GNU logs - #55937, boring messages

Message sent to bug-coreutils@HIDDEN:

Subject: bug#55937: [PATCH] touch: create parent directories if needed
Resent-From: Alan Rosenthal <alan.rosenthal@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Mon, 13 Jun 2022 04:33:01 +0000
Resent-Message-ID: <handler.55937.B.165509474015550 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55937 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Alan Rosenthal <alan.rosenthal@HIDDEN>
Date: Sun, 12 Jun 2022 22:05:40 -0400
Message-ID: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000c3759805e14abb5a"
Received-SPF: pass client-ip=2607:f8b0:4864:20::1029;
 envelope-from=alan.rosenthal@HIDDEN; helo=mail-pj1-x1029.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Mon, 13 Jun 2022 00:32:18 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--000000000000c3759805e14abb5a
Content-Type: text/plain; charset="UTF-8"

`touch a/b/c/d/e` will now be the same as running `mkdir -p a/b/c/d &&
touch a/b/c/d/e`.
Added an option --no-create-dirs to not create any directories.
---
 src/touch.c | 39 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 38 insertions(+), 1 deletion(-)

diff --git a/src/touch.c b/src/touch.c
index 21c247d0b..9034e8797 100644
--- a/src/touch.c
+++ b/src/touch.c
@@ -28,10 +28,12 @@
 #include "die.h"
 #include "error.h"
 #include "fd-reopen.h"
+#include "mkancesdirs.h"
 #include "parse-datetime.h"
 #include "posixtm.h"
 #include "posixver.h"
 #include "quote.h"
+#include "savewd.h"
 #include "stat-time.h"
 #include "utimens.h"

@@ -55,6 +57,9 @@ static int change_times;
 /* (-c) If true, don't create if not already there.  */
 static bool no_create;

+/* (-c) If true, don't create directories if not already there.  */
+static bool no_create_dirs;
+
 /* (-r) If true, use times from a reference file.  */
 static bool use_ref;

@@ -88,6 +93,7 @@ static struct option const longopts[] =
   {"date", required_argument, NULL, 'd'},
   {"reference", required_argument, NULL, 'r'},
   {"no-dereference", no_argument, NULL, 'h'},
+  {"no_create_dirs", no_argument, NULL, 'i'},
   {GETOPT_HELP_OPTION_DECL},
   {GETOPT_VERSION_OPTION_DECL},
   {NULL, 0, NULL, 0}
@@ -116,6 +122,14 @@ get_reldate (struct timespec *result,
     die (EXIT_FAILURE, 0, _("invalid date format %s"), quote (flex_date));
 }

+/* Create directory, called by mkancesdirs(). */
+
+static int
+make_dir(char const * file, char const * component, void * arg)
+{
+  return mkdir(component, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH);
+}
+
 /* Update the time of file FILE according to the options given.
    Return true if successful.  */

@@ -130,6 +144,25 @@ touch (char const *file)
     fd = STDOUT_FILENO;
   else if (! (no_create || no_dereference))
     {
+      if (! no_create_dirs)
+        {
+          struct savewd wd;
+          savewd_init(&wd);
+          ptrdiff_t ret = mkancesdirs((char*) file, &wd, make_dir, NULL);
+          if (ret == -1)
+            {
+              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
+              return false;
+            }
+          int r = savewd_restore(&wd, 0);
+          if (r < 0)
+            {
+              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
+              return false;
+            }
+          savewd_finish(&wd);
+        }
+
       /* Try to open FILE, creating it if necessary.  */
       fd = fd_reopen (STDIN_FILENO, file,
                       O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY,
MODE_RW_UGO);
@@ -276,7 +309,7 @@ main (int argc, char **argv)
   change_times = 0;
   no_create = use_ref = false;

-  while ((c = getopt_long (argc, argv, "acd:fhmr:t:", longopts, NULL)) !=
-1)
+  while ((c = getopt_long (argc, argv, "acd:fhimr:t:", longopts, NULL)) !=
-1)
     {
       switch (c)
         {
@@ -299,6 +332,10 @@ main (int argc, char **argv)
           no_dereference = true;
           break;

+        case 'i':
+          no_create_dirs = true;
+          break;
+
         case 'm':
           change_times |= CH_MTIME;
           break;
-- 
2.20.1

--000000000000c3759805e14abb5a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">`touch a/b/c/d/e` will now be the same as running `mkdir -=
p a/b/c/d &amp;&amp;<br>touch a/b/c/d/e`.<br>Added an option --no-create-di=
rs to not create any directories.<br>---<br>=C2=A0src/touch.c | 39 ++++++++=
++++++++++++++++++++++++++++++-<br>=C2=A01 file changed, 38 insertions(+), =
1 deletion(-)<br><br>diff --git a/src/touch.c b/src/touch.c<br>index 21c247=
d0b..9034e8797 100644<br>--- a/src/touch.c<br>+++ b/src/touch.c<br>@@ -28,1=
0 +28,12 @@<br>=C2=A0#include &quot;die.h&quot;<br>=C2=A0#include &quot;err=
or.h&quot;<br>=C2=A0#include &quot;fd-reopen.h&quot;<br>+#include &quot;mka=
ncesdirs.h&quot;<br>=C2=A0#include &quot;parse-datetime.h&quot;<br>=C2=A0#i=
nclude &quot;posixtm.h&quot;<br>=C2=A0#include &quot;posixver.h&quot;<br>=
=C2=A0#include &quot;quote.h&quot;<br>+#include &quot;savewd.h&quot;<br>=C2=
=A0#include &quot;stat-time.h&quot;<br>=C2=A0#include &quot;utimens.h&quot;=
<br>=C2=A0<br>@@ -55,6 +57,9 @@ static int change_times;<br>=C2=A0/* (-c) I=
f true, don&#39;t create if not already there. =C2=A0*/<br>=C2=A0static boo=
l no_create;<br>=C2=A0<br>+/* (-c) If true, don&#39;t create directories if=
 not already there. =C2=A0*/<br>+static bool no_create_dirs;<br>+<br>=C2=A0=
/* (-r) If true, use times from a reference file. =C2=A0*/<br>=C2=A0static =
bool use_ref;<br>=C2=A0<br>@@ -88,6 +93,7 @@ static struct option const lon=
gopts[] =3D<br>=C2=A0 =C2=A0{&quot;date&quot;, required_argument, NULL, &#3=
9;d&#39;},<br>=C2=A0 =C2=A0{&quot;reference&quot;, required_argument, NULL,=
 &#39;r&#39;},<br>=C2=A0 =C2=A0{&quot;no-dereference&quot;, no_argument, NU=
LL, &#39;h&#39;},<br>+ =C2=A0{&quot;no_create_dirs&quot;, no_argument, NULL=
, &#39;i&#39;},<br>=C2=A0 =C2=A0{GETOPT_HELP_OPTION_DECL},<br>=C2=A0 =C2=A0=
{GETOPT_VERSION_OPTION_DECL},<br>=C2=A0 =C2=A0{NULL, 0, NULL, 0}<br>@@ -116=
,6 +122,14 @@ get_reldate (struct timespec *result,<br>=C2=A0 =C2=A0 =C2=A0=
die (EXIT_FAILURE, 0, _(&quot;invalid date format %s&quot;), quote (flex_da=
te));<br>=C2=A0}<br>=C2=A0<br>+/* Create directory, called by mkancesdirs()=
. */<br>+<br>+static int<br>+make_dir(char const * file, char const * compo=
nent, void * arg)<br>+{<br>+ =C2=A0return mkdir(component, S_IRWXU | S_IRGR=
P | S_IXGRP | S_IROTH | S_IXOTH);<br>+}<br>+<br>=C2=A0/* Update the time of=
 file FILE according to the options given.<br>=C2=A0 =C2=A0 Return true if =
successful. =C2=A0*/<br>=C2=A0<br>@@ -130,6 +144,25 @@ touch (char const *f=
ile)<br>=C2=A0 =C2=A0 =C2=A0fd =3D STDOUT_FILENO;<br>=C2=A0 =C2=A0else if (=
! (no_create || no_dereference))<br>=C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=
=A0 =C2=A0if (! no_create_dirs)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct savewd wd;<br>+ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0savewd_init(&amp;wd);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p=
trdiff_t ret =3D mkancesdirs((char*) file, &amp;wd, make_dir, NULL);<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D -1)<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0error (0, open_errno, _(&quot;cannot mkdir %s&quot;), quoteaf (file))=
;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return false;<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0int r =3D savewd_restore(&amp;wd, 0);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0if (r &lt; 0)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>=
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error (0, open_errno, _(&=
quot;cannot mkdir %s&quot;), quoteaf (file));<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0return false;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0savewd_finish(&amp;wd);<=
br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Try=
 to open FILE, creating it if necessary. =C2=A0*/<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0fd =3D fd_reopen (STDIN_FILENO, file,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0O_WRONLY | O_CREAT |=
 O_NONBLOCK | O_NOCTTY, MODE_RW_UGO);<br>@@ -276,7 +309,7 @@ main (int argc=
, char **argv)<br>=C2=A0 =C2=A0change_times =3D 0;<br>=C2=A0 =C2=A0no_creat=
e =3D use_ref =3D false;<br>=C2=A0<br>- =C2=A0while ((c =3D getopt_long (ar=
gc, argv, &quot;acd:fhmr:t:&quot;, longopts, NULL)) !=3D -1)<br>+ =C2=A0whi=
le ((c =3D getopt_long (argc, argv, &quot;acd:fhimr:t:&quot;, longopts, NUL=
L)) !=3D -1)<br>=C2=A0 =C2=A0 =C2=A0{<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0switch =
(c)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>@@ -299,6 +332,10 @@ main (in=
t argc, char **argv)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0no_derefer=
ence =3D true;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br>=C2=A0=
<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39;i&#39;:<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0no_create_dirs =3D true;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0break;<br>+<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39;m&#39;:<br=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0change_times |=3D CH_MTIME;<br>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br>-- <br>2.20.1<br><br></d=
iv>

--000000000000c3759805e14abb5a--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Alan Rosenthal <alan.rosenthal@HIDDEN>
Subject: bug#55937: Acknowledgement ([PATCH] touch: create parent
 directories if needed)
Message-ID: <handler.55937.B.165509474015550.ack <at> debbugs.gnu.org>
References: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
X-Gnu-PR-Message: ack 55937
X-Gnu-PR-Package: coreutils
X-Gnu-PR-Keywords: patch
Reply-To: 55937 <at> debbugs.gnu.org
Date: Mon, 13 Jun 2022 04:33:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-coreutils@HIDDEN

If you wish to submit further information on this problem, please
send it to 55937 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
55937: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55937
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-coreutils@HIDDEN:

Subject: bug#55937: [PATCH] touch: create parent directories if needed
Resent-From: Alan Rosenthal <alan.rosenthal@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Mon, 13 Jun 2022 11:54:01 +0000
Resent-Message-ID: <handler.55937.B.165512121313682 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55937 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
In-Reply-To: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
From: Alan Rosenthal <alan.rosenthal@HIDDEN>
Date: Mon, 13 Jun 2022 07:52:47 -0400
Message-ID: <CABEWFW9+oseQjHuGAhVLm9uGeDXdziOTgiKMTb4gD-guoz3-pA@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000006458b805e152ef45"
Received-SPF: pass client-ip=2607:f8b0:4864:20::62b;
 envelope-from=alan.rosenthal@HIDDEN; helo=mail-pl1-x62b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--0000000000006458b805e152ef45
Content-Type: text/plain; charset="UTF-8"

`touch a/b/c/d/e` will now be the same as running `mkdir -p a/b/c/d &&
touch a/b/c/d/e`.
Added an option --no-create-dirs to not create any directories.
---
 src/touch.c | 40 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/src/touch.c b/src/touch.c
index 21c247d0b..557530f79 100644
--- a/src/touch.c
+++ b/src/touch.c
@@ -28,10 +28,12 @@
 #include "die.h"
 #include "error.h"
 #include "fd-reopen.h"
+#include "mkancesdirs.h"
 #include "parse-datetime.h"
 #include "posixtm.h"
 #include "posixver.h"
 #include "quote.h"
+#include "savewd.h"
 #include "stat-time.h"
 #include "utimens.h"

@@ -55,6 +57,9 @@ static int change_times;
 /* (-c) If true, don't create if not already there.  */
 static bool no_create;

+/* (-c) If true, don't create directories if not already there.  */
+static bool no_create_dirs;
+
 /* (-r) If true, use times from a reference file.  */
 static bool use_ref;

@@ -88,6 +93,7 @@ static struct option const longopts[] =
   {"date", required_argument, NULL, 'd'},
   {"reference", required_argument, NULL, 'r'},
   {"no-dereference", no_argument, NULL, 'h'},
+  {"no-create-dirs", no_argument, NULL, 'i'},
   {GETOPT_HELP_OPTION_DECL},
   {GETOPT_VERSION_OPTION_DECL},
   {NULL, 0, NULL, 0}
@@ -116,6 +122,14 @@ get_reldate (struct timespec *result,
     die (EXIT_FAILURE, 0, _("invalid date format %s"), quote (flex_date));
 }

+/* Create directory, called by mkancesdirs(). */
+
+static int
+make_dir(char const * file, char const * component, void * arg)
+{
+  return mkdir(component, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH);
+}
+
 /* Update the time of file FILE according to the options given.
    Return true if successful.  */

@@ -130,6 +144,25 @@ touch (char const *file)
     fd = STDOUT_FILENO;
   else if (! (no_create || no_dereference))
     {
+      if (! no_create_dirs)
+        {
+          struct savewd wd;
+          savewd_init(&wd);
+          ptrdiff_t ret = mkancesdirs((char*) file, &wd, make_dir, NULL);
+          if (ret == -1)
+            {
+              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
+              return false;
+            }
+          int r = savewd_restore(&wd, 0);
+          if (r < 0)
+            {
+              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
+              return false;
+            }
+          savewd_finish(&wd);
+        }
+
       /* Try to open FILE, creating it if necessary.  */
       fd = fd_reopen (STDIN_FILENO, file,
                       O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY,
MODE_RW_UGO);
@@ -234,6 +267,7 @@ change the times of the file associated with standard
output.\n\
   -f                     (ignored)\n\
 "), stdout);
       fputs (_("\
+  -i, --no-create-dirs   do not create any required parent directories\n\
   -h, --no-dereference   affect each symbolic link instead of any
referenced\n\
                          file (useful only on systems that can change
the\n\
                          timestamps of a symlink)\n\
@@ -276,7 +310,7 @@ main (int argc, char **argv)
   change_times = 0;
   no_create = use_ref = false;

-  while ((c = getopt_long (argc, argv, "acd:fhmr:t:", longopts, NULL)) !=
-1)
+  while ((c = getopt_long (argc, argv, "acd:fhimr:t:", longopts, NULL)) !=
-1)
     {
       switch (c)
         {
@@ -299,6 +333,10 @@ main (int argc, char **argv)
           no_dereference = true;
           break;

+        case 'i':
+          no_create_dirs = true;
+          break;
+
         case 'm':
           change_times |= CH_MTIME;
           break;
-- 
2.20.1

On Sun, Jun 12, 2022 at 10:05 PM Alan Rosenthal <alan.rosenthal@HIDDEN>
wrote:

> `touch a/b/c/d/e` will now be the same as running `mkdir -p a/b/c/d &&
> touch a/b/c/d/e`.
> Added an option --no-create-dirs to not create any directories.
> ---
>  src/touch.c | 39 ++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/src/touch.c b/src/touch.c
> index 21c247d0b..9034e8797 100644
> --- a/src/touch.c
> +++ b/src/touch.c
> @@ -28,10 +28,12 @@
>  #include "die.h"
>  #include "error.h"
>  #include "fd-reopen.h"
> +#include "mkancesdirs.h"
>  #include "parse-datetime.h"
>  #include "posixtm.h"
>  #include "posixver.h"
>  #include "quote.h"
> +#include "savewd.h"
>  #include "stat-time.h"
>  #include "utimens.h"
>
> @@ -55,6 +57,9 @@ static int change_times;
>  /* (-c) If true, don't create if not already there.  */
>  static bool no_create;
>
> +/* (-c) If true, don't create directories if not already there.  */
> +static bool no_create_dirs;
> +
>  /* (-r) If true, use times from a reference file.  */
>  static bool use_ref;
>
> @@ -88,6 +93,7 @@ static struct option const longopts[] =
>    {"date", required_argument, NULL, 'd'},
>    {"reference", required_argument, NULL, 'r'},
>    {"no-dereference", no_argument, NULL, 'h'},
> +  {"no_create_dirs", no_argument, NULL, 'i'},
>    {GETOPT_HELP_OPTION_DECL},
>    {GETOPT_VERSION_OPTION_DECL},
>    {NULL, 0, NULL, 0}
> @@ -116,6 +122,14 @@ get_reldate (struct timespec *result,
>      die (EXIT_FAILURE, 0, _("invalid date format %s"), quote (flex_date));
>  }
>
> +/* Create directory, called by mkancesdirs(). */
> +
> +static int
> +make_dir(char const * file, char const * component, void * arg)
> +{
> +  return mkdir(component, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH |
> S_IXOTH);
> +}
> +
>  /* Update the time of file FILE according to the options given.
>     Return true if successful.  */
>
> @@ -130,6 +144,25 @@ touch (char const *file)
>      fd = STDOUT_FILENO;
>    else if (! (no_create || no_dereference))
>      {
> +      if (! no_create_dirs)
> +        {
> +          struct savewd wd;
> +          savewd_init(&wd);
> +          ptrdiff_t ret = mkancesdirs((char*) file, &wd, make_dir, NULL);
> +          if (ret == -1)
> +            {
> +              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
> +              return false;
> +            }
> +          int r = savewd_restore(&wd, 0);
> +          if (r < 0)
> +            {
> +              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
> +              return false;
> +            }
> +          savewd_finish(&wd);
> +        }
> +
>        /* Try to open FILE, creating it if necessary.  */
>        fd = fd_reopen (STDIN_FILENO, file,
>                        O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY,
> MODE_RW_UGO);
> @@ -276,7 +309,7 @@ main (int argc, char **argv)
>    change_times = 0;
>    no_create = use_ref = false;
>
> -  while ((c = getopt_long (argc, argv, "acd:fhmr:t:", longopts, NULL)) !=
> -1)
> +  while ((c = getopt_long (argc, argv, "acd:fhimr:t:", longopts, NULL))
> != -1)
>      {
>        switch (c)
>          {
> @@ -299,6 +332,10 @@ main (int argc, char **argv)
>            no_dereference = true;
>            break;
>
> +        case 'i':
> +          no_create_dirs = true;
> +          break;
> +
>          case 'm':
>            change_times |= CH_MTIME;
>            break;
> --
> 2.20.1
>
>

--0000000000006458b805e152ef45
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">`touch a/b/c/d/e` will now be the same as running `mkdir -=
p a/b/c/d &amp;&amp;<br>touch a/b/c/d/e`.<br>Added an option --no-create-di=
rs to not create any directories.<br>---<br>=C2=A0src/touch.c | 40 ++++++++=
+++++++++++++++++++++++++++++++-<br>=C2=A01 file changed, 39 insertions(+),=
 1 deletion(-)<br><br>diff --git a/src/touch.c b/src/touch.c<br>index 21c24=
7d0b..557530f79 100644<br>--- a/src/touch.c<br>+++ b/src/touch.c<br>@@ -28,=
10 +28,12 @@<br>=C2=A0#include &quot;die.h&quot;<br>=C2=A0#include &quot;er=
ror.h&quot;<br>=C2=A0#include &quot;fd-reopen.h&quot;<br>+#include &quot;mk=
ancesdirs.h&quot;<br>=C2=A0#include &quot;parse-datetime.h&quot;<br>=C2=A0#=
include &quot;posixtm.h&quot;<br>=C2=A0#include &quot;posixver.h&quot;<br>=
=C2=A0#include &quot;quote.h&quot;<br>+#include &quot;savewd.h&quot;<br>=C2=
=A0#include &quot;stat-time.h&quot;<br>=C2=A0#include &quot;utimens.h&quot;=
<br>=C2=A0<br>@@ -55,6 +57,9 @@ static int change_times;<br>=C2=A0/* (-c) I=
f true, don&#39;t create if not already there. =C2=A0*/<br>=C2=A0static boo=
l no_create;<br>=C2=A0<br>+/* (-c) If true, don&#39;t create directories if=
 not already there. =C2=A0*/<br>+static bool no_create_dirs;<br>+<br>=C2=A0=
/* (-r) If true, use times from a reference file. =C2=A0*/<br>=C2=A0static =
bool use_ref;<br>=C2=A0<br>@@ -88,6 +93,7 @@ static struct option const lon=
gopts[] =3D<br>=C2=A0 =C2=A0{&quot;date&quot;, required_argument, NULL, &#3=
9;d&#39;},<br>=C2=A0 =C2=A0{&quot;reference&quot;, required_argument, NULL,=
 &#39;r&#39;},<br>=C2=A0 =C2=A0{&quot;no-dereference&quot;, no_argument, NU=
LL, &#39;h&#39;},<br>+ =C2=A0{&quot;no-create-dirs&quot;, no_argument, NULL=
, &#39;i&#39;},<br>=C2=A0 =C2=A0{GETOPT_HELP_OPTION_DECL},<br>=C2=A0 =C2=A0=
{GETOPT_VERSION_OPTION_DECL},<br>=C2=A0 =C2=A0{NULL, 0, NULL, 0}<br>@@ -116=
,6 +122,14 @@ get_reldate (struct timespec *result,<br>=C2=A0 =C2=A0 =C2=A0=
die (EXIT_FAILURE, 0, _(&quot;invalid date format %s&quot;), quote (flex_da=
te));<br>=C2=A0}<br>=C2=A0<br>+/* Create directory, called by mkancesdirs()=
. */<br>+<br>+static int<br>+make_dir(char const * file, char const * compo=
nent, void * arg)<br>+{<br>+ =C2=A0return mkdir(component, S_IRWXU | S_IRGR=
P | S_IXGRP | S_IROTH | S_IXOTH);<br>+}<br>+<br>=C2=A0/* Update the time of=
 file FILE according to the options given.<br>=C2=A0 =C2=A0 Return true if =
successful. =C2=A0*/<br>=C2=A0<br>@@ -130,6 +144,25 @@ touch (char const *f=
ile)<br>=C2=A0 =C2=A0 =C2=A0fd =3D STDOUT_FILENO;<br>=C2=A0 =C2=A0else if (=
! (no_create || no_dereference))<br>=C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=
=A0 =C2=A0if (! no_create_dirs)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct savewd wd;<br>+ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0savewd_init(&amp;wd);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p=
trdiff_t ret =3D mkancesdirs((char*) file, &amp;wd, make_dir, NULL);<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D -1)<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0error (0, open_errno, _(&quot;cannot mkdir %s&quot;), quoteaf (file))=
;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return false;<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0int r =3D savewd_restore(&amp;wd, 0);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0if (r &lt; 0)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>=
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error (0, open_errno, _(&=
quot;cannot mkdir %s&quot;), quoteaf (file));<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0return false;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0savewd_finish(&amp;wd);<=
br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Try=
 to open FILE, creating it if necessary. =C2=A0*/<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0fd =3D fd_reopen (STDIN_FILENO, file,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0O_WRONLY | O_CREAT |=
 O_NONBLOCK | O_NOCTTY, MODE_RW_UGO);<br>@@ -234,6 +267,7 @@ change the tim=
es of the file associated with standard output.\n\<br>=C2=A0 =C2=A0-f =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (ignored=
)\n\<br>=C2=A0&quot;), stdout);<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0fputs (_(&quo=
t;\<br>+ =C2=A0-i, --no-create-dirs =C2=A0 do not create any required paren=
t directories\n\<br>=C2=A0 =C2=A0-h, --no-dereference =C2=A0 affect each sy=
mbolic link instead of any referenced\n\<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 file (useful on=
ly on systems that can change the\n\<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 timestamps of a sym=
link)\n\<br>@@ -276,7 +310,7 @@ main (int argc, char **argv)<br>=C2=A0 =C2=
=A0change_times =3D 0;<br>=C2=A0 =C2=A0no_create =3D use_ref =3D false;<br>=
=C2=A0<br>- =C2=A0while ((c =3D getopt_long (argc, argv, &quot;acd:fhmr:t:&=
quot;, longopts, NULL)) !=3D -1)<br>+ =C2=A0while ((c =3D getopt_long (argc=
, argv, &quot;acd:fhimr:t:&quot;, longopts, NULL)) !=3D -1)<br>=C2=A0 =C2=
=A0 =C2=A0{<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0switch (c)<br>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0{<br>@@ -299,6 +333,10 @@ main (int argc, char **argv)<br>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0no_dereference =3D true;<br>=C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br>=C2=A0<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0case &#39;i&#39;:<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0no_creat=
e_dirs =3D true;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br>+<br>=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39;m&#39;:<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0change_times |=3D CH_MTIME;<br>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0break;<br><div>-- <br>2.20.1<br></div></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Jun 12, 2022=
 at 10:05 PM Alan Rosenthal &lt;<a href=3D"mailto:alan.rosenthal@HIDDEN"=
>alan.rosenthal@HIDDEN</a>&gt; wrote:<br></div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex"><div dir=3D"ltr">`touch a/b/c/d/e` will now be the=
 same as running `mkdir -p a/b/c/d &amp;&amp;<br>touch a/b/c/d/e`.<br>Added=
 an option --no-create-dirs to not create any directories.<br>---<br>=C2=A0=
src/touch.c | 39 ++++++++++++++++++++++++++++++++++++++-<br>=C2=A01 file ch=
anged, 38 insertions(+), 1 deletion(-)<br><br>diff --git a/src/touch.c b/sr=
c/touch.c<br>index 21c247d0b..9034e8797 100644<br>--- a/src/touch.c<br>+++ =
b/src/touch.c<br>@@ -28,10 +28,12 @@<br>=C2=A0#include &quot;die.h&quot;<br=
>=C2=A0#include &quot;error.h&quot;<br>=C2=A0#include &quot;fd-reopen.h&quo=
t;<br>+#include &quot;mkancesdirs.h&quot;<br>=C2=A0#include &quot;parse-dat=
etime.h&quot;<br>=C2=A0#include &quot;posixtm.h&quot;<br>=C2=A0#include &qu=
ot;posixver.h&quot;<br>=C2=A0#include &quot;quote.h&quot;<br>+#include &quo=
t;savewd.h&quot;<br>=C2=A0#include &quot;stat-time.h&quot;<br>=C2=A0#includ=
e &quot;utimens.h&quot;<br>=C2=A0<br>@@ -55,6 +57,9 @@ static int change_ti=
mes;<br>=C2=A0/* (-c) If true, don&#39;t create if not already there. =C2=
=A0*/<br>=C2=A0static bool no_create;<br>=C2=A0<br>+/* (-c) If true, don&#3=
9;t create directories if not already there. =C2=A0*/<br>+static bool no_cr=
eate_dirs;<br>+<br>=C2=A0/* (-r) If true, use times from a reference file. =
=C2=A0*/<br>=C2=A0static bool use_ref;<br>=C2=A0<br>@@ -88,6 +93,7 @@ stati=
c struct option const longopts[] =3D<br>=C2=A0 =C2=A0{&quot;date&quot;, req=
uired_argument, NULL, &#39;d&#39;},<br>=C2=A0 =C2=A0{&quot;reference&quot;,=
 required_argument, NULL, &#39;r&#39;},<br>=C2=A0 =C2=A0{&quot;no-dereferen=
ce&quot;, no_argument, NULL, &#39;h&#39;},<br>+ =C2=A0{&quot;no_create_dirs=
&quot;, no_argument, NULL, &#39;i&#39;},<br>=C2=A0 =C2=A0{GETOPT_HELP_OPTIO=
N_DECL},<br>=C2=A0 =C2=A0{GETOPT_VERSION_OPTION_DECL},<br>=C2=A0 =C2=A0{NUL=
L, 0, NULL, 0}<br>@@ -116,6 +122,14 @@ get_reldate (struct timespec *result=
,<br>=C2=A0 =C2=A0 =C2=A0die (EXIT_FAILURE, 0, _(&quot;invalid date format =
%s&quot;), quote (flex_date));<br>=C2=A0}<br>=C2=A0<br>+/* Create directory=
, called by mkancesdirs(). */<br>+<br>+static int<br>+make_dir(char const *=
 file, char const * component, void * arg)<br>+{<br>+ =C2=A0return mkdir(co=
mponent, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH);<br>+}<br>+<br>=
=C2=A0/* Update the time of file FILE according to the options given.<br>=
=C2=A0 =C2=A0 Return true if successful. =C2=A0*/<br>=C2=A0<br>@@ -130,6 +1=
44,25 @@ touch (char const *file)<br>=C2=A0 =C2=A0 =C2=A0fd =3D STDOUT_FILE=
NO;<br>=C2=A0 =C2=A0else if (! (no_create || no_dereference))<br>=C2=A0 =C2=
=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0if (! no_create_dirs)<br>+ =C2=A0 =C2=
=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct savewd wd;=
<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0savewd_init(&amp;wd);<br>+ =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0ptrdiff_t ret =3D mkancesdirs((char*) file, &amp=
;wd, make_dir, NULL);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D=
 -1)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error (0, open_errno, _(&quot;cannot mkdir %=
s&quot;), quoteaf (file));<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0return false;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int r =3D savewd_restore(&amp;wd, 0);<br>=
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (r &lt; 0)<br>+ =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0error (0, open_errno, _(&quot;cannot mkdir %s&quot;), quoteaf (file));<b=
r>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return false;<br>+ =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0savewd_finish(&amp;wd);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+<br>=C2=
=A0 =C2=A0 =C2=A0 =C2=A0/* Try to open FILE, creating it if necessary. =C2=
=A0*/<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0fd =3D fd_reopen (STDIN_FILENO, file,<b=
r>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY, MODE_RW_UGO);<br>@@ -=
276,7 +309,7 @@ main (int argc, char **argv)<br>=C2=A0 =C2=A0change_times =
=3D 0;<br>=C2=A0 =C2=A0no_create =3D use_ref =3D false;<br>=C2=A0<br>- =C2=
=A0while ((c =3D getopt_long (argc, argv, &quot;acd:fhmr:t:&quot;, longopts=
, NULL)) !=3D -1)<br>+ =C2=A0while ((c =3D getopt_long (argc, argv, &quot;a=
cd:fhimr:t:&quot;, longopts, NULL)) !=3D -1)<br>=C2=A0 =C2=A0 =C2=A0{<br>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0switch (c)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
{<br>@@ -299,6 +332,10 @@ main (int argc, char **argv)<br>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0no_dereference =3D true;<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0break;<br>=C2=A0<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0case &=
#39;i&#39;:<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0no_create_dirs =3D true;=
<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br>+<br>=C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0case &#39;m&#39;:<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0change_times |=3D CH_MTIME;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
break;<br>-- <br>2.20.1<br><br></div>
</blockquote></div>

--0000000000006458b805e152ef45--

Message sent to bug-coreutils@HIDDEN:

Subject: bug#55937: [PATCH] touch: create parent directories if needed
References: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
In-Reply-To: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
Resent-From: David Hilton <david.hilton.p@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Mon, 13 Jun 2022 14:20:01 +0000
Resent-Message-ID: <handler.55937.B55937.16551299938906 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55937 <at> debbugs.gnu.org
MIME-Version: 1.0
From: David Hilton <david.hilton.p@HIDDEN>
Date: Mon, 13 Jun 2022 06:55:31 -0600
Message-ID: <CALJCVT0zNS4=-03BPtqdYWDXLq_rWQkpNShqdfb4Di2PMvQ=Ug@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000002ce30e05e153cfb1"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--0000000000002ce30e05e153cfb1
Content-Type: text/plain; charset="UTF-8"

I don't like this as the default behavior. If this feature is added, it
should be optional, and enabled with -p, like mkdir.

David

--0000000000002ce30e05e153cfb1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>I don&#39;t like this as the default behavior. If thi=
s feature is added, it should be optional, and enabled with -p, like mkdir.=
<br></div><div><br></div><div><div dir=3D"ltr" class=3D"gmail_signature" da=
ta-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div>David</div></div></d=
iv></div></div>

--0000000000002ce30e05e153cfb1--

Message sent to bug-coreutils@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#55937: [PATCH] touch: create parent directories if needed
Resent-From: Alan Rosenthal <alan.rosenthal@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Wed, 15 Jun 2022 00:22:01 +0000
Resent-Message-ID: <handler.55937.B.165525248827847 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55937
X-GNU-PR-Package: coreutils
X-GNU-PR-Keywords: patch
To: 55937 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-coreutils@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.165525248827847
          (code B ref -1); Wed, 15 Jun 2022 00:22:01 +0000
Received: (at submit) by debbugs.gnu.org; 15 Jun 2022 00:21:28 +0000
Received: from localhost ([127.0.0.1]:36080 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o1Gml-0007F4-7a
	for submit <at> debbugs.gnu.org; Tue, 14 Jun 2022 20:21:28 -0400
Received: from lists.gnu.org ([209.51.188.17]:56614)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <alan.rosenthal@HIDDEN>) id 1o1Gmg-0007Et-Q3
 for submit <at> debbugs.gnu.org; Tue, 14 Jun 2022 20:21:26 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:50114)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <alan.rosenthal@HIDDEN>)
 id 1o1Gmf-0006Rs-U8
 for bug-coreutils@HIDDEN; Tue, 14 Jun 2022 20:21:22 -0400
Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:34682)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <alan.rosenthal@HIDDEN>)
 id 1o1Gmd-0004i3-01
 for bug-coreutils@HIDDEN; Tue, 14 Jun 2022 20:21:21 -0400
Received: by mail-pf1-x42b.google.com with SMTP id c196so9988878pfb.1
 for <bug-coreutils@HIDDEN>; Tue, 14 Jun 2022 17:21:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=9mh7EDG3rRA7Ur9x2wdwN4CgkpPNDGFKKJq2yiPl9W4=;
 b=p8RNqvzEfOrLsCswehIn07oXJaTpsmaMKaLCidxqJxJyEveKwuK1bZkxgqT3sUKLST
 +zGH/03rV885tjyHoYXcj72T//T4oo87xhViSs4kdaYjSVwAjaxyuJ4+lAma87yJke9Q
 DI8maRs8PF2iwHcEJ3H2YF5a1Jm4N2c5KLNwyTV3Bir1DNV/EX7TGQTW5Drz1OPCM7oh
 87hiOLmN6eE3Bz+CLzX25gA8Np/DfKqf04VOmdFT3Plm6e5NtVicb8DxAw52yYKngewZ
 JsU9OIE0oC9CJk4pi94GeteE8xcSpGMHK0R40fHMedOPWpgAomUnhLiLQ91P2pGcfuer
 JsjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=9mh7EDG3rRA7Ur9x2wdwN4CgkpPNDGFKKJq2yiPl9W4=;
 b=a7y5mDmYrnjgc05Gpdh2tWVY1DMmcj/9qUeccgs4Z/gMCVbveUXp1lfNH1tP6L5EEb
 BepFsKnESmdE0KJg0Mky3tpJLtGIMZ008C+fkK6mJzo88xJUJY122h5tNENFgDbQyQRp
 yYePcD5rk1L8dXCDzWFtv6/+faMIh2X17DrWLnCGRQ57y7lrPdgAdewGZV6M4CaRgSbM
 ez0VURRbTiaCsxv0/1HbHurq48TmrlomuRx12AHxcogXSzh0hwSerQdd+Nrqw0TF1bvP
 2NAbiQZAZi6UGJ/Ow7kpTMt4ZoDwww910CxvqNWe3+935yjJUfD/YaSOMBR+k/kdY2H6
 qcoA==
X-Gm-Message-State: AJIora9CxdI+IeLd29PEp+cbVMLmn8xONv7sre5t3oxhmdaArJ8BF9uV
 qJy1ZszUxG7bk9y0enNWjXu6NdCRO4yq+NIE71KHDJ/kVp4=
X-Google-Smtp-Source: AGRyM1vwbm6tvJOj4EDvb17OeYeNHv+pZ9NYA7np1J7TaZvfS9HXUwDAiDOiGU8QPSYtmeQj2koulrd27CWxu6t6AIY=
X-Received: by 2002:a63:7946:0:b0:408:c6ac:939b with SMTP id
 u67-20020a637946000000b00408c6ac939bmr573737pgc.349.1655252476279; Tue, 14
 Jun 2022 17:21:16 -0700 (PDT)
MIME-Version: 1.0
References: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
 <CABEWFW9+oseQjHuGAhVLm9uGeDXdziOTgiKMTb4gD-guoz3-pA@HIDDEN>
In-Reply-To: <CABEWFW9+oseQjHuGAhVLm9uGeDXdziOTgiKMTb4gD-guoz3-pA@HIDDEN>
From: Alan Rosenthal <alan.rosenthal@HIDDEN>
Date: Tue, 14 Jun 2022 20:20:40 -0400
Message-ID: <CABEWFW-Cb-8k4TrS6PERny7K2uM0tcjNYshi2MH2PYovvxUS4Q@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000dcbf2205e1717f1f"
Received-SPF: pass client-ip=2607:f8b0:4864:20::42b;
 envelope-from=alan.rosenthal@HIDDEN; helo=mail-pf1-x42b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--000000000000dcbf2205e1717f1f
Content-Type: text/plain; charset="UTF-8"

`touch -p a/b/c/d/e` will now be the same as running:
`mkdir -p a/b/c/d && touch a/b/c/d/e`.

Added an option -p/--create-dirs to create any required directories.
Default behavior remains the same.
---
 src/touch.c | 40 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/src/touch.c b/src/touch.c
index 21c247d0b..543f92b41 100644
--- a/src/touch.c
+++ b/src/touch.c
@@ -28,10 +28,12 @@
 #include "die.h"
 #include "error.h"
 #include "fd-reopen.h"
+#include "mkancesdirs.h"
 #include "parse-datetime.h"
 #include "posixtm.h"
 #include "posixver.h"
 #include "quote.h"
+#include "savewd.h"
 #include "stat-time.h"
 #include "utimens.h"

@@ -55,6 +57,9 @@ static int change_times;
 /* (-c) If true, don't create if not already there.  */
 static bool no_create;

+/* (-p) If true, create directories if not already there.  */
+static bool create_dirs;
+
 /* (-r) If true, use times from a reference file.  */
 static bool use_ref;

@@ -88,6 +93,7 @@ static struct option const longopts[] =
   {"date", required_argument, NULL, 'd'},
   {"reference", required_argument, NULL, 'r'},
   {"no-dereference", no_argument, NULL, 'h'},
+  {"create-dirs", no_argument, NULL, 'p'},
   {GETOPT_HELP_OPTION_DECL},
   {GETOPT_VERSION_OPTION_DECL},
   {NULL, 0, NULL, 0}
@@ -116,6 +122,14 @@ get_reldate (struct timespec *result,
     die (EXIT_FAILURE, 0, _("invalid date format %s"), quote (flex_date));
 }

+/* Create directory, called by mkancesdirs(). */
+
+static int
+make_dir(char const * file, char const * component, void * arg)
+{
+  return mkdir(component, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH);
+}
+
 /* Update the time of file FILE according to the options given.
    Return true if successful.  */

@@ -130,6 +144,25 @@ touch (char const *file)
     fd = STDOUT_FILENO;
   else if (! (no_create || no_dereference))
     {
+      if (create_dirs)
+        {
+          struct savewd wd;
+          savewd_init(&wd);
+          ptrdiff_t ret = mkancesdirs((char*) file, &wd, make_dir, NULL);
+          if (ret == -1)
+            {
+              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
+              return false;
+            }
+          int r = savewd_restore(&wd, 0);
+          if (r < 0)
+            {
+              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
+              return false;
+            }
+          savewd_finish(&wd);
+        }
+
       /* Try to open FILE, creating it if necessary.  */
       fd = fd_reopen (STDIN_FILENO, file,
                       O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY,
MODE_RW_UGO);
@@ -240,6 +273,7 @@ change the times of the file associated with standard
output.\n\
   -m                     change only the modification time\n\
 "), stdout);
       fputs (_("\
+  -p, --create-dirs      create any required parent directories\n\
   -r, --reference=FILE   use this file's times instead of current time\n\
   -t STAMP               use [[CC]YY]MMDDhhmm[.ss] instead of current
time\n\
       --time=WORD        change the specified time:\n\
@@ -276,7 +310,7 @@ main (int argc, char **argv)
   change_times = 0;
   no_create = use_ref = false;

-  while ((c = getopt_long (argc, argv, "acd:fhmr:t:", longopts, NULL)) !=
-1)
+  while ((c = getopt_long (argc, argv, "acd:fhmpr:t:", longopts, NULL)) !=
-1)
     {
       switch (c)
         {
@@ -303,6 +337,10 @@ main (int argc, char **argv)
           change_times |= CH_MTIME;
           break;

+        case 'p':
+          create_dirs = true;
+          break;
+
         case 'r':
           use_ref = true;
           ref_file = optarg;
-- 
2.20.1


On Mon, Jun 13, 2022 at 7:52 AM Alan Rosenthal <alan.rosenthal@HIDDEN>
wrote:

> `touch a/b/c/d/e` will now be the same as running `mkdir -p a/b/c/d &&
> touch a/b/c/d/e`.
> Added an option --no-create-dirs to not create any directories.
> ---
>  src/touch.c | 40 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 39 insertions(+), 1 deletion(-)
>
> diff --git a/src/touch.c b/src/touch.c
> index 21c247d0b..557530f79 100644
> --- a/src/touch.c
> +++ b/src/touch.c
> @@ -28,10 +28,12 @@
>  #include "die.h"
>  #include "error.h"
>  #include "fd-reopen.h"
> +#include "mkancesdirs.h"
>  #include "parse-datetime.h"
>  #include "posixtm.h"
>  #include "posixver.h"
>  #include "quote.h"
> +#include "savewd.h"
>  #include "stat-time.h"
>  #include "utimens.h"
>
> @@ -55,6 +57,9 @@ static int change_times;
>  /* (-c) If true, don't create if not already there.  */
>  static bool no_create;
>
> +/* (-c) If true, don't create directories if not already there.  */
> +static bool no_create_dirs;
> +
>  /* (-r) If true, use times from a reference file.  */
>  static bool use_ref;
>
> @@ -88,6 +93,7 @@ static struct option const longopts[] =
>    {"date", required_argument, NULL, 'd'},
>    {"reference", required_argument, NULL, 'r'},
>    {"no-dereference", no_argument, NULL, 'h'},
> +  {"no-create-dirs", no_argument, NULL, 'i'},
>    {GETOPT_HELP_OPTION_DECL},
>    {GETOPT_VERSION_OPTION_DECL},
>    {NULL, 0, NULL, 0}
> @@ -116,6 +122,14 @@ get_reldate (struct timespec *result,
>      die (EXIT_FAILURE, 0, _("invalid date format %s"), quote (flex_date));
>  }
>
> +/* Create directory, called by mkancesdirs(). */
> +
> +static int
> +make_dir(char const * file, char const * component, void * arg)
> +{
> +  return mkdir(component, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH |
> S_IXOTH);
> +}
> +
>  /* Update the time of file FILE according to the options given.
>     Return true if successful.  */
>
> @@ -130,6 +144,25 @@ touch (char const *file)
>      fd = STDOUT_FILENO;
>    else if (! (no_create || no_dereference))
>      {
> +      if (! no_create_dirs)
> +        {
> +          struct savewd wd;
> +          savewd_init(&wd);
> +          ptrdiff_t ret = mkancesdirs((char*) file, &wd, make_dir, NULL);
> +          if (ret == -1)
> +            {
> +              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
> +              return false;
> +            }
> +          int r = savewd_restore(&wd, 0);
> +          if (r < 0)
> +            {
> +              error (0, open_errno, _("cannot mkdir %s"), quoteaf (file));
> +              return false;
> +            }
> +          savewd_finish(&wd);
> +        }
> +
>        /* Try to open FILE, creating it if necessary.  */
>        fd = fd_reopen (STDIN_FILENO, file,
>                        O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY,
> MODE_RW_UGO);
> @@ -234,6 +267,7 @@ change the times of the file associated with standard
> output.\n\
>    -f                     (ignored)\n\
>  "), stdout);
>        fputs (_("\
> +  -i, --no-create-dirs   do not create any required parent directories\n\
>    -h, --no-dereference   affect each symbolic link instead of any
> referenced\n\
>                           file (useful only on systems that can change
> the\n\
>                           timestamps of a symlink)\n\
> @@ -276,7 +310,7 @@ main (int argc, char **argv)
>    change_times = 0;
>    no_create = use_ref = false;
>
> -  while ((c = getopt_long (argc, argv, "acd:fhmr:t:", longopts, NULL)) !=
> -1)
> +  while ((c = getopt_long (argc, argv, "acd:fhimr:t:", longopts, NULL))
> != -1)
>      {
>        switch (c)
>          {
> @@ -299,6 +333,10 @@ main (int argc, char **argv)
>            no_dereference = true;
>            break;
>
> +        case 'i':
> +          no_create_dirs = true;
> +          break;
> +
>          case 'm':
>            change_times |= CH_MTIME;
>            break;
> --
> 2.20.1
>
> On Sun, Jun 12, 2022 at 10:05 PM Alan Rosenthal <alan.rosenthal@HIDDEN>
> wrote:
>
>> `touch a/b/c/d/e` will now be the same as running `mkdir -p a/b/c/d &&
>> touch a/b/c/d/e`.
>> Added an option --no-create-dirs to not create any directories.
>> ---
>>  src/touch.c | 39 ++++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 38 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/touch.c b/src/touch.c
>> index 21c247d0b..9034e8797 100644
>> --- a/src/touch.c
>> +++ b/src/touch.c
>> @@ -28,10 +28,12 @@
>>  #include "die.h"
>>  #include "error.h"
>>  #include "fd-reopen.h"
>> +#include "mkancesdirs.h"
>>  #include "parse-datetime.h"
>>  #include "posixtm.h"
>>  #include "posixver.h"
>>  #include "quote.h"
>> +#include "savewd.h"
>>  #include "stat-time.h"
>>  #include "utimens.h"
>>
>> @@ -55,6 +57,9 @@ static int change_times;
>>  /* (-c) If true, don't create if not already there.  */
>>  static bool no_create;
>>
>> +/* (-c) If true, don't create directories if not already there.  */
>> +static bool no_create_dirs;
>> +
>>  /* (-r) If true, use times from a reference file.  */
>>  static bool use_ref;
>>
>> @@ -88,6 +93,7 @@ static struct option const longopts[] =
>>    {"date", required_argument, NULL, 'd'},
>>    {"reference", required_argument, NULL, 'r'},
>>    {"no-dereference", no_argument, NULL, 'h'},
>> +  {"no_create_dirs", no_argument, NULL, 'i'},
>>    {GETOPT_HELP_OPTION_DECL},
>>    {GETOPT_VERSION_OPTION_DECL},
>>    {NULL, 0, NULL, 0}
>> @@ -116,6 +122,14 @@ get_reldate (struct timespec *result,
>>      die (EXIT_FAILURE, 0, _("invalid date format %s"), quote
>> (flex_date));
>>  }
>>
>> +/* Create directory, called by mkancesdirs(). */
>> +
>> +static int
>> +make_dir(char const * file, char const * component, void * arg)
>> +{
>> +  return mkdir(component, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH |
>> S_IXOTH);
>> +}
>> +
>>  /* Update the time of file FILE according to the options given.
>>     Return true if successful.  */
>>
>> @@ -130,6 +144,25 @@ touch (char const *file)
>>      fd = STDOUT_FILENO;
>>    else if (! (no_create || no_dereference))
>>      {
>> +      if (! no_create_dirs)
>> +        {
>> +          struct savewd wd;
>> +          savewd_init(&wd);
>> +          ptrdiff_t ret = mkancesdirs((char*) file, &wd, make_dir, NULL);
>> +          if (ret == -1)
>> +            {
>> +              error (0, open_errno, _("cannot mkdir %s"), quoteaf
>> (file));
>> +              return false;
>> +            }
>> +          int r = savewd_restore(&wd, 0);
>> +          if (r < 0)
>> +            {
>> +              error (0, open_errno, _("cannot mkdir %s"), quoteaf
>> (file));
>> +              return false;
>> +            }
>> +          savewd_finish(&wd);
>> +        }
>> +
>>        /* Try to open FILE, creating it if necessary.  */
>>        fd = fd_reopen (STDIN_FILENO, file,
>>                        O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY,
>> MODE_RW_UGO);
>> @@ -276,7 +309,7 @@ main (int argc, char **argv)
>>    change_times = 0;
>>    no_create = use_ref = false;
>>
>> -  while ((c = getopt_long (argc, argv, "acd:fhmr:t:", longopts, NULL))
>> != -1)
>> +  while ((c = getopt_long (argc, argv, "acd:fhimr:t:", longopts, NULL))
>> != -1)
>>      {
>>        switch (c)
>>          {
>> @@ -299,6 +332,10 @@ main (int argc, char **argv)
>>            no_dereference = true;
>>            break;
>>
>> +        case 'i':
>> +          no_create_dirs = true;
>> +          break;
>> +
>>          case 'm':
>>            change_times |= CH_MTIME;
>>            break;
>> --
>> 2.20.1
>>
>>

--000000000000dcbf2205e1717f1f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">`touch -p a/b/c/d/e` will now be the same as running:<br>`=
mkdir -p a/b/c/d &amp;&amp; touch a/b/c/d/e`.<br><br>Added an option -p/--c=
reate-dirs to create any required directories.<br>Default behavior remains =
the same.<br>---<br>=C2=A0src/touch.c | 40 ++++++++++++++++++++++++++++++++=
+++++++-<br>=C2=A01 file changed, 39 insertions(+), 1 deletion(-)<br><br>di=
ff --git a/src/touch.c b/src/touch.c<br>index 21c247d0b..543f92b41 100644<b=
r>--- a/src/touch.c<br>+++ b/src/touch.c<br>@@ -28,10 +28,12 @@<br>=C2=A0#i=
nclude &quot;die.h&quot;<br>=C2=A0#include &quot;error.h&quot;<br>=C2=A0#in=
clude &quot;fd-reopen.h&quot;<br>+#include &quot;mkancesdirs.h&quot;<br>=C2=
=A0#include &quot;parse-datetime.h&quot;<br>=C2=A0#include &quot;posixtm.h&=
quot;<br>=C2=A0#include &quot;posixver.h&quot;<br>=C2=A0#include &quot;quot=
e.h&quot;<br>+#include &quot;savewd.h&quot;<br>=C2=A0#include &quot;stat-ti=
me.h&quot;<br>=C2=A0#include &quot;utimens.h&quot;<br>=C2=A0<br>@@ -55,6 +5=
7,9 @@ static int change_times;<br>=C2=A0/* (-c) If true, don&#39;t create =
if not already there. =C2=A0*/<br>=C2=A0static bool no_create;<br>=C2=A0<br=
>+/* (-p) If true, create directories if not already there. =C2=A0*/<br>+st=
atic bool create_dirs;<br>+<br>=C2=A0/* (-r) If true, use times from a refe=
rence file. =C2=A0*/<br>=C2=A0static bool use_ref;<br>=C2=A0<br>@@ -88,6 +9=
3,7 @@ static struct option const longopts[] =3D<br>=C2=A0 =C2=A0{&quot;dat=
e&quot;, required_argument, NULL, &#39;d&#39;},<br>=C2=A0 =C2=A0{&quot;refe=
rence&quot;, required_argument, NULL, &#39;r&#39;},<br>=C2=A0 =C2=A0{&quot;=
no-dereference&quot;, no_argument, NULL, &#39;h&#39;},<br>+ =C2=A0{&quot;cr=
eate-dirs&quot;, no_argument, NULL, &#39;p&#39;},<br>=C2=A0 =C2=A0{GETOPT_H=
ELP_OPTION_DECL},<br>=C2=A0 =C2=A0{GETOPT_VERSION_OPTION_DECL},<br>=C2=A0 =
=C2=A0{NULL, 0, NULL, 0}<br>@@ -116,6 +122,14 @@ get_reldate (struct timesp=
ec *result,<br>=C2=A0 =C2=A0 =C2=A0die (EXIT_FAILURE, 0, _(&quot;invalid da=
te format %s&quot;), quote (flex_date));<br>=C2=A0}<br>=C2=A0<br>+/* Create=
 directory, called by mkancesdirs(). */<br>+<br>+static int<br>+make_dir(ch=
ar const * file, char const * component, void * arg)<br>+{<br>+ =C2=A0retur=
n mkdir(component, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH);<br>+}<=
br>+<br>=C2=A0/* Update the time of file FILE according to the options give=
n.<br>=C2=A0 =C2=A0 Return true if successful. =C2=A0*/<br>=C2=A0<br>@@ -13=
0,6 +144,25 @@ touch (char const *file)<br>=C2=A0 =C2=A0 =C2=A0fd =3D STDOU=
T_FILENO;<br>=C2=A0 =C2=A0else if (! (no_create || no_dereference))<br>=C2=
=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0if (create_dirs)<br>+ =C2=A0 =
=C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct savewd =
wd;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0savewd_init(&amp;wd);<br>+ =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ptrdiff_t ret =3D mkancesdirs((char*) file, =
&amp;wd, make_dir, NULL);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =
=3D=3D -1)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error (0, open_errno, _(&quot;cannot =
mkdir %s&quot;), quoteaf (file));<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0return false;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<=
br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int r =3D savewd_restore(&amp;wd, 0)=
;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (r &lt; 0)<br>+ =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0error (0, open_errno, _(&quot;cannot mkdir %s&quot;), quoteaf (file)=
);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return false;<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0savewd_finish(&amp;wd);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+<br>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Try to open FILE, creating it if necessary. =
=C2=A0*/<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0fd =3D fd_reopen (STDIN_FILENO, file=
,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY, MODE_RW_UGO);<br>@=
@ -240,6 +273,7 @@ change the times of the file associated with standard ou=
tput.\n\<br>=C2=A0 =C2=A0-m =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 change only the modification time\n\<br>=C2=A0&quo=
t;), stdout);<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0fputs (_(&quot;\<br>+ =C2=A0-p,=
 --create-dirs =C2=A0 =C2=A0 =C2=A0create any required parent directories\n=
\<br>=C2=A0 =C2=A0-r, --reference=3DFILE =C2=A0 use this file&#39;s times i=
nstead of current time\n\<br>=C2=A0 =C2=A0-t STAMP =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 use [[CC]YY]MMDDhhmm[.ss] instead of current time\=
n\<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0--time=3DWORD =C2=A0 =C2=A0 =C2=A0 =C2=A0c=
hange the specified time:\n\<br>@@ -276,7 +310,7 @@ main (int argc, char **=
argv)<br>=C2=A0 =C2=A0change_times =3D 0;<br>=C2=A0 =C2=A0no_create =3D use=
_ref =3D false;<br>=C2=A0<br>- =C2=A0while ((c =3D getopt_long (argc, argv,=
 &quot;acd:fhmr:t:&quot;, longopts, NULL)) !=3D -1)<br>+ =C2=A0while ((c =
=3D getopt_long (argc, argv, &quot;acd:fhmpr:t:&quot;, longopts, NULL)) !=
=3D -1)<br>=C2=A0 =C2=A0 =C2=A0{<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0switch (c)<b=
r>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>@@ -303,6 +337,10 @@ main (int arg=
c, char **argv)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0change_times |=
=3D CH_MTIME;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br>=C2=A0<=
br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39;p&#39;:<br>+ =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0create_dirs =3D true;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
break;<br>+<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39;r&#39;:<br>=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0use_ref =3D true;<br>=C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0ref_file =3D optarg;<br>-- <br>2.20.1<br><br></d=
iv><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On =
Mon, Jun 13, 2022 at 7:52 AM Alan Rosenthal &lt;<a href=3D"mailto:alan.rose=
nthal@HIDDEN">alan.rosenthal@HIDDEN</a>&gt; wrote:<br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">`touch a/b/c/d/e`=
 will now be the same as running `mkdir -p a/b/c/d &amp;&amp;<br>touch a/b/=
c/d/e`.<br>Added an option --no-create-dirs to not create any directories.<=
br>---<br>=C2=A0src/touch.c | 40 +++++++++++++++++++++++++++++++++++++++-<b=
r>=C2=A01 file changed, 39 insertions(+), 1 deletion(-)<br><br>diff --git a=
/src/touch.c b/src/touch.c<br>index 21c247d0b..557530f79 100644<br>--- a/sr=
c/touch.c<br>+++ b/src/touch.c<br>@@ -28,10 +28,12 @@<br>=C2=A0#include &qu=
ot;die.h&quot;<br>=C2=A0#include &quot;error.h&quot;<br>=C2=A0#include &quo=
t;fd-reopen.h&quot;<br>+#include &quot;mkancesdirs.h&quot;<br>=C2=A0#includ=
e &quot;parse-datetime.h&quot;<br>=C2=A0#include &quot;posixtm.h&quot;<br>=
=C2=A0#include &quot;posixver.h&quot;<br>=C2=A0#include &quot;quote.h&quot;=
<br>+#include &quot;savewd.h&quot;<br>=C2=A0#include &quot;stat-time.h&quot=
;<br>=C2=A0#include &quot;utimens.h&quot;<br>=C2=A0<br>@@ -55,6 +57,9 @@ st=
atic int change_times;<br>=C2=A0/* (-c) If true, don&#39;t create if not al=
ready there. =C2=A0*/<br>=C2=A0static bool no_create;<br>=C2=A0<br>+/* (-c)=
 If true, don&#39;t create directories if not already there. =C2=A0*/<br>+s=
tatic bool no_create_dirs;<br>+<br>=C2=A0/* (-r) If true, use times from a =
reference file. =C2=A0*/<br>=C2=A0static bool use_ref;<br>=C2=A0<br>@@ -88,=
6 +93,7 @@ static struct option const longopts[] =3D<br>=C2=A0 =C2=A0{&quot=
;date&quot;, required_argument, NULL, &#39;d&#39;},<br>=C2=A0 =C2=A0{&quot;=
reference&quot;, required_argument, NULL, &#39;r&#39;},<br>=C2=A0 =C2=A0{&q=
uot;no-dereference&quot;, no_argument, NULL, &#39;h&#39;},<br>+ =C2=A0{&quo=
t;no-create-dirs&quot;, no_argument, NULL, &#39;i&#39;},<br>=C2=A0 =C2=A0{G=
ETOPT_HELP_OPTION_DECL},<br>=C2=A0 =C2=A0{GETOPT_VERSION_OPTION_DECL},<br>=
=C2=A0 =C2=A0{NULL, 0, NULL, 0}<br>@@ -116,6 +122,14 @@ get_reldate (struct=
 timespec *result,<br>=C2=A0 =C2=A0 =C2=A0die (EXIT_FAILURE, 0, _(&quot;inv=
alid date format %s&quot;), quote (flex_date));<br>=C2=A0}<br>=C2=A0<br>+/*=
 Create directory, called by mkancesdirs(). */<br>+<br>+static int<br>+make=
_dir(char const * file, char const * component, void * arg)<br>+{<br>+ =C2=
=A0return mkdir(component, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH)=
;<br>+}<br>+<br>=C2=A0/* Update the time of file FILE according to the opti=
ons given.<br>=C2=A0 =C2=A0 Return true if successful. =C2=A0*/<br>=C2=A0<b=
r>@@ -130,6 +144,25 @@ touch (char const *file)<br>=C2=A0 =C2=A0 =C2=A0fd =
=3D STDOUT_FILENO;<br>=C2=A0 =C2=A0else if (! (no_create || no_dereference)=
)<br>=C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0if (! no_create_dirs)<b=
r>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0str=
uct savewd wd;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0savewd_init(&amp;wd);=
<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ptrdiff_t ret =3D mkancesdirs((char=
*) file, &amp;wd, make_dir, NULL);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i=
f (ret =3D=3D -1)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error (0, open_errno, _(&quot;=
cannot mkdir %s&quot;), quoteaf (file));<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0return false;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int r =3D savewd_restore(&am=
p;wd, 0);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (r &lt; 0)<br>+ =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0error (0, open_errno, _(&quot;cannot mkdir %s&quot;), quoteaf=
 (file));<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return false=
;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0savewd_finish(&amp;wd);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>=
+<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Try to open FILE, creating it if necessa=
ry. =C2=A0*/<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0fd =3D fd_reopen (STDIN_FILENO, =
file,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0O_WRONLY | O_CREAT | O_NONBLOCK | O_NOCTTY, MODE_RW_UGO);<=
br>@@ -234,6 +267,7 @@ change the times of the file associated with standar=
d output.\n\<br>=C2=A0 =C2=A0-f =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (ignored)\n\<br>=C2=A0&quot;), stdout);<br>=C2=
=A0 =C2=A0 =C2=A0 =C2=A0fputs (_(&quot;\<br>+ =C2=A0-i, --no-create-dirs =
=C2=A0 do not create any required parent directories\n\<br>=C2=A0 =C2=A0-h,=
 --no-dereference =C2=A0 affect each symbolic link instead of any reference=
d\n\<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 file (useful only on systems that can change the\n=
\<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 timestamps of a symlink)\n\<br>@@ -276,7 +310,7 @@ mai=
n (int argc, char **argv)<br>=C2=A0 =C2=A0change_times =3D 0;<br>=C2=A0 =C2=
=A0no_create =3D use_ref =3D false;<br>=C2=A0<br>- =C2=A0while ((c =3D geto=
pt_long (argc, argv, &quot;acd:fhmr:t:&quot;, longopts, NULL)) !=3D -1)<br>=
+ =C2=A0while ((c =3D getopt_long (argc, argv, &quot;acd:fhimr:t:&quot;, lo=
ngopts, NULL)) !=3D -1)<br>=C2=A0 =C2=A0 =C2=A0{<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0switch (c)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>@@ -299,6 +333,1=
0 @@ main (int argc, char **argv)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0no_dereference =3D true;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bre=
ak;<br>=C2=A0<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39;i&#39;:<br>+ =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0no_create_dirs =3D true;<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0break;<br>+<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39=
;m&#39;:<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0change_times |=3D CH_M=
TIME;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br><div>-- <br>2.2=
0.1<br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Sun, Jun 12, 2022 at 10:05 PM Alan Rosenthal &lt;<a href=3D=
"mailto:alan.rosenthal@HIDDEN" target=3D"_blank">alan.rosenthal@HIDDEN=
m</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"=
><div dir=3D"ltr">`touch a/b/c/d/e` will now be the same as running `mkdir =
-p a/b/c/d &amp;&amp;<br>touch a/b/c/d/e`.<br>Added an option --no-create-d=
irs to not create any directories.<br>---<br>=C2=A0src/touch.c | 39 +++++++=
+++++++++++++++++++++++++++++++-<br>=C2=A01 file changed, 38 insertions(+),=
 1 deletion(-)<br><br>diff --git a/src/touch.c b/src/touch.c<br>index 21c24=
7d0b..9034e8797 100644<br>--- a/src/touch.c<br>+++ b/src/touch.c<br>@@ -28,=
10 +28,12 @@<br>=C2=A0#include &quot;die.h&quot;<br>=C2=A0#include &quot;er=
ror.h&quot;<br>=C2=A0#include &quot;fd-reopen.h&quot;<br>+#include &quot;mk=
ancesdirs.h&quot;<br>=C2=A0#include &quot;parse-datetime.h&quot;<br>=C2=A0#=
include &quot;posixtm.h&quot;<br>=C2=A0#include &quot;posixver.h&quot;<br>=
=C2=A0#include &quot;quote.h&quot;<br>+#include &quot;savewd.h&quot;<br>=C2=
=A0#include &quot;stat-time.h&quot;<br>=C2=A0#include &quot;utimens.h&quot;=
<br>=C2=A0<br>@@ -55,6 +57,9 @@ static int change_times;<br>=C2=A0/* (-c) I=
f true, don&#39;t create if not already there. =C2=A0*/<br>=C2=A0static boo=
l no_create;<br>=C2=A0<br>+/* (-c) If true, don&#39;t create directories if=
 not already there. =C2=A0*/<br>+static bool no_create_dirs;<br>+<br>=C2=A0=
/* (-r) If true, use times from a reference file. =C2=A0*/<br>=C2=A0static =
bool use_ref;<br>=C2=A0<br>@@ -88,6 +93,7 @@ static struct option const lon=
gopts[] =3D<br>=C2=A0 =C2=A0{&quot;date&quot;, required_argument, NULL, &#3=
9;d&#39;},<br>=C2=A0 =C2=A0{&quot;reference&quot;, required_argument, NULL,=
 &#39;r&#39;},<br>=C2=A0 =C2=A0{&quot;no-dereference&quot;, no_argument, NU=
LL, &#39;h&#39;},<br>+ =C2=A0{&quot;no_create_dirs&quot;, no_argument, NULL=
, &#39;i&#39;},<br>=C2=A0 =C2=A0{GETOPT_HELP_OPTION_DECL},<br>=C2=A0 =C2=A0=
{GETOPT_VERSION_OPTION_DECL},<br>=C2=A0 =C2=A0{NULL, 0, NULL, 0}<br>@@ -116=
,6 +122,14 @@ get_reldate (struct timespec *result,<br>=C2=A0 =C2=A0 =C2=A0=
die (EXIT_FAILURE, 0, _(&quot;invalid date format %s&quot;), quote (flex_da=
te));<br>=C2=A0}<br>=C2=A0<br>+/* Create directory, called by mkancesdirs()=
. */<br>+<br>+static int<br>+make_dir(char const * file, char const * compo=
nent, void * arg)<br>+{<br>+ =C2=A0return mkdir(component, S_IRWXU | S_IRGR=
P | S_IXGRP | S_IROTH | S_IXOTH);<br>+}<br>+<br>=C2=A0/* Update the time of=
 file FILE according to the options given.<br>=C2=A0 =C2=A0 Return true if =
successful. =C2=A0*/<br>=C2=A0<br>@@ -130,6 +144,25 @@ touch (char const *f=
ile)<br>=C2=A0 =C2=A0 =C2=A0fd =3D STDOUT_FILENO;<br>=C2=A0 =C2=A0else if (=
! (no_create || no_dereference))<br>=C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=
=A0 =C2=A0if (! no_create_dirs)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct savewd wd;<br>+ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0savewd_init(&amp;wd);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p=
trdiff_t ret =3D mkancesdirs((char*) file, &amp;wd, make_dir, NULL);<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D -1)<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0{<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0error (0, open_errno, _(&quot;cannot mkdir %s&quot;), quoteaf (file))=
;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return false;<br>+ =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0int r =3D savewd_restore(&amp;wd, 0);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0if (r &lt; 0)<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>=
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error (0, open_errno, _(&=
quot;cannot mkdir %s&quot;), quoteaf (file));<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0return false;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0}<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0savewd_finish(&amp;wd);<=
br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>+<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Try=
 to open FILE, creating it if necessary. =C2=A0*/<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0fd =3D fd_reopen (STDIN_FILENO, file,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0O_WRONLY | O_CREAT |=
 O_NONBLOCK | O_NOCTTY, MODE_RW_UGO);<br>@@ -276,7 +309,7 @@ main (int argc=
, char **argv)<br>=C2=A0 =C2=A0change_times =3D 0;<br>=C2=A0 =C2=A0no_creat=
e =3D use_ref =3D false;<br>=C2=A0<br>- =C2=A0while ((c =3D getopt_long (ar=
gc, argv, &quot;acd:fhmr:t:&quot;, longopts, NULL)) !=3D -1)<br>+ =C2=A0whi=
le ((c =3D getopt_long (argc, argv, &quot;acd:fhimr:t:&quot;, longopts, NUL=
L)) !=3D -1)<br>=C2=A0 =C2=A0 =C2=A0{<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0switch =
(c)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{<br>@@ -299,6 +332,10 @@ main (in=
t argc, char **argv)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0no_derefer=
ence =3D true;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br>=C2=A0=
<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39;i&#39;:<br>+ =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0no_create_dirs =3D true;<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0break;<br>+<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case &#39;m&#39;:<br=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0change_times |=3D CH_MTIME;<br>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;<br>-- <br>2.20.1<br><br></d=
iv>
</blockquote></div>
</blockquote></div>

--000000000000dcbf2205e1717f1f--

Message sent to bug-coreutils@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#55937: [PATCH] touch: create parent directories if needed
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Wed, 15 Jun 2022 02:38:01 +0000
Resent-Message-ID: <handler.55937.B55937.16552606729053 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55937
X-GNU-PR-Package: coreutils
X-GNU-PR-Keywords: patch
To: Alan Rosenthal <alan.rosenthal@HIDDEN>
Cc: 55937 <at> debbugs.gnu.org
Received: via spool by 55937-submit <at> debbugs.gnu.org id=B55937.16552606729053
          (code B ref 55937); Wed, 15 Jun 2022 02:38:01 +0000
Received: (at 55937) by debbugs.gnu.org; 15 Jun 2022 02:37:52 +0000
Received: from localhost ([127.0.0.1]:36190 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o1Iul-0002Lx-SS
	for submit <at> debbugs.gnu.org; Tue, 14 Jun 2022 22:37:52 -0400
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38522)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1o1Iuj-0002Li-9f
 for 55937 <at> debbugs.gnu.org; Tue, 14 Jun 2022 22:37:50 -0400
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id F1C651601F1;
 Tue, 14 Jun 2022 19:37:42 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id cI9MN8UyghAL; Tue, 14 Jun 2022 19:37:42 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 562F81601F2;
 Tue, 14 Jun 2022 19:37:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id gC_cITtS74t5; Tue, 14 Jun 2022 19:37:42 -0700 (PDT)
Received: from [100.115.92.201] (ip72-206-2-24.fv.ks.cox.net [72.206.2.24])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0CB301601F1;
 Tue, 14 Jun 2022 19:37:41 -0700 (PDT)
Message-ID: <d473fbc7-d612-70c8-9903-25d43ea84576@HIDDEN>
Date: Tue, 14 Jun 2022 21:37:36 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-US
References: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
 <CABEWFW9+oseQjHuGAhVLm9uGeDXdziOTgiKMTb4gD-guoz3-pA@HIDDEN>
 <CABEWFW-Cb-8k4TrS6PERny7K2uM0tcjNYshi2MH2PYovvxUS4Q@HIDDEN>
From: Paul Eggert <eggert@HIDDEN>
In-Reply-To: <CABEWFW-Cb-8k4TrS6PERny7K2uM0tcjNYshi2MH2PYovvxUS4Q@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On 6/14/22 19:20, Alan Rosenthal wrote:
> `touch -p a/b/c/d/e` will now be the same as running:
> `mkdir -p a/b/c/d && touch a/b/c/d/e`.

I don't see how this useful enough to merit a change, since one can 
achieve the effect of the proposed "touch -p" with the already-existing 
"mkdir -p" followed by plain "touch". mkdir -p already exists and should 
work everywhere that's POSIX-compatible. We don't need -p for other 
commands that create files (e.g., cp, mv, ln); what's special about 'touch'?

Message sent to bug-coreutils@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#55937: [PATCH] touch: create parent directories if needed
Resent-From: Alan Rosenthal <alan.rosenthal@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Wed, 15 Jun 2022 20:33:02 +0000
Resent-Message-ID: <handler.55937.B55937.16553251532636 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55937
X-GNU-PR-Package: coreutils
X-GNU-PR-Keywords: patch
To: Paul Eggert <eggert@HIDDEN>
Cc: 55937 <at> debbugs.gnu.org
Received: via spool by 55937-submit <at> debbugs.gnu.org id=B55937.16553251532636
          (code B ref 55937); Wed, 15 Jun 2022 20:33:02 +0000
Received: (at 55937) by debbugs.gnu.org; 15 Jun 2022 20:32:33 +0000
Received: from localhost ([127.0.0.1]:39979 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o1Zgm-0000gR-Td
	for submit <at> debbugs.gnu.org; Wed, 15 Jun 2022 16:32:33 -0400
Received: from mail-pl1-f178.google.com ([209.85.214.178]:45051)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <alan.rosenthal@HIDDEN>) id 1o1Zgj-0000g7-Fu
 for 55937 <at> debbugs.gnu.org; Wed, 15 Jun 2022 16:32:31 -0400
Received: by mail-pl1-f178.google.com with SMTP id h1so11335005plf.11
 for <55937 <at> debbugs.gnu.org>; Wed, 15 Jun 2022 13:32:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=No1BIIALLYJqWzMWIcEliAoustS8/lVIOWBGXLnnugQ=;
 b=dhyqGcNmjXgTp0wI7uOikOXfBOvk1YoRSnfHxvQamHftmkInajV6XgrotkQxx6hgGa
 gQ6ohxYpNQY8p75iICGDqGh0vqJquA7j5jXum+PaYWzIzENfh9zHU95YjVwoaRGJuSeg
 ImIPz03Xyocm5Z23WOsf1FqkSAMe7VtgoFuo8truLWmBBhma+njCQxqB6/k1kKEO/mIZ
 xUL7dGVXAgTDd/jXbn6AigR+17Q+DtKzkjRK3Y0E3nckIIP0gSv+ypKTCs+bHvzNTPsq
 1wyykA8nIR7j8yufvXGuRPJpJUt5wrAJgReXZ5z2B53DyiM6F9Q3ran07Jce1+vUlcPE
 S8AQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=No1BIIALLYJqWzMWIcEliAoustS8/lVIOWBGXLnnugQ=;
 b=2LgBeu5wZPA1zcEVgD6l0b0EllSgVaLsr3EQf3QgvjlxyQ6coCWqoS4s4wdYS75LwB
 j/eROGSi/jlSeRQhd/WWPvSF49hbCU3Hz5EdwnSfdwsdutB4rIQnT2NbdZ53CY9ZdSZi
 n7ZXOgtCCLt1sPtUq4/CkuFsWafeKXOvhGI9Wy525umuBqqimYazPfxUkBSVa0EV1Rqz
 i2hL7hkyk+mKhoDd2fPrHfui/ZHg0CdriDtwPBZIql+XiXzJiKCXpHH11m2kF13Psmlz
 KjTYuSEqeuYeku29naqLxg5nARfpBVLlZWZ/rzAvbuQwGdFqVPlt/wKgbu+EU9TXOCu/
 DfGg==
X-Gm-Message-State: AJIora+QxuWp7gihy5Temcle4Ht0OLPY/XIvN0qj3y9NpacHIGAGVdDn
 35X3lqaLgsoYiq8bXqyc3BMSAzXQc1DwX8rlUzQ=
X-Google-Smtp-Source: AGRyM1uAaz4p3LwX+yrifUpA2rkMeczC4InaHcm6+fcNSqzFe6r+55WP16UWQoCiL3SdjcPPRzTNKOEc1c/MVmCt06w=
X-Received: by 2002:a17:903:2645:b0:167:92f1:15c0 with SMTP id
 je5-20020a170903264500b0016792f115c0mr1286905plb.100.1655325143449; Wed, 15
 Jun 2022 13:32:23 -0700 (PDT)
MIME-Version: 1.0
References: <CABEWFW8x_Th-O0TdVTNi4fuordVvEZCFPiVqPuUnqQDRrM_OHQ@HIDDEN>
 <CABEWFW9+oseQjHuGAhVLm9uGeDXdziOTgiKMTb4gD-guoz3-pA@HIDDEN>
 <CABEWFW-Cb-8k4TrS6PERny7K2uM0tcjNYshi2MH2PYovvxUS4Q@HIDDEN>
 <d473fbc7-d612-70c8-9903-25d43ea84576@HIDDEN>
In-Reply-To: <d473fbc7-d612-70c8-9903-25d43ea84576@HIDDEN>
From: Alan Rosenthal <alan.rosenthal@HIDDEN>
Date: Wed, 15 Jun 2022 16:31:47 -0400
Message-ID: <CABEWFW9iJZ3edgRrWVN0=5RuMDrbAUM-uA+QqzZ1at=EKO+-2w@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000029c4ab05e1826b4f"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--00000000000029c4ab05e1826b4f
Content-Type: text/plain; charset="UTF-8"

Thanks for taking the time to review my patch.

I agree with you that this change is not strictly required. It's more of a
nice to have / ergonomic improvement to the existing touch interface.

There are several StackOverflow posts that ask for this very feature:
https://unix.stackexchange.com/q/63098 &
https://unix.stackexchange.com/q/305844

Below is the help text for touch:
> Update the access and modification times of each FILE to the current time.
> A FILE argument that does not exist is created empty, unless -c or -h is
supplied.

I was surprised to learn there was no existing flag that would allow
directory creation when a file and its directories do not exist. Currently
if directories do not exist, the command fails. I would go as far to argue
that creating a file also implies creating any required directories, since
directories must exist before we can create said file.

I also agree with David Hilton's recommendation that we should not change
the default behavior of touch, like in my first patch, but rather add an
opt-in flag for this behavior.

Thank you for reading my reply and I look forward to your future feedback.

On Tue, Jun 14, 2022 at 10:37 PM Paul Eggert <eggert@HIDDEN> wrote:

> On 6/14/22 19:20, Alan Rosenthal wrote:
> > `touch -p a/b/c/d/e` will now be the same as running:
> > `mkdir -p a/b/c/d && touch a/b/c/d/e`.
>
> I don't see how this useful enough to merit a change, since one can
> achieve the effect of the proposed "touch -p" with the already-existing
> "mkdir -p" followed by plain "touch". mkdir -p already exists and should
> work everywhere that's POSIX-compatible. We don't need -p for other
> commands that create files (e.g., cp, mv, ln); what's special about
> 'touch'?
>
>

--00000000000029c4ab05e1826b4f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks for taking the time to review my patch.<div><br></d=
iv><div>I agree with you that this change is not strictly required. It&#39;=
s more of a nice to have / ergonomic=C2=A0improvement=C2=A0to the existing =
touch interface.</div><div><br></div><div>There are several StackOverflow p=
osts that ask for this very feature: <a href=3D"https://unix.stackexchange.=
com/q/63098" target=3D"_blank">https://unix.stackexchange.com/q/63098</a> &=
amp;=C2=A0<a href=3D"https://unix.stackexchange.com/q/305844" target=3D"_bl=
ank">https://unix.stackexchange.com/q/305844</a></div><div><br></div><div>B=
elow is the help text for touch:</div><div>&gt; Update the access and modif=
ication times of each FILE to the current time.<br>&gt; A FILE argument tha=
t does not exist is created empty, unless -c or -h is supplied.<br></div><d=
iv><br></div><div>I was surprised to learn there was no existing=C2=A0flag =
that would allow directory creation when a file and its directories do not =
exist. Currently if directories do not exist, the command fails. I would go=
 as far to argue that creating a file also implies creating any required=C2=
=A0directories, since directories must exist before we can create said file=
.</div><div><br></div><div>I also agree with=C2=A0David Hilton&#39;s recomm=
endation that we should not change the default behavior of touch, like in m=
y first patch, but rather add an opt-in flag for this behavior.</div><div><=
br></div><div>Thank you for reading my reply and I look forward to your fut=
ure feedback.</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" cl=
ass=3D"gmail_attr">On Tue, Jun 14, 2022 at 10:37 PM Paul Eggert &lt;<a href=
=3D"mailto:eggert@HIDDEN" target=3D"_blank">eggert@HIDDEN</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 6/14/=
22 19:20, Alan Rosenthal wrote:<br>
&gt; `touch -p a/b/c/d/e` will now be the same as running:<br>
&gt; `mkdir -p a/b/c/d &amp;&amp; touch a/b/c/d/e`.<br>
<br>
I don&#39;t see how this useful enough to merit a change, since one can <br=
>
achieve the effect of the proposed &quot;touch -p&quot; with the already-ex=
isting <br>
&quot;mkdir -p&quot; followed by plain &quot;touch&quot;. mkdir -p already =
exists and should <br>
work everywhere that&#39;s POSIX-compatible. We don&#39;t need -p for other=
 <br>
commands that create files (e.g., cp, mv, ln); what&#39;s special about &#3=
9;touch&#39;?<br>
<br>
</blockquote></div>

--00000000000029c4ab05e1826b4f--

Last modified: Wed, 15 Jun 2022 20:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.