GNU bug report logs - #55964
[PATCH 2/9] gnu: Add node-yazl.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55964 in the body.
You can then email your comments to 55964 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 2/9] gnu: Add node-yazl.
Date: Tue, 14 Jun 2022 11:49:47 +0200

* gnu/packages/node-xyz.scm (node-yazl): New variable.
---
 gnu/packages/node-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index be37d627cf..af3745f601 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -1335,3 +1335,36 @@ (define-public node-serialport
 accessing serial ports.  This package is the recommended entry point for most
 projects.  It combines a high-level Node.js stream interface with a useful
 default set of parsers and bindings.")))
+
+(define-public node-yazl
+  (package
+    (name "node-yazl")
+    (version "2.5.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/thejoshwolfe/yazl")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+          (base32
+           "1lhwqqnvazpi4xw81ldpx0ky0h1j5rcx3br480q2bnzj21cm109n"))))
+    (build-system node-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (delete 'check)
+         (replace 'configure
+           (lambda* (#:key inputs #:allow-other-keys)
+             (invoke (string-append (assoc-ref inputs "node") "/bin/npm")
+                     "--offline" "--ignore-scripts" "install" "--production")
+             #t)))))
+    (inputs (list node-buffer-crc32))
+    (home-page "https://github.com/thejoshwolfe/yazl")
+    (synopsis "Yet another zip library for node")
+    (description "This package provides a zip library for Node. It follows the following principles:
+Don't block the JavaScript thread. Use and provide async APIs.
+Keep memory usage under control. Don't attempt to buffer entire files in RAM at once.
+Prefer to open input files one at a time than all at once. ")
+    (license license:expat)))
-- 
2.36.1

Message #10 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>,
 55964 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#55964] [PATCH 2/9] gnu: Add node-yazl.
Date: Thu, 23 Jun 2022 22:22:56 +0200

[Message part 1 (text/plain, inline)]

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> skriver:

> * gnu/packages/node-xyz.scm (node-yazl): New variable.

[...]

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/thejoshwolfe/yazl")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +          (base32
> +           "1lhwqqnvazpi4xw81ldpx0ky0h1j5rcx3br480q2bnzj21cm109n"))))

Indentation seems off here ('./pre-inst-env guix style node-yazl' can
take care of it if you don't use Emacs).

> +    (build-system node-build-system)
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'check)
> +         (replace 'configure
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (invoke (string-append (assoc-ref inputs "node") "/bin/npm")
> +                     "--offline" "--ignore-scripts" "install" "--production")
> +             #t)))))

Same comments as previous patch.

> +    (inputs (list node-buffer-crc32))
> +    (home-page "https://github.com/thejoshwolfe/yazl")
> +    (synopsis "Yet another zip library for node")
> +    (description "This package provides a zip library for Node. It follows the following principles:

Keep lines < 78 characters if possible.  Also use two spaces after
punctuation.

'./pre-inst-env guix lint PACKAGE' will warn about this and save review
time.  ;-)

> +Don't block the JavaScript thread. Use and provide async APIs.
> +Keep memory usage under control. Don't attempt to buffer entire files in RAM at once.
> +Prefer to open input files one at a time than all at once. ")

Use @enumerate for "bullet lists" which this seems to be.

Otherwise LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 55964 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Nicolas Graves <ngraves <at> ngraves.fr>, 55964 <at> debbugs.gnu.org
Subject: Re: [bug#55964] [PATCH 2/9] gnu: Add node-yazl.
Date: Fri, 24 Jun 2022 00:23:02 +0200

[Message part 1 (text/plain, inline)]

Nicolas Graves via Guix-patches via schreef op di 14-06-2022 om 11:49
[+0200]:
> +         (delete 'check)

You can use #:tests? #false for that.

> +             #t)))))

No need for trailing #t anymore (though harmless)!

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 55964 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 55964 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH] gnu: Add node-yazl.
Date: Wed, 20 Jul 2022 11:16:01 +0200

* gnu/packages/node-xyz.scm (node-yazl): New variable.
---
 gnu/packages/node-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index d6035e2c23..dec7d9ef19 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2021 Noisytoot <noisytoot <at> disroot.org>
 ;;; Copyright © 2021 Charles <charles.b.jackson <at> protonmail.com>
 ;;; Copyright © 2021 Philip McGrath <philip <at> philipmcgrath.com>
+;;; Copyright © 2022 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1333,3 +1334,39 @@ (define-public node-serialport
 accessing serial ports.  This package is the recommended entry point for most
 projects.  It combines a high-level Node.js stream interface with a useful
 default set of parsers and bindings.")))
+
+(define-public node-yazl
+  (package
+    (name "node-yazl")
+    (version "2.5.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/thejoshwolfe/yazl")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1lhwqqnvazpi4xw81ldpx0ky0h1j5rcx3br480q2bnzj21cm109n"))))
+    (build-system node-build-system)
+    (arguments
+     '(#:tests? #f
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key inputs #:allow-other-keys)
+             (invoke "npm" "--offline"
+                     "--ignore-scripts" "install" "--production"))))))
+    (inputs (list node-buffer-crc32))
+    (home-page "https://github.com/thejoshwolfe/yazl")
+    (synopsis "Yet another zip library for node")
+    (description "This package provides a zip library for Node.  It follows
+the following principles:
+@enumerate
+@item Don't block the JavaScript thread.  Use and provide async APIs.
+@item Keep memory usage under control.  Don't attempt to buffer entire
+files in RAM at once.
+@item Prefer to open input files one at a time than all at once.
+@end enumerate")
+    (license license:expat)))
-- 
2.37.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.