GNU bug report logs -
#55976
[PATCH] gnu: valgrind/interactive: Update to 3.19.0.
Previous Next
Reported by: Greg Hogan <code <at> greghogan.com>
Date: Tue, 14 Jun 2022 15:39:01 UTC
Severity: normal
Tags: patch
Done: Greg Hogan <code <at> greghogan.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55976 in the body.
You can then email your comments to 55976 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#55976
; Package
guix-patches
.
(Tue, 14 Jun 2022 15:39:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Greg Hogan <code <at> greghogan.com>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 14 Jun 2022 15:39:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/valgrind.scm (valgrind/interactive): Update to 3.19.0.
[home-page]: Update permanent redirect.
* gnu/packages/valgrind.scm (valgrind-3.18): Delete.
---
This patch bumps the version of the non-hidden valgrind while removing
the pinned-version package. Looking through the commit history, I do see
a reason for having both a valgrind/interactive and valgrind-3.18.
$ ./pre-inst-env guix refresh -l valgrind
No dependents other than itself: valgrind <at> 3.19.0
gnu/packages/valgrind.scm | 20 +++-----------------
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/gnu/packages/valgrind.scm b/gnu/packages/valgrind.scm
index 63524d59e9..8e9a4c39f4 100644
--- a/gnu/packages/valgrind.scm
+++ b/gnu/packages/valgrind.scm
@@ -79,7 +79,7 @@ (define-public valgrind
#t))))))
(native-inputs
(list perl))
- (home-page "https://www.valgrind.org/")
+ (home-page "https://valgrind.org/")
(synopsis "Debugging and profiling tool suite")
(description
"Valgrind is an instrumentation framework for building dynamic analysis
@@ -96,7 +96,7 @@ (define-public valgrind
(define-public valgrind/interactive
(package/inherit
valgrind
- (version "3.17.0")
+ (version "3.19.0")
(source (origin
(method url-fetch)
(uri (list (string-append "https://sourceware.org/pub/valgrind"
@@ -105,7 +105,7 @@ (define-public valgrind/interactive
"/valgrind-" version ".tar.bz2")))
(sha256
(base32
- "18l5jbk301j3462gipqn9bkfx44mdmwn0pwr73r40gl1irkfqfmd"))
+ "00lgfgb38xbrilkw6xvqk284dcnnnhbcq03kpvvkyj0sdx438pnx"))
(patches (search-patches
"valgrind-enable-arm.patch"
"valgrind-fix-default-debuginfo-path.patch"))))
@@ -148,17 +148,3 @@ (define-public valgrind/interactive
(string-length "/usr/lib/debug")
1))))))))))
(properties '())))
-
-(define-public valgrind-3.18
- (package
- (inherit valgrind/interactive)
- (version "3.18.1")
- (source (origin
- (inherit (package-source valgrind/interactive))
- (uri (list (string-append "https://sourceware.org/pub/valgrind"
- "/valgrind-" version ".tar.bz2")
- (string-append "ftp://sourceware.org/pub/valgrind"
- "/valgrind-" version ".tar.bz2")))
- (sha256
- (base32
- "1xgph509i6adv9w2glviw3xrmlz0dssg8992hbvxsbkp7ahrm180"))))))
--
2.36.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55976
; Package
guix-patches
.
(Tue, 14 Jun 2022 21:30:03 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi Greg,
Greg Hogan 写道:
> * gnu/packages/valgrind.scm (valgrind/interactive): Update to
> 3.19.0.
> [home-page]: Update permanent redirect.
> * gnu/packages/valgrind.scm (valgrind-3.18): Delete.
> ---
> This patch bumps the version of the non-hidden valgrind while
> removing
> the pinned-version package.
Unless I'm mistaken these 2 tasks are independent, and should
hence be split across 2 patches.
> Looking through the commit history,
> I do see
> a reason for having both a valgrind/interactive and
> valgrind-3.18.
I thought this was a typo for ‘don't’ at first, but I really can't
tell.
I don't see a reason to keep both now, but then I don't see one
when 50f7402c was committed either. Do you remember, Ludo'?
Kind regards,
T G-R
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55976
; Package
guix-patches
.
(Tue, 14 Jun 2022 21:30:04 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55976
; Package
guix-patches
.
(Wed, 15 Jun 2022 13:56:01 GMT)
Full text and
rfc822 format available.
Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):
On Tue, Jun 14, 2022 at 5:29 PM Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:
>
> Hi Greg,
>
> Greg Hogan 写道:
> > * gnu/packages/valgrind.scm (valgrind/interactive): Update to
> > 3.19.0.
> > [home-page]: Update permanent redirect.
> > * gnu/packages/valgrind.scm (valgrind-3.18): Delete.
> > ---
> > This patch bumps the version of the non-hidden valgrind while
> > removing
> > the pinned-version package.
>
> Unless I'm mistaken these 2 tasks are independent, and should
> hence be split across 2 patches.
I will split the commit and send a v2 patchset upon confirmation of
the valgrind-3.18 removal..
> > Looking through the commit history,
> > I do see
> > a reason for having both a valgrind/interactive and
> > valgrind-3.18.
>
> I thought this was a typo for ‘don't’ at first, but I really can't
> tell.
You are correct, this should have said "don't see a reason".
> I don't see a reason to keep both now, but then I don't see one
> when 50f7402c was committed either. Do you remember, Ludo'?
>
> Kind regards,
>
> T G-R
Thanks for the review!
Greg
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55976
; Package
guix-patches
.
(Wed, 15 Jun 2022 13:56:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55976
; Package
guix-patches
.
(Thu, 07 Jul 2022 14:25:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 55976 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/valgrind.scm (valgrind/interactive): Update to 3.19.0.
[home-page]: Update permanent redirect.
---
gnu/packages/valgrind.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/valgrind.scm b/gnu/packages/valgrind.scm
index 63524d59e9..1356fd57de 100644
--- a/gnu/packages/valgrind.scm
+++ b/gnu/packages/valgrind.scm
@@ -79,7 +79,7 @@ (define-public valgrind
#t))))))
(native-inputs
(list perl))
- (home-page "https://www.valgrind.org/")
+ (home-page "https://valgrind.org/")
(synopsis "Debugging and profiling tool suite")
(description
"Valgrind is an instrumentation framework for building dynamic analysis
@@ -96,7 +96,7 @@ (define-public valgrind
(define-public valgrind/interactive
(package/inherit
valgrind
- (version "3.17.0")
+ (version "3.19.0")
(source (origin
(method url-fetch)
(uri (list (string-append "https://sourceware.org/pub/valgrind"
@@ -105,7 +105,7 @@ (define-public valgrind/interactive
"/valgrind-" version ".tar.bz2")))
(sha256
(base32
- "18l5jbk301j3462gipqn9bkfx44mdmwn0pwr73r40gl1irkfqfmd"))
+ "00lgfgb38xbrilkw6xvqk284dcnnnhbcq03kpvvkyj0sdx438pnx"))
(patches (search-patches
"valgrind-enable-arm.patch"
"valgrind-fix-default-debuginfo-path.patch"))))
--
2.36.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55976
; Package
guix-patches
.
(Thu, 07 Jul 2022 14:25:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 55976 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/valgrind.scm (valgrind-3.18): Delete.
---
gnu/packages/valgrind.scm | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/gnu/packages/valgrind.scm b/gnu/packages/valgrind.scm
index 1356fd57de..8e9a4c39f4 100644
--- a/gnu/packages/valgrind.scm
+++ b/gnu/packages/valgrind.scm
@@ -148,17 +148,3 @@ (define-public valgrind/interactive
(string-length "/usr/lib/debug")
1))))))))))
(properties '())))
-
-(define-public valgrind-3.18
- (package
- (inherit valgrind/interactive)
- (version "3.18.1")
- (source (origin
- (inherit (package-source valgrind/interactive))
- (uri (list (string-append "https://sourceware.org/pub/valgrind"
- "/valgrind-" version ".tar.bz2")
- (string-append "ftp://sourceware.org/pub/valgrind"
- "/valgrind-" version ".tar.bz2")))
- (sha256
- (base32
- "1xgph509i6adv9w2glviw3xrmlz0dssg8992hbvxsbkp7ahrm180"))))))
--
2.36.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55976
; Package
guix-patches
.
(Thu, 07 Jul 2022 14:25:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 55976 <at> debbugs.gnu.org (full text, mbox):
This patchset divides the original patch into separate patches for
updation and deletion.
Greg Hogan (2):
gnu: valgrind/interactive: Update to 3.19.0.
gnu: valgrind-3.18: Delete.
gnu/packages/valgrind.scm | 20 +++-----------------
1 file changed, 3 insertions(+), 17 deletions(-)
--
2.36.1
Reply sent
to
Greg Hogan <code <at> greghogan.com>
:
You have taken responsibility.
(Mon, 07 Nov 2022 18:37:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Greg Hogan <code <at> greghogan.com>
:
bug acknowledged by developer.
(Mon, 07 Nov 2022 18:37:02 GMT)
Full text and
rfc822 format available.
Message #31 received at 55976-done <at> debbugs.gnu.org (full text, mbox):
24 October 2022: valgrind-3.20.0 is available.
On Wed, Jun 15, 2022 at 9:55 AM Greg Hogan <code <at> greghogan.com> wrote:
>
> On Tue, Jun 14, 2022 at 5:29 PM Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:
> >
> > Hi Greg,
> >
> > Greg Hogan 写道:
> > > * gnu/packages/valgrind.scm (valgrind/interactive): Update to
> > > 3.19.0.
> > > [home-page]: Update permanent redirect.
> > > * gnu/packages/valgrind.scm (valgrind-3.18): Delete.
> > > ---
> > > This patch bumps the version of the non-hidden valgrind while
> > > removing
> > > the pinned-version package.
> >
> > Unless I'm mistaken these 2 tasks are independent, and should
> > hence be split across 2 patches.
>
> I will split the commit and send a v2 patchset upon confirmation of
> the valgrind-3.18 removal..
>
> > > Looking through the commit history,
> > > I do see
> > > a reason for having both a valgrind/interactive and
> > > valgrind-3.18.
> >
> > I thought this was a typo for ‘don't’ at first, but I really can't
> > tell.
>
> You are correct, this should have said "don't see a reason".
>
> > I don't see a reason to keep both now, but then I don't see one
> > when 50f7402c was committed either. Do you remember, Ludo'?
> >
> > Kind regards,
> >
> > T G-R
>
> Thanks for the review!
>
> Greg
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 06 Dec 2022 12:24:10 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 113 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.