GNU bug report logs - #55979
[PATCH] gnu: Add java-commons-text

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55979 in the body.
You can then email your comments to 55979 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add java-commons-text
Date: Tue, 14 Jun 2022 21:44:16 +0300

[Message part 1 (text/plain, inline)]

Hello,

here's the patch that adds 'java-commons-text'. [1]

Unfortunately I had to disable tests as they require JUnit5 (which is
missing from GNU Guix at the moment.)

Also many thanks to Julien Lepiller who helped me to update
'java-commons-lang3' to 3.12.0, which in turn was required to package
'java-commons-text'.

- Artyom

References:
1. https://commons.apache.org/proper/commons-text/

[0001-gnu-Add-java-commons-text.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 55979 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>, 55979 <at> debbugs.gnu.org
Subject: Re: [bug#55979] [PATCH] gnu: Add java-commons-text
Date: Wed, 15 Jun 2022 12:53:19 +0200

[Message part 1 (text/plain, inline)]

Hi!

The patch looks good to me. I would just change some things for style: no need for a new line between a keyword and it value in the arguments list, and use a quote or semi-quote instead of list. I think the comments are a bit too much, but I'm not sure what's the riggt amount. If it were me, I would only add a comment to #:tests? saying it depends on junit5 which is not packaged.

Maybe more important, you say it's a dependency for maven-plugin-plugin. In that case, we need to install it with its pom file, to lib/m2. This is done by install-from-pom.

Maybe at this point we should mandate using it for java packages? We can always go back and fix them when needed, but it's much less work to do the right thing from the start.

Just thinking out load, maybe we could add a #:pom argument to the ant-build-system, so we don't have to modify the phases all the time?


On June 14, 2022 8:44:16 PM GMT+02:00, "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> wrote:
>Hello,
>
>here's the patch that adds 'java-commons-text'. [1]
>
>Unfortunately I had to disable tests as they require JUnit5 (which is
>missing from GNU Guix at the moment.)
>
>Also many thanks to Julien Lepiller who helped me to update
>'java-commons-lang3' to 3.12.0, which in turn was required to package
>'java-commons-text'.
>
>- Artyom
>
>References:
>1. https://commons.apache.org/proper/commons-text/
>

[Message part 2 (text/html, inline)]

Message #11 received at 55979 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org, "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>,
 55979 <at> debbugs.gnu.org
Subject: Re: [bug#55979] [PATCH] gnu: Add java-commons-text
Date: Wed, 15 Jun 2022 12:48:48 +0200

[Message part 1 (text/plain, inline)]

Hi!

The patch looks good to me. I would just change some things for style: no need for a new line between a keyword and it value in the arguments list, and use a quote or semi-quote instead of list. I think the comments are a bit too much, but I'm not sure what's the riggt amount. If it were me, I would only add a comment to #:tests? saying it depends on junit5 which is not packaged.

Maybe more important, you say it's a dependency for maven-plugin-plugin. In that case, we need to install it with its pom file, to lib/m2. This is done by install-from-pom.

Maybe at this point we should mandate using it for java packages? We can always go back and fix them when needed, but it's much less work to do the right thing from the start.

Just thinking out load, maybe we could add a #:pom argument to the ant-build-system, so we don't have to modify the phases all the time?

On June 14, 2022 8:44:16 PM GMT+02:00, "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> wrote:
>Hello,
>
>here's the patch that adds 'java-commons-text'. [1]
>
>Unfortunately I had to disable tests as they require JUnit5 (which is
>missing from GNU Guix at the moment.)
>
>Also many thanks to Julien Lepiller who helped me to update
>'java-commons-lang3' to 3.12.0, which in turn was required to package
>'java-commons-text'.
>
>- Artyom
>
>References:
>1. https://commons.apache.org/proper/commons-text/
>

[Message part 2 (text/html, inline)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 55979 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#55979] [PATCH] gnu: Add java-commons-text
Date: Sat, 18 Jun 2022 19:25:29 +0300

[Message part 1 (text/plain, inline)]

Hello Julien,

I've updated the patch according to your suggestions.  Could you please
take a look?

[0001-gnu-Add-java-commons-text.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Thanks!

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 55979 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 55979 <at> debbugs.gnu.org
Subject: Re: [bug#55979] [PATCH] gnu: Add java-commons-text
Date: Sat, 18 Jun 2022 21:42:05 +0200

Le Sat, 18 Jun 2022 19:25:29 +0300,
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> a écrit :

> +    (build-system ant-build-system)
> +    (arguments
> +     (list #:jar-name "java-commons-text.jar"
> +           #:source-dir "src/main/java"
> +           #:test-dir "src/test"
> +           ;; XXX: Tests require JUnit5, namely
> 'org.junit.jupiter.api' module
> +           ;; from JUnit5.

I think ;; tests require junit5
is enough here :)

> +           #:tests? #f
> +           #:phases #~(modify-phases %standard-phases
> +                        (replace 'install
> +                          (install-from-pom "pom.xml")))))

great :)

> +    (inputs
> +     (list java-commons-lang3
> +           java-commons-io))
> +    (propagated-inputs
> +     (list apache-commons-parent-pom-52))

So this is an error, because apache-commons-parent-pom-52 is not the
parent of this package's pom file. Here's the content of the pom file
(btw you can view it easily with "guix build -S java-commons-text"):

  <parent>
    <groupId>org.apache.commons</groupId>
    <artifactId>commons-parent</artifactId>
    <version>51</version>
  </parent>

so the parent is apache-commons-parent-pom-51 (note the version number).

Also in the list of dependencies from that file I see
java-commons-lang3, so it needs to be propagated, otherwise maven might
not be able to find it.

> +    (home-page "https://commons.apache.org/text/")
> +    (synopsis "Library focused on algorithms working on strings")

Message #26 received at 55979 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 55979 <at> debbugs.gnu.org
Subject: Re: [bug#55979] [PATCH] gnu: Add java-commons-text
Date: Mon, 20 Jun 2022 22:50:02 +0300

[Message part 1 (text/plain, inline)]

Hello,

here's an updated version of the patch.  I've added
'apache-commons-parent-pom-51' in the same patch, not sure if it's right
though.

[0001-gnu-Add-java-commons-text.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Thanks!

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 55979 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 55979 <at> debbugs.gnu.org
Subject: Re: [bug#55979] [PATCH] gnu: Add java-commons-text
Date: Thu, 23 Jun 2022 21:45:49 +0300

[Message part 1 (text/plain, inline)]

Hello,

have you had any chance to review my patch?

Thanks!

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 55979-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 55979-done <at> debbugs.gnu.org
Subject: Re: [bug#55979] [PATCH] gnu: Add java-commons-text
Date: Sat, 25 Jun 2022 11:39:36 +0200

I split the patch in two commits (one per package) and pushed to master
as 583537f2d6b8e5cd7f4b2f6cc7a6d7d2c9aeae7a and
2f8929482acf709d36e89ba8aca9d281b8cf6831.

I changed the propagated input of apache-commons-parent-pom-51 to
apache-parent-pom-23 instead of apache-parent-pom-21, because that's
what the pom file contains. I added a full stop at the end of the
commit message.

Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.