GNU bug report logs - #55986
28.1; (setq repeat-keep-prefix t) breaks repeat-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55986 in the body.
You can then email your comments to 55986 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Bernier <john.brnpo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
Date: Wed, 15 Jun 2022 02:22:19 +0200

[Message part 1 (text/plain, inline)]

When using repeat-mode, (setq repeat-keep-prefix t) should allow a
user to keep the previously used prefix when repeating a command.
Instead, setting it to t will somehow break the repeat functionality.
'emacs -Q', reloading the init file or toggling repeat-mode off/on does
not fix it.

[Message part 2 (text/html, inline)]

Message #8 received at 55986 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: John Bernier <john.brnpo <at> gmail.com>
Cc: 55986 <at> debbugs.gnu.org
Subject: Re: bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
Date: Wed, 15 Jun 2022 10:20:52 +0300

> When using repeat-mode, (setq repeat-keep-prefix t) should allow a
> user to keep the previously used prefix when repeating a command.
> Instead, setting it to t will somehow break the repeat functionality.
> 'emacs -Q', reloading the init file or toggling repeat-mode off/on does
> not fix it.

This should be implemented in the next release.

Message #11 received at 55986 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Juri Linkov <juri <at> linkov.net>
Cc: John Bernier <john.brnpo <at> gmail.com>, 55986 <at> debbugs.gnu.org
Subject: Re: bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
Date: Thu, 23 Jun 2022 13:41:35 -0500

Juri Linkov <juri <at> linkov.net> writes:

>> When using repeat-mode, (setq repeat-keep-prefix t) should allow a
>> user to keep the previously used prefix when repeating a command.
>> Instead, setting it to t will somehow break the repeat functionality.
>> 'emacs -Q', reloading the init file or toggling repeat-mode off/on does
>> not fix it.
>
> This should be implemented in the next release.

Do you mean that this is already fixed on master?

Message #14 received at 55986 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: John Bernier <john.brnpo <at> gmail.com>, 55986 <at> debbugs.gnu.org
Subject: Re: bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
Date: Thu, 23 Jun 2022 21:59:02 +0300

forcemerge 51281 55986
thanks

>>> When using repeat-mode, (setq repeat-keep-prefix t) should allow a
>>> user to keep the previously used prefix when repeating a command.
>>> Instead, setting it to t will somehow break the repeat functionality.
>>> 'emacs -Q', reloading the init file or toggling repeat-mode off/on does
>>> not fix it.
>>
>> This should be implemented in the next release.
>
> Do you mean that this is already fixed on master?

Please see the commit ef4954b69c17831f4c8360c436352170305666ea that says:

    * lisp/repeat.el (repeat-keep-prefix): Change default to nil.
    'repeat-keep-prefix' doesn't yet have sufficient support
    that covers all cases in bug#51281, so it's disabled now.

There is a patch in bug#51281 that was too late to install
on the release branch, and moreover it needs more work
that should be finished before the next release.

Message #19 received at 55986 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 51281 <at> debbugs.gnu.org, 55986 <at> debbugs.gnu.org
Subject: Re: bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
Date: Mon, 05 Sep 2022 21:40:14 +0200

Juri Linkov <juri <at> linkov.net> writes:

> I hesitate to make such massive change in repeat.el on the release branch.
>
> I have more patches for repeat.el that I'm unsure about to push.
> One of them is a patch that allows kbd syntax for 'repeat-exit-key':

(I only skimmed these two bug reports lightly.)  This was more than half
a year ago, but at least some of this hasn't been pushed yet?  Are these
changes still on the planning change?

Message #22 received at 55986 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51281 <at> debbugs.gnu.org, 55986 <at> debbugs.gnu.org
Subject: Re: bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
Date: Mon, 03 Oct 2022 22:58:49 +0300

>> I hesitate to make such massive change in repeat.el on the release branch.
>>
>> I have more patches for repeat.el that I'm unsure about to push.
>> One of them is a patch that allows kbd syntax for 'repeat-exit-key':
>
> (I only skimmed these two bug reports lightly.)  This was more than half
> a year ago, but at least some of this hasn't been pushed yet?  Are these
> changes still on the planning change?

One of the patches is pushed in b374952b51, but another change is more massive.

Message #25 received at 55986 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: John Bernier <john.brnpo <at> gmail.com>
Cc: 55986 <at> debbugs.gnu.org
Subject: Re: bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
Date: Tue, 20 Dec 2022 19:22:40 +0200

close 55986 29.0.60
thanks

> When using repeat-mode, (setq repeat-keep-prefix t) should allow a
> user to keep the previously used prefix when repeating a command.
> Instead, setting it to t will somehow break the repeat functionality.
> 'emacs -Q', reloading the init file or toggling repeat-mode off/on does
> not fix it.

Thanks for the bug report.  The bug is fixed now, and closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.