GNU bug report logs - #55996
[PATCH] tests: run overlay-headers.sh with inotify enabled

Previous Next

To reply to this bug, email your comments to 55996 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jan Scheer <jhscheer <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] tests: run overlay-headers.sh with inotify enabled
Date: Wed, 15 Jun 2022 14:50:15 +0200

[Message part 1 (text/plain, inline)]

This test intends to check `tail` for:
"redundant headers for overlapping inotify events while it was
suspended". However, it then runs `tail ---dis` which disables
inotify events. This test should either test both
(`for mode in '' '---disable-inotify'; do`) like what the other
tests do, or only run the test with inotify enabled `tail`.
Since it looks like the intention here was the latter, removing
the `fastpoll` option should suffice.
---
 tests/tail-2/overlay-headers.sh | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/tail-2/overlay-headers.sh
b/tests/tail-2/overlay-headers.sh
index ddd7d6a49..1cf231a7c 100755
--- a/tests/tail-2/overlay-headers.sh
+++ b/tests/tail-2/overlay-headers.sh
@@ -37,9 +37,6 @@ wait4lines_ ()
   [ "$(countlines_)" -ge "$elc" ] || { sleep $delay; return 1; }
 }

-# Speedup the non inotify case
-fastpoll='---dis -s.1 --max-unchanged-stats=1'
-
 # Terminate any background tail process
 cleanup_() {
   kill $pid 2>/dev/null && wait $pid;
@@ -52,7 +49,7 @@ echo start > file2 || framework_failure_
 # Use this as a way to gracefully terminate tail
 env sleep 20 & sleep=$!

-tail $fastpoll --pid=$sleep -f file1 file2 > out & pid=$!
+tail --pid=$sleep -f file1 file2 > out & pid=$!

 kill -0 $pid || fail=1

-- 
2.35.3

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.