GNU bug report logs - #56004
[PATCH] gnu: Add snafu.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56004 in the body.
You can then email your comments to 56004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add snafu.
Date: Wed, 15 Jun 2022 21:19:31 -0500

* gnu/packages/suckless.scm (snafu): New variable.
---
 gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 5aa37657b9..e05ae022df 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
 ;;; Copyright © 2021 Nikolay Korotkiy <sikmir <at> disroot.org>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@ (define-module (gnu packages suckless)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages crates-io)
   #:use-module (gnu packages cups)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages fontutils)
@@ -46,6 +48,7 @@ (define-module (gnu packages suckless)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xorg)
+  #:use-module (guix build-system cargo)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
@@ -189,6 +192,35 @@ (define-public slstatus
 @end itemize")
       (license license:isc))))
 
+(define-public snafu
+  (let ((commit "da0a5eea31e35aef75c698d1c01f559858c17b0d")
+        (revision "0"))
+    (package
+      (name "snafu")
+      (version commit)
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/jsbmg/snafu")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1wi857rdqmg4731wzgry06ndfxk8c40yyrf0whk1wlq7p0n6bd3b"))))
+          (arguments
+            `(#:cargo-inputs
+              (("rust-chrono" ,rust-chrono-0.4))
+              #:tests? #f)) ; There are no tests.
+      (build-system cargo-build-system)
+      (home-page "https://github.com/jsbmg/snafu")
+      (synopsis "Status text for dwm window manager")
+      (description
+"@code{snafu} provides status text for dwm's builtin bar on Linux.  It
+shows battery status, battery capacity, current WIFI connection, and
+the time in a nice format.")
+      (license license:isc))))
+
 (define-public blind
   (package
     (name "blind")
-- 
2.36.1

Message #8 received at 56004 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 56004 <at> debbugs.gnu.org
Subject: Re: bug#56004: [PATCH] gnu: Add snafu.
Date: Thu, 07 Jul 2022 16:52:57 -0400

Hello,

jgart <jgart <at> dismail.de> writes:

> * gnu/packages/suckless.scm (snafu): New variable.
> ---
>  gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 5aa37657b9..e05ae022df 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -12,6 +12,7 @@
>  ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
>  ;;; Copyright © 2021 Nikolay Korotkiy <sikmir <at> disroot.org>
>  ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
> +;;; Copyright © 2022 jgart <jgart <at> dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -32,6 +33,7 @@ (define-module (gnu packages suckless)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages compression)
> +  #:use-module (gnu packages crates-io)
>    #:use-module (gnu packages cups)
>    #:use-module (gnu packages fonts)
>    #:use-module (gnu packages fontutils)
> @@ -46,6 +48,7 @@ (define-module (gnu packages suckless)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages webkit)
>    #:use-module (gnu packages xorg)
> +  #:use-module (guix build-system cargo)
>    #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix download)
> @@ -189,6 +192,35 @@ (define-public slstatus
>  @end itemize")
>        (license license:isc))))
>  
> +(define-public snafu
> +  (let ((commit "da0a5eea31e35aef75c698d1c01f559858c17b0d")
> +        (revision "0"))
> +    (package
> +      (name "snafu")
> +      (version commit)

You'd need write a proper monotonically increasing version via
'git-version', as hinted in info '(guix) Version Numbers'.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://github.com/jsbmg/snafu")
> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1wi857rdqmg4731wzgry06ndfxk8c40yyrf0whk1wlq7p0n6bd3b"))))
> +          (arguments
> +            `(#:cargo-inputs
> +              (("rust-chrono" ,rust-chrono-0.4))
> +              #:tests? #f)) ; There are no tests.
> +      (build-system cargo-build-system)
> +      (home-page "https://github.com/jsbmg/snafu")
> +      (synopsis "Status text for dwm window manager")

Fully capitalize DWM.

> +      (description
> +"@code{snafu} provides status text for dwm's builtin bar on Linux.  It

Remove "on Linux", extraneous information on GNU Guix.

> +shows battery status, battery capacity, current WIFI connection, and

The proper "acronym" capitalization is WiFi.

Could you send a revised patch?

Thanks,

Maxim

Message #13 received at 56004 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 56004 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH v2] gnu: Add snafu.
Date: Sat, 27 Aug 2022 10:53:27 -0500

* gnu/packages/suckless.scm (snafu): New variable.

Here's v2 with your suggestions added. Thanks!
---
 gnu/packages/suckless.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index dbc3537ac6..d971de10f0 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -33,6 +33,7 @@
 (define-module (gnu packages suckless)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages crates-io)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages cups)
   #:use-module (gnu packages fonts)
@@ -49,6 +50,7 @@ (define-module (gnu packages suckless)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xorg)
+  #:use-module (guix build-system cargo)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
@@ -1182,6 +1184,35 @@ (define-public farbfeld
       (home-page "https://git.suckless.org/farbfeld/")
       (license license:isc))))
 
+(define-public snafu
+  (let ((commit "e436fb4f61ca93a4ec85122506b2c2d4fec30eb6")
+        (revision "0"))
+    (package
+      (name "snafu")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/jsbmg/snafu")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1c6ahxw0qz0703my28k2z0kgi0am5bp5d02l4rgyphgvjk1jfv8h"))))
+          (arguments
+            `(#:cargo-inputs
+              (("rust-chrono" ,rust-chrono-0.4))
+              #:tests? #f)) ; There are no tests.
+      (build-system cargo-build-system)
+      (home-page "https://github.com/jsbmg/snafu")
+      (synopsis "Status text for DWM window manager")
+      (description
+"@code{snafu} provides status text for DWM's builtin bar.  It
+shows battery status, battery capacity, current WiFi connection, and
+the time in a nice format.")
+      (license license:isc))))
+
 (define-public svkbd
   (package
     (name "svkbd")
-- 
2.37.2

Message #18 received at 56004-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: jgart <jgart <at> dismail.de>
Cc: 56004-done <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#56004] [PATCH v2] gnu: Add snafu.
Date: Thu, 1 Sep 2022 11:18:17 +0300

[Message part 1 (text/plain, inline)]

Thanks. Patch pushed!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.