GNU bug report logs - #56010
[PATCH] Add treefmt

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56010 in the body.
You can then email your comments to 56010 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Arazas <foo.dogsquared <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add treefmt
Date: Thu, 16 Jun 2022 12:51:14 +0800

Just getting familiar with the workflow of sending a patch series.

Message #8 received at 56010 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Arazas <foo.dogsquared <at> gmail.com>
To: 56010 <at> debbugs.gnu.org
Cc: Gabriel Arazas <foo.dogsquared <at> gmail.com>
Subject: [PATCH 1/2] gnu: rust-sha-1-0.9: Update to 0.9.8.
Date: Thu, 16 Jun 2022 13:00:38 +0800

* gnu/packages/crates-io.scm (rust-sha-1-0.9): Update to 0.9.8.
---
 gnu/packages/crates-io.scm | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 452a22f0f2..dd68c249a8 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -55306,25 +55306,23 @@ (define-public rust-sha-1-0.9
   (package
     (inherit rust-sha-1-0.10)
     (name "rust-sha-1")
-    (version "0.9.1")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (crate-uri "sha-1" version))
-       (file-name
-        (string-append name "-" version ".tar.gz"))
-       (sha256
-        (base32
-         "0w37j7swjkbzgi9mf7ihkw0zfik6vl97fs6jdpqs6r68hvm3c2hp"))))
+    (version "0.9.8")
+    (source (origin
+              (method url-fetch)
+              (uri (crate-uri "sha-1" version))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "19jibp8l9k5v4dnhj5kfhaczdfd997h22qz0hin6pw9wvc9ngkcr"))))
+    (build-system cargo-build-system)
     (arguments
-     `(#:cargo-inputs
-       (("rust-block-buffer" ,rust-block-buffer-0.9)
-        ("rust-cfg-if" ,rust-cfg-if-0.1)
-        ("rust-cpuid-bool" ,rust-cpuid-bool-0.1)
+     `(#:skip-build? #t
+       #:cargo-inputs
+       (("rust-block-buffer" ,rust-block-buffer-0.9) ("rust-cfg-if" ,rust-cfg-if-1)
+        ("rust-cpufeatures" ,rust-cpufeatures-0.2)
         ("rust-digest" ,rust-digest-0.9)
-        ("rust-libc" ,rust-libc-0.2)
         ("rust-opaque-debug" ,rust-opaque-debug-0.3)
-        ("rust-sha1-asm" ,rust-sha1-asm-0.4))
+        ("rust-sha1-asm" ,rust-sha1-asm-0.5))
        #:cargo-development-inputs
        (("rust-digest" ,rust-digest-0.9)
         ("rust-hex-literal" ,rust-hex-literal-0.2))))))

base-commit: a431d1dbc5a009ad852b55e2300465b49bdce362
-- 
2.36.1

Message #11 received at 56010 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Arazas <foo.dogsquared <at> gmail.com>
To: 56010 <at> debbugs.gnu.org
Cc: Gabriel Arazas <foo.dogsquared <at> gmail.com>
Subject: [PATCH 2/2] gnu: Add treefmt.
Date: Thu, 16 Jun 2022 13:00:39 +0800

* gnu/packages/rust-apps.scm (treefmt): New variable.
---
 gnu/packages/rust-apps.scm | 51 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm
index 6d97e289c2..e84528dff2 100644
--- a/gnu/packages/rust-apps.scm
+++ b/gnu/packages/rust-apps.scm
@@ -1129,6 +1129,57 @@ (define-public tectonic
 of support files.")
     (license license:expat)))
 
+(define-public treefmt
+  (package
+    (name "treefmt")
+    (version "0.4.1")
+    (source (origin
+              (method url-fetch)
+              (uri (crate-uri "treefmt" version))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1rarg6rffzl1cf6r167h9p14wr696kwnzr85kwbdy7x7x5zpj5li"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:cargo-inputs (("rust-anyhow" ,rust-anyhow-1) ("rust-console" ,rust-console-0.13)
+                       ("rust-directories" ,rust-directories-3)
+                       ("rust-filetime" ,rust-filetime-0.2)
+                       ("rust-globset" ,rust-globset-0.4)
+                       ("rust-ignore" ,rust-ignore-0.4)
+                       ("rust-log" ,rust-log-0.4)
+                       ("rust-path-clean" ,rust-path-clean-0.1)
+                       ("rust-rayon" ,rust-rayon-1)
+                       ("rust-serde" ,rust-serde-1)
+                       ("rust-serde-json" ,rust-serde-json-1)
+                       ("rust-sha-1" ,rust-sha-1-0.9)
+                       ("rust-structopt" ,rust-structopt-0.3)
+                       ("rust-tempfile" ,rust-tempfile-3)
+                       ("rust-toml" ,rust-toml-0.5)
+                       ("rust-which" ,rust-which-4))
+       #:cargo-development-inputs
+       (("rust-criterion" ,rust-criterion-0.3))))
+    (home-page "https://numtide.github.io/treefmt")
+    (synopsis "Command-line application to format the code tree")
+    (description
+     "This application provides a way to unify the formatting process of the
+codebase. It is nice for large code trees where using multiple formatters are
+common. @command{treefmt} comes with the following features.
+
+@itemize @bullet
+@item Unified CLI and output.
+@item Runs formatters in parallel.
+@item Cache changed files for performance.
+@end itemize
+
+The application does have some design decisions to keep in mind.
+
+@itemize @bullet
+@item The source code is kept under version control, making it possible to revert and check changes.
+@item Only one formatter per file, making outputs idempotent.
+@end itemize")
+    (license license:expat)))
+
 (define-public hex
   (package
     (name "hex")
-- 
2.36.1

Message #16 received at 56010-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Gabriel Arazas <foo.dogsquared <at> gmail.com>
Cc: 56010-done <at> debbugs.gnu.org
Subject: Re: [bug#56010] [PATCH] Add treefmt
Date: Thu, 1 Sep 2022 11:18:23 +0300

[Message part 1 (text/plain, inline)]

On Thu, Jun 16, 2022 at 12:51:14PM +0800, Gabriel Arazas wrote:
> Just getting familiar with the workflow of sending a patch series.
> 

Thanks for sending the patches. I rounded out the commit message of the
first patch and skipped installing the sources in the second patch. And
some minor layout changes in the code to minimize the diff.

I also added a copyright line for you. Patches pushed! Thanks.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.