GNU bug report logs - #5607
23.1; compile error regexps for perl test scripts, mark 2

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5607 in the body.
You can then email your comments to 5607 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; compile error regexps for perl test scripts, mark 2
Date: Sat, 20 Feb 2010 11:15:14 +1100

[Message part 1 (text/plain, inline)]

I eventually got around to revisiting the compile error regexps I made
for perl test scripts in my compilation-perl.el.

I was misguided about the "NOK" business of the perl--Test::Harness one
that's now in emacs.  I believe the three symbols perl--Test,
perl--Test2 and perl--Test::Harness can be replaced by the two simpler
bits of compile.el.perl.fragment below.  compilation.txt fragment below
too, to replace the two sections "* Perl Test module error messages" and
"* Perl Test::Harness output".

2010-02-20  Kevin Ryde  <user42 <at> zip.com.au>

	* progmodes/compile.el (compilation-error-regexp-alist-alist):
	Replace/amend perl--Test, perl--Test2 and perl--Test::Harness with
	better patterns perl--Test and perl--Test-failed.

2010-02-20  Kevin Ryde  <user42 <at> zip.com.au>

	* compilation.txt (Perl Test module, Perl Test::Harness): Replace
	for new perl--Test and perl--Test-failed symbols.

[compile.el.perl.fragment (text/plain, attachment)]

[compilation.txt (text/plain, attachment)]

[Message part 4 (text/plain, inline)]

In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Message #10 received at 5607 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 5607 <at> debbugs.gnu.org
Subject: Re: bug#5607: 23.1;
	compile error regexps for perl test scripts, mark 2
Date: Sun, 02 Dec 2012 14:11:17 +0800

Kevin Ryde <user42 <at> zip.com.au> writes:

> I eventually got around to revisiting the compile error regexps I made
> for perl test scripts in my compilation-perl.el.
>
> I was misguided about the "NOK" business of the perl--Test::Harness one
> that's now in emacs.  I believe the three symbols perl--Test,
> perl--Test2 and perl--Test::Harness can be replaced by the two simpler
> bits of compile.el.perl.fragment below.  compilation.txt fragment below
> too, to replace the two sections "* Perl Test module error messages" and
> "* Perl Test::Harness output".

Sorry for the very late response.

With your patch, the following line from the old compile.txt is no
longer correctly highlighted:

# Test 6 got: "xx" (foo.t at line 33 fail #2)

Is that a valid compilation message?

Message #13 received at 5607 <at> debbugs.gnu.org (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 5607 <at> debbugs.gnu.org
Subject: Re: bug#5607: 23.1;
	compile error regexps for perl test scripts, mark 2
Date: Fri, 07 Dec 2012 09:34:40 +1100

Chong Yidong <cyd <at> gnu.org> writes:
>
> With your patch, the following line from the old compile.txt is no
> longer correctly highlighted:
>
> # Test 6 got: "xx" (foo.t at line 33 fail #2)
>
> Is that a valid compilation message?

Yes.  It should be matched.  My latest and greatest seems to do so
( http://user42.tuxfamily.org/compilation-perl/index.html ).  I'll try
to double check what I posted.


Incidentally, the "cucumber" pattern of the emacs24 seems to match the
perl test intro

# Current time local: Wed Aug 15 12:04:58 2012

I wondered if the cucumber "#" bit might be tightened up.  Maybe its "#"
is never at the start of a line, or something like that.

Message #16 received at 5607 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 5607 <at> debbugs.gnu.org
Subject: Re: bug#5607: 23.1;
 compile error regexps for perl test scripts, mark 2
Date: Sun, 28 Feb 2016 17:10:07 +1100

Kevin Ryde <user42 <at> zip.com.au> writes:

> I eventually got around to revisiting the compile error regexps I made
> for perl test scripts in my compilation-perl.el.
>
> I was misguided about the "NOK" business of the perl--Test::Harness one
> that's now in emacs.  I believe the three symbols perl--Test,
> perl--Test2 and perl--Test::Harness can be replaced by the two simpler
> bits of compile.el.perl.fragment below.  compilation.txt fragment below
> too, to replace the two sections "* Perl Test module error messages" and
> "* Perl Test::Harness output".

[...]

> 2010-02-20  Kevin Ryde  <user42 <at> zip.com.au>
>
> 	* compilation.txt (Perl Test module, Perl Test::Harness): Replace
> 	for new perl--Test and perl--Test-failed symbols.
>
>     (perl--Test
>      ;; Test.pm ok() message when comparing got/want values (printed in
>      ;; its _complain()),
>      ;;
>      ;;     # Test 2 got: "xx" (t-compilation-perl-2.t at line 10)
>      ;;
>      ;; And under Test::Harness can be preceded by progress stuff so
>      ;; allow match anywhere in the line.

[...]

> Yes.  It should be matched.  My latest and greatest seems to do so
> ( http://user42.tuxfamily.org/compilation-perl/index.html ).  I'll try
> to double check what I posted.
>
> Incidentally, the "cucumber" pattern of the emacs24 seems to match the
> perl test intro
>
> # Current time local: Wed Aug 15 12:04:58 2012
>
> I wondered if the cucumber "#" bit might be tightened up.  Maybe its "#"
> is never at the start of a line, or something like that.

It's been three years again, so it's time to revisit this bug report.
:-)

If this is still an issue, can you provide a patch for this instead of
code fragments?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 5607 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 5607 <at> debbugs.gnu.org
Subject: Re: bug#5607: 23.1;
 compile error regexps for perl test scripts, mark 2
Date: Thu, 27 Jun 2019 19:24:52 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> It's been three years again, so it's time to revisit this bug report.
> :-)
>
> If this is still an issue, can you provide a patch for this instead of
> code fragments?

And yet another three years have passed, so I progress seems unlikely on
this bug report, and I'm closing it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.