GNU bug report logs - #56094
[PATCH] gnu: Remove unnecessary sway dependency on elogind.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56094 in the body.
You can then email your comments to 56094 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Remove unnecessary sway dependency on elogind.
Date: Sun, 19 Jun 2022 17:39:05 +0300

* gnu/packages/wm.scm (sway): Cleanup dependencies.
---
 gnu/packages/wm.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index d816bad871..875f73bfe2 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1588,7 +1588,6 @@ (define-public sway
                                "/bin/scdoc'")))
              #t)))))
     (inputs (list cairo
-                  elogind
                   gdk-pixbuf
                   json-c
                   libevdev
-- 
2.36.1

Message #8 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: muradm <mail <at> muradm.net>, 56094 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Remove unnecessary sway dependency on elogind.
Date: Mon, 20 Jun 2022 11:36:40 +0200

Hi,

note that "unnecessary" is quite judgmental.  Why is it unnecessary?
By default, guix tends to include "optional" inputs such as elogind.

Am Sonntag, dem 19.06.2022 um 17:39 +0300 schrieb muradm:
> * gnu/packages/wm.scm (sway): Cleanup dependencies.
The ChangeLog should explicitly say what is done, i.e. (sway)[inputs]:
Remove elogind.


What exactly is the goal here?  As far as I'm aware sway works either
with *logind or seatd or by having itself be setuid.  If the aim is to
support seatd-based services, I think having a sway-with-seatd variant
would be better.

WDYT?

Message #11 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 56094 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Remove unnecessary sway dependency on elogind.
Date: Mon, 20 Jun 2022 13:51:21 +0300

[Message part 1 (text/plain, inline)]

Hi,

elogind/systemd was used via wlroots actually.
wlroots dropped elogind/system in favour of libseat.
libseat can talk to either systemd, elogind or seatd.
this is already reflected in wlroots package.

setuid thing you point is reflected as warning in meson.build.
there is no functionality behind it as far as I know.
and in 1.7 meson does not look at them directly, but via wlroots.
basically informative from sway point of view.

the only thing left behind is swaybar which relays on
either systemd, elogind or basu for system tray functionality.
this could be used as argument for keeping elogind
as dependency.

you may look at #49969 which added the other day
seatd-service-type and greetd stuff.

--
muradm

Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> writes:

> Hi,
>
> note that "unnecessary" is quite judgmental.  Why is it 
> unnecessary?
> By default, guix tends to include "optional" inputs such as 
> elogind.
>
> Am Sonntag, dem 19.06.2022 um 17:39 +0300 schrieb muradm:
>> * gnu/packages/wm.scm (sway): Cleanup dependencies.
> The ChangeLog should explicitly say what is done, i.e. 
> (sway)[inputs]:
> Remove elogind.
>
>
> What exactly is the goal here?  As far as I'm aware sway works 
> either
> with *logind or seatd or by having itself be setuid.  If the aim 
> is to
> support seatd-based services, I think having a sway-with-seatd 
> variant
> would be better.
>
> WDYT?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: muradm <mail <at> muradm.net>
Cc: 56094 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Remove unnecessary sway dependency on elogind.
Date: Tue, 21 Jun 2022 21:12:49 +0200

Am Montag, dem 20.06.2022 um 13:51 +0300 schrieb muradm:
> the only thing left behind is swaybar which relays on
> either systemd, elogind or basu for system tray functionality.
> this could be used as argument for keeping elogind
> as dependency.
I think the way forward would be to package basu and replace elogind
with it, rather than drop it and breaking swaybar.  WDYT?

Message #17 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: 56094 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: [PATCH] gnu: Remove unnecessary sway dependency on elogind.
Date: Wed, 22 Jun 2022 12:27:21 +0300

Should be applied after #56136.

Message #20 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: 56094 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: [PATCH v2] gnu: wm: Switch sway from elogind to basu.
Date: Wed, 22 Jun 2022 12:27:22 +0300

* gnu/packages/wm.scm (basu): Switch sway from elogind to basu.
[inputs]: Replace elogind with basu for sd-bus library dependency.
[arguments]: Use G-expressions.
<#:configure-flags>: Request building against basu.
---
 gnu/packages/wm.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index ecc79f73b9..7570e37239 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1572,7 +1572,8 @@ (define-public sway
         (base32 "0j4sdbsrlvky1agacc0pcz9bwmaxjmrapjnzscbd2i0cria2fc5j"))))
     (build-system meson-build-system)
     (arguments
-     `(#:phases
+     `(#:configure-flags '("-Dsd-bus-provider=basu")
+       #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'hardcode-paths
            (lambda* (#:key inputs #:allow-other-keys)
@@ -1587,8 +1588,8 @@ (define-public sway
                 (string-append "'" (assoc-ref inputs "scdoc")
                                "/bin/scdoc'")))
              #t)))))
-    (inputs (list cairo
-                  elogind
+    (inputs (list basu
+                  cairo
                   gdk-pixbuf
                   json-c
                   libevdev
-- 
2.36.1

Message #23 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: muradm <mail <at> muradm.net>, 56094 <at> debbugs.gnu.org
Cc: control <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: wm: Switch sway from elogind to basu.
Date: Wed, 22 Jun 2022 11:31:48 +0200

block 56094 by 56136
thanks

Am Mittwoch, dem 22.06.2022 um 12:27 +0300 schrieb muradm:
> * gnu/packages/wm.scm (basu): Switch sway from elogind to basu.
Should be sway.
> [inputs]: Replace elogind with basu for sd-bus library dependency.
This can be simplified to "Replace ‘elogind’ with ‘basu’."
> [arguments]: Use G-expressions.
Actually, you don't, and even if, that ought to be a separate commit.
> <#:configure-flags>: Request building against basu.
Is this necessary?  Doesn't sway have autodetection for basu?


Cheers

Message #28 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: control <at> debbugs.gnu.org, 56094 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: wm: Switch sway from elogind to basu.
Date: Wed, 22 Jun 2022 12:38:01 +0300

[Message part 1 (text/plain, inline)]

Next one reflecting changes.

Yes, necessary to state basu explicitly, meson.build detects
like systemd -> elogind -> basu. While removed from sway
dependencies, elogind still comes from dependencies of
dependencies.

--
muradm

Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> writes:

> block 56094 by 56136
> thanks
>
> Am Mittwoch, dem 22.06.2022 um 12:27 +0300 schrieb muradm:
>> * gnu/packages/wm.scm (basu): Switch sway from elogind to basu.
> Should be sway.
>> [inputs]: Replace elogind with basu for sd-bus library 
>> dependency.
> This can be simplified to "Replace ‘elogind’ with ‘basu’."
>> [arguments]: Use G-expressions.
> Actually, you don't, and even if, that ought to be a separate 
> commit.
>> <#:configure-flags>: Request building against basu.
> Is this necessary?  Doesn't sway have autodetection for basu?
>
>
> Cheers

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: muradm <mail <at> muradm.net>
Cc: 56094 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: wm: Switch sway from elogind to basu.
Date: Wed, 22 Jun 2022 11:47:26 +0200

Am Mittwoch, dem 22.06.2022 um 12:38 +0300 schrieb muradm:
> Next one reflecting changes.
> 
> Yes, necessary to state basu explicitly, meson.build detects
> like systemd -> elogind -> basu. While removed from sway
> dependencies, elogind still comes from dependencies of
> dependencies.
We call that a transitive propagated input.  You should probably add a
comment that elogind "still exists" and justify your defensive
programming in there.

Cheers

Message #34 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: 56094 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: [PATCH v3] gnu: wm: Switch sway from elogind to basu.
Date: Wed, 22 Jun 2022 12:52:49 +0300

* gnu/packages/wm.scm (sway): Replace ‘elogind’ with ‘basu’.
[inputs]: Replace ‘elogind’ with ‘basu’.
[arguments]:
<#:configure-flags>: Request building against basu.
`elogind` still exists as transitive propagated input,
while `meson.build` auto detects by probing `systemd`,
`elogind` and `basu` in respective order.
---
 gnu/packages/wm.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index ecc79f73b9..7570e37239 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1572,7 +1572,8 @@ (define-public sway
         (base32 "0j4sdbsrlvky1agacc0pcz9bwmaxjmrapjnzscbd2i0cria2fc5j"))))
     (build-system meson-build-system)
     (arguments
-     `(#:phases
+     `(#:configure-flags '("-Dsd-bus-provider=basu")
+       #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'hardcode-paths
            (lambda* (#:key inputs #:allow-other-keys)
@@ -1587,8 +1588,8 @@ (define-public sway
                 (string-append "'" (assoc-ref inputs "scdoc")
                                "/bin/scdoc'")))
              #t)))))
-    (inputs (list cairo
-                  elogind
+    (inputs (list basu
+                  cairo
                   gdk-pixbuf
                   json-c
                   libevdev
-- 
2.36.1

Message #37 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: muradm <mail <at> muradm.net>, 56094 <at> debbugs.gnu.org
Subject: Re: [PATCH v3] gnu: wm: Switch sway from elogind to basu.
Date: Wed, 22 Jun 2022 11:57:17 +0200

Am Mittwoch, dem 22.06.2022 um 12:52 +0300 schrieb muradm:
> * gnu/packages/wm.scm (sway): Replace ‘elogind’ with ‘basu’.
> [inputs]: Replace ‘elogind’ with ‘basu’.
Collapse to (sway)[inputs].  No need to repeat yourself.
> [arguments]:
> <#:configure-flags>: Request building against basu.
Since we're at it, this should actually be "Add [the flag]".
> `elogind` still exists as transitive propagated input,
> while `meson.build` auto detects by probing `systemd`,
> `elogind` and `basu` in respective order.
In the source, not in the commit message :P
Can be shortened to "elogind is propagated by [input] and would
otherwise shadow basu".


Cheers

Message #40 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: 56094 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: [PATCH v4] gnu: wm: Switch sway from elogind to basu.
Date: Wed, 22 Jun 2022 13:35:48 +0300

* gnu/packages/wm.scm (sway):
[inputs]: Replace ‘elogind’ with ‘basu’.
[arguments]: Add -Dsd-bus-provider=basu flag.
---
 gnu/packages/wm.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index ecc79f73b9..0ea7641db3 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1572,7 +1572,10 @@ (define-public sway
         (base32 "0j4sdbsrlvky1agacc0pcz9bwmaxjmrapjnzscbd2i0cria2fc5j"))))
     (build-system meson-build-system)
     (arguments
-     `(#:phases
+     `(;; elogind is propagated by wlroots -> libseat
+       ;; and would otherwise shadow basu.
+       #:configure-flags '("-Dsd-bus-provider=basu")
+       #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'hardcode-paths
            (lambda* (#:key inputs #:allow-other-keys)
@@ -1587,8 +1590,8 @@ (define-public sway
                 (string-append "'" (assoc-ref inputs "scdoc")
                                "/bin/scdoc'")))
              #t)))))
-    (inputs (list cairo
-                  elogind
+    (inputs (list basu
+                  cairo
                   gdk-pixbuf
                   json-c
                   libevdev
-- 
2.36.1

Message #43 received at 56094 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: muradm <mail <at> muradm.net>, 56094 <at> debbugs.gnu.org
Subject: Re: [PATCH v4] gnu: wm: Switch sway from elogind to basu.
Date: Wed, 22 Jun 2022 12:39:42 +0200

Am Mittwoch, dem 22.06.2022 um 13:35 +0300 schrieb muradm:
> * gnu/packages/wm.scm (sway):
> [inputs]: Replace ‘elogind’ with ‘basu’.
> [arguments]: Add -Dsd-bus-provider=basu flag.
Tiny nitpick, should literally be “Add "-Dsd-bus-provider=basu"”
(see how quoting this is hard?)  You don't need to send a v5 though,
I'll just reword it once basu is ready.


Cheers

Message #48 received at 56094-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: muradm <mail <at> muradm.net>, 56136-done <at> debbugs.gnu.org, Maxime Devos
 <maximedevos <at> telenet.be>, 56094-done <at> debbugs.gnu.org
Subject: Re: [PATCH v4] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 21:36:53 +0200

Am Mittwoch, dem 22.06.2022 um 16:21 +0300 schrieb muradm:
> * gnu/packages/freedesktop.scm (basu): New variable.
Pushed along with the original issue.  Reworded both slightly.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.