GNU bug report logs - #56115
[PATCH] python-build-system: Fix typo in module-level comment paragraph.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Mon, 20 Jun 2022 21:18:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56115 in the body.
You can then email your comments to 56115 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#56115; Package guix-patches. (Mon, 20 Jun 2022 21:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 20 Jun 2022 21:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] python-build-system: Fix typo in module-level comment
 paragraph.
Date: Mon, 20 Jun 2022 16:17:33 -0500
* guix/build/python-build-system.scm: Fix typo in comment paragraph.
---
 guix/build/python-build-system.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 08871f60cd..28041e90a3 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -68,7 +68,7 @@ (define-module (guix build python-build-system)
 ;; downloading the package source from PyPI (the Python Package Index).  Both
 ;; of them import setuptools and execute the "setup.py" file under their
 ;; control.  Thus the "setup.py" behaves as if the developer had imported
-;; setuptools within setup.py - even is still using only distutils.
+;; setuptools within setup.py - even if it is still using only distutils.
 ;;
 ;; Setuptools' "install" command (to be more precise: the "easy_install"
 ;; command which is called by "install") will put the path of the currently
-- 
2.36.1





Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Wed, 22 Jun 2022 18:41:02 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Wed, 22 Jun 2022 18:41:02 GMT) Full text and rfc822 format available.

Message #10 received at 56115-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 56115-done <at> debbugs.gnu.org
Subject: Re: bug#56115: [PATCH] python-build-system: Fix typo in
 module-level comment paragraph.
Date: Wed, 22 Jun 2022 14:40:22 -0400
Hi,

jgart <jgart <at> dismail.de> writes:

> * guix/build/python-build-system.scm: Fix typo in comment paragraph.
> ---
>  guix/build/python-build-system.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 08871f60cd..28041e90a3 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -68,7 +68,7 @@ (define-module (guix build python-build-system)
>  ;; downloading the package source from PyPI (the Python Package Index).  Both
>  ;; of them import setuptools and execute the "setup.py" file under their
>  ;; control.  Thus the "setup.py" behaves as if the developer had imported
> -;; setuptools within setup.py - even is still using only distutils.
> +;; setuptools within setup.py - even if it is still using only distutils.
>  ;;
>  ;; Setuptools' "install" command (to be more precise: the "easy_install"
>  ;; command which is called by "install") will put the path of the currently

Thanks.  Unfortunately this simply typo fix causes a world rebuild.  I'd
suggest flagging such patches with the 'core-updates PATCH' prefix, as
hinted in info '(guix) Submitting Patches' to avoid committers from
unintentionally pushing these to master.

Applied to core-updates.

Closing!

Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#56115; Package guix-patches. (Thu, 23 Jun 2022 00:49:02 GMT) Full text and rfc822 format available.

Message #13 received at 56115-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 56115-done <at> debbugs.gnu.org
Subject: Re: bug#56115: [PATCH] python-build-system: Fix typo in module-level
 comment paragraph.
Date: Wed, 22 Jun 2022 19:48:48 -0500
On Wed, 22 Jun 2022 14:40:22 -0400 Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
> Thanks.  Unfortunately this simply typo fix causes a world rebuild.  I'd
> suggest flagging such patches with the 'core-updates PATCH' prefix, as
> hinted in info '(guix) Submitting Patches' to avoid committers from
> unintentionally pushing these to master.
> 
> Applied to core-updates.

Thanks! I'll keep that in mind on the next one and I'll try to add a note in the docs soon about this unless you do first.

all best,

jgart




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 21 Jul 2022 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 251 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.