GNU bug report logs - #56127
[PATCH] gnu: polybar: Update to 3.6.3.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56127 in the body.
You can then email your comments to 56127 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: polybar: Update to 3.6.3.
Date: Tue, 21 Jun 2022 18:21:47 +0000

[Message part 1 (text/plain, inline)]

Hi Guix,

Here is a patch to update polybar. There were some slight tweaks needed: new input, remove unneeded native-input, and change where the default configuration file is installed (from /etc) to #$output/etc/xdg.

This last change may look slightly different from the default behavior, but this will put it where it should be found using XDG_CONFIG_DIRS. This was made in the change to polybar that also moved/altered the configuration installation: https://github.com/polybar/polybar/commit/282b0f4e73e9cbb68afd6e168c472e3f422e9a6f#diff-6b4c594394f4751f9012dc3889b278312f0e7275ab48edbe3b02d434e183aa52

I tested that it builds and polybar will find this default configuration file when no config is otherwise found or specified. The default bar looked fine to me. Note that I did test this where I do have XDG_CONFIG_DIRS set for that profile anyway.

Thanks!
John

[0001-gnu-polybar-Update-to-3.6.3.patch (text/x-patch, attachment)]

Message #8 received at 56127 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: John Kehayias <john.kehayias <at> protonmail.com>, 56127 <at> debbugs.gnu.org
Subject: Re: [bug#56127] [PATCH] gnu: polybar: Update to 3.6.3.
Date: Wed, 22 Jun 2022 15:42:50 +0200

Hello John

John Kehayias via Guix-patches via <guix-patches <at> gnu.org> writes:

> Hi Guix,
>
> Here is a patch to update polybar. There were some slight tweaks needed: new input, remove unneeded native-input, and change where the default configuration file is installed (from /etc) to #$output/etc/xdg.
>
> This last change may look slightly different from the default behavior, but this will put it where it should be found using XDG_CONFIG_DIRS. This was made in the change to polybar that also moved/altered the configuration installation: https://github.com/polybar/polybar/commit/282b0f4e73e9cbb68afd6e168c472e3f422e9a6f#diff-6b4c594394f4751f9012dc3889b278312f0e7275ab48edbe3b02d434e183aa52
>
> I tested that it builds and polybar will find this default configuration file when no config is otherwise found or specified. The default bar looked fine to me. Note that I did test this where I do have XDG_CONFIG_DIRS set for that profile anyway.

Looks good to me as-is, builds and runs fine, although I'd prefer to
keep the file at /etc/, and patch src/utils/file.cpp to look for
$output/etc/polybar/config.ini.  That way, polybar would work without a
config file even when not installed.  Also, if you have the time, could
you move the native-inputs to the new style as an additional commit?

WDYT?
-- 
Josselin Poiret

Message #11 received at 56127 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 56127 <at> debbugs.gnu.org
Subject: Re: [bug#56127] [PATCH] gnu: polybar: Update to 3.6.3.
Date: Wed, 22 Jun 2022 14:35:00 +0000

Hi Josselin,

------- Original Message -------
On Wednesday, June 22nd, 2022 at 9:42 AM, Josselin Poiret <dev <at> jpoiret.xyz> wrote:


>
> Looks good to me as-is, builds and runs fine, although I'd prefer to
> keep the file at /etc/, and patch src/utils/file.cpp to look for
> $output/etc/polybar/config.ini. That way, polybar would work without a
> config file even when not installed. Also, if you have the time, could
> you move the native-inputs to the new style as an additional commit?
>
> WDYT?

Not sure I understand what you mean by not needing to have polybar installed. Do you mean not having to worry about XDG_CONFIG_DIRS being set up? Running directly from /gnu/store? I can make that change (it was the alternative I thought of too) if that would help useability for a new user without a config.

And yes, can update with a second commit to clean native-inputs as well.

Thanks for taking a look!

John

Message #14 received at 56127 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 56127 <at> debbugs.gnu.org
Subject: Re: [bug#56127] [PATCH] gnu: polybar: Update to 3.6.3.
Date: Thu, 23 Jun 2022 12:16:06 +0200

Hi John,

John Kehayias <john.kehayias <at> protonmail.com> writes:

> Not sure I understand what you mean by not needing to have polybar installed. Do you mean not having to worry about XDG_CONFIG_DIRS being set up? Running directly from /gnu/store? I can make that change (it was the alternative I thought of too) if that would help useability for a new user without a config.

Yes, I meant running from store or using `guix shell polybar -- polybar`
(which does not setup XDG_CONFIG_DIRS).

> And yes, can update with a second commit to clean native-inputs as well.

Great!

> Thanks for taking a look!

Thank you for your contribution!

Best,
-- 
Josselin Poiret

Message #17 received at 56127 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 56127 <at> debbugs.gnu.org
Subject: Re: [bug#56127] [PATCH 1/2 v2] gnu: polybar: Update to 3.6.3.
Date: Thu, 23 Jun 2022 14:40:34 +0000

[Message part 1 (text/plain, inline)]

Hi Josselin,

------- Original Message -------
On Thursday, June 23rd, 2022 at 6:16 AM, Josselin Poiret wrote:
>
> Yes, I meant running from store or using `guix shell polybar -- polybar`
> (which does not setup XDG_CONFIG_DIRS).
>

Done in the update first patch, checked that now `guix shell polybar -- polybar` finds the default config.

> > And yes, can update with a second commit to clean native-inputs as well.
>

Added this second little patch.

Thanks!
John

[0001-gnu-polybar-Update-to-3.6.3.patch (text/x-patch, attachment)]

Message #20 received at 56127 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 56127 <at> debbugs.gnu.org
Subject: Re: [bug#56127] [PATCH 2/2] gnu: polybar: Simplify inputs.
Date: Thu, 23 Jun 2022 14:41:39 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0002-gnu-polybar-Simply-inputs.patch (text/x-patch, attachment)]

Message #25 received at 56127-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, 56127-done <at> debbugs.gnu.org
Subject: Re: bug#56127: [PATCH] gnu: polybar: Update to 3.6.3.
Date: Thu, 23 Jun 2022 22:29:14 +0200

Hi John,

John Kehayias <john.kehayias <at> protonmail.com> skribis:

> From addc99adfc0013da57dcda43df96fca11eb33d1c Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias <at> protonmail.com>
> Date: Tue, 21 Jun 2022 14:14:08 -0400
> Subject: [PATCH 1/2] gnu: polybar: Update to 3.6.3.
>
> * gnu/packages/wm.scm (polybar): Update to 3.6.3.
> [phases]: Add patch-config-path for polybar to find its default configuration
> file in the store.
> [inputs]: Add libuv, required to build polybar.
> [native-inputs]: Remove python-2, no longer needed.

Applied together with the patch that removes input labels.

Thank you, and thanks Josselin for reviewing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.