GNU bug report logs - #56136
[PATCH] gnu: freedesktop: Add basu 0.2.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56136 in the body.
You can then email your comments to 56136 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: guix-patches <at> gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: [PATCH] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 11:40:35 +0300

* gnu/packages/freedesktop.scm (basu): New variable.
---
 gnu/packages/freedesktop.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 29bb7c1664..7269520a21 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2021, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
+;;; Copyright © 2022 muradm <mail <at> muradm.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -702,6 +703,30 @@ (define-public elogind
 of a the system to know what users are logged in, and where.")
     (license license:lgpl2.1+)))
 
+(define-public basu
+  (package
+    (name "basu")
+    (version "0.2.0")
+    (home-page "https://git.sr.ht/~emersion/basu")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url home-page)
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0h23n7wg18xc7xwldca18wi00iajyliixwicqyvv38qx831d8q18"))))
+    (build-system meson-build-system)
+    (inputs
+     (list pkg-config python gperf libcap))
+    (synopsis "The sd-bus library, extracted from systemd.")
+    (description "Some projects rely on the sd-bus library for DBus support.
+However not all systems have systemd or elogind installed.
+This library provides just sd-bus (and the busctl utility).")
+    (license license:gpl2)))
+
 (define-public localed
   ;; XXX: This package is extracted from systemd but we retain so little of it
   ;; that it would make more sense to maintain a fork of the bits we need.
-- 
2.36.1

Message #10 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: muradm <mail <at> muradm.net>, 56136 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: Re: [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 12:02:18 +0200

[Message part 1 (text/plain, inline)]

muradm schreef op wo 22-06-2022 om 11:40 [+0300]:
> +    (license license:gpl2)))

Looking at
<https://git.sr.ht/~emersion/basu/tree/master/item/meson.build#L5>, it
seems to be LGPL2.1+, not GPL-2-only?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: 56136 <at> debbugs.gnu.org,
	Maxime Devos <maximedevos <at> telenet.be>
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: [PATCH v2] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 13:32:29 +0300

* gnu/packages/freedesktop.scm (basu): New variable.
---
 gnu/packages/freedesktop.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 29bb7c1664..bcd083a316 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2021, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
+;;; Copyright © 2022 muradm <mail <at> muradm.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -702,6 +703,30 @@ (define-public elogind
 of a the system to know what users are logged in, and where.")
     (license license:lgpl2.1+)))
 
+(define-public basu
+  (package
+    (name "basu")
+    (version "0.2.0")
+    (home-page "https://git.sr.ht/~emersion/basu")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url home-page)
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0h23n7wg18xc7xwldca18wi00iajyliixwicqyvv38qx831d8q18"))))
+    (build-system meson-build-system)
+    (inputs
+     (list pkg-config python gperf libcap))
+    (synopsis "The sd-bus library, extracted from systemd.")
+    (description "Some projects rely on the sd-bus library for DBus support.
+However not all systems have systemd or elogind installed.
+This library provides just sd-bus (and the busctl utility).")
+    (license license:lgpl2.1+)))
+
 (define-public localed
   ;; XXX: This package is extracted from systemd but we retain so little of it
   ;; that it would make more sense to maintain a fork of the bits we need.
-- 
2.36.1

Message #16 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: muradm <mail <at> muradm.net>, 56136 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: Re: [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 13:54:28 +0200

[Message part 1 (text/plain, inline)]

muradm schreef op wo 22-06-2022 om 11:40 [+0300]:
> +    (inputs
> +     (list pkg-config python gperf libcap))

(Didn't notice this previously):

  * gperf is a binary (usually) run during the build to generate stuff,
    so it needs to be in native-inputs for cross-compilation to work.

  * pkg-config is almost surely needs to be native-inputs (it's like a
    (cross-) compiler).  "./pre-inst-env guix lint basu" probably would
    report this.

    As a test, you can try
    "./pre-inst-env guix build basu --target=aarch64-linux-gnu" or
    such.

  * whether python is native- or non-native depends on how it is used.

  * libcap looks fine from here.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: 56136 <at> debbugs.gnu.org,
	Maxime Devos <maximedevos <at> telenet.be>
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: [PATCH v3] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 15:00:59 +0300

* gnu/packages/freedesktop.scm (basu): New variable.
---
 gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 29bb7c1664..1b0f21c0e4 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2021, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
+;;; Copyright © 2022 muradm <mail <at> muradm.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -702,6 +703,32 @@ (define-public elogind
 of a the system to know what users are logged in, and where.")
     (license license:lgpl2.1+)))
 
+(define-public basu
+  (package
+    (name "basu")
+    (version "0.2.0")
+    (home-page "https://git.sr.ht/~emersion/basu")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url home-page)
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0h23n7wg18xc7xwldca18wi00iajyliixwicqyvv38qx831d8q18"))))
+    (build-system meson-build-system)
+    (native-inputs
+     (list pkg-config python gperf))
+    (inputs
+     (list libcap))
+    (synopsis "The sd-bus library, extracted from systemd.")
+    (description "Some projects rely on the sd-bus library for DBus support.
+However not all systems have systemd or elogind installed.
+This library provides just sd-bus (and the busctl utility).")
+    (license license:lgpl2.1+)))
+
 (define-public localed
   ;; XXX: This package is extracted from systemd but we retain so little of it
   ;; that it would make more sense to maintain a fork of the bits we need.
-- 
2.36.1

Message #22 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>,
 56136 <at> debbugs.gnu.org
Subject: Re: [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 15:07:09 +0300

[Message part 1 (text/plain, inline)]

Fixed in v3

Maxime Devos <maximedevos <at> telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> muradm schreef op wo 22-06-2022 om 11:40 [+0300]:
>> +    (inputs
>> +     (list pkg-config python gperf libcap))
>
> (Didn't notice this previously):
>
>   * gperf is a binary (usually) run during the build to generate 
>   stuff,
>     so it needs to be in native-inputs for cross-compilation to 
>     work.
>
>   * pkg-config is almost surely needs to be native-inputs (it's 
>   like a
>     (cross-) compiler).  "./pre-inst-env guix lint basu" 
>     probably would
>     report this.
Didn't see any warning or else.

>
>     As a test, you can try
>     "./pre-inst-env guix build basu --target=aarch64-linux-gnu" 
>     or
>     such.
>
>   * whether python is native- or non-native depends on how it is 
>   used.
Python nedeed by gperf scripts, so native- also.

>
>   * libcap looks fine from here.
>
> Greetings,
> Maxime.
>
> [[End of PGP Signed Part]]

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: muradm <mail <at> muradm.net>
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>,
 56136 <at> debbugs.gnu.org
Subject: Re: [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 15:08:59 +0200

[Message part 1 (text/plain, inline)]

muradm schreef op wo 22-06-2022 om 15:07 [+0300]:
> >    * pkg-config is almost surely needs to be native-inputs (it's 
> >    like a
> >      (cross-) compiler).  "./pre-inst-env guix lint basu" 
> >      probably would
> >      report this.
> Didn't see any warning or else.

Can't reproduce:

$ guix lint -L . basu  # (*)
./a.scm:24:5: basu <at> 0.2.0: ‘pkg-config’ zou waarschijnlijk inheemse voer moeten zijn
./a.scm:25:14: basu <at> 0.2.0: geen punt toegestaan aan het einde van de synopsis
fetching CVE database for 2022...
fetching CVE database for 2021...
fetching CVE database for 2020...
[...]

(i.e.: the translation for 'native' is in retrospect confusing, pkg-config should
probably be a native-input instead and a synopsis may not end with a period)

(*): I put the package definition into a separate file, hence the -L ..  In your case,
that would be  './pre-inst-env guix lint basu' instead

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>,
 56136 <at> debbugs.gnu.org
Subject: Re: [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 16:14:07 +0300

[Message part 1 (text/plain, inline)]

For v3 with lint I got only this:

gnu/packages/freedesktop.scm:726:14: basu <at> 0.2.0: no period allowed 
at the end of the synopsis

v4 has no lint warnings.

--
muradm

Maxime Devos <maximedevos <at> telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> muradm schreef op wo 22-06-2022 om 15:07 [+0300]:
>> >    * pkg-config is almost surely needs to be native-inputs 
>> > (it's
>> >    like a
>> >      (cross-) compiler).  "./pre-inst-env guix lint basu"
>> >      probably would
>> >      report this.
>> Didn't see any warning or else.
>
> Can't reproduce:
>
> $ guix lint -L . basu  # (*)
> ./a.scm:24:5: basu <at> 0.2.0: ‘pkg-config’ zou waarschijnlijk 
> inheemse voer moeten zijn
> ./a.scm:25:14: basu <at> 0.2.0: geen punt toegestaan aan het einde 
> van de synopsis
> fetching CVE database for 2022...
> fetching CVE database for 2021...
> fetching CVE database for 2020...
> [...]
>
> (i.e.: the translation for 'native' is in retrospect confusing, 
> pkg-config should
> probably be a native-input instead and a synopsis may not end 
> with a period)
>
> (*): I put the package definition into a separate file, hence 
> the -L ..  In your case,
> that would be  './pre-inst-env guix lint basu' instead
>
> Greetings,
> Maxime.
>
> [[End of PGP Signed Part]]

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: 56136 <at> debbugs.gnu.org,
	Maxime Devos <maximedevos <at> telenet.be>
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Subject: [PATCH v4] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 16:21:41 +0300

* gnu/packages/freedesktop.scm (basu): New variable.
---
 gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 29bb7c1664..4d06235771 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2021, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
+;;; Copyright © 2022 muradm <mail <at> muradm.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -702,6 +703,32 @@ (define-public elogind
 of a the system to know what users are logged in, and where.")
     (license license:lgpl2.1+)))
 
+(define-public basu
+  (package
+    (name "basu")
+    (version "0.2.0")
+    (home-page "https://git.sr.ht/~emersion/basu")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url home-page)
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0h23n7wg18xc7xwldca18wi00iajyliixwicqyvv38qx831d8q18"))))
+    (build-system meson-build-system)
+    (native-inputs
+     (list pkg-config python gperf))
+    (inputs
+     (list libcap))
+    (synopsis "The sd-bus library, extracted from systemd")
+    (description "Some projects rely on the sd-bus library for DBus support.
+However not all systems have systemd or elogind installed.
+This library provides just sd-bus (and the busctl utility).")
+    (license license:lgpl2.1+)))
+
 (define-public localed
   ;; XXX: This package is extracted from systemd but we retain so little of it
   ;; that it would make more sense to maintain a fork of the bits we need.
-- 
2.36.1

Message #34 received at 56136 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: muradm <mail <at> muradm.net>
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>,
 56136 <at> debbugs.gnu.org
Subject: Re: [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 18:32:04 +0200

[Message part 1 (text/plain, inline)]

muradm schreef op wo 22-06-2022 om 16:14 [+0300]:
> For v3 with lint I got only this:
> 
> gnu/packages/freedesktop.scm:726:14: basu <at> 0.2.0: no period allowed 
> at the end of the synopsis

My comment was on the v2, not the v3.  You wrote that:

> >   * pkg-config is almost surely needs to be native-inputs (it's 
> >   like a
> >     (cross-) compiler).  "./pre-inst-env guix lint basu" 
> >     probably would
> >     report this.
> Didn't see any warning or else.

... which would seem to be somehow a bug in "guix lint" or an incorrect
use of "guix lint".  Basically, I don't understand how you didn't get
any warnings.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #39 received at 56136-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: muradm <mail <at> muradm.net>, 56136-done <at> debbugs.gnu.org, Maxime Devos
 <maximedevos <at> telenet.be>, 56094-done <at> debbugs.gnu.org
Subject: Re: [PATCH v4] gnu: freedesktop: Add basu 0.2.0.
Date: Wed, 22 Jun 2022 21:36:53 +0200

Am Mittwoch, dem 22.06.2022 um 16:21 +0300 schrieb muradm:
> * gnu/packages/freedesktop.scm (basu): New variable.
Pushed along with the original issue.  Reworded both slightly.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.