GNU bug report logs - #56139
[PATCH 0/4] Make window managers use libinput-minimal instead of libinput

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56139 in the body.
You can then email your comments to 56139 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH 0/4] Make window managers use libinput-minimal instead of
 libinput
Date: Wed, 22 Jun 2022 14:14:15 +0200

This reduces their total closure, since libinput pulls in gtk+ which
adds roughly 400MiB.

Josselin Poiret (4):
  gnu: wlroots: Replace input libinput by libinput-minimal.
  gnu: sway: Replace input libinput by libinput-minimal.
  gnu: waybar: Replace input libinput by libinput-minimal.
  gnu: hikari: Replace input libinput by libinput-minimal.

 gnu/packages/wm.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


base-commit: e74fa406e1043547242a8b67ab9907fea7aae6b9
-- 
2.36.1

Message #8 received at 56139 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: 56139 <at> debbugs.gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH 1/4] gnu: wlroots: Replace input libinput by libinput-minimal.
Date: Wed, 22 Jun 2022 14:17:30 +0200

* gnu/packages/wm.scm (wlroots)[propagated-inputs]: Replace libinput
by libinput-minimal to reduce closure.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index ecc79f73b9..fb5a6bc5b3 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1538,7 +1538,7 @@ (define-public wlroots
     (propagated-inputs
      (list ;; As required by wlroots.pc.
            eudev
-           libinput
+           libinput-minimal
            libxkbcommon
            mesa
            pixman
-- 
2.36.1

Message #11 received at 56139 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: 56139 <at> debbugs.gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH 2/4] gnu: sway: Replace input libinput by libinput-minimal.
Date: Wed, 22 Jun 2022 14:17:31 +0200

* gnu/packages/wm.scm (sway)[propagated-inputs]: Replace libinput
by libinput-minimal to reduce closure.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index fb5a6bc5b3..3fd4ed6ca4 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1592,7 +1592,7 @@ (define-public sway
                   gdk-pixbuf
                   json-c
                   libevdev
-                  libinput
+                  libinput-minimal
                   libxkbcommon
                   pango
                   swaybg
-- 
2.36.1

Message #14 received at 56139 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: 56139 <at> debbugs.gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH 3/4] gnu: waybar: Replace input libinput by libinput-minimal.
Date: Wed, 22 Jun 2022 14:17:32 +0200

* gnu/packages/wm.scm (waybar)[propagated-inputs]: Replace libinput
by libinput-minimal to reduce closure.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 3fd4ed6ca4..8c312e5115 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1724,7 +1724,7 @@ (define-public waybar
                   gtkmm-3
                   jsoncpp
                   libdbusmenu
-                  libinput
+                  libinput-minimal
                   libmpdclient
                   libnl
                   libxml2
-- 
2.36.1

Message #17 received at 56139 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: 56139 <at> debbugs.gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH 4/4] gnu: hikari: Replace input libinput by libinput-minimal.
Date: Wed, 22 Jun 2022 14:17:33 +0200

* gnu/packages/wm.scm (hikari)[propagated-inputs]: Replace libinput
by libinput-minimal to reduce closure.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 8c312e5115..a23acfd3f8 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -2561,7 +2561,7 @@ (define-public hikari
      (list bmake pkg-config wayland-protocols))
     (inputs
      `(("cairo" ,cairo)
-       ("libinput" ,libinput)
+       ("libinput" ,libinput-minimal)
        ("libucl" ,libucl)
        ("libxkbcommon" ,libxkbcommon)
        ("pam" ,linux-pam)
-- 
2.36.1

Message #22 received at 56139-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 56139-done <at> debbugs.gnu.org
Subject: Re: bug#56139: [PATCH 0/4] Make window managers use
 libinput-minimal instead of libinput
Date: Thu, 23 Jun 2022 22:20:49 +0200

Hi,

Josselin Poiret <dev <at> jpoiret.xyz> skribis:

> This reduces their total closure, since libinput pulls in gtk+ which
> adds roughly 400MiB.

Good catch; applied, thanks!

It never occurred to me that it could depend on GTK+; apparently that’s
for some debugging GUI, but it’s not clear how it’s supposed to get
invoked:

--8<---------------cut here---------------start------------->8---
$ grep -r 2i4ykhraljp7jhhs76v44c51kkz31f01 $(guix build libinput)
grep: /gnu/store/brbdvjj4k9g80c2vdv8cfkckwd1q9dsk-libinput-1.19.2/libexec/libinput/libinput-debug-gui: binary file matches
grep: /gnu/store/brbdvjj4k9g80c2vdv8cfkckwd1q9dsk-libinput-1.19.2/etc/ld.so.cache: binary file matches
$ grep -r libinput-debug-gui $(guix build libinput)
$ echo $?
1
--8<---------------cut here---------------end--------------->8---

What’s is it used for?

Ludo’.

Message #25 received at 56139-done <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>, Josselin Poiret
 <dev <at> jpoiret.xyz>
Cc: 56139-done <at> debbugs.gnu.org
Subject: Re: bug#56139: [PATCH 0/4] Make window managers use
 libinput-minimal instead of libinput
Date: Thu, 23 Jun 2022 22:34:08 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op do 23-06-2022 om 22:20 [+0200]:
> Hi,
> 
> Josselin Poiret <dev <at> jpoiret.xyz> skribis:
> 
> > This reduces their total closure, since libinput pulls in gtk+ which
> > adds roughly 400MiB.
> 
> Good catch; applied, thanks!
> 
> It never occurred to me that it could depend on GTK+; apparently that’s
> for some debugging GUI, but it’s not clear how it’s supposed to get
> invoked:
> 
> [...]
> 
> What’s is it used for?

FWIW, it has a man page:
<https://man.archlinux.org/man/extra/libinput/libinput-debug-gui.1.en>?

I did some quick searches for 'libinput-debug-gui' on the Web but
didn't find any uses in the wild, so maybe we don't really lose
anything by disabling it?

Also, having multiple library variants is a bit messy (there was some
bug involving multiple versions of cairo used by a single app?), so I'd
prefer to eliminate the libinput / libinput-minimal distinction (maybe
with a separate libinput-debug-gui package if desired?).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 56139-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, 56139-done <at> debbugs.gnu.org
Subject: Re: bug#56139: [PATCH 0/4] Make window managers use
 libinput-minimal instead of libinput
Date: Fri, 24 Jun 2022 17:10:49 +0200

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> FWIW, it has a man page:
> <https://man.archlinux.org/man/extra/libinput/libinput-debug-gui.1.en>?

Since it’s under libexec/, I’d assume that it’s not meant to be invoked
directly, but the man page suggests otherwise?…

> I did some quick searches for 'libinput-debug-gui' on the Web but
> didn't find any uses in the wild, so maybe we don't really lose
> anything by disabling it?

Looks like it.

> Also, having multiple library variants is a bit messy (there was some
> bug involving multiple versions of cairo used by a single app?), so I'd
> prefer to eliminate the libinput / libinput-minimal distinction (maybe
> with a separate libinput-debug-gui package if desired?).

Yeah, maybe we can do that (with a comment), and apparently that’s even
an OK change for master.

If you provide a patch, I’ll happily apply it.  :-)

Ludo’.

Message #31 received at 56139-done <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>, Maxime Devos
 <maximedevos <at> telenet.be>
Cc: 56139-done <at> debbugs.gnu.org
Subject: Re: bug#56139: [PATCH 0/4] Make window managers use
 libinput-minimal instead of libinput
Date: Sun, 26 Jun 2022 12:14:57 +0200

Hi Ludo and Maxime, 

Ludovic Courtès <ludo <at> gnu.org> writes:
> Since it’s under libexec/, I’d assume that it’s not meant to be invoked
> directly, but the man page suggests otherwise?…

Just as a heads-up, the debug GUI is supposed to be launched through
`libinput debug-gui`.  I'm not sure there's anything there that cannot
be debugged through `libinput debug-envents` though.

Cheers,
-- 
Josselin Poiret

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.