GNU bug report logs - #56193
Add Climate Data Operators package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56193 in the body.
You can then email your comments to 56193 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman.scherer <at> burningswell.com>
To: guix-patches <at> gnu.org
Subject: Add Climate Data Operators package
Date: Fri, 24 Jun 2022 16:28:59 +0200

[Message part 1 (text/plain, inline)]

Hello Guix,

I would like to contribute a patch to add the Climate Data Operators
package to Guix's geo module. Could you please review it?

Thanks, Roman.

[0001-Add-Climate-Data-Operators-package.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 56193 <at> debbugs.gnu.org (full text, mbox):

From: Antero Mejr <antero <at> mailbox.org>
To: 56193 <at> debbugs.gnu.org
Date: Fri, 24 Jun 2022 19:10:39 +0000

Hi Roman,

NetCDF support isn't working in your patch. The software says this:

"Unsupported file type (library support not compiled in)
To create a CDO application with NetCDF support use:
./configure --with-netcdf=<NetCDF root directory> ..."

So it looks like you will have to modify the configure phase a little.

I don't think you need the expression
`(modules '((guix build utils))`
as you are not using that module in your source expression.

`licenses` doesn't have to be a list unless cdo is dual-licensed.

Please run `guix style` and `guix lint` (using pre-inst-env), which will
help make sure the code style follows the Guix style guidelines.

Thanks,
Antero

Message #11 received at 56193 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman.scherer <at> burningswell.com>
To: 56193 <at> debbugs.gnu.org
Subject: [PATCH] Add Climate Data Operators package
Date: Sat, 25 Jun 2022 12:18:24 +0200

[Message part 1 (text/plain, inline)]

Hi Antero,

thanks for your review! Here's an updated version of the patch. I added
--with-netcdf to the configure flags, removed the build utils, added
spaces between sentences and don't use a list for the licence field
anymore.

Could you have another look please?

I'm not sure if I addressed all lint issues, since this command is
failing on my machine recently. Any idea what this could be? Here's the
backtrace of the lint command:

```
[roman <at> thinkpad guix]$ ./pre-inst-env guix lint cdo
;;; note: source file /home/roman/workspace/guix/gnu/packages/geo.scm
;;;       newer than compiled /home/roman/workspace/guix/gnu/packages/geo.go
;;; note: source file /home/roman/workspace/guix/gnu/packages/geo.scm
;;;       newer than compiled /home/roman/.cache/guile/ccache/3.0-LE-8-4.5/home/roman/workspace/guix/gnu/packages/geo.scm.go
;;; Failed to autoload html->sxml in (htmlprag):
;;; no code for module (htmlprag)
Backtrace:
In ice-9/boot-9.scm:
  1752:10 18 (with-exception-handler _ _ #:unwind? _ # _)
In unknown file:
          17 (apply-smob/0 #<thunk 7f3b46a28f60>)
In ice-9/boot-9.scm:
    724:2 16 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
In ice-9/eval.scm:
    619:8 15 (_ #(#(#<directory (guile-user) 7f3b46a22c80>)))
In guix/ui.scm:
   2238:7 14 (run-guix . _)
  2201:10 13 (run-guix-command _ . _)
In ice-9/boot-9.scm:
  1752:10 12 (with-exception-handler _ _ #:unwind? _ # _)
  1752:10 11 (with-exception-handler _ _ #:unwind? _ # _)
In guix/store.scm:
   659:37 10 (thunk)
In srfi/srfi-1.scm:
    634:9  9 (for-each #<procedure 7f3b4531efa0 at guix/scripts/lin…> …)
In guix/scripts/lint.scm:
     65:4  8 (run-checkers _ _ #:store _)
In srfi/srfi-1.scm:
    634:9  7 (for-each #<procedure 7f3b31769de0 at guix/scripts/lin…> …)
In guix/scripts/lint.scm:
    74:21  6 (_ _)
In guix/lint.scm:
   1476:5  5 (check-for-updates #<package cdo <at> 2.0.5 /home/roman/work…>)
    811:2  4 (call-with-networking-fail-safe _ _ _)
In ice-9/boot-9.scm:
  1752:10  3 (with-exception-handler _ _ #:unwind? _ # _)
  1685:16  2 (raise-exception _ #:continuable? _)
  1683:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
error: html->sxml: unbound variable
```

Thanks, Roman.

[0002-Add-Climate-Data-Operators-package.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Roman Scherer <roman.scherer <at> burningswell.com>
Cc: 56193 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#56193] [PATCH] Add Climate Data Operators package
Date: Sat, 25 Jun 2022 13:09:00 +0200

[Message part 1 (text/plain, inline)]

Roman!

Roman Scherer 写道：
> [roman <at> thinkpad guix]$ ./pre-inst-env guix lint cdo

[…]

> error: html->sxml: unbound variable

This is probably solved by running the command above in a guix 
shell:

 $ guix shell guix -- ./pre-inst-env guix lint cdo

‘pre-inst-env’ sets up some environment (variables) like 
GUILE_LOAD_PATH to ensure that Guix can run from your local git 
checkout, but nothing more.

Most importantly, it does not create a full Guix profile with the 
numerous dependencies of the ‘guix’ package — including the 
‘guile-lib’ package that provides HTML->SXML.

That's what the ‘guix shell’ is for.  It's a clean alternative to 
‘guix install’ing all these guile-* packages into your user 
profile.  Both work.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman.scherer <at> burningswell.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 56193 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#56193] [PATCH] Add Climate Data Operators package
Date: Sat, 25 Jun 2022 13:43:55 +0200

[Message part 1 (text/plain, inline)]

Hi Tobias,

thanks for the tip. Unfortunately the command you sent me is not
enough. I still get this error with `guix shell guix`:

```
[roman <at> thinkpad guix]$ guix shell guix -- ./pre-inst-env guix lint gdal
;;; note: source file /home/roman/workspace/guix/gnu/packages/geo.scm
;;;       newer than compiled /home/roman/workspace/guix/gnu/packages/geo.go
;;; note: source file /home/roman/workspace/guix/gnu/packages/geo.scm
;;;       newer than compiled /home/roman/.cache/guile/ccache/3.0-LE-8-4.5/home/roman/workspace/guix/gnu/packages/geo.scm.go
;;; Failed to autoload html->sxml in (htmlprag):
;;; no code for module (htmlprag)
Backtrace:
In ice-9/boot-9.scm:
  1752:10 18 (with-exception-handler _ _ #:unwind? _ # _)
In unknown file:
          17 (apply-smob/0 #<thunk 7f09e3748f60>)
In ice-9/boot-9.scm:
    724:2 16 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
In ice-9/eval.scm:
    619:8 15 (_ #(#(#<directory (guile-user) 7f09e3742c80>)))
In guix/ui.scm:
   2238:7 14 (run-guix . _)
  2201:10 13 (run-guix-command _ . _)
In ice-9/boot-9.scm:
  1752:10 12 (with-exception-handler _ _ #:unwind? _ # _)
  1752:10 11 (with-exception-handler _ _ #:unwind? _ # _)
In guix/store.scm:
   659:37 10 (thunk)
In srfi/srfi-1.scm:
    634:9  9 (for-each #<procedure 7f09e21bc9e0 at guix/scripts/lin…> …)
In guix/scripts/lint.scm:
     65:4  8 (run-checkers _ _ #:store _)
In srfi/srfi-1.scm:
    634:9  7 (for-each #<procedure 7f09d2d94c60 at guix/scripts/lin…> …)
In guix/scripts/lint.scm:
    74:21  6 (_ _)
In guix/lint.scm:
   1476:5  5 (check-for-updates #<package gdal <at> 3.5.0 /home/roman/wor…>)
    811:2  4 (call-with-networking-fail-safe _ _ _)
In ice-9/boot-9.scm:
  1752:10  3 (with-exception-handler _ _ #:unwind? _ # _)
  1685:16  2 (raise-exception _ #:continuable? _)
  1683:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
error: html->sxml: unbound variable
```

However, after adding guile-lib to my home profile, it seems to work!

Thanks, Roman.

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> [[PGP Signed Part:Undecided]]
> Roman!
>
> Roman Scherer 写道：
>> [roman <at> thinkpad guix]$ ./pre-inst-env guix lint cdo
>
> […]
>
>> error: html->sxml: unbound variable
>
> This is probably solved by running the command above in a guix shell:
>
>  $ guix shell guix -- ./pre-inst-env guix lint cdo
>
> ‘pre-inst-env’ sets up some environment (variables) like
> GUILE_LOAD_PATH to ensure that Guix can run from your local git
> checkout, but nothing more.
>
> Most importantly, it does not create a full Guix profile with the
> numerous dependencies of the ‘guix’ package — including the
> ‘guile-lib’ package that provides HTML->SXML.
>
> That's what the ‘guix shell’ is for.  It's a clean alternative to
> ‘guix install’ing all these guile-* packages into your user profile.
> Both work.
>
> Kind regards,
>
> T G-R
>
> [[End of PGP Signed Part]]

[signature.asc (application/pgp-signature, inline)]

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Roman Scherer <roman.scherer <at> burningswell.com>
Cc: 56193 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#56193] [PATCH] Add Climate Data Operators package
Date: Sat, 25 Jun 2022 14:05:28 +0200

[Message part 1 (text/plain, inline)]

Roman,

Roman Scherer 写道：
> thanks for the tip. Unfortunately the command you sent me is not
> enough. I still get this error with `guix shell guix`:

That's because I'm an old, who's still used to the (deprecated) 
‘guix environment’, but wanted to sound hip by saying ‘guix shell’ 
instead.  A recipe for failure.

The two are semantically equivalent but not identical, so I should 
have said

 $ guix shell -D guix -- ./pre-inst-env stuff

Note the -D, for --development (‘add P's inputs rather than P 
itself’).

Nothing wrong with keeping guile-* packages in your user profile 
but the above is a bit cleaner.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman.scherer <at> burningswell.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 56193 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#56193] [PATCH] Add Climate Data Operators package
Date: Sat, 25 Jun 2022 14:18:47 +0200

[Message part 1 (text/plain, inline)]

Haha, ok. Thanks for the explanation Tobias. I think I leave it in my
home profile, I already have some other guile packages in it.

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> [[PGP Signed Part:Undecided]]
> Roman,
>
> Roman Scherer 写道：
>> thanks for the tip. Unfortunately the command you sent me is not
>> enough. I still get this error with `guix shell guix`:
>
> That's because I'm an old, who's still used to the (deprecated) ‘guix
> environment’, but wanted to sound hip by saying ‘guix shell’ instead.
> A recipe for failure.
>
> The two are semantically equivalent but not identical, so I should
> have said
>
>  $ guix shell -D guix -- ./pre-inst-env stuff
>
> Note the -D, for --development (‘add P's inputs rather than P
> itself’).
>
> Nothing wrong with keeping guile-* packages in your user profile but
> the above is a bit cleaner.
>
> Kind regards,
>
> T G-R
>
> [[End of PGP Signed Part]]

[signature.asc (application/pgp-signature, inline)]

Message #40 received at 56193-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Roman Scherer <roman.scherer <at> burningswell.com>
Cc: 56193-done <at> debbugs.gnu.org
Subject: Re: bug#56193: Add Climate Data Operators package
Date: Sun, 03 Jul 2022 16:07:21 +0200

Hi,

Roman Scherer <roman.scherer <at> burningswell.com> skribis:

> From d003fb5a519341a23973e8565ac7bc3195742808 Mon Sep 17 00:00:00 2001
> From: r0man <roman <at> burningswell.com>
> Date: Sat, 25 Jun 2022 12:10:00 +0200
> Subject: [PATCH] Add Climate Data Operators package
>
> This patch adds CDO, a collection of command line Operators to manipulate and
> analyse Climate and NWP model Data to Guix's geo module.

I tweaked the description and commit log, change #:configure-flags to
use the ‘this-package-input’ idiom, and committed.

Thanks!

Ludo’.

Message #43 received at 56193-done <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman.scherer <at> burningswell.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 56193-done <at> debbugs.gnu.org
Subject: Re: bug#56193: Add Climate Data Operators package
Date: Sun, 03 Jul 2022 18:47:21 +0200

[Message part 1 (text/plain, inline)]

Cool, I didn't know about this-package-input.

Thank you!

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Roman Scherer <roman.scherer <at> burningswell.com> skribis:
>
>> From d003fb5a519341a23973e8565ac7bc3195742808 Mon Sep 17 00:00:00 2001
>> From: r0man <roman <at> burningswell.com>
>> Date: Sat, 25 Jun 2022 12:10:00 +0200
>> Subject: [PATCH] Add Climate Data Operators package
>>
>> This patch adds CDO, a collection of command line Operators to manipulate and
>> analyse Climate and NWP model Data to Guix's geo module.
>
> I tweaked the description and commit log, change #:configure-flags to
> use the ‘this-package-input’ idiom, and committed.
>
> Thanks!
>
> Ludo’.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.