Received: (at 56212) by debbugs.gnu.org; 25 Jun 2022 11:15:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 25 07:15:39 2022
Received: from localhost ([127.0.0.1]:44223 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o53lK-0001Yt-LR
for submit <at> debbugs.gnu.org; Sat, 25 Jun 2022 07:15:39 -0400
Received: from lepiller.eu ([89.234.186.109]:41770)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <julien@HIDDEN>) id 1o53lI-0001UO-C8
for 56212 <at> debbugs.gnu.org; Sat, 25 Jun 2022 07:15:37 -0400
Received: from lepiller.eu (localhost [127.0.0.1])
by lepiller.eu (OpenSMTPD) with ESMTP id 7d3191a4;
Sat, 25 Jun 2022 11:15:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from
:to:cc:subject:message-id:in-reply-to:references:mime-version
:content-type; s=dkim; bh=WdPNjp9xPy+TS9GOAoEEQOUf/h5w8jaFBuBExK
n7s8g=; b=n3YDq40XfHzo+TkW66nDxPySWFqFQMLI/qocrqzdp2g1EqfhxfJ5AZ
hWDihUUERXyv4UgQYfJUpbJN/mw+Jim9pc7ehDHlcmASe5fN6lUFGU3L+l5UYZd9
xQlp65Li3ReRWmGppKxfK97rW+m70iOXibDNoVLyV7Opz9Gl04DI2V5kYAKU12K4
8C4SHQvCoC48V9qy/Bq9CCPQa/Z7WpOIFLkrkBUWyuiRtwbXwuXcFY3tFQKQlxir
31MdYTGlxLbu+kX8StKK3mkCP8UcgXgsrOfgwcr1QQ3YElSrokiLYH/S581BXdri
RxLqfuadw9GNurdsCAc8wMSCx078gJdg==
Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3fc8e667
(TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO);
Sat, 25 Jun 2022 11:15:16 +0000 (UTC)
Date: Sat, 25 Jun 2022 13:15:08 +0200
From: Julien Lepiller <julien@HIDDEN>
To: "Artyom V. Poptsov" <poptsov.artyom@HIDDEN>
Subject: Re: [bug#56212] [PATCH] gnu: Add maven-release-api
Message-ID: <20220625131502.691b1ee1@HIDDEN>
In-Reply-To: <871qvd3xgd.fsf@HIDDEN>
References: <871qvd3xgd.fsf@HIDDEN>
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/IVi.9t+oeaIdPBlr17Cwv_U";
protocol="application/pgp-signature"; micalg=pgp-sha512
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 56212
Cc: 56212 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--Sig_/IVi.9t+oeaIdPBlr17Cwv_U
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Thanks for the patch! A few remarks below.
Le Sat, 25 Jun 2022 12:26:58 +0300,
"Artyom V. Poptsov" <poptsov.artyom@HIDDEN> a =C3=A9crit :
> From f071547eaf36804cfe0fc7ee0ef418e2db1abb7a Mon Sep 17 00:00:00 2001
> From: "Artyom V. Poptsov" <poptsov.artyom@HIDDEN>
> Date: Sat, 25 Jun 2022 12:16:29 +0300
> Subject: [PATCH] gnu: Add maven-release-api
Missing full stop in the subject line.
>=20
> * gnu/packages/maven.scm (maven-release-api): New variable.
> (maven-release-parent-pom): New variable.
> ---
> gnu/packages/maven.scm | 58
> ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58
> insertions(+)
>=20
> diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm
> index e5831ee614..7ff2d6d69e 100644
> --- a/gnu/packages/maven.scm
> +++ b/gnu/packages/maven.scm
> @@ -3938,3 +3938,61 @@ method and a end of tag by @code{xxxx_()}
> method.") (description "@samp{Doxia} is a content generation
> framework that provides powerful techniques for generating static and
> dynamic content, supporting a variety of markup languages.")))
> +
> +(define-public maven-release-api
> + (package
> + (name "maven-release-api")
> + (version "3.0.0-M5")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/apache/maven-release")
> + (commit (string-append "maven-release-"
> version))))
> + (file-name (git-file-name "maven-release" version))
> + (modules '((guix build utils)))
> + (snippet
> + '(begin
> + ;; XXX: Delete dummy JAR-files.
> + (delete-file-recursively
> +
> "maven-release-manager/src/test/remote-repository")
> + #t))
No need to end the snippet with #t.
Since we're going to build maven-release-manager at some point (I
suppose?), we'll need these files in order to run the tests. Could you
add something to the snippet to regenerate the files (if that's
possible from the snippet, otherwise we'll regenerate them in a phase
once we have a maven-release-manager package)?
> + (sha256
> + (base32
> +
> "13yxjl29jp4zkb8xvy0b045b5fpqz9nais1jsf4r9krczyxyj96k"))))
> + (build-system ant-build-system)
> + (propagated-inputs (list maven-release-parent-pom))
> + (inputs (list maven-repository-metadata
> + maven-artifact
> + maven-core
> + maven-model
> + java-eclipse-aether-util
> + java-slf4j-api
> + java-plexus-utils))
I think most of these inputs should be propagated because the pom file
references these packages in its dependencies:
<dependencies>
...
</dependencies>
whatever's not a test dependency will be required at runtime by maven,
so we need to propagate.
> + (arguments
> + `(#:jar-name "maven-release-api.jar"
> + #:source-dir "maven-release-api/src/main/java"
> + #:tests? #f ; no tests
> + #:phases (modify-phases %standard-phases
> + (replace 'install
> + (install-from-pom
> "maven-release-api/pom.xml")))))
> + (home-page "https://maven.apache.org/maven-release/")
> + (synopsis "APIs to implement to extend maven-release-plugin")
It's hard to understand this sentence. maybe s/to implement/required/
> + (description "APIs to implement to extend maven-release-plugin")
This should be full sentences. Can you come up with maybe two sentences
that briefly explain what this package does?
> + (license license:asl2.0)))
> +
> +(define maven-release-parent-pom
> + (package
> + (inherit maven-release-api)
> + (name "maven-release-parent-pom")
> + (arguments
> + `(#:tests? #f ; no tests
> + #:phases (modify-phases %standard-phases
> + (delete 'configure)
> + (delete 'build)
> + (replace 'install
> + (install-pom-file "pom.xml")))))
> + (propagated-inputs
> + (list maven-parent-pom-34))
> + (synopsis "Apache Maven Release (Plugin)")
> + (description "This plugin is used to release a project with
> Maven, saving +a lot of repetitive, manual work.")))
I would replace "(Plugin)" with "parent pom". The description is for
the plugin, not the parent pom, so maybe:
This is the parent for the maven release plugin that is used to release
...
WDYT?
--Sig_/IVi.9t+oeaIdPBlr17Cwv_U
Content-Type: application/pgp-signature
Content-Description: Signature digitale OpenPGP
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEHvsJCR8X0ozL+bE6U9RXstY27oIFAmK27jwACgkQU9RXstY2
7oIDKg//bY1mTqDctJTv4Ib8FMGYvrkM5UETeMteK2/3ThP31NwCsS6DAKmrn+py
X1wVuyGlfNDoXK/rbzcii2JsgzQu2mwkyKudSb8z337vitbeOHdJnxn5KFwrAk2C
Az1VnOotdjrLHo7YYbUX+/H2R+R67X01HJbxD7VC8orDrX/if4aAgmyUYtgjZ7/4
iVFGxnLRGMyzLaQVvlC9Dc7rbgODFVb+CkCVehFGPFs//QUsXL5DFRaaDeM3MsvY
DdYGEGH4naZP6ipiJhhdixeAcubZqOMS/O2l2fAlpzwp1IEEGymRMdFzu1Ek+IwO
egb9MMyBeVFyDOtOlz8KHCYYUQCqqgVarFTTs46ncRqVsuZxK/qeihzK/nNZDMCk
Hy9DreZz2azl/iGvVMSdpewemtoVpW8XEGjTFe3fbz4A9cGelA1/VfssbQ2BqYp6
zHEV7FOgYuUBCO3+gIYaibIrftdpyFLS8fPj+FQwfOFqQmAxkHpiTAmKmetFRcNd
7H1Xxt562fkVJQe73FJ65apY0EApUiKpM1hdaPTSWgPIjPQDMU1aPNF0crNeugWJ
mWsA5mqc+PGcTxa//atXXXeI2nKfwihTihoCnJ8NZIcUOc2bqtBaOQYMgj/dGJl4
visx+uiGmLiLOPwGqzTUSzkRP7b8Y4HfUHyKP82BGfPh3XzsyjA=
=HyKr
-----END PGP SIGNATURE-----
--Sig_/IVi.9t+oeaIdPBlr17Cwv_U--
guix-patches@HIDDEN:bug#56212; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 25 Jun 2022 09:27:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 25 05:27:14 2022
Received: from localhost ([127.0.0.1]:44113 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o524Q-0006XH-5a
for submit <at> debbugs.gnu.org; Sat, 25 Jun 2022 05:27:14 -0400
Received: from lists.gnu.org ([209.51.188.17]:48436)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <poptsov.artyom@HIDDEN>) id 1o524O-0006XA-BG
for submit <at> debbugs.gnu.org; Sat, 25 Jun 2022 05:27:13 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:45228)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <poptsov.artyom@HIDDEN>)
id 1o524M-00058U-DP
for guix-patches@HIDDEN; Sat, 25 Jun 2022 05:27:11 -0400
Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:46018)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <poptsov.artyom@HIDDEN>)
id 1o524J-0004zs-Cx
for guix-patches@HIDDEN; Sat, 25 Jun 2022 05:27:10 -0400
Received: by mail-lj1-x22d.google.com with SMTP id s10so5353988ljh.12
for <guix-patches@HIDDEN>; Sat, 25 Jun 2022 02:27:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:to:subject:date:message-id:user-agent:mime-version;
bh=o+XiA/Od2Y+nsBeDNIRUgb32VrJFyKjv9IoRBcKn88I=;
b=TbpUlLQ+WsEF8viwQCR9lBMBys3/0CFEtXq9GLeyGD7LYu6D6JKSYHr+yaMNnA6x+z
//AS5BPL6fK8NSBCskRGM7BJnJzLBGxyjja68Qu/0vjinJ6YCEPPW9NlPYjK4hJ+KzTo
SJDM6zOIhe+DkUxChgV3mwugn5GRitA2hYwgzjUhLUZgeWK36Yo9PdgiGSCvvVK27k6q
lVrGj5PIAa97gLsHck+i2v9iMXHIKq3cbZjeKhmKqLfRP69xMRChblrXaKzGI1eIwHSk
hs+A4d6knO7+wNFu/h32XhXsvINh5GgkxBxy9wN+Mo29t3s/8iLuSYJZp6mV3D95YHwT
he1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:to:subject:date:message-id:user-agent
:mime-version;
bh=o+XiA/Od2Y+nsBeDNIRUgb32VrJFyKjv9IoRBcKn88I=;
b=jemYpxZOWrNFgCr2H42FQgRNRiOjHds0xU+D78aP2j0GA/nOxB8XwDWF5ndGBzKWyB
Whs88sqdKCATMSfudMslyiLyhaCSmBGDPo3rQ+pu3xoEm8lktqp9BHEhrJ6pHJFPE4em
6sAVqrNh6RwyDSGe2iU3HMmnPwGFSNNB9tj7MVlQlhl6OFmQhrsBZaPnL1BO2jucNX37
AWaGlJi+lvS8pXrqobOfwnqts639d2jc5H6pbhZanjs7t+9UMyvxod/GqAfjYWPs1TmF
35Mzu1UiNf+FA+Met2rqeH1AqzH/L84kksp+Tk3YOOyvAcymoVLr5wiakSjPWJ9Bg1BU
Mtcg==
X-Gm-Message-State: AJIora81wsehOty0MJEbTdSbzHj739iOuHHX71NcKW26Gpk/gEMIUMQ/
ww1XXCmwWXfhtTYUTU0relIKKXMK1M0=
X-Google-Smtp-Source: AGRyM1vDRzIugaxcw+e54iOqvNH7YauffSxLkj6ODlGhDCvEbclLSne7to6Pq6ToE1W7GRl+A6SKAQ==
X-Received: by 2002:a2e:3808:0:b0:25a:703b:6d00 with SMTP id
f8-20020a2e3808000000b0025a703b6d00mr1684062lja.352.1656149223095;
Sat, 25 Jun 2022 02:27:03 -0700 (PDT)
Received: from elephant ([5.164.222.47]) by smtp.gmail.com with ESMTPSA id
k6-20020ac257c6000000b0047fa02cd96csm775613lfo.162.2022.06.25.02.27.02
for <guix-patches@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 25 Jun 2022 02:27:02 -0700 (PDT)
From: "Artyom V. Poptsov" <poptsov.artyom@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add maven-release-api
Date: Sat, 25 Jun 2022 12:26:58 +0300
Message-ID: <871qvd3xgd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a00:1450:4864:20::22d;
envelope-from=poptsov.artyom@HIDDEN; helo=mail-lj1-x22d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="
--=-=-=
Content-Type: text/plain
Hello,
this patch adds Maven Release API under the name 'maven-release-api', as
well as the private 'maven-release-parent-pom' package.
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0001-gnu-Add-maven-release-api.patch
Content-Transfer-Encoding: quoted-printable
From=20f071547eaf36804cfe0fc7ee0ef418e2db1abb7a Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@HIDDEN>
Date: Sat, 25 Jun 2022 12:16:29 +0300
Subject: [PATCH] gnu: Add maven-release-api
* gnu/packages/maven.scm (maven-release-api): New variable.
(maven-release-parent-pom): New variable.
=2D--
gnu/packages/maven.scm | 58 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm
index e5831ee614..7ff2d6d69e 100644
=2D-- a/gnu/packages/maven.scm
+++ b/gnu/packages/maven.scm
@@ -3938,3 +3938,61 @@ method and a end of tag by @code{xxxx_()} method.")
(description "@samp{Doxia} is a content generation framework that prov=
ides
powerful techniques for generating static and dynamic content, supporting a
variety of markup languages.")))
+
+(define-public maven-release-api
+ (package
+ (name "maven-release-api")
+ (version "3.0.0-M5")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/apache/maven-release")
+ (commit (string-append "maven-release-" version))))
+ (file-name (git-file-name "maven-release" version))
+ (modules '((guix build utils)))
+ (snippet
+ '(begin
+ ;; XXX: Delete dummy JAR-files.
+ (delete-file-recursively
+ "maven-release-manager/src/test/remote-repository")
+ #t))
+ (sha256
+ (base32
+ "13yxjl29jp4zkb8xvy0b045b5fpqz9nais1jsf4r9krczyxyj96k"))))
+ (build-system ant-build-system)
+ (propagated-inputs (list maven-release-parent-pom))
+ (inputs (list maven-repository-metadata
+ maven-artifact
+ maven-core
+ maven-model
+ java-eclipse-aether-util
+ java-slf4j-api
+ java-plexus-utils))
+ (arguments
+ `(#:jar-name "maven-release-api.jar"
+ #:source-dir "maven-release-api/src/main/java"
+ #:tests? #f ; no tests
+ #:phases (modify-phases %standard-phases
+ (replace 'install
+ (install-from-pom "maven-release-api/pom.xml")))))
+ (home-page "https://maven.apache.org/maven-release/")
+ (synopsis "APIs to implement to extend maven-release-plugin")
+ (description "APIs to implement to extend maven-release-plugin")
+ (license license:asl2.0)))
+
+(define maven-release-parent-pom
+ (package
+ (inherit maven-release-api)
+ (name "maven-release-parent-pom")
+ (arguments
+ `(#:tests? #f ; no tests
+ #:phases (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'build)
+ (replace 'install
+ (install-pom-file "pom.xml")))))
+ (propagated-inputs
+ (list maven-parent-pom-34))
+ (synopsis "Apache Maven Release (Plugin)")
+ (description "This plugin is used to release a project with Maven, sav=
ing
+a lot of repetitive, manual work.")))
=2D-=20
2.25.1
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Thanks,
=2D Artyom
=2D-=20
Artyom "avp" Poptsov <poptsov.artyom@HIDDEN>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
--=-=-=--
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEE0MLqwTMQgi2Y3rV86cWi2QiYoC8FAmK21OIACgkQ6cWi2QiY
oC/OJAf9GVDPFBvj8jUcCSOhKJOdMeeiCJGWbLvstzKoM6qLFUy52h2c4YMQLL1e
buP5Ry5JWG83vytGD+iiC3CNjSDrB+uAzFp3mSqE4krm0q2VDudxvRp8sd3+H7mb
stZsB7rvrmjDHA7A6RIvwBUkzWvXmmxicYn9XbgYHv8tKiiaynPUMZ9eOoxqVOE8
DT7BORISTYQQpblzNyYhpVJwVipfxRrUiNHMZKXWjghgCKKd/gutxYEWfN3zc7HL
uSvPd7DvvkLe+o4hqSc6jM4azCdD4j9AmMBx1DR0cCz8CTyxOkMd7X42Z31qCMKJ
8XP5zSK1Edh0E6iO1I/OH+1l2cnl/A==
=f0o1
-----END PGP SIGNATURE-----
--==-=-=--
"Artyom V. Poptsov" <poptsov.artyom@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#56212; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.