GNU bug report logs - #56318
[PATCH] import: github: Fix updater.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56318 in the body.
You can then email your comments to 56318 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] import: github: Fix updater.
Date: Thu, 30 Jun 2022 09:42:21 +0200

* guix/import/github.scm(updated-url): For one one of the
  cases add missing 'prefix' and set new version.
---
 guix/import/github.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/import/github.scm b/guix/import/github.scm
index 51118d1d39..e1a1af7133 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2019 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2019 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2022 Maxime Devos <maximedevos <at> telenet.be>
+;;; Copyright © 2022 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -95,8 +96,8 @@ false if none is recognized"
            ((string-suffix? (string-append "/releases/download/" repo "-"
                                            version "/" repo "-" version ext)
                             url)
-            (string-append "/releases/download/" repo "-" version "/" repo "-"
-                           version ext))
+            (string-append prefix "/releases/download/" repo "-" new-version "/"
+                           repo "-" new-version ext))
            (#t #f))) ; Some URLs are not recognised.
         #f))
 

base-commit: d7449142f56cb0b34860f4ac90fc322aee32d177
-- 
2.30.4

Message #8 received at 56318 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 56318 <at> debbugs.gnu.org
Subject: Re: bug#56318: [PATCH] import: github: Fix updater.
Date: Fri, 08 Jul 2022 23:44:58 +0200

Hi,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> * guix/import/github.scm(updated-url): For one one of the
>   cases add missing 'prefix' and set new version.

Could you add an example of a case that is fixed by this change in the
commit log?  (Like “‘guix refresh foo’ would fail to find the new
release of ‘foo’ before this change.”)

Also in the commit log: I’d suggest something like “Use correct URL
scheme” instead of “Fix updater”, for clarity.

Otherwise LGTM (assuming the URL scheme is correct), thanks!

Ludo’.

Message #13 received at 56318-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 56318-close <at> debbugs.gnu.org
Subject: Re: bug#56318: [PATCH] import: github: Fix updater.
Date: Mon, 11 Jul 2022 15:36:39 +0200

Thanks for the review. I amended the commit-message an pushed as 
e8cd9e3d12c8c24b7c81e8787207f21e277da540

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.