GNU logs - #56382, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Morgan.J.Smith@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 04 Jul 2022 13:50:01 +0000
Resent-Message-ID: <handler.56382.B.165694256915771 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 56382 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith@HIDDEN>
From: Morgan.J.Smith@HIDDEN
Date: Mon,  4 Jul 2022 09:43:54 -0400
Message-ID: <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cb738992-897e-4f47-4c8b-08da5dc349c9
X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNUxDAI+Tg+jRSc79YAuptYJhmncM8NyUp9rWTTE5mCN/H4OAnFMn/noNuFNNakJsg1KFfouBScTG69u5RpRjJ53XOi7gYX7PMRfHVeHydNgZZGaA94GrOyB0XUVGY15fuiMQRciAoYbBz3JYYAoTie0f9gEHwr//fd6Rgz8Pwp2tBJVb6S2fHOcpcW617Y+nv9tXYHMuy3mBkmZX484ayelDNS5um9EKH2aV+ijUyACvawPKdUqDxWMu6q5hjiklHvr6YCitkD8xmTc++YXEqn+hs3AAk36wS1eG3VkwdrD4f3aQaHD7H++hGlWIH3mKxWt9PTxiyE09bpnZxlGRIl2fhSrPmPtEGbm69tWO6WOxEOeQ9SPKGS1LZL1oi24SmcFuKBKVLLgU4jiy0bunylhWght/rE4s8gu3cqaTCREMc1eZKBuGcb/pxB9p95i9L/A1RG7vI2R60pyGIVSJmyVJK5E2SrXMPM2c0HLTsFI4Oh8uC0JgtSSU8P6X70j6qZFhzkvj9wcJmDM+zcT1q9OKzNK+JNs9F1T7BWdD424Mdb57IDwrDHXDB/Pk9AZ1+48/2f5Q/2v9+bevC8Z7BV75ty/EL5wpoqP/UqOS4cIYqer62MZ1bizHi1zcesj91o1vyqgOtWRNfe37oQSe+uNc/sCRPFoq/A/1CH1NQKe6n66JhRgPFNTMhgL9ks7R26C+WAYS7zwT8kz6XMR7ANC8dTmaBK27MI=
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6567:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: K1gYSpIsZDwgmS3sT03poeqZYnWMPbZcuqD5Q90HG5WaTAlCD4Wq5Jg6oEBPyPfPxrOBwrK/zTE0gacRHenCbR42LEQVGMT5Zv/tf33IcuzygBzSpshvsHAODH6++krVgKciWuSxpNHMgaXPp/3oXI4kzVsR36jytoAWn2faRpsqtM/h1nYb04n6rYEnTON6B+n+LjYopJpYF4FHdRf66Dy4gckmwyQMesD6ELmTBcl1sDxa773GwMRm5hRPHm0lU8yzDkHUKDRCg20CfRArXebxCg+ScTE2nnXXcCw3augTMAPBgj777hJxt8FcnHCZ+GqOPOuQpC+DlBGhB5wnUaw+3bTWwP9jbl4pAmrGgaa4cD1RutPZ4kPOg15hoXmdZcWtOJkSm9Y0JC0pFys8+VbT4CysYUpeF3CZF7A1L6x5GN+eqBRnnoaEQRNkvp+jI0MjQIsKrEJlBJ3B2iV/FYkzZMwmwB52wJt1v5FKp0DmIYRFuaTo8Z7q2T8fwGkmhsnML9I9x2cQMoccx771WYzsb75iH8L/w9QksBlK3P+eW7pwVywV0mDCVnpqdztwhFbG4XMiowUJYNsOCVmTlTPb0qNQaNSu7f6KjK2isj/uN+e+yFNAWqisvwurW4JEeQ9KxzPV4qCn54ifgQOCZw==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: kuxShw3kOneCBgAEfzCI90tBSg5x+jHXtoguuBSvTox+tCFp4CU9rVeyhPk38asK+mM5h1phhg3LWL3Cb0qu//I1UT+nZk61qYiBsXztB/Gk28kLTOnp3eLvGmNwbT4m8SVcWDzZZWCr/+jqDLgiOkEhz1MvhORcRvoE9eWnvHavTTMpA648G0+S1lQCEEZ7dWmOah02JGyJdTTblxs2NMkh4ZZzqFOIjMCXOLvFCfExq5we5CkTy6K4bRxFlsiLlJQV1yVw9Gg9lE8J9CQCth3MnWwzQaQ7dP6ZyetlR6AHQOuXJY5KhFuU6fHuomoZ1uAWqx/IfH+cvzK/SVcMHZTW6cBbTyRmuuhLEichEt3g5H7iD+/VER0DN3aN5qBR9YgiQNszB54fOear6FW4s/iQGpp2bWX4LPoSedyjJ6PURDRPxE6WgDCySr8MReNKklfCzSUhfv7qh6KQebRtzCXjART+35dF0pFDr7F7AMmGbcNwuKaxOqFxLN3grmgrh97OKsnR+BpsAjuGUGOmFbMv7EBzRJYdPKpYQq5JUI19d+XQr+XPAi3DpCJrEuBWM77vMyOI/OAUFyj+T/Javd75erMeclCLL2tBp9PyRtE4kJRysoVKov8v5JY4J6XLjdjT21EY0QaIk51rG4YJ6zK+aJu05kr30B93mjykHvHTWlVpERsLuNfzIEAcm9rQN7sE45lno+kLx6bd4JnTNnm5RdSgS5FeiBg4YJe9oLgxew2hMJT9v4IcTVc4rPU/OaJtVodybBHikeju0OYbZ44/Y2z9QUAdSMD+DkEMTwSvLQL0ElAMLYXCiV9GXHakL/8ofSm8G/S5cMCIC7+FLmVssTuA4xQkHio+0iNKlr4IOrKvhJwkLw3hRidCDfJBboFzOYfXnB99dodVN8CVuUMC+S9p/Pw1j6PaAIsZU3L4hVGx0RUasLOYIb2+FHFPhlPtH4/WaTFHUCgGkEQHPvWCH4eelbm6OdZn4TYa5mvN01mgc1WHbh9MG+qHnGKdsQ+lkTRNLc6wETMu8yxiGfFAt1QSKrurqjSdI8a5SPzpocVe5TJP5FrRxFj3bvGGoRgxnepA1gKOZROKCPBHS0NoknuAxRgZfXGqgGK8EiY70eUDzH8nyCquYN3WnIbWLsjd8DAt34gg/EMsveHxep7gsybk/UvZ6TobssWAFFVtt6NfadbxmD4h98RqV/oE4klEI6tcJLRbuyiKS+MO7RYVSgeZtokWRvNHkJtHLUlokg8K270BFGj+w1+NB1NV8CJc6RGBQ6Y0vXbj9lv9gH1g9+eTE96JB7Gp48qZf+o=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb738992-897e-4f47-4c8b-08da5dc349c9
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 13:44:16.8187 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6567
Received-SPF: pass client-ip=2a01:111:f400:7e8a::81a;
 envelope-from=Morgan.J.Smith@HIDDEN;
 helo=NAM10-BN7-obe.outbound.protection.outlook.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

From: Morgan Smith <Morgan.J.Smith@HIDDEN>

* gnu/packages/messaging.scm (gajim)[inputs]: Add hicolor-icon-theme
---

So on my system gajim crashes saying something like "icon not present in the
theme Adwaita".  I have installed Adwaita system wide.  Looking in the gajim
build dir at
'/gnu/store/...-gajim-1.4.5/lib/python3.9/site-packages/gajim/data/icons/'
shows that the icons are stored in a 'hicolor' directory.  The proper solution
is to either figure out how to install the icons in a theme independent way or
to notify upstream

 gnu/packages/messaging.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index a9906bfd29..1efcce21d5 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1270,6 +1270,7 @@ (define-public gajim
        ("gtk+" ,gtk+)
        ("gtksourceview" ,gtksourceview)
        ("gupnp-igd" ,gupnp-igd)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
        ("libappindicator" ,libappindicator)
        ("libnice" ,libnice)
        ("libsecret" ,libsecret)
-- 
2.36.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Morgan.J.Smith@HIDDEN
Subject: bug#56382: Acknowledgement ([PATCH] gnu: gajim: Use
 hicolor-icon-theme to avoid crashing on startup)
Message-ID: <handler.56382.B.165694256915771.ack <at> debbugs.gnu.org>
References: <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
X-Gnu-PR-Message: ack 56382
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 56382 <at> debbugs.gnu.org
Date: Mon, 04 Jul 2022 13:50:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 56382 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
56382: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56382
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 12 Jul 2022 22:16:02 +0000
Resent-Message-ID: <handler.56382.B56382.16576641471487 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Morgan.J.Smith@HIDDEN
Cc: Raghav Gururajan <rg@HIDDEN>, 56382 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
Date: Wed, 13 Jul 2022 00:15:28 +0200
In-Reply-To: <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 (Morgan J. Smith's message of "Mon, 4 Jul 2022 09:43:54 -0400")
Message-ID: <87sfn6asfz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Morgan,

(+Cc: Raghav.)

Morgan.J.Smith@HIDDEN skribis:

> From: Morgan Smith <Morgan.J.Smith@HIDDEN>
>
> * gnu/packages/messaging.scm (gajim)[inputs]: Add hicolor-icon-theme
> ---
>
> So on my system gajim crashes saying something like "icon not present in =
the
> theme Adwaita".  I have installed Adwaita system wide.  Looking in the ga=
jim
> build dir at
> '/gnu/store/...-gajim-1.4.5/lib/python3.9/site-packages/gajim/data/icons/'
> shows that the icons are stored in a 'hicolor' directory.  The proper sol=
ution
> is to either figure out how to install the icons in a theme independent w=
ay or
> to notify upstream

I can reproduce the problem with:

--8<---------------cut here---------------start------------->8---
$ guix describe
Generation 221  Jul 03 2022 23:52:07    (current)
  guix e069de4
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: e069de452a2c923868f5137421b4b6349c38d754
$ guix shell -CN -E DISPLAY gajim -- gajim
[=E2=80=A6]
(org.gajim.Gajim:1): Gtk-WARNING **: 22:04:37.615: Could not find the icon =
'org.gajim.Gajim-symbolic'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
        http://icon-theme.freedesktop.org/releases
Traceback (most recent call last):
  File "/gnu/store/b3c4lsfl0swzyk0ylkvbjz2lk28caxrl-gajim-1.4.5/lib/python3=
.9/site-packages/gajim/gtk/application.py", line 389, in _handle_local_opti=
ons
    self._startup()
  File "/gnu/store/b3c4lsfl0swzyk0ylkvbjz2lk28caxrl-gajim-1.4.5/lib/python3=
.9/site-packages/gajim/gtk/application.py", line 278, in _startup
    MainWindow()
  File "/gnu/store/b3c4lsfl0swzyk0ylkvbjz2lk28caxrl-gajim-1.4.5/lib/python3=
.9/site-packages/gajim/gtk/main.py", line 85, in __init__
    self._main_stack =3D MainStack()
  File "/gnu/store/b3c4lsfl0swzyk0ylkvbjz2lk28caxrl-gajim-1.4.5/lib/python3=
.9/site-packages/gajim/gtk/main_stack.py", line 45, in __init__
    self._chat_page =3D ChatPage()
  File "/gnu/store/b3c4lsfl0swzyk0ylkvbjz2lk28caxrl-gajim-1.4.5/lib/python3=
.9/site-packages/gajim/gtk/chat_page.py", line 60, in __init__
    self._chat_stack =3D ChatStack()
  File "/gnu/store/b3c4lsfl0swzyk0ylkvbjz2lk28caxrl-gajim-1.4.5/lib/python3=
.9/site-packages/gajim/gtk/chat_stack.py", line 48, in __init__
    self.add_named(ChatPlaceholderBox(), 'empty')
  File "/gnu/store/b3c4lsfl0swzyk0ylkvbjz2lk28caxrl-gajim-1.4.5/lib/python3=
.9/site-packages/gajim/gtk/chat_stack.py", line 161, in __init__
    pixbuf =3D Gtk.IconTheme.load_icon_for_scale(
gi.repository.GLib.GError: gtk-icon-theme-error-quark: Icon 'org.gajim.Gaji=
m-symbolic' not present in theme Adwaita (0)
--8<---------------cut here---------------end--------------->8---

Does simply adding =E2=80=98hicolor-icon-theme=E2=80=99 to =E2=80=98inputs=
=E2=80=99 fix the issue?

Unfortunately, Gajim fails to build for me as described in
<https://dev.gajim.org/gajim/gajim/-/issues/10478>.

Raghav, what should we do about it?  The issue above is closed, but are
we missing the fix?

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: "Raghav Gururajan" <rg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 13 Jul 2022 08:55:01 +0000
Resent-Message-ID: <handler.56382.B56382.165770248228983 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "Ludovic =?UTF-8?Q?Court=C3=A8s?=" <ludo@HIDDEN>
Cc: Morgan.J.Smith@HIDDEN, 56382 <at> debbugs.gnu.org
MIME-Version: 1.0
Date: Wed, 13 Jul 2022 08:54:37 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: "Raghav Gururajan" <rg@HIDDEN>
Message-ID: <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
In-Reply-To: <87sfn6asfz.fsf@HIDDEN>
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Ludo,=0A=0A> Does simply adding =E2=80=98hicolor-icon-theme=E2=80=99 to =
=E2=80=98inputs=E2=80=99 fix the issue?=0A=0AMost gtk-based apps expect h=
icolor-icon-theme and adwaita-icon-theme to be in the profile. Adding the=
se in either system or user profile would prevent this error from occurri=
ng.=0A=0A> Unfortunately, Gajim fails to build for me as described in=0A>=
 <https://dev.gajim.org/gajim/gajim/-/issues/10478>.=0A> =0A> Raghav, wha=
t should we do about it? The issue above is closed, but are=0A> we missin=
g the fix?=0A=0AThat's odd. The upstream removed those obsolete test file=
s which were causing the build failure. Could you please confirm the comm=
it and system-architecture you tried to build on?=0A=0ARegards,=0ARG.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Raghav Gururajan <rg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 13 Jul 2022 16:08:01 +0000
Resent-Message-ID: <handler.56382.B56382.165772843032719 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56382
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Morgan.J.Smith@HIDDEN, 56382 <at> debbugs.gnu.org
Received: via spool by 56382-submit <at> debbugs.gnu.org id=B56382.165772843032719
          (code B ref 56382); Wed, 13 Jul 2022 16:08:01 +0000
Received: (at 56382) by debbugs.gnu.org; 13 Jul 2022 16:07:10 +0000
Received: from localhost ([127.0.0.1]:47569 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oBetH-0008Vb-9x
	for submit <at> debbugs.gnu.org; Wed, 13 Jul 2022 12:07:10 -0400
Received: from out2.migadu.com ([188.165.223.204]:39699)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rg@HIDDEN>) id 1oBetC-0008VD-F0
 for 56382 <at> debbugs.gnu.org; Wed, 13 Jul 2022 12:07:06 -0400
Message-ID: <bc00a04c-c7f2-e556-24e1-77b59df31b35@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raghavgururajan.name; 
 s=key1; t=1657728421;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=BSKF6GwPeyu7fSbKEIkVVJl4q5T9K4JKrqBKo+uACPg=;
 b=btxK0Ek7P9ANhoZrm+4kh7SJxbLJEdtKWEQf232TOOpZYP1S8bZGjdxp6vwpJW/tzB/NkS
 5eu0W1yFA+O5vr5qtms3CJtNbt/r5u4sqzOymrdF0j3/V44nOLhYSHo4p3CkoqyXzPMQff
 aW8Ymbrf9DnoAg5fan9/S5czQgXPFAp7itlTMVqKLl62GcQ7y3a2xQU3rsX3SIB00I1dSD
 WAXba6h2dqmrNZOv7KowzWJy1/aBbQV+/EXsLvvkgkvLe5Y3R9aipcyYusssB4kSop+23A
 aWvTza0UxRJZ0TCjI+c8I/o/y03r79NToSyq5yt4sv2NnsNumqw5YLLHlfBYaQ==
Date: Wed, 13 Jul 2022 12:06:52 -0400
MIME-Version: 1.0
Content-Language: en-CA
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Raghav Gururajan <rg@HIDDEN>
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
In-Reply-To: <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------w9pM2gktrehHrly6uFhiYwFD"
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: raghavgururajan.name
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------w9pM2gktrehHrly6uFhiYwFD
Content-Type: multipart/mixed; boundary="------------eWapZyOWHGUWqofYKL970NjT";
 protected-headers="v1"
From: Raghav Gururajan <rg@HIDDEN>
To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= <ludo@HIDDEN>
Cc: 56382 <at> debbugs.gnu.org, Morgan.J.Smith@HIDDEN
Message-ID: <bc00a04c-c7f2-e556-24e1-77b59df31b35@HIDDEN>
Subject: Re: bug#56382: [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid
 crashing on startup
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
In-Reply-To: <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>

--------------eWapZyOWHGUWqofYKL970NjT
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

THVkbywNCg0KPj4gRG9lcyBzaW1wbHkgYWRkaW5nIOKAmGhpY29sb3ItaWNvbi10aGVtZeKA
mSB0byDigJhpbnB1dHPigJkgZml4IHRoZSBpc3N1ZT8NCj4gDQo+IE1vc3QgZ3RrLWJhc2Vk
IGFwcHMgZXhwZWN0IGhpY29sb3ItaWNvbi10aGVtZSBhbmQgYWR3YWl0YS1pY29uLXRoZW1l
IHRvIGJlIGluIHRoZSBwcm9maWxlLiBBZGRpbmcgdGhlc2UgaW4gZWl0aGVyIHN5c3RlbSBv
ciB1c2VyIHByb2ZpbGUgd291bGQgcHJldmVudCB0aGlzIGVycm9yIGZyb20gb2NjdXJyaW5n
Lg0KPiANCj4+IFVuZm9ydHVuYXRlbHksIEdhamltIGZhaWxzIHRvIGJ1aWxkIGZvciBtZSBh
cyBkZXNjcmliZWQgaW4NCj4+IDxodHRwczovL2Rldi5nYWppbS5vcmcvZ2FqaW0vZ2FqaW0v
LS9pc3N1ZXMvMTA0Nzg+Lg0KPj4NCj4+IFJhZ2hhdiwgd2hhdCBzaG91bGQgd2UgZG8gYWJv
dXQgaXQ/IFRoZSBpc3N1ZSBhYm92ZSBpcyBjbG9zZWQsIGJ1dCBhcmUNCj4+IHdlIG1pc3Np
bmcgdGhlIGZpeD8NCj4gDQo+IFRoYXQncyBvZGQuIFRoZSB1cHN0cmVhbSByZW1vdmVkIHRo
b3NlIG9ic29sZXRlIHRlc3QgZmlsZXMgd2hpY2ggd2VyZSBjYXVzaW5nIHRoZSBidWlsZCBm
YWlsdXJlLiBDb3VsZCB5b3UgcGxlYXNlIGNvbmZpcm0gdGhlIGNvbW1pdCBhbmQgc3lzdGVt
LWFyY2hpdGVjdHVyZSB5b3UgdHJpZWQgdG8gYnVpbGQgb24/DQoNCkl0IGFwcGVhcnMgdGhl
IGJ1aWxkIGZhaWxzIG9uIENJIHRvbyANCltodHRwczovL2NpLmd1aXguZ251Lm9yZy9idWls
ZC8xMDk5MzYzL2xvZy9yYXddLiBUaGlzIHRpbWUgaXRzIGEgDQpkaWZmZXJlbnQgdGVzdCB0
aGF0IGlzIGZhaWxpbmcuIEJ1dCBzYW1lIGFzIGJlZm9yZSwgaXQgcGFzc2VzIG9uIG15IA0K
bWFjaGluZSBhbmQgcHJvYmFibHkgcGFzc2VzIG9uIHNvbWUgb3RoZXIgbWFjaGluZXMgdG9v
LiBQdXNoZWQgdGhlIGZpeCANCmFzIGNvbW1pdCAJMjk5ODAwOTg1MDhlMWUyM2E3NjdhN2M5
MWZlMjdmMDQ3ODQxOGViMiwgYW5kIHJlcG9ydGVkIHRoZSANCmJ1ZyB1cHN0cmVhbS4NCg0K
UmVnYXJkcywNClJHLg0K

--------------eWapZyOWHGUWqofYKL970NjT--

--------------w9pM2gktrehHrly6uFhiYwFD
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wnsEABYIACMWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYs7tnAUDAAAAAAAKCRBfWBZkf4vlUT09
AP9hZLTsGKxRt9lGqSWYaHIxSl+LYVa9A8oVKPFhNe1nIAEAmAidRBq0lKurJvueYaCxKCxTHLyr
gN4yZL44wTD9xQU=
=+LXH
-----END PGP SIGNATURE-----

--------------w9pM2gktrehHrly6uFhiYwFD--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 15 Jul 2022 13:03:01 +0000
Resent-Message-ID: <handler.56382.B56382.16578901361243 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56382
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: "Raghav Gururajan" <rg@HIDDEN>
Cc: Morgan.J.Smith@HIDDEN, 56382 <at> debbugs.gnu.org
Received: via spool by 56382-submit <at> debbugs.gnu.org id=B56382.16578901361243
          (code B ref 56382); Fri, 15 Jul 2022 13:03:01 +0000
Received: (at 56382) by debbugs.gnu.org; 15 Jul 2022 13:02:16 +0000
Received: from localhost ([127.0.0.1]:39800 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oCKxU-0000Jy-4G
	for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 09:02:16 -0400
Received: from eggs.gnu.org ([209.51.188.92]:53122)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1oCKxP-0000Ji-R4
 for 56382 <at> debbugs.gnu.org; Fri, 15 Jul 2022 09:02:15 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:33112)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oCKxJ-0006re-2f; Fri, 15 Jul 2022 09:02:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=9HEIBo69vW5+23guk54WWDobmoC1C1TmzKt+yYzXZY4=; b=BHH/slNPmhdF1B4NtTM7
 qt3lIgDvY94OuVUJUdDZ9OfyQuxtcvL019rNWreWuM5XiNdMlgEh9H5539ZilMGdiQwi5GtRsa3nn
 tkTHWa/KYurbqZI44UUBcKGxQqDpXgbWBZYg5lPUvmi4WjGhlxvV//uh1w99QidHvsxzKHdlKAs8M
 n2Tqg2RLw0SDBwklFLdsUeDEW+XqOFNf638zC/N7rzwssiSxAw+Ty1qFsCmsxX/sTU9XUR3brt5OU
 iM3Kue7ywsEHgkr7kVbPmo5dxvVyJ/EwvoGj1BX09ZQd0AePj5OSdd7TuQ5KU2IqurBNsTQ5jjTxs
 uBPPlQwTxwxgWg==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59294
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oCKxI-00065N-MS; Fri, 15 Jul 2022 09:02:04 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Septidi 27 Messidor an 230 de la =?UTF-8?Q?R=C3=A9volution,?= jour de l'Ail
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Fri, 15 Jul 2022 15:02:02 +0200
In-Reply-To: <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN> (Raghav
 Gururajan's message of "Wed, 13 Jul 2022 08:54:37 +0000")
Message-ID: <877d4e8r79.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

"Raghav Gururajan" <rg@HIDDEN> skribis:

>> Does simply adding =E2=80=98hicolor-icon-theme=E2=80=99 to =E2=80=98inpu=
ts=E2=80=99 fix the issue?
>
> Most gtk-based apps expect hicolor-icon-theme and adwaita-icon-theme to b=
e in the profile. Adding these in either system or user profile would preve=
nt this error from occurring.

Right, so the proposed patch (adding =E2=80=98hicolor-icon-theme=E2=80=99 t=
o =E2=80=98inputs=E2=80=99,
not =E2=80=98propagated-inputs=E2=80=99) shouldn=E2=80=99t make any differe=
nce I guess?

>> Unfortunately, Gajim fails to build for me as described in
>> <https://dev.gajim.org/gajim/gajim/-/issues/10478>.
>>=20
>> Raghav, what should we do about it? The issue above is closed, but are
>> we missing the fix?
>
> That's odd. The upstream removed those obsolete test files which were cau=
sing the build failure. Could you please confirm the commit and system-arch=
itecture you tried to build on?

I retried and this time it passed.  Perhaps it=E2=80=99s non-deterministic?
Maybe has to do with running tests in parallel?

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 16 Jul 2022 01:39:01 +0000
Resent-Message-ID: <handler.56382.B56382.16579354978915 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56382
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Raghav Gururajan <rg@HIDDEN>, 56382 <at> debbugs.gnu.org, Morgan.J.Smith@HIDDEN
Received: via spool by 56382-submit <at> debbugs.gnu.org id=B56382.16579354978915
          (code B ref 56382); Sat, 16 Jul 2022 01:39:01 +0000
Received: (at 56382) by debbugs.gnu.org; 16 Jul 2022 01:38:17 +0000
Received: from localhost ([127.0.0.1]:42542 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oCWl7-0002Jj-Dq
	for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 21:38:17 -0400
Received: from mail-qt1-f170.google.com ([209.85.160.170]:34727)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1oCWl5-0002JS-LC
 for 56382 <at> debbugs.gnu.org; Fri, 15 Jul 2022 21:38:16 -0400
Received: by mail-qt1-f170.google.com with SMTP id e5so5057705qts.1
 for <56382 <at> debbugs.gnu.org>; Fri, 15 Jul 2022 18:38:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=rNtOcPBYnINtvu8w1IQkVAflWnY/IH6MxK71NimaaEE=;
 b=lq/RkcTtOO6FJviPl731WWrCOb/KJFZ4CsY+oKGTTVgGypzReyifrt1mb9fFiHp4H8
 IRVrEJRJPbruPg6E4cM7V5LORbFDydOdtAVmF79qkET/1H5Uw5FFJSdQfuid++BI3ZUD
 m8S3v2ZMsYqF7YgcnfdHCagA9pPV9YbUt/nZGxHwQHZH6S93wCkcdEAH8GzRJs80ff43
 PJI5dMf4FXnY/Tx0ifgh+/RtO/rhFtCdSQcDOibgQlPYkqETe8URIu3BlXc2b411uvqu
 HGf3DI308vqo8txp5oE8LM1AkV/GYsaq3y56INmADjSaSAFJw7atpI3sc5ym8PtBsY2Y
 mC/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=rNtOcPBYnINtvu8w1IQkVAflWnY/IH6MxK71NimaaEE=;
 b=jvQOjw3MOe9wPppLl+KgoZ3Nj56avxLUsrbHJd6iDNdMWR/J0B4Gt4S6gVD1JW14Oi
 fmqokOnUlrFCZMIhhq6mk4m54avNHZjs8uoWPOqj5buqWPamstxQRTbCbYm6rtyt1Zi+
 kRGXT+GiiIZNR4dn/IgU2B8lBTwwcJGHgg3otRIJJtZpTRosLhOZvdjYeF9WSyNpdpbZ
 JpaT7csV+fGQk3PdAAQYNvdQZeJnpBH1TgY+s3KVp0I3/NKuKHDOBWiO2LYrUfpTanVJ
 FHi2vwgTYi3H9091+sfzkwv7KQhui/+sqWaSgxmkKMUJ50kk48kl1cxXh0nesZo/YrGk
 FAnQ==
X-Gm-Message-State: AJIora9HNIhXe1SPZdVX4ibZGirIGLHZJBv4EBEneRFMAj/JpdspcSBX
 ZapMX8rhHKgyAd/lTgt4eJGhRBizIJ4y4w==
X-Google-Smtp-Source: AGRyM1tGLArW4ziSCyct6rOLAuhi4MlOkAjZ8J+MoFjpjqWsrxGYfnKIzqdxKEKnQTt+6YPEps792Q==
X-Received: by 2002:ac8:584d:0:b0:31e:e631:ddc2 with SMTP id
 h13-20020ac8584d000000b0031ee631ddc2mr157673qth.617.1657935490077; 
 Fri, 15 Jul 2022 18:38:10 -0700 (PDT)
Received: from hurd (dsl-205-233-125-176.b2b2c.ca. [205.233.125.176])
 by smtp.gmail.com with ESMTPSA id
 cn11-20020a05622a248b00b0031eb00e6fc9sm4667760qtb.32.2022.07.15.18.38.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 15 Jul 2022 18:38:09 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
 <877d4e8r79.fsf@HIDDEN>
Date: Fri, 15 Jul 2022 21:38:08 -0400
In-Reply-To: <877d4e8r79.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 15 Jul 2022 15:02:02 +0200")
Message-ID: <87tu7hsupr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludovic,

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Hi,
>
> "Raghav Gururajan" <rg@HIDDEN> skribis:
>
>>> Does simply adding =E2=80=98hicolor-icon-theme=E2=80=99 to =E2=80=98inp=
uts=E2=80=99 fix the issue?
>>
>> Most gtk-based apps expect hicolor-icon-theme and adwaita-icon-theme to =
be in the profile. Adding these in either system or user profile would prev=
ent this error from occurring.
>
> Right, so the proposed patch (adding =E2=80=98hicolor-icon-theme=E2=80=99=
 to =E2=80=98inputs=E2=80=99,
> not =E2=80=98propagated-inputs=E2=80=99) shouldn=E2=80=99t make any diffe=
rence I guess?

I think it works as inputs because of our wrappers (perhaps
XDG_DATA_DIRS)?  But it's kind at odds with our policy which is to let
users manage icons themselves.

Probably because of #20255 that wouldn't help currently (system and user
profiles are not merged), but if we fixed that bug we could make the
situation better by adding 'hicolor-icon-theme' to the default packages
of our desktop system templates.

Thanks,

Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 18 Jul 2022 09:31:02 +0000
Resent-Message-ID: <handler.56382.B56382.165813661519294 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56382
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: Raghav Gururajan <rg@HIDDEN>, 56382 <at> debbugs.gnu.org, 20255 <at> debbugs.gnu.org, Morgan.J.Smith@HIDDEN
Received: via spool by 56382-submit <at> debbugs.gnu.org id=B56382.165813661519294
          (code B ref 56382); Mon, 18 Jul 2022 09:31:02 +0000
Received: (at 56382) by debbugs.gnu.org; 18 Jul 2022 09:30:15 +0000
Received: from localhost ([127.0.0.1]:49182 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDN4w-000512-M6
	for submit <at> debbugs.gnu.org; Mon, 18 Jul 2022 05:30:15 -0400
Received: from eggs.gnu.org ([209.51.188.92]:55072)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>)
 id 1oDN4n-0004yo-LH; Mon, 18 Jul 2022 05:30:10 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59218)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oDN4h-0008Fi-IX; Mon, 18 Jul 2022 05:29:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=cx/RkAi8vCzdWqXQ+zSox2x5BmqlDz+0CqSfENtLXr8=; b=WFH1BNxNKlFLi7BK0TZv
 1261q4AFXq5UaE5Ue5X6fbpIBBvuJ8MBSxg1yFQZgSGTgnIYlhVFMqxiVUYewNH2JGyN/uM87zwtr
 MJkvjXsBUekyRepytBeTfSQPS8QfBdQ6UkyNv+zFKPRocGjwQ2hgNUKcXa2zITxTLcqpWtOj2EKHP
 bOyWQlSNGPzUiJRfMQZavtaOGp5JPso/4T4szgUa7l9l+4+9j9H06kd83Zw9Q0TxL2i/UJ4JCegsR
 iXmm/SQS2MEDMwtN54DKEt1ai0Qy6vOgQnj4iFLO1P/HJNE5gPcWMuNl36hT6C5o+CuAAKO3KgfaK
 01kYpwrxbPLOIQ==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41642 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oDN4g-0000R6-NP; Mon, 18 Jul 2022 05:29:59 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
 <877d4e8r79.fsf@HIDDEN> <87tu7hsupr.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: =?UTF-8?Q?D=C3=A9cadi?= 30 Messidor an 230 de la
 =?UTF-8?Q?R=C3=A9volution,?= jour de la
 =?UTF-8?Q?Chal=C3=A9mie?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Mon, 18 Jul 2022 11:29:55 +0200
In-Reply-To: <87tu7hsupr.fsf@HIDDEN> (Maxim Cournoyer's message of "Fri, 15
 Jul 2022 21:38:08 -0400")
Message-ID: <87k08a3h0s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:

> Hi Ludovic,
>
> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
>
>> Hi,
>>
>> "Raghav Gururajan" <rg@HIDDEN> skribis:
>>
>>>> Does simply adding =E2=80=98hicolor-icon-theme=E2=80=99 to =E2=80=98in=
puts=E2=80=99 fix the issue?
>>>
>>> Most gtk-based apps expect hicolor-icon-theme and adwaita-icon-theme to=
 be in the profile. Adding these in either system or user profile would pre=
vent this error from occurring.
>>
>> Right, so the proposed patch (adding =E2=80=98hicolor-icon-theme=E2=80=
=99 to =E2=80=98inputs=E2=80=99,
>> not =E2=80=98propagated-inputs=E2=80=99) shouldn=E2=80=99t make any diff=
erence I guess?
>
> I think it works as inputs because of our wrappers (perhaps
> XDG_DATA_DIRS)?  But it's kind at odds with our policy which is to let
> users manage icons themselves.

Yeah.

> Probably because of #20255 that wouldn't help currently (system and user
> profiles are not merged), but if we fixed that bug we could make the
> situation better by adding 'hicolor-icon-theme' to the default packages
> of our desktop system templates.

Right.

BTW, the reason the solution at <https://issues.guix.gnu.org/20255#12>
was rejected could be revisited.  Since that time, search paths made it
into the manifest itself, which brings a speed up:

--8<---------------cut here---------------start------------->8---
$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches '
$ time guix package -p ~/.guix-home/profile -p /run/current-system/profile =
--search-paths > /dev/null

real    0m0.540s
user    0m0.131s
sys     0m0.063s
$ time guix package -p ~/.guix-home/profile -p /run/current-system/profile =
--search-paths > /dev/null

real    0m0.135s
user    0m0.130s
sys     0m0.024s
--8<---------------cut here---------------end--------------->8---

Thoughts?

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 18 Jul 2022 11:22:03 +0000
Resent-Message-ID: <handler.56382.B56382.165814331431108 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56382
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Raghav Gururajan <rg@HIDDEN>, 56382 <at> debbugs.gnu.org, 20255 <at> debbugs.gnu.org, Morgan.J.Smith@HIDDEN
Received: via spool by 56382-submit <at> debbugs.gnu.org id=B56382.165814331431108
          (code B ref 56382); Mon, 18 Jul 2022 11:22:03 +0000
Received: (at 56382) by debbugs.gnu.org; 18 Jul 2022 11:21:54 +0000
Received: from localhost ([127.0.0.1]:49320 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDOp0-00085a-Eo
	for submit <at> debbugs.gnu.org; Mon, 18 Jul 2022 07:21:54 -0400
Received: from mail-qt1-f175.google.com ([209.85.160.175]:43727)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1oDOou-00084y-HW; Mon, 18 Jul 2022 07:21:49 -0400
Received: by mail-qt1-f175.google.com with SMTP id a9so8409974qtw.10;
 Mon, 18 Jul 2022 04:21:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=QnebC4v9Of8Z3sryzCjXmI7hUlxj3D7aIiV4baEPYEg=;
 b=d/qIEgAl6iboPOFeEeXl/Lq8KjdjDD28iQ89s+OHO/yETXEqFeGXPKr6YQIp9mqAoJ
 7tAQIefG8teGuX1hDZpH+WECWtulXRmaNGdK5CiLlbk8MqFBGUVlTVltxnPAYO/NK4mG
 1Xv48dy35XByRgzFErKiwHkQTHd1YSl3ixt4KY3p4aEUNTi8vrkto/DHMbIAgEOMe0l1
 SJWY/6BBlUyX6LSqSM0/sw7zYYea7gLrH68ftjSKvW0cW6OkqOjYMQR9v1tSzSevXhXj
 FC0Ttf3PdWtrcr5OazylVrZQU3hXAV1s+Qq1Ri+LorrZ3SCFLTOIaqxnL29TU9uC+xF0
 ezqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=QnebC4v9Of8Z3sryzCjXmI7hUlxj3D7aIiV4baEPYEg=;
 b=2eZrSYjMQVCBX+y+tWVNtl1jBXX6dRiB+A7FGFXgedqPfiCIJms8cE4dqHo2cbMJv2
 UbnmVvmJBooUN1pWi2sVqnmBkpraqjAuGpG7TcCI1H3CgLLI2j5or+MX/fShfWrKCrEz
 pjOD+oap9tZ14+eLRA0mm4paguGK6AN7vW/EJ8w7b5yyxxGm6pr1ucqlVBxB/DTuOeqY
 a8i5LgqGuAZgRdo8zugw869nAcknUtY4E/XRMVx932sneWakh32yybJKMhCQV0f7OBZZ
 B2PpZ0qpvuEtaIb49CiHo+swmsR5pXRNe1mFzpJYK1OY64K37vtUAZgtACZrIRqBlPl1
 VExw==
X-Gm-Message-State: AJIora/1SOlCWi7MqpMdg8XiA4SfqmgllRbh405B+4iaDcX644bknXeF
 8E1urWOtSE1b/NgpgX+aINYnMPU5py5QdQ==
X-Google-Smtp-Source: AGRyM1uNc5OFOLHhen7XP7oZJWULBsvfHVsMk7MF4nyXqOJQnA/oyrF+6ECCvdc5AKHNLYM3hUWRSA==
X-Received: by 2002:a05:622a:30c:b0:31e:bc56:98e4 with SMTP id
 q12-20020a05622a030c00b0031ebc5698e4mr20909493qtw.679.1658143302732; 
 Mon, 18 Jul 2022 04:21:42 -0700 (PDT)
Received: from hurd (dsl-205-151-56-157.b2b2c.ca. [205.151.56.157])
 by smtp.gmail.com with ESMTPSA id
 z25-20020ac87cb9000000b0031d283f4c4dsm8630169qtv.60.2022.07.18.04.21.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 18 Jul 2022 04:21:42 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
 <877d4e8r79.fsf@HIDDEN> <87tu7hsupr.fsf@HIDDEN>
 <87k08a3h0s.fsf@HIDDEN>
Date: Mon, 18 Jul 2022 07:21:40 -0400
In-Reply-To: <87k08a3h0s.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 18 Jul 2022 11:29:55 +0200")
Message-ID: <87edyism2j.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello!

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

[...]

>>> Right, so the proposed patch (adding =E2=80=98hicolor-icon-theme=E2=80=
=99 to =E2=80=98inputs=E2=80=99,
>>> not =E2=80=98propagated-inputs=E2=80=99) shouldn=E2=80=99t make any dif=
ference I guess?
>>
>> I think it works as inputs because of our wrappers (perhaps
>> XDG_DATA_DIRS)?  But it's kind at odds with our policy which is to let
>> users manage icons themselves.
>
> Yeah.
>
>> Probably because of #20255 that wouldn't help currently (system and user
>> profiles are not merged), but if we fixed that bug we could make the
>> situation better by adding 'hicolor-icon-theme' to the default packages
>> of our desktop system templates.
>
> Right.
>
> BTW, the reason the solution at <https://issues.guix.gnu.org/20255#12>
> was rejected could be revisited.  Since that time, search paths made it
> into the manifest itself, which brings a speed up:
>
> $ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches '
> $ time guix package -p ~/.guix-home/profile -p /run/current-system/profil=
e --search-paths > /dev/null
>
> real    0m0.540s
> user    0m0.131s
> sys     0m0.063s
> $ time guix package -p ~/.guix-home/profile -p /run/current-system/profil=
e --search-paths > /dev/null
>
> real    0m0.135s
> user    0m0.130s
> sys     0m0.024s
>
> Thoughts?

Re-reading the bug report, we had come up with a blueprint of a possible
solution  but failed short of implementing it [0]

[0]  https://issues.guix.gnu.org/20255#35

Even the --search-paths command become 0.2 s, I don't think it'll
satisfy all parties, so the solution above still has merit, I think.
Perhaps we should try to implement it, unless you see a problem with it.

Thanks,

Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56382] bug#20255: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: bokr@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 18 Jul 2022 13:34:01 +0000
Resent-Message-ID: <handler.56382.B56382.165815122420268 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56382
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Raghav Gururajan <rg@HIDDEN>, Morgan.J.Smith@HIDDEN, 56382 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, 20255 <at> debbugs.gnu.org
Received: via spool by 56382-submit <at> debbugs.gnu.org id=B56382.165815122420268
          (code B ref 56382); Mon, 18 Jul 2022 13:34:01 +0000
Received: (at 56382) by debbugs.gnu.org; 18 Jul 2022 13:33:44 +0000
Received: from localhost ([127.0.0.1]:49557 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDQsZ-0005Gh-LO
	for submit <at> debbugs.gnu.org; Mon, 18 Jul 2022 09:33:44 -0400
Received: from mailout.easymail.ca ([64.68.200.34]:41878)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bokr@HIDDEN>)
 id 1oDQsU-0005GH-Tz; Mon, 18 Jul 2022 09:33:41 -0400
Received: from localhost (localhost [127.0.0.1])
 by mailout.easymail.ca (Postfix) with ESMTP id 4BA09E2846;
 Mon, 18 Jul 2022 13:33:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bokr.com; s=easymail;
 t=1658151213; bh=YWaedQzFVAxzN77LVePc8QihnE0Xeatd+IbYGZJgIw4=;
 h=From:Date:To:Cc:Subject:References:In-Reply-To:From;
 b=USXNCC942TEt9OaeJqwvLv9w0OdnaTbJCEZu64iSdIaYm3C1Ydzw7rbVEvBnNBnbJ
 DW6zJ7h5RWkW/98nnyKkO6HQeTxH/62+6HJen40kyG0uMx3XIWYoUpkLqyKleC0TB3
 LF4X7qFl1Qs3b1ZAH91EZucxp5HifLo8UF4M/AvKdB9gAD0sYbuUn6qlBmASsDb1rg
 dICUXBijg4wP5Chs1hB96kAm2AW4Et1mfExHKfcvlYBjKBxiqZWZ+AN99ZK9N69zYS
 dTMGfrl7V1OU8eB5f5qE5Ma4mLZNByfroJ8g38UUVsu008q77SyYTM3894LM8bGBt8
 xdgKtShSc62EQ==
X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn
Received: from mailout.easymail.ca ([127.0.0.1])
 by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id TeYpSuVLeBCg; Mon, 18 Jul 2022 13:33:32 +0000 (UTC)
Received: from localhost (m90-129-211-26.cust.tele2.se [90.129.211.26])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mailout.easymail.ca (Postfix) with ESMTPSA id BD477E29C6;
 Mon, 18 Jul 2022 13:33:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bokr.com; s=easymail;
 t=1658151212; bh=YWaedQzFVAxzN77LVePc8QihnE0Xeatd+IbYGZJgIw4=;
 h=From:Date:To:Cc:Subject:References:In-Reply-To:From;
 b=jtEfxLgAZAXc0qso/4Vn98tM3F+BCX6M37ngLxP28RMAnqEl8oT2hLJgIAyBuJDwr
 eIbSeExAr4RXtGivsBNs+DQFPoOeX53kxzP7/XuFLyyqsANAehmy9r/MGl+fl2OzMw
 r3SULVTNXed23jJRWtom3NJYfQ6eqJ1ZkfjwJjTkpFDVxeOhJ0KXR75QILeKi1BS/m
 f3b+6y5GvmGKLlIbrJC0NW1Aty2ekwgFkVcln5eSFz0QVteKMnbekyG2/OAypc7IBw
 cgV3yrh85rWEMzli+KLjomjeq51HMWwvVrlgXrIZzlwRjAC93Bw4QTVtI6SyArMjxh
 erGv5KqjNoFIg==
From: bokr@HIDDEN
Date: Mon, 18 Jul 2022 15:33:18 +0200
Message-ID: <20220718133318.GA2771@LionPure>
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
 <877d4e8r79.fsf@HIDDEN> <87tu7hsupr.fsf@HIDDEN>
 <87k08a3h0s.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87k08a3h0s.fsf@HIDDEN>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Ludo,

On +2022-07-18 11:29:55 +0200, Ludovic Courtès wrote:
> Hi,
> 
> Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:
> 
> > Hi Ludovic,
> >
> > Ludovic Courtès <ludo@HIDDEN> writes:
> >
> >> Hi,
> >>
> >> "Raghav Gururajan" <rg@HIDDEN> skribis:
> >>
> >>>> Does simply adding ‘hicolor-icon-theme’ to ‘inputs’ fix the issue?
> >>>
> >>> Most gtk-based apps expect hicolor-icon-theme and adwaita-icon-theme to be in the profile. Adding these in either system or user profile would prevent this error from occurring.
> >>
> >> Right, so the proposed patch (adding ‘hicolor-icon-theme’ to ‘inputs’,
> >> not ‘propagated-inputs’) shouldn’t make any difference I guess?
> >
> > I think it works as inputs because of our wrappers (perhaps
> > XDG_DATA_DIRS)?  But it's kind at odds with our policy which is to let
> > users manage icons themselves.
> 
> Yeah.
> 
> > Probably because of #20255 that wouldn't help currently (system and user
> > profiles are not merged), but if we fixed that bug we could make the
> > situation better by adding 'hicolor-icon-theme' to the default packages
> > of our desktop system templates.
> 
> Right.
> 
> BTW, the reason the solution at <https://issues.guix.gnu.org/20255#12>
> was rejected could be revisited.  Since that time, search paths made it
> into the manifest itself, which brings a speed up:
> 
> --8<---------------cut here---------------start------------->8---
> $ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches '
> $ time guix package -p ~/.guix-home/profile -p /run/current-system/profile --search-paths > /dev/null
> 
> real    0m0.540s
> user    0m0.131s
> sys     0m0.063s
> $ time guix package -p ~/.guix-home/profile -p /run/current-system/profile --search-paths > /dev/null
> 
> real    0m0.135s
> user    0m0.130s
> sys     0m0.024s
> --8<---------------cut here---------------end--------------->8---
> 
> Thoughts?
> 
> Ludo’.

I'm sure you were just after a quick indication and know what can affect timing,
but I'm curious:

What would the above results be if you did the second timing
first, after a power down and cold start?

I'm guessing the kernel file systems are pretty clever about
caching stuff, especially if you have lots of ram :)

I.e., what cached state could the first timing have left for the second to profit from?

(I've been fooled maany times, benchmarking and timing :)

--
Regards,
Bengt Richter

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Raghav Gururajan <rg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 18 Jul 2022 15:21:01 +0000
Resent-Message-ID: <handler.56382.B56382.1658157609480 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56382
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Morgan.J.Smith@HIDDEN, 56382 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 56382-submit <at> debbugs.gnu.org id=B56382.1658157609480
          (code B ref 56382); Mon, 18 Jul 2022 15:21:01 +0000
Received: (at 56382) by debbugs.gnu.org; 18 Jul 2022 15:20:09 +0000
Received: from localhost ([127.0.0.1]:51845 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDSXY-00007g-OR
	for submit <at> debbugs.gnu.org; Mon, 18 Jul 2022 11:20:09 -0400
Received: from out2.migadu.com ([188.165.223.204]:24972)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rg@HIDDEN>) id 1oDSXU-00007U-B7
 for 56382 <at> debbugs.gnu.org; Mon, 18 Jul 2022 11:20:07 -0400
Message-ID: <cef370c5-5239-2c74-77d5-fde7b085ceef@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raghavgururajan.name; 
 s=key1; t=1658157603;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=7JbpxeTj75EVDPrZn1kpOuGfguShT/0CHpxY3i81gu8=;
 b=N4OYfA3fCaGMIOieAb/Nac0vFlSzNnq4+uFC7k+vwP3ekSC91975bZsDUT/z4iVUdcJkRg
 SPBDUFHP5PeKJEte8+9KcqLIN1iRM7ObZR72cyWCWvUCeTswAcmADeX3LHWwEO4AHI6c4Y
 tJOcfTTy094447etWeMQklgN8Rtw7xAehqrqm5D1//BJuND/hCrGGQNKCADId76z8ombVg
 +0FESdcAuMyzTC8jvBPdDyhFMogZPjShRoVf7CYda9b9Hp/rwmJrDUN6LyPiMXbmAmapA7
 rhkgONLH0CFC7fabGsiWhwrP8RjYJ2fVwcB1IqAy4g1HC8TXvvTWDmYz30jRpQ==
Date: Mon, 18 Jul 2022 11:19:50 -0400
MIME-Version: 1.0
Content-Language: en-CA
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
 <877d4e8r79.fsf@HIDDEN> <87tu7hsupr.fsf@HIDDEN>
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Raghav Gururajan <rg@HIDDEN>
In-Reply-To: <87tu7hsupr.fsf@HIDDEN>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------9370aUBJ8eTUWXV7cdNutggM"
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: raghavgururajan.name
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------9370aUBJ8eTUWXV7cdNutggM
Content-Type: multipart/mixed; boundary="------------4Vde8iyJ1mDQNilv7queUrec";
 protected-headers="v1"
From: Raghav Gururajan <rg@HIDDEN>
To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= <ludo@HIDDEN>
Cc: Morgan.J.Smith@HIDDEN, 56382 <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Message-ID: <cef370c5-5239-2c74-77d5-fde7b085ceef@HIDDEN>
Subject: Re: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid
 crashing on startup
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
 <877d4e8r79.fsf@HIDDEN> <87tu7hsupr.fsf@HIDDEN>
In-Reply-To: <87tu7hsupr.fsf@HIDDEN>

--------------4Vde8iyJ1mDQNilv7queUrec
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

THVkbywNCg0KPj4gUmlnaHQsIHNvIHRoZSBwcm9wb3NlZCBwYXRjaCAoYWRkaW5nIOKAmGhp
Y29sb3ItaWNvbi10aGVtZeKAmSB0byDigJhpbnB1dHPigJksDQo+PiBub3Qg4oCYcHJvcGFn
YXRlZC1pbnB1dHPigJkpIHNob3VsZG7igJl0IG1ha2UgYW55IGRpZmZlcmVuY2UgSSBndWVz
cz8NCj4gDQo+IEkgdGhpbmsgaXQgd29ya3MgYXMgaW5wdXRzIGJlY2F1c2Ugb2Ygb3VyIHdy
YXBwZXJzIChwZXJoYXBzDQo+IFhER19EQVRBX0RJUlMpPyAgQnV0IGl0J3Mga2luZCBhdCBv
ZGRzIHdpdGggb3VyIHBvbGljeSB3aGljaCBpcyB0byBsZXQNCj4gdXNlcnMgbWFuYWdlIGlj
b25zIHRoZW1zZWx2ZXMuDQoNClllcCwgYWRkaW5nIGljb25zIHRvIGlucHV0cyBzaG91bGQg
d29yayBiZWNhdXNlIG9mIHRoZSB3cmFwcGVycy4gQnV0IHRoZSANCnJlYXNvbiBNYXhpbSBt
ZW50aW9uZWQsIGlzIHdoeSBJIGhhdmVuJ3QgYWRkZWQgaWNvbnMgdG8gaW5wdXRzIGluIEdh
amltLg0KDQpSZWdhcmRzLA0KUkcuDQo=

--------------4Vde8iyJ1mDQNilv7queUrec--

--------------9370aUBJ8eTUWXV7cdNutggM
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wnsEABYIACMWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYtV6FgUDAAAAAAAKCRBfWBZkf4vlUQM1
APsF02+hTM+7A1VegyP9i0Q80Cpour3YyDqpgTfuloISagD/UdVeN8J91hJYkx7omgbXJxFpVl2I
JfRaKTgzNPd9zQQ=
=5mRj
-----END PGP SIGNATURE-----

--------------9370aUBJ8eTUWXV7cdNutggM--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56382] bug#20255: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 19 Jul 2022 08:31:02 +0000
Resent-Message-ID: <handler.56382.B56382.16582194281999 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56382
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: bokr@HIDDEN
Cc: Raghav Gururajan <rg@HIDDEN>, Morgan.J.Smith@HIDDEN, 56382 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, 20255 <at> debbugs.gnu.org
Received: via spool by 56382-submit <at> debbugs.gnu.org id=B56382.16582194281999
          (code B ref 56382); Tue, 19 Jul 2022 08:31:02 +0000
Received: (at 56382) by debbugs.gnu.org; 19 Jul 2022 08:30:28 +0000
Received: from localhost ([127.0.0.1]:52747 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oDicX-0000Vs-1i
	for submit <at> debbugs.gnu.org; Tue, 19 Jul 2022 04:30:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45712)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>)
 id 1oDicN-0000UF-7O; Tue, 19 Jul 2022 04:30:19 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59998)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oDicF-0007bG-4a; Tue, 19 Jul 2022 04:30:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=XFv7coPNgEmt8EUxuz6aCPAOAWc1w6otd6EaGMPioqo=; b=D43fk+/AmmZwAegniEYP
 zYCKlZUqv+4yZdK9ij8IDcoARHpGjAGKLBU3T8DCmx87puqbDqfeOabh+cxB7JwRBkg2fHcLb8sNo
 u8XcChjoqwepywJOA16ar34gDFa6u05WBQ2+lZ6sfY9QHJHUI62I3Ack8T34MXeX+dkZU/VQVei1s
 ncCX9N4pS10vnGX+xQ5DZ1h7/IQ7qH9FoAHNbSABYvqoOxBoTtbxtX4oZ2t3tCDoMpJvJY5sU1v24
 qOQk/hwtRjABojenHPOlHZvAAPRJKLuQCWvwe7R3ujyPUzj3YRkp8qZQe0YEVrjw5Pj3jJbGuaP+w
 uCblSYOSJK4cag==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=54716 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oDicE-00048r-Lq; Tue, 19 Jul 2022 04:30:02 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <87sfn6asfz.fsf@HIDDEN>
 <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@HIDDEN>
 <ff47ca4d7bfe0148f827dac382ca6211@HIDDEN>
 <877d4e8r79.fsf@HIDDEN> <87tu7hsupr.fsf@HIDDEN>
 <87k08a3h0s.fsf@HIDDEN> <20220718133318.GA2771@LionPure>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Primidi 1 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution,?= jour de =?UTF-8?Q?l'=C3=89pautre?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Tue, 19 Jul 2022 10:29:59 +0200
In-Reply-To: <20220718133318.GA2771@LionPure> (bokr@HIDDEN's message of
 "Mon, 18 Jul 2022 15:33:18 +0200")
Message-ID: <871quhwlmg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

bokr@HIDDEN skribis:

> I'm sure you were just after a quick indication and know what can affect =
timing,
> but I'm curious:
>
> What would the above results be if you did the second timing
> first, after a power down and cold start?
>
> I'm guessing the kernel file systems are pretty clever about
> caching stuff, especially if you have lots of ram :)

The =E2=80=98drop_caches=E2=80=99 command is meant to drop all caches, as i=
f I were
doing it on a cold start.

Ludo=E2=80=99.

Last modified: Tue, 19 Jul 2022 08:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.