GNU logs - #56423, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 06 Jul 2022 16:23:02 +0000
Resent-Message-ID: <handler.56423.B.165712456912184 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 56423 <at> debbugs.gnu.org
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Date: Wed, 06 Jul 2022 18:22:36 +0200
Message-ID: <874jzui52r.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=217.72.192.78;
 envelope-from=michael_heerdegen@HIDDEN; helo=mout.web.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)


Hello,

in a dired buffer, M-x hi-lock-face-buffer RET and enter a pattern so
that there are matches.  Then M-x wdired-change-to-wdired-mode and edit
something (insert a char or so).  Hi-Lock highlighting immediately
disappears.  Changing back to normal dired doesn't let highlighting
reappear.  That's not good.  I would like highlighting to stay when
starting or finishing `wdired-mode'.

The (only) reason for this is that when toggling `wdired-mode' the
hi-lock pattern rules added to `font-lock-keywords' are gone (why?).

So this fixes the problem for me:

#+begin_src emacs-lisp
(defun my-wdired-run-font-lock-mode-hook (&rest _)
  "Necessary to get hi-lock survive toggling `wdired-mode'."
  (run-hooks 'font-lock-mode-hook))

(dolist (f `(,#'wdired-change-to-wdired-mode
             ,#'wdired-finish-edit
             ,#'wdired-abort-changes))
  (advice-add f :after #'my-wdired-run-font-lock-mode-hook))
#+end_src

Running `hi-lock-font-lock-hook' instead of the complete
`font-lock-mode-hook' also works.

I would like to know why this is necessary at all, and what a correct
fix that can be installed would look like.

TIA,

Michael.


In GNU Emacs 29.0.50 (build 14, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2022-07-06 built on drachen
Repository revision: b2df1cc19c2312b27f7bab6b3eb7d339f668113d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: bug#56423: Acknowledgement (29.0.50; Hi-lock in dired broken by
 toggling wdired-mode)
Message-ID: <handler.56423.B.165712456912184.ack <at> debbugs.gnu.org>
References: <874jzui52r.fsf@HIDDEN>
X-Gnu-PR-Message: ack 56423
X-Gnu-PR-Package: emacs
Reply-To: 56423 <at> debbugs.gnu.org
Date: Wed, 06 Jul 2022 16:23:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 56423 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
56423: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56423
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 06 Jul 2022 18:59:02 +0000
Resent-Message-ID: <handler.56423.B56423.16571339374916 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 56423 <at> debbugs.gnu.org
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <874jzui52r.fsf@HIDDEN> (Michael Heerdegen's message of "Wed, 06
 Jul 2022 18:22:36 +0200")
References: <874jzui52r.fsf@HIDDEN>
Date: Wed, 06 Jul 2022 20:58:45 +0200
Message-ID: <87iloa2hlm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> The (only) reason for this is that when toggling `wdired-mode' the
> hi-lock pattern rules added to `font-lock-keywords' are gone (why?).

Ok, tried to follow what happens.  Hitting the first key after entering
wdired calls `font-lock-set-defaults' like this:

| (font-lock-set-defaults)
| (font-lock-fontify-region 132 243)
| (jit-lock--run-functions 132 243)
| (jit-lock-fontify-now 132 1632)
| (jit-lock-function 132)

and `font-lock-set-defaults' finds that

  (derived-mode-p font-lock-major-mode)

fails so that it recomputes the `font-lock-keywords' from the defaults.
I guess we could prevent that happening?

Michael.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 06 Jul 2022 19:20:01 +0000
Resent-Message-ID: <handler.56423.B56423.16571351857072 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 56423 <at> debbugs.gnu.org
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <87iloa2hlm.fsf@HIDDEN> (Michael Heerdegen's message of "Wed, 06
 Jul 2022 20:58:45 +0200")
References: <874jzui52r.fsf@HIDDEN> <87iloa2hlm.fsf@HIDDEN>
Date: Wed, 06 Jul 2022 21:19:35 +0200
Message-ID: <87mtdmyrp4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> [...] and `font-lock-set-defaults' finds that
>
>   (derived-mode-p font-lock-major-mode)
>
> fails so that it recomputes the `font-lock-keywords' from the
> defaults.  I guess we could prevent that happening?

This patch seems to fix the issue.  Good idea?


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-WIP-Fix-wdired-vs.-hi-lock-Bug-56423.patch
Content-Transfer-Encoding: quoted-printable

=46rom 26baa6c65e934b110499c77255c5c54a89acd116 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Date: Wed, 6 Jul 2022 21:16:19 +0200
Subject: [PATCH] WIP: Fix wdired vs. hi-lock Bug#56423

=2D--
 lisp/wdired.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/wdired.el b/lisp/wdired.el
index a5858ed190..7c8969431f 100644
=2D-- a/lisp/wdired.el
+++ b/lisp/wdired.el
@@ -261,6 +261,7 @@ wdired-change-to-wdired-mode
   (add-hook 'before-change-functions #'wdired--before-change-fn nil t)
   (add-hook 'after-change-functions #'wdired--restore-properties nil t)
   (setq major-mode 'wdired-mode)
+  (setq font-lock-major-mode 'wdired-mode)
   (setq mode-name "Editable Dired")
   (add-function :override (local 'revert-buffer-function) #'wdired-revert=
)
   (set-buffer-modified-p nil)
@@ -457,6 +458,7 @@ wdired-change-to-dired-mode
   (force-mode-line-update)
   (setq buffer-read-only t)
   (setq major-mode 'dired-mode)
+  (setq font-lock-major-mode 'dired-mode)
   (setq mode-name "Dired")
   (dired-advertise)
   (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t)
=2D-
2.30.2


--=-=-=
Content-Type: text/plain



TIA,

Michael.

--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 07 Jul 2022 05:36:02 +0000
Resent-Message-ID: <handler.56423.B56423.165717213620137 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56423
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: 56423 <at> debbugs.gnu.org
Received: via spool by 56423-submit <at> debbugs.gnu.org id=B56423.165717213620137
          (code B ref 56423); Thu, 07 Jul 2022 05:36:02 +0000
Received: (at 56423) by debbugs.gnu.org; 7 Jul 2022 05:35:36 +0000
Received: from localhost ([127.0.0.1]:55510 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9KAp-0005Ej-TR
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 01:35:36 -0400
Received: from eggs.gnu.org ([209.51.188.92]:40424)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1o9KAm-0005EV-IZ
 for 56423 <at> debbugs.gnu.org; Thu, 07 Jul 2022 01:35:34 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:39572)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1o9KAh-0002af-1R; Thu, 07 Jul 2022 01:35:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=nZ0CcKD0+hEWO3dR5OgdAhOMOvOjza+WYdm0pO4hhO0=; b=qoKN0L7KK8Xm
 eA92PZZ4c8ldUDP0NUNV5tSyTBjXDyCindYf+z85R/vYH/PJJaYd7PrrOkA1e6LqmZAxyYE+qC+Rm
 Ot8EvX9D5QuOq/lZCElYNxtcMj0/TWXCQlHdyWwDjvuI9cC6MdN//O3JP+X1bkNnYYyPtIv73aYYO
 rF/Kab8IOvPVaeKnH7VOc3TSuCL6m2jU6kCjU/hqjkibt4AYDzvHKvnGGdOdYCHfBGXSwQT5ugY2b
 3VWj8nXZgynx6G62m7NS9Ubl/RA++gOJvowvwnsIfHIkjaQ3l1Bz/oqS75PldwYRtjyXyRDZNpK2o
 WcuHMF/L7uZYFpbVM/p7SQ==;
Received: from [87.69.77.57] (port=2891 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1o9KAe-00059P-LB; Thu, 07 Jul 2022 01:35:26 -0400
Date: Thu, 07 Jul 2022 08:35:20 +0300
Message-Id: <83o7y15vtz.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87mtdmyrp4.fsf@HIDDEN> (message from Michael Heerdegen on Wed,
 06 Jul 2022 21:19:35 +0200)
References: <874jzui52r.fsf@HIDDEN> <87iloa2hlm.fsf@HIDDEN>
 <87mtdmyrp4.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Michael Heerdegen <michael_heerdegen@HIDDEN>
> Date: Wed, 06 Jul 2022 21:19:35 +0200
> 
> diff --git a/lisp/wdired.el b/lisp/wdired.el
> index a5858ed190..7c8969431f 100644
> --- a/lisp/wdired.el
> +++ b/lisp/wdired.el
> @@ -261,6 +261,7 @@ wdired-change-to-wdired-mode
>    (add-hook 'before-change-functions #'wdired--before-change-fn nil t)
>    (add-hook 'after-change-functions #'wdired--restore-properties nil t)
>    (setq major-mode 'wdired-mode)
> +  (setq font-lock-major-mode 'wdired-mode)
>    (setq mode-name "Editable Dired")
>    (add-function :override (local 'revert-buffer-function) #'wdired-revert)
>    (set-buffer-modified-p nil)
> @@ -457,6 +458,7 @@ wdired-change-to-dired-mode
>    (force-mode-line-update)
>    (setq buffer-read-only t)
>    (setq major-mode 'dired-mode)
> +  (setq font-lock-major-mode 'dired-mode)
>    (setq mode-name "Dired")
>    (dired-advertise)
>    (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t)

Don't we need to make sure font-lock-major-mode is restored no matter
how wdired is exited, whether normally or abnormally?

I'm not too familiar with wdired, so apologies if what I said makes no
sense.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 07 Jul 2022 10:27:01 +0000
Resent-Message-ID: <handler.56423.B56423.16571895749348 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56423
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 56423 <at> debbugs.gnu.org
Received: via spool by 56423-submit <at> debbugs.gnu.org id=B56423.16571895749348
          (code B ref 56423); Thu, 07 Jul 2022 10:27:01 +0000
Received: (at 56423) by debbugs.gnu.org; 7 Jul 2022 10:26:14 +0000
Received: from localhost ([127.0.0.1]:55850 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9Oi6-0002Qi-1H
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 06:26:14 -0400
Received: from mout.web.de ([212.227.17.12]:51931)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1o9Oi3-0002QV-K2
 for 56423 <at> debbugs.gnu.org; Thu, 07 Jul 2022 06:26:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1657189564;
 bh=1IzjmB9gJNglowXZ2Eem5Z/mk3Ahrd/GCuRDERVjGio=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=cXuKGIoxuBOSQL9XN6vDbvaybIIy37SxDbyup+hIUetxhC6IPVDDzPIklIJ+WanLj
 yfIK2U0l99Z+rFA4xujAui6SwbMu96aTFHVPcOO6opJX1zL+8He5XXoVCvREl12rDK
 uBRDM/QJ29OqeX5ycfWt19NrP6GGxNZjAyZyMCLo=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.59.210.236]) by smtp.web.de (mrweb105
 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MrwwJ-1nmNgH1QcX-00ngRF; Thu, 07
 Jul 2022 12:26:04 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <83o7y15vtz.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 07 Jul
 2022 08:35:20 +0300")
References: <874jzui52r.fsf@HIDDEN> <87iloa2hlm.fsf@HIDDEN>
 <87mtdmyrp4.fsf@HIDDEN> <83o7y15vtz.fsf@HIDDEN>
Date: Thu, 07 Jul 2022 12:26:03 +0200
Message-ID: <87edyxz0as.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:p1OHaRwWod4URqf3sEoZG+LnzOlhasQCIErUZ0wO+ZoEOhnCOMc
 BTQPAedA0fkRPvG7s4fUMQDkD0JeZfhm6hQdDzoemfOKlLDE4oWjx4aHcYFOBvSH5fevJ9u
 LPeTSKne2PK8nNc3E+1P6iimmha7hudUpG1+UPOgjdNZKdabDfYkAQTbE/AVVlZd8EH7j4o
 GG0VM7AOZHvsbWfTIH9fQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:XaCjNEpWg+E=:KUgiwykW2GA60BWaazQUDV
 pZ8Yjh/a7sdvMBXUvM4Fz8J4BZ/bgVYpjmxtlEkmAppyajmuiPVDEu5Iyd/zb3X9KihY8R467
 EuPXC7EZNRHltTUSeZpzDLC5lOOo9T+SYYQ1NXPWkb4uwwopofpe7s0RcAoB/UN34cdXPgBpe
 +zPeSMW8OCBiBmQckjYlFsSi0xKcOBnewMajkhwa48V39LushnupYftgDpw/LIvGISUluSwRj
 4cgycWMkoqir/MAsXsqqGjrKfRaKLiVnuraJp0Njulv1+YmGjbAlXwS7k7QhYsEuXkCZ0XCsC
 LNa7Rs6QLrG0Qqqv+TlQ766kl8nLVVk2IXT+Puu+RTTpLiRN3LHjRAInsGOUe+r8Uq/MMWUE3
 tIl9duB6z0U/91AOlO3BC1S3cJaAUybPrQURMUauyQSfeTGY2WUIvcCioWNoLMRP3AH5u3z8H
 NEF/JcdjRwwgnoTH63PQ9Lje9uLFAnEcRn8b2lwPlrDskV1o3WYmwlK81s/jYTLRGEZU8pbx7
 GXFvQUNF0JxDZJCBgDGUQlYgtU20B9Or59n/Bc7lvcMdGvW6uf5c3dj5ydlt8W3eUvD4xCNnd
 cDBSALmhAWGpE54g0ZENjVGQAfnM1wzdFzew0Ym7FZfU4lmMFE1IoP7+UfU0IR+5Rj0+GBem+
 uYCMuN4hYaxE9WQeqqFZxNNeooxauyVmInOLEz1PN1KyQk/+bHE2tfv1iDmSCstEPZ6UZyQZk
 JT36TWic6heKP1rti838sFV3mkCX7kzLw9zeu9Yh62ixSlX3zy7Hs0BfLDLlrhakGcJOJtsM2
 c6TbsFo8m0oTv2GH5d4O9ib6kTPcOMPfyGo7HsIxGngNS6EW13EfqOPrQig3cclTUGcv6ZkSx
 vW8D2WZcuwBfg0oIW3pIiEpgkeDeqgtfK5XPdGIPAEf/jxIlHwvFDlZx/+NVsAhVuAsre3sgB
 UFl+xosa11wVQhmsPGM3gg21kTATZ41TfM4xyQMNmYjaofKwfViXQe7nmMBa/uewCDMOpMhYo
 oi6Jh+zIT6TK74Vx9i0Nnje/TshMN785/XhfgrL/M2iKwDXsKwcKN9imX6Z7nQr9qFCa/LEKA
 MgMRh9XwiFSzgBUPNaQwZ0Ngf1YdHvzOeWJA9pAaweqqnDFyJFa/AZgQg==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> > diff --git a/lisp/wdired.el b/lisp/wdired.el
> > index a5858ed190..7c8969431f 100644
> > --- a/lisp/wdired.el
> > +++ b/lisp/wdired.el
> > @@ -261,6 +261,7 @@ wdired-change-to-wdired-mode
> >    (add-hook 'before-change-functions #'wdired--before-change-fn nil t)
> >    (add-hook 'after-change-functions #'wdired--restore-properties nil t)
> >    (setq major-mode 'wdired-mode)
> > +  (setq font-lock-major-mode 'wdired-mode)
> >    (setq mode-name "Editable Dired")
> >    (add-function :override (local 'revert-buffer-function)
> > #'wdired-revert)
> >    (set-buffer-modified-p nil)
> > @@ -457,6 +458,7 @@ wdired-change-to-dired-mode
> >    (force-mode-line-update)
> >    (setq buffer-read-only t)
> >    (setq major-mode 'dired-mode)
> > +  (setq font-lock-major-mode 'dired-mode)
> >    (setq mode-name "Dired")
> >    (dired-advertise)
> >    (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t)

> Don't we need to make sure font-lock-major-mode is restored no matter
> how wdired is exited, whether normally or abnormally?

There are two official ways to return - `wdired-abort-changes' and
`wdired-finish-edit' - both call `wdired-change-to-dired-mode' (which I
modified).

If a way of exiting doesn't call `wdired-change-to-dired-mode' your
dired buffer would be broken afterwards AFAIU - you must call it to get
rid of the modifications made by wdired.

Michael.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 07 Jul 2022 10:36:02 +0000
Resent-Message-ID: <handler.56423.B56423.165719012010260 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56423
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: 56423 <at> debbugs.gnu.org
Received: via spool by 56423-submit <at> debbugs.gnu.org id=B56423.165719012010260
          (code B ref 56423); Thu, 07 Jul 2022 10:36:02 +0000
Received: (at 56423) by debbugs.gnu.org; 7 Jul 2022 10:35:20 +0000
Received: from localhost ([127.0.0.1]:55859 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9Oqu-0002fQ-91
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 06:35:20 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50344)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1o9Oqs-0002fE-VG
 for 56423 <at> debbugs.gnu.org; Thu, 07 Jul 2022 06:35:19 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42892)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1o9Oqn-0006uJ-LW; Thu, 07 Jul 2022 06:35:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=mfQVKHkJ5C5XlfZFNKvn3wjHW1NO1n7UkWAxQS9dIHk=; b=p+2kYW8iC2oB
 mu5XjLfQ80kk1PTSUly/Q7KyT7dSPftEbbtgSaEBj5WZe75B5i/wkuL0YgH5y7MKl9XinDGqi1llf
 pOdGlIFP6NwwYA1J4bPLnwS2tieZhar/o+8nhs2jjyoMeqywznCNNF5XUN++uBr8odclORQo+zt8b
 EV++GhtGaFC/8wr85aNtjIkB8qdRr8OnTBM/raS9D7pHdHkWBflrmMCd8qSROvKDUeJD85BOvP5Yq
 jZ9Z6W7WU9RlX29iEDps2sfxP+tPfbyxXWGsaoef0GS98SI+DZdCt5lXatzcuDp/mEUgGLTc4Cj0U
 GjMHNqLDd14xZXH+TSJHkA==;
Received: from [87.69.77.57] (port=1652 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1o9Oqn-0002bL-4K; Thu, 07 Jul 2022 06:35:13 -0400
Date: Thu, 07 Jul 2022 13:35:10 +0300
Message-Id: <83czeh5hy9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87edyxz0as.fsf@HIDDEN> (message from Michael Heerdegen on Thu,
 07 Jul 2022 12:26:03 +0200)
References: <874jzui52r.fsf@HIDDEN> <87iloa2hlm.fsf@HIDDEN>
 <87mtdmyrp4.fsf@HIDDEN> <83o7y15vtz.fsf@HIDDEN> <87edyxz0as.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Michael Heerdegen <michael_heerdegen@HIDDEN>
> Cc: 56423 <at> debbugs.gnu.org
> Date: Thu, 07 Jul 2022 12:26:03 +0200
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> > Don't we need to make sure font-lock-major-mode is restored no matter
> > how wdired is exited, whether normally or abnormally?
> 
> There are two official ways to return - `wdired-abort-changes' and
> `wdired-finish-edit' - both call `wdired-change-to-dired-mode' (which I
> modified).
> 
> If a way of exiting doesn't call `wdired-change-to-dired-mode' your
> dired buffer would be broken afterwards AFAIU - you must call it to get
> rid of the modifications made by wdired.

It sounds like you described the "normal" ways of returning?  I mostly
had in mind the "abnormal" ones, via one of the non-local exits.  If
that is possible, we should set up unwind-protect form.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 07 Jul 2022 11:15:02 +0000
Resent-Message-ID: <handler.56423.B56423.165719245514104 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56423
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 56423 <at> debbugs.gnu.org
Received: via spool by 56423-submit <at> debbugs.gnu.org id=B56423.165719245514104
          (code B ref 56423); Thu, 07 Jul 2022 11:15:02 +0000
Received: (at 56423) by debbugs.gnu.org; 7 Jul 2022 11:14:15 +0000
Received: from localhost ([127.0.0.1]:55904 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9PSZ-0003fQ-LO
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 07:14:15 -0400
Received: from mout.web.de ([212.227.17.11]:59421)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1o9PSX-0003fC-Dj
 for 56423 <at> debbugs.gnu.org; Thu, 07 Jul 2022 07:14:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1657192447;
 bh=aqWuSk124tpa5YD9x+iDwpjdeA9QQQK4LGtUuVEe9KM=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=MVTYtVlLMWcBJt1UTZnzIfw/rcc2jfGX6q5yzJkAxK403AxjoiTkXUH/KNtP3vnMK
 tQAJYRl2Ij3nNtbMlL1J6EHCQL9FHb3ZK4SNOpXFzNRovjZIvZUDvLjZAfa1Id7kmA
 DkwTNGyk7ykMGpWV90WO+Tz2dB2gd15s+krowJcQ=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.59.210.236]) by smtp.web.de (mrweb106
 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MxpmW-1nNSd70Fdm-00zZH9; Thu, 07
 Jul 2022 13:14:07 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
In-Reply-To: <83czeh5hy9.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 07 Jul
 2022 13:35:10 +0300")
References: <874jzui52r.fsf@HIDDEN> <87iloa2hlm.fsf@HIDDEN>
 <87mtdmyrp4.fsf@HIDDEN> <83o7y15vtz.fsf@HIDDEN>
 <87edyxz0as.fsf@HIDDEN> <83czeh5hy9.fsf@HIDDEN>
Date: Thu, 07 Jul 2022 13:14:05 +0200
Message-ID: <87bku15g5e.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:xpPNhtmfYDySs8P398aAGTJ3uFW79R7ZKlU385j5rY3QN74a33l
 g73afAm4n54oykGwbx1LijUlzd5Hnja7j3dXhOXi1ucdZbZjTsSPJhqrT+LxLM6CUeKs0dk
 cV1zTGwlzVcb2ZhwpWBgX9/S54g0tgOXVav1srZlZ3uzTl4rwZVapJzVyfRaqa+rENO185/
 6sTyB4O4ktodJRsZbPFyw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:vBwLsmWJAuY=:wYhUxs7EIUE9oscOYuhiC6
 2yO7wJ3ilCX3/92hOM3c7362i8R2GgQBlN1V1ibBOh0+4ABlJenAQOim31tBJGZ6BDQq1BUwi
 eDOAoNNewR4xGcb+J++1+jWaeBC/QY0OFq5bx8K0bAnxhrSmsxoZP4aMdjoKxbTQ2YPJ7ztyh
 AvFSPXDI/HObpmMD8ran3ECnuLwup6Jw5GhvnMEaNCWmXwG3EaYsETt7U2DYDxHVUd1w2GaZ+
 wgp5QzT+G+VMi/J7r0oAJc0TZ7KU4o4ERHFSbamVmwKKP0BgqcYGXK9T089vQTfV7Va/F6NYi
 NuHy+qVTXdSxyGQ632Rqg97C1wUWmmga0IQu/ZzFUFRh1weDYk6pLCPywodBOc/nDVWFLvbQD
 XB2HkoiVH315fGCrx59Lw5nlSmQnWfJrZW2SP7wewZv5eg9RC5J8y71lyXZJYS9Gr/Gw3HLAj
 97kTSUwb8/dDiUl/SZkviObg8VQC/w7lUdcGbvprD7HtcAPhzlmRJhO6pWyShna1GEUkegPpn
 sloK/REJ1GUNZI5hPcMPXUvELeFN7VTWFur1HR7wmMyNmUQFrPZSY7vTRWCFYY2wDjPodd6L0
 r0Iy6gehfc6wO8EkqunFRowJ53tEmdYP70Pk5owKJBj5UkzhqROjkIubdgIKetQlJmmo9KSg1
 YI2i2g1S/fx0gNxnRPt5hHo5z7410YUzrlGNxqBwxU8VpJPCho19K0x0P6arEGcTtn/G866Qr
 qmyUOVSKTh3dXu1VZrFoWSCYZ5Wk+cs5t1zL9sG+NDLbjDrIEsBpKxKJBiXU1ePA3XMobyp5s
 smH9usaeXDzczrJOsGJoS8FIMGuy25w4HrhsUFK/kB8MsbKHd8b0XuZ+xrcp6GVefcBZrULxB
 cBfkzCkwlThBP94EYS/cz24POf9R3/id52G8vhLJeF740S5Qde2WqyXr/4zgWovl1xTcLZQwh
 KJHL4CQCh16tVkyhbR3OZZC1geu41fukXWMf6F99+y4/LlhqLbukCMTxPjwp0SOUXzA9XGvav
 FqjXeSExZLPKQSRlAEyXhSCFdklHI6YxPBQ4kpyMzVR70lo4KNSarpRfZmSXyAccdazChktWn
 X8W58GdpSeL/E9KXKHa0fnJ6dBVbiOCgeRqpypAwHVdWRiL8u1XtFIE1g==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> It sounds like you described the "normal" ways of returning?  I mostly
> had in mind the "abnormal" ones, via one of the non-local exits.  If
> that is possible, we should set up unwind-protect form.

Ah - ok.  But AFAIK there is no non-local way of exiting possible.  In
wdired you are at top-level, you can only "exit" explicitly.  The
wording "exit" is a bit misleading in this context, actually you are
just switching to a (or something like a) different major mode and back.
There is no code where we could add an `unwind-protect' to - there is no
continuation executed after "exiting" wdired.

Michael.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 07 Jul 2022 13:30:02 +0000
Resent-Message-ID: <handler.56423.B56423.16572005732932 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56423
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: 56423 <at> debbugs.gnu.org
Received: via spool by 56423-submit <at> debbugs.gnu.org id=B56423.16572005732932
          (code B ref 56423); Thu, 07 Jul 2022 13:30:02 +0000
Received: (at 56423) by debbugs.gnu.org; 7 Jul 2022 13:29:33 +0000
Received: from localhost ([127.0.0.1]:56031 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9RZR-0000lA-WA
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 09:29:33 -0400
Received: from eggs.gnu.org ([209.51.188.92]:40310)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1o9RZN-0000kt-0w
 for 56423 <at> debbugs.gnu.org; Thu, 07 Jul 2022 09:29:29 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45924)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1o9RZH-00060W-LG; Thu, 07 Jul 2022 09:29:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=PUFb66mCA1+NvNP2VKOJeXvxG18DlmuVRjPwvG6ulGs=; b=PYCGjILfSoIZ
 NNOUGmIRE4Os8ZP9lQR3GaguSrYkenr2LzkpQ4QeL60QOZaHgf5D6apVGMYSDLS5d8onUBqQTmkiG
 V7ryKInvN57WyF067RNCOfyYptS+nbYFF9BTL/egSrMD5ZsFmrrJTJq/92fPyotXOthxCfOQ5hH4f
 qrg9j6Mf6oibRoIlirv70xSRD7d2VqxAR8vM90PhJQ414gZ7XGnDEEqqgfF7PPM84GvO0QLTajpOn
 G6gNC/47OHzq8oUX6pNLvNDAQQg4Az/EOnxOlD99q4uLRIe2Hp1yQqKUF/JQMdSvKHKWE6eiCpTE7
 tfk5dfP65AWFHtUNEC+B8A==;
Received: from [87.69.77.57] (port=4271 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1o9RZH-0002qS-54; Thu, 07 Jul 2022 09:29:19 -0400
Date: Thu, 07 Jul 2022 16:29:15 +0300
Message-Id: <835yk959w4.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87bku15g5e.fsf@HIDDEN> (message from Michael Heerdegen on Thu,
 07 Jul 2022 13:14:05 +0200)
References: <874jzui52r.fsf@HIDDEN> <87iloa2hlm.fsf@HIDDEN>
 <87mtdmyrp4.fsf@HIDDEN> <83o7y15vtz.fsf@HIDDEN>
 <87edyxz0as.fsf@HIDDEN> <83czeh5hy9.fsf@HIDDEN> <87bku15g5e.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Michael Heerdegen <michael_heerdegen@HIDDEN>
> Cc: 56423 <at> debbugs.gnu.org
> Date: Thu, 07 Jul 2022 13:14:05 +0200
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> > It sounds like you described the "normal" ways of returning?  I mostly
> > had in mind the "abnormal" ones, via one of the non-local exits.  If
> > that is possible, we should set up unwind-protect form.
> 
> Ah - ok.  But AFAIK there is no non-local way of exiting possible.

Not even with C-g at some un-opportune moment?  If so, there's no
problem, indeed.

Last modified: Thu, 7 Jul 2022 13:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.