GNU bug report logs - #56450
29.0.50; erc-match commands should store regular expressions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56450 in the body.
You can then email your comments to 56450 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; erc-match commands should store regular expressions
Date: Fri, 08 Jul 2022 06:27:26 -0700

[Message part 1 (text/plain, inline)]

Tags: patch

Currently, pals, fools, keywords, etc. aren't `regexp-quote'd by their
associated commands (such as `erc-add-pal') before being added as match
patterns. Thus, items containing special characters, like "boo[m]" or
"lol.fun.dad", tend to be ineffective. Worse, invalid regexps containing
things like unmatched brackets create errors in the process filter.

Something else not included that perhaps should be is a clearer
indication that items added interactively can match any substring in a
candidate without regard for boundaries. It may also be worth
contrasting this with what's ultimately highlighted. For example, if you
"M-x erc-add-pal RET bo RET", then "<bob>" (minus the brackets) will be
highlighted. Compare this to keywords, where only the matched portion
appears in a designated face.

Documentation aside, it might also be nice to retain a means of
interactively adding a regexp verbatim (IOW, the old behavior minus the
unhelpful completion list). Perhaps this can be done via universal
argument.

BTW, the individual who originally brought this to our attention on
Libera also mused about a command for jumping between keywords, so I've
included something sketchy to that effect. However, it suffers from an
intermittent issue that I can't yet reproduce reliably: basically, when
first invoked, it sometimes makes Emacs unresponsive for a few seconds.
If I can't manage to tame it, I'll just drop it from this patch set.

Lastly, these changes (as presented) uphold the proud ERC tradition of
mutating custom options on behalf of a user. If this is truly
objectionable, then I can switch to network-local analogs instead.
However, such a move may adversely affect third-party code, given that
this module's been around in roughly the same form for some 20 odd
years.

Thanks,
J.P.

P.S. This bug is not (yet) associated with any planned ERC release.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6)
 of 2022-07-06 built on localhost
Repository revision: e6504c3eda12c72268d2db6598764f043b74c24d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3'
 PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
faces cus-face macroexp files window text-properties overlay sha1 md5
base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 35545 5688)
 (symbols 48 5073 0)
 (strings 32 13303 1546)
 (string-bytes 1 429956)
 (vectors 16 9197)
 (vector-slots 8 145428 11407)
 (floats 8 21 25)
 (intervals 56 214 0)
 (buffers 992 10))

[0001-Quote-new-entries-as-regexps-in-erc-match-commands.patch (text/x-patch, attachment)]

[0002-Add-command-to-jump-to-erc-match-keywords.patch (text/x-patch, attachment)]

Message #8 received at 56450 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 56450 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#56450: 29.0.50; erc-match commands should store regular
 expressions
Date: Fri, 15 Jul 2022 06:38:42 -0700

[Message part 1 (text/plain, inline)]

"J.P." <jp <at> neverwas.me> writes:

> Something else not included that perhaps should be is a clearer
> indication that items added interactively can match any substring in a
> candidate without regard for boundaries. It may also be worth
> contrasting this with what's ultimately highlighted. For example, if you
> "M-x erc-add-pal RET bo RET", then "<bob>" (minus the brackets) will be
> highlighted. Compare this to keywords, where only the matched portion
> appears in a designated face.

This is nonsense (apologies). ERC already includes this information in
the doc strings for `erc-current-nick-highlight-type' and friends.

> Documentation aside, it might also be nice to retain a means of
> interactively adding a regexp verbatim (IOW, the old behavior minus the
> unhelpful completion list). Perhaps this can be done via universal
> argument.

I've added an option offering to quote new items, do nothing, or ask
when applicable. By default, it's set to the latter to accommodate
infrequent users (those likeliest to have been bitten by the old
behavior). This may be received negatively by some, but there's already
precedent in `erc-cmd-IGNORE', which has no accompanying opt-out.

Also, when the choice is quote or verbatim, the opposite boolean is made
available via universal argument. For example, if you're a fan of the
status quo because you like manually composing regexps on the fly (and
don't mind slightly misleading completion offerings), you may take
comfort in knowing that ERC will happily quote them for you when
supplied with a prefix argument, should the unlikely need ever arise.

> BTW, the individual who originally brought this to our attention on
> Libera also mused about a command for jumping between keywords, so I've
> included something sketchy to that effect. However, it suffers from an
> intermittent issue that I can't yet reproduce reliably: basically, when
> first invoked, it sometimes makes Emacs unresponsive for a few seconds.
> If I can't manage to tame it, I'll just drop it from this patch set.

Despite my weird issue having magically subsided after syncing and
rebuilding, I have, for now, decided to drop the proposed command,
mainly because I've been reminded of a discussion [1] from a few months
back regarding a proposal for a mini framework for jumping between
elements of any type. I'd rather save this functionality for something
like that, provided such a thing ever materializes. Thanks.

[1] https://lists.gnu.org/archive/html/emacs-erc/2022-02/msg00010.html

[0000-v1-v2.diff (text/x-patch, attachment)]

[0001-Offer-to-regexp-quote-new-items-in-erc-match-command.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.