GNU bug report logs - #56536
[PATCH]: gnu: newt: Fix cross-compilationn

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56536 in the body.
You can then email your comments to 56536 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH]: gnu: newt: Fix cross-compilationn
Date: Wed, 13 Jul 2022 12:08:35 +0000

[Message part 1 (text/plain, inline)]

Updates the newt package to use G-Expressions and
adds support for cross-compilation in the process
by adding python3.9-config and python-config to
$PATH.

To test:

./pre-inst-env guix build newt \
                          --target=aarch64-linux-gnu

—
Jean-Pierre De Jesus DIAZ

[0001-gnu-newt-Fix-cross-compilation.patch (text/x-patch, attachment)]

Message #8 received at 56536 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
Cc: 56536 <at> debbugs.gnu.org
Subject: Re: bug#56536: [PATCH]: gnu: newt: Fix cross-compilationn
Date: Sat, 06 Aug 2022 18:40:54 +0200

Hello,

> +           (add-before 'build 'add-python-config-to-path
> +             (lambda* (#:key target #:allow-other-keys)
> +               ;; When cross-compiling python-config is not present in $PATH.
> +               ;;
> +               ;; It is a shell script without dependencies on target binaries
> +               ;; so it can be run on the host to allow cross-compilation.

Why not moving python to the native-inputs instead?

Thanks,

Mathieu

Message #11 received at 56536 <at> debbugs.gnu.org (full text, mbox):

From: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 56536 <at> debbugs.gnu.org
Subject: [PATCH]: gnu: newt: Fix cross-compilationn
Date: Sat, 06 Aug 2022 16:54:14 +0000

Hello,

> Why not moving python to the native-inputs instead?

Because `python-config' output differs for the host and the target I
believe.

Thanks,

—
Jean-Pierre De Jesus DIAZ


------- Original Message -------
On Saturday, August 6th, 2022 at 18:40, Mathieu Othacehe <othacehe <at> gnu.org> wrote:


> Hello,
>
> > + (add-before 'build 'add-python-config-to-path
> > + (lambda* (#:key target #:allow-other-keys)
> > + ;; When cross-compiling python-config is not present in $PATH.
> > + ;;
> > + ;; It is a shell script without dependencies on target binaries
> > + ;; so it can be run on the host to allow cross-compilation.
>
>

>
> Thanks,
>
> Mathieu

Message #14 received at 56536 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
Cc: 56536 <at> debbugs.gnu.org
Subject: Re: [PATCH]: gnu: newt: Fix cross-compilationn
Date: Sat, 06 Aug 2022 19:34:22 +0200

Hey,

> Because `python-config' output differs for the host and the target I
> believe.

Right, however moving python to native-inputs I have:

--8<---------------cut here---------------start------------->8---
mathieu <at> meije ~/guix [env]$ file /gnu/store/ib2xkrh9i2ff2b5zj1llf2x58zrm4zn6-newt-0.52.21-python/lib/python3.9/site-packages/_snack.so
/gnu/store/ib2xkrh9i2ff2b5zj1llf2x58zrm4zn6-newt-0.52.21-python/lib/python3.9/site-packages/_snack.so: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, stripped
--8<---------------cut here---------------end--------------->8---

which seems fine. An issue could be that the headers it uses at compile
time are from the native Python so maybe we'd better take the one from
the target python.

All in all, I'll go with your original patch I guess.

Thanks,

Mathieu

Message #19 received at 56536-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
Cc: 56536-done <at> debbugs.gnu.org
Subject: Re: bug#56536: [PATCH]: gnu: newt: Fix cross-compilationn
Date: Sun, 07 Aug 2022 11:41:48 +0200

Pushed as c0e713f6e2232593739181c89a886b9fd7be3a6c.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.