Received: (at 56561) by debbugs.gnu.org; 17 Jul 2022 05:43:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 17 01:43:30 2022 Received: from localhost ([127.0.0.1]:46519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCx3y-0003Wc-1C for submit <at> debbugs.gnu.org; Sun, 17 Jul 2022 01:43:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCx3t-0003WJ-A7 for 56561 <at> debbugs.gnu.org; Sun, 17 Jul 2022 01:43:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCx3n-0007y3-U3; Sun, 17 Jul 2022 01:43:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xD/+Ckg1ZFRdjmZG22Do2caV9gxCAhC7tv6VgwDEEGg=; b=LJXVKFT3PXNK hsNSmqfoONiuzsDWd0FsMmUESzwcWgoAv0scRa6f9CbLUKT1a5DE9kUUx7tQ8KGTWHK9NZuqhRXUc OmiPOloOPvDX4c9CEemrnOLBwYzylV8u3NR50sDB9q0K4ww6EFy0GvASGSR4No5yhrmkal6uw4S3v 1pR05ekGiN/qKXZGO3z+leuh+LkDngzmIHQYmJ60TqTXjQ30abMcD93EdUzLKw2l5I8Ye3IkiKYHF s3XiItNFlUD4ez8tKNT1ymh5YRhXYOhTg65Oc4FsDRrqqIYoZhQZ4x1CJa9BX28AKjOIN6HT80yTY qGRQ0jbci6eHf3iLgZ98uw==; Received: from [87.69.77.57] (port=1779 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCx3m-0007Zw-SH; Sun, 17 Jul 2022 01:43:19 -0400 Date: Sun, 17 Jul 2022 08:43:03 +0300 Message-Id: <83edykqopk.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <8735f0in23.fsf@HIDDEN> (message from Po Lu on Sun, 17 Jul 2022 08:45:56 +0800) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> <83tu7hqvq1.fsf@HIDDEN> <877d4djqhi.fsf@HIDDEN> <83pmi5qq8c.fsf@HIDDEN> <87lestiadt.fsf@HIDDEN> <83o7xpqo1u.fsf@HIDDEN> <87fsj1i6by.fsf@HIDDEN> <83mtd9qlkx.fsf@HIDDEN> <8735f0in23.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Po Lu <luangruo@HIDDEN> > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Sun, 17 Jul 2022 08:45:56 +0800 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> Yes. The question was how to tell apart the situation where the rows > >> don't extend to ZV because of that bug, and when they don't extend to ZV > >> legitimately (since the tooltip is too small.) > > > > By "legitimately", you mean because of the restrictions in > > x-max-tooltip-size? I guess we should compare the values of > > x-max-tooltip-size with their default values. > > Indeed. But the default is 80 by 40, so a restriction is still placed. > So unfortunately that doesn't seem very helpful. I don't see the problem. If the default causes only partial display (which would really need a HUGE tooltip), then whoever does that without adjusting x-max-tooltip-size has only him/herself to blame, and I see no problem. We were talking about the conditions for an assertion. Assertions are for developers, they are compiled to nothing in a production build, so such bad code in a production build will show a partial text. While in a development build, we will in such a case see an assertion, which will tell us some code needs to be fixed. Where's the problem?
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 17 Jul 2022 00:46:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 20:46:15 2022 Received: from localhost ([127.0.0.1]:46377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCsQI-0004JO-W3 for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 20:46:15 -0400 Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]:41662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCsQG-0004J7-Uj for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 20:46:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658018765; bh=JjMI056181Ls9pln3t1vLmBfU/14vNlPrrSv1A8kD0E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=hlvUKGTy6YSMLRxMXlnrlSFo2dczGIII0puulBA9a819BF/6mSSzELZbJ2vLrKolZ7yHfuSnf5+QOVoupREYoe+FuUtP76B4J2qjpCQTS+SGTjoYjgIT89V6aI7rhlG5FDHjA1SWCDQrMIR0eLGc8oBci1AEr5W3Xv6sVQTKp/Z35znxCy/LfvNV67yq6VUXp49EGNNd7ixGT+bADgfo+cF3TvZdyb5eLkLt+1E4oN8wIINsxLFENILl6Khw5zSQnPdHU7/9hXVZGqDI8ZVawAj5CjDepd3OCOSMopPHq1w5BIxQyMCYk7ttWzed7IhJfIOjo1YiCKUP4PVl33qP9Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658018765; bh=aW/0lyMZbFzjpuocyJysBIvOxP7yUXbOiFW3SIPmDNn=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=dnKK6m4vpYpSKVmBgcWVHmD//1JQ+t8tNOlaDsKgOeUaY+QiWXVhW/C8MxJYLK4mulwTHD5Zdci5zYCdeCi29KsKW3/XH4j0QJixAnaN/YGSsJG5zTN18zGIMho5eBi6/TPdj4DrsV09E6X7F6oQ9UYaFQOpoTttTphpRodP5dbBYlvcegAc1mGzd2K7drWs3boEvjg2oOxYE/D+V1rguSMDjqTUqxxHfdvqIfGsBK7az6YUs5osBJ8DkqYL0QjEyw+MY2YvwhiYFlllaiNZup9Lc3wLzkQoQLIjUV2oqk5IxhQdlqvqCgk90DvL97Dgx0N1WJs+/bIjQJoqpwyzzQ== X-YMail-OSG: i8d5s.8VM1mjBl5H3NqRxtVMgcs_bM8uemXhjBsZw6LueQ9Tv2O700knGpTj8yt EOyxO7NGAzJ7txaEyVkAdy_YvkEdqcrjAmnqpGdWFdo5iv5ugFIHzd7JH85W1KPuRvRDY3L57d72 o6m044FsQqJqJ1ucq3IzdcTdgOM2gxp8VbZCGNgcBwo.rWNniDIbJlgXT1IYQipfMuWnQmniv9Bj 1ss1wJ_zT5mqIvIqNYgqOBB3F59Vqm4HNWVKaxzP73YtDgp_L2DLAmLNpguQM0LAx7pJz1sNooRS CNR6l2GATdi2ZALBo48j.wlfaXnfgPfirYELrnxVIL2D4LmIGfF8UZ1ZYPh4AmTgGjZc3Wcnh1PL sxc57yaH3LfZNx95UqutuLF72GfbIWfgNQ56qFXqr9EXOdBpv0AywIuFkfe7qYQSAIroQAiEJUnk Lt5MnjZw6podmfhjmvqlfBi78.yaO9.s9SZUub9moPxiDvq3432D2WPif1uEGiXfVclv1LEYY4Do 1J7F8qZpMWGAesZetqTFi7kXjQXiD7KG6nf6dCHza.sCbk.xIe9.d5bEPgnjIgCJrKlifzlFr0_P JynSGy4CKnGy_7ui4KlB854MxjmgHoBj19hM_CzPnFufOCQJPoebjoZ3WONoe_lTN.cYVygHg57p _ykKstSaOE86xEd9Pmx50WSB5cGNPcKCd0XVT2NvdnrDRW9QlNn8KP2ygpjaYkeF2e2wzo3aaVzD dn03OcYgPeIte27RIeTQWa7WzvtpDAfYabpiOTBkNJXdk3N3mUA0VOYBsvKAAlVHzBc24fnt.inl Yf3azV3S7KqFA_fS9RJmAjaptoCXMAAJtssQSTDj.Zr2u99e.yRfcwA.OsoabArc_zHO5uC4Mufh B1U8JIOcM2h1gBeMux3JSna0fYhVFgQIF.qRPg6XUaNt4wPytwTjIM0azOWpoB2JjwfReratHG1K FyvUaK0.ZKF_Tg5qh2Os7YvPA6pPdnaHY7eDEuKvfb4CiRx00U8VJSviYTRKTTljaP4e_X6m6rHA rUZmWZCd0WCRx395J6jA3jaEFoHd2aqQKhmjZ2wDIuKqqf5SMK5UTW0zfZuABfR.w.xw1x217yPd Mith2u95zpAQPGILjoeHk4IXhq0I_OIIROFzYG4h9VsKzEvX1wTBOu7i71qkcN4rYlrWHVZaqA_c VXZ8hFyA0yz0ouy7pVfo4D5O9H1Oxhb.CODIp0VYaSla4kHMMVCN4DJ10.73StiGKAmMg7CpCkgn s2VDhY4WUuM0Em2pEQLUZKzJ3Kdb3cRMvFo6hKRNZMOgwD3eEBe7o8qnxsUvjGIBm1pROqb6Bh8z CrAX6SJv2BJlWWg2eNNEE.8UaVXsWG._H3ZGeaZsELZspL_XPAKPC0qMnnJvZx_r0.QwYhfBr2IS 5_1KndzsZoyu9EQw.j4qJoZqtELf1ZqrBov8z4EC9L6bWIbzPhjl8ESHH_IcsPWUOaGC935vRCs4 EM5ulYym42w5nkZIN7bjUfIB0X9TNZZU3SP8HDth_WXxKL5XR50DPmFf0w59hdGz79n2cH9b.Kfw wBOQYatP.uG2ZvVDoSu48z9q1Vgoxi9mc8JE_ubjv8Cdy5a0k6JJhWZ4MmFTqXqPvSaqbN_R.oJv Up6JqsF_BptbezZUCEJOBPiBL2ZcXL8mt.3JAs9Pbe1pCfyG9LxpKjYNNgWsM3Hw5D9ep2fyTO_H 3mqFgxyc7eeR5MH1mbme9G9PvVjOeenvXi9OIKCJ15yvlGZm47Nq8LVkFU6WU6w4rvAXEYp3OrOy 6x8Ht.12h.OF0lMHPVQ3llKmuD.dEg.ZoBEr8lxzMo5Yd_RRswto0cMqftbjNvrII.D77fSZe9EY LCf0yoDZg3RUXLfk_NSx7XD8nCL7mgRWqKhcKJ22kaMemeHMPDLWs5an8nfmk6WVxHaHFPfXtr1m sSHiHY5GMFwuwIOqoYKlZ2NDSUrbSqOD6XofgTBI6ealy4m4iSfa_bsfP9fU9EQmo9BaQBtv6Fwf dRNZfhf29Ox.VRZROVAEKWaYCof4NwrwK8fz9Ny.lIAvi3R4.imFCHXpB.v1kJU_rkjMVrIWUsZ2 0bgFXHgwNYsFYklA7QbiBzxVPCYmAATURiFj68FqBEPFaRrdzF66TqH21OPUi82JMi5MRVjTbb9Q siuJhpSLNJutxXb7DPsH0HCRWp0ftd.N69s9TLtODQyTt9e4ESFOyQkYznpeabi7s67.IONe9zH4 a9_baUBEh4zjmGnyCYM2v45vTJBW5yAE7_3.4WdLz9WnptKApJ0M_4Nxxfb5Yk05imQ-- X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Sun, 17 Jul 2022 00:46:05 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-5klrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cc926fbcfcbc37c1da47160e741215a0; Sun, 17 Jul 2022 00:46:02 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> <83tu7hqvq1.fsf@HIDDEN> <877d4djqhi.fsf@HIDDEN> <83pmi5qq8c.fsf@HIDDEN> <87lestiadt.fsf@HIDDEN> <83o7xpqo1u.fsf@HIDDEN> <87fsj1i6by.fsf@HIDDEN> <83mtd9qlkx.fsf@HIDDEN> Date: Sun, 17 Jul 2022 08:45:56 +0800 In-Reply-To: <83mtd9qlkx.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 16 Jul 2022 15:38:22 +0300") Message-ID: <8735f0in23.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 533 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> Yes. The question was how to tell apart the situation where the rows >> don't extend to ZV because of that bug, and when they don't extend to ZV >> legitimately (since the tooltip is too small.) > > By "legitimately", you mean because of the restrictions in > x-max-tooltip-size? I guess we should compare the values of > x-max-tooltip-size with their default values. Indeed. But the default is 80 by 40, so a restriction is still placed. So unfortunately that doesn't seem very helpful.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 12:38:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 08:38:39 2022 Received: from localhost ([127.0.0.1]:43219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCh4B-0003jr-Ja for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 08:38:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCh49-0003jf-Kv for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 08:38:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCh44-0000zx-D0; Sat, 16 Jul 2022 08:38:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=g41CsCyccguep53oUp6Xlk4E8sngFrO/WoAnH53FQ0w=; b=hqliQhOdgVHs g8uICxJm2EGS0CdNVsB8ORr6MbH3evSc6wB4yPAsv3xONp/PVQPCc5YYeZ3m60I/pHcK5kGlfAlXh clssoPl1hjRQMvo0zofWhFZ13AH34WoZx3/+JQz/3uGM8XuEIlmUpuOyImETKVUCVo2IsdrjGU+YF jcOxR3m9VxtK0vUBOlFYpFfoZTgRNndP17JGPexSoN0nudw3p3ckYCB7H9pNkd3A3whl1Z+I7Ya38 UrBS7J7220D6f+II/cqkPwi8CYSGDNgA3AftHxN4FIJj1Yh8kxKhbQ1dVS0Rv54JMf+9+TBnZZpMT QG5iQIRXtozNPLdSIZLPKQ==; Received: from [87.69.77.57] (port=2571 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCh43-0002ns-T8; Sat, 16 Jul 2022 08:38:32 -0400 Date: Sat, 16 Jul 2022 15:38:22 +0300 Message-Id: <83mtd9qlkx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <87fsj1i6by.fsf@HIDDEN> (message from Po Lu on Sat, 16 Jul 2022 20:34:57 +0800) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> <83tu7hqvq1.fsf@HIDDEN> <877d4djqhi.fsf@HIDDEN> <83pmi5qq8c.fsf@HIDDEN> <87lestiadt.fsf@HIDDEN> <83o7xpqo1u.fsf@HIDDEN> <87fsj1i6by.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Po Lu <luangruo@HIDDEN> > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Sat, 16 Jul 2022 20:34:57 +0800 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> The problem is how to detect that the glyph matrix is indeed too small > >> to fit all of the tooltip text, and not too small due to the bug being > >> triggered? > > > Which bug? the one which started this discussion? that's the idea of > > looking at ends_at_zv_p flag of the rows in the matrix, after > > try_window returns. > > Yes. The question was how to tell apart the situation where the rows > don't extend to ZV because of that bug, and when they don't extend to ZV > legitimately (since the tooltip is too small.) By "legitimately", you mean because of the restrictions in x-max-tooltip-size? I guess we should compare the values of x-max-tooltip-size with their default values.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 12:35:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 08:35:15 2022 Received: from localhost ([127.0.0.1]:43214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCh0t-0003fC-2M for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 08:35:15 -0400 Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:41886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCh0q-0003er-QD for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 08:35:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657974906; bh=OgqAIHNhuRPu439NqCo16fnexFpI1m7wSTG2LoDmuLA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=aiPPp1GEMWUOpw0XHa0gxhLKn10ztmCTW+c27SplWVd5yTJA11MkVBXGigmIPF2OJLtx20LeDn76vaD63L4AuqsjoFbE7tSVJ8iAvf7t3/KsjhAUs4m4cxT7WKt954aXOvnSKf/VCk4Awu7zZpKrFrvLabpwsOqVSafNAaXhken2TvZZwWWgNwtNDRHSreg8gQb6P4LpojcNjvRuQY5zXX2KOzKGcYnHnl37BLZJvSzISOsc0/OfKwq9QK3ZNlLoDmfyhTHNzE1cxzjm8QvQHGEx5AbAbXJY952+EfleiBWlMKVfidMQlH7+uLfnrbFfdxN12ibF/tk/STjn+swZaQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657974906; bh=B3XnjLWMvQIh3Hr3nk2ATaNBkoUompOnTrnB6yxSxZ7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=lfNqJDJe6bTgdEX7ZLEyAQX7EiJRj8qeDy+LtHWlY/e7Bj0lGmTjnPOmBL+ThZtVK7isgK6mp4M5v1M8wj3KMEhsN9E27L1MXSrtjR/c+et81qYsctXCfuSMD+d/uR6pl7ELHIdxVU8XndNyjKNFCw3B/QRttygEZ7H2mY8B+iiHJUczU0kilpXFS8Zf5U+rqsdw0o0NS3BLlBId8gptNZn+2h7und9q2i4p3BrrOeEO+ktbcE21tDuuym5CTyP0AmyhxYEMxJl3ofp+mmpCU/lnFMcGwbpI+LV9Ahs4qCEz2ofc+s/KWeOcrfdDxODAlrLnwpAYgoNNHFiSgp/www== X-YMail-OSG: K3SCoT4VM1n7p1JkycgtsdZWAT4y_L9iOYWyGgZsni3Ubb4kMMFLN3okA3XLfGe sghUScQ1j0Um2m6f1W2wrxExkXtX5zq.jQ.kgPKfFvkVpKV5kNeh8Cfszb5knvVRhmhqqSoRoJTN GBJqi91LArmzgqzJR15AinSSMFqapy7yOwQZD9INDw6OHPvMaQr84utNslZ13k8M_J4h_eRbqVLE p0NKWRD8mUU_iglekguFJXsj2WXBeIyXrL3MkMow5nwy4O3otLY7VJVJ.NFZe1lOofyH4NO5nLeL X..84lIJT_u7SG87BF6Jq8sFjQ2I4LAqaEXFZu6hFJoo1xB9boKRZvPSuL.sBF9YKgVE2N_KYBoJ iiCBqqE1cSBCXS4iAaTzqmQCU0kEJC9CBIco2v6h_EH8g2gnav5lZLY8oq8GDkZI0jcs6V6m3kUv utrV0g.aI10fBqLOV_hTZ4YVydt9c6wwbtAMZMirMG24nTYqF8h3Wd25PZrlq9F3AFJ_aIEnbwzD QRD1Q3s7ryeb3PEd2PFEdzVDBfBO3hEh2xiJQvfgmUW17CJ5FBVWnA1YNAXIZWd3zxWwe.VJDX5_ B8ddidn0wx9keUQ0zD_O8.rQjpgggXg1TRTOlGvMwluDnp3htVzrYNAnhkKg6BlgRr3BRvEawhJ8 LD1ui.yOVaiQ_vzUGraLlwVZwRHK5rvufLVXL6HFALPBUfc0GFxEvrw87PytOxzYx2ve5IQenJ_Q run2iP8BYFmw4roVBLPoIojT2xcwi.ft3had5.wwJuhESAflwj5MfQ6iyCd33EJJE.WMLnaKSYBU 0bHe8j5UICCAQ9UE1KcxItnfCkom1lpymTQUp5UAWY4Y95_bW0yINNLUtNo3C37PSrc5QYm.StX_ 05eBwuVzxeW88cWI8I4lv6lttuZLd_nhAeebUZOVCuZehvPQcO6KGIxfMqAL46NT0gXY8lLZCf4F eLMoGdVaho3oBW.BrkB5..m_EdjWb46PfiFvGbbNa578F3JIUUyeOziZNP9IX9Z0SHdSk056Bmur p2L6.2JI2VLTHNdEmvkMSIxKfFamkfGAduJiHnAroZmHfvqXSuZeXz5uPEtes_frXvQvpw_A7Qsr lBWdbjgmfqbrMdXetD9B_MoXgsl0l.xZnLnD_W9EMCq2NYdA7Dq.qvPhPCHqBcB25ADCBSO8kpGB wkxPednm20tUJDWqWngbc3hrBq_gf9uIW37q6eBCvweSnIEATG7YG3mOLwDMmXAsju6JD.LtVMfD pds0x99su2BY7_DcyI6S.w1TvcicQ.qKmygdvGj9CaFMhHbsMBDM6X7l.FqdD4_Bks3so.uNXpCM kG1nm3dBWxub.xr2Jt1iR6dNNguBkPqWu8wSybf9N44.nJGcWRHFlAwru1n8db3s46Jz6..fF6ht l6Vt.tvDp2B5taaYooB9X74BeE50Ybg8GeqvjBdLUZyqgY5_9uUdWzsenuRTTf8NNo0GVYm4Y1Ei 4QkZSZaYIlKOA9nNMMoWtHOEWw9Z7S252EebNUfVwfdBWYeFt5hpwjGxspYGgwdIezO478slV1Ns ON2h68QVW3VDoQqVo6jVX1P9amaYgEoYOQqmJLondgVJRpqji2pG0S3VphNNlRveHF4jJP25Csf5 l8vYGkZcbWXpnWTddO3VxjXTVAO7O9.6RkeKxalJ8GSqItZatx9WsMlQyJQROJAClBMY2XH6Pssa 7rh6tYv5LnhrfDI5W3CEg.jpZ1xfOi9vRGB9nqL1b_uuzGRbr64P.9fhJ2MRjn7ICQ3Y3.8sCSkA bWakEVFCR6bA22m4onhsirmMqet2HIJCp9u5oloj.9A084j28xl9MubO9yMpdDl_eEdpwWsiT0wl FlTH_fQgGLU2EILpuxjUfuXl16iMFCPcHd_WP1_PyR9dcJd0mNekOaj4CxcbXzAi5XG0130IcdlL q0sU5DCKBTrBzVWM.Z1LDXdxbjWdilk_A_IkSvKPGXQu8nlavb8.nLFy6zJprZ4zCrNAAI8LrUk_ R4O33geQ_BnoFsrZRao.MdSd3Z05K7AiUHkAI.3UzFQzJ5F9a6vj05y38ZtHvzfgcTLMs7P6SheG hesMI332GE7pKK7L6JnA9GO00cWM7CwmZg_vnsBdY1jtccEqruPoI5qIcZClWMkM1FEQGsqRpibC 3s14orRxN3P6i1f.7Zac6re2tx1TxdLBGjyRIKJ57qkz3ojQNfeQ3.CK5RSnSFT8zWzQeSkR5hDH 9fG2XIoXZm1p1GFM1JIeAUoFyGJ9luig8f3M5TI2KtcjXJGw8YU5u9niqh.jXoPAoDHg- X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 12:35:06 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-v4p6m (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f54e8c4a344e2084afdb071b305faeee; Sat, 16 Jul 2022 12:35:03 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> <83tu7hqvq1.fsf@HIDDEN> <877d4djqhi.fsf@HIDDEN> <83pmi5qq8c.fsf@HIDDEN> <87lestiadt.fsf@HIDDEN> <83o7xpqo1u.fsf@HIDDEN> Date: Sat, 16 Jul 2022 20:34:57 +0800 In-Reply-To: <83o7xpqo1u.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 16 Jul 2022 14:45:01 +0300") Message-ID: <87fsj1i6by.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 549 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> The problem is how to detect that the glyph matrix is indeed too small >> to fit all of the tooltip text, and not too small due to the bug being >> triggered? > Which bug? the one which started this discussion? that's the idea of > looking at ends_at_zv_p flag of the rows in the matrix, after > try_window returns. Yes. The question was how to tell apart the situation where the rows don't extend to ZV because of that bug, and when they don't extend to ZV legitimately (since the tooltip is too small.)
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 11:45:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 07:45:22 2022 Received: from localhost ([127.0.0.1]:43088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCgEc-0006Ow-Cg for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 07:45:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCgEW-0006Oc-BH for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 07:45:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCgEQ-0000Ix-Re; Sat, 16 Jul 2022 07:45:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3PIj2T5XrBG9gxoreJvYmaSyIYp3zmCJDeccxlaf0gU=; b=Jz2KdTved+U9 9QmgssyaqD8jU68ul2u0dap2DwwV6tc91UCPvpFBqSbRDun8ixxrfvOVeh/YmtVzS3u0PItqwpxEQ 7PmfrCGqrg8aRciQk6L8lgx0XwENy9/Go7kE558sC2P8yMunz/X5jTK1moGQ7+qdeu0tWdcs7NI3w QQ9Nl270Ma4pskrML5qpkCq/t8tgXqjQTk+KtTBqh5rWZCtZjvxkYKQ55L59q/UkLfNDJ+G+7UFpA 02rV1K6k9+DEYkuhxHO46+jjb6cO6fdh8IkhgC3DbmEE+s8qqTIHme7tyKqEsfegVOz7Gb/u//asb Jl2A1jTYwJ2o9ku7hkm1iQ==; Received: from [87.69.77.57] (port=3254 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCgEQ-0003e4-As; Sat, 16 Jul 2022 07:45:10 -0400 Date: Sat, 16 Jul 2022 14:45:01 +0300 Message-Id: <83o7xpqo1u.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <87lestiadt.fsf@HIDDEN> (message from Po Lu on Sat, 16 Jul 2022 19:07:26 +0800) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> <83tu7hqvq1.fsf@HIDDEN> <877d4djqhi.fsf@HIDDEN> <83pmi5qq8c.fsf@HIDDEN> <87lestiadt.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Po Lu <luangruo@HIDDEN> > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Sat, 16 Jul 2022 19:07:26 +0800 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > That is true. Which part of detecting the above situation sounds > > problematic to you? I'm asking because I'm uncertain what should I > > explain in this regard. > > The problem is how to detect that the glyph matrix is indeed too small > to fit all of the tooltip text, and not too small due to the bug being > triggered? Which bug? the one which started this discussion? that's the idea of looking at ends_at_zv_p flag of the rows in the matrix, after try_window returns.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 11:07:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 07:07:45 2022 Received: from localhost ([127.0.0.1]:43069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCfeD-0003Ko-7d for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 07:07:45 -0400 Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]:33951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCfeA-0003Kb-LI for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 07:07:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657969657; bh=m6TbMgdAda0FTWAEfU4PAPv0n2bDY6LlzZO7THDXtH4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=bxkUtYkmz83ImCAy54vFgoJ7PuoGa/Qy4RyptMGOCjklNpYt7hnl0/FUST/a7FugRM5lW10L3MIlUMmEqG0v95U6OEJzN4eZH5eMLu/Ja8Qq9b2UhT9peeQ5MLP/HjFfCdIJZaFIem5Mj6MiOrlAMcS5jWnugLoFhL2PghonMz9ePsQDbpqT17r0q9FWZHpChDz/M9ZA3me5nz3ReL64JkV7tumbYIWIt3QARBVkRsEuy9tP2VlijTeJbF9m6NTFqAf56dmAewSEutshcbViMT+h7H9eDcyiWKZICbU9L51/tnXGWspwqph66g/YjiF5DfpNNvmQJnptd8ezNAQ2+g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657969657; bh=4a/uRgmexwCILkMAUI0O8ox9dN6bBnG7hJW+wfEry75=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Z5C3VKeIY5TwlmSBx/Jitj8+4C+O7yQ5YvfNGic4cuLY2Gg+b9nIRJAYHWqZZQpDaO+aDSIYg9EblbbCyzQ85BJPEHj3NHghqasfADVq0gUC8WC8kyRUJmkr+Rb4ha2VxbEwqQ9KULMw2rVkkZY1sEuEKLKI+APdsWqvZ5ElTfmtnoFxZejUKYz+FcQVUscdnmoqw+az0iw0SyT+jgTbYubV08T/lXpnifcGA6cThxW1mQNqCU5avtqarVxQLKN50pIzOEc33IJXs3yz+5n3GqqwB0uLO7rWhDuU0G7JGxWGw9Of4ecxx9kH5kgNHG8E3GKgpDFa9f6jlyT75enlFg== X-YMail-OSG: sfGunqUVM1kdwXk4_UCPbAiiW.muw6VqNpxIIqJJcKrZ1Gh1h5fKW8YsZgGuGPm .iPe1.n3PqSC5kFnW_MAwzFpY5ueaINMQlxq8bSzBzHhEg9sQIAubvpTJyBDRnIDfKTmRWu7KqkQ Kk0ntXmjYp5omkOJ3U18U6roGLVRDaio2rKAALam2c0_qTzhKVGiox96WPbrnKjAm_gMZ00K4HaE 8rB7liAY7ehYrGMNJH9JifZVYq3YFdFMOTgLIhat6HpUD0ph93Mbwv2LtUqwJZHLju0NRj3nit_P VvvNOtHSdBRjaBf2lX9mVrVwJqAPYpN4rM8NUPcv.RHAUetInN81erE3omBbriOYSQiUP9T20uCl ePm4zRjEfKP5SGue5vO1CC.u85UYS7Aj8jBWaiGhkxvybbad3PGGv08YaRx_8c.CbTjcf92WKFEX eZRN.M6in3jJ_vzdg3MybEesTnpFJE8gPNEXkP2vBAEE_N124in3UzGCNgitS2duIHSEt8qHWSrh J2ppdhseNIlWZ5zx5P1uQ4LFDf6VcoG7E2pbFETlm71DoaIWkjjGxi5_l..EvakYmVEU3ljFS07w Y2ChT7zE6eRY1rH1_qgq7pyvKey.RK.YTwOCbO2JewGOUn.SFVFwlzYETM_2FCAjRcGZtd7Hrsxe F9wlvMsTLvsLDymP2oQVk39InHG0CzovBAUO.5liRtuxpBedGWhgbI6CV2y53TzaeI61lwdVQ38y 0iZnpA4dpq6bMWn_a35aZCAdz4g1SRjyOCpKiz.F_ZMDkoVE2LWB1btk9VFSzm7mcgj6G2DUVmVE k7n6vsovGWx2DxlwdoDaKeVISeJEA_lqbP64qgTGwV3ecrF9qKlgMcRjLyxJXrgkpI9pVC9fQ5eM nZ0A8Eas9_.dzxmxM_bVptaNTgNks4f3IbSHoiV2ysx21h.ajqw3jf7p0v8SKWQmR8w80nse5tQ9 FfHboD6pO.QPThfhEHcse6YmrDyDbj1q.8BkakKKgyqtHBbfDmEL3AbZt7UCoyqIQnoN6.wms9F. DRn.5swQKP35kh3tkXz8TCDW6YLNz9Rzwarn3X4b5rIEbr0AN5prMkNqvvEV.0E2yfUYt_NAIRKy oYWuWAEbmw05pRi2Ou9lTzEBb8bM0UBCU_pgzeMDSJkHc9DWRQu_NYI7v8XZ7YUyChGcZEDCLNdm xMlXp90UU3cNC5I5d74DgRpqdAclB8TUzY6TiunYPWK6ski32cIMn8CUKlXxEpkKeJ1JjEkZPCmE HMzTx4G2Dina8_95JxITlmwPFK13KrJwlFs.sxuzpcYIXdkdO5uRqGVHM6QW7mAAUh0Jhi_7ewYt .utgK2QNYuNAF4BcMmFGb1QR5xlvKGcPAv6RQMH0Qu21sUOSrpy6Ay3BaGraP5I4s8RCJ0_Oc5JM 3OGcKO5DYBMXh9GFGM6vDCvkiBlWjZ8oCgExb2lAJLUGfrvHslgaXondyQ458kQ0Iw.5FaRpNS5t sfkR866SnKsJxAwgLGyO7yoIqBCXpfy09JrXuGe90ncyTssxdoVf.qbSLbNnPkihyLF19vIvYpix WiJ6IJqnTlWub3j1oLTGAfVAq0E3h_u8ZJHZjCCWjTbQUWrJfmOmyVkF2uBOgKWRSfeUod9qf2Nh kMBmOunbET44KCIBSMvxIVQQ6k0Fn37D_o_PUM7YIbc_w5RnBqeC7BKoZRIBEGUDRICHSFO5LD3I 2g_D2FucITkuS8chkNs58kvrSt8wYnzygrVhpGI7edHxpJYNQ6iBbcdAYqAKqLRmLbkTK94Roxdr 6y4YXKF6iqSSWFB4XVn5kq1lye1EEwOHv4jvTO84fk8g.KF2ps9Gb5a2bb_xYdjCE11tgtkm9358 J6qsjK_LFVkluVbvrBpP7UC.cTH_kCXmqHGUtLIXsSicAjYlKcXjcOex11yNSSAyhYGof1RM.y.G NC_.KSPpx7Ni6uQg1T.9AxccZgI_6NzO4ugtY8Jhyqzt28.K1R1DCeHhkCPHGYuao3r.Uj06wuYX 4eUpQpd1HI2nlgWGEID9ePy.nDG7513i.1AHQHHfgiSM1AD73tvgM6.omhhaaR4NgvZgg.mydT7d ya5wajDS9xH2jYGzkPuVXVGQNJcG7h09yaUErfZZzLkgU8JfoOxzHv5ahe..Kqrf7NbNAENRRX.e U0zFSPvHd1nF4s36vg9x9PHqpdPnY8bU9ahl4Rs4vamXwP7fyQh2XX6tj5fmqqeYE_bm3sc3NN.P qPv00LHH9kc3jWW_ZlsZ1KU94oHxyVdh1aGNcHup02V6SY_8YekLsyQyKu_wXEIj5g2p4 X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 11:07:37 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-mtf9g (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cc030544f2093bf154136f24982c5626; Sat, 16 Jul 2022 11:07:31 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> <83tu7hqvq1.fsf@HIDDEN> <877d4djqhi.fsf@HIDDEN> <83pmi5qq8c.fsf@HIDDEN> Date: Sat, 16 Jul 2022 19:07:26 +0800 In-Reply-To: <83pmi5qq8c.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 16 Jul 2022 13:57:55 +0300") Message-ID: <87lestiadt.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 531 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > That is true. Which part of detecting the above situation sounds > problematic to you? I'm asking because I'm uncertain what should I > explain in this regard. The problem is how to detect that the glyph matrix is indeed too small to fit all of the tooltip text, and not too small due to the bug being triggered? The size calculated later on is not useful: it is returned in pixels, and doesn't take into account any line wrapping (or other similar operations) try_window might perform.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 10:58:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 06:58:10 2022 Received: from localhost ([127.0.0.1]:43056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCfUv-00035V-Vv for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 06:58:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCfUu-00035J-7q for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 06:58:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCfUo-0002eI-St; Sat, 16 Jul 2022 06:58:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PCsJN2IseRREDb1v7nuv8pPqlV37keCOjOrCPyplaXk=; b=ap7AUtM5Envf k9Mc9TjJkKYfbsGXO0uxsEmKEHUuzsqB8Ap1ryV59PWbEh0+Y6q0rrSthbHarGEl4a6se3+swTxml /iou+Ga0qczZcLPObkQWkvnvZ/8S4uFq5h+wwiJva5zVhfe3zWyG17znscG2ELwEWoIrha3jL83it eQct87SHz246uYLl61vwuSOVLes6FhmZvxCUrH4Fmth1e3XcEEoxwsYFhaTcFd6bHB3z3cWVt68Qd 2U1TkUCDb/eg4r0hFXtDBVXpscclu6q8YcAevVtI2gZCOLblW8ZMU3x/0Z7edaqOGBLrSl93gt15O Zw/C/6isxfQgPIwjFQA13g==; Received: from [87.69.77.57] (port=4367 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCfUo-0002p6-C2; Sat, 16 Jul 2022 06:58:02 -0400 Date: Sat, 16 Jul 2022 13:57:55 +0300 Message-Id: <83pmi5qq8c.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <877d4djqhi.fsf@HIDDEN> (message from Po Lu on Sat, 16 Jul 2022 18:34:17 +0800) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> <83tu7hqvq1.fsf@HIDDEN> <877d4djqhi.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Po Lu <luangruo@HIDDEN> > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Sat, 16 Jul 2022 18:34:17 +0800 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> The point I was making was that aborting in such a situation (when there > >> is no row where ends_at_zv_p is true) will result in false positives > >> when the tooltip is intentionally too small to display the entire text. > > > Yes, and so this situation should be detected, and we should avoid > > triggering the assertion violation in that case. > > Hmm. I might've missed where you explained that, but how would I go > about detecting that situation? > > The way I understand the code is that we set the window dimensions to > the max tooltip size, create a glyph matrix of that size, and then call > try_window. That is true. Which part of detecting the above situation sounds problematic to you? I'm asking because I'm uncertain what should I explain in this regard.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 10:34:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 06:34:38 2022 Received: from localhost ([127.0.0.1]:42995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCf8A-0000Jg-D2 for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 06:34:38 -0400 Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]:41158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCf89-0000JU-1x for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 06:34:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657967670; bh=ykh59TFp+N4RCxkwx+jkewBkQ1TqZtrzU1sNuwNO+Uw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=XIiLhEkSTCKv/YDVs48AhCbsNPv2cbM+o76hgKn2sBKnhFGOuBXPdXqZr5sJDJgd9CXpksL4sQWE0G94G/2JEtt1e8NTn7/xo/XxMFJycddL/zazLSDEYuJoybQEnJRya2pUtSYgOxYVdW11zXrYtmCINUeMXgd0rNn3oXfmAaLGeSRnJ2Xi47Ymsgpr+EXxVVxPdsg3vvOSWcE4ieys9G2To49fRmG70Pjwy1KgUmEvrTIdPm9dXVn3rFbkcapQArLRjyf9Q2buizWSsBfr3ZbRMMTqoy7u3IcTwZWez2WAKSk7uxbwpapLro0CxvuMfxABaoBQWjXlOdtQRofoFQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657967670; bh=Mc++nnGKa1k4o1dDZ42Uo5uKLFh7FUkAgkHZz2qN1w+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=bMb8tf8v7qde1I5SYVytYa9ZsHr32MM/y3/jAZMYxcvJ/xJYKJdy6oZ29ggdTKjojwJz/pEHkmGpz+kgtBnlm9+ZhuQdgaGruGVXBhKnRUoUWOQH872/mioFGyXzCTe6o8b6qpKUE4TxwsbvYSxsDAHiuF233igiBfkhOvilJnd/zj4/nJkZ5HO6AQOvEkePOCVnGbwO+Yro4D2fNVvC3hJtdKQbpdbrlqpY/ukki+SPv7TYIea12qPEhmxIlAyerI+xGrwjW0p4aS3wi6VpItM33MjzzhlndG6rWg8LbpE3H3MuiieG2uKNiAO2J2c7aJGw8prqMNEzeTLLPcd1TA== X-YMail-OSG: 41nHMsgVM1mcL27btTp2DCQNnOKcGO0f18mNyjV9xwLPODjtn840jcSk4Bz5JGO miUB25AanHTbAA1LoNydfhoBSDCdesSvcQt3Edu6FxJ6ohEXGoRDBJYESZHAvryVIX7Sok1ox9DF VaT6aG48vP3WeoWe2XxrGECtPwAJVsUD7TO1eqYWJefTtWxdlC8LPXiNPr.kDKvSxBpo92fTkxaX 7qy7wZEYG__Jlf0nnho8V71mTVQJE1csKCxDfBvvLmr_WTEB8NArmYozjoWhiju64YkCis8cUe6n stomkCKSM9v_WRNyG5eYlOaWyvWrOPY7V6j1V9UBmoNQ7xD.2CQTO6nSahU0yPKtgpUWqvqJ3L7t efJCAkywSzgZIflWhPTYyFowz217nknFeHf0LwZ4NPW.JIumhIgY5c8oiUghd8aqzbCUc3ODVc.T yEIxKsFrQUmWCfhad14x_jpnhWqJE.K00gr_U05h_IvT5q32EQKogbok_drln8QNUNQArgKxZryw oNU4AIoklVmSdopAHe7V8nK6dO.5h8yZDimUcEu74c5hHhkmxeEJ7d1VUQMP_GEDkFm5rMrnKCt5 YzJKFFO5b8YWZqQ_qPdx.vnoR1t_6fi5mFI8ZGhHrSsbtP.9rRkiEuAePLx5TaHJHNl3gefSivhF bG9vcqnCyybRJfNhCAPnsylI0vegy3xRHyh8Tuhnc0DyQn9He1dSVZokq6P.OEGHdCuZ7RakEv1v T.hCKJ7let5KrUY_HXxINoFulY.Kg0CrBTFzcGwMGrPyGfPeFXs139Fmw1bTkhCY8ZWvehoQj1Qc RgepMauPo.zMSIDkFKmhlHhmXIwwJUFf4CSr2pNLXAZVb62ZGGI9K9TR42sWhMQqu5btHahaSHBb mWfGYqlMiyuiPO6qU6abUuWTtYliq2rKlhunId1CBB7Bsqo1EtdPYeB4vSUdjZIIaJRJadSGHCGw lcXCNoeIlBtpBWAc8.1xTPHdiIaZVLpTzt5shLjCXbOfL5mpQ1b113pxKrNMrE2ucwxdQLbD4yYd EeJtBKvtfyo5weIEcokHUEa0TbygHQ0hfk9GYZpGsxH3Gk5ZnEYXnq5R_S8uRTo88XZw1Hxzpu3X pGbbR6Ej_KhtVK9.PIMd5BZY.METBpGIW_m0nw_CK_S_X5xbT0eLyDYT8unr1sZ22En.uVY_J3CZ lOpgJA7ij8r7cOAFZmu5RNRi9M8s98qPKWdgaKA6TxU4_BB3vtgfSv9aMOChhLvFkenGGZbq4ng9 TvqFhHxSZUHf6A2eaLi6sUeAOHHDb85.Ib6Bm6xHSnW2l6Syr08NVqApty2uUcrxojwgZgwuibDj JxNq_IBBI8bNe3olOj_YtDOIHrj14Hov1v27z0y4mDkiEggIR7HNwy_tZ74E5rL7raPI34titz1m 6lVbgQz94Iaug1.VYACblYh7N2FQY_S7sk.i9EiIyhxWp6REY7ub8iisKLzfz8GCSNMHlpQ__DSt 4B0jZZbeQX39JvlihS6H34gQrWX3qInRWKslrJpCwijbfcotVrZ1_.uG4_CJaGTVIJT1dv589vYF 3FXN2okf026ieGpcMQiDaQpdAJzr0oHe.S8fY1xu215tce.lbm0k4splcP7uT_9gF9YlRwpolg2N MjyMnj0Pdv5wImf.3R7jY_XYYpjFQCKjrUcd8H51lYSdK2uXDy_UVFkKZ7PQ23wboX8rLRpJqNXF IHLFbMie5qopzpAMC.kOcuGnqZdVa4J3pmZ2wjLJ6DmY8k2J68I0Zu1YtfRfg_SfaAYnVn9el1CM ofN9G9N3_cC4UPqiGoYHopgjwdeUBDmGCN7dU3wI7rHJP.pXMrm1qpbxByGkUMg_7RHj0215r7vC xQCxHM.wi.wwUEupadm9HOxsnNRt6DQk1yA0cU7UoP68ZHq_0UIcZIuklR2x04qNWJ9sKqWoXXWH n6eiaYgtwq0faClgi5Gn9WVfyy_gBzyPzWfWOGChzjC7lemmIsLClnB2io6x5yBxvL3GEH0XOMqr o8wwcmAt5p3ftSfJ4T8yr6cLYsd8CJ4GIhLD0aRlwQgv5nzhMCaaUBi0zUh_qUNWvnacssawg8Dl vxCW1r4IiVItynljOBu2YMHK8qyncNXscMXgGKzbbp4DFPscRWUK1IJCC7QUPk7hpRNGmnG3kJse 4819li5u_5NVHisny5lhX9Xkia4JIc3t7O3eE0jcWy7lIXg2.QziVX9kwYnV6_wPcsXfhbhmXvT2 CFWOJY.F3F0orktUcBKEBiY5C05VctEBVyJRKBUp8fwnGXXVBDlssO6_dQSxhobNa X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 10:34:30 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-mtf9g (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 51f9ae5e1a6db2d11f9569eb94ecec30; Sat, 16 Jul 2022 10:34:23 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> <83tu7hqvq1.fsf@HIDDEN> Date: Sat, 16 Jul 2022 18:34:17 +0800 In-Reply-To: <83tu7hqvq1.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 16 Jul 2022 11:59:18 +0300") Message-ID: <877d4djqhi.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 648 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> The point I was making was that aborting in such a situation (when there >> is no row where ends_at_zv_p is true) will result in false positives >> when the tooltip is intentionally too small to display the entire text. > Yes, and so this situation should be detected, and we should avoid > triggering the assertion violation in that case. Hmm. I might've missed where you explained that, but how would I go about detecting that situation? The way I understand the code is that we set the window dimensions to the max tooltip size, create a glyph matrix of that size, and then call try_window. Thanks.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 08:59:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 04:59:33 2022 Received: from localhost ([127.0.0.1]:42896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCde8-0003qq-NV for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 04:59:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCde7-0003qY-2p for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 04:59:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCde1-0008I8-Ky; Sat, 16 Jul 2022 04:59:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2ZCLCpgMSDbnq+OINHkXL25hI+6bmZhLmm95wGU0UAo=; b=QzrZFBRlN2Nc uj3NcLBgxuxNy56kBEFbFthtr5Go3HBMwfHzvvWiJPGhbql6PaVatqLPqge7Z1CcvyvZ/rsPtfoSM xE6Hj2AW3lbZYBO0xW8L+kWws36GLkHH4w2JDIEpyLoVNGH5R6Iu7XilELXl9IM6LlugRR35JtN5e 43Fqm1FGJ9yCgN2Bv2pRuWBAP76i/Cr51+Zs1p+/HWEvjC360OBfaac1P+VLc1xk5+nV0xjmtrgJg BORBiYXkQCHMQEeiDRpe+sPSzrxPCSJ3K0Y9RyIXKzKi/TMI2/9v4tFx8D7Ama7Sxwcsx9VmxWA4p 5Fm1+x5/gKVTpIZDrHxcHQ==; Received: from [87.69.77.57] (port=4158 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCde1-0003hJ-4D; Sat, 16 Jul 2022 04:59:25 -0400 Date: Sat, 16 Jul 2022 11:59:18 +0300 Message-Id: <83tu7hqvq1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <87edyljvfs.fsf@HIDDEN> (message from Po Lu on Sat, 16 Jul 2022 16:47:19 +0800) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> <87edyljvfs.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Po Lu <luangruo@HIDDEN> > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Sat, 16 Jul 2022 16:47:19 +0800 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Then it's what the user or the application who set the values wanted, > > and we shouldn't override that. And in this case having try_window > > return zero is perfectly OK, btw, even if it didn't process through > > ZV. > > The point I was making was that aborting in such a situation (when there > is no row where ends_at_zv_p is true) will result in false positives > when the tooltip is intentionally too small to display the entire text. Yes, and so this situation should be detected, and we should avoid triggering the assertion violation in that case.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 08:47:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 04:47:42 2022 Received: from localhost ([127.0.0.1]:42891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCdSg-0003Oh-El for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 04:47:42 -0400 Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:43470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCdSc-0003Nx-Mr for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 04:47:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657961253; bh=glpjnTTMyPodkZ8VyKP/4NLslJ5J2bFEtSIoi9O6b4A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=YHMuNbhseJkeMfhX0H11tIsYWObTdkHBw2bensOeoI9ta5XfLaC8/vKfc5FpJm3Ofe8XfRwMpQDqOuQGZaU42HsB6UQlmBl21Vai3jN0EtvmMGeLfsvueAJQ+RYK4Re7thCHHF+Vv8A318CtYUK34qMxa6X1eIfTBJSDMJafQ/vcZ6Tx9D+HRqju2dojX+iLAjIg9RfYBPc8iAA6HvYc63lvLjOOVOlXyDHi5UqhVE4N9fBekb1UohKrSccyuAaf8p1g0+cy4DTTG9LI35sQE9dQMn1QON7YGojSEehPRFDXQh+hhOtG0k/2TmE9SzWFW757W3jlpuQqzwEHxKwWzg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657961253; bh=zBbe7PWhfr98gl2N1cj1YBzVEL9Od4Wy+5T5LSdtj1B=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fjOc4faLn04qOSggHOQ59w/jfwZo9U8++cPvqUWeaFqkIx4v+WB4oZlvGC+OpaLOZF8561Sap2G02faqvpAKIjm+vgOybs4OUVw/zi5heOkX+BYjKta3dMorag++N8UnosDqGuc+fqMmph3ADWJlvkue7WHPJd+IbfccLQmSvGErdQyVfS80RqSw8t6VrTXu39SifgLRjyaXquhOvmAieslpjlHnnzYs8n3kQMeCkgZCOmwaz0h9FxxrcrAJ7TGuUStFB6rIoPY2Bgl1a+fngT8vZaGxbjrov49QwuGtc94MwiTdBovtP13RtPrT2DQebmmCVnvuS6H8c1ODnTAPpA== X-YMail-OSG: H63oRLsVM1kQ65EFe0RlXJpvGqIrAsCSjO449FIlbSPgdL8kYU7Tg982juWcZUE 6k2oIioDHKCWFctI0Wz.Cu3nUQ3kL._udjD5pzaPkzCHDp2sTMt8TSo2LuSFNsCkKKVYZ5eKFiYF dtJTkNWDOSsGYOEPjB8lwPz1rzRwDYknRQ3SiD9JSTeLLL2UX9xZ2.9lXyaw.WYnt6QcR9mmEAz4 XbdfXEdD7cGHBvRk799yuFiBoGfBPUHLce4dGANkP4mB7FyFF8b4XLY7I1QTTzrT2PInyV0K32Si c1Ij6cqP9MZCovQVdaH2xNIxSVliUOcQ6qxp9ALH3SnhPyaPg_3Z7ZQWOvdojb03I63utdt_DmVx W3obHvCqKmab6AMmO4hDlVUCSbPSLoh0qtbeaqJjnKXO4RYRUP_Jngh_TV20pWconypaFBDaH9bc Uyl.EVXDZe30MLA.NFKKGT8yYMOwsUtM5OGLpZT8MwPlVujvI_2XvCJUHRNYCVd4esa6b6mQspWa ew4CTCwe5zcmHScug9_tnEcafMIJmhx4VySJULWE1LEMTMwy8Jy2ZcnJj_1u_J5F4zpPinUqsjyy eLFw.gzxZQOOHA6nMSisnkpvY0IT8_YMnRaweG.rrBf8Fl7b8x3djtv4bBWZpYZ6QYmuZK0Yad4B y8O8gy2S_16LG0Oret6yUyDSNuqF_rOnDq3MHk9el1MaedUk1pFfoID4bh1b32ITpZn72LWwcCCh q1kU_DaJpZVj_99Y0Bt2HXTDO6PGQSvcCBYuk.VVI3OzUTidIkr__Y652_EKYdMlCN.BGjrp9wNt O1UB3BYdM3ppWOnxwzSOjKrto_iJsLqA1qkOXKeefhKOZutbj8wW5Wf4v3gvkpMdcWI2_6ADZEzE p1D4Zqwqy5uWTum67dWlQB23FHqThJ18kkNuVneyZEtKzSaA.iYmkv_CBXBvuXiTcrh1k73qi.F0 GWDui_D8kXcTUFF1XOeFbixF7_TvrQ8f3KnTuf8Bn6OiK4jTNt248SOjrhig5GncAmIn.F2ykesh 7NGPo.oHb0I2M17QMG44K3UPMbKEmYY4Ae91wUF1tglCJEnzwa.B_jWPrhJ7R657vH1vQSDPMbPl 1BQGbJ.aeW4kEwsgl.Ylrl8w.9jpNvN0epmZej7ekyzZdX3LAuVhYZADvg.9vWvTXxgHNHCBrkLC X1N.MbJ664ntL46.yDX1NFESvVPUoOkEJVVIa2wzarmla_Uf.EedIHovgD7gUaQYUmCCZ96pMnCg ClbLB_LihlbiOk6YOVfpajMeV22ow6r6mWVwRMdXteuIULrZAycwByJyiVVc7T3x2H1CJobUsX42 a5z.jXxdGcOFSciUH1UbE09aicYPEesthLL4vah_JKUX2hld93d0YlOAWrKv24NEMt3Q9GUVZyxl 2gDZH8GFq8DQyHx5ABiKh.ihe0l6FiW.Wb3dUxY6ilC3CH59d_CK95Oaf0Nv6pQZmXWrjWky3W5y wMmBGHhkNQtKhHMC5Rr5nUvIfWkPyn8zn1pYuZeDWU5FnTIXNFLjFa6MQIiJ3BbpnoMpEpidjjZZ _UFXFCwR0uQyzM5ZOnuFgvoMmJfbpOhplqSMjIitudjMrXoGAryve2I6GDeA08zeulxP.PCJ9uBn 102GVn7mCD28f1.CHNFjK6RaHCs2M1NUY0Ub1y2Z2cU.svl7MkFrMQXDIPME4NiVT8oyf5kG_w.Q Cu.4AWMTnK3qtDTbyL.TX2BZL75oqmTv_fUXogJ655jTHmyYEvpLF1xQ72CrKHJweeUbUGahuBfH 6K1178XjgYxnc38q2a3zhwYBwEnPYhSfLE4IJJKWDRfiE30GigYS3Fd4ZDWuqv1m2tKpQwe_py1i EjxWFVi8n9YqZH1RLkB7OXpUgGTR9.v8dg74yvhIWbgZ7.VJPGPHsQgfZ31VZpMZxr5UHPZ7A.X8 G3pAaz4Jt8ohB6w7KogdIXH5j5m4UNKjEdov2koD8jI0CuFuRcbhydD.H.qxI5ly9bMwkXotOKC3 qG8dkHxyWmJGLaDCYq_UaG2fURzHHPgLVKPUKuUTago9iO31KDjEwPfClv3p3lxY36yget9OjjXA pUL55OUhh6mK99F0eqsoxlvY4ZNBNuz7DfOAI0uxDC4suZEuOVgNojlMHTqjLO_7AaSlPUbA0sRl HMnj3pBJ1a4UDF31neTLIPTJuRWE8qDJUHfg0PL4IvPcGgODmb0pei9SeJuoXxzn0TMtprI0QWjC V983TvaIxS8mHzGgqr8NDkEC8c4PoFQ9xzrTSmknpLeCpJdL5mheZUBjhxp4t X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 08:47:33 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-v4p6m (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cb6d2a07d586ec44cb9a738f55e9f7ab; Sat, 16 Jul 2022 08:47:26 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> Date: Sat, 16 Jul 2022 16:47:19 +0800 In-Reply-To: <83y1wtqzqp.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 16 Jul 2022 10:32:30 +0300") Message-ID: <87edyljvfs.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 663 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > Then it's what the user or the application who set the values wanted, > and we shouldn't override that. And in this case having try_window > return zero is perfectly OK, btw, even if it didn't process through > ZV. The point I was making was that aborting in such a situation (when there is no row where ends_at_zv_p is true) will result in false positives when the tooltip is intentionally too small to display the entire text. > I'm reading the code, not the commentary. I will fix the commentary > to be more accurate: it doesn't take into account the special way we > invoke this function from x-show-tip. Thanks.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 08:22:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 04:22:25 2022 Received: from localhost ([127.0.0.1]:42856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCd4C-0002aE-OG for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 04:22:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCd4B-0002a1-Aq for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 04:22:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCd46-0000f1-3y; Sat, 16 Jul 2022 04:22:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=txSMAI/tu4dtH9zx0VKCLCNNuNNJ3p2YuNYxLcqXqoM=; b=rpZtmxAiTvE6 ycsCIRLO1m+1ohMuTJaluXy5aS2qre/L5eOYBYgZu1FVkXTyi0jYiNpABDkvLW/aW43QAg7r+S/2z U/iKHs5RuIYObTnGLNBAqG0f/7AzD1dukx0xmo6PO9jbaW7Mik88d/VdltgKnnNmZ0JRS6ZUOXMK5 QIoaXeIxcZnJZfSapF+iLrVe78tjH735zd8eA/U+mk015hJj8C/qOdchwBS1Sowm7yXNL202DwM5k 4/SOiKCx/CC+kp0rShR6JjCjApvfjlE7VffBY3uqnDjxGIJIqXhEkIwwl83vd+LK8jo+FRHY7nRxy whnbKqjXo15n0XSKL8Hinw==; Received: from [87.69.77.57] (port=1880 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCd45-0000aP-HK; Sat, 16 Jul 2022 04:22:17 -0400 Date: Sat, 16 Jul 2022 11:22:12 +0300 Message-Id: <83wncdqxfv.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: luangruo@HIDDEN In-Reply-To: <83y1wtqzqp.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 16 Jul 2022 10:32:30 +0300) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> <83y1wtqzqp.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Sat, 16 Jul 2022 10:32:30 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > > > The situation that started this bug report is one such case: my fix > > > will cause try_window to return zero in that case. But if the entire > > > text was processed and is in the glyph matrix, that zero return value > > > doesn't mean a failure. > > > > That isn't what the comment above try_window says about its return > > value: > > > > Value is 1 if successful. It is zero if fonts were loaded during > > redisplay which makes re-adjusting glyph matrices necessary, and -1 > > if point would appear in the scroll margins. > > (We check the former only if TRY_WINDOW_IGNORE_FONTS_CHANGE is > > unset in FLAGS, and the latter only if TRY_WINDOW_CHECK_MARGINS is > > set in FLAGS.) > > I'm reading the code, not the commentary. I will fix the commentary > to be more accurate Now done.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 07:32:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 03:32:45 2022 Received: from localhost ([127.0.0.1]:42829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCcI9-0001NG-67 for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 03:32:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCcI5-0001N1-7o for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 03:32:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCcHz-0000pI-Qb; Sat, 16 Jul 2022 03:32:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DKRmcxcgqxQneeyG9hq1oW9DzkjCsuVDEDGaNtdOA4I=; b=sFdItnPBgdCC Tn2TZ9gGZULO+qL7rOBoDY5hWMfZpk9bf9qfu814M8b63GGwG5ZQfibWyjagcbv4bLtKKpcQ6GcNx n6hAcOp31nOlnJoW02Du8qlkKOpMTTvRPPBCYHU7NfQOMVMW1M6wwCzemmHuXeIMr2EA68gwdVyz+ 0zUDs+eHGbqrLO3KJekaCLTfTJYbxqjKg4NbziB6bcP9a3oSnG76VJeTFOczcXkUnFEvBSAG5B+dq KrF8pDAVCSfckOSs6LWSPW2dbcwTYdnkw7JiFvgBXmGWtT4sbRn+p859GYLxJ6yJJJcJrs7XppsVg +8idKzssNA9A4M4YR9QMFA==; Received: from [87.69.77.57] (port=2818 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCcHx-0006UW-HZ; Sat, 16 Jul 2022 03:32:35 -0400 Date: Sat, 16 Jul 2022 10:32:30 +0300 Message-Id: <83y1wtqzqp.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <87lestk18e.fsf@HIDDEN> (message from Po Lu on Sat, 16 Jul 2022 14:42:09 +0800) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> <87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN> <87lestk18e.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Po Lu <luangruo@HIDDEN> > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Sat, 16 Jul 2022 14:42:09 +0800 > > Hmm, right. But what if Vx_max_tooltip_size makes the window too small > to hold the entire tooltip? Then it's what the user or the application who set the values wanted, and we shouldn't override that. And in this case having try_window return zero is perfectly OK, btw, even if it didn't process through ZV. > > As for toolkits: we don't use this code when toolkit tooltips are > > used. > > I wasn't talking about X specifically. The code in nsfns.m calls > [NSWindow setFrame: display:], which can end up calling > adjust_frame_size if NS decides for whatever reason to resize the > tooltip frame. Depending on the conditions when that resizing happens, it could arguably be a bug, e.g. if x-max-tooltip-size restriction is overruled. > > That would trigger unnecessarily, creating false positives. > > How so? We pass TRY_WINDOW_IGNORE_FONTS_CHANGE, so try_window can only > return 0 if the glyph matrices are too small. The question is "small for what?" If it is only too small to display enough empty glyph rows, we don't care, since the tooltip will be sized to accommodate for the text part only, and the empty glyph rows will not be displayed anyway. > > The situation that started this bug report is one such case: my fix > > will cause try_window to return zero in that case. But if the entire > > text was processed and is in the glyph matrix, that zero return value > > doesn't mean a failure. > > That isn't what the comment above try_window says about its return > value: > > Value is 1 if successful. It is zero if fonts were loaded during > redisplay which makes re-adjusting glyph matrices necessary, and -1 > if point would appear in the scroll margins. > (We check the former only if TRY_WINDOW_IGNORE_FONTS_CHANGE is > unset in FLAGS, and the latter only if TRY_WINDOW_CHECK_MARGINS is > set in FLAGS.) I'm reading the code, not the commentary. I will fix the commentary to be more accurate: it doesn't take into account the special way we invoke this function from x-show-tip. Note that x-show-tip doesn't check the return value, and never did, for that very reason.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.
Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 06:42:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 02:42:31 2022
Received: from localhost ([127.0.0.1]:42789 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oCbVX-00005t-GC
for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 02:42:31 -0400
Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]:36095)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <luangruo@HIDDEN>) id 1oCbVV-00005g-PH
for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 02:42:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
t=1657953742; bh=iukbqjvkDxw4FzjJno0VdprVUkV1c8i6pkjXXbVVIRw=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To;
b=onEWzWOQSeWnp1w3N3L+v2BTdINmJXlxv/Y/FMsixBOzs887xDGrMSCcI6InAfbR2A/CL+g6TvGpVC8tCzzS4jCtjo7LGpdwc04DU8z36ycckIZHsHjiJOLE/PG6Hz3QDE5aSw8AcHoJK4p9KbUswSwbkPJSrSEzlgFTRr3oPQ04of9b9ufqRlIbCd+sAXBVU2Qs/32AEpBO5zHSTrd5lzis2W3EXg04v7r0EyWuWLKFcUW1Tea0hqW5mZ1IHR1JQsPt2EfxWsw8azuwDGCxCWatB9zfMVhwNMsXode4SLiy4SWgJKx1W08TVt6NtsXwYFx7Vf/hLvZGKp4gOZFDUQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
t=1657953742; bh=Yh2vXpfyME5lVU9erdZlxGZu+HEYKOizny/349WXOux=;
h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
b=MsOeWKsEkBoHJYx598BSYj7lZZr0XZO57LK/GwhO4IyAkx0KjBRJOsBN8xaRxAYv4oefDaualyG6LfWk4TzJN1bR+q+VevcIZ3GSDKgm4+P0oOOlYgQ4hcb96OefyecBbPguRZC4NeQ84YXo0ZQ7pMLxz/0OytLdKHqcILBroJI9ouiX/OIkhAUax2+VR/p1+fKtOgzmAY38E9EtLVxyiL+u+ukoAZTuEdbfOTnY08+1w/TKw3+rOAdW31MckV3WUE64Olnd1cfCaiwf48yKtIiq3K5WIKry4i6mbZIWJmMyhSJAMnbkOBhd5EmpqybHdz/NxiZ16zevEeudCIl+wQ==
X-YMail-OSG: 7TG.7wcVM1k43w6nkMSwGda3jCoOqvabwYz22lVSo8KWWBJ_k3kFcFowes0KRYc
hKRGX6EOhwqJ2dyfv6ZLbkvPrJuZ.V5789rStLPf6zcYk..DOUnSVKI4sGV8txuRzoveCWw64oAq
oP.1uzP.qGNIXQ9vW50qBbMDsNTDtXhBuRp8m59.ZH0WyOqXvczlefBgRXz5qS9sRJCZmtEyXTkk
q0oVWtc_ss889hcWGNOGNNmcdedEb1m7Q0ypJbJsu0.XYw5yN_VzKhLDvMAMzt2ZOliEGu9IS.g4
SkQwbQlB4CjU7ecN6ctrOf2OcdzFh7rt3jQbKOLzlICImPh37ujUTMdD0PbHfONiisFcrAD89wvw
wGJMf77TOlcDHaSlOdLiv8wygcO_XyDlqKcvSftLQvcVUo4ddHpGucbI24qHQ4wZO9v5kySwPNQg
IWXr9YJrGMViKB.7S8thCPn.vUYNeTDxawzc6ssndGmkwyhBX2AOVz5r083eAgptMnU907RxEe9i
Owor53YCwZa.YcamqWNMimEBurUipDcVVZMj5LyGKRnHXGzBFNrecD4HaIgbPj4wYZDHc6n6s7Av
OexxzTfFrtY8KpSUj5u9dayz18Y5xPTGI4aNaohCSRSZXJmBfpfaWE_LB679kuK30384jVj4JFis
lKmLsphqRfioZlGfeQGfLFLIA67M7NKUYQwqpjmXvwWUr_gGgoNP6PhYb6UYHhYnI2Nbxr9NG8hN
a5KEA2xz0P2YfNndxoQ_q2aQUbUZphcuCKYnidBoFHTuRqpa_R5zDnUZv4t4nbBiylxwiEmgoZem
vUb2ZxOVjo3hDQpisl9Ev7JlF5Jtv8fasJ_QS__RUNWfXS2NgMAYUIEcawYOFtGF7DgCoQxjurmk
f6EuJbB4Hp14N4IMKZZQ8y9lXLl_q.jGAvq1xOB70bVFR2vMT67NS9FjpRkL_BwWYr3Cv8Foj3Nj
ETlahVAVYI_iJN.ZmXhRmzD3ODtePbXA4.UBKRFdvfAOAdHrH2PhRX.2iBH8Ld3Xx0_jAF_DUnuU
TeQ7rfTfZckxjdKtDpEJ3STCQDf0cuoFjr1eCCFmqMDdgXAt9beGL18ZdygNVYrl9EkGIICuTnjM
9Z7my7NaNkBupIiOUJdNS5vMzklhDor7VrF3aYobe3ca0JddDyI2_qDFxgwL1sXTMmsX9E2U6.BW
ZylY4wO1gSmaYbPb8P3XqlYJw6iP7HnyWEoTh_vHuSX4ZdRK2nvawacelPyhlJzVpkObYFWPTQnP
Pwur0T6kgftemLnoDAHobkdb8l5gnaB8BCINNmiw2EFvu_GEecVfXeON8rViS_Qv.6vDR2TUusiN
qtSEJQtQmSRq9gAY1i6KYzl92kZey0TRxg6YeP.aDJrhmnsnBwrkhqphku1ek1B5tL_C1DyFZBWu
zEW6o1P.QVWx69rYn0F6eUoru9c_TPhmHy80.RHU0a7hvNR6x5J.4um6Xvjh00P3Z4GitwBieCyM
q9a6QkmSNtAetxx_UKVmqUs815M63Kz8VY7f08xkqptrrUDWpDE.cbmnGqb14FXv80CFPAtf2FyT
FPzTuoI7vxR3ObIfAeTHAnRe1eJK4jg1yNmnI7FkWbjlC.yFHhfpfovmyAHwI3F8j2KeULEqvGio
egOZPOtdIxR1Vtd8PHCfDD40JzYyDHVjH8IY_oynQmYmy.aEFVPRJiUHD8lkY.vSi6jvK2dRKLWO
24lpSfzKJjlM3pxe6NBQZmVXMSmvLUMKJ.BjJvHJxrbHUlno2cAapJLCeoO9FgFOfRiCLXD_.Wii
ko.ppUOwGwmfZHZYiC1nPoLBZNDNXxmqHvvpcfZpF44VopTss6.NavWallzmQkaw1wxaScJUeewd
3g8GpJ0KkhlDgasMiogICwjKzTWpF7A2.IGBb3MMHa2Y.fS8sqRBymPyx7IjRZJvtgQZmS_xm8K4
2EiOsjPhIs9OTbGXRVRqlU5cIi7RYKX4Utltl05ngb_JesER3ZLfcoeFAZ6uJZxN.5HQxx7CfL1N
fclhOmAj5muUV1PYV4IoANDh5WPJNnhYvECrw836K5ndkxn2nggS4mWwEbupe6niMsEHBQaUQczp
KdjpaI9oz0PrLAEmoqmbeZ_F.T_k3ytev2hytjqgD5JkQSw9BA1DcFi7zsOHeR15nOLBojZAIw.j
Ilvo6RYx.8cvvjdLeGHLxUYey7zNn2S_N7aQyvVNNhNZIJg4z1XoAAkdmN4QBsTs3Z2Kr73l0bQW
EiZB19wPRXzBSL_4S3xFZOlwK5INbozZzTICuVXR.svIfwacVFAsJ4qbMC8Wu
X-Sonic-MF: <luangruo@HIDDEN>
Received: from sonic.gate.mail.ne1.yahoo.com by
sonic305.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 06:42:22 +0000
Received: by hermes--canary-production-sg3-67975bbd4b-w2clr (Yahoo Inc. Hermes
SMTP Server) with ESMTPA ID bc1f1d4e1b7eb945fba20f0672eb1368;
Sat, 16 Jul 2022 06:42:15 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#56561: 29.0.50; Infloop in try_window
References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN>
<878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN>
<83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN>
<83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN>
<83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN>
<878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN>
<87v8rxk3eb.fsf@HIDDEN> <83zgh9r2he.fsf@HIDDEN>
Date: Sat, 16 Jul 2022 14:42:09 +0800
In-Reply-To: <83zgh9r2he.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 16 Jul
2022 09:33:17 +0300")
Message-ID: <87lestk18e.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.20407
mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 2129
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 56561
Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
> if (CONSP (Vx_max_tooltip_size)
> && RANGED_FIXNUMP (1, XCAR (Vx_max_tooltip_size), INT_MAX)
> && RANGED_FIXNUMP (1, XCDR (Vx_max_tooltip_size), INT_MAX))
> {
> w->total_cols = XFIXNAT (XCAR (Vx_max_tooltip_size));
> w->total_lines = XFIXNAT (XCDR (Vx_max_tooltip_size));
> }
> else
> {
> w->total_cols = 80;
> w->total_lines = 40;
> }
>
> w->pixel_width = w->total_cols * FRAME_COLUMN_WIDTH (tip_f);
> w->pixel_height = w->total_lines * FRAME_LINE_HEIGHT (tip_f);
> FRAME_TOTAL_COLS (tip_f) = WINDOW_TOTAL_COLS (w);
> adjust_frame_glyphs (tip_f);
Hmm, right. But what if Vx_max_tooltip_size makes the window too small
to hold the entire tooltip?
> Or maybe I don't understand what you mean by "the size can be changed
> by the window manager", please explain and show the code to which you
> allude.
>
> As for toolkits: we don't use this code when toolkit tooltips are
> used.
I wasn't talking about X specifically. The code in nsfns.m calls
[NSWindow setFrame: display:], which can end up calling
adjust_frame_size if NS decides for whatever reason to resize the
tooltip frame.
But you're right. It is called after we compute the window dimensions
and then call try_window.
> That would trigger unnecessarily, creating false positives.
How so? We pass TRY_WINDOW_IGNORE_FONTS_CHANGE, so try_window can only
return 0 if the glyph matrices are too small.
> The situation that started this bug report is one such case: my fix
> will cause try_window to return zero in that case. But if the entire
> text was processed and is in the glyph matrix, that zero return value
> doesn't mean a failure.
That isn't what the comment above try_window says about its return
value:
Value is 1 if successful. It is zero if fonts were loaded during
redisplay which makes re-adjusting glyph matrices necessary, and -1
if point would appear in the scroll margins.
(We check the former only if TRY_WINDOW_IGNORE_FONTS_CHANGE is
unset in FLAGS, and the latter only if TRY_WINDOW_CHECK_MARGINS is
set in FLAGS.)
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.
Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 06:33:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 02:33:30 2022
Received: from localhost ([127.0.0.1]:42784 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oCbMo-0008KY-B9
for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 02:33:30 -0400
Received: from eggs.gnu.org ([209.51.188.92]:55502)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1oCbMk-0008KJ-FN
for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 02:33:28 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:52882)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1oCbMf-0007vq-0Y; Sat, 16 Jul 2022 02:33:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=Z9xIKErB3y/VYSGsgDU4qBgmNifcK7WpCzgukHq6nvs=; b=CvMhsjGgeaqO
aI+GxOiZDB7VF+m6fmjtZjyQv61MauWeaTZ5MNEHeLaL1aV/Bl9oMoEhQGhz0/YsPAFA3V7WyHNxz
wjLXbs0Ey3a5cSy5YEN2Wcssj1rXF7QBsCTYe8xucXOWd0F/629/XhEtLtYhBnRSRq5QhTzYspqoq
20Bzfh3unZHs1WPiUeK4iCJoNAO4EzOucztmWYX6f+85/t+15URi4LcrRKee4A2TSfSLdbRQ6dk/R
TxsvEWfWlAsb8YBLmgSwY24W2h/mj6yjaUH8voDpmby/AJuAoAuqABRKusun7fKL6cVYhdrj/vsHC
mG28D0MKGP1t9TSXVnSZvw==;
Received: from [87.69.77.57] (port=3191 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1oCbMe-0005sT-H6; Sat, 16 Jul 2022 02:33:20 -0400
Date: Sat, 16 Jul 2022 09:33:17 +0300
Message-Id: <83zgh9r2he.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
In-Reply-To: <87v8rxk3eb.fsf@HIDDEN> (message from Po Lu on Sat, 16 Jul
2022 13:55:24 +0800)
Subject: Re: bug#56561: 29.0.50; Infloop in try_window
References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN>
<878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN>
<83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN>
<83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN>
<83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN>
<878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN>
<87v8rxk3eb.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56561
Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Po Lu <luangruo@HIDDEN>
> Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org
> Date: Sat, 16 Jul 2022 13:55:24 +0800
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> > What I had in mind is an assertion in x-show-tip that the glyph matrix
> > produced by try_window includes all of the tooltip text, i.e. that
> > there's a glyph row there whose ends_at_zv_p flag is set. This is an
> > indication that all of the text was processed and will appear in the
> > tooltip.
> >
> > Note that in the case in point this is precisely what's happened: the
> > entire text of the tip was processed and produced its glyphs, and the
> > problem happened while try_window was producing empty glyph rows
> > beyond ZV.
>
> Thanks, but we can't guarantee that the tooltip frame's window is large
> enough to hold the entire contents of the tooltip buffer. The size can
> be changed (on various different platforms) by the window manager or the
> toolkit.
If the window manager changes the size of the window, we won't know
that in try_window, because the code which creates the window-system
window runs _after_ try_window. The dimensions of the Emacs window
for which we invoke try_window and of its frame are determined by our
code:
if (CONSP (Vx_max_tooltip_size)
&& RANGED_FIXNUMP (1, XCAR (Vx_max_tooltip_size), INT_MAX)
&& RANGED_FIXNUMP (1, XCDR (Vx_max_tooltip_size), INT_MAX))
{
w->total_cols = XFIXNAT (XCAR (Vx_max_tooltip_size));
w->total_lines = XFIXNAT (XCDR (Vx_max_tooltip_size));
}
else
{
w->total_cols = 80;
w->total_lines = 40;
}
w->pixel_width = w->total_cols * FRAME_COLUMN_WIDTH (tip_f);
w->pixel_height = w->total_lines * FRAME_LINE_HEIGHT (tip_f);
FRAME_TOTAL_COLS (tip_f) = WINDOW_TOTAL_COLS (w);
adjust_frame_glyphs (tip_f);
Or maybe I don't understand what you mean by "the size can be changed
by the window manager", please explain and show the code to which you
allude.
As for toolkits: we don't use this code when toolkit tooltips are
used.
> > No, because as I explained in my message, I don't think this should
> > be needed. If the above assertion ever triggers, we will see what
> > kind of situation causes it, and can then discuss solutions.
>
> How about simply asserting that try_window never returns 0?
That would trigger unnecessarily, creating false positives. The
situation that started this bug report is one such case: my fix will
cause try_window to return zero in that case. But if the entire text
was processed and is in the glyph matrix, that zero return value
doesn't mean a failure.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 05:55:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 01:55:47 2022 Received: from localhost ([127.0.0.1]:42776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCamJ-0007Ql-0c for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 01:55:47 -0400 Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:38237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCamD-0007QU-4J for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 01:55:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657950934; bh=FRdyToEvj8c7hn2X5hYoIAb+RAinkKHE8NNZZA+3WYc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=rYeDXTWar05/qVLhR8uBWT/vX9cJ8tnaVtiJyxs3DcC29Y8exGIFdpPDXWFuQzKJ8U80AdjodgblTgb/1Hs7Pr5qBedGwGVnV5slovB4oHuJ+vV7ucd4TGVvUhTfkZ1QUmzu562O7jFbQnchLyYrRkxoWa0QXtqoKPAHNLYbElO+r4ZDlLu+WHQ7xOjaewF+x3vuQtvhnYbFdraWPM2SVcGCbqH52XkrpzBIKV1CLkV7EuL91/CS1FzcEnzoEUR70CXAn9pdZ++LKzAmPEPvjTWjFvLheQSzrnYCRdpfWKMrbze8rmX4etb/RLO6X7ehsOqaKky2b4KikOI+PVSHsw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657950934; bh=Nf3k9yX8FH1nJntoSx61tCXnV0EsPTvmGsWS1MQrofd=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=mxoX79+RTj+ahks6BhMb8JQ0mwQjN2KUUNXw7+MxdrlKwq2+8KMV+uDDEX+bYvVJDbHAn6VuLd+KUIVpy3jHxmwH/pZpSLJ6l9Opfv5u07aa8BlTZRiXjP5dB5+bH2PhGvG5KhmvLOWu2uVZ6OkLqHjmsKAKWJERpadD8OUWsq1CB6xHv5Jmcody160Tg8SnQEHaAEi4v5vX1nRYBao04t8Og9vdDzaxOrwS4YJvfT98ddT/AISu2TSOuHKDHv5kwyFoS0mUiXgZcwY5yhc4KLUYMhNo3qhM/RsbGyfSYKM0V+qu4ViW1QNAo8T/zARfN7GSEv0+R6XHuvrpCVzcIA== X-YMail-OSG: 1UjXqjYVM1lkEcncumkwKKA3oOUTpRBdRiVLwE3KZ2pNRUa.z44bAoBf8sfOaHN YuR_feoYxEqeifVd9GUUBFbbLF.7qSOKIWKraFXfEnQq9MvDwCtBXDvKMvaIfVaC4zul90t6yQYb 30YPXkcQqjrKj3md1ZpqK7FyLd7J6m13QpD148IvWRs9CaUON.iHnYsKxbE_c1QuAYxxKNNRO4DH 5eFl4lFYhtC7aV_OGoMcTerCOSsl0Z4p6uCw1FXSABRZYES9bLT_v8uzXlXziUzlC97pCfSZaGmM AsY0aQnrkjb7j490L4naqdCml6HDocNZvqmZEMSe1V2GYe3avWgBWrsSp4jJPZrIKgaFS9ejPUiY SqoomK_FB5AJcSoorLP.PbJNoeNOkpF9ogHfhUlAy4aP2x87Z81JsETLgh009h32k4LdYQEH.eEP ZLlBC3DPNDUvT8rvtzBaecopec2HuRwxEfOAlzuflNnXa6xngMjqgsES1jg4kQsWQe2JpMLYBg36 vVJ.pGyK7VgtDAzt48L.OH4S6SlSfM4i0XJZluVNkFIv1OzJeXAMZkPDoFLVo7YEbLp7.5U.yIhy zyIV08tZ0UaOMJEfE3nWivFmZEHUsm5CypyongY_qFTdaNiVsv2Gr7AHudNwmPjLOu9U5OseE6tV ilceKYNjiX3SOBdV5z072juVdQgEkhlBjjOj8V04.r2o3CxkQahYnL2D2Pin1KYDVU0JTGo8sVwx kMROuUxVeSxg2qt.Isg_zsWCLkzgwZs7PD6kUZvoa6dhIQILyztGbuLN9.PpViKpK3.gVJn7BiDX svq0Taa_9WYwy.ah6DWcIdPyiJ9K8UPJ_gFGYkysq7erMG4ngiR7z9ojVB8Lsbh4XzQ0qfVDVCna rMAP3F6GIJavn9qMMEL19LWP5fD9sUHHx3jMUHo3V4q.iSy9dPjgV6z29mV76xl401cYGu1TMAAP 7_vJ0fRuZlVwJYjKXC3TLHoK9b9DKv9fHRqjpc4uKZZtEX6C3bxJvcjdzvr71aMOxYEvK.zjNqXm ebTGeTYnvXqKV3oS9LxlfoUBSiXKbBhL5xPZYvQ12yks90Foep3ywXIa_2BGh5ZaOhCy8DH48i1z 3kMCN5rShzNlGXl757QxadZDPhlpG7f79CDStdfeALU3YGUpyiz7fmR4AmToVjkW_7pO2fs9eAoa lAHwptKfui9mI65rr6TxWaJ8LS0OOcDEBluvJ58RQkJaZQaC3Pra6QBt31L5D4L8GhJSm1.Ah8r3 .cSl8WQ7YSLnMe5KqpZQBkngdEtvjP0G.pA_i0bxIEW3P142E9d6ocAa4cgJPqfcqJwbB7xmu0k0 T3rhPVsIojcnZDMcqDZR1RYosyLtdC0fFi4SWrXehQ81HVBhNaFNj7p49fPF8Jz0aiMwYRnvW3lc eK_5QvcrZtcMuu6supTsZ39VX6nnivv_fMY0mQxwZ7TKK1xa.LUSl5cEroWUZcFn3EvNi8GdinPa a.DlEwR.lcHx28lspR22UGvOkvTwv3t8QIUj_.u5qc0uZuoT2FoKvqoo6FEj.T0n5OcEOS3zpiY9 cDetqUXBBkDicOMzoW0cwzkXL7o6OWigreSPzVcv.WsAEwrCsw2ZNhbxQcOK_IiF73K9CNaKTjfd c9rCaXtE28.R01JvO39PrN3Ip6IRBY4LvczS.dL9_MltECeS8NsO21HimgrFoeXuGFi9oiT_P3Ux dHepUSCgRhfj9cWe2lZDtLPLsOox07RkBql_gSNhlbObPgRLd1JJDgcQyi1O8hI6RMpmX.a.Lt65 nKxkUoRMNGchzls0gmvsDzfEiMieX7BTAwAhWM42Fe.ugz57t9351DLUKJahnG000Ek5xWnwTntp FZWOOdYXKeagnD0YWWfh_g8wAwC7l7aTC4FRNHMNOoT6K.vSTT9IL0kTFXMS49eLlxF03h._ibW1 Qz5zxnd6QLRg5R_YgmkHe1ow8tOxEYYQ.jrXlgkgirMGk.KMGWS6E_YjfJULiyN5BVBse8jhxK7U fQycWzxoV.Aa6Yn0R9FIFJLW0mbdFPRjJGsfCXqk5ElXuk2ed6cDpMNRRhxhHEdwC4n8H1._Any2 nQUXk34ISLFXoaqulhm4NpbmJiZdTZkRxoaoIF4I3Oq_jo6RboAxe8jRA1EiswVGUfK8UKFBzKUE A7EIQIbxfCiOfEe0OAO2L17avrKN5TK4EL5Su3.Uh6VRxdxJzHVsBIBe9iVohv1EQcUAxX3RFN6x aKAh1vPWC1ZGDPEGLW4.2XV7hhaaxjyn799HhhbXCEQ6xalWYsMOWG697caAaPpw- X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 05:55:34 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-w2clr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0188803537038133470b9458eba216d4; Sat, 16 Jul 2022 05:55:31 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> <834jzhsj1a.fsf@HIDDEN> Date: Sat, 16 Jul 2022 13:55:24 +0800 In-Reply-To: <834jzhsj1a.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 16 Jul 2022 08:50:25 +0300") Message-ID: <87v8rxk3eb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1051 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > What I had in mind is an assertion in x-show-tip that the glyph matrix > produced by try_window includes all of the tooltip text, i.e. that > there's a glyph row there whose ends_at_zv_p flag is set. This is an > indication that all of the text was processed and will appear in the > tooltip. > > Note that in the case in point this is precisely what's happened: the > entire text of the tip was processed and produced its glyphs, and the > problem happened while try_window was producing empty glyph rows > beyond ZV. Thanks, but we can't guarantee that the tooltip frame's window is large enough to hold the entire contents of the tooltip buffer. The size can be changed (on various different platforms) by the window manager or the toolkit. > No, because as I explained in my message, I don't think this should > be needed. If the above assertion ever triggers, we will see what > kind of situation causes it, and can then discuss solutions. How about simply asserting that try_window never returns 0?
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 05:50:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 16 01:50:34 2022 Received: from localhost ([127.0.0.1]:42769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCahG-0007JY-4O for submit <at> debbugs.gnu.org; Sat, 16 Jul 2022 01:50:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCahE-0007JF-RQ for 56561 <at> debbugs.gnu.org; Sat, 16 Jul 2022 01:50:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51156) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCah9-0000bw-Hz; Sat, 16 Jul 2022 01:50:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jK/lrhUpFk0abECvBHnwh7tca0cGshYZc1L6RItdv2w=; b=fbewjQFLghf+ pgEhqdxBrij+62wnuR+mJRP4OGm3ebkqBCaMMN5MXG3b3G6CPoBv3A1iW46QmcYzSR6oOD3dT2RpV SjZ0XMJe/25kREIG80E3KRQLXu4H1UXc6RoprZR8B0Xq5WzR9JPAZeW+M/4Lqupl7vAxz8NnSEosr fhdY2izrcTiouatTXXFPnwSLVxxK3WVnM6foVHn2o/4Er8Xn6XLk6z7bEjecpiclCtvRWojIUV13R OhniDHIU2swQjKxNp0op+7vDEnbxXpq/UcQBGEyqTlqKi8uFbBkRhmiWrQ99zeMIfSmJKT1gmm1R5 JvLAHV7jwVAkJErujzHE2A==; Received: from [87.69.77.57] (port=4351 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCah9-0007tE-2H; Sat, 16 Jul 2022 01:50:27 -0400 Date: Sat, 16 Jul 2022 08:50:25 +0300 Message-Id: <834jzhsj1a.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Po Lu <luangruo@HIDDEN> In-Reply-To: <878rotlpck.fsf@HIDDEN> (message from Po Lu on Sat, 16 Jul 2022 11:15:55 +0800) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> <878rotlpck.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Po Lu <luangruo@HIDDEN> > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Sat, 16 Jul 2022 11:15:55 +0800 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > No, that's wrong: we call update_single_window there, and that > > requires a window with a desired matrix set up correctly. So yes, the > > call to try_window is still needed. > > Indeed. So would you prefer an assertion in try_window Not sure which assertion you had in mind. It cannot be easily done inside try_window, because that function is called from many places unrelated to tooltips. What I had in mind is an assertion in x-show-tip that the glyph matrix produced by try_window includes all of the tooltip text, i.e. that there's a glyph row there whose ends_at_zv_p flag is set. This is an indication that all of the text was processed and will appear in the tooltip. Note that in the case in point this is precisely what's happened: the entire text of the tip was processed and produced its glyphs, and the problem happened while try_window was producing empty glyph rows beyond ZV. > or a call to adjust_frame_glyphs if it fails? No, because as I explained in my message, I don't think this should be needed. If the above assertion ever triggers, we will see what kind of situation causes it, and can then discuss solutions.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 03:16:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 23:16:16 2022 Received: from localhost ([127.0.0.1]:42618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCYHw-00058V-C8 for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 23:16:16 -0400 Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:39238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCYHv-00058H-GM for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 23:16:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657941369; bh=W91fIj5YpvZiQqUYvLsIE+UBdkKEuDOwjB5c2SR6dcI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=L2feVFPLmvOj3JXqGf7EjLz0uGRQ5xunfjJh3zqNnkZAhJ6w4I7nQ0JZdgebd23g2J8K/b8UJoJ6p/genyq4V/pW9lDd1XKqxzcSOAP3A3DsQ0ZmoyFd7lQXLhMWaW9j3BS87ip6iWETXRyocfxUKhZU7rs1RlizcvwJSRcKCQzHeOUp7s+tzgDaWxToM5duueWGcfHbD2GYvLmdUP2LND2KWyPql2v+4L6e9HSoNqKQdk9EOkdw+oLE061V8VHm6PHvcn1l5X4YNXx/zHeMyJMpHBWT/jLXxBGOCuEB0mdnFUiVDVtFcmEneVSsi55p3otKy27hD/D7blKd2tK5lA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657941369; bh=nsgbi/6AoIKt3sT4Cl5iipkl45G6iEp2kOaA9sAsCx9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=lbaZmjhqIPWqrRsxeP87M/nLV9pfVfZiuTpRyTWaMfYR5LMYpCmnRoynpVwDbGD/iR6zcIhvLYiaBZe7IvHmiYL7B0vwcb0HDzG3h7T4I8uPKraKvo3RZ0PvaChl8jttbH+Zk4H8fEwwouNWKb/D4V0fwNoT2sHv35lHB/ghoYxuR9Hp4+akKp9MRWcdpkcEGwBdClx13Q2IifSOlwlFOSQDL8LIdoR4xM+WGB7tDLKcW4usQfF015b7wG6Xn/7y2WM5wr46pqt1W2THYSBpkxKQ4SldReSWoRIwpC4HfCAYhgZXGZY4zuKDvnz7XoJ/Q3W/bwXwoVm4Cu3cpXKSwg== X-YMail-OSG: M4.vhtYVM1kCxDA7LbZXffB0G79SrWm5dxHyhgrgfo8pT_.s08cWH1xFNw4U.S3 5xEiZBBVjtUGK4vx_tu6uW7sSyRDS6Tc9MowuMduz81dygMEfwsBICbOuKRN8J_evsFfJRTfKsQg D1N3jrRFCr4YyLmb9xGx95KQntEKE0MvY5jxRl0Uvmur8H57JnukaVzkAV85.oaThKDJnEJTyEvi mjhtDVDH_VPSSXR1QcJPiqM4ZeeH_4nhNjS311.IlMEGP_IsCAgOce1lmIMutx80KEMW572rbZjP vUB2uIR58Wp.kTywwClk8VDWPVQW5mJltY2T0qNuwmSc.IMUrgFNUVcHd.XWAjiY2VgC4CEcPjT1 TYjQHGDoG3FtHvtcM.g92PvPMTYRWi.IeQc0Gj.7U18LM.43mOJDmzsSBXCDveHBV5nru5fJyMsk Bnk5n26kEWcnKOIT1ar9dcrT77CA1.BgZ8kBdUEXi1M8hJj.QIjI0_Azr2__eAOef8dVYkRc95SN JWJHMq.gdQz242K1.oGO2WvMrWvh1wMU._a1_91bETKvXQmSiLxnE9rZUt0lH2zEjiZtk78yCoXy Ol1yupufJ5bLhEC_Y3jrFSy6eUkRledTwuFF.ksUz4bTsZzc03Hw42yhCXA36V7aUY0MoJxv7ATs mxvYCAOrPRkRZ9tAEa4QIO3Vj3z.f1igqZ.QExHtsfY_9HCKUgCwxV22pZRx32IyuF5FzAVrFGkd gEdSfMdiFR5L1n_Kc.ahjs41t0lT1j2mad6EIQgaVXWA_k8xCZ5DumBYWd02gPcXSqLSedi3_.yB jBA7aCWRhOaJNaIzlLdWCPy94nnp4rygamzfASqw9imdjIyhPlDj2UrzAzeo97vRGctt53Rl35U9 EO3Kkh7GBZ_tDUD6zjW9o8nssfaX3ELDw6Sus7FVFhuUQLzbFl29rf_7TW1ogCDrR6d6N0ociJQh eJGGdF0sLUFVi4iVB._5VZhoOw3msVILtNMuBYj8XxYfMK2bM2qZ2gbmYnGMff8mrzd3YMalRjhX 5LUUijbXPyfKRGa7olo_W7L6tWo_Pckwlv2OsDsjFuu1y3GjYxXEcYojzC9P_6DCppVC4nsedUBc 9y5o_hMt8JqxP1qTxpmkHRX6kx35BHvUKcOmvRbWkSl0G6zk7fpC5FqHa3t9qry7SB82WxD5O19X HEyq_3mDeMGIX3S9yuppb47xhjWaU3jPud5LkRBrzQleVm9xmFNXMml9nrluHfXeSQmqiyrdDbyj 2eeCCQEuxrpc1YOZMnGsyWWNhIo_nbbPtjby2JyEMl.nAUoihqI6Uog4JBaz7aKWPKRvQ_MKPX0C 5TWlAhei2rlKClfrvYLZ2UFhM45eqMo7qKkUDaCIXk8bTyFek_WMi1zjMuSGR34BJIp62iX03kil oSUWGrC.4QfWKUuJMCnL.6tbcxEz_HMMKsOglsKnwdh7BvHfuTQmk282I2eH36Rr1Q8tAyZDEDDR 473FPyBhKJmmuuML9eD4LM8ZfmL06h9II.jGtXqTsLWmNkLiB.HTBM08G5.4UjUiaVrQNNBN0J5L Q2rPHOodJfJpaLrCkVJDyyYaXZo90C1FbUe_4hJVZS9S9wCJ9kg2Okg2Lms3e7LqFwhgkcGtdxqx asGnyEvlRpDlNYjdlke4_jWcMDTdw3z.LZ_E8W9P.3sqKD_w8NB2wNJxUZiZwkFNloHr77hBiDND 0ECl9scopfklsVQ2yE4IyMNfhTnY0asw9fgxXsoXkpX2Iox3Y3rMFwuo8DjpZp6WgVRHd8Fl49SK 3MDtho8vgVe7.iU3oRa.QlrlrVJ76NQWnII_.3i9e9YFzMTB_B56uohfTxYzwEmmr2KnjQWBrHhN RdbzfOoZSeEeAnbPJPwL.kxWVHkrwI3XJrByhIlFr8oo2v63THZLbuvPmty4spCDl3pBo01cy64z Q0U3y7sMDkqKOMFPhVjXk8a1F6Z_Z_LM7PP_J.L2fXE80WV0LbiEKoalF2LS1oLdqgKQshxSLpOQ 7ICAcZ1z5m8TzrgMibdETAM2cqqpu_Imeqa13iBHTkFdzEw3euruPA83dSgLujrob_kpLCKKS2_R 7f07LtIZJlsL4rbppy1qru7kUJe._Bg_yaRJCWcuknjrBNB9Wp4uSN4H0aDroc_sOvT70hkKqWDT z6B1sb3__z9YI.IkB6ZuRB_A9KE8TELYvi4GGP7__4HRyeQX.G1yncpjvqYa5y5X0VqYVbNeCSb2 K9ZfaAfEQpmjq0X.57dK3jXKroFEqmLq_5aMobVWUdKxhP.Lo7gKsRPnIjSeDJrg- X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 03:16:09 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-5klrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a58d17c073f126c8af39d6b130f5d472; Sat, 16 Jul 2022 03:16:02 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> <83bktqs724.fsf@HIDDEN> Date: Sat, 16 Jul 2022 11:15:55 +0800 In-Reply-To: <83bktqs724.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 15 Jul 2022 18:56:51 +0300") Message-ID: <878rotlpck.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 327 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > No, that's wrong: we call update_single_window there, and that > requires a window with a desired matrix set up correctly. So yes, the > call to try_window is still needed. Indeed. So would you prefer an assertion in try_window, or a call to adjust_frame_glyphs if it fails? Thanks.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 03:15:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 23:15:18 2022 Received: from localhost ([127.0.0.1]:42612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCYGz-00056o-Ue for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 23:15:18 -0400 Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:43420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCYGv-00056S-Fi for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 23:15:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657941307; bh=H/5lLZNaE8RK5L5NQ2EI3GVr8Z49sfrGQN7dSHgqzi4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=NqvD/5lgHVFmZm0wRYRGAPFbqtvqioW96iAuGsLdOFvVHLgj2Wv//SLWCmZC4n3/RewnnHRtycEm4A9Q3Ah9xbnkqHLf6kUS1sSUIsriF8I44wdGPxljf9/snwj7A46Uhn+EslOh2GlGQ5LQwfFUFH0aNXrHFmcHqd/bNF8Oz/0lbA0l4vrqq0vGojUB+/bCYl3sT5S/R5Y5V/3AbsW9+5SgQBf7vchUcGGrZ6btTijQnawUJ3rxGu9adzsjFbJxGOPv/ZqyY1L0Jn3dVClPsMxc0d5NJ5bB4HRmnubTqUcxjUaEO3n21vALwg98canET7L73yIdcWBmFJqocz0NBw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657941307; bh=jHEqdiQMn08ZSjE6mLeUoABfvldZtCe5tiVRV0FxZ0b=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=e//q+Zb5/bEiMLFdcda35jBbpX0An8ugqB3goJr0sabekKFouOMJhbch8DNjVZAmDsRBvhNneF8m6OFPg7AVVMn51C+eXEnNKxe4jduDq9KKrWlmZn0PHSYqrG+EUMiy6O6Ww0EFTL/ylyaIy8PU4vUo66u8Tlz9Ct0KfuBKa8AilpvT1K+tCjMDzUWI/aRANPLDAmNAJ30LYFD/eX/vo7/MhsuNRPfu/SNJPO8U4u5nx5Nb8E4MwWyUZMOGSD//Xee+YnXq4uAXk5ynw5ThdJRYzpZ/U+237ayb6/hepyToX47hhMmG0pazi9Y+KVV7Tp/DtE33YbvgI5knWJZFJQ== X-YMail-OSG: 7siKJO8VM1l4jRxd.07b3L5Et2B6UIGdayewFJUf2D7sNBqN5nrpXVI9ZvjSwTA rxF9VGUvq7S0v1DBz1nTX4Usn15jw_YsAohtvZgAdlFs3VI.XLFnxB3CpqUFHIKNtUTYIFOy0fuV JedyXfNtR6Uh4TII7DMVlw.2gLUtz3JVjBaHUbFT5eQdapwQvSteK6eeYsOlonA94rM.6Evcg0cw uY3Y4jKdHebBct3_aNDOgfdOooWsa0jzSshdhG1sGixHiE9zlcEZf_sEjXQUQ3Wm2_9YK400jfkL 4dRtXkmhlEUnj14nh.NjOL0vIa0wgWGu76mzJtOPWtRz3Tsyw26L98Mwd9t0ithYmJvMI_A3x7_h R3d8wze9rQst5.bAWYZRtePYunnAhMTY.8BqakgsHhAAZb7fj9enVH7TCKb.lhcPjtTviEWGDOye f1YhqmGYaU.cYbqXZW08rxNJHnpXL7sQ0q.yQ4iRj0eBeOS8qbx3gZEnr5pwJwjmFwa.xx5doiFa P1lpLDsW0ydjRBtJQ6lYYFqWR12k03n98VvhdIhcEmKTYjW3gsN5Cj3Tma4yxSFg9k8ps6IHnCXy rOKUcUnpDjC5Zzgb3j92lRPvSXztNyOwviMYji6nrOwkWdNpDb8Ma4RWUK5txJIp3zqoQyOWobh6 gv9XDI3oRHYXD1D_U6L2bz.RLqEJp.V6z.FjVfn4ti9EHBw8u0Yfnp2pCAQ4wkY4zstqGF2S.Y6e tmfkVR8fqFVSfVrL7QwOTacrYfsXFsr24UBmteleIbqcGh4m.ob4Q9.tqbHC8.cTkJ.XGk8hXmtd Ox7lfD3PXa4dAkaZDmaafvw.qxGtD1ouPMBxMUYEGvUWM8vfv2_O.b4T.ep5UWGX5U_gO883TjOE BC8PlR0A9RbmBKOaB3wRRslIObKvogCUEHFV6zG2G6Cpz4_nERlbqXW1Hz8gljh90FyX1nfk5iqI Qtfaur4XSrOjR18BzciJlCYaTsd_mHcRkjnpbqVk4y9aMY5lePlGieGFFb712xrrkZRw0.j1M0a8 5XQLU2jhbO44Mteh8KB4fnfKUuSegrVdzz5CkoIxXzOS5pWPB61YMSbCgAryGqz9iAutX3UHtfXi BpE40xusJemp_Xjj0bcR0b7IsYjp5UvmeEOx1WzqprzXh7hajPu3MCOYjMTSxXedgoBIvR564lXO 2wMohsxpvDNX4WFenSSOjET7ysrCTHnApylozYZ4fbf.ssX3aZgR51iMrb.nKFKghs4QvciahMPH XVACh.jDKr_6kl3jmBzsYelYR_f02qU.IeNtZMT30o0DG0S2uoQbPo1VLtSFGhE302IlZ1suUTOw DSwNmk_H_M.f61uR5AXiTXz.yJx68QJ8jxhIFKKMdcRmlz.omTEtEvY0Mi2LXY0X3UKe7oUUb5fk 7Z1yVfS_HSOi1tj8oSk4MZ7UTEaX0PYhXqCQpA3zGOc4xX.hsrpTlFqhrvyavfs6VWt8kgrYtFyP Fa5WXFgub1VxdZq7IvrZNc.jeljOkGYyUBn2sF2H_huw_R7jJ.V4SBm7n6AAX1.GYS9BPprfxn6V wyuf8bvkkMcNTsKIkE32W50yvQr85NE_RlW.oFHO7iKwTPslul_8WR9zWiuRxD1FJGLXGVNp8cGE 99QR_4Zj9iDgQefrI_rlzx7gmyNUaMfG_NqRSD4r4nrR7jxKSVULvWrbvjBoAcWjMsTcyqSs.sKm DpsXUd72bx1bq2LOSzfmmsIEo38V9xJdDF6KwNPg3ws2tzwLIC2_iXyhV35T48IcBraSAT.2ly.f G0z2A0xmJcGrvATiqzUcE8oS5_i_9foaYSj6jaFCrvI4iDzP7Hz_jUCxZfqaKWyl2PLhCsdKwyzM Gk1Lpkp5ONZnl9UdrwFyINhEvgJYtdc_KYZOYb_4VxqGcNgxir.YCvwf7nr3MyxV.A2tkSgfVngH EEL7smd5xClOUizxRYoRTyfGeA1MNxzlZulxjNeQ2d_MTyHzOmBRiI_09vrPS2CsvQ5YMZo289SU CACEJUJwmC2cecw1RG5VeV7hYSO49XRiAUmO2d8ls1gTYAfZB2enl6MaGuAOMpTkI7631rpRolsD AoS0F5CArmODlC4tNvkLBt7xHb3sNHPwQ92RMhkczG08V7M19rF_8q06mTdahdzxaZn7ji6QBeyE 3dC6F52H.p7_HgTSRGT1wAB1yQk5RxTK0GYsxkzOpkV4gHRXPWs0GWEtcvyAF5EXT81m6kAWYGyO vD2Vv7XCXrwUP113PSLarBEBKavFJP2mVqcuJI93UPK8q8IMdcNfZn.OyBT5VHl0- X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 03:15:07 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-wpvcf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cf9ddd0dcb0bb92f188cb45a714a8c44; Sat, 16 Jul 2022 03:15:04 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> Date: Sat, 16 Jul 2022 11:14:57 +0800 In-Reply-To: <83cze6s7xt.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 15 Jul 2022 18:37:50 +0300") Message-ID: <87cze5lpe6.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1005 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > On third thought, why do we even call try_window there? The original > code needed try_window because it then used the glyph matrix it > produces to calculate the size of the tooltip. But we've dumped that > code, and we nowadays use window-text-pixel-size instead, which > emulates the display internally anyway. So I think we should simply > delete the call to try_window from x-show-tip, and be done. At least > on master. That leads to blank tooltips inside popup menus. Here is the vital code in this case: clear_glyph_matrix (w->desired_matrix); clear_glyph_matrix (w->current_matrix); SET_TEXT_POS (pos, BEGV, BEGV_BYTE); try_window (window, pos, TRY_WINDOW_IGNORE_FONTS_CHANGE); [...] w->must_be_updated_p = true; update_single_window (w); flush_frame (tip_f); Otherwise, the contents of the tooltip will not be visible by the time the tooltip is displayed, and will not be generated, as redisplay cannot happen inside a popup menu.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 03:12:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 23:12:12 2022 Received: from localhost ([127.0.0.1]:42606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCYE0-00051p-BT for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 23:12:12 -0400 Received: from sonic316-21.consmr.mail.ne1.yahoo.com ([66.163.187.147]:38506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCYDy-00051X-Cf for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 23:12:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657941124; bh=honoJA0I28V3/Wh+xUthIS1yHX4uCItlMEvgkTfp37Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=CjL5J0ItTFEWPSErX+2fMyxbjZa355u5hR5EK+3IAnlleqZ2poLMwJHMVLqZF9fkJ4eTalSHj9xdJDwa5axez2o9Yvd+OSb1c33xp270dooe2ktWvR8JP8jLPEznsamqRLskimUsHuxKgxlondKOcVR7f0IGV2PErHT8yl8Xd/AzGttS/vXgcG5G8cE5/h/J19UJFOCPDrSQTYBvIcR1/0iwzHKnOF6avJmAQSN0w1jzQdskqM5fd2iBurZBH9BHpcDKXl4mKWKzGf3+TuKWf6l/cIioCtOPUW8aLoRMogFIgrnQFG8Ucx3VDLjtumpvf4Sh/tuX2UAhfw2oEhmOcg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657941124; bh=Bt1oE9pg5g191HwteFIVyODZ/ulUgosT5I8VlWRrEeD=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=EYfLA62Ozggvzoaramb5RU234FhrpKz8AnaFk1GrL4Gq7hb6iIyDi4rY8pGU8l/oCuSv65exBEykFkyvqYnw4u2CyoubGyOsmfLJBAFkMfv2IUm0hT1BXWu40Ce5JFpkgVzewWglaqon15A6nsX8EKf6jAJFFmGa3YAu3E0Vplmw87zAciD5LLu94nhrNAwkaCR2raUIBEzLAM72kMHwxP4FZ0uMrQNVKx7Zp2exzx1X8gde2IFClt6z25tRAgUO4rSPYVLbx7u+7R+QiTPvJer5cdQpbLtxGvHOUfTMfad1EbDEN5ta+8/xxPi/kmLc1PM7CZTX3wRZ1dk3Z+9D7w== X-YMail-OSG: X44Y_D4VM1lsb_tkBfOYVFavAol2WSgHwfqFN2IzXaLwdmsF.GTgJh.zqzQj7kP _futQVPBOsOE1qoxalNZAcTUd8_Txe9vyo5jftX3o6lNbr1yarPZwpy7VccO8cqHfStBmcf_pRC8 4lxQWkYnh3c2_vF24RY.jnmkE_T4XdZ0O9jIj0JUa8q3gK4BM.HeEnGOBW5mwwCFnk9GHQyuHLbv 7I8IuaIDDjfVUNq_hHklGfoLtghHuSjRV0jxAgJuTiTSAfWO3sxY2wXzl2pjf3vr0XtHUdSZ9qVR OQxTOcpyUPATILS72VXjyMkGXrGtdkynOS7pw6Kmzd7LG0FZPRIuiYfOMrHDYXAPiyzqFsQ1J4NM mFb1a_aUDrCdt649CQrmIMW7Q_bfDhy_ddfClvq0SsgtbxalxSIeB5MpiGGu6.phrtQ8_tO0_sIp yptnO2E5XqfmDp3giFEkLkqGqdW6YFwCJc_MlGcDl.nMU6GoY5pw2uUCdYwpdoLdxShK1B0QYNuH boFc5EmOwOb9yMF2xwSfm68.rFEuAqPQk9ACLjg1_j.djt9Jcr7rcgIliic9bWnYSoDlGVZcS6VV t2lmDuBVZkNnmfL4h3NJm6T2wnVB4rX5WO.F77kYM4sBl0CXRZP4w68gT1LKlympITDENBi2ZlCk neFgBZVlIinic4tix8PV19OtAkolcqbNbzV_QgdeDCu2cAwNbIjwZy21oADBDJg3DnLwAc.EUyrs mbuG1SAPfuL29Z9oPybDp8yMZbXqp7DgdyJJ9wGL0_toIwAxbFAeQO5SeAn3cT5BiM11LTcH2mja 0QQztCEebRoAmqjwg91nv67iTc8c_ue_FWlsdNHA2lyHQCtltC2rQtAPf7R5SDqh5M9PoCN8dsae rgNCMi_3c9ZF169FJ9.CJVSFJdpi1imPwum2OaNUHr616kDKe9p.a6gR1.Ohs8ETz6OMR7BS4t0s kl8vHIEVCMcn9Zm8d1c6.q8OYXKOCY5k1wDvpHqDtU2GHarNyBIPez8ADEwxazKDohchy_68OFek vYaqho5k51R.o2VfR00xXlmFhbMrCAbaiHWtMgUPdVNKKwu9TqZARWpokV_ynHiCL8A6YxttdHt5 3ZmTy4CkGlG_jMkC8LkcRtz2_hBLv6_NPeQETq8Ko9bfSjtk.ngiKAuXGCu4gprYl6wVrh.Un11E zJ2k9mhaIS119D_s7HK1YEiW_9QO_EiXkpzTSg4rY95CFoX6AWbQVknsUz1rYeUOxhMebwT_Na4i NSSUSjT6T9wzDFIU7qXsLX2IgiHFb6zT3cGad0.GNazGfRuuhlsn1pHKdYYOllwAaIBP4aaFJjv7 .xxznRPbEDwtsD_OVcDwJrTgxY_v8lDiQtbf6H48vxsm_X8jFCv51wXR1dXX4SjTI1YaUK8p9lMR Adj3RZBv0vpsUBlLQsgeYHTbwswtEp2nRmWkumCiYkrOfAVPg_HGN5DgqrSjSIZMK1lpRoCw7Wlt yQzosijjlN6GHIXp0YCn8iUYD3Z88YO5sqRgu3sHv7JraGBY1m1cRoATeALsNALLQMe1g8zpQinR GiESO.XlTTDo.J.FX.VOA5xT0KttBZ1Ds3_HXBECfrEaaFbKDPXrTAJkVFy0TB5knSIjRB5Q9gdI bzzZC0U87Jwoeik.Va90eJK5U5363miCkUoR4aW6ESMfvdA_EnV.6nuBfU3AJcTDnYd0uWxoujh9 JobRfKes_VBPQS9XnC.nx_4MQCvgG7yNeja4Ulmfwr.KYnuF.vBsPKEL5nPjPxuyzJ88QmDLw0ym x2oFeq0cyjKLiwNA.WCra291Mryc71fi.k0NVsnl09yQJGa3CiLaVPnC.NKpKaE1kdB2hxt0puvq 9d1D_TUHjvp3es34GhyPlNowdL7wNGvloQpO77aKk.eiP0qAs3EVLcGdSqXgV51ylu6_q651Edse VxtS3be1SKAkxTZKP6S8WY3eFI.OS1wRvsBsf2mw7xecg45EYYfT1LoGqfKRb X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 03:12:04 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-bp49d (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 373aae2f4a42588c9912e83758f71ee9; Sat, 16 Jul 2022 03:11:57 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> Date: Sat, 16 Jul 2022 11:11:52 +0800 In-Reply-To: <83fsj2s8fg.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 15 Jul 2022 18:27:15 +0300") Message-ID: <87o7xplpjb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1294 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > On second thought, I take this back. I don't see how we could have a > blank tooltip. We call try_window just so we could compute the size > of the text in it, which then allows us to know the size of the > tooltip. The situation where nrows_scale_factor is increased happens > when we get to the bottom of the window, which for a tooltip means we > already laid out all the text and are just producing empty glyph rows > beyond the end of the text. ncols_scale_factor could theoretically > happen before we reach the end of the text, but I'd like to see > something like that happening before I believe it; and even if it does > happen in the very first line, the tooltip will not be empty, just > truncated. No, we call try_window to generate the window contents, and then call update_single_window followed by flush_frame to immediately flush the contents to display. This is because redisplay actually cannot run by itself in some cases where we do want tooltips to be displayed. > We could add an assertion to verify that try_window gets to ZV in this > case before it returns, if we want to be able to detect those cases. This could still work. I think `TRY_WINDOW_IGNORE_FONTS_CHANGE' means the caller isn't ready for try_window to fail.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 03:07:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 23:07:54 2022 Received: from localhost ([127.0.0.1]:42601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCY9p-0004uH-Me for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 23:07:53 -0400 Received: from sonic308-10.consmr.mail.ne1.yahoo.com ([66.163.187.33]:37972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCY9o-0004u2-5s for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 23:07:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657940865; bh=jPN5H8iOZ6THqPbK798e4LEMVRf2LFS4wBQAJHfVb9A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=r4zNH/DhbM5QsBdJBjJCO87PUSRhre0mVsJwubSuaak5bDGaszJZAm55smSBc1tHBBLY7drYA8jDoErIeZ0TuMRQtMLgbp9k6/py3xnlm2gl4L8VeCJnZQazLDzAOhO/GnDp8IvWoHY2c0PjK2wKI5PHaK3qjmJRh7cjuBaT5B8Nzq4daGfBJndsucf060GD5HfFtBWyWaUJUeYl+DgJKEgU7EA/dc1XrAwC5FNot8d/hYjmbT1Q5f3Q75TX/pqSjgiJQ+RS/HDdmZEdDE10RgToe3p5wrc0sJclSL5leEx66NkiAZaq5GamwZIGoSEEsaHdF3pO4I9y/4csO/RLaQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657940866; bh=xyXhu8brpx0oZ7Fhcq5Y+Z94ZmWaCaxfJl2LLVT9fUU=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=uavZ1GH4L7giViIdvHMneKRHHzcqXy4OTmDiUWcLBcinG6rvapFRi1qL42Foushn5PadEDzhWs2W6fr3u58bMr5AfXjBpTGXi2TrW409uDMkE2li8MRHgL6UyOLk7xU1CCCCkbDmA32VA/PdlYpXx3fpnCMWgWUqcD1aG6IcveTqNt010Q4KVI5EAzfZqcDf2jPU3Pzlz/2e3ea4eKDgJL8rhI30IV9dmDT1Em+BGOe2xCh3vn97zKShs4TG1zRIi4QFMDuMs1PUJuboFyAvMh7JgjzauAyPPUK70jtVM8s+BpwINYBNFO+k8M7+UKsR5VIemEiCzaVIvBkXpYcIRg== X-YMail-OSG: FthYQBMVM1k3l6Iz9R1whXHc_qQmhjA7_FPZ1C.KSqn04NQWVhIm_p7P2eoAFhn eSvXLLEMAWruYRotT9vOAj2nHZI31PbFMlHQPM2JNV8DCu6lshxI0c96MP9zPe4V0Ttu7ZFCw5u_ LW9J2wHQLvQUfdPU7XYX.QongTvotYp6FcXOrguGfPZWfAyF4SEORY4HJM_j2AP8zVpZw8wMeNp1 kb85MYQTVAdomGLDHLWCwvoAEY7hBQ24c98W62bonYHES57OzhHFVlOZk0n6cSsN.7z0BzQjLA29 aznjVLHzayhRDcGl5dD1NwLB5NNJSd3AEknSqJbeGDN2gA0dStAdwc.PF9hw77s4t8v8_.df.cO2 sdwHUfS1SAi7XDtdTl3_7I.6fKdOMJ7PRSq9bsv3SpwAGZ.qpQi6Reml1P3CtD4AGGCz3TQTiimU Wv_cvj.BQlXMIdmqbKYptunVrldIBANxPgY2SFiMDS.8.ogRw9YUkhULuVj06f3.Kbwh.d3q774n TJkgB9Z0BKTbAuRSC7LsbD4ZzErOqT5P53q_AQb6c0jQ4t6FfBX9cpXvU8ZnQiGe8Q1XPhYmnLgl dbP_l.ejopNAPLe5QDSDehWvQycm8f4yCzaY8zEAmlAVv02RR9QFlQThHDFz9fiFTWODK3QRprNA XJk73FW42P5nFRJAIyG5It2pcSyka89eWlDAREGaSGN0OYUwRoidK5wp50XUSSL2G78nSE9FeYSr 8aR_5ePuLxDU87KyS4MFzw5uMG_CeXHAZF.JjUGdlwilWM2y.SP.Sf4EWSV9SImJlpyv1ohp9JV3 yI7h7HHhi_DwYwrwO_iaM4pQnAEl.cWlObvBuL_EiA8hSE1zxlEl6JUND03HtLzp5VCJIWZNtytM Ia981K_LBEaMghgHQFGintuaUT1WX.62NhgUmmUNr1HH8sDbQ5ysMAPMNpNMmvolPppHsHg6.Pmn io3l1h4eWR6RNtB60poAtWHqyV6rnc_ollYRt_1DJkWfd_E0jeNLX_UQNZSIeQOXT2ltSupA7kl4 fhJL7vD8U6zTDFNcuymY2jRqyYaeAEIzricHiBffoAs5NLypKV9tSRmyVeVs4_qNugXdvHoSfCsi qycBnwEN71f.G_bjPgUS9DB58rVn_TRIUsFL0wZK35zKQDq684OU9cYGCICOrYkzxHP83YCPEn2p aortQOwrrxrUvIm4Y5NNDoOIXOi8cINBj3XB_XxJp1qI0IH3RHX77gUOyeKLaAzK2uRq8FA703MM ujhR9GUJQFusjEU1sQPFmvnMcZVZU2mfJme.d5zkqong4Y.Y0piDE2C0VLMI5ux2mV0A1gzVgukl hrnX9BD5HwDM7s3y61CM3jvS0TUWI7kkh.l1dHuCDjKuuVAEHPlgzMD_vm8Pwe2YZwD.VeQtnmzV tfmaCT_WsQgU_wv8.ElkREQXjDiexTHycfNj5.TCgAZAXxzZGZ42NwVn89FuwDv8jytHfTHyPO43 hG_wI_jd2Fl1P9hBQQSUrLYTVBL8WlOd5m4XFaXWgQC8dHzYIpD0uBil3nwq1E3Rwjj7DNZx0nan hQto.Lppr23Zsd3IA5e9BWzh.Th85mHP6jwHyj.lMpzfOegxnWoTaxPLc7PBSX64NG5V71dtb4wp DSHdG6Salko20wJbxFoTbUkzWkud6FUr5W8JbvoVyxU1GiJLgZpL9HKH2WpcV.dxrQq7dXjq1kTr ruq7CVDu95Xxo0vpNjxOuetl16W31BPGfWbstRNC6mQCIQsNQoxSYgdHNK4OwuvAMd8cGRPsdkT1 Y7ZGt9xkXUGOBE_m7_1bTPTO67_4o6p9Zs1LbpaEiuLJcu1MTUYnmjezQCUik9MA6jRldlulLr0y hI_Hefo6Wo2hdIiN7KTCHO42GF4BDy2sbp1DkiFUVygzEtHQ7KA0e4ioIEjCgAo5g78t61U3UT.a QZsSU86vS.vdjQzKmAW1MNGemSA9VXqv3xWUTF2Qehz6HH5pxUUaTucft6KH6qNIyoPGOLRncFVt xDeocdCgXFuQJ7oPoyxc04kaOoAeC2DIdVmw5465U67Fih1iHHqRDL.TLFHz.L.gDg9A5S9XUT0M lOYWv94_4.5I8nZsZgJysMDgcR1d9_.thLZphM7HDIR1XNKAvWrt1qL9zr5AK.8Crb7IQhbUM63g CiQH1WxR.FQ0pMHOdJI3hMiAts60KTPwUxd6Cg0nA9C_8._gugSczCDfzwNs9nYVSW9ky2PPWKKY zdyrFhMC8biVXzz7K3fqacP5F_oYxrCssEEH4hx6UkoL5AGJFWFoJHgf2 X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 03:07:45 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-5klrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 65cb7d0c8202d25d25ba0c65ae98599b; Sat, 16 Jul 2022 03:07:39 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> Date: Sat, 16 Jul 2022 11:07:33 +0800 In-Reply-To: <83ilnysbc5.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 15 Jul 2022 17:24:26 +0300") Message-ID: <87wncdlpqi.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 555 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: > You mean, adjust_frame_glyphs, right? I thought that was what I said. > We probably should do that, but my problem is that I cannot reproduce > the original issue: whatever I try, the condition > > it.current_y < it.last_visible_y > > happens before > > MATRIX_ROW_VPOS (row, it->w->desired_matrix) > >= it->w->desired_matrix->nrows > > We need a recipe to trigger the reverse, to be able to test a > solution. I can't find one either, yes. Maybe it has something to do with some installed fonts?
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 15:57:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 11:57:04 2022 Received: from localhost ([127.0.0.1]:42047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCNge-0005Vc-2F for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 11:57:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCNga-0005V6-5P for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 11:57:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCNgU-0004Gi-Ho; Fri, 15 Jul 2022 11:56:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t5KLoMNqHSH6Fhxnk+mVMmnFgMipCGn7qUNlTWWBxZk=; b=GZFs3t2HwmqV KMdiLtD1ROgQjWGYsYj6mXsTUjWsi189QyY5dLogPsT5xpfgE0ycREUrNw4uGZkfIGOJqmNk2I8t+ 8ZhD+V810YDvQwW0BKEQF65uDZ/Viai84Q04hsd+Orj7jl6b2EodIOxq1v3dR3eL0ujSTTXzg+nVY JAlim4i5IY34yLdGnjRpBAEavN+zmoC2CveQhbxM7zU1R7+/mtpYTKYTLlFkYWIioiBhUhTdstHB/ PEGgGtNmFPHhInY54IqkG2NYcW0vYImyqfKg/XHp7tJnWaerupI70mvndFAxJGVYT4Ul/YpIWry9w rzYbqY8Ev0gCvlYd1+IrMQ==; Received: from [87.69.77.57] (port=1298 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCNgU-0006b0-1V; Fri, 15 Jul 2022 11:56:54 -0400 Date: Fri, 15 Jul 2022 18:56:51 +0300 Message-Id: <83bktqs724.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: luangruo@HIDDEN In-Reply-To: <83cze6s7xt.fsf@HIDDEN> (message from Eli Zaretskii on Fri, 15 Jul 2022 18:37:50 +0300) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> <83cze6s7xt.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Fri, 15 Jul 2022 18:37:50 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > On third thought, why do we even call try_window there? The original > code needed try_window because it then used the glyph matrix it > produces to calculate the size of the tooltip. But we've dumped that > code, and we nowadays use window-text-pixel-size instead, which > emulates the display internally anyway. So I think we should simply > delete the call to try_window from x-show-tip, and be done. At least > on master. No, that's wrong: we call update_single_window there, and that requires a window with a desired matrix set up correctly. So yes, the call to try_window is still needed.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 15:38:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 11:38:05 2022 Received: from localhost ([127.0.0.1]:42024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCNOH-00050W-0l for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 11:38:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCNOE-000500-7l for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 11:38:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCNO6-0002ZA-Q1; Fri, 15 Jul 2022 11:37:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=klTnV9YlGaHOoL3x1A55a2190m+2x/3DP4o4C+KSZZo=; b=j4sUDpAWvVaQ eKtgQs6v634qqMdfQt3WpS+vA9yqMPu+gF5mJUNYzYxJwdJyNYHZF++RYouWybzoUE2EchiG+KEM1 WlwhveiHaDvegKlTR5VhRh57ngxzBv7d18AB6tS3g/UR3NfufpSpVACviyW0IT/YGBlypp9HubcNU DJiaLVoQSgk3ur6LZrCwJfitXJxUgz9g6Y+hvGXYX8WabZwAFZJzxEqWIJ+cQoXWBRyPKLuNHcl49 e7To5rLG/H1eDd5mmu89Q1M4AVdClK4omL/tXfGtBhY1mZKALC1kkf0m3e7pj02MNLmqpO+rrVWPr UW8ZzidH4gQOdxB6dgR6TQ==; Received: from [87.69.77.57] (port=4114 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCNO6-0002iN-4W; Fri, 15 Jul 2022 11:37:54 -0400 Date: Fri, 15 Jul 2022 18:37:50 +0300 Message-Id: <83cze6s7xt.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: luangruo@HIDDEN In-Reply-To: <83fsj2s8fg.fsf@HIDDEN> (message from Eli Zaretskii on Fri, 15 Jul 2022 18:27:15 +0300) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> <83fsj2s8fg.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Fri, 15 Jul 2022 18:27:15 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > > Date: Fri, 15 Jul 2022 17:24:26 +0300 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > From: Po Lu <luangruo@HIDDEN> > > > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > > > Date: Fri, 15 Jul 2022 21:54:24 +0800 > > > > > > BTW, I have a question about the fix: redisplay cannot run when a > > > tooltip is displayed as popup menu help-text, so adjust_glyph_matrix and > > > the subsequent try_window call that is required to generate the display > > > contents will not be called in time, leading to a blank tooltip. > > > > > > The call could previously never fail, since the tooltip code specifies > > > TRY_WINDOW_IGNORE_FONTS_CHANGE. > > > > > > Would it be appropriate to call adjust_frame_glyphs and try_window again > > > if this call to try_window in Fx_show_tip fails? > > > > You mean, adjust_frame_glyphs, right? > > > > We probably should do that > > On second thought, I take this back. I don't see how we could have a > blank tooltip. We call try_window just so we could compute the size > of the text in it, which then allows us to know the size of the > tooltip. On third thought, why do we even call try_window there? The original code needed try_window because it then used the glyph matrix it produces to calculate the size of the tooltip. But we've dumped that code, and we nowadays use window-text-pixel-size instead, which emulates the display internally anyway. So I think we should simply delete the call to try_window from x-show-tip, and be done. At least on master.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 15:27:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 11:27:26 2022 Received: from localhost ([127.0.0.1]:42012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCNDy-0004iF-Dx for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 11:27:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCNDw-0004i2-JH for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 11:27:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCNDr-0005NF-8X; Fri, 15 Jul 2022 11:27:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ay4VlCmhdCEMhNJUIGaxKHKL1t0VzbjnnQG84C/rK9I=; b=C9eZHk+33sIu d/MTF3WjRmRLlnN0YnnHhPJOM2bWR/VdCloi7okokttH5G2ASpxuuyDrZhp/z2ZkswnrlAFLhaoNM scCYaACAi3llbM7l2zI31CkOQ2K95bHPzgfmdkcbatqOjM7fRI7OjBN/Xr0D0MrxledynaD/z9jqz bd4qCb5v7Ag7/PuRH1zogDSebRKmA/nA5uEwsWIN+fJFcKkl8QeOGcttzYaqPVajOy2TJbv1wUVkA /B6/PgexZpPh3EHS0WkcTHVdY8wsEdVC994IRT5ordW8mRzUEWkfDmGRrKVm6q6GNdNAGLcrjgF26 ojOPRPUOpx6tSe/vY2FtRQ==; Received: from [87.69.77.57] (port=3461 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCNDq-0006ix-OC; Fri, 15 Jul 2022 11:27:19 -0400 Date: Fri, 15 Jul 2022 18:27:15 +0300 Message-Id: <83fsj2s8fg.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: luangruo@HIDDEN In-Reply-To: <83ilnysbc5.fsf@HIDDEN> (message from Eli Zaretskii on Fri, 15 Jul 2022 17:24:26 +0300) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN> <83ilnysbc5.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > Date: Fri, 15 Jul 2022 17:24:26 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > > From: Po Lu <luangruo@HIDDEN> > > Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org > > Date: Fri, 15 Jul 2022 21:54:24 +0800 > > > > BTW, I have a question about the fix: redisplay cannot run when a > > tooltip is displayed as popup menu help-text, so adjust_glyph_matrix and > > the subsequent try_window call that is required to generate the display > > contents will not be called in time, leading to a blank tooltip. > > > > The call could previously never fail, since the tooltip code specifies > > TRY_WINDOW_IGNORE_FONTS_CHANGE. > > > > Would it be appropriate to call adjust_frame_glyphs and try_window again > > if this call to try_window in Fx_show_tip fails? > > You mean, adjust_frame_glyphs, right? > > We probably should do that On second thought, I take this back. I don't see how we could have a blank tooltip. We call try_window just so we could compute the size of the text in it, which then allows us to know the size of the tooltip. The situation where nrows_scale_factor is increased happens when we get to the bottom of the window, which for a tooltip means we already laid out all the text and are just producing empty glyph rows beyond the end of the text. ncols_scale_factor could theoretically happen before we reach the end of the text, but I'd like to see something like that happening before I believe it; and even if it does happen in the very first line, the tooltip will not be empty, just truncated. So I cannot see how this case could produce an empty tooltip, and I have hard time imagining how it could even produce a truncated text. We could add an assertion to verify that try_window gets to ZV in this case before it returns, if we want to be able to detect those cases. > We need a recipe to trigger the reverse, to be able to test a > solution. That part is still true.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.
Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 14:24:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 10:24:38 2022
Received: from localhost ([127.0.0.1]:41928 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oCMFC-00031s-15
for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 10:24:38 -0400
Received: from eggs.gnu.org ([209.51.188.92]:49064)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1oCMF9-00031d-KM
for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 10:24:36 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:34072)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1oCMF4-0001T1-5M; Fri, 15 Jul 2022 10:24:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=RiRqiD4zeDkuHzJg0ZhCWMw+EsLkqaamYGR+s7uLwmc=; b=ooA4eLa2IiqW
mDlzX/AMVThAUl5D24Ck1gI/EvM5A6bKa32Jgz7ZsCtZX+KUZzHpxzrnzBePQiM9fkeH3wKlTK/1o
E4S3V2yYU4BWx/JudZal4YdnPb7IrT7oO2FWGNGXmvX6WY3MeLZmW1nItKsitcOl9RfiFTlk3tyOJ
r7vZuncMhar7dYr+Id7OkUCyTheRhb3SDZr8rpyMHSEzcHpKjxx1I7WRDldkw+1LhiX1y4D+h1+gO
E8Hp3W5z5Yw7PzhNB61KRWqWCAL5GDfIF9R1MunLs7r3sRS7t92wDEHygzZh6QFEF0/X/s9Ekid6M
LJqEvJg7IJOTfAM2Q/a4ig==;
Received: from [87.69.77.57] (port=3611 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1oCMF3-0002hb-Kl; Fri, 15 Jul 2022 10:24:29 -0400
Date: Fri, 15 Jul 2022 17:24:26 +0300
Message-Id: <83ilnysbc5.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
In-Reply-To: <87lesumqgf.fsf@HIDDEN> (message from Po Lu on Fri, 15 Jul
2022 21:54:24 +0800)
Subject: Re: bug#56561: 29.0.50; Infloop in try_window
References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN>
<878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN>
<83lesusl4w.fsf@HIDDEN> <87lesumqgf.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56561
Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Po Lu <luangruo@HIDDEN>
> Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org
> Date: Fri, 15 Jul 2022 21:54:24 +0800
>
> BTW, I have a question about the fix: redisplay cannot run when a
> tooltip is displayed as popup menu help-text, so adjust_glyph_matrix and
> the subsequent try_window call that is required to generate the display
> contents will not be called in time, leading to a blank tooltip.
>
> The call could previously never fail, since the tooltip code specifies
> TRY_WINDOW_IGNORE_FONTS_CHANGE.
>
> Would it be appropriate to call adjust_frame_glyphs and try_window again
> if this call to try_window in Fx_show_tip fails?
You mean, adjust_frame_glyphs, right?
We probably should do that, but my problem is that I cannot reproduce
the original issue: whatever I try, the condition
it.current_y < it.last_visible_y
happens before
MATRIX_ROW_VPOS (row, it->w->desired_matrix)
>= it->w->desired_matrix->nrows
We need a recipe to trigger the reverse, to be able to test a
solution.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 14:03:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 10:03:44 2022 Received: from localhost ([127.0.0.1]:41873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCLuy-0002TL-1j for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 10:03:44 -0400 Received: from md5i.com ([75.151.244.229]:36062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mwd@HIDDEN>) id 1oCLuw-0002T7-8i for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 10:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nP+G7fnfKeDa7p9/7PF+xAjdRdm/vr/vJMz66BsJTtQ=; b=qcl6lL37gred4OKg0yOMjqrbrC mhzpmnClnJG7FJGbF9hjhS0FzG831delfc6PSDeP6aOLPl/DKjwFFsd57+RncYp3jPNYifxQvjVpW +NeJMjIUFciykZva+0FBcbjEK; Received: from abode ([192.168.177.1] helo=miko) by md5i.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <mwd@HIDDEN>) id 1oCLun-00HU3P-8Y; Fri, 15 Jul 2022 10:03:33 -0400 From: Michael Welsh Duggan <mwd@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window In-Reply-To: <83lesusl4w.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 15 Jul 2022 13:52:47 +0300") References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> Date: Fri, 15 Jul 2022 10:03:32 -0400 Message-ID: <87lesuh3rf.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> Cc: 56561 <at> debbugs.gnu.org >> Date: Fri, 15 Jul 2022 09:14:10 +0300 >> From: Eli Zaretskii <eliz@HIDDEN> >> >> Hmm... so the short tooltip text somehow causes us to exceed the >> number of glyph rows of the matrix? Please tell what the commands >> below show: >> >> (gdb) pgrowx it->w->desired_matrix->rows >> (gdb) pgrowx it->w->desired_matrix->rows+1 >> (gdb) pgrowx it->w->desired_matrix->rows+2 >> (gdb) pgrowx it->w->desired_matrix->rows+3 >> ... >> (gdb) pgrowx it->w->desired_matrix->rows+34 >> >> That is, I want to see the entire contents of the glyph rows. >> >> Also >> >> (gdb) p it->last_visible_x >> (gdb) p it->last_visible_y > > Actually, I think I see the reason. I installed a fix, but I cannot > find a way of triggering the problem, so I cannot be 110% sure this is > fixed. I guess time will tell. Sounds good. I, unfortunately, lost my debug session due to an unrelated window manager problem. I'll certainly let you know if I ever run into this again. -- Michael Welsh Duggan (md5i@HIDDEN)
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 13:54:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 09:54:44 2022 Received: from localhost ([127.0.0.1]:39899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCLmG-0001ia-1j for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 09:54:44 -0400 Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:37009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oCLmE-0001iJ-02 for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 09:54:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657893276; bh=E81QqiFvJACXxL0NXHSNdcakzRmP9zj97zxXAqWuBho=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=RlgjcxoXlHv+KbP1Ldaqx9joDyi6OXa/1Y+DqP5FtH5lYmOpIIL77ioeaJjYvNQbFc/b2PXNUce5E8n5nkL3phuBk5+9tE8j1SoOzlozbmkdPh/ece8pqp/nsi2Hy60hLCmTYKxCWMTFpKHCrcsceFHQXgxryjdH7LLps1HFIxAE3tt0r1r1nM9fOKhPPV8jPEHi00Ldtgpayt9rBtrdTdRxKhgfUNA9CKJ/XgZ70bOzekIjK4ZPiz/URaNBzmIG56w2dcSbXttouLZ5ELxr+1QaWc3S2jotDTOiea+ZyrtD9I1BaWosOVSqNWiWCDcmXuhwThp7TrDV8rclOAlo0w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657893276; bh=6Kcaq8eN9Wa4A3hFyd3L84DinGocS2jC71jEgI3R7o9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=U6pf9wfHIKBGSR4E7ZdDBL5WuJ3wn1tWZbTcwixmpIHArQvenO45pwLIJuLxv+cPYNQ1ZcPXJuRbGINZ1DiQP9r7kHFyrUmmlmNMYI+ZVYYDL81OfB4QOK/mImCCbnadWB6cf8dOMFpu2hKCqQGNqmCbIT8fc69D1Fcup5fFcQIkAQpK56GoizLuFU62nBN9+29DVrho9hWsJEyw8Gfi29LytvkdPg6ttFErj600UlZnGm7EWUW14WlhIWKsID1h6ahJ2eqSTCtACh/MBhlOaDbDIEods4HWUfKjkgKoJDKwwIn4VbivfVdINZZX01TAU53X4J1WPJKI+3zFFzEzOQ== X-YMail-OSG: zecWkSsVM1k4UZ_BC2d.4t2mlHkhiz5Yy94yO2qVOGrYSGLyh2QFd._6HjVoMYh hIKRWcsW5qgEARE0PPfv4aZ5A_V7iRx_vWrR6QlVHHcAdBC.Ew7oMNv8HjjPHHG6v05j.9VpBI18 VsP6GdQg63yrz_Xb6xbj48KgtjwdE_iABoJVLXS2E.YyflSxqWLQg7AjYrj37Goii7ppaKD2O.mq 5jxp10lPPETEqqdOwceoAb7I_Sx7azbAxDwjIMU4_rwNKD5OvImy.5A98QjfuuuusB5Yc1hhsZ_V G5bzbQFd0S1eSi8R1_C1yufZgq8TgxcfLtooOlkyBBfPCIt6UwU0EuGn.jfdsOGYrK5YdKeJ1Gvn vOmRBU9ISwFsV0wOAEC3nFthJFoLSg1Hu9PulWqX5Ui2CpHvlsOndvR1kxVLKxdvkcSuXQuw7RvN QdCcEftimokOKHi7kgU6WJL40v2yoitzCYL_gJAFkYsW1QouCIFuSg_.rAqkDwQeX85Xiqa2xPqB TRTq58xCDTRmq6F0GuVsh4O8vpp6nRQmAYVGZiEfrFWfkYEgjohPmJD111suYFjuxrvvHYhv57tG jREBkckNdiINQCvwqp2G9VeNH3v86EnDEiKj2P57kWuG7YYPUR1YRqLOYrXrtosTgZvBa0ywajJt s.kow3YcIXm3YXIvSW96EBkOlugPBNBvx7q.noYdH4S33Whdy7.ynXjDVjI41sdYrg.FQNyIEn0B _Z7m_8g40o0dZ6z9lE.LvHKBnRYcm.s605bwMsbikC7OIEFH9r3EArZMLmKZ5z8qBEXxS8_evxMV 8asEh_sigFF709JKJJePW76UuUDbq6SeVlAlL0.Z84qGh.Rpe0XZEU0iLnL.I3bkqBLkD.Hgimz5 3jN6URm4o1fyIeiZtmhYZTDBAO2FoZmG2CEaCE3pUHV_3MSqXoV7B7uwTg6mdQ4jpsTO.xTX4ZkP XWxICnD3_YkkD_ZCspPt7YrIdQpsu2Cqb2h8XFj0uG.SZ.piE.rUDCmBlP69QdJ4TfKZGFg4PzBo DmyMqp2FL3s6e1FK5lqdU5sNbac49BRGd9QPDb6frc9RPETjdFnVe_3e6pOA.lRdKlS0v.EkF2De 0W4qSICz4XllspluwYZllc1_UedN3baVCAdXSZSbH5uh.fJpTtu1DmN5vUf5sbSeqRQPSLGbX4TS tSfmW.lg1eWCQR.rOy4QYsfbd48hWE.HcRVjGRbhnwtT2kehgSXkgBGhjDl7uxSvIHETrsMZOGcJ _j4arRAmKnhaprnYHGLP2jAR4n1eK2PYtD6bgHCQrjBjqkjqM2SqmDHUS3gLJi29jMlmEjtQn9iD pxaMJYbZsplmrUHmhjkLhJLlKnA5t2N0tB0Kf7DoNSPI_WnIxkkf.xX3pcoWPpNa2Awit2zXGfRC b73Z2qSzJA1CCrcUSV0Fyj2nfqM3PfZuR71zrUl1G6BvjQkxGrYtlPFm0TjxcAEyXvKmWryXIeFr Kqlo1zB3XXmwjeVTkOYBRmpMzx8nZVOLGtDc_CbC9DJTqTP3qn1Aa9ka2k0tn9H3GxOM6TKrsGp4 Dj7VlrQl.TqkahG44lXx06M_jekoq2yB3so67vFGszbF5bG0VcQv6dH.2kFaGm7zjB.2drBJCtdv rSLiSJlf.jG78jOt4fV21gNqTnvIM1QVneR3kpTUXXIXvkZj_Ye5dWcdENJgQsjibpvWsOdLV546 NVluJgqBI5s6.5ZKOGOHM7uXjA3MvrHll42v4Rb5fOALS11bL1s.g2GBmgPMI8EybQG0HhvBPyhe OeFyxvfCNlllyPl5uJFF2udT.zm3ZObCkfwzORcNGzEXxvB2ORB_ruQtaRRMdS41W_lZvTLWKIzk BmyzjK3gEqjAKtJg_3cFv4E9HPeVtoqY72nfDGAOtVDaH9ruT7O6WZuEMm5dafpUaLqE.6MlxSRm DAFzt7LVdk4_RSUhEaq4UENXsM6FPInSKe8I.Z5g6Tzfxvn5HWDZZcj4UFFx4xKhW.BIshK1xU4x mMC0g4JR7YjT9vGpgSw5Rh6unDVXRQMNdPUK8xE7YbcCmX6F6M1Dq1YMZWURqlB0VH2Xjjhpkhyq 2lccMkMZfN4f4dfhYDDm58j2oGeH.7XeCjTfkpkcrZEHpyumCtZexUMXgSMiNH8SOT.ZOJoY4CH6 F7Ca5qYZeu2Uq2o0wGBIuAJf8IvKf9NN5mByOrzvdjEsmekIhEqJ4UkRGPlP36EGImz4XwO5_BjP dZMpyKZNRocct3g5nMujXTvMwYYrQsSPaSMH4SKw9ZJUuFQuRjZk69sknzAkRLXd7nxU- X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Fri, 15 Jul 2022 13:54:36 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-wpvcf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8190c8d2ac3cb1443d0954d50284a9a8; Fri, 15 Jul 2022 13:54:31 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> <83lesusl4w.fsf@HIDDEN> Date: Fri, 15 Jul 2022 21:54:24 +0800 In-Reply-To: <83lesusl4w.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 15 Jul 2022 13:52:47 +0300") Message-ID: <87lesumqgf.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 2073 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56561 Cc: mwd@HIDDEN, 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> Cc: 56561 <at> debbugs.gnu.org >> Date: Fri, 15 Jul 2022 09:14:10 +0300 >> From: Eli Zaretskii <eliz@HIDDEN> >> >> Hmm... so the short tooltip text somehow causes us to exceed the >> number of glyph rows of the matrix? Please tell what the commands >> below show: >> >> (gdb) pgrowx it->w->desired_matrix->rows >> (gdb) pgrowx it->w->desired_matrix->rows+1 >> (gdb) pgrowx it->w->desired_matrix->rows+2 >> (gdb) pgrowx it->w->desired_matrix->rows+3 >> ... >> (gdb) pgrowx it->w->desired_matrix->rows+34 >> >> That is, I want to see the entire contents of the glyph rows. >> >> Also >> >> (gdb) p it->last_visible_x >> (gdb) p it->last_visible_y > > Actually, I think I see the reason. I installed a fix, but I cannot > find a way of triggering the problem, so I cannot be 110% sure this is > fixed. I guess time will tell. BTW, I have a question about the fix: redisplay cannot run when a tooltip is displayed as popup menu help-text, so adjust_glyph_matrix and the subsequent try_window call that is required to generate the display contents will not be called in time, leading to a blank tooltip. The call could previously never fail, since the tooltip code specifies TRY_WINDOW_IGNORE_FONTS_CHANGE. Would it be appropriate to call adjust_frame_glyphs and try_window again if this call to try_window in Fx_show_tip fails? specpdl_ref count_1 = SPECPDL_INDEX (); old_buffer = current_buffer; set_buffer_internal_1 (XBUFFER (w->contents)); bset_truncate_lines (current_buffer, Qnil); specbind (Qinhibit_read_only, Qt); specbind (Qinhibit_modification_hooks, Qt); specbind (Qinhibit_point_motion_hooks, Qt); Ferase_buffer (); Finsert (1, &string); clear_glyph_matrix (w->desired_matrix); clear_glyph_matrix (w->current_matrix); SET_TEXT_POS (pos, BEGV, BEGV_BYTE); ->try_window (window, pos, TRY_WINDOW_IGNORE_FONTS_CHANGE); /* Calculate size of tooltip window. */ size = Fwindow_text_pixel_size (window, Qnil, Qnil, Qnil, make_fixnum (w->pixel_height), Qnil, Qnil); Thanks.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 10:53:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 06:53:01 2022 Received: from localhost ([127.0.0.1]:39628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oCIwP-0002wR-11 for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 06:53:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oCIwL-0002wB-8a for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 06:52:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCIwG-0006yo-1I; Fri, 15 Jul 2022 06:52:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XwWwlg/f5DMmPX39Astvv4vOoh4kuwAWdF5WFmwicsE=; b=pFgm+fRHdxgH kiMRAQEf5j1UOP4urVj8wwJ7WwAuLb3Y0q1wyTFJnm+UQ0ESBgtTsbIIq+QJCup5psnAANzB8S7Pi POenyQ02+NnS0TcxPmsgtoGUdQov6gV+ID6sEYvUgG5Lgj7nlCeimhD4cTe9P1cFLcqCnuSSUKZxq WwE+1zcibsP31KjeWWSpDEm+HPSF4X6NkGDm2XuMtqqsuXVuDjiPnl50pHkBHhirTlvfAx4QP+8xQ vsTwVfLwzIzp6LcPTPBLkBrQt6+K/M11RT4SOCq1N4XyhaKy4SguPfHkIlYVXAdwYsgpJJGXkOH78 VLb9PHSAfuf6M2cRBTguWg==; Received: from [87.69.77.57] (port=4925 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oCIwF-0004Vs-Am; Fri, 15 Jul 2022 06:52:51 -0400 Date: Fri, 15 Jul 2022 13:52:47 +0300 Message-Id: <83lesusl4w.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: mwd@HIDDEN In-Reply-To: <83sfn2sy19.fsf@HIDDEN> (message from Eli Zaretskii on Fri, 15 Jul 2022 09:14:10 +0300) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN> <878rovxqjo.fsf@HIDDEN> <83sfn2sy19.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 56561 <at> debbugs.gnu.org > Date: Fri, 15 Jul 2022 09:14:10 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Hmm... so the short tooltip text somehow causes us to exceed the > number of glyph rows of the matrix? Please tell what the commands > below show: > > (gdb) pgrowx it->w->desired_matrix->rows > (gdb) pgrowx it->w->desired_matrix->rows+1 > (gdb) pgrowx it->w->desired_matrix->rows+2 > (gdb) pgrowx it->w->desired_matrix->rows+3 > ... > (gdb) pgrowx it->w->desired_matrix->rows+34 > > That is, I want to see the entire contents of the glyph rows. > > Also > > (gdb) p it->last_visible_x > (gdb) p it->last_visible_y Actually, I think I see the reason. I installed a fix, but I cannot find a way of triggering the problem, so I cannot be 110% sure this is fixed. I guess time will tell. Thanks.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.
Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 06:14:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 15 02:14:31 2022
Received: from localhost ([127.0.0.1]:39258 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oCEas-0003Q7-Os
for submit <at> debbugs.gnu.org; Fri, 15 Jul 2022 02:14:31 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60998)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1oCEan-0003Pr-Qz
for 56561 <at> debbugs.gnu.org; Fri, 15 Jul 2022 02:14:29 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:57584)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1oCEah-0001Sg-7e; Fri, 15 Jul 2022 02:14:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=uOb+j73by7eEhqi94DiHHt1+rB9ysJk4NT0gbbvTn9s=; b=OoStq64Fy/TB
81QVd7WZcNw0tmc6qGx+0s//LXBcIALU1JX8P62Ijvpa17xF2unE54Yp4U8F40aIsb9wbsNRZE3P/
IoibckkqKBSMhOG62/J08oh+9esnn9qrK1C8u0LGGdhbEx9aiZtH/33/Fem1/AdRlK9C9b6+oZhUf
Fxqiy27wF+iboQICoaJyA8av2vG8tfysGafrOi0p7yOpkuk3GyWoxcPddS1pxsCFAJlnvOp+Wd4ED
AUrEkY5sonDjB+q76RB1VlJknx2wsCTh9sfKxz67bN70x0ROpnZRU7V7IqvvXiPkvHmKL5zkYOkgE
ffTeW1IrX/iQrc4oMNy5xg==;
Received: from [87.69.77.57] (port=3363 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1oCEad-0005tk-Ey; Fri, 15 Jul 2022 02:14:17 -0400
Date: Fri, 15 Jul 2022 09:14:10 +0300
Message-Id: <83sfn2sy19.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Michael Welsh Duggan <mwd@HIDDEN>
In-Reply-To: <878rovxqjo.fsf@HIDDEN> (message from Michael Welsh Duggan on
Thu, 14 Jul 2022 18:44:43 -0400)
Subject: Re: bug#56561: 29.0.50; Infloop in try_window
References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN>
<878rovxqjo.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56561
Cc: 56561 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Michael Welsh Duggan <mwd@HIDDEN>
> Cc: 56561 <at> debbugs.gnu.org
> Date: Thu, 14 Jul 2022 18:44:43 -0400
>
> Moving my cursor between frames and either clicking or typing C-p, I
> think. The emacs was on a remote machine at the time, visible via X11
> over ssh. This may have slowed X events enough for some corner
> condition to be achieved.
All I see is that Emacs tried to display a tooltip.
> (gdb) p current_thread->m_current_buffer->text->beg
> $15 = (unsigned char *) 0x555557bb75a0 "mouse-2: correct word at point"
> (gdb) p it->current
> $16 = {
> pos = {
> charpos = 31,
> bytepos = 31
> },
> overlay_string_index = -1,
> string_pos = {
> charpos = -1,
> bytepos = -1
> },
> dpvec_index = -1
> }
> (gdb) p it->w->desired_matrix->nrows
> $17 = 35
>
> (gdb) p MATRIX_ROW_VPOS(row, it->w->desired_matrix)
> No symbol "MATRIX_ROW_VPOS" in current context.
> (gdb) p row - it->w->desired_matrix->rows
> $18 = 35
Hmm... so the short tooltip text somehow causes us to exceed the
number of glyph rows of the matrix? Please tell what the commands
below show:
(gdb) pgrowx it->w->desired_matrix->rows
(gdb) pgrowx it->w->desired_matrix->rows+1
(gdb) pgrowx it->w->desired_matrix->rows+2
(gdb) pgrowx it->w->desired_matrix->rows+3
...
(gdb) pgrowx it->w->desired_matrix->rows+34
That is, I want to see the entire contents of the glyph rows.
Also
(gdb) p it->last_visible_x
(gdb) p it->last_visible_y
Thanks.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.
Received: (at 56561) by debbugs.gnu.org; 14 Jul 2022 22:44:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 14 18:44:55 2022
Received: from localhost ([127.0.0.1]:39045 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oC7Zm-00005G-T5
for submit <at> debbugs.gnu.org; Thu, 14 Jul 2022 18:44:55 -0400
Received: from md5i.com ([75.151.244.229]:36060)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mwd@HIDDEN>) id 1oC7Zi-00004w-6C
for 56561 <at> debbugs.gnu.org; Thu, 14 Jul 2022 18:44:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com;
s=dkim; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=9iKBpLQG/Z7GB1BkQo0AlJ2tzNW2q2jCPR2EAtn0hnE=; b=IxtzXLshyOQmHAA5nd7j16eB7P
Yz66ceNS/qqHxTKGYgtufkleFeTj3Su0KMIUZrHNvKWMb/06jVif5s8gXMhlYCpYUnWSc9Fj65eaI
Bh4jPT5Ase5oy4RusLudnwoj2;
Received: from abode ([192.168.177.1] helo=miko)
by md5i.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.95) (envelope-from <mwd@HIDDEN>) id 1oC7Zb-00HRam-Eb;
Thu, 14 Jul 2022 18:44:43 -0400
From: Michael Welsh Duggan <mwd@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#56561: 29.0.50; Infloop in try_window
In-Reply-To: <83v8rzsdd1.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 14 Jul
2022 22:28:26 +0300")
References: <874jzjwmhn.fsf@HIDDEN> <83v8rzsdd1.fsf@HIDDEN>
Date: Thu, 14 Jul 2022 18:44:43 -0400
Message-ID: <878rovxqjo.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 56561
Cc: 56561 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Michael Welsh Duggan <md5i@HIDDEN>
>> Date: Thu, 14 Jul 2022 14:57:40 -0400
>>
>> I've connected to this in gdb. `try_window' is calling `display_line'
>> in a loop until the iterator hits a certain point. But `display_line',
>> in this case, isn't modifying the iterator, so the loop never ends.
>> Here follows part of the debugging session demonstrating this. I'll
>> keep this gdb session alive for a while.
>
> I need to see what's in the buffer and some other variables. These
> are for the call-stack frame inside display_line:
>
> (gdb) p current_buffer->text->beg
> (gdb) p it->current
> (gdb) p it->w->desired_matrix->nrows
> (gdb) p MATRIX_ROW_VPOS(row, it->w->desired_matrix)
> (gdb) thread apply all bt
> (gdb) xbacktrace
>
> And finally, any idea what you were doing when this happened?
Moving my cursor between frames and either clicking or typing C-p, I
think. The emacs was on a remote machine at the time, visible via X11
over ssh. This may have slowed X events enough for some corner
condition to be achieved.
(gdb) p current_thread->m_current_buffer->text->beg
$15 = (unsigned char *) 0x555557bb75a0 "mouse-2: correct word at point"
(gdb) p it->current
$16 = {
pos = {
charpos = 31,
bytepos = 31
},
overlay_string_index = -1,
string_pos = {
charpos = -1,
bytepos = -1
},
dpvec_index = -1
}
(gdb) p it->w->desired_matrix->nrows
$17 = 35
(gdb) p MATRIX_ROW_VPOS(row, it->w->desired_matrix)
No symbol "MATRIX_ROW_VPOS" in current context.
(gdb) p row - it->w->desired_matrix->rows
$18 = 35
Thread 4 (Thread 0x7fffe7fff640 (LWP 1400080) "gdbus"):
#0 0x00007ffff3cb487f in __GI___poll (fds=0x7ffff6b0f4e0, nfds=140737331255742, timeout=32767) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x00007fffe0016990 in ()
#2 0x00007fffe0016990 in ()
#3 0x0000000000000002 in ()
#4 0xffffffff00000001 in ()
#5 0x00007fffe0014ca0 in ()
#6 0x00007ffff6a2e1ee in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7 0x00007ffff6a2e543 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#8 0x00007ffff6cc3cf6 in () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
#9 0x00007fffe0002de0 in ()
#10 0x00007ffff6a5859d in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#11 0x00007ffff61a6d80 in start_thread (arg=0x7fffe7fff640) at pthread_create.c:481
#12 0x00007ffff3cc076f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
#13 0x0000000000000000 in ()
Lisp Backtrace:
"x-show-tip" (0xffffcdb0)
"tooltip-show" (0xffffced8)
"tooltip-help-tips" (0xffffd038)
"tooltip-timeout" (0xffffd278)
"apply" (0xffffd270)
"timer-event-handler" (0xffffd3f8)
Thread 3 (Thread 0x7fffece4a640 (LWP 1400079) "dconf worker"):
#0 0x00007ffff3cb487f in __GI___poll (fds=0x7ffff6b0f4e0, nfds=140737331255742, timeout=32767) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x00005555573d6900 in ()
#2 0x00005555573d6900 in ()
#3 0x0000000000000001 in ()
#4 0xffffffff00000001 in ()
#5 0x00005555573d6810 in ()
#6 0x00007ffff6a2e1ee in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7 0x00007ffff6a2e30f in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#8 0x00007fffeceab3bd in () at /usr/lib/x86_64-linux-gnu/gio/modules/libdconfsettings.so
#9 0x00007ffff6a5859d in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#10 0x00007ffff61a6d80 in start_thread (arg=0x7fffece4a640) at pthread_create.c:481
#11 0x00007ffff3cc076f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
#12 0x0000000000000000 in ()
Lisp Backtrace:
"x-show-tip" (0xffffcdb0)
"tooltip-show" (0xffffced8)
"tooltip-help-tips" (0xffffd038)
"tooltip-timeout" (0xffffd278)
"apply" (0xffffd270)
"timer-event-handler" (0xffffd3f8)
Thread 2 (Thread 0x7fffee6ca640 (LWP 1399543) "gmain"):
#0 0x00007ffff3cb487f in __GI___poll (fds=0x7ffff6b0f4e0, nfds=140737331255742, timeout=0) at ../sysdeps/unix/sysv/linux/poll.c:29
#1 0x0000555555ccf0d0 in ()
#2 0x0000555555ccf0d0 in ()
#3 0x0000000000000001 in ()
#4 0xffffffff00000001 in ()
#5 0x0000555555edd870 in ()
#6 0x00007ffff6a2e1ee in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7 0x00007ffff6a2e30f in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#8 0x00007ffff6a2e361 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#9 0x00007ffff6a5859d in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#10 0x00007ffff61a6d80 in start_thread (arg=0x7fffee6ca640) at pthread_create.c:481
#11 0x00007ffff3cc076f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
#12 0x0000000000000000 in ()
Lisp Backtrace:
"x-show-tip" (0xffffcdb0)
"tooltip-show" (0xffffced8)
"tooltip-help-tips" (0xffffd038)
"tooltip-timeout" (0xffffd278)
"apply" (0xffffd270)
"timer-event-handler" (0xffffd3f8)
Thread 1 (Thread 0x7ffff05e1380 (LWP 1399519) "emacs"):
#0 0x00005555555e461a in display_line (it=it@entry=0x7fffffffb770, cursor_vpos=cursor_vpos@entry=0) at ../../md5i/src/xdisp.c:24169
#1 0x00005555555e7e01 in try_window (window=window@entry=XIL(0x55555b4301f5), pos=..., flags=flags@entry=2) at ../../md5i/src/xdisp.c:20206
#2 0x00005555556ad347 in Fx_show_tip (string=<optimized out>, frame=<optimized out>, parms=XIL(0x55556045d6d3), timeout=<optimized out>, dx=<optimized out>, dy=<optimized out>) at ../../md5i/src/xfns.c:8752
#3 0x0000555555754d86 in funcall_subr (subr=0x555555bd1c20 <Sx_show_tip>, numargs=numargs@entry=6, args=args@entry=0x7fffffffcdb0) at ../../md5i/src/eval.c:3006
#4 0x0000555555752ca4 in funcall_general (fun=<optimized out>, numargs=numargs@entry=6, args=args@entry=0x7fffffffcdb0) at ../../md5i/src/eval.c:2904
#5 0x0000555555753131 in Ffuncall (nargs=7, args=0x7fffffffcda8) at ../../md5i/src/eval.c:2958
#6 0x00007fffeee6ed9d in F746f6f6c7469702d73686f77_tooltip_show_0 () at /home/md5i/src/emacs/build/src/../native-lisp/29.0.50-bb581598/preloaded/tooltip-29462ede-0f14bf43.eln
#7 0x0000555555754d4f in funcall_subr (subr=0x7fffef911310, numargs=numargs@entry=2, args=args@entry=0x7fffffffced8) at ../../md5i/src/eval.c:3002
#8 0x0000555555752ca4 in funcall_general (fun=<optimized out>, numargs=numargs@entry=2, args=args@entry=0x7fffffffced8) at ../../md5i/src/eval.c:2904
#9 0x0000555555753131 in Ffuncall (nargs=3, args=0x7fffffffced0) at ../../md5i/src/eval.c:2958
#10 0x00007fffeee6f968 in F746f6f6c7469702d68656c702d74697073_tooltip_help_tips_0 () at /home/md5i/src/emacs/build/src/../native-lisp/29.0.50-bb581598/preloaded/tooltip-29462ede-0f14bf43.eln
#11 0x0000555555754d16 in funcall_subr (subr=0x7fffef912e38, numargs=numargs@entry=1, args=args@entry=0x7fffffffd038) at ../../md5i/src/eval.c:2996
#12 0x0000555555752ca4 in funcall_general (fun=<optimized out>, numargs=numargs@entry=1, args=args@entry=0x7fffffffd038) at ../../md5i/src/eval.c:2904
#13 0x0000555555753131 in Ffuncall (nargs=2, args=0x7fffffffd030) at ../../md5i/src/eval.c:2958
#14 0x0000555555751f6c in run_hook_with_args (nargs=2, args=0x7fffffffd030, funcall=funcall@entry=0x555555753016 <Ffuncall>) at ../../md5i/src/eval.c:2817
#15 0x00005555557521df in Frun_hook_with_args_until_success (nargs=<optimized out>, args=<optimized out>) at ../../md5i/src/eval.c:2703
#16 0x00007fffeee6e964 in F746f6f6c7469702d74696d656f7574_tooltip_timeout_0 () at /home/md5i/src/emacs/build/src/../native-lisp/29.0.50-bb581598/preloaded/tooltip-29462ede-0f14bf43.eln
#17 0x0000555555754d16 in funcall_subr (subr=0x7fffef911db8, numargs=numargs@entry=1, args=args@entry=0x7fffffffd278) at ../../md5i/src/eval.c:2996
#18 0x0000555555752ca4 in funcall_general (fun=<optimized out>, numargs=numargs@entry=1, args=args@entry=0x7fffffffd278) at ../../md5i/src/eval.c:2904
#19 0x0000555555753131 in Ffuncall (nargs=nargs@entry=2, args=args@entry=0x7fffffffd270) at ../../md5i/src/eval.c:2958
#20 0x0000555555753c70 in Fapply (nargs=2, args=0x7fffffffd270) at ../../md5i/src/eval.c:2586
#21 0x0000555555754de9 in funcall_subr (subr=0x555555bdf060 <Sapply>, numargs=numargs@entry=2, args=args@entry=0x7fffffffd270) at ../../md5i/src/eval.c:3023
#22 0x0000555555752ca4 in funcall_general (fun=<optimized out>, numargs=numargs@entry=2, args=args@entry=0x7fffffffd270) at ../../md5i/src/eval.c:2904
#23 0x0000555555753131 in Ffuncall (nargs=3, args=0x7fffffffd268) at ../../md5i/src/eval.c:2958
#24 0x00007fffef039e90 in F74696d65722d6576656e742d68616e646c6572_timer_event_handler_0 () at /home/md5i/src/emacs/build/src/../native-lisp/29.0.50-bb581598/preloaded/timer-3ee7cfd9-76499eee.eln
#25 0x0000555555754d16 in funcall_subr (subr=0x7ffff0025ad0, numargs=numargs@entry=1, args=args@entry=0x7fffffffd3f8) at ../../md5i/src/eval.c:2996
#26 0x0000555555752ca4 in funcall_general (fun=<optimized out>, numargs=numargs@entry=1, args=args@entry=0x7fffffffd3f8) at ../../md5i/src/eval.c:2904
#27 0x0000555555753131 in Ffuncall (nargs=nargs@entry=2, args=args@entry=0x7fffffffd3f0) at ../../md5i/src/eval.c:2958
#28 0x00005555556c3cf3 in call1 (arg1=XIL(0x55555bd20ee5), fn=XIL(0xf390)) at ../../md5i/src/lisp.h:3239
#29 timer_check_2 (timers=<optimized out>, timers@entry=XIL(0x55555c403a33), idle_timers=<optimized out>, idle_timers@entry=XIL(0x55555c403803)) at ../../md5i/src/keyboard.c:4599
#30 0x00005555556d1ec0 in timer_check () at ../../md5i/src/keyboard.c:4665
#31 0x00005555556d1f10 in readable_events (flags=1) at ../../md5i/src/keyboard.c:3492
#32 0x00005555556d2254 in get_input_pending (flags=flags@entry=1) at ../../md5i/src/keyboard.c:7240
#33 0x00005555556d238f in swallow_events (do_display=do_display@entry=false) at ../../md5i/src/keyboard.c:4406
#34 0x00005555556d4a90 in read_char (commandflag=1, map=map@entry=XIL(0x55555eba43d3), prev_event=XIL(0), used_mouse_menu=used_mouse_menu@entry=0x7fffffffd7eb, end_time=end_time@entry=0x0) at ../../md5i/src/keyboard.c:2585
#35 0x00005555556d67eb in read_key_sequence (keybuf=keybuf@entry=0x7fffffffd8c0, prompt=prompt@entry=XIL(0), dont_downcase_last=dont_downcase_last@entry=false, can_return_switch_frame=can_return_switch_frame@entry=true, fix_current_buffer=fix_current_buffer@entry=true, prevent_redisplay=prevent_redisplay@entry=false) at ../../md5i/src/keyboard.c:9947
#36 0x00005555556d8257 in command_loop_1 () at ../../md5i/src/keyboard.c:1391
#37 0x00005555557518a6 in internal_condition_case (bfun=bfun@entry=0x5555556d805e <command_loop_1>, handlers=handlers@entry=XIL(0x90), hfun=hfun@entry=0x5555556c8fb3 <cmd_error>) at ../../md5i/src/eval.c:1485
#38 0x00005555556c22a1 in command_loop_2 (handlers=handlers@entry=XIL(0x90)) at ../../md5i/src/keyboard.c:1132
#39 0x000055555575181d in internal_catch (tag=tag@entry=XIL(0xf690), func=func@entry=0x5555556c2287 <command_loop_2>, arg=arg@entry=XIL(0x90)) at ../../md5i/src/eval.c:1208
#40 0x00005555556c2264 in command_loop () at ../../md5i/src/keyboard.c:1110
#41 0x00005555556c8b5a in recursive_edit_1 () at ../../md5i/src/keyboard.c:719
#42 0x00005555556c8eef in Frecursive_edit () at ../../md5i/src/keyboard.c:802
#43 0x00005555556c194f in main (argc=2, argv=0x7fffffffdc68) at ../../md5i/src/emacs.c:2517
Lisp Backtrace:
"x-show-tip" (0xffffcdb0)
"tooltip-show" (0xffffced8)
"tooltip-help-tips" (0xffffd038)
"tooltip-timeout" (0xffffd278)
"apply" (0xffffd270)
"timer-event-handler" (0xffffd3f8)
--
Michael Welsh Duggan
(md5i@HIDDEN)
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.Received: (at 56561) by debbugs.gnu.org; 14 Jul 2022 19:28:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 14 15:28:40 2022 Received: from localhost ([127.0.0.1]:38929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oC4Vr-0003Td-RC for submit <at> debbugs.gnu.org; Thu, 14 Jul 2022 15:28:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oC4Vp-0003TO-Bm for 56561 <at> debbugs.gnu.org; Thu, 14 Jul 2022 15:28:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oC4Vk-0006lG-35; Thu, 14 Jul 2022 15:28:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Qoqh80e8Trb36tLC3DZnfBclgRUM6hElKZA9tjDkyeM=; b=JZD4G30DjkeC FAK4uBLX0zPWihNzte1leyX7qyydxeBjw4U8yV52ku4bwHPKPczdIHRWH7kPNo9XmO2p22lb2lNp+ PfzWUsrQkwuXkkovZQZ3ED+nEX4RWbCmST1FzISEqDh42fEZTCW43hD/1adegOJ+G4ymJ8QJzvcGu 5sRt8i+Y68Ez9GfBOHgLZFiXTnaRV2ADbvdNFwVrrqhEXByAo/s3HQUqnEx/ToIKEz57HU5a6Gmg2 1pHk2KkAolu0yRIhKsCXytBm+kcmoB6TJRIQf2q3hFZTwwNaxiNf0bLL5ycoCbM0Ynj0v2CXtoMFV voTh/t1H7TPQvCGQaYU94A==; Received: from [87.69.77.57] (port=3815 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oC4Vj-0005t3-GK; Thu, 14 Jul 2022 15:28:31 -0400 Date: Thu, 14 Jul 2022 22:28:26 +0300 Message-Id: <83v8rzsdd1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Michael Welsh Duggan <md5i@HIDDEN> In-Reply-To: <874jzjwmhn.fsf@HIDDEN> (message from Michael Welsh Duggan on Thu, 14 Jul 2022 14:57:40 -0400) Subject: Re: bug#56561: 29.0.50; Infloop in try_window References: <874jzjwmhn.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56561 Cc: 56561 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Michael Welsh Duggan <md5i@HIDDEN> > Date: Thu, 14 Jul 2022 14:57:40 -0400 > > I've connected to this in gdb. `try_window' is calling `display_line' > in a loop until the iterator hits a certain point. But `display_line', > in this case, isn't modifying the iterator, so the loop never ends. > Here follows part of the debugging session demonstrating this. I'll > keep this gdb session alive for a while. I need to see what's in the buffer and some other variables. These are for the call-stack frame inside display_line: (gdb) p current_buffer->text->beg (gdb) p it->current (gdb) p it->w->desired_matrix->nrows (gdb) p MATRIX_ROW_VPOS(row, it->w->desired_matrix) (gdb) thread apply all bt (gdb) xbacktrace And finally, any idea what you were doing when this happened? Thanks.
bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 14 Jul 2022 18:57:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 14 14:57:54 2022
Received: from localhost ([127.0.0.1]:38894 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oC425-0002ec-PK
for submit <at> debbugs.gnu.org; Thu, 14 Jul 2022 14:57:54 -0400
Received: from lists.gnu.org ([209.51.188.17]:38430)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <md5i@HIDDEN>) id 1oC422-0002eT-Es
for submit <at> debbugs.gnu.org; Thu, 14 Jul 2022 14:57:52 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:43204)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <md5i@HIDDEN>) id 1oC422-00070h-13
for bug-gnu-emacs@HIDDEN; Thu, 14 Jul 2022 14:57:50 -0400
Received: from md5i.com ([75.151.244.229]:54372)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <md5i@HIDDEN>) id 1oC41y-0005Pp-Tg
for bug-gnu-emacs@HIDDEN; Thu, 14 Jul 2022 14:57:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com;
s=dkim; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender:
Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description:
Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=kP+PzACyg+tjjmU063XbtXsVDjWM0eMDuUzA8GmgNCQ=; b=pb27Uo56VcD+sktfPnxPdn40n/
J6vMYGUo8GPkwenAAAME7HTQf9QT9m4olNDD1bHuSDZ9+7WGXzH+kKaC7IoHP/vJKBfPPu1ZA+8+m
gVxb9xbsyozwiVTsCl03xjYF+;
Received: from abode ([192.168.177.1] helo=miko)
by md5i.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.95) (envelope-from <md5i@HIDDEN>) id 1oC41x-00HRDY-BZ
for bug-gnu-emacs@HIDDEN; Thu, 14 Jul 2022 14:57:45 -0400
From: Michael Welsh Duggan <md5i@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; Infloop in try_window
Date: Thu, 14 Jul 2022 14:57:40 -0400
Message-ID: <874jzjwmhn.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=75.151.244.229; envelope-from=md5i@HIDDEN;
helo=md5i.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
No recipe for this. In the course of using Emacs, I ended up in an
infloop in `try_window`.
I've connected to this in gdb. `try_window' is calling `display_line'
in a loop until the iterator hits a certain point. But `display_line',
in this case, isn't modifying the iterator, so the loop never ends.
Here follows part of the debugging session demonstrating this. I'll
keep this gdb session alive for a while.
try_window (window=window@entry=XIL(0x55555b4301f5), pos=..., flags=flags@entry=2) at ../../md5i/src/xdisp.c:20208
20208 if (f->fonts_changed && !(flags & TRY_WINDOW_IGNORE_FONTS_CHANGE))
(gdb) n
20204 while (it.current_y < it.last_visible_y)
(gdb) p it.current_y
$11 = 595
(gdb) p it.last_visible_y
$12 = 680
(gdb) n
20206 if (display_line (&it, cursor_vpos))
(gdb) s
display_line (it=it@entry=0x7fffffffb770, cursor_vpos=cursor_vpos@entry=0) at ../../md5i/src/xdisp.c:24140
24140 {
(gdb) n
24141 struct glyph_row *row = it->glyph_row;
(gdb)
24154 ptrdiff_t min_pos = ZV + 1, max_pos = 0;
(gdb)
24157 int tab_line = window_wants_tab_line (it->w);
(gdb)
24158 int header_line = window_wants_header_line (it->w);
(gdb)
24159 bool hscroll_this_line = (cursor_vpos >= 0
(gdb)
24162 int first_visible_x = it->first_visible_x;
(gdb)
24163 int last_visible_x = it->last_visible_x;
(gdb)
24169 if (MATRIX_ROW_VPOS (row, it->w->desired_matrix)
(gdb)
24172 it->w->nrows_scale_factor++;
(gdb) p it->w->nrows_scale_factor
$13 = 2064109537
(gdb) n
24173 it->f->fonts_changed = true;
(gdb)
24174 return false;
(gdb)
try_window (window=window@entry=XIL(0x55555b4301f5), pos=..., flags=flags@entry=2) at ../../md5i/src/xdisp.c:20208
20208 if (f->fonts_changed && !(flags & TRY_WINDOW_IGNORE_FONTS_CHANGE))
(gdb)
20204 while (it.current_y < it.last_visible_y)
In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0)
of 2022-07-03 built on miko
Repository revision: e41ba8ab89a125c91dee672845679f2dec19853a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux bookworm/sid
Configured using:
'configure --without-toolkit-scroll-bars --with-x-toolkit=lucid
--with-native-compilation --with-xinput2 'CFLAGS=-Og -ggdb''
Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP
NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF X11
XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
flyspell-mode: t
display-time-mode: t
magit-wip-initial-backup-mode: t
magit-wip-before-change-mode: t
magit-wip-after-apply-mode: t
magit-wip-after-save-mode: t
magit-wip-mode: t
global-git-commit-mode: t
magit-auto-revert-mode: t
shell-dirtrack-mode: t
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
line-number-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
/home/md5i/.config/emacs/elpa/transient-20220514.945/transient hides /home/md5i/src/emacs/md5i/lisp/transient
Features:
(shadow sort mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime
smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file url-dired svg
gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud gnus-spec gnus-win
emacsbug goto-addr bug-reference thingatpt mule-util face-remap
dired-aux flyspell ispell view pacproxy descr-text tramp tramp-loaddefs
trampver tramp-integration cus-edit pp cus-load files-x tramp-compat
parse-time iso8601 ls-lisp time sieve-manage sasl sasl-anonymous
sasl-login sasl-plain rng-loc rng-uri rng-parse rng-match rng-dt
rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util
sgml-mode facemenu dom python ps-print ps-print-loaddefs ps-def lpr
picture nm dbus xml magit-submodule magit-obsolete magit-blame
magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch
magit-clone magit-remote magit-commit magit-sequence magit-notes
magit-worktree magit-tag magit-merge magit-branch magit-reset
magit-files magit-refs magit-status magit magit-repos magit-apply
magit-wip magit-log which-func imenu magit-diff smerge-mode diff
diff-mode easy-mmode git-commit log-edit pcvs-util add-log magit-core
magit-autorevert autorevert filenotify magit-margin magit-transient
magit-process with-editor shell pcomplete server magit-mode transient
comp comp-cstr warnings rx cl-extra edmacro kmacro help-mode magit-git
magit-base magit-section format-spec crm dash compat-27 compat-26 compat
nnimap nnmail gnus-int mail-source gnus-range message sendmail
yank-media rfc822 mml mml-sec epa mm-decode mm-bodies mm-encode
mailabbrev gmm-utils mailheader utf7 netrc nnoo gnus wid-edit nnheader
gnus-util time-date mail-utils range gnus-o365-oauth2 oauth2 url-http
url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums
mail-prsvr url-gw nsm puny plstore generated generic-x epg rfc6068
epg-config ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help
ediff-init ediff-util dired-x dired dired-loaddefs compile
text-property-search comint ring ansi-color cc-mode cc-fonts cc-guess
cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs derived
debian-el rainbow-delimiters-autoloads info package browse-url url
url-proxy url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv
url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
faces cus-face macroexp files window text-properties overlay sha1 md5
base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty make-network-process native-compile emacs)
Memory information:
((conses 16 380223 18419)
(symbols 48 27063 2)
(strings 32 95513 5733)
(string-bytes 1 3154480)
(vectors 16 56391)
(vector-slots 8 955380 21517)
(floats 8 665 186)
(intervals 56 3263 950)
(buffers 992 18))
--
Michael Welsh Duggan
(md5i@HIDDEN)
Michael Welsh Duggan <md5i@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#56561; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.