GNU bug report logs - #56657
[PATCH] gnu: ranger: Add dependency file

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: Nguyễn Gia Phong <mcsinyx@HIDDEN>; Keywords: patch moreinfo; dated Wed, 20 Jul 2022 08:50:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Ludovic Courtès <ludo@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 56657 <at> debbugs.gnu.org:


Received: (at 56657) by debbugs.gnu.org; 26 Jul 2022 15:29:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 26 11:29:49 2022
Received: from localhost ([127.0.0.1]:54200 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGMVI-0005OP-K9
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 11:29:49 -0400
Received: from knopi.disroot.org ([178.21.23.139]:33090)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mcsinyx@HIDDEN>) id 1oGFDl-0007Ep-Qy
 for 56657 <at> debbugs.gnu.org; Tue, 26 Jul 2022 03:43:16 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 34D0440DC3;
 Tue, 26 Jul 2022 09:43:12 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id cbQJBPJK6Ja3; Tue, 26 Jul 2022 09:43:11 +0200 (CEST)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1658821391; bh=9mxULXOIASMUe/x022CrbZ0+T2oFz4X3HofhGdjxMgk=;
 h=Date:To:From:Subject:References:In-Reply-To;
 b=iBjvlftg90+yHVbFzDl2lpRcWiXtWfGcmbKpZZLi7CD/5tbvfgQhiEAhUSehlQq1j
 3dhZtSurRnR6E56pjwrAWEvVCFnaODd9ttdrm+RbdgCrH3ytzSYTxBP9CHqLgrhyDM
 2DvNePT8TrjkEbt77jkI055E5vyKoPloKhlO+qyj6d2eyJJnexgQW5YhQoFqiSxNWL
 6tRH+DPaVBlPGZCv8HfVjPuwjyinqzgzxm9NKLTBSBGdU6/YKCcEneRjtiOvTJsCsI
 auR1xR84P8w7YKy9WXwl5BtJVRwZguke5Yynl1DrKrEIX5Ej+qiKJThL+MozyHLJCb
 qhrTZe1WUW3bQ==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 26 Jul 2022 16:43:06 +0900
Message-Id: <CLPF3SUOY06B.2ONLNWJ9RSI7V@nix>
To: "Liliana Marie Prikler" <liliana.prikler@HIDDEN>,
 <56657 <at> debbugs.gnu.org>
From: =?utf-8?q?Nguy=E1=BB=85n_Gia_Phong?= <mcsinyx@HIDDEN>
Subject: Re: [PATCH] gnu: ranger: Add dependency file
References: <20220720080143.18005-1-mcsinyx@HIDDEN>
 <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@HIDDEN>
In-Reply-To: <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 56657
X-Mailman-Approved-At: Tue, 26 Jul 2022 11:29:47 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Thu Jul 21, 2022 at 8:50 AM +0200, Liliana Marie Prikler wrote:
> Rather than patching PATH, you should use substitute*
> to hardcode the reference.

Coming from Nix, I don't get why is it preferred.
Shouldn't users be able to override runtime dependencies at runtime,
e.g. via a custom wrapper script?

If that is the case, I suppose the correct wrapper would be

(wrap-program ...
  '("PATH" suffix ,(list (string-append file "/bin"))))

> Also, do write a ChangeLog style commit message.

Thanks, I probably missed this reading the contrib guide.
Information forwarded to guix-patches@HIDDEN:
bug#56657; Package guix-patches. Full text available.

Message received at 56657 <at> debbugs.gnu.org:


Received: (at 56657) by debbugs.gnu.org; 26 Jul 2022 07:49:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 26 03:49:06 2022
Received: from localhost ([127.0.0.1]:52123 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGFJR-0007RG-RW
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 03:49:06 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:25071)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oGFJL-0007Qg-VF
 for 56657 <at> debbugs.gnu.org; Tue, 26 Jul 2022 03:49:04 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
 by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LsTZ03fQYz3wjt;
 Tue, 26 Jul 2022 09:48:56 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
 s=mailrelay; t=1658821736;
 bh=Arm66ewzBDVShgdP2lHNc3cHxn9PMAor3yfIbFG7pa4=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=jQesQV3TXopSmewl7jEWIZbtFBwQjsG0YXuq69ztMwH4ap4mWuRnctmOymxlBLzZp
 99bSsHoxUd935bemu/hmieOL07yVE3ye2uUQFiJ5kTRfdA/f4nt0RSiUYSqN2wxlj7
 IFd+BdhqIqvEG7WArX0s/g0tUHUPMfSCKG51KRt8=
Message-ID: <3b9ad15ef70095a116c2657017808d0783a9c44e.camel@HIDDEN>
Subject: Re: [PATCH] gnu: ranger: Add dependency file
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>, 
 56657 <at> debbugs.gnu.org
Date: Tue, 26 Jul 2022 09:48:55 +0200
In-Reply-To: <CLPF3SUOY06B.2ONLNWJ9RSI7V@nix>
References: <20220720080143.18005-1-mcsinyx@HIDDEN>
 <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@HIDDEN>
 <CLPF3SUOY06B.2ONLNWJ9RSI7V@nix>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001 
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56657
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Am Dienstag, dem 26.07.2022 um 16:43 +0900 schrieb Nguyễn Gia Phong:
> On Thu Jul 21, 2022 at 8:50 AM +0200, Liliana Marie Prikler wrote:
> > Rather than patching PATH, you should use substitute*
> > to hardcode the reference.
> 
> Coming from Nix, I don't get why is it preferred.
> Shouldn't users be able to override runtime dependencies at runtime,
> e.g. via a custom wrapper script?
In Guix we prefer not to rely on the environment because that breaks
the case of pure shells.  We have transformations, which are more
powerful than wrapper scripts.
Information forwarded to guix-patches@HIDDEN:
bug#56657; Package guix-patches. Full text available.

Message received at 56657 <at> debbugs.gnu.org:


Received: (at 56657) by debbugs.gnu.org; 21 Jul 2022 06:51:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 21 02:51:00 2022
Received: from localhost ([127.0.0.1]:36542 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEQ1U-0005sH-Eg
	for submit <at> debbugs.gnu.org; Thu, 21 Jul 2022 02:51:00 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:25031)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oEQ1P-0005s5-Oe
 for 56657 <at> debbugs.gnu.org; Thu, 21 Jul 2022 02:51:00 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
 by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LpNWJ6CY3z3wWT;
 Thu, 21 Jul 2022 08:50:52 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
 s=mailrelay; t=1658386253;
 bh=I0qijGD3wL1zPJmEvoxAe6wMjO1JwWb2N1IJS57qh+g=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=cigMjlEnfUU+k7FSP2RMg0bps2G+GCw4Idrbcm86ojgNGVneig+pDbp8uZfSuwjXv
 p4WIQ1eNXMoFYgWA10tic+ElO9kug0Du3MJWgDFVVHMSEz5dMjQ7jKLQYDtYAo9ICl
 xhA75nqEfc0sWAwtPTr/+dFVdauYNuZWdmDIHtNA=
Message-ID: <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@HIDDEN>
Subject: Re: [PATCH] gnu: ranger: Add dependency file
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>, 
 56657 <at> debbugs.gnu.org
Date: Thu, 21 Jul 2022 08:50:52 +0200
In-Reply-To: <20220720080143.18005-1-mcsinyx@HIDDEN>
References: <20220720080143.18005-1-mcsinyx@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001 
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56657
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Am Mittwoch, dem 20.07.2022 um 17:01 +0900 schrieb Nguyễn Gia Phong:
> While file is an optional dependency, without it
> file type determination and opening does not work out of the box.
Rather than patching PATH, you should use substitute* to hardcode the
reference.  Also, do write a ChangeLog style commit message.

Cheers
Information forwarded to guix-patches@HIDDEN:
bug#56657; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 20 Jul 2022 08:49:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 20 04:49:32 2022
Received: from localhost ([127.0.0.1]:55799 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oE5Od-0005WO-Ch
	for submit <at> debbugs.gnu.org; Wed, 20 Jul 2022 04:49:31 -0400
Received: from lists.gnu.org ([209.51.188.17]:44194)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mcsinyx@HIDDEN>) id 1oE4fJ-0004KD-SO
 for submit <at> debbugs.gnu.org; Wed, 20 Jul 2022 04:02:43 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:47156)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mcsinyx@HIDDEN>)
 id 1oE4fI-000553-S3
 for guix-patches@HIDDEN; Wed, 20 Jul 2022 04:02:41 -0400
Received: from knopi.disroot.org ([178.21.23.139]:54466)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mcsinyx@HIDDEN>)
 id 1oE4fG-0008Vb-Si
 for guix-patches@HIDDEN; Wed, 20 Jul 2022 04:02:40 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 2A05540E2F;
 Wed, 20 Jul 2022 10:02:36 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with UTF8SMTP id oklS-1p6n8UT; Wed, 20 Jul 2022 10:02:31 +0200 (CEST)
From: =?UTF-8?q?Nguy=E1=BB=85n=20Gia=20Phong?= <mcsinyx@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1658304116; bh=KS3nN9fMb3zRltBY9dqE95Nnrmk18mapqbbCahGDS1M=;
 h=From:To:Cc:Subject:Date;
 b=H79cQPkJf2p/sA/QIEHyd6rpxQ1PQFjvCVG6lD9GsWW7YSwcovSRIttoHiw7gxFuq
 nG/yXX+CQi0YVIK9ntMmDZyPc6B/05qxRJRz67g4zx3QQ70R2Udj3jweZFjGgxGWxu
 1KLll4f3irL6Hv4m62XQO68bSVC4RFii8vcB1R89BVATNsJZueuOBdSy4pPXozNWPP
 QXPf5elsXvhTFcN+fSz39ezp8+rUonvf7c79wc1gPyhILLMlvz22lHE6UbSnxq9v6m
 ahyLsGquGLTPHucBwAuVIJrX5v2Q3cBWKW26GJWlSaD8bIlv4nlK7YqGq/67A9ez5k
 5Abul2eKhrVpg==
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: ranger: Add dependency file
Date: Wed, 20 Jul 2022 17:01:43 +0900
Message-Id: <20220720080143.18005-1-mcsinyx@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=178.21.23.139; envelope-from=mcsinyx@HIDDEN;
 helo=knopi.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Wed, 20 Jul 2022 04:49:30 -0400
Cc: =?UTF-8?q?Nguy=E1=BB=85n=20Gia=20Phong?= <mcsinyx@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

While file is an optional dependency, without it
file type determination and opening does not work out of the box.
---
 gnu/packages/disk.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 47b15e588f79..58bd3db3812c 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2021 Justin Veilleux <terramorpha@HIDDEN>
 ;;; Copyright © 2014, 2022 Ludovic Courtès <ludo@HIDDEN>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
+;;; Copyright © 2022 Nguyễn Gia Phong <mcsinyx@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -800,7 +801,7 @@ (define-public ranger
                 "0lfjrpv3z4h0knd3v94fijrw2zjba51mrp3mjqx2c98wr428l26f"))))
     (build-system python-build-system)
     (inputs
-     (list w3m))
+     (list file w3m))
     (native-inputs
      (list which
            ;; For tests.
@@ -815,11 +816,13 @@ (define-public ranger
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out  (assoc-ref outputs "out"))
                     (ranger (string-append out "/bin/ranger"))
+                    (file (assoc-ref inputs "file"))
                     (w3m (assoc-ref inputs "w3m"))
                     (w3mimgdisplay (string-append w3m
                                    "/libexec/w3m/w3mimgdisplay")))
                (wrap-program ranger
-                 `("W3MIMGDISPLAY_PATH" ":" prefix (,w3mimgdisplay)))
+                 `("W3MIMGDISPLAY_PATH" ":" prefix (,w3mimgdisplay))
+                 `("PATH" ":" prefix ,(list (string-append file "/bin"))))
                #t)))
          (replace 'check
            ;; The default check phase simply prints 'Ran 0 tests in 0.000s'.
-- 
2.37.0
Acknowledgement sent to Nguyễn Gia Phong <mcsinyx@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#56657; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 4 Aug 2022 22:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.