GNU bug report logs - #56668
[PATCH] gnu: Add wavbreaker

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56668 in the body.
You can then email your comments to 56668 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joeke de Graaf <joeke <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add wavbreaker
Date: Wed, 20 Jul 2022 12:07:50 +0000

[Message part 1 (text/plain, inline)]

Hello,

This patch adds the wavbreaker package to mp3.scm

Best regards,

Joeke de Graaf

[0001-gnu-Add-wavbreaker.patch (text/x-patch, inline)]

From 2f512eb8a85c4920aeea5f673129d1507f32cbb9 Mon Sep 17 00:00:00 2001
From: Joeke de Graaf <joeke <at> posteo.net>
Date: Wed, 20 Jul 2022 13:58:38 +0200
Subject: [PATCH] gnu: Add wavbreaker

---
 gnu/packages/mp3.scm | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 4a8bdad711..a3207ef062 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2021 Simon Streit <simon <at> netpanic.org>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
+;;; Copyright © 2022 Joeke de Graaf <joeke <at> posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -50,13 +51,15 @@ (define-module (gnu packages mp3)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages linux)               ;alsa-lib
   #:use-module (gnu packages video)               ;ffmpeg
+  #:use-module (gnu packages cmake)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
-  #:use-module (guix build-system cmake))
+  #:use-module (guix build-system cmake)
+  #:use-module (guix build-system meson))
 
 (define-public libmad
   (package
@@ -710,3 +713,30 @@ (define-public python-pytaglib
 cross-platform, works with all Python versions, and is very
 simple to use yet fully featured.")
     (license license:gpl3)))
+
+(define-public wavbreaker
+  (package
+    (name "wavbreaker")
+    (version "0.15")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/thp/wavbreaker/")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "16h0sfcb8av6a368giizzwv9m0lq5c3bnf4b9vyyh9nkbbsc7c3j"))))
+    (build-system meson-build-system)
+    (native-inputs
+     (list pkg-config cmake))
+    (inputs (list glib gtk+ ao))
+    (home-page "https://wavbreaker.sourceforge.io/")
+    (synopsis "WAV and MP3 file splitter with a GUI")
+    (description
+     "Wavbreaker is a WAV and MP3 file splitter.  It can be used to
+break up a WAV or MP3 audio file into multiple WAV files.
+Wavbreaker contains a helpful waveform display of the audio file
+being edited, to help the user in splitting the file at the right
+point.  Wavbreaker also supports splitting MP3 files without
+re-encoding them, to preserve their original audio quality.")
+    (license license:gpl2)))
-- 
2.37.0

Message #8 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Joeke de Graaf <joeke <at> posteo.net>, 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sat, 23 Jul 2022 21:50:40 +0200

[Message part 1 (text/plain, inline)]

On 20-07-2022 14:07, Joeke de Graaf wrote:

> +    (native-inputs
> +     (list pkg-config cmake))
> +    (inputs (list glib gtk+ ao))

Please check that it works nicely (with, e.g., no missing icons, which 
sometimes happens for GTK+ stuff) in a pure environment. Try:

$ guix shell --pure wavbreaker -- 
insert-the-binary-name-here,probably-wavbreaker

If there are problems, we'll have to add some things to fix them.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Joeke de Graaf <joeke <at> posteo.net>, 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sat, 23 Jul 2022 21:51:44 +0200

[Message part 1 (text/plain, inline)]

On 20-07-2022 14:07, Joeke de Graaf wrote:
> +    (license license:gpl2)))

Going by https://github.com/thp/wavbreaker/blob/master/src/appconfig.c, 
it's actually gpl2+, though I haven't verified whether that applies to 
all files.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #14 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Joeke de Graaf <joeke <at> posteo.net>
To: 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sat, 23 Jul 2022 22:14:48 +0000

[Message part 1 (text/plain, inline)]

On 23.07.2022 21:51, Maxime Devos wrote:
> On 20-07-2022 14:07, Joeke de Graaf wrote:
>> +    (license license:gpl2)))
> 
> Going by
> https://github.com/thp/wavbreaker/blob/master/src/appconfig.c, it's
> actually gpl2+, though I haven't verified whether that applies to all
> files.

You're right, I missed that. I attached a new patch.

On 23.07.2022 21:50, Maxime Devos wrote:
> On 20-07-2022 14:07, Joeke de Graaf wrote:
> 
>> +    (native-inputs
>> +     (list pkg-config cmake))
>> +    (inputs (list glib gtk+ ao))
> 
> Please check that it works nicely (with, e.g., no missing icons, which
> sometimes happens for GTK+ stuff) in a pure environment. Try:
> 
> $ guix shell --pure wavbreaker --
> insert-the-binary-name-here,probably-wavbreaker
> 
> If there are problems, we'll have to add some things to fix them.

It seems that in the package's current state, it does not like being run 
in a pure environment, it simply crashes.
The application seems to expect GTK icons to be in a certain place and 
it's not finding them.
It's not immediately obvious to me what the solution for this is, but I 
gather from your previous e-mail that this is a known and fixable 
problem.

In any case, I attached the output of
$ guix shell --pure -- wavbreaker
as a plain text attachment.


Best regards,

Joeke de Graaf

[0001-gnu-Add-wavbreaker.patch (text/x-patch, attachment)]

[wavbreaker-pure-environment-output.txt (text/plain, attachment)]

Message #17 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Joeke de Graaf <joeke <at> posteo.net>, 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sun, 24 Jul 2022 00:27:38 +0200

[Message part 1 (text/plain, inline)]

On 24-07-2022 00:14, Joeke de Graaf wrote:

> The application seems to expect GTK icons to be in a certain place and 
> it's not finding them.
> It's not immediately obvious to me what the solution for this is, but 
> I gather from your previous e-mail that this is a known and fixable 
> problem. 

Maybe have a look at how the inkscape package wraps things (search for 
GDK_PIXBUF_MODULE_FILE), maybe also search for glib-or-gtk-wrap, maybe 
GI_TYPELIB_PATH but probably not, perhaps XDG_DATA_DIRS (see e.g. icedove).

I'm not sure which of them is important, but my guess is XDG_DATA_DIRS.

Greetings,
Maxime

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #20 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Joeke de Graaf" <joeke <at> posteo.net>, <56668 <at> debbugs.gnu.org>
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sun, 24 Jul 2022 11:31:30 +0100

On Sat Jul 23, 2022 at 11:14 PM BST, Joeke de Graaf wrote:
> It seems that in the package's current state, it does not like being run 
> in a pure environment, it simply crashes.
> The application seems to expect GTK icons to be in a certain place and 
> it's not finding them.
> It's not immediately obvious to me what the solution for this is, but I 
> gather from your previous e-mail that this is a known and fixable 
> problem.

You should be able to fix this by adding the hicolor-icon-theme package
to native-inputs.

    -- (

Message #23 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Joeke de Graaf <joeke <at> posteo.net>
To: 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sun, 24 Jul 2022 18:07:51 +0000

On 24.07.2022 12:31, ( wrote:
> On Sat Jul 23, 2022 at 11:14 PM BST, Joeke de Graaf wrote:
>> It seems that in the package's current state, it does not like being 
>> run
>> in a pure environment, it simply crashes.
>> The application seems to expect GTK icons to be in a certain place and
>> it's not finding them.
>> It's not immediately obvious to me what the solution for this is, but 
>> I
>> gather from your previous e-mail that this is a known and fixable
>> problem.
> 
> You should be able to fix this by adding the hicolor-icon-theme package
> to native-inputs.
> 
>     -- (

Thanks, this fixed it.

Message #26 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Joeke de Graaf <joeke <at> posteo.net>
To: 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sun, 24 Jul 2022 18:09:07 +0000

[Message part 1 (text/plain, inline)]

Here is the new patch.

[0001-gnu-Add-wavbreaker.patch (text/x-patch, attachment)]

Message #29 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "(" <paren <at> disroot.org>, Joeke de Graaf <joeke <at> posteo.net>,
 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sun, 24 Jul 2022 23:13:11 +0200

[Message part 1 (text/plain, inline)]

On 24-07-2022 12:31, ( via Guix-patches via wrote:
> On Sat Jul 23, 2022 at 11:14 PM BST, Joeke de Graaf wrote:
>> It seems that in the package's current state, it does not like being run
>> in a pure environment, it simply crashes.
>> The application seems to expect GTK icons to be in a certain place and
>> it's not finding them.
>> It's not immediately obvious to me what the solution for this is, but I
>> gather from your previous e-mail that this is a known and fixable
>> problem.
> You should be able to fix this by adding the hicolor-icon-theme package
> to native-inputs.
>
>      -- (

This doesn't seem correct to me -- if it is a runtime thing (otherwise, 
how could it stop the crashes), it needs to be _inputs_, not 
_native-inputs_, for cross-compilation reasons. If you go for 
native-inputs anyways, check the references and make sure the icons 
don't end up in them.  Also, a comment on why this seemingly unneeded 
package is added would be in order (the package builds without, so some 
future reader could easily just remove the input for being unneeded).

Greetings,
Maxime.

[Message part 2 (text/html, inline)]

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #32 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Joeke de Graaf <joeke <at> posteo.net>
To: 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sun, 24 Jul 2022 21:26:22 +0000

On 24.07.2022 23:13, Maxime Devos wrote:
> On 24-07-2022 12:31, ( via Guix-patches via wrote:
> 
>> On Sat Jul 23, 2022 at 11:14 PM BST, Joeke de Graaf wrote:
>> 
>>> It seems that in the package's current state, it does not like
>>> being run
>>> in a pure environment, it simply crashes.
>>> The application seems to expect GTK icons to be in a certain place
>>> and
>>> it's not finding them.
>>> It's not immediately obvious to me what the solution for this is,
>>> but I
>>> gather from your previous e-mail that this is a known and fixable
>>> problem.
>> 
>> You should be able to fix this by adding the hicolor-icon-theme
>> package
>> to native-inputs.
>> 
>> -- (
> 
> This doesn't seem correct to me -- if it is a runtime thing
> (otherwise, how could it stop the crashes), it needs to be _inputs_,
> not _native-inputs_, for cross-compilation reasons. If you go for
> native-inputs anyways, check the references and make sure the icons
> don't end up in them.  Also, a comment on why this seemingly unneeded
> package is added would be in order (the package builds without, so
> some future reader could easily just remove the input for being
> unneeded).
> 
> Greetings,
>  Maxime.

You are right, adding hicolor-icon-theme as a native input did not 
resolve the issue.
While testing, I forgot to add --pure to the "guix shell" command.
I will attempt some other fixes.

Message #35 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Joeke de Graaf <joeke <at> posteo.net>
To: 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Sun, 24 Jul 2022 23:06:17 +0000

Just an update on this issue to avoid duplicate effort if someone else 
also tries to fix this later:

On Maxime Devos' suggestion, I looked into glib-or-gtk-wrap.
Looking at %standard-phases in the module (guix build 
meson-build-system) there is already a glib-or-gtk-wrap phase.
Adding this phase manually after the install phase does not help to fix 
the problem (as expected, though it was worth a shot).

Later this week (hopefully tomorrow) I will try some more of Maxime 
Devos' suggestions


Best regards,

Joeke de Graaf

Message #38 received at 56668 <at> debbugs.gnu.org (full text, mbox):

From: Joeke de Graaf <joeke <at> posteo.net>
To: 56668 <at> debbugs.gnu.org
Subject: Re: [bug#56668] [PATCH] gnu: Add wavbreaker
Date: Wed, 27 Jul 2022 23:43:38 +0000

[Message part 1 (text/plain, inline)]

I've modified my patch to make wavbreaker work in pure environments.

The only thing I haven't been able to fix is the program's own icon in 
Gnome's activity overview (the overview of open programs one gets when 
one presses the super key).
If wavbreaker is run in a pure environment, this icon does not show up. 
Otherwise, the program seems to run fine.


Best regards,

Joeke de Graaf

[001-gnu-Add-wavbreaker.patch (text/x-patch, attachment)]

Message #43 received at 56668-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Joeke de Graaf <joeke <at> posteo.net>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 56668-done <at> debbugs.gnu.org
Subject: Re: bug#56668: [PATCH] gnu: Add wavbreaker
Date: Sat, 06 Aug 2022 22:42:23 +0200

[Message part 1 (text/plain, inline)]

Hi Joeke,

Joeke de Graaf <joeke <at> posteo.net> skribis:

> I've modified my patch to make wavbreaker work in pure environments.
>
> The only thing I haven't been able to fix is the program's own icon in
> Gnome's activity overview (the overview of open programs one gets when
> one presses the super key).
> If wavbreaker is run in a pure environment, this icon does not show
> up. Otherwise, the program seems to run fine.

Sounds good.  Applied with the formatting changes below: keeping inputs
fields next to one another, avoiding long lines, replacing tabulations
with spaces (as suggested by ‘guix lint’), and removing extra space from
the description.  I also added a commit log that follows our
conventions¹.

Thank you, and thanks Maxime for reviewing!

Ludo’.

¹ https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 406ebb9233..e2b112832b 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -752,55 +752,64 @@ (define-public wavbreaker
     (name "wavbreaker")
     (version "0.15")
     (source (origin
-	      (method git-fetch)
-	      (uri (git-reference
-		    (url "https://github.com/thp/wavbreaker/")
-		    (commit version)))
-	      (file-name (git-file-name name version))
-	      (sha256
-	       (base32 "16h0sfcb8av6a368giizzwv9m0lq5c3bnf4b9vyyh9nkbbsc7c3j"))))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/thp/wavbreaker/")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "16h0sfcb8av6a368giizzwv9m0lq5c3bnf4b9vyyh9nkbbsc7c3j"))))
     (build-system meson-build-system)
-    (native-inputs
-     (list pkg-config cmake))
     (arguments
      '(#:modules
        ((guix build utils)
-	(guix build meson-build-system))
+        (guix build meson-build-system))
 
        #:phases
        (modify-phases %standard-phases
-	 (add-after 'install 'wrap-program
-	   ;; This wrapping is necessary to make wavbreaker find things it needs in pure environments
-	   (lambda* (#:key inputs outputs #:allow-other-keys)
-	     (let ((out (assoc-ref outputs "out"))
-		   (adwaita-icons (assoc-ref inputs "adwaita-icon-theme"))
-		   (hicolor-icons (assoc-ref inputs "hicolor-icon-theme"))
-		   (shared-mime (assoc-ref inputs "shared-mime-info")))
-	       (wrap-program (string-append out "/bin/wavbreaker")
-		 ;; Needed in order for wavbreakere to find the icons it needs
-		 `("XDG_DATA_DIRS" ":" prefix ,(map (lambda (package)
-                                                      (string-append package
-                                                                     "/share"))
-                                                    `(,out ;; For wavbreaker's icon
-                                                      ,adwaita-icons
-                                                      ,hicolor-icons
-                                                      ,shared-mime)))
-		 ;; This is necessary to load some pixbufs like Adwaita's check-symbolic.svg
-		 ;; and wavbreaker's own logo in the 'about' section
-		 `("GDK_PIXBUF_MODULE_FILE" =
-		   (,(getenv "GDK_PIXBUF_MODULE_FILE")))
-		 ;; Needed for GTK's file chooser to not crash
-		 `("GSETTINGS_SCHEMA_DIR" =
+         (add-after 'install 'wrap-program
+           ;; This wrapping is necessary to make wavbreaker find things it
+           ;; needs in pure environments.
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (adwaita-icons (assoc-ref inputs "adwaita-icon-theme"))
+                   (hicolor-icons (assoc-ref inputs "hicolor-icon-theme"))
+                   (shared-mime (assoc-ref inputs "shared-mime-info")))
+               (wrap-program (string-append out "/bin/wavbreaker")
+                 ;; Needed in order for wavbreakere to find the icons it needs
+                 `("XDG_DATA_DIRS" ":" prefix
+                   ,(map (lambda (package)
+                           (string-append package "/share"))
+                         `(,out                   ;for wavbreaker's icon
+                           ,adwaita-icons
+                           ,hicolor-icons
+                           ,shared-mime)))
+                 ;; This is necessary to load some pixbufs like Adwaita's
+                 ;; check-symbolic.svg and wavbreaker's own logo in the
+                 ;; 'about' section.
+                 `("GDK_PIXBUF_MODULE_FILE" =
+                   (,(getenv "GDK_PIXBUF_MODULE_FILE")))
+                 ;; Needed for GTK's file chooser to not crash.
+                 `("GSETTINGS_SCHEMA_DIR" =
                  (,(string-append (assoc-ref inputs "gtk+")
                                   "/share/glib-2.0/schemas"))))))))))
-    (inputs (list glib gtk+ ao bash-minimal adwaita-icon-theme shared-mime-info hicolor-icon-theme gsettings-desktop-schemas))
+    (native-inputs
+     (list pkg-config cmake))
+    (inputs
+     (list glib
+           gtk+
+           ao
+           bash-minimal
+           adwaita-icon-theme
+           shared-mime-info
+           hicolor-icon-theme
+           gsettings-desktop-schemas))
     (home-page "https://wavbreaker.sourceforge.io/")
     (synopsis "WAV and MP3 file splitter with a GUI")
     (description
-     "Wavbreaker is a WAV and MP3 file splitter.  It can be used to
-  break up a WAV or MP3 audio file into multiple WAV files.
-  Wavbreaker contains a helpful waveform display of the audio file
-  being edited, to help the user in splitting the file at the right
-  point.  Wavbreaker also supports splitting MP3 files without
-  re-encoding them, to preserve their original audio quality.")
+     "Wavbreaker is a WAV and MP3 file splitter.  It can be used to break up a
+WAV or MP3 audio file into multiple WAV files.  Wavbreaker contains a helpful
+waveform display of the audio file being edited, to help the user in splitting
+the file at the right point.  Wavbreaker also supports splitting MP3 files
+without re-encoding them, to preserve their original audio quality.")
     (license license:gpl2+)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.