GNU logs - #56683, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Andrey Listopadov <andreyorst@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Jul 2022 19:00:02 +0000
Resent-Message-ID: <handler.56683.B.165842998824220 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 56683 <at> debbugs.gnu.org
User-agent: mu4e 1.6.6; emacs 29.0.50
From: Andrey Listopadov <andreyorst@HIDDEN>
Date: Thu, 21 Jul 2022 21:49:47 +0300
Message-ID: <87h73ab8bo.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2a00:1450:4864:20::52e;
 envelope-from=andreyorst@HIDDEN; helo=mail-ed1-x52e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

I'm using emacs with `truncate-lines` set to `t` in my init.el.  After
the merge of #56393 I've rebuilt Emacs, and started testing the fix.
I've noticed, that when lines are truncated, opening dictionary.json
from the #45898 and pressing C-e doesn't move you to the end of the
line, but stops somewhere inside it.  E.g. with the default window width
of Emacs -Q, I can see the following portion of the line

=E2=86=90, "hu": ["index"]}, "examples": [["en C la indicoj aperas inter or=
tajkrampoj, =E2=86=92

Arrows shown in the fringe indicate that there are more to the line on
the right side.

As a side question, does these optimizations work with truncated lines?
As far as I can tell Emacs is not as responsive as when the lines are
wrapped, but I don't know how to measure this precisely.

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, c=
airo version 1.17.4)
 of 2022-07-21 built on toolbox
Repository revision: 4a4fcf628e1e4c8db47cd62fa5617b662fa8b5d6
Repository branch: master
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --without-compress-install --with-native-compilation
 --with-pgtk --with-mailutils --prefix=3D/home/alist/.local'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PGTK PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XIM
GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=3Dibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(comp comp-cstr warnings rx cl-seq cl-macs gv cl-extra bytecomp
byte-compile cconv help-mode pp shadow sort mail-extr emacsbug message
mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec
password-cache epa derived epg rfc6068 epg-config gnus-util
text-property-search time-date subr-x mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win
pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list
replace newcomment text-mode lisp-mode prog-mode register page tab-bar
menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
nadvice seq simple cl-generic indonesian philippine cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop
case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
gtk pgtk lcms2 multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 82646 9587)
 (symbols 48 7091 6)
 (strings 32 19214 1773)
 (string-bytes 1 656752)
 (vectors 16 15347)
 (vector-slots 8 284088 17444)
 (floats 8 173 66)
 (intervals 56 698 7)
 (buffers 992 13))

--
Andrey Listopadov

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Andrey Listopadov <andreyorst@HIDDEN>
Subject: bug#56683: Acknowledgement (29.0.50; long lines fix doesn't work
 correctly when lines are truncated)
Message-ID: <handler.56683.B.165842998824220.ack <at> debbugs.gnu.org>
References: <87h73ab8bo.fsf@HIDDEN>
X-Gnu-PR-Message: ack 56683
X-Gnu-PR-Package: emacs
Reply-To: 56683 <at> debbugs.gnu.org
Date: Thu, 21 Jul 2022 19:00:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 56683 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
56683: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56683
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Jul 2022 19:46:01 +0000
Resent-Message-ID: <handler.56683.B56683.165843272829175 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Andrey Listopadov <andreyorst@HIDDEN>
Cc: 56683 <at> debbugs.gnu.org
Date: Thu, 21 Jul 2022 19:45:19 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <87h73ab8bo.fsf@HIDDEN>
Message-ID: <b7551196d54434aeb8a7@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="gC4JE3gtHw"
Content-ID: <b7551196d5081760b545@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


--gC4JE3gtHw
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-ID: <b7551196d5481c4adbc4@HIDDEN>


>
> I'm using emacs with `truncate-lines` set to `t` in my init.el.  After=20
> the merge of #56393 I've rebuilt Emacs, and started testing the fix.=20
> I've noticed, that when lines are truncated, opening dictionary.json=20
> from the #45898 and pressing C-e doesn't move you to the end of the=20
> line, but stops somewhere inside it.  E.g. with the default window width=
=20
> of Emacs -Q, I can see the following portion of the line
>
> =E2=86=90, "hu": ["index"]}, "examples": [["en C la indicoj aperas intero=
rtajkrampoj, =E2=86=92
>
> Arrows shown in the fringe indicate that there are more to the line on=20
> the right side.
>

You would have seen the same bug before the merge, so it's entirely=20
unrelated to the merge.  It is present at least in Emacs 24, 25, 26, 27=20
and 28.

>
> As a side question, does these optimizations work with truncated lines?=
=20
> As far as I can tell Emacs is not as responsive as when the lines are=20
> wrapped, but I don't know how to measure this precisely.
>

They do work with truncated lines, but I suspect that truncated lines=20
require specific fixes to work efficiently.
--gC4JE3gtHw--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Jul 2022 19:59:02 +0000
Resent-Message-ID: <handler.56683.B56683.165843349030573 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gregory Heytings <gregory@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Date: Thu, 21 Jul 2022 22:57:55 +0300
Message-Id: <83zgh2kzlo.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <b7551196d54434aeb8a7@HIDDEN> (message from Gregory
 Heytings on Thu, 21 Jul 2022 19:45:19 +0000)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Cc: 56683 <at> debbugs.gnu.org
> Date: Thu, 21 Jul 2022 19:45:19 +0000
> From: Gregory Heytings <gregory@HIDDEN>
> 
> > I'm using emacs with `truncate-lines` set to `t` in my init.el.  After 
> > the merge of #56393 I've rebuilt Emacs, and started testing the fix. 
> > I've noticed, that when lines are truncated, opening dictionary.json 
> > from the #45898 and pressing C-e doesn't move you to the end of the 
> > line, but stops somewhere inside it.  E.g. with the default window width 
> > of Emacs -Q, I can see the following portion of the line
> >
> > ←, "hu": ["index"]}, "examples": [["en C la indicoj aperas interortajkrampoj, →
> >
> > Arrows shown in the fringe indicate that there are more to the line on 
> > the right side.
> >
> 
> You would have seen the same bug before the merge, so it's entirely 
> unrelated to the merge.  It is present at least in Emacs 24, 25, 26, 27 
> and 28.

Is this related to the below (from xdisp.c)?

  #define DISP_INFINITY 10000000

Maybe we should make "infinity" somewhat larger?  dictionary.json has
a single line that is 18922365 characters long, so it's "more than
infinity".

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Jul 2022 20:16:02 +0000
Resent-Message-ID: <handler.56683.B56683.165843455932407 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165843455932407
          (code B ref 56683); Thu, 21 Jul 2022 20:16:02 +0000
Received: (at 56683) by debbugs.gnu.org; 21 Jul 2022 20:15:59 +0000
Received: from localhost ([127.0.0.1]:39304 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEcaV-0008Qd-4K
	for submit <at> debbugs.gnu.org; Thu, 21 Jul 2022 16:15:59 -0400
Received: from heytings.org ([95.142.160.155]:47082)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gregory@HIDDEN>) id 1oEcaT-0008QT-FZ
 for 56683 <at> debbugs.gnu.org; Thu, 21 Jul 2022 16:15:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org;
 s=20220101; t=1658434555;
 bh=3F+6Md+54dMg3hNOlssHyqhyD2QT0vRSC53YtghJ/cs=;
 h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From;
 b=lH6+1AUWWYoCsMzTX98OGg9XYy1AZmqjcAyEPVv8cXDXjwAguYewcNmujr2uyxrZa
 6buUNVNhcq6JXZRburMVy3eFTJBjIfCtm8vR5+QctrB7jkF2jJyuYKHPZj6J8ez4nX
 Xxy0N4Uvl9z6szF5rGsb6ClLcwJJy6Lk62sxfhcPCYhvIX26PipaKp6cm7SXwpP7si
 aKBKadGLf/jKOjGzp5UUquysa1oUlqvqK+KIFwYrHEgZH5IoSQErQ9xZ7L6W6A44N8
 AtHYINIoy/lld6enoRWk+Y2xWZArmHRz2q/4GMVpnVpbLrpVEP170E8WNIKpqdBazd
 8J7PWlYXVU9Qg==
Date: Thu, 21 Jul 2022 20:15:55 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <83zgh2kzlo.fsf@HIDDEN>
Message-ID: <b7551196d5203b87e6ec@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="31SQA5rcgw"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--31SQA5rcgw
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable


>
> Is this related to the below (from xdisp.c)?
>
> #define DISP_INFINITY 10000000
>
> Maybe we should make "infinity" somewhat larger?  dictionary.json has a=
=20
> single line that is 18922365 characters long, so it's "more than=20
> infinity".
>

It is indeed, setting DISP_INFINITY to 1000000000 "fixes" that bug.=20
But... how infinite is infinite?  (A near-philosophical question =F0=9F=98=
=89)=20
With a somewhat larger file (that one is only 20 MB) we'd have to increase=
=20
it again.  If that's a hard-coded limit, I guess it's a sign that we=20
should advise against using toggle-truncate-lines in buffer with long=20
lines.
--31SQA5rcgw--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Andrey Listopadov <andreyorst@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Jul 2022 20:38:01 +0000
Resent-Message-ID: <handler.56683.B56683.16584358402158 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.16584358402158
          (code B ref 56683); Thu, 21 Jul 2022 20:38:01 +0000
Received: (at 56683) by debbugs.gnu.org; 21 Jul 2022 20:37:20 +0000
Received: from localhost ([127.0.0.1]:39323 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEcvA-0000Yj-Gu
	for submit <at> debbugs.gnu.org; Thu, 21 Jul 2022 16:37:20 -0400
Received: from mail-ed1-f46.google.com ([209.85.208.46]:41885)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreyorst@HIDDEN>) id 1oEcv7-0000YS-RD
 for 56683 <at> debbugs.gnu.org; Thu, 21 Jul 2022 16:37:18 -0400
Received: by mail-ed1-f46.google.com with SMTP id c72so733549edf.8
 for <56683 <at> debbugs.gnu.org>; Thu, 21 Jul 2022 13:37:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=references:user-agent:from:to:subject:date:in-reply-to:message-id
 :mime-version; bh=we9cFjGvHMpw05ttmAMv2n0otRuQWDCcRDkxeUbm5Sc=;
 b=jK0lTUHE3dBEZXdC/zqirzYrb0/hP+GHN7G0RnjeJKcDd3V1csS10/NsqqJGinuAHl
 zrXfMQJsccrdtNmANEzLe+JElWVtFj2Z4g3VBJXl1vwQ5/L7Sr7AsBFSTzwN3r7yru7U
 iA1pO+vTOo8tXMgg9Xe4KFGgtPsjPaOyD/+CLUjnxZGRBwzRYCUMldz2nncwlazBjXqn
 0pb5IqRjtfERUaZmo/Jz635UErzqltGSmH9uM3aFd8lu20PJ/ovmqhiUdFWQu6VYfTpF
 KeitFB1U5lM0tW44IZlBQQNzDiyiA0Z5x7Y4N0eyu6cFyUwSTB7rNUPnQDfJxWUz4O3L
 DJpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:references:user-agent:from:to:subject:date
 :in-reply-to:message-id:mime-version;
 bh=we9cFjGvHMpw05ttmAMv2n0otRuQWDCcRDkxeUbm5Sc=;
 b=3KzQ/DGpo2o2ojAXTHH7vsEDH1no3ykY/XmNIs4eAZzMOfW5qAMxlu+rRHWd2OjxZR
 M3+ExaRcQZwKafZRrhl4YqRH7+QeF3Wuwe4oWQbCFauqHczZCVekjvYs+D4So4bEfbdK
 DHwhIqBwWV54i/k/K6silDuZ5Ia/kwzfd8ZukiDts5YYw8ooComF0AJkXUJPCT+G0BZL
 vHdLFj1HXMk0v796dUwH4HZ7P7wXF8dwFvffp+NkVrVlTFHTXjsdtT0y7jEbg6kSaXSA
 mMkaBJQutUMwXidPuWc05HjPNQfs79gVch+/oKRlPFP/d4nznmzCaQuhlNF11+FcPRwj
 4DUw==
X-Gm-Message-State: AJIora/hotdpsJV6YwiKmwuCoxwALese/0nfzCctoX6kg7K+3ZH/UY+u
 8d3RWbcbFQIf+LsKAACcoaMWZcM3MVQ=
X-Google-Smtp-Source: AGRyM1vv6r/E62ofIC5UFXsLs2G5aYFKSOm9cvDt+G5KC1cBhMl0RRw+vOi8NIjcf9Y+uYI6SOuSmQ==
X-Received: by 2002:aa7:d64b:0:b0:43b:1f5d:1443 with SMTP id
 v11-20020aa7d64b000000b0043b1f5d1443mr131438edr.370.1658435831933; 
 Thu, 21 Jul 2022 13:37:11 -0700 (PDT)
Received: from s540.smtp.gmail.com (broadband-90-154-70-5.ip.moscow.rt.ru.
 [90.154.70.5]) by smtp.gmail.com with ESMTPSA id
 dk20-20020a0564021d9400b0043a71775903sm1526428edb.39.2022.07.21.13.37.11
 for <56683 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Jul 2022 13:37:11 -0700 (PDT)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
User-agent: mu4e 1.6.6; emacs 29.0.50
From: Andrey Listopadov <andreyorst@HIDDEN>
Date: Thu, 21 Jul 2022 23:31:35 +0300
In-reply-to: <b7551196d54434aeb8a7@HIDDEN>
Message-ID: <87czdyb3t5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Gregory Heytings <gregory@HIDDEN> writes:

> You would have seen the same bug before the merge, so it's entirely
> unrelated to the merge.  It is present at least in Emacs 24, 25, 26,
> 27 and 28.

Oh, well.  Then it seems that I've simply never noticed this before,
perhaps because Emacs couldn't handle such long lines.  Feel free to
close this then, if this is intended/known.

> They do work with truncated lines, but I suspect that truncated lines
> require specific fixes to work efficiently.

Thanks!  I've asked because It's important to me that Emacs is
responsive if I open a log file with really long lines. Truncated lines
make such logs much easier to read, as I can compare lines above and
below the very long one, without scrolling.

--
Andrey Listopadov

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Jul 2022 20:53:01 +0000
Resent-Message-ID: <handler.56683.B56683.165843677312042 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Andrey Listopadov <andreyorst@HIDDEN>
Cc: 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165843677312042
          (code B ref 56683); Thu, 21 Jul 2022 20:53:01 +0000
Received: (at 56683) by debbugs.gnu.org; 21 Jul 2022 20:52:53 +0000
Received: from localhost ([127.0.0.1]:39327 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEdAD-00038A-2f
	for submit <at> debbugs.gnu.org; Thu, 21 Jul 2022 16:52:53 -0400
Received: from heytings.org ([95.142.160.155]:47114)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gregory@HIDDEN>) id 1oEdA6-00037v-4I
 for 56683 <at> debbugs.gnu.org; Thu, 21 Jul 2022 16:52:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org;
 s=20220101; t=1658436764;
 bh=bXSxR7TegBum2w1FK8PT44ZahkHW1hZrrx96SsSoVLA=;
 h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From;
 b=5DoGpM+FW7EaKdTHnu++4ckzoDfGebSkzfJ7Tdz8y/HgizdkY/vYMkEE7qnvTi+dX
 NyV+l03YrKXStIAfu2LNYQLnNsK+xHJBt6p3Itqpo9RXQe+t0/8XlTvjMOEXd6vr+f
 xaz1qaUfm6byCLYQenLXGuis96pRyDsMdtFtrTDOoF5zr05b6hOZ1a1J6MeQFUy7H+
 k2yfS9vv5lstwRG/mKV6mkHN3Z5A9smOYnQekiIQtWOrzsTHE1aKW2+y7qKdr3pEf5
 BSGt1+2OgndgYHWSO8oUJQ5FB+0e9PLk7/9mg1Ha+FRJDPqk4yD6ONjGmtg6gVZ3uN
 GPyKpi53IJMfA==
Date: Thu, 21 Jul 2022 20:52:44 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <87czdyb3t5.fsf@HIDDEN>
Message-ID: <b7551196d5bd6fb1e821@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <87czdyb3t5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Thanks for your comments.

>> They do work with truncated lines, but I suspect that truncated lines 
>> require specific fixes to work efficiently.
>
> Thanks!  I've asked because It's important to me that Emacs is 
> responsive if I open a log file with really long lines. Truncated lines 
> make such logs much easier to read, as I can compare lines above and 
> below the very long one, without scrolling.
>

How long is a "really long line" in a log file?  Do you think 1000 or 
10000 characters is a reasonable upper limit for your use case?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Andrey Listopadov <andreyorst@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 05:20:01 +0000
Resent-Message-ID: <handler.56683.B56683.16584671558704 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gregory Heytings <gregory@HIDDEN>
Cc: 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.16584671558704
          (code B ref 56683); Fri, 22 Jul 2022 05:20:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 05:19:15 +0000
Received: from localhost ([127.0.0.1]:39854 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEl4E-0002GK-Ow
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 01:19:15 -0400
Received: from mail-ed1-f43.google.com ([209.85.208.43]:43978)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreyorst@HIDDEN>) id 1oEl4C-0002G4-1k
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 01:19:14 -0400
Received: by mail-ed1-f43.google.com with SMTP id v12so4530556edc.10
 for <56683 <at> debbugs.gnu.org>; Thu, 21 Jul 2022 22:19:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=references:user-agent:from:to:cc:subject:date:in-reply-to
 :message-id:mime-version:content-transfer-encoding;
 bh=/ZiYMu7tW08RBQNw37/22XfpW2XPMQUG0GJ/nV2SjsA=;
 b=PxI96U5mjBoGlYWgNVUnbqbXH26EF0seerEqWfd6ccellnghrbacHLI8w7DD1rQm70
 tElTpY8gAhFFjGPjzfyGDMnybaBiTPiJ+Dczn4q47xQ72JdX0BALtz//9Y2v/yt1FsqX
 1IvRS+QH3Uqv7mz5W0qxHimpwJp+tl4jSOIU2rf/tOFb2r9Ah30DoQTSK/prW5sZlVjn
 5LXJ/kb1g6GdcBqiR2LOxhwlo+1XGuHsCmwWh4N8ppoCcFhEN2i6uJv5gxxDyQ+dfbts
 3hA1bzE/NK7sp2d4waZR7789/PID7hb8Lfdmqk9uvQBuxlBhwUvrgPPcBcz7uPWyx92/
 Ppzw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:references:user-agent:from:to:cc:subject:date
 :in-reply-to:message-id:mime-version:content-transfer-encoding;
 bh=/ZiYMu7tW08RBQNw37/22XfpW2XPMQUG0GJ/nV2SjsA=;
 b=Supi7HMevprv0kS3BS2VdqEwq4wLDgdB9O3l1KuPSCyhAY6+U0gom9xM88djYJ/K1B
 H+Q4ZTzEaDiy+UEIqcCqWG9MgUb2xEVCAFnbTDUXCg2NsK7OZb7L/1jtdynFPKwaQyNk
 MMcthGMOzXNSc/be9gOq5sRYQVlDfc8Nhbf+EZInzi76ECXWzQEKnPRpYvub7vEP1BuC
 678ygQdC3/wotm3EIxqrRWHJGZNwI+3TZJuOTHIIf2y6lIIS433Nn21ngWLy0imHmAKB
 4knPzrNDzmmuL6/j3sqKa068pm7zg7jqpW84RD+/TH5Ub9zg33vN/OMETaR34Sa4Br0h
 2vhQ==
X-Gm-Message-State: AJIora/YD+DQEmL1jDf0bVuCg0y/hfJNRGLk4uxxATEw2xLRG4b14Bmg
 C6syEqruzQ5NFbiJzViM0oG56xWPjJE=
X-Google-Smtp-Source: AGRyM1tvSR9KdWgIpwc9pR4M4d5mYJVZJRJieKS3CoUsKybCkWv+4T+6Zdd5Vn27Pav1f7I488lT5A==
X-Received: by 2002:aa7:cac7:0:b0:43a:c5ba:24a6 with SMTP id
 l7-20020aa7cac7000000b0043ac5ba24a6mr1742327edt.84.1658467145846; 
 Thu, 21 Jul 2022 22:19:05 -0700 (PDT)
Received: from s540.smtp.gmail.com (broadband-90-154-70-5.ip.moscow.rt.ru.
 [90.154.70.5]) by smtp.gmail.com with ESMTPSA id
 qc3-20020a170906d8a300b0072b36cbcdaasm1573358ejb.92.2022.07.21.22.19.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Jul 2022 22:19:05 -0700 (PDT)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <87czdyb3t5.fsf@HIDDEN> <b7551196d5bd6fb1e821@HIDDEN>
User-agent: mu4e 1.6.6; emacs 29.0.50
From: Andrey Listopadov <andreyorst@HIDDEN>
Date: Fri, 22 Jul 2022 08:03:27 +0300
In-reply-to: <b7551196d5bd6fb1e821@HIDDEN>
Message-ID: <878rolbu7r.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


> How long is a "really long line" in a log file?  Do you think 1000 or
> 10000 characters is a reasonable upper limit for your use case?

It depends, occasionally there are lines with JSONs maybe one third of
the size of the mentioned dictionary.json.  But these are rare cases,
most of the time the longest lines are about 3000 characters wide, I
guess I have to measure it next time.  So probably a smaller amount than
10000 to enable optimizations is welcome.

One particularly interesting situation is when there are logs which span
such long lines on every line, e.g.:

   1 log-line-with-1800-chars=E2=86=92
   2 log-line-with-3000-chars=E2=86=92
   3 log-line-with-2000-chars=E2=86=92
   4 log-line-with-1500-chars=E2=86=92
     ...
1830 log-line-with-1500-chars

In this case, if I wasn't using truncation I would see only the first
line of the log, wrapped around and taking all screen space, but since
lines are truncated, I have ~70 very long lines displayed on screen.

I've taken dictionary.json, and used C-u 70 M-x duplicate-line, and it
does seem to perform well (or at least Emacs doesn't hang completely),
but there are some occasional slowdowns (Probably because of
show-paren-mode).

--
Andrey Listopadov

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 06:15:01 +0000
Resent-Message-ID: <handler.56683.B56683.165847045714850 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gregory Heytings <gregory@HIDDEN>, Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165847045714850
          (code B ref 56683); Fri, 22 Jul 2022 06:15:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 06:14:17 +0000
Received: from localhost ([127.0.0.1]:39898 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oElvT-0003rR-7S
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:14:16 -0400
Received: from eggs.gnu.org ([209.51.188.92]:54944)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oElvO-0003r8-MW
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:14:14 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38868)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oElvJ-0000Nv-6b; Fri, 22 Jul 2022 02:14:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=xKA4l5kgTNxTyk+KP3Mz00k+bTS4iOaeZaXKqCfiWM0=; b=RToDrMQ3DbvARGFB+CHA
 tKz5N/2q0C+Yf6KCAzpv1FXSOOa2NItUnLCDTC/FlFvqOSmSOCRlNsNvBlXxDZE158su6hoZdYGEg
 MQvTBOwUIax8qm66qzbOT88xUydoXTETHLqgtrba0FaBsTxmT2Ia0yu93WgDb3QV7pi9w3uU56iCM
 VeF7US2C9RBKDa2GUeJoDQ5K1Dvk030FC40Covavl5/1a1o0rvUuJgIkWgH/S/kIc85OR/htxNVKJ
 fNi02zUzGs3mfI5yBj/J8k7EXwohVGdqQhFSIPk5sZErIqou+47MC8RhcuP+KzUfimwU0Q9zroSr2
 CrpmPLieg80sHg==;
Received: from [87.69.77.57] (port=4277 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oElvI-00044v-MX; Fri, 22 Jul 2022 02:14:05 -0400
Date: Fri, 22 Jul 2022 09:13:59 +0300
Message-Id: <83y1wlllnc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <b7551196d5203b87e6ec@HIDDEN> (message from Gregory
 Heytings on Thu, 21 Jul 2022 20:15:55 +0000)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Thu, 21 Jul 2022 20:15:55 +0000
> From: Gregory Heytings <gregory@HIDDEN>
> cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
> 
> > Is this related to the below (from xdisp.c)?
> >
> > #define DISP_INFINITY 10000000
> >
> > Maybe we should make "infinity" somewhat larger?  dictionary.json has a 
> > single line that is 18922365 characters long, so it's "more than 
> > infinity".
> 
> It is indeed, setting DISP_INFINITY to 1000000000 "fixes" that bug. 
> But... how infinite is infinite?  (A near-philosophical question 😉) 
> With a somewhat larger file (that one is only 20 MB) we'd have to increase 
> it again.  If that's a hard-coded limit, I guess it's a sign that we 
> should advise against using toggle-truncate-lines in buffer with long 
> lines.

We could enlarge the value to INT_MAX, or even make the X-coordinate
members of the iterator structure have the type ptrdiff_t and then
DISP_INFINITY could be PTRDIFF_MAX (which would be undesirable in
general for performance reasons).  But that would not solve the
problem completely, because the value is in pixels.  So with the
largest possible line length, which is EMACS_INT_MAX characters long,
we'd need at least 7 or 8 times that for the X-coordinate values, and
we don't have that even in 64-bit builds.

If we want to advise against truncate-lines in such buffers, perhaps
toggle-truncate-lines should ask for confirmation in such cases, and
the documentation should mention the limitation.

Gerd, any ideas or comments?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 06:31:02 +0000
Resent-Message-ID: <handler.56683.B56683.165847144916582 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gregory Heytings <gregory@HIDDEN>, Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165847144916582
          (code B ref 56683); Fri, 22 Jul 2022 06:31:02 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 06:30:49 +0000
Received: from localhost ([127.0.0.1]:39909 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEmBT-0004JN-MM
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:30:48 -0400
Received: from eggs.gnu.org ([209.51.188.92]:57916)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oEmBN-0004J3-Nj
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:30:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38938)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEmBI-0007jX-8v; Fri, 22 Jul 2022 02:30:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=l44QvWwLBDPV7DFMDpf/WnsRKtn+nbMTIxYDsoKX2/Q=; b=qzv5IbY7sNx7NoaDnfUj
 JFvv0CqH7DUidEDg8p1hnb3RidNfOF4OT07xK9qBpvg7GBuEBZ2+k0M4GHSZmPe1k18fml1U/yekI
 hJZ7R4o/PuvENfk5lEBt5d/Pxl8w5DAZe3KH0FTyG9fpaozHTzikvO5GqyVYwaU1z7SGutXEAdz92
 8vnZddZHteOXyh460aYeTdXa7kdmXwpMLOpFLJPqNmFhMv4CLgXpIkYP5VErIm+w9Npg1534G6kw+
 3bJJ4gC3RaR6vSTlTdFFWrg/IEjersrG35xSbp4Tii0uwEySlYzcR0JOb4Zyzmr21Q38srLECtozH
 q+dbdX4Bptb3vg==;
Received: from [87.69.77.57] (port=1308 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEmBG-0006ll-KX; Fri, 22 Jul 2022 02:30:35 -0400
Date: Fri, 22 Jul 2022 09:30:28 +0300
Message-Id: <83wnc5lkvv.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <b7551196d54434aeb8a7@HIDDEN> (message from Gregory
 Heytings on Thu, 21 Jul 2022 19:45:19 +0000)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 56683 <at> debbugs.gnu.org
> Date: Thu, 21 Jul 2022 19:45:19 +0000
> From: Gregory Heytings <gregory@HIDDEN>
> 
> > As a side question, does these optimizations work with truncated lines? 
> > As far as I can tell Emacs is not as responsive as when the lines are 
> > wrapped, but I don't know how to measure this precisely.
> 
> They do work with truncated lines, but I suspect that truncated lines 
> require specific fixes to work efficiently.

I think we should take look at this fragment from hscroll_window_tree:

	      /* Move iterator to pt starting at cursor_row->start in
		 a line with infinite width.  */
	      init_to_row_start (&it, w, cursor_row);
	      if (hscl)
		it.first_visible_x = window_hscroll_limited (w, it.f)
				     * FRAME_COLUMN_WIDTH (it.f);
	      it.last_visible_x = DISP_INFINITY;
	      move_it_in_display_line_to (&it, pt, -1, MOVE_TO_POS);
	      /* If the line ends in an overlay string with a newline,
		 we might infloop, because displaying the window will
		 want to put the cursor after the overlay, i.e. at X
		 coordinate of zero on the next screen line.  So we
		 use the buffer position prior to the overlay string
		 instead.  */
	      if (it.method == GET_FROM_STRING && pt > 1)
		{
		  init_to_row_start (&it, w, cursor_row);
		  if (hscl)
		    it.first_visible_x = (window_hscroll_limited (w, it.f)
					  * FRAME_COLUMN_WIDTH (it.f));
		  move_it_in_display_line_to (&it, pt - 1, -1, MOVE_TO_POS);
		}

Specifically, init_to_row_start can potentially start from a very far
away buffer position, especially in buffers with a single long line,
and AFAICT the subroutines called by init_to_row_start aren't
restricted to the "narrowing" for long lines, so they go to BOB in
this case.  The problem here is that this code handles automatic
hscrolling, so any changes to it need to be careful not to destroy the
use case of moving point horizontally to a position that is beyond the
right or left window edge (which is what auto-hscroll is for).

Alternatively, maybe automatic hscrolling should be disabled in such
buffers (or we should advise that), and then we should have convenient
commands to hscroll manually so as to bring point into the view.
(Maybe we even have such commands already, I don't know.)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 06:35:02 +0000
Resent-Message-ID: <handler.56683.B56683.165847166716926 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Andrey Listopadov <andreyorst@HIDDEN>
Cc: 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165847166716926
          (code B ref 56683); Fri, 22 Jul 2022 06:35:02 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 06:34:27 +0000
Received: from localhost ([127.0.0.1]:39913 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEmF1-0004Ow-6U
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:34:27 -0400
Received: from heytings.org ([95.142.160.155]:47590)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gregory@HIDDEN>) id 1oEmEz-0004Oo-H3
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:34:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org;
 s=20220101; t=1658471664;
 bh=wCJab4sMiSmEM9+x+Qdp0hTmBIlcWeIWO9zdwR8WLKQ=;
 h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From;
 b=WpSgOVljRDniTl2akJS+wpmE5Yso5fQiMjQbzQHAP0yFn4WevME6+ZLMOI6fQPMmm
 kYA8PCbc0n6QUh4E1bVHKI/+V6yRoJzX31Ftm+RXrjpJLBvdOdeatGcW8ANtDCi7Gi
 0BZ5X+VRSZdE8OplStd2Ts7/VzG4Am6D6CLTuQjamB/iQ9ii71S6aCQ4rEH462BeSZ
 q+xj/W3BRZm/bVinizmpDKOWFHcaMw3OJXhSXBc+J8yvMPQAsFf2nb/6mUjG6/wRNT
 iqhxeFjDoeVdnNartGBkDGTMqZRdWoCa3EuPKQwwX6Ytnx0XIhiKJ3dYyOeuAjcNvd
 K1KHO481VuBrg==
Date: Fri, 22 Jul 2022 06:34:23 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <878rolbu7r.fsf@HIDDEN>
Message-ID: <174616cd5c921541f5b8@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <87czdyb3t5.fsf@HIDDEN> <b7551196d5bd6fb1e821@HIDDEN>
 <878rolbu7r.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="XFS5cle5tR"
Content-ID: <174616cd5ce86bbf14ad@HIDDEN>
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--XFS5cle5tR
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-ID: <174616cd5cb179a0fd05@HIDDEN>


Thanks again for your comments.

>
> It depends, occasionally there are lines with JSONs maybe one third of=20
> the size of the mentioned dictionary.json.  But these are rare cases,=20
> most of the time the longest lines are about 3000 characters wide, I=20
> guess I have to measure it next time.  So probably a smaller amount than=
=20
> 10000 to enable optimizations is welcome.
>

FTR, in buffers with lines that are "only" 3000 characters wide, long line=
=20
optimizations are not turned on by default (see long-line-threshold, which=
=20
is set to 10000 by default), such buffers should behave "well enough"=20
without them.

>
> One particularly interesting situation is when there are logs which span=
=20
> such long lines on every line, e.g.:
>
>   1 log-line-with-1800-chars=E2=86=92
>   2 log-line-with-3000-chars=E2=86=92
>   3 log-line-with-2000-chars=E2=86=92
>   4 log-line-with-1500-chars=E2=86=92
>     ...
> 1830 log-line-with-1500-chars
>
> In this case, if I wasn't using truncation I would see only the first=20
> line of the log, wrapped around and taking all screen space, but since=20
> lines are truncated, I have ~70 very long lines displayed on screen.
>

I understand.  It's an interesting use case.

>
> I've taken dictionary.json, and used C-u 70 M-x duplicate-line, and it=20
> does seem to perform well (or at least Emacs doesn't hang completely),=20
> but there are some occasional slowdowns (Probably because of=20
> show-paren-mode).
>

At the moment I think it would be better to advise against using truncated=
=20
lines for such pathological files.  As Eli just said, it would probably be=
=20
rather complex to remove the hard-coded limit in the Emacs display engine.
--XFS5cle5tR--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 06:53:01 +0000
Resent-Message-ID: <handler.56683.B56683.165847272818823 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, Gregory Heytings <gregory@HIDDEN>
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165847272818823
          (code B ref 56683); Fri, 22 Jul 2022 06:53:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 06:52:08 +0000
Received: from localhost ([127.0.0.1]:39929 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEmW8-0004tW-1q
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:52:08 -0400
Received: from mail-ed1-f43.google.com ([209.85.208.43]:38861)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gerd.moellmann@HIDDEN>) id 1oEmW5-0004t2-MD
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:52:06 -0400
Received: by mail-ed1-f43.google.com with SMTP id m13so4710695edc.5
 for <56683 <at> debbugs.gnu.org>; Thu, 21 Jul 2022 23:52:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=bd8ZMSbMdqRuA6aUI7q6D2+1VC/JxQhPv/9Hwu0j/l0=;
 b=VLEOfv99OYWnN9+JOiBpkAa5c871/b/pihxxydXE0C9dnue/fpYiaBccHHzQAjEEop
 LT/8RKpawyThrn+20SoqjFFd5Ti5UD+C3nHIfgXUhCQMxzIeEzrGbDjMqY9XmUitlStk
 q8PqK4M2eHwXy+b/tf27ePmpIYbV+QyTn9N6GOSu9ffwSXmZqqbcpacdl0Fx86MpPt8t
 ASJ9T3p+jRaLlcmw6iU8EpS7BZOvqIcbRZR/7s+X9d7mETXVpDWJC5Pj1TagmQika0Sb
 Y55Zk6eQujz4hJIBnKSdKNwy+k48z2VpQ98YvIAgXBlEadMPx2IPyYf1i9XT19bRyOoI
 MvZw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=bd8ZMSbMdqRuA6aUI7q6D2+1VC/JxQhPv/9Hwu0j/l0=;
 b=Kq5pnrdLljoiinODD7F68/uWE9vUOjfprHPe01yYq5r3RwADqb3LiDWs+0IVp4TR04
 xUGBYpqV5re9llQ6xtHQtsHK+BsDfVQma1wi7WtG7vcGyrPrqiZC1Nv0/wKUFc70U6Xv
 PO0UGLAyWhIDw+BFg/SjqtmxG6KJyOJfnVm4nugsOpxjpLNIBsUIc5ARSKkKfF0Kh+9W
 xxsNQakI+HD22GupQE5HuYCRy3h9zu7E+2/f/rkNaSgEedP17qB1z59XToBhYkHJcgef
 o4iUMc7yUIkAqPjAdiDW6mpkM6h1YzebrgW5UoAP1auvmL2m9YqFfpBHH6hGvDlF9TaM
 BqEA==
X-Gm-Message-State: AJIora8tatO//hnoYbdh9nAAcRqo/IR/MdOqx9vVAA+VOayYyONshTUh
 2TxtH3VN0H5Qqq0z6it6tIRku7m1qzl/jw==
X-Google-Smtp-Source: AGRyM1uOQAOF8lx7ng5v5QuRhVskM/eHkZzXLPKA13Lyhji81B2dwFgIhz6sdxCnkPgNKeX8y3KMNg==
X-Received: by 2002:a05:6402:1e8c:b0:43a:c57f:2cbb with SMTP id
 f12-20020a0564021e8c00b0043ac57f2cbbmr2019553edf.97.1658472718526; 
 Thu, 21 Jul 2022 23:51:58 -0700 (PDT)
Received: from Mini.fritz.box (p4fe3a8ba.dip0.t-ipconnect.de. [79.227.168.186])
 by smtp.gmail.com with ESMTPSA id
 ku7-20020a170907788700b007052b183d51sm1653793ejc.132.2022.07.21.23.51.57
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Jul 2022 23:51:57 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <83y1wlllnc.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 22 Jul
 2022 09:13:59 +0300")
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN>
Date: Fri, 22 Jul 2022 08:51:56 +0200
Message-ID: <m2pmhxabcj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Date: Thu, 21 Jul 2022 20:15:55 +0000
>> From: Gregory Heytings <gregory@HIDDEN>
>> cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
>>=20
>> > Is this related to the below (from xdisp.c)?
>> >
>> > #define DISP_INFINITY 10000000
>> >
>> > Maybe we should make "infinity" somewhat larger?  dictionary.json has =
a=20
>> > single line that is 18922365 characters long, so it's "more than=20
>> > infinity".
>>=20
>> It is indeed, setting DISP_INFINITY to 1000000000 "fixes" that bug.=20
>> But... how infinite is infinite?  (A near-philosophical question =F0=9F=
=98=89)

Don't think too much about it, it didn't do good to Georg Cantor.  BTW,
Omega would be a really cool name for that INFINITY; the smallest
position beyond all finite x.

>> With a somewhat larger file (that one is only 20 MB) we'd have to increa=
se=20
>> it again.  If that's a hard-coded limit, I guess it's a sign that we=20
>> should advise against using toggle-truncate-lines in buffer with long=20
>> lines.
>
> We could enlarge the value to INT_MAX, or even make the X-coordinate
> members of the iterator structure have the type ptrdiff_t and then
> DISP_INFINITY could be PTRDIFF_MAX (which would be undesirable in
> general for performance reasons).  But that would not solve the
> problem completely, because the value is in pixels.  So with the
> largest possible line length, which is EMACS_INT_MAX characters long,
> we'd need at least 7 or 8 times that for the X-coordinate values, and
> we don't have that even in 64-bit builds.
>
> If we want to advise against truncate-lines in such buffers, perhaps
> toggle-truncate-lines should ask for confirmation in such cases, and
> the documentation should mention the limitation.
>
> Gerd, any ideas or comments?

I had to look around a bit, because I didn't remember that constant.  It
seems to have been introduced for horizontal scroll bars, I think.

If we really want infinity, how about setting last_visible_x to -1 in
that case.  But that requires checking/changing some places where
the iterator pisition is tested against last_visible_x.

I think that's okay.  WDYT?

Your "ticks" check kicks in should be burn to much time because of the
infinite last x, right?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 06:54:02 +0000
Resent-Message-ID: <handler.56683.B56683.165847282418978 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, Gregory Heytings <gregory@HIDDEN>
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165847282418978
          (code B ref 56683); Fri, 22 Jul 2022 06:54:02 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 06:53:44 +0000
Received: from localhost ([127.0.0.1]:39933 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEmXg-0004w2-H9
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:53:44 -0400
Received: from mail-ej1-f49.google.com ([209.85.218.49]:36705)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gerd.moellmann@HIDDEN>) id 1oEmXc-0004vm-RG
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 02:53:43 -0400
Received: by mail-ej1-f49.google.com with SMTP id mf4so7036889ejc.3
 for <56683 <at> debbugs.gnu.org>; Thu, 21 Jul 2022 23:53:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :user-agent:mime-version;
 bh=fiUWveomm1YcddzY5jwy4HJmw2RhdkvDL6Fr07CfZRs=;
 b=H/ZA2Tjt1VulEWofoFWFqQJnmD0FI8wK0ZOaHn35ia09AGEz5FpmIt+4rjM/ENLjT8
 dvAeF1ZDcNSiewTHx4thRyj5TqG7AZIDEgecKfKu7nTfKbps4aiBS3vAZSrU6g5k9e7+
 fP/blKBIOoE2bvcDi20UqUV8p0cWGebj76iU8ZLAJHF3rT7/96KYZrM6Ya2oKY8pl0X+
 47ppVdqgrvIsPPCn9emzrgI/VrDcK9Ugv7xCROjkRx1Kvo3IlUXEDndNXLqCAJPhvp6b
 eOtkZPQsPtR69IBDmJBm3NxDR6HrwpDLGg5B1EYVzCWQpUwkiKyhfkcPDuY9cYO7sxH+
 t6dQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:user-agent:mime-version;
 bh=fiUWveomm1YcddzY5jwy4HJmw2RhdkvDL6Fr07CfZRs=;
 b=RtLN/BPiRY1ketYxjOth0aSkstBvSuT94ArmUJQyUHEQJ3KMuTVDvpV55EW+0cuGXB
 CgErp3jkCSBMgpbnD2/7Nds5c1GqnV6TDi9StN7zNJpztaWEUZHNndlC8u4eErG54OMe
 DQ0hhaJQNWu9Iq9IJPG8LmbfDWLc9iUD0QcXteHo16sF8HvP5avFBrIE85vY+xx2dkKy
 OHQVclUM/ROpfWC17aNElZgJHe0PxAB2kksP8Ov5/aFwKQCQofbiPj6msFxbhQdcRzsl
 xcMMlYzOKbJAgstjBHWwLAzv/YSQiSlc3NWUkfDxXfmEgd1lxwnLeH4ubLrDGqbD8rsb
 xSzg==
X-Gm-Message-State: AJIora+jiHiEJ6BUUGm33xtYJ1lsFqacpMUqUYkUeXxefJ5Dubqb4zIq
 yshcWXNSMh0oux7s4e6M0Zj54p1DTjtzzg==
X-Google-Smtp-Source: AGRyM1u04WBGQyCb319fKFEF14RGfGc7jVEz2PyhMILS0w9KAMT5jYhywlLdgOzbMb5bMli43bI7Kw==
X-Received: by 2002:a17:907:9806:b0:72b:9b29:7d34 with SMTP id
 ji6-20020a170907980600b0072b9b297d34mr2034918ejc.466.1658472814436; 
 Thu, 21 Jul 2022 23:53:34 -0700 (PDT)
Received: from Mini.fritz.box (p4fe3a8ba.dip0.t-ipconnect.de. [79.227.168.186])
 by smtp.gmail.com with ESMTPSA id
 s20-20020a05640217d400b0043baadb2279sm2148728edy.59.2022.07.21.23.53.33
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Jul 2022 23:53:33 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <83y1wlllnc.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 22 Jul
 2022 09:13:59 +0300")
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN>
Date: Fri, 22 Jul 2022 08:53:33 +0200
Message-ID: <m2mtd1ab9u.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> Gerd, any ideas or comments?

Forgot one thing:  There seem to be a place in dispextern.h where
last_visible_x is set to the number 1000000.  That's odd.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 07:29:01 +0000
Resent-Message-ID: <handler.56683.B56683.165847491922591 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, Gregory Heytings <gregory@HIDDEN>
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165847491922591
          (code B ref 56683); Fri, 22 Jul 2022 07:29:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 07:28:39 +0000
Received: from localhost ([127.0.0.1]:40016 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEn5T-0005sC-7A
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:28:39 -0400
Received: from mail-ed1-f47.google.com ([209.85.208.47]:34797)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gerd.moellmann@HIDDEN>) id 1oEn5O-0005re-HI
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:28:37 -0400
Received: by mail-ed1-f47.google.com with SMTP id x91so4830524ede.1
 for <56683 <at> debbugs.gnu.org>; Fri, 22 Jul 2022 00:28:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :user-agent:mime-version;
 bh=sxURHxjMdzMe9e+t7JyhVzxNo54S6PGBjRSwg6jaQZg=;
 b=O9XQsouHatay4o5hjqVnjXJBemrRvjntCEp6F/Qwcu8+p036+3FQvB1NZ4he5PCY0I
 +ieD8r1Y0HfhAnNlsiKUS+bq6MX0aVEe1MwqrHbLHDQVJtsp0MmWW2gOI6AeGt9BG+qD
 UyUtjyRh7UpUt8eJ8+TFpxP0Dt86dxcUUe1rztda6f4QQMY5M3EaLp52t00x0PO/5u5r
 rjEAcgUp9jgGaE+1LdpPiGuLffdVoLtPx0Z+5tSs7blxYmndLhRSBoH6cByRMMJwScfb
 d18iZZD7HIE49xpMmg8lyCSODwbSZufdWMpnG7xHzYuHkqE6NapT56USWy61R0SrN0Js
 NXbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:user-agent:mime-version;
 bh=sxURHxjMdzMe9e+t7JyhVzxNo54S6PGBjRSwg6jaQZg=;
 b=KncJ69/c2HxuMkD6h6Lkhgn515HRG+Yr5cMTswgDLgLWpOJHofeg2Lmys+sZbyEX91
 5eGUjkSrAkbLUC7TEDHOylXDsFIGiPx18mcaZ2YgxLfJw4QXf1Pk2Xo3fmBAmiPM1zrB
 KiDuIUTCiLT9tWSl4HPFQp1G1eb1iG5D5lj4tgnMkuJybVDWXjFVvrQCzPtJ4Z3CSnhw
 wvj7J9M3FCxcaGpZazRvJkK2hKpbBpAIVMFGSM2LALLCueGuFhVYB/9o++qFlrjRHGRU
 N81QlMQGgd7HWZvCXCWZJQAx1ggzu0S9+j0J8qgbR3H+zBPSQhQF8aEea0b/clzRMxWY
 OMfw==
X-Gm-Message-State: AJIora+mkW4MIMzywTW1aLhpWQ9nqsEOvtd773VWvRFCkv0Xpk+7u28x
 QzHx5BI478RqywE1JmLitnWrXhkjtMSbbg==
X-Google-Smtp-Source: AGRyM1vrudUE/o8YT0IDjK9o8BB0mdXGGhOpSSAU5yeQO25Iu3JaJu4m1fU/NMW4pErUKv4e/RtBpw==
X-Received: by 2002:a05:6402:5289:b0:43b:69a9:38c8 with SMTP id
 en9-20020a056402528900b0043b69a938c8mr2193392edb.263.1658474908125; 
 Fri, 22 Jul 2022 00:28:28 -0700 (PDT)
Received: from Mini.fritz.box (p4fe3a8ba.dip0.t-ipconnect.de. [79.227.168.186])
 by smtp.gmail.com with ESMTPSA id
 lb8-20020a170907784800b00722e52d043dsm1698300ejc.114.2022.07.22.00.28.26
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Jul 2022 00:28:27 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <83wnc5lkvv.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 22 Jul
 2022 09:30:28 +0300")
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83wnc5lkvv.fsf@HIDDEN>
Date: Fri, 22 Jul 2022 09:28:26 +0200
Message-ID: <m2k085a9np.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> I think we should take look at this fragment from hscroll_window_tree:
>
> 	      /* Move iterator to pt starting at cursor_row->start in
> 		 a line with infinite width.  */
> 	      init_to_row_start (&it, w, cursor_row);
> 	      if (hscl)
> 		it.first_visible_x = window_hscroll_limited (w, it.f)
> 				     * FRAME_COLUMN_WIDTH (it.f);
> 	      it.last_visible_x = DISP_INFINITY;
> 	      move_it_in_display_line_to (&it, pt, -1, MOVE_TO_POS);
> 	      /* If the line ends in an overlay string with a newline,
> 		 we might infloop, because displaying the window will
> 		 want to put the cursor after the overlay, i.e. at X
> 		 coordinate of zero on the next screen line.  So we
> 		 use the buffer position prior to the overlay string
> 		 instead.  */
> 	      if (it.method == GET_FROM_STRING && pt > 1)
> 		{
> 		  init_to_row_start (&it, w, cursor_row);
> 		  if (hscl)
> 		    it.first_visible_x = (window_hscroll_limited (w, it.f)
> 					  * FRAME_COLUMN_WIDTH (it.f));
> 		  move_it_in_display_line_to (&it, pt - 1, -1, MOVE_TO_POS);
> 		}
>
> Specifically, init_to_row_start can potentially start from a very far
> away buffer position, especially in buffers with a single long line,

I'm not sure. Cursor_row comes from here:

	  if (w->cursor.vpos < bottom_row - w->desired_matrix->rows)
	    cursor_row = MATRIX_ROW (w->desired_matrix, w->cursor.vpos);
	  else
	    cursor_row = bottom_row - 1;

	  if (!cursor_row->enabled_p)
	    {
	      bottom_row = MATRIX_BOTTOM_TEXT_ROW (w->current_matrix, w);
	      if (w->cursor.vpos < bottom_row - w->current_matrix->rows)
		cursor_row = MATRIX_ROW (w->current_matrix, w->cursor.vpos);
	      else
		cursor_row = bottom_row - 1;
	    }

In my own words, either cursor_row has just been produced in the
desired_matrix, or it has been produced previously, and is now part of
the current matrix.

Doesn't that mean it was already subject to the iterator narrowing?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 07:30:02 +0000
Resent-Message-ID: <handler.56683.B56683.165847494222662 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165847494222662
          (code B ref 56683); Fri, 22 Jul 2022 07:30:02 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 07:29:02 +0000
Received: from localhost ([127.0.0.1]:40027 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEn5q-0005tI-45
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:29:02 -0400
Received: from eggs.gnu.org ([209.51.188.92]:39622)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oEn5o-0005sn-27
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:29:00 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:40096)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEn5i-0003Mq-C3; Fri, 22 Jul 2022 03:28:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=Utfk6QxtPfqB1nQ6JG5ENR254W8FiVfsFymU5Q0j9Z4=; b=Nb8wLTMT9LbjBpPg7Yef
 ZyGwmFRyhUttvkJZJ+n3d7v7ySnAFy5uIgmRIDyMjJCh3ASliEjiIck7BNK1fEl+YDCkzYOMXxYSj
 xacve1FAbBUClPZv+oaSn59gTLhPgugOvfBU8oH1z+WAwg4LEvmL0lGKHQmK270/pJtTPW0ZLNdZV
 OsVnCb+yNm3+32lQzMN7y02DWIhSETyYx9y1eA8Nhb1RKvEd4rKcrlENYWw6Hl2gtNaURXcUCStgP
 506gdRoJ68pwK4eOOEuAKpidM9BLp0+EGN3mi0EajxTYnsBq64oCZhFdD5ZmsTpSlV87yu7mlJ3Tu
 ShOCnUTlMEUtlQ==;
Received: from [87.69.77.57] (port=4885 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEn5h-0007U2-I6; Fri, 22 Jul 2022 03:28:54 -0400
Date: Fri, 22 Jul 2022 10:28:47 +0300
Message-Id: <83mtd1li6o.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <m2pmhxabcj.fsf@HIDDEN> (message from Gerd
 =?UTF-8?Q?M=C3=B6llmann?= on Fri, 22 Jul 2022 08:51:56 +0200)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Gerd Möllmann <gerd.moellmann@HIDDEN>
> Cc: Gregory Heytings <gregory@HIDDEN>,  andreyorst@HIDDEN,
>   56683 <at> debbugs.gnu.org
> Date: Fri, 22 Jul 2022 08:51:56 +0200
> 
> If we really want infinity, how about setting last_visible_x to -1 in
> that case.  But that requires checking/changing some places where
> the iterator pisition is tested against last_visible_x.

I don't really see how this could help in general, because the
current_x member (what you call the "iterator position") will still
overflow at some point, and we can no longer do any layout decisions
for the X coordinate after that.

Or what am I missing?

> Your "ticks" check kicks in should be burn to much time because of the
> infinite last x, right?

Sorry, I don't think I understand what you are asking here.  Please
elaborate or rephrase.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 07:32:01 +0000
Resent-Message-ID: <handler.56683.B56683.165847510531236 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165847510531236
          (code B ref 56683); Fri, 22 Jul 2022 07:32:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 07:31:45 +0000
Received: from localhost ([127.0.0.1]:40033 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEn8S-00087k-P1
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:31:45 -0400
Received: from eggs.gnu.org ([209.51.188.92]:40092)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oEn8R-00087W-73
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:31:43 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:40160)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEn8L-0004fL-OD; Fri, 22 Jul 2022 03:31:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=OjTkeH5hG7F4E9prUyFheVcrUSZNRpHA9loe5wlNX7o=; b=S+aPgUsLReI6Pyzbbuw1
 MeoU36NgJYUP+ILyY6eQs6JtDJsKfY28NX5U83OOKzzUN2gUWJE2i/QCpv9Caq3THlmt6E7la747D
 1kmHijKHKjypP0RjgAfegGVc+snXfmcEdhU6j/fRW/MxWdfsoyNyVt7zBiaFjiRRkPXTJmsXR5BAN
 okA7fwJZcxWkF0fXwLxmpyG5OKXIXc78z3T/fH1/TmgWS9yvvUI2CUdFGlKwJwtRiAQtJ3qS+Vd1T
 OUTRZCBX/OpDqb5h2+ie827GIkRjGalZrFwRxbhFVKFu6lzSaYoVacEg5eMmFc/TN98SuUg4e7r+5
 pQHmuQBsr8a/dg==;
Received: from [87.69.77.57] (port=1073 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEn8F-00082I-41; Fri, 22 Jul 2022 03:31:34 -0400
Date: Fri, 22 Jul 2022 10:31:26 +0300
Message-Id: <83leslli29.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <m2mtd1ab9u.fsf@HIDDEN> (message from Gerd
 =?UTF-8?Q?M=C3=B6llmann?= on Fri, 22 Jul 2022 08:53:33 +0200)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2mtd1ab9u.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Gerd M�llmann <gerd.moellmann@HIDDEN>
> Cc: Gregory Heytings <gregory@HIDDEN>,  andreyorst@HIDDEN,
>   56683 <at> debbugs.gnu.org
> Date: Fri, 22 Jul 2022 08:53:33 +0200
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> > Gerd, any ideas or comments?
> 
> Forgot one thing:  There seem to be a place in dispextern.h where
> last_visible_x is set to the number 1000000.  That's odd.

That's a different kind of "infinity" ;-)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 07:53:01 +0000
Resent-Message-ID: <handler.56683.B56683.1658476348954 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.1658476348954
          (code B ref 56683); Fri, 22 Jul 2022 07:53:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 07:52:28 +0000
Received: from localhost ([127.0.0.1]:40045 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEnSW-0000FK-0F
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:52:28 -0400
Received: from mail-ed1-f46.google.com ([209.85.208.46]:33776)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gerd.moellmann@HIDDEN>) id 1oEnSU-0000F3-BP
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:52:26 -0400
Received: by mail-ed1-f46.google.com with SMTP id t3so4915618edd.0
 for <56683 <at> debbugs.gnu.org>; Fri, 22 Jul 2022 00:52:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=ZVtNaqbscSx/QjKIfu8vljzZWfIJO2VappmX3C8ucyY=;
 b=WPZtzQVGv22yEzJzkcf3QxJegLKDNqZjf3SES0E0QDeUl8zWlGXhyrqCpozb7xdVs+
 VgE0nwcEluhi3BVMW4T1HF8dUOMi8eCLBuTibfzDOWUQh7vYM8kiLT8Wg6jD+S9Kv9lY
 JFL2bWQTrl37VyfD2//HhesF/mvtELIjgnZz2eJFgLgQikZ+nS/lBoohqTwXKM0WEao9
 ny1oHuh+WYdaYMqBX7Duy29ZT2bxedQVbdlebxE/9SuuCGfwkKYt6hmQ6tJdrD/tRTiq
 SeQEDvqSG7Ncdx0+wN5xrjSS6zQyhfgXzFy8naa91sMkaetk/Y4/aWFoJ8IjqXZ2EBjM
 Wxmg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=ZVtNaqbscSx/QjKIfu8vljzZWfIJO2VappmX3C8ucyY=;
 b=TZnlswxNS6iauAd4ODhpLerkABcD4Us8MU6rQDhtwmiCkIhGrUODN+h/tS/5hixhwV
 Lv1gQ4ETb2gsR+ToR0nyNHOT+i4Clb+TSE80JVRq4in1e6tmW2tObPI+C+/ZC810mRoJ
 R0MxRrEz6UVH9pdSnwc+ftEbnp6YoXEVZfgFpi7Ig797YFmLFu6WzmfBPFU/P86Gqdyd
 QqkdcBku8qZ9Q7P2R/V71or7Fdu1HZGSrBY1KICLomdF3fWS0A1Z4uAwdGky1S9f0M71
 wZno3k4WJ7ad5pigrKiupw7n5y8wwMtr+S+O85d8DrERkLxWZNmAfGFYKMTkIHgMKD5x
 0kAg==
X-Gm-Message-State: AJIora9A6clVVIcEjZwcT9FVc7Bfz6qMwfZ5Q5HQcop5NaPd89vKoVDQ
 ysL9kmI9vzumhO7RENl6DoY=
X-Google-Smtp-Source: AGRyM1tUFXaIJW7IGQGv0wqx+osDvUzR5tOJoANca2l3cfZ95oBFXWf3KZAeIrLuxvw/kljmhKyPlg==
X-Received: by 2002:a05:6402:2395:b0:43a:6d91:106c with SMTP id
 j21-20020a056402239500b0043a6d91106cmr2247746eda.299.1658476338007; 
 Fri, 22 Jul 2022 00:52:18 -0700 (PDT)
Received: from Mini.fritz.box (p4fe3a8ba.dip0.t-ipconnect.de. [79.227.168.186])
 by smtp.gmail.com with ESMTPSA id
 w23-20020a17090649d700b0072b33e91f96sm1713686ejv.190.2022.07.22.00.52.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Jul 2022 00:52:17 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <83mtd1li6o.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 22 Jul
 2022 10:28:47 +0300")
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN>
Date: Fri, 22 Jul 2022 09:52:16 +0200
Message-ID: <m2edyda8jz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN>
>> If we really want infinity, how about setting last_visible_x to -1 in
>> that case.  But that requires checking/changing some places where
>> the iterator pisition is tested against last_visible_x.
>
> I don't really see how this could help in general, because the
> current_x member (what you call the "iterator position") will still
> overflow at some point, and we can no longer do any layout decisions
> for the X coordinate after that.
>
> Or what am I missing?

You were asking for a good value of DISP_OMEGA, that's at least what I
understood.  My answer is -1, plus code changes.

That current_x can overflow is something completely different, IMO.  But
now I'm cautious enough to ask what do you mean?  Overflowing which
bound?  I read this as integer overflow, integer =3D the data type.

>
>> Your "ticks" check kicks in should be burn to much time because of the
>> infinite last x, right?
>
> Sorry, I don't think I understand what you are asking here.  Please
> elaborate or rephrase.

The thing you implemented in set_iterator_to_next we talked about.

  if (max_redisplay_ticks > 0)
    update_redisplay_ticks (1, it->w);

I don't remember the offical name ATM.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 07:54:01 +0000
Resent-Message-ID: <handler.56683.B56683.16584764231134 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.16584764231134
          (code B ref 56683); Fri, 22 Jul 2022 07:54:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 07:53:43 +0000
Received: from localhost ([127.0.0.1]:40072 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEnTi-0000ID-VT
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:53:43 -0400
Received: from mail-ej1-f54.google.com ([209.85.218.54]:34357)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gerd.moellmann@HIDDEN>) id 1oEnTg-0000I0-SW
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 03:53:41 -0400
Received: by mail-ej1-f54.google.com with SMTP id oy13so7250902ejb.1
 for <56683 <at> debbugs.gnu.org>; Fri, 22 Jul 2022 00:53:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :user-agent:mime-version;
 bh=NkNnJD3M7wt+GooSAO0iQ/ZP246GTPCDwOW8Wwy0GS0=;
 b=lSpr0uXjH87MAf72EHrvr+3nRAmmfsly735k+xlskuE52JAFa4U6UFFlkXCKpvazRq
 0fOyIzmf8/5ynBN5a1RfZ0k22FhrZd3d6XOLos+9Z2sejACzmHwpHplApc7GU2j0Ngfd
 snSv2LtbWYhP8uR8mYtdzNqlztFuYHjHcv4kV0peyNgb0JfT/tNGFsFtO03pWpUngHCH
 uBEENqv6N4ZHhI0nK/64K0wjxbSOw9/APPBg36VRk9Wt7DOtqYAgWh6NDMBHTGcCl2ys
 W0BoN+xEILH2LOD+4nY31cx1llYbcepYpgv1d4CrThxAFVvMTD1zrP1q9YOUj01NtAeB
 s+5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:user-agent:mime-version;
 bh=NkNnJD3M7wt+GooSAO0iQ/ZP246GTPCDwOW8Wwy0GS0=;
 b=kESoqFxGGnLjizj64rCBAGKzh4Lim/Nric+afiMU3iUjpoJCCqEuKHjOXulmiu84Zw
 oGsI3x70Hhix2+f7sZlosBF4VzJsNY1K30TIu7ywTPHJShdDd1NTa9yxnxRgG84QXeAD
 GfznM9fOFWPqa8eyYJm/AIDyXrv8TqeGaNutFDLnE0++ZPpvuBlsWi2s81MEte9/6Mhg
 FhN8sgL6TorLkrwJbkyZmup9EoSiIH3RvEgMZqsNKVq+YYnyzfQHVAUBr4KBAf6XXDHr
 QeQC7da8wcVhxVQYpgdkmMbgUERFt4CPz7VBkjmVMQZdlfu7DNplPSXw4YU+Brb6Fxrt
 xddA==
X-Gm-Message-State: AJIora8+6lgAplKGILX4UXGmMFK0XDmvvAsb/LzGNtnYkA/cKx+ylt4u
 YunssWoVMgiUDUWwUad5ev8=
X-Google-Smtp-Source: AGRyM1sWgYv6ttqPsl2800HtZRuXPtLfQo2XUMdVL5A4NwyvrKZLZs1PxCm1Uy0H5toCaLj7juab7g==
X-Received: by 2002:a17:907:86ac:b0:72b:87f6:75c2 with SMTP id
 qa44-20020a17090786ac00b0072b87f675c2mr2163502ejc.667.1658476414899; 
 Fri, 22 Jul 2022 00:53:34 -0700 (PDT)
Received: from Mini.fritz.box (p4fe3a8ba.dip0.t-ipconnect.de. [79.227.168.186])
 by smtp.gmail.com with ESMTPSA id
 d32-20020a056402402000b00438ac12d6b9sm2151599eda.52.2022.07.22.00.53.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Jul 2022 00:53:34 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <83leslli29.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 22 Jul
 2022 10:31:26 +0300")
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2mtd1ab9u.fsf@HIDDEN>
 <83leslli29.fsf@HIDDEN>
Date: Fri, 22 Jul 2022 09:53:33 +0200
Message-ID: <m2bktha8hu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Forgot one thing:  There seem to be a place in dispextern.h where
>> last_visible_x is set to the number 1000000.  That's odd.
>
> That's a different kind of "infinity" ;-)

Aleph1 :-O.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 11:03:02 +0000
Resent-Message-ID: <handler.56683.B56683.165848772921223 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165848772921223
          (code B ref 56683); Fri, 22 Jul 2022 11:03:02 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 11:02:09 +0000
Received: from localhost ([127.0.0.1]:40222 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEqQ5-0005WE-Hv
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 07:02:09 -0400
Received: from eggs.gnu.org ([209.51.188.92]:52754)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oEqQ2-0005Vl-HP
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 07:02:08 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56366)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEqPx-000479-0T; Fri, 22 Jul 2022 07:02:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=GyldM6Dj/XRtiA5HHXNgd8r+EqtkqRz6l4YeCkEXpCw=; b=FVfYXAFCBw0MXWBBrBG/
 ejdni7KA5eTom5rcjRVT7GhnMNY0kRgt+qdQL+eHiuEEMguE4GQ2I/Y5yD+3GcRIstHntA+2n75BV
 kEoUtJoD3svTvSmNrF3a2K5Hx1XGnhTibEXj3gAo6+F777waxO+o2OjgkzUUCPLPztN9TxlID/5i8
 bsVoYrRrAFQ5pt9GjmZRe/0wCcJJ+1hhC5yZ7kLMF8F+RZDAmaiAk2D/KCVgs3Y0Fj5oe/pfxIPnj
 KvHo3WhFWY5trYZHK15MsjADbu5gI5PwKC7Q1IG10rK1E7S8Zffl3oQU+0+CfHQZaEX9dNOoV5oIU
 903URN1/SoIecg==;
Received: from [87.69.77.57] (port=1993 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEqPv-0003a6-7i; Fri, 22 Jul 2022 07:02:00 -0400
Date: Fri, 22 Jul 2022 14:01:55 +0300
Message-Id: <83fsitl8bg.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <m2bktha8hu.fsf@HIDDEN> (message from Gerd
 =?UTF-8?Q?M=C3=B6llmann?= on Fri, 22 Jul 2022 09:53:33 +0200)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2mtd1ab9u.fsf@HIDDEN>
 <83leslli29.fsf@HIDDEN> <m2bktha8hu.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Gerd M�llmann <gerd.moellmann@HIDDEN>
> Cc: andreyorst@HIDDEN,  56683 <at> debbugs.gnu.org,  gregory@HIDDEN
> Date: Fri, 22 Jul 2022 09:53:33 +0200
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >> Forgot one thing:  There seem to be a place in dispextern.h where
> >> last_visible_x is set to the number 1000000.  That's odd.
> >
> > That's a different kind of "infinity" ;-)
> 
> Aleph1 :-O.

Well, what I meant was that it's used for other purposes than
DISP_INFINITY.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 11:55:01 +0000
Resent-Message-ID: <handler.56683.B56683.16584908992695 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.16584908992695
          (code B ref 56683); Fri, 22 Jul 2022 11:55:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 11:54:59 +0000
Received: from localhost ([127.0.0.1]:40317 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oErFD-0000hO-4I
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 07:54:59 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34810)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oErFA-0000h6-R4
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 07:54:57 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:34464)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oErF5-0003bE-7f; Fri, 22 Jul 2022 07:54:51 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=AV/Bo6egeu+C5jRWmzjDEePRxLmYNxH0FnNDurgTLWA=; b=p51iWCoHoIF4NpTcZmvZ
 lONZaI5dlndf7cIbXNLQ2JAsBYzm9+KGHikBpRzOmazl3AdwBZMcqajWsriTFobi63ELrvDNeJVqZ
 6P9T2J0mH8yPI8lKkXzjr3p64XyUZgk1DtS0n0W+DcmxyrRiVZa35ben+mi8yZN1D6v4ppAoBoZyZ
 AuTAPxir1poAisL9Ov96ganhzgeGqqZ6WZkZFf9IDU9l6R7T42DWHKQ7XInuupcbk1CzVr74WaWhg
 c6H7kPereXY6sRbqH/9+UOpyVKGGqSsiNOERHvc7dbIW+6kqFPP/ZzX/6u7WZf36wifpmY4/rspJo
 iwTYtZ3RJgjM8Q==;
Received: from [87.69.77.57] (port=1243 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oErEw-0000Bf-Jo; Fri, 22 Jul 2022 07:54:49 -0400
Date: Fri, 22 Jul 2022 14:54:37 +0300
Message-Id: <835yjpl5vm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <m2edyda8jz.fsf@HIDDEN> (message from Gerd
 =?UTF-8?Q?M=C3=B6llmann?= on Fri, 22 Jul 2022 09:52:16 +0200)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Gerd Möllmann <gerd.moellmann@HIDDEN>
> Cc: andreyorst@HIDDEN,  56683 <at> debbugs.gnu.org,  gregory@HIDDEN
> Date: Fri, 22 Jul 2022 09:52:16 +0200
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >> From: Gerd Möllmann <gerd.moellmann@HIDDEN>
> >> If we really want infinity, how about setting last_visible_x to -1 in
> >> that case.  But that requires checking/changing some places where
> >> the iterator pisition is tested against last_visible_x.
> >
> > I don't really see how this could help in general, because the
> > current_x member (what you call the "iterator position") will still
> > overflow at some point, and we can no longer do any layout decisions
> > for the X coordinate after that.
> >
> > Or what am I missing?
> 
> You were asking for a good value of DISP_OMEGA, that's at least what I
> understood.  My answer is -1, plus code changes.
> 
> That current_x can overflow is something completely different, IMO.  But
> now I'm cautious enough to ask what do you mean?  Overflowing which
> bound?  I read this as integer overflow, integer = the data type.

Yes, integer overflow.  This code:

	      init_to_row_start (&it, w, cursor_row);
	      if (hscl)
		it.first_visible_x = window_hscroll_limited (w, it.f)
				     * FRAME_COLUMN_WIDTH (it.f);
	      it.last_visible_x = DISP_INFINITY;
	      move_it_in_display_line_to (&it, pt, -1, MOVE_TO_POS);

will keep producing glyphs inside move_it_in_display_line_to until
it gets to the position of point.  While producing glyphs,
it.current_x is incremented by the pixel-width of each produced
glyph.  After a large enough number of produced glyphs, it.current_x
will overflow INT_MAX.

> >> Your "ticks" check kicks in should be burn to much time because of the
> >> infinite last x, right?
> >
> > Sorry, I don't think I understand what you are asking here.  Please
> > elaborate or rephrase.
> 
> The thing you implemented in set_iterator_to_next we talked about.
> 
>   if (max_redisplay_ticks > 0)
>     update_redisplay_ticks (1, it->w);

I understood that part, but not the "should be burn to much time
because of the infinite last x" part, even if I replace "to" with
"too".

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 12:57:01 +0000
Resent-Message-ID: <handler.56683.B56683.16584945919857 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.16584945919857
          (code B ref 56683); Fri, 22 Jul 2022 12:57:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 12:56:31 +0000
Received: from localhost ([127.0.0.1]:40394 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEsCl-0002Yu-6U
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 08:56:31 -0400
Received: from mail-ej1-f52.google.com ([209.85.218.52]:38601)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gerd.moellmann@HIDDEN>) id 1oEsCj-0002Yf-TW
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 08:56:30 -0400
Received: by mail-ej1-f52.google.com with SMTP id l23so8459889ejr.5
 for <56683 <at> debbugs.gnu.org>; Fri, 22 Jul 2022 05:56:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=ohxDlmlXIoibZHYX0/l5QoChE0EGy1ZejZXwswWDbZ4=;
 b=D1HYP3EzdtpWDUOwrX+VKYSDOOyXjNUDv8TDXQqXakUXxkHTIzh9dOXKv5MiPfw/EV
 +8cpgeLtZkABPB8GQ33BoOKhsqWE57Fg9JI6C6Y4hoxJPNe8H9NYVHxh9qxQByUbw2q8
 MHGnzHQTXTOQXBOqh0yyuTVOPhxHwOKEYeQhN3iUzTj3DaqpLVY4N5ln596jDvaSI7J9
 MCxd3ibm8upxaOwZduGobHvQMWVKzRC5R/hrQsS+XF2HExGP/L0mfcDlOVlTwQRkE1rJ
 7zuqRstgAlNehi7770S3ldCaWGyYFC3qktATH3JXdHYWHMC41OVT0wXTdS53CDpzsdkb
 6fFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=ohxDlmlXIoibZHYX0/l5QoChE0EGy1ZejZXwswWDbZ4=;
 b=mxe36Xb/P5O0uTziCEmnkJYCpi273KGbM17cX2DBDMnDQG+AR4aqMrlpffuuFOiwQM
 Jke92ZQyPbnDqBYwpfwBonwABwpyFP1YgIBjjuid//3PVsWDSfkTG1ygGoMLaUa25fBr
 ENiUWiLSVfiURoZsMeq7gye6nR+6BfZuGAHptpFfT7uHnYmprcD2TVsb9x9w3JwbwtDb
 pp1Bc/6VxQn47Y5Wfy4i0sQPQWykLXjFQW0n50gkDI72reJsdM8gFojK5s/MR/nKa7vY
 cdHlfM/tlgMs680qtbOXVBRoBPYkWOrUGskmjTeM5XGlJWbnwix7nEtdsqSwpUydS2DC
 GfCQ==
X-Gm-Message-State: AJIora9uiGuamuMLFbZmNSjCA819Jy0ZXOai+s8Pza870cbBproqrawV
 06eRnte6S8jAPoPXqaMWaQU=
X-Google-Smtp-Source: AGRyM1vBruI5rHJ2UB1LnOAljpptW7sH9FdEbzmYo+QezNGRRdVWMBrDKDpRHpdgUw66ooVW6n01Ng==
X-Received: by 2002:a17:907:94ca:b0:72b:8f3e:3be0 with SMTP id
 dn10-20020a17090794ca00b0072b8f3e3be0mr395908ejc.462.1658494583759; 
 Fri, 22 Jul 2022 05:56:23 -0700 (PDT)
Received: from Mini.fritz.box (p4fe3a8ba.dip0.t-ipconnect.de. [79.227.168.186])
 by smtp.gmail.com with ESMTPSA id
 kv11-20020a17090778cb00b0072eddc468absm1989209ejc.134.2022.07.22.05.56.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Jul 2022 05:56:23 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <835yjpl5vm.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 22 Jul
 2022 14:54:37 +0300")
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN>
Date: Fri, 22 Jul 2022 14:56:22 +0200
Message-ID: <m2mtd1tifd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN>
>
> Yes, integer overflow.  This code:
>
> 	      init_to_row_start (&it, w, cursor_row);
> 	      if (hscl)
> 		it.first_visible_x =3D window_hscroll_limited (w, it.f)
> 				     * FRAME_COLUMN_WIDTH (it.f);
> 	      it.last_visible_x =3D DISP_INFINITY;
> 	      move_it_in_display_line_to (&it, pt, -1, MOVE_TO_POS);
>
> will keep producing glyphs inside move_it_in_display_line_to until
> it gets to the position of point.  While producing glyphs,
> it.current_x is incremented by the pixel-width of each produced
> glyph.  After a large enough number of produced glyphs, it.current_x
> will overflow INT_MAX.

Right.  I am not worried about that:

It takes a lot of iterations until the ints overflow.  The largest
positive 32-bit integer is very roughly 2 * 10^9.  With a font width of
of 10 pixels, that would mean 2 * 10^8 characters (200 Mb), and so on
with wider fonts.

Se that being said, what I orignally wanted to ask, was:

>> The thing you implemented in set_iterator_to_next we talked about.
>>=20
>>   if (max_redisplay_ticks > 0)
>>     update_redisplay_ticks (1, it->w);
>
> I understood that part, but not the "should be burn to much time
> because of the infinite last x" part, even if I replace "to" with
> "too".

Sorry for the typo: s/be/we, i.e. "if we burn...".  What I meant to ask
is if the check above doesn't lead to a signal anyway long before we
reach the overflow.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 13:38:02 +0000
Resent-Message-ID: <handler.56683.B56683.165849702714188 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165849702714188
          (code B ref 56683); Fri, 22 Jul 2022 13:38:02 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 13:37:07 +0000
Received: from localhost ([127.0.0.1]:40441 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEsq2-0003gl-IP
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 09:37:06 -0400
Received: from eggs.gnu.org ([209.51.188.92]:32936)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oEsq1-0003gJ-Vn
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 09:37:06 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:43674)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEspw-0000cT-CF; Fri, 22 Jul 2022 09:37:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=Dpl+UXv4AsSx8G3p2E8wxBAkyPrDfrrF7hWnmIAAgeM=; b=Ak/eI1h+us33Vtz8zf+g
 rilFoPeBtfVOaRL7WtmBXYoJoOaNgxbqt9KyyQSrIsVnlTxz3RKp9y9+FZqRF/iFntwuQvMX5Wo+2
 4g3ZO+wRo7Rjq9ykgLcMAthR/5wG7YIM4yZ3RGAIb+c8T3b5+h2F4VHlmf3G/SYkvupXcUETuEknd
 hI0C2RQyeMsE3R3Do1f/eQ9CTsgGwGsEPT9UkT5mj//x7RzvQ/PLUTIG3iPX5k93xk/Nk8TGt6lIg
 c0Gih77TyvzHxi0tsbbe++0WxGgX+HmR04lwcnteT3ptlH6aTvBrStNfzngpy1WP7mux3xoJ8Iu63
 M1pCe6iIV3Y6eg==;
Received: from [87.69.77.57] (port=3527 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEspv-0002tr-SQ; Fri, 22 Jul 2022 09:37:00 -0400
Date: Fri, 22 Jul 2022 16:36:56 +0300
Message-Id: <83y1wljmkn.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <m2mtd1tifd.fsf@HIDDEN> (message from Gerd
 =?UTF-8?Q?M=C3=B6llmann?= on Fri, 22 Jul 2022 14:56:22 +0200)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Gerd Möllmann <gerd.moellmann@HIDDEN>
> Cc: andreyorst@HIDDEN,  56683 <at> debbugs.gnu.org,  gregory@HIDDEN
> Date: Fri, 22 Jul 2022 14:56:22 +0200
> 
> > will keep producing glyphs inside move_it_in_display_line_to until
> > it gets to the position of point.  While producing glyphs,
> > it.current_x is incremented by the pixel-width of each produced
> > glyph.  After a large enough number of produced glyphs, it.current_x
> > will overflow INT_MAX.
> 
> Right.  I am not worried about that:
> 
> It takes a lot of iterations until the ints overflow.  The largest
> positive 32-bit integer is very roughly 2 * 10^9.  With a font width of
> of 10 pixels, that would mean 2 * 10^8 characters (200 Mb), and so on
> with wider fonts.

We already have an example of a 19-MB file which is a single line.  It
is within an order of magnitude of the limit you described.  JSON
files in particular are known to be like that: long and without
newlines.

So I think the danger is real.

> >>   if (max_redisplay_ticks > 0)
> >>     update_redisplay_ticks (1, it->w);
> >
> > I understood that part, but not the "should be burn to much time
> > because of the infinite last x" part, even if I replace "to" with
> > "too".
> 
> Sorry for the typo: s/be/we, i.e. "if we burn...".  What I meant to ask
> is if the check above doesn't lead to a signal anyway long before we
> reach the overflow.

That feature is disabled by default.  If enabled, then yes, it will
most probably fire before that.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 13:55:01 +0000
Resent-Message-ID: <handler.56683.B56683.165849806116071 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165849806116071
          (code B ref 56683); Fri, 22 Jul 2022 13:55:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 13:54:21 +0000
Received: from localhost ([127.0.0.1]:40464 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEt6j-0004B8-12
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 09:54:21 -0400
Received: from mail-ed1-f48.google.com ([209.85.208.48]:46768)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gerd.moellmann@HIDDEN>) id 1oEt6d-0004Ar-Rh
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 09:54:19 -0400
Received: by mail-ed1-f48.google.com with SMTP id w12so5907909edd.13
 for <56683 <at> debbugs.gnu.org>; Fri, 22 Jul 2022 06:54:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :user-agent:mime-version;
 bh=n4sRvYuDLClbHm6rt3zwuw60gnMlmoXfpzilJ0Jj9Js=;
 b=PWSeG7ld7FgJM/tDgRUYx5p1AAXaADC2hP7eU7Zio6yWoPJsiOfHy2J2GcwHQNr1w0
 cEvkoKAsXyLTMpc+Ow350rvUM5D4jBDtyLvfjSE2tTJ5wwuwuGgD5o2Plg719BgAwwRq
 6ryawWIw4P9tXLV1r1rVZrv0xrg57Pig0eJl84x/fV8WvJWe7+BSda+VoOaGsqYE2ZS8
 Niy7Qf/XIP0tWwtIryr36IPrtzP/L8RgqL/Y9tjYJA7qu1+LtzUmbGRmhOM8mSNBJRV5
 LlM4BNyOQLunJ2zCkHwhGXqsX2O5sVVBZlMIQB3m3YKdBboMiFiQHd5cIR7bXFfO+sFN
 mAdg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:user-agent:mime-version;
 bh=n4sRvYuDLClbHm6rt3zwuw60gnMlmoXfpzilJ0Jj9Js=;
 b=UEaA3w6BaJyGmT6YPznAdplLTSHlozsdSxUsa+P1zBxk+uwkep1kco0593g02T+QAm
 ZWHSk3huDPesx4Rx9dq1+nm2iOVBVrBN9i0Xp6fpA7NHYqeix1CeIC6H3dpvvu+XHD7k
 OIp61n74On/qkRMFpdNsllaS25NBRfRctjrmf6NPa4OwscbFnKZtz6jwFjDs7iQpDBXs
 SjLTSGW3zcLHMZo7y4GgdmiWyhhwCstrO0yMIgG/dnTXeCl8QJMjLM42YAo1K05J1pP2
 MW4qx960RSpmnkOaP+vC5rO/D8IHtSk8Q0kNfAAJktPDFvfp1rCfFFOGqxUAM8BGW82F
 D/aw==
X-Gm-Message-State: AJIora8gz5+AYw0Tk0vOoTZufK9SDeTGbbhWx34OXaEV19jkmUdRzURg
 d3UDKP+eZaJUGvPkUVPc2zg=
X-Google-Smtp-Source: AGRyM1scfgZmKEFcAg/ilmNVYe/HlYCuKz0DflZel66enzMO//2FSqe9Fs4UaI78BZTI7gqqZ3EgbQ==
X-Received: by 2002:a05:6402:28a1:b0:43b:a0d5:d30a with SMTP id
 eg33-20020a05640228a100b0043ba0d5d30amr821848edb.278.1658498049551; 
 Fri, 22 Jul 2022 06:54:09 -0700 (PDT)
Received: from Mini.fritz.box (p4fe3a8ba.dip0.t-ipconnect.de. [79.227.168.186])
 by smtp.gmail.com with ESMTPSA id
 mh8-20020a170906eb8800b006fe0abb00f0sm2026961ejb.209.2022.07.22.06.54.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 22 Jul 2022 06:54:08 -0700 (PDT)
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <83y1wljmkn.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 22 Jul
 2022 16:36:56 +0300")
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN>
Date: Fri, 22 Jul 2022 15:54:07 +0200
Message-ID: <m2y1wl9rsw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> That feature is disabled by default.  If enabled, then yes, it will
> most probably fire before that.

Could we enabled it automatically when we switch on iterator narrowing?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 22 Jul 2022 14:36:01 +0000
Resent-Message-ID: <handler.56683.B56683.165850052122719 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Cc: andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org, gregory@HIDDEN
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165850052122719
          (code B ref 56683); Fri, 22 Jul 2022 14:36:01 +0000
Received: (at 56683) by debbugs.gnu.org; 22 Jul 2022 14:35:21 +0000
Received: from localhost ([127.0.0.1]:42110 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEtkO-0005uN-LA
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 10:35:20 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45640)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oEtkM-0005u2-O0
 for 56683 <at> debbugs.gnu.org; Fri, 22 Jul 2022 10:35:20 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44292)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEtkH-0007Dt-Gr; Fri, 22 Jul 2022 10:35:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=UmVkNbp+mRlvhgefgTzyd01+FXQY9duZSeQj9QSCfGk=; b=KG3ZRnp6YKbxpIkRvS54
 wsOEzKH9dH9wogLVMe6wyqDcfdjaky2hr9yrbIR6VXNXJDvL4UXPcs5ArUrKB/VsuD12UmTNJMCi8
 wiYYwwQle5Jv+r4BAPNBqYDHQafUGt25cazbYIhQi4OhIJIY/ZTs/k4gpcvElJWUf5w71l5CqYTvZ
 DD2ZJSykLo2fcp0edKpTv3FVY3Mf15YxBRzz7eUR/zfcht5MNm15oDwIKX1C5cLBkRC+KXPjFIXDf
 Z0cUUHvJRMWV9LBVvmriLs1GZhMFSyaX62/3y/S1iWhJp+c4Go/MR1pRrEtoVuigyJpr1oCdCn1L5
 2DNKUsso17q43g==;
Received: from [87.69.77.57] (port=3174 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oEtkH-0000SZ-0O; Fri, 22 Jul 2022 10:35:13 -0400
Date: Fri, 22 Jul 2022 17:35:09 +0300
Message-Id: <83r12djjvm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <m2y1wl9rsw.fsf@HIDDEN> (message from Gerd
 =?UTF-8?Q?M=C3=B6llmann?= on Fri, 22 Jul 2022 15:54:07 +0200)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Gerd M�llmann <gerd.moellmann@HIDDEN>
> Cc: andreyorst@HIDDEN,  56683 <at> debbugs.gnu.org,  gregory@HIDDEN
> Date: Fri, 22 Jul 2022 15:54:07 +0200
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> > That feature is disabled by default.  If enabled, then yes, it will
> > most probably fire before that.
> 
> Could we enabled it automatically when we switch on iterator narrowing?

Technically, sure.  I'm not yet convinced we should, though, because
it isn't clear to me what problems, if any, will be left after the
narrowing idea is used as fully as practical.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 25 Jul 2022 22:23:01 +0000
Resent-Message-ID: <handler.56683.B56683.165878774627286 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165878774627286
          (code B ref 56683); Mon, 25 Jul 2022 22:23:01 +0000
Received: (at 56683) by debbugs.gnu.org; 25 Jul 2022 22:22:26 +0000
Received: from localhost ([127.0.0.1]:51599 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oG6T4-000762-2S
	for submit <at> debbugs.gnu.org; Mon, 25 Jul 2022 18:22:26 -0400
Received: from heytings.org ([95.142.160.155]:52674)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gregory@HIDDEN>) id 1oG6T2-00075u-8g
 for 56683 <at> debbugs.gnu.org; Mon, 25 Jul 2022 18:22:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org;
 s=20220101; t=1658787743;
 bh=BcxD89Etbv3QObRFlAxdgwe1XcXyayFXGtxH+rz68Ds=;
 h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From;
 b=eCEAHXSTtjXKcG0BL2n6xGnYKNXknjbGDimfFPUxr0uZCH/n6TWJm19RuyTWLisMb
 5LJyp73/R0FH3cVr/zJrhGwDmD0t/Gzkj0SXP9I559bMWoC2NEdmKqhqfM9qS0XPwc
 F+4xKNnZ5UuZkD0bavA4tYxwTJbmcAhPDUzPbeIfbL0NKPeIqosX2mGroodTdG7j0t
 K8fe3K7sMdFtfEKs4HpMHn6cLGPeo+JBVaflxHVebGsejjz9Nj6bf7yNVGECil3WSF
 CbWqg7c2H8k+zkdDKgAr2qYZKNBXaizoSQxhqeBrQ1906DTY/Gwo0SDFqKTXx2MDXA
 fKzYcYQ/FwvXg==
Date: Mon, 25 Jul 2022 22:22:22 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <83r12djjvm.fsf@HIDDEN>
Message-ID: <8a3eaeef01b9a103450a@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=us-ascii
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


By the way, we should also decide what to do when the user enables 
truncate-lines in a buffer with "really too long" lines.  With 
DISP_INFINITY == 10000000 (its current value), and with a character pixel 
width of 20 (a not uncommon value nowadays with HiDPI screens), lines 
longer than 500000 (single-width) characters will not be displayed 
correctly.  With a larger character pixel width, or with characters 
occupying more than one column, that would be even less.

Given:

1. that there has not been a single bug report about the fact that 
truncate-line does not work correctly with "really too long" lines in the 
last 20 years,

2. that the limit above, caused by DISP_INFINITY, is not much more than 
10000, the default value for long-line-threshold, and

3. the remaining slowdowns caused by truncate-lines,

I'd be in favor of simply disabling truncate-lines when 
long_line_optimizations_p is set.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Andrey Listopadov <andreyorst@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 07:14:01 +0000
Resent-Message-ID: <handler.56683.B56683.165881960624594 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gregory Heytings <gregory@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165881960624594
          (code B ref 56683); Tue, 26 Jul 2022 07:14:01 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 07:13:26 +0000
Received: from localhost ([127.0.0.1]:52083 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGEkw-0006Oc-0M
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 03:13:26 -0400
Received: from mail-lf1-f53.google.com ([209.85.167.53]:36766)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreyorst@HIDDEN>) id 1oGEkq-0006OK-M3
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 03:13:24 -0400
Received: by mail-lf1-f53.google.com with SMTP id q23so8132648lfr.3
 for <56683 <at> debbugs.gnu.org>; Tue, 26 Jul 2022 00:13:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=date:from:to:cc:subject:in-reply-to:references:message-id
 :mime-version:content-transfer-encoding;
 bh=STGXACrVYm1dJraicj2wnQH89UwW98/ldj+BpEWVlJ8=;
 b=aKv3ah3amcbKu8/y7lMAsI0wuCy0vvUhQbasqGF569dtOii7+6CSs00L0rKxG7XAiP
 lY9oHn/zIpDD8wFgyjZK5dxWdd3sizjfPBHROfe0JE6qz3bqp1di+I/OpZYDZ0J/19Yv
 lGwWQTDC6Na5oiKrqOBCWS3vDi5nJ11hWST+btOs1MJg69KvY7q9+cMTClU1V6la5byO
 mos8mAU/WAiziYcSiCGGtZMJ5PvZxU1VPzBOEl3RvFgcaURcOurFKRxa2coDbXrllUKn
 EKnjfTijwSpG2ASPjZaY7dNU8R+cE3NjgHoinxA6C3wid5kxGI22IyxRAs4MomlTmzxZ
 sACg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:references
 :message-id:mime-version:content-transfer-encoding;
 bh=STGXACrVYm1dJraicj2wnQH89UwW98/ldj+BpEWVlJ8=;
 b=rFfwCEolC7HV1lFRLHD/Bo0c0CO2/TlGyAiDwcaO1VSLMXp/fLqwQZuorN81vucPaC
 2FmB4VTuGpdfKM6gXUDZ7bCgjsx7+wethZAPy+IQavHOhLGal4hQeQbRrl7J9UZizpqP
 TLl0yB/e+TdJWcgpZBVQwJDXZ7WyrhpjXXlbbKNZfnuGBMRlohIFGoC6s2NPb20IeHff
 nqG8yX/NUFQNwnWjTOgESqc912dkTW/nkSCkULyecBiUv2eh+ugsj1eGyYup8/hHNEbD
 9oe/JKCQcSskfVyvK+RgxE7Uq/wCDikX2UItsH6P0Ln2F9O2XsJR8ayS2LLxS3/P65h0
 TFaQ==
X-Gm-Message-State: AJIora+kKtiqdbQ2z8+aODH6OUx7WUc9sghQsZa0kdZTQAn5AccNfugg
 Vq9Gd/ZwzRcwR5PM+W95gN8=
X-Google-Smtp-Source: AGRyM1uPyh1QeHqsXXgMne3dZ3G3Giq7kbvgQbZlvrQGdJHRCFsR+BRIiF9qDRhKX8eP54Rp7rLggg==
X-Received: by 2002:a05:6512:318d:b0:48a:7eaa:8c80 with SMTP id
 i13-20020a056512318d00b0048a7eaa8c80mr5300527lfe.584.1658819594493; 
 Tue, 26 Jul 2022 00:13:14 -0700 (PDT)
Received: from [127.0.0.1] ([176.59.174.143]) by smtp.gmail.com with ESMTPSA id
 b1-20020a2eb901000000b0025c8c3747bbsm3109526ljb.37.2022.07.26.00.13.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 26 Jul 2022 00:13:14 -0700 (PDT)
Date: Tue, 26 Jul 2022 07:12:08 +0000
From: Andrey Listopadov <andreyorst@HIDDEN>
In-Reply-To: <8a3eaeef01b9a103450a@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
Message-ID: <EA2D3A79-F85D-44EA-A3FA-A0A81F86DD50@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> there has not been a single bug report about the fact that truncate-line =
does not work correctly with "really too long" lines in the last 20 years,

I imagine there's not that big of a percent of Emacs users who open files
with a really long lines (given the issues with these), and for all of tho=
se
there's an even smaller percent of those who use truncate-lines (and
even smaller percent of those who would submit a report, perhaps)=2E

Overall, I'd like not to lose the ability to view long lines in such logs =
with truncated lines enabled, because as I've said earlier, it allows me to=
 partially compare line to above and below ones, without scrolling=2E And I=
 rarely even scroll to the right that much in such logs, as there's just wa=
y too much information to be viewed in a single horizontal line=2E

If, however nothing will prevent me from enabling truncating even if optim=
izations are in place, I'm OK with disabling truncating by default=2E

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 07:33:01 +0000
Resent-Message-ID: <handler.56683.B56683.165882078026771 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Andrey Listopadov <andreyorst@HIDDEN>
Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, 56683 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165882078026771
          (code B ref 56683); Tue, 26 Jul 2022 07:33:01 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 07:33:00 +0000
Received: from localhost ([127.0.0.1]:52113 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGF3r-0006xj-KZ
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 03:32:59 -0400
Received: from heytings.org ([95.142.160.155]:53138)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gregory@HIDDEN>) id 1oGF3p-0006xZ-49
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 03:32:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org;
 s=20220101; t=1658820775;
 bh=Sgyo4PvHguT32FBFaZmfYI1KfxNcWeEebK6L1x3h6ho=;
 h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From;
 b=nh1DTvKE8czzHO2HWUK59i44vCkG9ZHsDETulCR60jlTQa328BdPMXEQdHu13ASgb
 PA/GIVg8nR04I+oj60n2RVZcHJeBUf22J9s7qAhhB+v+emPY0iwt8gmePNMm2el4Ed
 OH20JIyMigC9sqG3RXj1OEaTEdTr9/LdJqcUJQbnlMNNAwhXQElwp+zcc4L372kzUU
 GHLWwG6wK5muyvRAu8V9YnXlxvg7ufM/ptj9BExCWQapejuAnw/WQclYqMCsKHZN+C
 w9pAs9c86FAcrJ3SKISpBo/3J49t6dveuiGdKS5qaEZ69XwPtBkzrl2GYfZSNm2KV2
 +CCTcaFDY8ktw==
Date: Tue, 26 Jul 2022 07:32:55 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <EA2D3A79-F85D-44EA-A3FA-A0A81F86DD50@HIDDEN>
Message-ID: <ad567fa90ab9788b6003@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
 <EA2D3A79-F85D-44EA-A3FA-A0A81F86DD50@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


>
> Overall, I'd like not to lose the ability to view long lines in such 
> logs with truncated lines enabled, because as I've said earlier, it 
> allows me to partially compare line to above and below ones, without 
> scrolling. And I rarely even scroll to the right that much in such logs, 
> as there's just way too much information to be viewed in a single 
> horizontal line.
>

As far as I understand, for your use case disabling truncate-lines when 
the buffer contains long lines would not change anything: you said that in 
your case the long lines are never longer than 10000 characters, which is 
the (default) limit of long-line-threshold.  Should you ever encounter a 
slightly longer line, you could always adapt long-line-threshold 
accordingly.  The point is that there's no way to make truncate-lines work 
with arbitrarily long lines, say a 1 GB long line.

(A side note: if you rarely scroll to the right that much, you can also 
truncate the lines with an external tool like "cut", either before you 
open the file in Emacs, or inside Emacs with C-x h M-| cut -c-1000 RET.)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 11:43:01 +0000
Resent-Message-ID: <handler.56683.B56683.165883576231057 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gregory Heytings <gregory@HIDDEN>
Cc: gerd.moellmann@HIDDEN, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165883576231057
          (code B ref 56683); Tue, 26 Jul 2022 11:43:01 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 11:42:42 +0000
Received: from localhost ([127.0.0.1]:52406 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGIxW-00084q-EB
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 07:42:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:38424)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oGIxU-00084b-5O
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 07:42:41 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:36670)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oGIxO-0000U9-S5; Tue, 26 Jul 2022 07:42:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=wGUe21z5/qifmIRjtBJkVwgte0035StKwPl49L8KSu4=; b=YeghwPM34qkNv6aXGUVC
 7sXscAEEy+8/5PjBmGMP58oog+/aDAxGJtALP6V+RK2gdnXTQAafofBTOTvx8zReU8MbyUkUblwEM
 mSojRV7wU5rzr9ZpoPy1wr/Z+Ayxa6vdBUOErzAx0o2hPurAWXHfqqk1nYpo0AJ7j+ySS6tkCKFef
 qQzjapJJxYJyXh8q+RQ465A82JvGE6bXpCFJUauHOvOQBAXHWYENVfKwEEc3xImLps6naEN3qjkpH
 bd3XouildQHTD367t1q0IDknFYkDw2sk4NFPXR5BPcOE33KrOzGl6ZuXDiMFr7Ac/6f9mqoNdbyr0
 jqmu0vkN+ieZWA==;
Received: from [87.69.77.57] (port=2669 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oGIxO-0007TL-58; Tue, 26 Jul 2022 07:42:34 -0400
Date: Tue, 26 Jul 2022 14:42:39 +0300
Message-Id: <835yjkdrrk.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <8a3eaeef01b9a103450a@HIDDEN> (message from Gregory
 Heytings on Mon, 25 Jul 2022 22:22:22 +0000)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Mon, 25 Jul 2022 22:22:22 +0000
> From: Gregory Heytings <gregory@HIDDEN>
> cc: Gerd Möllmann <gerd.moellmann@HIDDEN>, 
>     andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
> 
> By the way, we should also decide what to do when the user enables 
> truncate-lines in a buffer with "really too long" lines.  With 
> DISP_INFINITY == 10000000 (its current value), and with a character pixel 
> width of 20 (a not uncommon value nowadays with HiDPI screens), lines 
> longer than 500000 (single-width) characters will not be displayed 
> correctly.  With a larger character pixel width, or with characters 
> occupying more than one column, that would be even less.
> 
> Given:
> 
> 1. that there has not been a single bug report about the fact that 
> truncate-line does not work correctly with "really too long" lines in the 
> last 20 years,

This might be because no one seriously visited such files in Emacs
until now.

> 2. that the limit above, caused by DISP_INFINITY, is not much more than 
> 10000, the default value for long-line-threshold, and
> 
> 3. the remaining slowdowns caused by truncate-lines,
> 
> I'd be in favor of simply disabling truncate-lines when 
> long_line_optimizations_p is set.

Maybe optionally.  Or maybe displaying a message/warning suggesting
that.  I don't like disabling truncate-lines unconditionally in such
buffers, I prefer leaving that to the user.

And I think we should use INT_MAX instead of DISP_INFINITY, for the
purpose of auto-hscroll.  (There are several other uses of that macro,
but I didn't yet look at all of them to see if it would make sense to
increase DISP_INFINITY itself.)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 12:16:02 +0000
Resent-Message-ID: <handler.56683.B56683.16588377222595 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gregory Heytings <gregory@HIDDEN>
Cc: andreyorst@HIDDEN, gerd.moellmann@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.16588377222595
          (code B ref 56683); Tue, 26 Jul 2022 12:16:02 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 12:15:22 +0000
Received: from localhost ([127.0.0.1]:52467 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGJT8-0000fm-4i
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 08:15:22 -0400
Received: from eggs.gnu.org ([209.51.188.92]:47378)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oGJT6-0000fa-W1
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 08:15:21 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:37606)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oGJT1-0006hO-HQ; Tue, 26 Jul 2022 08:15:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=tbohWtJ0PEIdSHNUdIQmwAODtuh/toqDDTc3XpVOvY8=; b=nC7th/r7UF4WyAJfteHB
 BOVESa4brKzxQy0bWBYRmcQcUkx5le2G9jrkuUIhKnVAEEBMJSRpGx1wFj4x5VT/dGM9X5J8Io4o9
 nlWxLQNYOMRYM9oM4IUKKEHB+OVLLWlMb76RWaFkiH2PJwll1Fwao55DDYpCx1OF2qI9hUZr896h1
 /R6UHdKeKXx4lTxhHuaFtA1lbL5IIUbVfc5UP8kNJFJi/YaAjGkqXta0CQ1szGS7Q2sXI91rxZPLH
 AeYKYsGHkzDDLQHN09JyMCd9NKGwAH0Tl2lUxy7857X7zhaOO4kaASHjVGbaof3dM3ZHlo/zMOq+D
 7Etlq7CUXyqeww==;
Received: from [87.69.77.57] (port=4741 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oGJSx-0007Yl-Ft; Tue, 26 Jul 2022 08:15:15 -0400
Date: Tue, 26 Jul 2022 15:15:15 +0300
Message-Id: <83wnc0cbos.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <ad567fa90ab9788b6003@HIDDEN> (message from Gregory
 Heytings on Tue, 26 Jul 2022 07:32:55 +0000)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
 <EA2D3A79-F85D-44EA-A3FA-A0A81F86DD50@HIDDEN>
 <ad567fa90ab9788b6003@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 26 Jul 2022 07:32:55 +0000
> From: Gregory Heytings <gregory@HIDDEN>
> cc: Eli Zaretskii <eliz@HIDDEN>, 
>     Gerd Möllmann <gerd.moellmann@HIDDEN>, 
>     56683 <at> debbugs.gnu.org
> 
> (A side note: if you rarely scroll to the right that much, you can also 
> truncate the lines with an external tool like "cut", either before you 
> open the file in Emacs, or inside Emacs with C-x h M-| cut -c-1000 RET.)

If you never scroll such windows too much to the right, the problems
with "finite infinity" won't show at all, AFAICT, so there's no need
to use 'cut' or its ilk.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 12:18:02 +0000
Resent-Message-ID: <handler.56683.B56683.16588378562875 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: gerd.moellmann@HIDDEN, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.16588378562875
          (code B ref 56683); Tue, 26 Jul 2022 12:18:02 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 12:17:36 +0000
Received: from localhost ([127.0.0.1]:52480 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGJVI-0000kF-Ej
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 08:17:36 -0400
Received: from heytings.org ([95.142.160.155]:53448)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gregory@HIDDEN>) id 1oGJVG-0000jx-CI
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 08:17:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org;
 s=20220101; t=1658837853;
 bh=yvHExRoIz3JG4IhZfG5K7T2yTw+2dYZW4fF8+jEQDYs=;
 h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From;
 b=iQhPIQSIF6DEXMKZ9l51N7LY6UVnF6ykiHQIYyP5w68HXuQOJtWoAJ1wW+uIAj2NQ
 kdQUC8sUuTLBbZ4V4Cli7slEdy1bE4jWyq3wfvlaJMHA7cGfwE6tRfSK8pGAn/MPxj
 5ii0JI4rSyNqU+Q4njz9xDNI4gjqWd/Mtpg9ab89wwcpdexmu/KSNwjZ+x04FqgMgs
 eQXrBy+L9HB1rgHQYwVex1qZCUZ7lIQ0UH3DVC4JoG+/OGBSUsVNpjqQlhc/G4/tQJ
 wHJlRmOtbItMd5raic3izddTnDX/grRuh362pQgIRUxIgbr7XPc0MZgriEJA9zvwCo
 Q50uy2k8uDdBQ==
Date: Tue, 26 Jul 2022 12:17:33 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <835yjkdrrk.fsf@HIDDEN>
Message-ID: <ad567fa90a52badace47@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
 <835yjkdrrk.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=us-ascii
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


>
> Maybe optionally.  Or maybe displaying a message/warning suggesting 
> that.  I don't like disabling truncate-lines unconditionally in such 
> buffers, I prefer leaving that to the user.
>

The user would still have the choice to disable the automatic disabling by 
setting long-line-threshold to nil.

>
> And I think we should use INT_MAX instead of DISP_INFINITY, for the 
> purpose of auto-hscroll.  (There are several other uses of that macro, 
> but I didn't yet look at all of them to see if it would make sense to 
> increase DISP_INFINITY itself.)
>

But you said earlier that this was undesirable because it would affect 
performance?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 12:38:02 +0000
Resent-Message-ID: <handler.56683.B56683.16588390705372 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gregory Heytings <gregory@HIDDEN>
Cc: gerd.moellmann@HIDDEN, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.16588390705372
          (code B ref 56683); Tue, 26 Jul 2022 12:38:02 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 12:37:50 +0000
Received: from localhost ([127.0.0.1]:52529 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGJos-0001Oa-DP
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 08:37:50 -0400
Received: from eggs.gnu.org ([209.51.188.92]:52672)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oGJon-0001OK-Lf
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 08:37:49 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:37902)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oGJoi-0002KD-Cf; Tue, 26 Jul 2022 08:37:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=RgDITeoPsV+xiHDg4UspS0bQUHP0LpsFLlK1rRxh18k=; b=JikRPNJbuTyl
 OxIxjkImDti45nz77Ya5myUSjUV7K5L70lxSz44KzJ2NxAxi3Sb9lc7iEBzSGb2RNVNmayL16afrP
 jquIhd4uCSUJcGXegKmAD75pIsguUEizDg+tzRnG2isCWKNR77Wu5gpbcALQfsP4tmzMJFZapnhrV
 Wj9jRa1jFTcT75ODzmAoDiIvA+urHHNAQF0ei1Ie7n1kDysIjIXS8axxFl1V/KuxO0UJcY/Ee03LD
 +VvbT8mPH9UStunB8BMuF9io4ze2uWvEWGy9kGENuGMq37fp+6Fl8C3mLaswLE7pCMyA+4krqdzgA
 tzwJJBBFyabVl4V4GTbAmA==;
Received: from [87.69.77.57] (port=2145 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oGJof-00048L-FD; Tue, 26 Jul 2022 08:37:40 -0400
Date: Tue, 26 Jul 2022 15:37:41 +0300
Message-Id: <83r128cane.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <ad567fa90a52badace47@HIDDEN> (message from Gregory
 Heytings on Tue, 26 Jul 2022 12:17:33 +0000)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
 <835yjkdrrk.fsf@HIDDEN> <ad567fa90a52badace47@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 26 Jul 2022 12:17:33 +0000
> From: Gregory Heytings <gregory@HIDDEN>
> cc: gerd.moellmann@HIDDEN, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
> 
> > Maybe optionally.  Or maybe displaying a message/warning suggesting 
> > that.  I don't like disabling truncate-lines unconditionally in such 
> > buffers, I prefer leaving that to the user.
> 
> The user would still have the choice to disable the automatic disabling by 
> setting long-line-threshold to nil.

Yes, I understand.  I still don't like it very much.  But if many
users will complain, we might change that before Emacs 29 is released.

> > And I think we should use INT_MAX instead of DISP_INFINITY, for the 
> > purpose of auto-hscroll.  (There are several other uses of that macro, 
> > but I didn't yet look at all of them to see if it would make sense to 
> > increase DISP_INFINITY itself.)
> 
> But you said earlier that this was undesirable because it would affect 
> performance?

No, I said making the type of the struct member current_x a ptrdiff_t
or intmax_t will affect performance.  The above doesn't propose any
such changes, it just enlarges the "infinity" value.  With that value,
lines up to (/ (expt 2 31) 20) => 107374182 (i.e. about 107 million
characters) per line will still display correctly with truncate-lines
when hscrolling is required.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 12:51:02 +0000
Resent-Message-ID: <handler.56683.B56683.165883985415422 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: gerd.moellmann@HIDDEN, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165883985415422
          (code B ref 56683); Tue, 26 Jul 2022 12:51:02 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 12:50:54 +0000
Received: from localhost ([127.0.0.1]:52583 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGK1W-00040g-Ck
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 08:50:54 -0400
Received: from heytings.org ([95.142.160.155]:53536)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gregory@HIDDEN>) id 1oGK1V-00040Y-Es
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 08:50:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org;
 s=20220101; t=1658839852;
 bh=oh8J8omaty/wuQwGLfTo+DcrLlRnwPVvMxZMIJRb6WQ=;
 h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From;
 b=grWlE/gRy5RdC02ocMVF26yhOuMA855KtW3On1LxxOwV9ddYEbELvdF0XLxeiIlku
 d/mcP+kqhupW2cSo4RS/PkJFudbS/hUL+AySIXmhE/Pw8o9ILgJlXdwpoUYcMMks+R
 6ADpCjfzBMqRzRevQLz9GcWWl29bVyqgvuQmL18w5ACx1aBQUN5SS3N8Lkcrv34n1H
 +aL+8tIUbtYdDXsEBw4ThaFg2DnVX7dj9rbjlnqtcnvE9T2tgYmc9BssveMEl+yd1q
 nKCMkOkM2NHLzWDc/FdRI36kJjO4ECq+dy3aDCpSH/4sGzDENm1iuAVgTJc+qBsp+q
 ajuY8d3xAfJAQ==
Date: Tue, 26 Jul 2022 12:50:51 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <83r128cane.fsf@HIDDEN>
Message-ID: <ad567fa90a9c133efc8a@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
 <835yjkdrrk.fsf@HIDDEN> <ad567fa90a52badace47@HIDDEN>
 <83r128cane.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=us-ascii
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


>>> Maybe optionally.  Or maybe displaying a message/warning suggesting 
>>> that.  I don't like disabling truncate-lines unconditionally in such 
>>> buffers, I prefer leaving that to the user.
>>
>> The user would still have the choice to disable the automatic disabling 
>> by setting long-line-threshold to nil.
>
> Yes, I understand.  I still don't like it very much.  But if many users 
> will complain, we might change that before Emacs 29 is released.
>

Do I understand correctly that it's okay to do that on the feature (and 
later master) branch, and that it will be perhaps be revisited later?

>
> No, I said making the type of the struct member current_x a ptrdiff_t or 
> intmax_t will affect performance.  The above doesn't propose any such 
> changes, it just enlarges the "infinity" value.  With that value, lines 
> up to (/ (expt 2 31) 20) => 107374182 (i.e. about 107 million 
> characters) per line will still display correctly with truncate-lines 
> when hscrolling is required.
>

Sorry, I misunderstood what you said.  Now it's much clearer, indeed. 
But still, as you say, that puts a limit at around 100 MB, which isn't 
"that much" nowadays.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 13:16:01 +0000
Resent-Message-ID: <handler.56683.B56683.165884131326598 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Gregory Heytings <gregory@HIDDEN>
Cc: gerd.moellmann@HIDDEN, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165884131326598
          (code B ref 56683); Tue, 26 Jul 2022 13:16:01 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 13:15:13 +0000
Received: from localhost ([127.0.0.1]:52639 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGKP2-0006uv-RD
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 09:15:13 -0400
Received: from eggs.gnu.org ([209.51.188.92]:33110)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oGKP1-0006uf-0I
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 09:15:11 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38700)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oGKOv-0001EG-PU; Tue, 26 Jul 2022 09:15:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=AdYPdsWKgFupLck0LXopU/f6OMz3lj6K5jKMjAZodh8=; b=PPwahZRiDxTa
 nuwTrBACPwfYKPSnjR4D9crqoDtyjbV9UV2DOP2KZgZY1eRqmsRTLfNNxXrPdzZMaaNETT0iGrUZ4
 C68/S8Qv+9jRagn3U8yPStfrZMGfdFeu92dzdsQ21eR4KDQSXBoHE23xGNyTfCrWh01XJHNDVH6W9
 924mFoeuws14rIrNzvClB8v1hov8xBkEdtPV9ssxIfVHN+Mwgd0Jfmt+N580rjyWTtJ79Ge3kig+x
 9v1lM1eqLERbbJ+aasCgMn57GuqhwvMVIihs4CMEJxXQJXfJg/sGY2gq+yKzL780CwsQzxRnWYjaS
 kz9l4eAJriRC818yykGQGQ==;
Received: from [87.69.77.57] (port=4439 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oGKOv-0003sh-85; Tue, 26 Jul 2022 09:15:05 -0400
Date: Tue, 26 Jul 2022 16:15:10 +0300
Message-Id: <83h734c8wx.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <ad567fa90a9c133efc8a@HIDDEN> (message from Gregory
 Heytings on Tue, 26 Jul 2022 12:50:51 +0000)
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
 <835yjkdrrk.fsf@HIDDEN> <ad567fa90a52badace47@HIDDEN>
 <83r128cane.fsf@HIDDEN> <ad567fa90a9c133efc8a@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 26 Jul 2022 12:50:51 +0000
> From: Gregory Heytings <gregory@HIDDEN>
> cc: gerd.moellmann@HIDDEN, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
> 
> >>> Maybe optionally.  Or maybe displaying a message/warning suggesting 
> >>> that.  I don't like disabling truncate-lines unconditionally in such 
> >>> buffers, I prefer leaving that to the user.
> >>
> >> The user would still have the choice to disable the automatic disabling 
> >> by setting long-line-threshold to nil.
> >
> > Yes, I understand.  I still don't like it very much.  But if many users 
> > will complain, we might change that before Emacs 29 is released.
> 
> Do I understand correctly that it's okay to do that on the feature (and 
> later master) branch, and that it will be perhaps be revisited later?

I'd prefer not to do it just yet, and wait for more user feedback
(once the feature branch is merged, which I guess will be soon).

> > No, I said making the type of the struct member current_x a ptrdiff_t or 
> > intmax_t will affect performance.  The above doesn't propose any such 
> > changes, it just enlarges the "infinity" value.  With that value, lines 
> > up to (/ (expt 2 31) 20) => 107374182 (i.e. about 107 million 
> > characters) per line will still display correctly with truncate-lines 
> > when hscrolling is required.
> 
> Sorry, I misunderstood what you said.  Now it's much clearer, indeed. 
> But still, as you say, that puts a limit at around 100 MB, which isn't 
> "that much" nowadays.

Yes, it's not a solution, just a band-aid.  But it costs almost
nothing, and we get to push the problematic situations farther.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#56683: 29.0.50; long lines fix doesn't work correctly when lines are truncated
Resent-From: Gregory Heytings <gregory@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jul 2022 13:26:02 +0000
Resent-Message-ID: <handler.56683.B56683.165884193827904 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56683
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: gerd.moellmann@HIDDEN, andreyorst@HIDDEN, 56683 <at> debbugs.gnu.org
Received: via spool by 56683-submit <at> debbugs.gnu.org id=B56683.165884193827904
          (code B ref 56683); Tue, 26 Jul 2022 13:26:02 +0000
Received: (at 56683) by debbugs.gnu.org; 26 Jul 2022 13:25:38 +0000
Received: from localhost ([127.0.0.1]:52675 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGKZ8-0007Fy-2r
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 09:25:38 -0400
Received: from heytings.org ([95.142.160.155]:53606)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gregory@HIDDEN>) id 1oGKZ2-0007Fj-HM
 for 56683 <at> debbugs.gnu.org; Tue, 26 Jul 2022 09:25:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org;
 s=20220101; t=1658841931;
 bh=pup7bUxA0Nlpn1Ieft9jiCKBoE0SylZV3JvwFX8TxLA=;
 h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From;
 b=X8gsHQPpMnw0ih13bSLJGeRp7u7gVfwMbBydVVAZwisfNPh1XOhTMgs6ic+ycAITP
 MIrZ3DdMCMpVcsEqllugiu3FDOqImwNyjJjPp7ACwTY4O6m9KYpIZQt9N19QBIYrfZ
 aD3TjPeVsl5Fl9YdKvzaJhwUnYNMDR9Ze7GSniEn9UrkguvUs4vb13sTsmscJp+aEa
 l8yHzDf380AOJkNKOJ36RIOtJX/5uhxKgYfxaQM2O9e4n+4j8B+pPtMKZHlwBbLpe/
 /YD/NmsKobg2x3DGxOcERyrDtTpuSAr53py42VmVRozSO2Qf4GX9t/6Vj9D1hdbpC3
 48QngYEU1TEvA==
Date: Tue, 26 Jul 2022 13:25:30 +0000
From: Gregory Heytings <gregory@HIDDEN>
In-Reply-To: <83h734c8wx.fsf@HIDDEN>
Message-ID: <ad567fa90a192d1ffec9@HIDDEN>
References: <87h73ab8bo.fsf@HIDDEN> <b7551196d54434aeb8a7@HIDDEN>
 <83zgh2kzlo.fsf@HIDDEN> <b7551196d5203b87e6ec@HIDDEN>
 <83y1wlllnc.fsf@HIDDEN> <m2pmhxabcj.fsf@HIDDEN>
 <83mtd1li6o.fsf@HIDDEN> <m2edyda8jz.fsf@HIDDEN>
 <835yjpl5vm.fsf@HIDDEN> <m2mtd1tifd.fsf@HIDDEN>
 <83y1wljmkn.fsf@HIDDEN> <m2y1wl9rsw.fsf@HIDDEN>
 <83r12djjvm.fsf@HIDDEN> <8a3eaeef01b9a103450a@HIDDEN>
 <835yjkdrrk.fsf@HIDDEN> <ad567fa90a52badace47@HIDDEN>
 <83r128cane.fsf@HIDDEN>
 <ad567fa90a9c133efc8a@HIDDEN> <83h734c8wx.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=us-ascii
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


>> Do I understand correctly that it's okay to do that on the feature (and 
>> later master) branch, and that it will be perhaps be revisited later?
>
> I'd prefer not to do it just yet, and wait for more user feedback (once 
> the feature branch is merged, which I guess will be soon).
>

Wouldn't it be easier to get useful user feedback if that automatic 
disabling was present on master?  If it's absent, what kind of user 
feedback can we expect to decide what is better for Emacs 29?

>> But still, as you say, that puts a limit at around 100 MB, which isn't 
>> "that much" nowadays.
>
> Yes, it's not a solution, just a band-aid.  But it costs almost nothing, 
> and we get to push the problematic situations farther.
>

It does indeed, but alas the fact that displaying such buffers is 
noticeably slower with truncate-lines remains.  I could perhaps take a 
look (after finalizing and merging the current branch), but I'm not really 
sure it's worth the price.

Last modified: Tue, 26 Jul 2022 13:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.