GNU bug report logs - #56690
[PATCH] gnu: seatd-service-type: Should use seat group.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: muradm <mail@HIDDEN>; Keywords: patch; dated Fri, 22 Jul 2022 04:28:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added indication that bug 56690 blocks56971 Request was from Liliana Marie Prikler <liliana.prikler@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 56690 <at> debbugs.gnu.org:


Received: (at 56690) by debbugs.gnu.org; 24 Jul 2022 16:28:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 24 12:28:47 2022
Received: from localhost ([127.0.0.1]:48558 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oFeTH-00028h-Bm
	for submit <at> debbugs.gnu.org; Sun, 24 Jul 2022 12:28:47 -0400
Received: from knopi.disroot.org ([178.21.23.139]:36744)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <paren@HIDDEN>) id 1oFeTF-00028W-SJ
 for 56690 <at> debbugs.gnu.org; Sun, 24 Jul 2022 12:28:46 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 72B3B40DA3;
 Sun, 24 Jul 2022 18:28:44 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id uw_wuF8qFUgS; Sun, 24 Jul 2022 18:28:43 +0200 (CEST)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1658680123; bh=mecwXTrRZdfR4CdUZoaYaWj1pKnFodPDv5NoyBd+6MM=;
 h=Date:Subject:From:To:References:In-Reply-To;
 b=IETRl5rH9PTEWLz8sVtk6Q4E2YenmqeoTqllv7KfmsEUlChGuhxWs/pLKqTSLDUZU
 MXgITByaXl/VYIMr19RYqLKLtqB7wKNO6GFPA0cHMJW/AHtQHUa/AdolG3IYRNCTM5
 OV3cdrPvu3d6IpxCEdYrLt+xTgFmY8niSJrjptBUeaeqvh1TYSw0iyjFSnmXkDQjU+
 gG6IUpo5tK0aEkKU9dQ4mS2JrAGf2kBKGGPHVbNmEoR5a/L9Zqp/vPLlL63b5ab381
 e/1l+2T1Jm19Gb5rE4MXpmJQGWBnDc0P7UxsE7p/kRfx4srwa4MzRSNdyhbB2F7VCw
 Z11ndFtfgtPcg==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 24 Jul 2022 17:28:43 +0100
Message-Id: <CLO115738RZH.2Q7DHDC619VG6@guix-aspire>
Subject: Re: [bug#56690] [PATCH] gnu: seatd-service-type: Should use seat
 group.
From: "(" <paren@HIDDEN>
To: "muradm" <mail@HIDDEN>, <56690 <at> debbugs.gnu.org>
References: <20220722042745.26745-1-mail@HIDDEN>
In-Reply-To: <20220722042745.26745-1-mail@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 56690
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Because patches with replies are more likely to be visible: LGTM :)

    -- (




Information forwarded to guix-patches@HIDDEN:
bug#56690; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 22 Jul 2022 04:27:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 22 00:27:56 2022
Received: from localhost ([127.0.0.1]:39795 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEkGa-0000hD-2T
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 00:27:56 -0400
Received: from lists.gnu.org ([209.51.188.17]:36756)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oEkGT-0000gz-Ba
 for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 00:27:54 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46446)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oEkGT-0001Rh-6q
 for guix-patches@HIDDEN; Fri, 22 Jul 2022 00:27:49 -0400
Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:53974
 helo=nomad-cl1.muradm.net)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oEkGR-0000jG-Ec
 for guix-patches@HIDDEN; Fri, 22 Jul 2022 00:27:48 -0400
Received: from localhost ([127.0.0.1]:46674)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oEkGB-0004es-0q
 for guix-patches@HIDDEN; Fri, 22 Jul 2022 04:27:31 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date
 :Subject:To:From:Sender:Reply-To:Cc:Content-ID:Content-Description:
 Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
 In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=mua2yXN7R2IhKYYRHZvnL0T33OYicTP8O+SBalav4lM=; b=Ip5YCerk9wtSxrKX433I/btste
 g0ERbawwBn3Q6irvacTfDQupE2AKBQ/cuMxcPqWtdjnQjttY360sDIFn4ok6M1WWygY9btb34jRmD
 /q+9nDZNklbyiRAnoZAGjAazzaBvM/x46JmX3sV4vZhUo2+zkq8tHtu/Vvlca17k84uFWMWheFRD8
 GY1dGqhd5eXPfpNP1JL/0Hg4kxvXczMnFAXIXQXBUSEC+xoqX/eo0WpSMSYLtMs7xa+PG8o4uys9u
 9MmsF3u7LHrqCyex3oF2nL6A6AP2zcC99nLcJN1LNkHZJcrnVpv0qXnYXVs9V/b8YAJ8dxONVX9af
 x4+WbIBvv9Ngr6sN3+DMMqvw0Rp4uMdyL9pPwpPetnkJaB7ewvGiqfXUPbhCiS7wPefkBpKLZLgmV
 wbIk6wzTjvmyE1OL2WPfnbrk454e7r36CpJ+cXr/N3BL7bCJJENbAJy0PXyYQjHmIlR7+Tduyq4I8
 ZFdX+i0y9glYsni4HEZ6gOmR;
Received: from muradm by localhost with local (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oEkGP-0006xV-0J
 for guix-patches@HIDDEN; Fri, 22 Jul 2022 07:27:45 +0300
From: muradm <mail@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: seatd-service-type: Should use seat group.
Date: Fri, 22 Jul 2022 07:27:45 +0300
Message-Id: <20220722042745.26745-1-mail@HIDDEN>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=139.162.159.157; envelope-from=mail@HIDDEN;
 helo=nomad-cl1.muradm.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/services/desktop.scm (seatd-service-type): Uses "seat" group.
[extensions]: Added account-service-type with %seatd-accounts.
(%seatd-accounts): List with "seat" group.
(<seatd-configuration>): [group] Change default value to "seat".
* doc/guix.texi: Mention that users may need to become members of
"seat" group and update default value for group field.
---
 doc/guix.texi            | 18 +++++++++++++++++-
 gnu/services/desktop.scm |  8 ++++++--
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 3c5864ec1a..750ed9b121 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -23151,6 +23151,22 @@ input), without requiring the applications needing access to be root.
   %base-services)
 
 @end lisp
+
+Users which are going to interact with @code{seatd} daemon while logged in
+should be added to @code{seat} group. For instance:
+
+@lisp
+(user-account
+  (name "alice")
+  (group "users")
+  (supplementary-groups '("wheel"   ;allow use of sudo, etc.
+                          "seat"    ;interact with seatd
+                          "audio"   ;sound card
+                          "video"   ;video devices such as webcams
+                          "cdrom")) ;the good ol' CD-ROM
+  (comment "Bob's sister"))
+@end lisp
+
 @end defvr
 
 @deftp {Data Type} seatd-configuration
@@ -23163,7 +23179,7 @@ The seatd package to use.
 @item @code{user} (default: @samp{"root"})
 User to own the seatd socket.
 
-@item @code{group} (default: @samp{"users"})
+@item @code{group} (default: @samp{"seat"})
 Group to own the seatd socket.
 
 @item @code{socket} (default: @samp{"/run/seatd.sock"})
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 29a3722f1b..0d7cd71732 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2020 Tobias Geerinckx-Rice <me@HIDDEN>
 ;;; Copyright © 2020 Reza Alizadeh Majd <r.majd@HIDDEN>
 ;;; Copyright © 2021 Brice Waegeneire <brice@HIDDEN>
-;;; Copyright © 2021 muradm <mail@HIDDEN>
+;;; Copyright © 2021, 2022 muradm <mail@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1646,7 +1646,7 @@ (define-record-type* <seatd-configuration> seatd-configuration
   seatd-configuration?
   (seatd seatd-package (default seatd))
   (user seatd-user (default "root"))
-  (group seatd-group (default "users"))
+  (group seatd-group (default "seat"))
   (socket seatd-socket (default "/run/seatd.sock"))
   (logfile seatd-logfile (default "/var/log/seatd.log"))
   (loglevel seatd-loglevel (default "info")))
@@ -1670,6 +1670,9 @@ (define (seatd-shepherd-service config)
                    #:log-file #$(seatd-logfile config)))
          (stop #~(make-kill-destructor)))))
 
+(define %seatd-accounts
+  (list (user-group (name "seat") (system? #t))))
+
 (define seatd-environment
   (match-lambda
     (($ <seatd-configuration> _ _ _ socket)
@@ -1683,6 +1686,7 @@ (define seatd-service-type
 applications needing access to be root.")
    (extensions
     (list
+     (service-extension account-service-type (const %seatd-accounts))
      (service-extension session-environment-service-type seatd-environment)
      ;; TODO: once cgroups is separate dependency we should not mount it here
      ;; for now it is mounted here, because elogind mounts it
-- 
2.36.1





Acknowledgement sent to muradm <mail@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#56690; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 4 Aug 2022 11:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.