GNU bug report logs - #56699
[PATCH] gnu: greetd-service-type: Add greeter-extra-groups config field.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: muradm <mail@HIDDEN>; Keywords: patch; dated Fri, 22 Jul 2022 11:46:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 56699 <at> debbugs.gnu.org:


Received: (at 56699) by debbugs.gnu.org; 7 Aug 2022 21:48:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 07 17:48:19 2022
Received: from localhost ([127.0.0.1]:38427 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oKo8A-0000EO-T9
	for submit <at> debbugs.gnu.org; Sun, 07 Aug 2022 17:48:19 -0400
Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:40818
 helo=nomad-cl1.muradm.net)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oKo88-0000Dl-In
 for 56699 <at> debbugs.gnu.org; Sun, 07 Aug 2022 17:48:17 -0400
Received: from localhost ([127.0.0.1]:48752)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oKo7V-0001ZE-22;
 Sun, 07 Aug 2022 21:47:37 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
 Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=Iyo7Kt/OBpisvavYZ9vzVLreMLacPDasYHjYyUdAVM4=; b=QVym5EFbwuxWJSwOS1JVRYaBPj
 x0RD0BGWhLIKFMOEEuF4IBVcz4i94wO78cUNESeUgH56zbGPQBAx6vatNsgvfeh30eO4CmkqDs6h8
 ACdz5hrqPKEtENBSS//quOuVN2lPy3uIp5SvzV71WkzF8wBs6G9bIA51lHMTH6tUwTBX7/hUGXCs9
 4JuyK2pAup/7TbWOEgz1CoARr50RQvKfRl11BgIO5WmlLT3N4CJlTOW6m8K6hp2xMmTOj0QPbDZYC
 2K7Z82cffZpiIK26hzg4BTx3S4dnpzOEe0smMAo9xmgfKypHXub0KTpQnczenGjUMcq4UxsgaJtkr
 eiPC6yYNabctwaL+KV2itLeVxdqHIxaspkHvGGOU91E8VYgs426IU2Jxdtg6+GcwlgO6dFoCup4VV
 tI1bcQP+IGXipgmo2X+Cyk7se3ZbBZlRFUnFXAeFaXTJcKp+xYRi4fijo8WI0ld6l7xx8wt2w7Ku1
 FXxY54qTnPFn+PW2IdE69f3F;
Received: from muradm by localhost with local (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oKo7w-0005oB-21;
 Mon, 08 Aug 2022 00:48:04 +0300
From: muradm <mail@HIDDEN>
To: 56699 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: [PATCH v2] gnu: greetd-service-type: Add greeter-extra-groups config
 field.
Date: Mon,  8 Aug 2022 00:48:04 +0300
Message-Id: <20220807214804.22323-1-mail@HIDDEN>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <874jyn20et.fsf@HIDDEN>
References: <874jyn20et.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 1.7 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: * gnu/services/base.scm (greetd-service-type): Added
 configurable
 groups. [extensions]: Switching accounts-service-type from const to function.
 (<greetd-configuration>): Added greeter-groups field of [...] 
 Content analysis details:   (1.7 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
 [URIs: muradm.net]
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
X-Debbugs-Envelope-To: 56699
Cc: "\(" <paren@HIDDEN>, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.7 (/)

* gnu/services/base.scm (greetd-service-type): Added configurable groups.
[extensions]: Switching accounts-service-type from const to function.
(<greetd-configuration>): Added greeter-groups field of type list.
(greetd-accounts-service): New variable, function returning list necessary
accounts for accounts-service-type, including the greeter-extra-groups.
(%greetd-accounts): Removed.
* gnu/tests/desktop.scm (%minimal-services): Add test for greeter-groups.
* doc/guix.texi: Mention greeter-extra-groups field with example.
---
 doc/guix.texi         |  8 ++++++++
 gnu/services/base.scm | 24 +++++++++++-------------
 gnu/tests/desktop.scm |  7 +++++++
 3 files changed, 26 insertions(+), 13 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 21cee4e369..2b09bea3b0 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -18509,6 +18509,14 @@ the 'root' account has just been created.
 @item @code{terminals} (default: @code{'()})
 List of @code{greetd-terminal-configuration} per terminal for which
 @code{greetd} should be started.
+
+@item @code{greeter-groups} (default: @code{'()})
+List of groups which should be added to @code{greeter} user. For instance:
+@lisp
+(greeter-groups '("seat" "video"))
+@end lisp
+Note that, however it will fail if @code{seatd-service-type} is not present,
+or to be more specific, @code{seat} group is not present.
 @end table
 @end deftp
 
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 27eae75c46..85de6decfe 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -2918,17 +2918,6 @@ (define (make-greetd-terminal-configuration-file config)
      "user = " default-session-user "\n"
      "command = " default-session-command "\n")))
 
-(define %greetd-accounts
-  (list (user-account
-         (name "greeter")
-         (group "greeter")
-         ;; video group is required for graphical greeters.
-         (supplementary-groups '("video"))
-         (system? #t))
-        (user-group
-         (name "greeter")
-         (system? #t))))
-
 (define %greetd-file-systems
   (list (file-system
           (device "none")
@@ -2956,7 +2945,16 @@ (define-record-type* <greetd-configuration>
   greetd-configuration?
   (motd greetd-motd (default %default-motd))
   (allow-empty-passwords? greetd-allow-empty-passwords? (default #t))
-  (terminals greetd-terminals (default '())))
+  (terminals greetd-terminals (default '()))
+  (greeter-groups greetd-greeter-groups (default '())))
+
+(define (greetd-accounts-service config)
+  (list (user-group (name "greeter") (system? #t))
+        (user-account
+         (name "greeter")
+         (group "greeter")
+         (supplementary-groups (greetd-greeter-groups config))
+         (system? #t))))
 
 (define (make-greetd-pam-mount-conf-file config)
   (computed-file
@@ -3033,7 +3031,7 @@ (define greetd-service-type
 login manager daemon.")
    (extensions
     (list
-     (service-extension account-service-type (const %greetd-accounts))
+     (service-extension account-service-type greetd-accounts-service)
      (service-extension file-system-service-type (const %greetd-file-systems))
      (service-extension etc-service-type greetd-etc-service)
      (service-extension pam-root-service-type greetd-pam-service)
diff --git a/gnu/tests/desktop.scm b/gnu/tests/desktop.scm
index 25971f9225..ef4a7e0ec9 100644
--- a/gnu/tests/desktop.scm
+++ b/gnu/tests/desktop.scm
@@ -122,6 +122,7 @@ (define %minimal-services
     (service seatd-service-type)
     (service greetd-service-type
              (greetd-configuration
+              (greeter-groups '("input" "video"))
               (terminals
                (list
                 ;; we can make any terminal active by default
@@ -286,6 +287,12 @@ (define (greetd-pid-to-sock pid)
               (marionette-type "echo alice > /run/user/1000/test\n" marionette)
               (file-get-all-strings "/run/user/1000/test")))
 
+          (test-equal "check greeter user has correct groups"
+            "greeter input video\n"
+            (begin
+              (marionette-type "id -Gn greeter > /run/user/1000/greeter-groups\n" marionette)
+              (file-get-all-strings "/run/user/1000/greeter-groups")))
+
           (test-assert "screendump"
             (begin
               (marionette-control (string-append "screendump " #$output
-- 
2.37.1





Information forwarded to guix-patches@HIDDEN:
bug#56699; Package guix-patches. Full text available.

Message received at 56699 <at> debbugs.gnu.org:


Received: (at 56699) by debbugs.gnu.org; 7 Aug 2022 21:45:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 07 17:45:36 2022
Received: from localhost ([127.0.0.1]:38417 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oKo5X-00006s-LK
	for submit <at> debbugs.gnu.org; Sun, 07 Aug 2022 17:45:36 -0400
Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:53576
 helo=nomad-cl1.muradm.net)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oKo5Q-00006G-VO
 for 56699 <at> debbugs.gnu.org; Sun, 07 Aug 2022 17:45:32 -0400
Received: from localhost ([127.0.0.1]:46580)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oKo4m-0001Z8-39;
 Sun, 07 Aug 2022 21:44:48 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To
 :From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=si6vmR69WWx0B/e+tyS9cplxa4euN/1AA/9rwBqDZBI=; b=sQl1lD1TX2N9x1XNjeFcBYj+iC
 D05OpJXr5L2Mb6yBeFaL0Fb0ZqXHNQ3pw2Mv/ggXy6TV0Ls/e5qdAJ94T1L0n9Kc9sjlKLXt/z9W9
 wvkcWoEV9hYCPTvg7sRDgVPfsCcmcMAjtMpwIY/uFxxuMcsg8nOj/b6pmIzbW+9PMertKxltWtZjg
 EbVmVHuP8DrglKX46SyslaNJz4/iJGzdOZBmDHsq2f8T1ikywcP79wZlv3haheCK71PhWsaT7dl9C
 QY3qa6wGHDzu/fX/5DL8jyr+LiAxrhSo8BBa1oJcolvwYsUVSCVZvk8w5my6zdao7eVbFvwsF31B7
 wAPUdtx52v5eaQ4FyWvBgn9/gR3Px04TKaFgVF92SCKLXGAJSGPbR58ij/CpGBsxOSH+pE4uhw2jV
 ePu2zDzHvdrQUB/ObfRRVX20925Z/r/PsPQYp8v9DGfr/tT2ZqGjF8nLXX9bungawkaVfQtjqZW0l
 7JRb0Dak21MImDt2mkO4E9rX;
Received: from muradm by localhost with local (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oKo5D-0005np-1w;
 Mon, 08 Aug 2022 00:45:15 +0300
References: <20220722114501.5273-1-mail@HIDDEN>
 <CLO13EG52QG0.F152G8L34MRH@guix-aspire> <87v8r71909.fsf@HIDDEN>
 <cf6a4c2413045877b6c6143a6c35b8178e0dc77b.camel@HIDDEN>
User-agent: mu4e 1.8.7; emacs 29.0.50
From: muradm <mail@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: [bug#56699] [PATCH v2] gnu: greetd-service-type: Add
 greeter-extra-groups config field.
Date: Mon, 08 Aug 2022 00:42:09 +0300
In-reply-to: <cf6a4c2413045877b6c6143a6c35b8178e0dc77b.camel@HIDDEN>
Message-ID: <874jyn20et.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 1.7 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Correct, no defaults are given. Attached is v2. Defaults non
 existent, append/cons* irrelevant. thanks in advance, muradm Liliana Marie
 Prikler <liliana.prikler@HIDDEN> writes: 
 Content analysis details:   (1.7 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
 [URIs: muradm.net]
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
X-Debbugs-Envelope-To: 56699
Cc: "\(" <paren@HIDDEN>, 56699 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.7 (/)

--=-=-=
Content-Type: text/plain; format=flowed


Correct, no defaults are given. Attached is v2. Defaults
non existent, append/cons* irrelevant.



thanks in advance,
muradm

Liliana Marie Prikler <liliana.prikler@HIDDEN> writes:

> Am Freitag, dem 05.08.2022 um 09:44 +0300 schrieb muradm:
>> supplimentary-groups receiving a list, so I find it more
>> informative when adding apples with apples. And yes with high 
>> enough
>> chance more groups could be added to the list of defaults.
> What are "the defaults" here, though?  A sequence of hard-coded 
> values
> known at compile time.  There is no need to make that sequence a 
> list.
>
>> Is there any preference on using cons* in favour of more 
>> readable
>> append?
> Use of cons or cons* signals that you are only expecting 
> user-supplied
> groups to be a list and everything else known values.  Use of 
> append on
> the other hand signals that you are expecting multiple lists, 
> which
> even if you did are not currently present.
>
> Cheers


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLwMmsACgkQ6M7O0mLO
BeISvQ/+OnYE07rD+0gZcBs7XA2u02k8E31ywGhXeO4Ja8BHfHf9kmSDecmj0kD7
+k5Zwl8IrrADU8GP7MqJwcrc2grwpgMYbwqHTUPN6mHpINjgTyWGtKYsiuHbZ3Tf
+e0HfzVZ968G34xtZy9fiDX5XjGE3LNAj3x/rT1pWdEeLJYZPugTPqaDRZv/yUBv
W+bBKOIYO9X1MWDmsqAcNN1JiibLisgCKC7zIdvFgB4vYLdpni8I7z25ban1loqT
CBjT/3Lf1vUO1Kszf3reUWWVtXZ/a1znDutsvrFapdN9L+0PcLvKAc6wBtCde2sm
v5NcNGn2gse2wCSnEvJS24xouunZ1jiAusPk1jXH03sNLUAvTcC5aEpI2Wbfp2a6
WvOHpUTqojm0MByHgoPSaZwaT9rUKRK9HV1iRwVn8BaoKIkyM53pc98EV2syMPcW
fOVkBEFQCPUectmV5kryYnFvWUQdh7Wb3TR4heSuSTiKVwQFxWXqTG61hh3C2q9S
JkLcmF1HbuyARLwsAWZIlUfMUNdSjJZmp8urdJ+qPgcSCzcDFLQOjFwOKXZuj1Wt
cAvVcctO2CzMSl+blsWRELazYC9Jdfy0SxSXgQ8QPOzxun82ZwVESXzVVLJJgGCE
OWLrX4PWS4B9+QDlsVGq+cekxck8A0PHC0+RpJjGe6iFTFfZQoU=
=rpws
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#56699; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Aug 2022 21:45:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 07 17:45:32 2022
Received: from localhost ([127.0.0.1]:38415 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oKo5U-00006Z-99
	for submit <at> debbugs.gnu.org; Sun, 07 Aug 2022 17:45:32 -0400
Received: from lists.gnu.org ([209.51.188.17]:34822)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oKo5P-00006L-OP
 for submit <at> debbugs.gnu.org; Sun, 07 Aug 2022 17:45:30 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53642)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oKo5P-0002lA-JL
 for guix-patches@HIDDEN; Sun, 07 Aug 2022 17:45:27 -0400
Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:59516
 helo=nomad-cl1.muradm.net)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oKo5O-0001tO-6j
 for guix-patches@HIDDEN; Sun, 07 Aug 2022 17:45:27 -0400
Received: from localhost ([127.0.0.1]:46580)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oKo4m-0001Z8-39;
 Sun, 07 Aug 2022 21:44:48 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To
 :From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=si6vmR69WWx0B/e+tyS9cplxa4euN/1AA/9rwBqDZBI=; b=sQl1lD1TX2N9x1XNjeFcBYj+iC
 D05OpJXr5L2Mb6yBeFaL0Fb0ZqXHNQ3pw2Mv/ggXy6TV0Ls/e5qdAJ94T1L0n9Kc9sjlKLXt/z9W9
 wvkcWoEV9hYCPTvg7sRDgVPfsCcmcMAjtMpwIY/uFxxuMcsg8nOj/b6pmIzbW+9PMertKxltWtZjg
 EbVmVHuP8DrglKX46SyslaNJz4/iJGzdOZBmDHsq2f8T1ikywcP79wZlv3haheCK71PhWsaT7dl9C
 QY3qa6wGHDzu/fX/5DL8jyr+LiAxrhSo8BBa1oJcolvwYsUVSCVZvk8w5my6zdao7eVbFvwsF31B7
 wAPUdtx52v5eaQ4FyWvBgn9/gR3Px04TKaFgVF92SCKLXGAJSGPbR58ij/CpGBsxOSH+pE4uhw2jV
 ePu2zDzHvdrQUB/ObfRRVX20925Z/r/PsPQYp8v9DGfr/tT2ZqGjF8nLXX9bungawkaVfQtjqZW0l
 7JRb0Dak21MImDt2mkO4E9rX;
Received: from muradm by localhost with local (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oKo5D-0005np-1w;
 Mon, 08 Aug 2022 00:45:15 +0300
References: <20220722114501.5273-1-mail@HIDDEN>
 <CLO13EG52QG0.F152G8L34MRH@guix-aspire> <87v8r71909.fsf@HIDDEN>
 <cf6a4c2413045877b6c6143a6c35b8178e0dc77b.camel@HIDDEN>
User-agent: mu4e 1.8.7; emacs 29.0.50
From: muradm <mail@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: [bug#56699] [PATCH v2] gnu: greetd-service-type: Add
 greeter-extra-groups config field.
Date: Mon, 08 Aug 2022 00:42:09 +0300
In-reply-to: <cf6a4c2413045877b6c6143a6c35b8178e0dc77b.camel@HIDDEN>
Message-ID: <874jyn20et.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
Received-SPF: pass client-ip=139.162.159.157; envelope-from=mail@HIDDEN;
 helo=nomad-cl1.muradm.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: submit
Cc: "\(" <paren@HIDDEN>, 56699 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

--=-=-=
Content-Type: text/plain; format=flowed


Correct, no defaults are given. Attached is v2. Defaults
non existent, append/cons* irrelevant.



thanks in advance,
muradm

Liliana Marie Prikler <liliana.prikler@HIDDEN> writes:

> Am Freitag, dem 05.08.2022 um 09:44 +0300 schrieb muradm:
>> supplimentary-groups receiving a list, so I find it more
>> informative when adding apples with apples. And yes with high 
>> enough
>> chance more groups could be added to the list of defaults.
> What are "the defaults" here, though?  A sequence of hard-coded 
> values
> known at compile time.  There is no need to make that sequence a 
> list.
>
>> Is there any preference on using cons* in favour of more 
>> readable
>> append?
> Use of cons or cons* signals that you are only expecting 
> user-supplied
> groups to be a list and everything else known values.  Use of 
> append on
> the other hand signals that you are expecting multiple lists, 
> which
> even if you did are not currently present.
>
> Cheers


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLwMmsACgkQ6M7O0mLO
BeISvQ/+OnYE07rD+0gZcBs7XA2u02k8E31ywGhXeO4Ja8BHfHf9kmSDecmj0kD7
+k5Zwl8IrrADU8GP7MqJwcrc2grwpgMYbwqHTUPN6mHpINjgTyWGtKYsiuHbZ3Tf
+e0HfzVZ968G34xtZy9fiDX5XjGE3LNAj3x/rT1pWdEeLJYZPugTPqaDRZv/yUBv
W+bBKOIYO9X1MWDmsqAcNN1JiibLisgCKC7zIdvFgB4vYLdpni8I7z25ban1loqT
CBjT/3Lf1vUO1Kszf3reUWWVtXZ/a1znDutsvrFapdN9L+0PcLvKAc6wBtCde2sm
v5NcNGn2gse2wCSnEvJS24xouunZ1jiAusPk1jXH03sNLUAvTcC5aEpI2Wbfp2a6
WvOHpUTqojm0MByHgoPSaZwaT9rUKRK9HV1iRwVn8BaoKIkyM53pc98EV2syMPcW
fOVkBEFQCPUectmV5kryYnFvWUQdh7Wb3TR4heSuSTiKVwQFxWXqTG61hh3C2q9S
JkLcmF1HbuyARLwsAWZIlUfMUNdSjJZmp8urdJ+qPgcSCzcDFLQOjFwOKXZuj1Wt
cAvVcctO2CzMSl+blsWRELazYC9Jdfy0SxSXgQ8QPOzxun82ZwVESXzVVLJJgGCE
OWLrX4PWS4B9+QDlsVGq+cekxck8A0PHC0+RpJjGe6iFTFfZQoU=
=rpws
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#56699; Package guix-patches. Full text available.

Message received at 56699 <at> debbugs.gnu.org:


Received: (at 56699) by debbugs.gnu.org; 5 Aug 2022 07:54:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 05 03:54:57 2022
Received: from localhost ([127.0.0.1]:56046 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJsAb-00057C-5C
	for submit <at> debbugs.gnu.org; Fri, 05 Aug 2022 03:54:57 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:59922)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oJsAY-000573-IK
 for 56699 <at> debbugs.gnu.org; Fri, 05 Aug 2022 03:54:55 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
 by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LzdDB4XTlz3wks;
 Fri,  5 Aug 2022 09:54:50 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
 s=mailrelay; t=1659686091;
 bh=u7Rw+ftc15OQrS9H9QXjSt01tblam9Z7zUrjBP4x0Ow=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References;
 b=kUGbu3Vi1FhEtLf88LP2HDsKbCkfIyrmsAJT9oKP4ynHygigFonxxYUpnirfbXAtU
 NYlPIXHHJLptAV5afgKFh+FgC7jBovpx9RDPKe2HHmwmay1BbgysOIGa4+YzlQ5C4+
 Ytkk3r5vqaB71bYF/Yn1ds/nToWoB+hJrVWv36yU=
Message-ID: <cf6a4c2413045877b6c6143a6c35b8178e0dc77b.camel@HIDDEN>
Subject: Re: [bug#56699] [PATCH] gnu: greetd-service-type: Add
 greeter-extra-groups config field.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: muradm <mail@HIDDEN>, "(" <paren@HIDDEN>
Date: Fri, 05 Aug 2022 09:54:50 +0200
In-Reply-To: <87v8r71909.fsf@HIDDEN>
References: <20220722114501.5273-1-mail@HIDDEN>
 <CLO13EG52QG0.F152G8L34MRH@guix-aspire> <87v8r71909.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001 
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56699
Cc: 56699 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Am Freitag, dem 05.08.2022 um 09:44 +0300 schrieb muradm:
> supplimentary-groups receiving a list, so I find it more 
> informative when adding apples with apples. And yes with high enough
> chance more groups could be added to the list of defaults.
What are "the defaults" here, though?  A sequence of hard-coded values
known at compile time.  There is no need to make that sequence a list.

> Is there any preference on using cons* in favour of more readable
> append?
Use of cons or cons* signals that you are only expecting user-supplied
groups to be a list and everything else known values.  Use of append on
the other hand signals that you are expecting multiple lists, which
even if you did are not currently present.

Cheers




Information forwarded to guix-patches@HIDDEN:
bug#56699; Package guix-patches. Full text available.

Message received at 56699 <at> debbugs.gnu.org:


Received: (at 56699) by debbugs.gnu.org; 5 Aug 2022 06:48:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 05 02:48:15 2022
Received: from localhost ([127.0.0.1]:55879 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJr83-0007OV-G7
	for submit <at> debbugs.gnu.org; Fri, 05 Aug 2022 02:48:15 -0400
Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:47222
 helo=nomad-cl1.muradm.net)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oJr81-0007Nr-5C
 for 56699 <at> debbugs.gnu.org; Fri, 05 Aug 2022 02:48:13 -0400
Received: from localhost ([127.0.0.1]:33084)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oJr7R-0000kO-0h;
 Fri, 05 Aug 2022 06:47:37 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To
 :From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=rMfEqfyvjFr3pvOVIpz9aRo6xcgfh6+HKD8pSjPJFqo=; b=fjEf14Xi4YEx1lGzgj/8X7wepD
 4tj/qUFdN5v8gTgrRn3qudwhN6EQsyxPYUmEZNLTg9GLWSPUW7IBs+uuSYrePTiwVyddR15jBHT+c
 1IUJoFf91csjlDnUlYha67VjUTXsGlSAtjSBLk1o9pvOs+Maa2G5NFlZSQoxe8KuCFpfpdXOBbZBp
 65E8YDX2zib4Giygu1iWR02mKaGOwULPq9dMUVpW/gdOj6306RDJLZIbHlzQ7OszGPNrsk+zcTvc9
 FVkTLiGtyre25Los3In98LUw6B6WxRf4B0330wOvfVOBauJUH+HZsZbRrPvwyRU0b/NZzESyS4MCs
 Vs3AUDa//jZfks0Fh0IRJA6hhAkM0d4FFKJgs4U40QDqKsMKUGoMo1EQ7LN4pgH2shJwGO/MEsiB4
 TQxbF0xuls46BAFfKSvqiGyD8AeOpKTl6tyM1Kqvjoy7GRTT5oE/bs8qolMr2EwkhlWzmu3/lS7H+
 Yi9cpygQ8XqPb2g/SiQvZI6a;
Received: from muradm by localhost with local (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oJr7u-0007QE-2y;
 Fri, 05 Aug 2022 09:48:06 +0300
References: <20220722114501.5273-1-mail@HIDDEN>
 <CLO13EG52QG0.F152G8L34MRH@guix-aspire>
User-agent: mu4e 1.8.7; emacs 29.0.50
From: muradm <mail@HIDDEN>
To: "(" <paren@HIDDEN>
Subject: Re: [bug#56699] [PATCH] gnu: greetd-service-type: Add
 greeter-extra-groups config field.
Date: Fri, 05 Aug 2022 09:44:48 +0300
In-reply-to: <CLO13EG52QG0.F152G8L34MRH@guix-aspire>
Message-ID: <87v8r71909.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 56699
Cc: 56699 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; format=flowed


supplimentary-groups receiving a list, so I find it more 
informative
when adding apples with apples. And yes with high enough chance
more groups could be added to the list of defaults.

Is there any preference on using cons* in favour of more readable
append?

thanks in advance,
muradm

"(" <paren@HIDDEN> writes:

> On Fri Jul 22, 2022 at 12:45 PM BST, muradm wrote:
>> +         ;; video group is required for graphical greeters.
>> +         (supplementary-groups
>> +          (append
>> +           '("video")
>> +           (greetd-greeter-extra-groups config)))
> Change to (cons "video" (greetd-greeter-extra-groups config)) or 
> maybe
> use cons* if you think there's a possibility that more groups 
> will later
> need to be added.
>
> Otherwise SGTM :)
>
>     -- (


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLsvSYACgkQ6M7O0mLO
BeJeyBAAmowok7Um3s7D+Deg8pGTAW5s4WzJi/9grZM891wtzed8KOJJT/9/85Zf
9Aso9b36GGLkQDh+D/XznV7y/VTpu7bVIqqR9tC+Uiw584ixsbJcycy1sTeujGoO
uxyqinu0Es9X6dWsiFG9ss5OvYkbDzdfO87jXttfOExd8aEeoh96yNun7uj9zWbB
Onvo9KEny47tR2hMVmKPMcQ+jPWI3xH7wS2Am9+y+MqI2vI3dwirMmSCR78rS4/8
genDLCn5PTQZ8BmqFw42YBe1ByjDBNADEpJwSwUUdLBaDUEdTGpexg4cAVFM7xKa
y/uqaabDpLTS2RgE3V+OFs5CBfTPNXg5rQ9+zhWt7qjg5/zrq9+sMA70tzTOxRCJ
tEFuzfDHmMji6AWZeo1kgWy9EbnxE0uOn+Plh2aAQCYpCn9yTZ7wJtoWd4cE+LzK
GtkqXJhHfO7aMvbNnuN1N7BZtuAipE8kt0pqU1JKLNzM788lCsyIz6N4NJto1rxZ
+RHBFBtDupOTlGR+iCSujcl9wwUvbK0UuERGJmDk9LBtm2RV3HjhEI2btLAu3/S7
gog0NmeVjuOr9qkjVNnqEAp2K5K7UJbhy9gSFN79Xc1/EZuJOStjEx8i5JAbL9s8
qxmukgk21JSix19XPkS0v0XFYTfSH+Jg8lROCQSmPph+iQCtH2U=
=zZ0L
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#56699; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 5 Aug 2022 06:48:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 05 02:48:26 2022
Received: from localhost ([127.0.0.1]:55883 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJr8D-0007P6-S3
	for submit <at> debbugs.gnu.org; Fri, 05 Aug 2022 02:48:26 -0400
Received: from lists.gnu.org ([209.51.188.17]:54652)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oJr8C-0007Oy-Gn
 for submit <at> debbugs.gnu.org; Fri, 05 Aug 2022 02:48:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:51526)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oJr88-0007eq-Uy
 for guix-patches@HIDDEN; Fri, 05 Aug 2022 02:48:22 -0400
Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:56612
 helo=nomad-cl1.muradm.net)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oJr84-0007Vb-Rj
 for guix-patches@HIDDEN; Fri, 05 Aug 2022 02:48:20 -0400
Received: from localhost ([127.0.0.1]:33084)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oJr7R-0000kO-0h;
 Fri, 05 Aug 2022 06:47:37 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To
 :From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=rMfEqfyvjFr3pvOVIpz9aRo6xcgfh6+HKD8pSjPJFqo=; b=fjEf14Xi4YEx1lGzgj/8X7wepD
 4tj/qUFdN5v8gTgrRn3qudwhN6EQsyxPYUmEZNLTg9GLWSPUW7IBs+uuSYrePTiwVyddR15jBHT+c
 1IUJoFf91csjlDnUlYha67VjUTXsGlSAtjSBLk1o9pvOs+Maa2G5NFlZSQoxe8KuCFpfpdXOBbZBp
 65E8YDX2zib4Giygu1iWR02mKaGOwULPq9dMUVpW/gdOj6306RDJLZIbHlzQ7OszGPNrsk+zcTvc9
 FVkTLiGtyre25Los3In98LUw6B6WxRf4B0330wOvfVOBauJUH+HZsZbRrPvwyRU0b/NZzESyS4MCs
 Vs3AUDa//jZfks0Fh0IRJA6hhAkM0d4FFKJgs4U40QDqKsMKUGoMo1EQ7LN4pgH2shJwGO/MEsiB4
 TQxbF0xuls46BAFfKSvqiGyD8AeOpKTl6tyM1Kqvjoy7GRTT5oE/bs8qolMr2EwkhlWzmu3/lS7H+
 Yi9cpygQ8XqPb2g/SiQvZI6a;
Received: from muradm by localhost with local (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oJr7u-0007QE-2y;
 Fri, 05 Aug 2022 09:48:06 +0300
References: <20220722114501.5273-1-mail@HIDDEN>
 <CLO13EG52QG0.F152G8L34MRH@guix-aspire>
User-agent: mu4e 1.8.7; emacs 29.0.50
From: muradm <mail@HIDDEN>
To: "(" <paren@HIDDEN>
Subject: Re: [bug#56699] [PATCH] gnu: greetd-service-type: Add
 greeter-extra-groups config field.
Date: Fri, 05 Aug 2022 09:44:48 +0300
In-reply-to: <CLO13EG52QG0.F152G8L34MRH@guix-aspire>
Message-ID: <87v8r71909.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
Received-SPF: pass client-ip=139.162.159.157; envelope-from=mail@HIDDEN;
 helo=nomad-cl1.muradm.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: 56699 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain; format=flowed


supplimentary-groups receiving a list, so I find it more 
informative
when adding apples with apples. And yes with high enough chance
more groups could be added to the list of defaults.

Is there any preference on using cons* in favour of more readable
append?

thanks in advance,
muradm

"(" <paren@HIDDEN> writes:

> On Fri Jul 22, 2022 at 12:45 PM BST, muradm wrote:
>> +         ;; video group is required for graphical greeters.
>> +         (supplementary-groups
>> +          (append
>> +           '("video")
>> +           (greetd-greeter-extra-groups config)))
> Change to (cons "video" (greetd-greeter-extra-groups config)) or 
> maybe
> use cons* if you think there's a possibility that more groups 
> will later
> need to be added.
>
> Otherwise SGTM :)
>
>     -- (


--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLsvSYACgkQ6M7O0mLO
BeJeyBAAmowok7Um3s7D+Deg8pGTAW5s4WzJi/9grZM891wtzed8KOJJT/9/85Zf
9Aso9b36GGLkQDh+D/XznV7y/VTpu7bVIqqR9tC+Uiw584ixsbJcycy1sTeujGoO
uxyqinu0Es9X6dWsiFG9ss5OvYkbDzdfO87jXttfOExd8aEeoh96yNun7uj9zWbB
Onvo9KEny47tR2hMVmKPMcQ+jPWI3xH7wS2Am9+y+MqI2vI3dwirMmSCR78rS4/8
genDLCn5PTQZ8BmqFw42YBe1ByjDBNADEpJwSwUUdLBaDUEdTGpexg4cAVFM7xKa
y/uqaabDpLTS2RgE3V+OFs5CBfTPNXg5rQ9+zhWt7qjg5/zrq9+sMA70tzTOxRCJ
tEFuzfDHmMji6AWZeo1kgWy9EbnxE0uOn+Plh2aAQCYpCn9yTZ7wJtoWd4cE+LzK
GtkqXJhHfO7aMvbNnuN1N7BZtuAipE8kt0pqU1JKLNzM788lCsyIz6N4NJto1rxZ
+RHBFBtDupOTlGR+iCSujcl9wwUvbK0UuERGJmDk9LBtm2RV3HjhEI2btLAu3/S7
gog0NmeVjuOr9qkjVNnqEAp2K5K7UJbhy9gSFN79Xc1/EZuJOStjEx8i5JAbL9s8
qxmukgk21JSix19XPkS0v0XFYTfSH+Jg8lROCQSmPph+iQCtH2U=
=zZ0L
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#56699; Package guix-patches. Full text available.
Added indication that bug 56699 blocks56971 Request was from Liliana Marie Prikler <liliana.prikler@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 56699 <at> debbugs.gnu.org:


Received: (at 56699) by debbugs.gnu.org; 24 Jul 2022 16:31:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 24 12:31:45 2022
Received: from localhost ([127.0.0.1]:48563 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oFeW8-0002FP-QJ
	for submit <at> debbugs.gnu.org; Sun, 24 Jul 2022 12:31:45 -0400
Received: from knopi.disroot.org ([178.21.23.139]:43024)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <paren@HIDDEN>) id 1oFeW7-0002FF-2p
 for 56699 <at> debbugs.gnu.org; Sun, 24 Jul 2022 12:31:43 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 6B4D240DBF;
 Sun, 24 Jul 2022 18:31:41 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id kSK1doPcsqZB; Sun, 24 Jul 2022 18:31:40 +0200 (CEST)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1658680300; bh=25v0Gv3wW+K6GXqy3NLOP+5muck4pxgxhwV9rx0hA9A=;
 h=Date:Subject:From:To:References:In-Reply-To;
 b=YBKL7YAcPibGTWdsd+JacXcO9tFUilQSyvB00KX8eIstinpONzt/ceppRtPM8TFR1
 Cjgguw7sdFpdsdOMrvOFr7iVBEjdaocBz+U2sH6y61kuz7tRSk2l4tS/jZPosz2qXf
 /BKQtsPkSLafwXYQXz7+jumqyjCNCVZ5dzsa/9X9Wx5reqp8i8p4bDYva0GbIjr2bC
 ctukllkGbS9adIaG9EFxO09Vx81AoRj+UgzGle6bo1i75IwInZZIIZuz9o3aPaZR59
 X8K/fHdPGwtRNrqVtH7kXpS2JbrFyWdbNWyAJNsVbD0ZR7fOBilM2U2BVoFNDw+fnW
 Rc56LFPf3aNsQ==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 24 Jul 2022 17:31:39 +0100
Message-Id: <CLO13EG52QG0.F152G8L34MRH@guix-aspire>
Subject: Re: [bug#56699] [PATCH] gnu: greetd-service-type: Add
 greeter-extra-groups config field.
From: "(" <paren@HIDDEN>
To: "muradm" <mail@HIDDEN>, <56699 <at> debbugs.gnu.org>
References: <20220722114501.5273-1-mail@HIDDEN>
In-Reply-To: <20220722114501.5273-1-mail@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 56699
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Fri Jul 22, 2022 at 12:45 PM BST, muradm wrote:
> +         ;; video group is required for graphical greeters.
> +         (supplementary-groups
> +          (append
> +           '("video")
> +           (greetd-greeter-extra-groups config)))
Change to (cons "video" (greetd-greeter-extra-groups config)) or maybe
use cons* if you think there's a possibility that more groups will later
need to be added.

Otherwise SGTM :)

    -- (




Information forwarded to guix-patches@HIDDEN:
bug#56699; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 22 Jul 2022 11:45:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 22 07:45:09 2022
Received: from localhost ([127.0.0.1]:40306 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oEr5g-0000Np-Hm
	for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 07:45:08 -0400
Received: from lists.gnu.org ([209.51.188.17]:46916)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oEr5e-0000Ne-Gr
 for submit <at> debbugs.gnu.org; Fri, 22 Jul 2022 07:45:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:45724)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oEr5e-0000vc-7b
 for guix-patches@HIDDEN; Fri, 22 Jul 2022 07:45:06 -0400
Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:33722
 helo=nomad-cl1.muradm.net)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oEr5c-0001eB-7Y
 for guix-patches@HIDDEN; Fri, 22 Jul 2022 07:45:05 -0400
Received: from localhost ([127.0.0.1]:35736)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oEr5L-0004k4-2E
 for guix-patches@HIDDEN; Fri, 22 Jul 2022 11:44:47 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:
 From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:
 Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
 In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=Me7XkSa5skJ/BRdPTglmTHxilb4H0HWgfKmVOSWJ9h0=; b=xe4ChSYPV3tafr9c2MJepkoP8E
 cuy1ftLbN/Byafl1fhnBegKxtPOo3eAdDVemc/7tplTMLQ8Fy81mJmpmCY+yNIqRfAwNIO5pI9kp4
 P+crarqwSO7TusSA8vpVL0o2+ajuTZL/hct7FhaO1VeHF3B/8L+U2wkYnX7W8Wn3rmHqT3Nd1LuCq
 +UVriar8W+HJSe6QIOSevxuPgv89pC8Co/tYK69LApUPNhC5ANUxjz66lmwDXr7olPAIY5TH8w+m4
 0nfbNP+z730jdgDzaYy88Vo91zyN2wxQ6iPa1rG9B5bIgDijVM3ZRKxsLhl4P2uVMcng92EwfU1GZ
 v6bXtd9Hd/OO6QvutA5o+GAl6xvOwvU2nLjN3L83jvt7WIcUSQvJ//zM/IrTqdyEwn9ygzN973fwQ
 Wy9PKPMkM81qNAxJvs9ifOQTviE29TIbKyfOmhbSrZvZur4FvGyveNJVYtNg6C3+x4fZMu31Ym2gq
 nVzYVGxIdpfJCrLJAPF3nGV4;
Received: from muradm by localhost with local (Exim 4.96)
 (envelope-from <mail@HIDDEN>) id 1oEr5Z-0001NB-1b
 for guix-patches@HIDDEN; Fri, 22 Jul 2022 14:45:01 +0300
From: muradm <mail@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: greetd-service-type: Add greeter-extra-groups config
 field.
Date: Fri, 22 Jul 2022 14:45:01 +0300
Message-Id: <20220722114501.5273-1-mail@HIDDEN>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=139.162.159.157; envelope-from=mail@HIDDEN;
 helo=nomad-cl1.muradm.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/services/base.scm (greetd-service-type): Added configurable groups.
[extensions]: Switching accounts-service-type from const to function.
(<greetd-configuration>): Added greeter-extra-groups field of type list.
(greetd-accounts-service): New variable, function returning list necessary
accounts for accounts-service-type, including the greeter-extra-groups.
(%greetd-accounts): Removed.
* doc/guix.texi: Mention greeter-extra-groups field with example.
---
 doc/guix.texi         |  8 ++++++++
 gnu/services/base.scm | 28 +++++++++++++++-------------
 2 files changed, 23 insertions(+), 13 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 3c5864ec1a..51678b7f19 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -18493,6 +18493,14 @@ the 'root' account has just been created.
 @item @code{terminals} (default: @code{'()})
 List of @code{greetd-terminal-configuration} per terminal for which
 @code{greetd} should be started.
+
+@item @code{greeter-extra-groups} (default: @code{'()})
+List of groups which should be added to @code{greeter} user. For instance:
+@lisp
+(greeter-extra-groups '("seat"))
+@end lisp
+Note that, however it will fail if @code{seatd-service-type} is not present,
+or to be more specific, @code{seat} group is not present.
 @end table
 @end deftp
 
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 27eae75c46..94c8dcac2a 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -2918,17 +2918,6 @@ (define (make-greetd-terminal-configuration-file config)
      "user = " default-session-user "\n"
      "command = " default-session-command "\n")))
 
-(define %greetd-accounts
-  (list (user-account
-         (name "greeter")
-         (group "greeter")
-         ;; video group is required for graphical greeters.
-         (supplementary-groups '("video"))
-         (system? #t))
-        (user-group
-         (name "greeter")
-         (system? #t))))
-
 (define %greetd-file-systems
   (list (file-system
           (device "none")
@@ -2956,7 +2945,20 @@ (define-record-type* <greetd-configuration>
   greetd-configuration?
   (motd greetd-motd (default %default-motd))
   (allow-empty-passwords? greetd-allow-empty-passwords? (default #t))
-  (terminals greetd-terminals (default '())))
+  (terminals greetd-terminals (default '()))
+  (greeter-extra-groups greetd-greeter-extra-groups (default '())))
+
+(define (greetd-accounts-service config)
+  (list (user-group (name "greeter") (system? #t))
+        (user-account
+         (name "greeter")
+         (group "greeter")
+         ;; video group is required for graphical greeters.
+         (supplementary-groups
+          (append
+           '("video")
+           (greetd-greeter-extra-groups config)))
+         (system? #t))))
 
 (define (make-greetd-pam-mount-conf-file config)
   (computed-file
@@ -3033,7 +3035,7 @@ (define greetd-service-type
 login manager daemon.")
    (extensions
     (list
-     (service-extension account-service-type (const %greetd-accounts))
+     (service-extension account-service-type greetd-accounts-service)
      (service-extension file-system-service-type (const %greetd-file-systems))
      (service-extension etc-service-type greetd-etc-service)
      (service-extension pam-root-service-type greetd-pam-service)
-- 
2.36.1





Acknowledgement sent to muradm <mail@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#56699; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 7 Aug 2022 22:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.