Received: (at 56739) by debbugs.gnu.org; 9 Sep 2023 06:12:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 09 02:12:21 2023 Received: from localhost ([127.0.0.1]:45963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qerCe-0007yN-VJ for submit <at> debbugs.gnu.org; Sat, 09 Sep 2023 02:12:21 -0400 Received: from mout.web.de ([212.227.17.12]:38523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1qerCb-0007yA-Vu for 56739 <at> debbugs.gnu.org; Sat, 09 Sep 2023 02:12:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1694239921; x=1694844721; i=michael_heerdegen@HIDDEN; bh=Tqe2iw31jDj5tENdz5/s0xMwDxqXDY6q4KFnM0KI9Ts=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=G+AdSjwSI4PU1DAtx3EMGvht901wU/1NYqzo6d7M+phflpQue16Xk/fNZNRfO3/EX+Gq0NC RtnH48vMjab1CxW8a10T4N7Mdori26vAipJUi7zja5N2mkiz9zBxW8waTphew3+OkgYvCl2oE g8f78YUKC85VXUKVZRFs/06CkVbs+AEjyLmTIfgydHGCdSzXuf43ziNs/6bR69+WW1hx4QRb8 5J9Zs3iM+1N/Zy33b5EMce2fKU7lJ4fdEWjKNY1Xn2XwBMPyPo3HPwXByQJtgFTmAE8IM1hGp H0Zl731u8KpWhx0puk1MPLaLsK156G1qbEsW1NMHgmIdQbPFeL2Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.191]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M59jC-1qdkjl2apg-001dbT; Sat, 09 Sep 2023 08:12:01 +0200 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros In-Reply-To: <87h6o55pn8.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 08 Sep 2023 05:07:23 +0200") References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN> <8735eeyz7e.fsf@HIDDEN> <87y1w6xjmg.fsf@HIDDEN> <jwv4jxls0qg.fsf-monnier+emacs@HIDDEN> <CADwFkmmYJzsNgx1Xq=t-fPJndga2DYWQY35LtvKFxHxgYs_7NQ@HIDDEN> <87h6o55pn8.fsf@HIDDEN> Date: Sat, 09 Sep 2023 08:12:00 +0200 Message-ID: <87msxvg9jj.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:u/JThdWUWR5nLm7kDE90ZmX78zJvhPEeP3DMtn6FtTFB9m/eZH2 8s86mMQJUmXCnLP1MV+e3tIy3RDE3odl7bhn0HgjUJ+SvEcCuBOYT3xj/AtVcU1wKizXk/Z 2rCiAEg8PibgR9fn/TGTr9jH3l3kTcU6S5DyCX87jCnkikoqMEkaP/niN094DmKa+8vMsSQ 2J1ok73O70gzjYdvJ5h4A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:6uPyDkLw6sQ=;jiLsS0HqBe1ja7NpzKIDRCkCoIf mvOVPKe2Ez4un3g3LPoVBkrXvCbceHxKQ2fD+JSM5ZSkLgl7Cwqwn+5jwZQxuncV4WUhP5CwZ 3h8LCtYhDJMo4xt2exp19yi+x8v1/d6QbmQQFhhMA2KejM3qRmq8u9NmcL+sJjq7GO2O655kE l226qfNmLuPMr9z40QYQ9NciP77+mQTOx9uiMHpMAcUNDzBdDPVm7xZ06ZbxvuWHp1WJfi1k3 eDExRK4M2VbJVcNtCF47f0BcgRQHRSdIdKSAfAXFqx8Nf0ISzbntjBQS+1OkJzhsNhimHLyq3 PQd5ma/pIBlu4Hwl1hvUC9Zdk8C2hTe9CXsS+J7yKnfvx/5HeaIoF0LZrBD/Qe9AUXdP8MUkt 0/ePZ97SvJ2SxgvJoOtJHKCRbJqRLiL+JrFA6B91p0ff6Q4DhUHq83z+gKvZJEyK/xoGUCCjB mYnDt12laWZZFmHCi+/j9C85zlICFZ2vsofZHj1uGdTsTCVBIsoNsC46ii9RLaYhs9KqqC6Tg JV+mtfyfdAJR3C53iQ6BUu9bEM0Q7p7pWjLMRozgusc+20N+DoNPYWH7euB7WsV5VzPedLKmB A0JJOgw9uRJ/ogXL6QIid981lBkxviRWbWxbYos3ts/Yd+hgtLam/YRz1LiZULXEbvgY68EPN ioKJyd4Af3PM97drUduw2iFWuma87O5rp5LJxxCQQrw2AN2TdFDRCWue4ERIMCR2/Uf1CotKF bjw7zhxSECuoyXb0gkc1hkQCx8s0dDuHaSETuAKMiT3vs8b3AtHFSQdCdoNl/DslUe+UmySPk Sn7Fb7sNIynSmlQRa6XDh/BRZa4v6/2M6bkDA6sXgTSWOOgn9honVro/4WKl2/3z+ZIKdf5G8 kh1i+Fk9SYRmzG4888Hiu42JtvJu6LsQh/BNPO+75cQp/SBfwcnLyaVPp36ASsgiDn6j6uCNp OVOXWib+ify1klAg9xWkyQ9DeM0= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56739 Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, 56739 <at> debbugs.gnu.org, Wing Hei Chan <whmunkchan@HIDDEN>, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > > Michael, did you have a chance to look into this? It would be nice to > > get this bug fixed. > > I would rather leave this one to Stefan to be honest because I'm only > partially understanding what is needed. Or maybe Gerd can help? Don't want to bother you Gerd, but maybe you are even interested in this one. Regards, Michael.
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.Received: (at 56739) by debbugs.gnu.org; 8 Sep 2023 03:07:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 07 23:07:43 2023 Received: from localhost ([127.0.0.1]:41831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qeRqR-0005pN-4s for submit <at> debbugs.gnu.org; Thu, 07 Sep 2023 23:07:43 -0400 Received: from mout.web.de ([212.227.15.14]:42271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1qeRqN-0005p6-P2 for 56739 <at> debbugs.gnu.org; Thu, 07 Sep 2023 23:07:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1694142444; x=1694747244; i=michael_heerdegen@HIDDEN; bh=YffbbF1Fo7OW4F8XqNVpR5tcfgvSvzxuu+Hef+u83vI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=IDOoIGv8B3j5dvBT7geZ3myw/634IFOaXkq9l8UuS2fOii5ParAenjx+KZ9azSaN7NuAfZq 5Qq5iVn5PETtqwXtw8jsll/ElqmH6KOoU3i2K5nyM3bGuNrnEtoAAbJ7KEth3QfYX6grTl4Cb LQhSZ2VDkym4wrjHekEvTsAbFNnQGeNwmi+T0BrA2W9pfiTRwZD6FALv2Tm2sNcftN8BtDtvj pve7PvL9/T9SPYn2elguI7j6hcq3rhbTQ/mXHB24LWKPicoPtchZ8NCEknN/LFrqz3xeAo4ma tu27ofLH3cshT7qQT7WsGdgjZSGqFXhnJVTW9xhEY3q8ABReMDew== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.191]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N8Epo-1paQyy35Wq-014RkR; Fri, 08 Sep 2023 05:07:24 +0200 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros In-Reply-To: <CADwFkmmYJzsNgx1Xq=t-fPJndga2DYWQY35LtvKFxHxgYs_7NQ@HIDDEN> (Stefan Kangas's message of "Thu, 7 Sep 2023 11:31:34 -0700") References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN> <8735eeyz7e.fsf@HIDDEN> <87y1w6xjmg.fsf@HIDDEN> <jwv4jxls0qg.fsf-monnier+emacs@HIDDEN> <CADwFkmmYJzsNgx1Xq=t-fPJndga2DYWQY35LtvKFxHxgYs_7NQ@HIDDEN> Date: Fri, 08 Sep 2023 05:07:23 +0200 Message-ID: <87h6o55pn8.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:4QIXbFXeMJ2Rj8gcUOHBjxAQFViR6Tnjz9JJy49byTnx6qLy+5H 6iTAS2tBpbIwG6WttzE39/A61FbKNIeat9+/Etb4dAFJOBCbDHOhwwiHsy9wYSlvJU0qG0N mCY4uccaQeVQaCRBWuJaC+THCf0qs6hMQMls5vSUeSFOQzSzg2yuJDhEUVJZvt/F1GKIKyJ /4aEoukeZlfOQDwXyrppQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:zwMKjE7Ku+I=;CfuEhwUi9bPWdX2PMO38R9dsb9y wzzoy8Yjf2LwMAyT+fVt8EqzglAPuGcnllovT3ZFsxAJMOU6UAeTR7eLdmgNFJR9sodFNG6Yn krqwQSe3ybq4n7M0wFLViRDSMDAg8TnUaGsQslNH1A7IFTymxQyn/wt4rc8+CSh3voxaBjZlh S50A4tXRJ8K4UeHH7un4qw5iWh6sgMQ4jcmaMwVJJwiy5bL8A0ZPaqy93X5idpJtbM2MhX8QS hTQjGHIN6zGOYJgUL0VSCRhNqxzeDuvQvUzUt0LoN4M6d/iGxJSVt7OCjSMTtaFM/+Q88AXP0 W3zY+028+WRv0uU9afTtN6kN5fhTlyXti4twpqCV5vh3ch3c5/Yo+/86972c98QH5e0YF6g5d KKNP7wRPdaLCEQOIiCqbNZURGg+msmWKGHenUCmzWCzesb4ivoqa6pFfp0T824KZ0LdsV+XaF lV1DXzE/3bOSIpjhvpcrSQX5l0zv77fTFS9G+AKWNsYgD5yobISqRgC1OnFJRa2VWHl+Z45zJ EoLU5LUAYso+k61WbZi10GHOr9reoxtlcoj5+jrgj+umdSEF4DiHik7uou94BFq+oUCFeguuO zkD3EU6NUovajX4LAaEZ/bI5Kz/cFbbnVUfqFZe+O4JaaY4Pngb1BVGO1QZOUqL+I2ED0rSPh PBuC+MBmEKQvPSTerjqCntOWbrgPXXvxCEolJPwUSHFmEPVgFU0jCoqrGEOpqOY1XNqHCI9q7 H27YHY9LI98v6DfiCDoLQEddGhOPKwgCdnkPVQn0TAXo9omeGMEhmuu8d9zTAKjl8+8oGuIQO YwGr2QyY3IOJXruiuZKEWHsBJvu1pyt4AupZyEUXEXxKjtIHXdvBzFM42W0yaClTHYhyp9Ns7 kVQgC0h6d9KFScBB6hHeg7qh1Kr2xmobXRjjcgPMRRYVV8Y8Z/sn/RDX/Xcm2+ZCA/HWFnjKk RA3mT3EFY+Wg7qXrff+9poyWvQk= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56739 Cc: 56739 <at> debbugs.gnu.org, Wing Hei Chan <whmunkchan@HIDDEN>, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Stefan Kangas <stefankangas@HIDDEN> writes: > Michael, did you have a chance to look into this? It would be nice to > get this bug fixed. I would rather leave this one to Stefan to be honest because I'm only partially understanding what is needed. Michael.
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.Received: (at 56739) by debbugs.gnu.org; 7 Sep 2023 18:31:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 07 14:31:47 2023 Received: from localhost ([127.0.0.1]:41406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qeJn8-00017B-Oj for submit <at> debbugs.gnu.org; Thu, 07 Sep 2023 14:31:47 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:54390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1qeJn5-00016s-3Z for 56739 <at> debbugs.gnu.org; Thu, 07 Sep 2023 14:31:45 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-5009d4a4897so2157572e87.0 for <56739 <at> debbugs.gnu.org>; Thu, 07 Sep 2023 11:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694111495; x=1694716295; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=K7H5TpCkzqmt3o8Q8NlznPBwPvqgvvbsN7ghYmHEFiI=; b=UAmb33BYFZYBrtZcoGACRgJkzoZzezVGhIQIXG8V9pjz3sGLUQgGew67XuR9iM+eSN gXeJhNmx8RPr1Pfn13uhX6dWcLITVQE+iGn7n+yqpd+iRO/Ti/OVRX53pC+W/enkXr13 L1DC6Pp3WgF/RTJVjakaSOaMbkmeS9cH1ldsbDN4BaqCwFVeI1GVUBJHAUNrvL20rTN1 YsExmIJkWLL5s/PUi2wFiqPftSu+64fZnWekBeFJuctQyI487u9kk7tRBfZ8GLCoJRMN qZP0QrD3UrPRJn6ahDcy5Z0cAPM78SUX7qPkm0X+fi1mZ1gz1da1eha0mYkSDr/APPeP TIBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694111495; x=1694716295; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7H5TpCkzqmt3o8Q8NlznPBwPvqgvvbsN7ghYmHEFiI=; b=ifSrHe3dx4dIznAJTUVYA7wV9x3+DPSzmCC09j6a3s4Ah412dDxDoyQvQoiFP3QxTd 9d0cW1Qncl6BZf+4Gg6ABvOn8KaW8PnHWXtdLexL6ALYGCwT97c5vVMSiz44DToLxT1L gem8I6lRTakrQJtrxR3ygEqpol+xiJQ4+LxDCab9pcbhHP7R/U0w3DJ9RLpu4ie8hXDV K81OG4jMkXYFFdlfZPdn+pD/0xKunHQ4+xn8mwLi/9rUmyIu3RxIPVQZnoNisz3kDTEq BoNn13ae+/gSKZRhSOB19nw5GQ/VqVSEJ8CRgf6JDujPVeAsg+/jG60OJNnn5uakRJ8+ 6YTQ== X-Gm-Message-State: AOJu0YxV3IIMle3Mim9R8uNwCpKqv/lf/a+tb6e8kDl6JGsLTQZL5r8G cnd9mgtdcEy+wGGdPC/DfRcEsJBjMpoGA1XvkW17G7t4UIE= X-Google-Smtp-Source: AGHT+IEl/mgZMbt9GZs9EEVtueYc/6KTnLOFOwHaQwW/iqHmHGeia37MLdWDJidzDa8bgWSiddYZgI0Nylg1visSVFI= X-Received: by 2002:a2e:350d:0:b0:2bb:9710:9d89 with SMTP id z13-20020a2e350d000000b002bb97109d89mr57033ljz.10.1694111495146; Thu, 07 Sep 2023 11:31:35 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 7 Sep 2023 11:31:34 -0700 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <jwv4jxls0qg.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message of "Mon, 05 Sep 2022 22:22:28 -0400") References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN> <8735eeyz7e.fsf@HIDDEN> <87y1w6xjmg.fsf@HIDDEN> <jwv4jxls0qg.fsf-monnier+emacs@HIDDEN> MIME-Version: 1.0 Date: Thu, 7 Sep 2023 11:31:34 -0700 Message-ID: <CADwFkmmYJzsNgx1Xq=t-fPJndga2DYWQY35LtvKFxHxgYs_7NQ@HIDDEN> Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros To: Stefan Monnier <monnier@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56739 Cc: Michael Heerdegen <michael_heerdegen@HIDDEN>, 56739 <at> debbugs.gnu.org, Wing Hei Chan <whmunkchan@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier <monnier@HIDDEN> writes: >> - (let ((p args) (simple t) (vars nil)) >> + (let ((p args) (simple t) (vars nil) >> + (smacros (alist-get :cl-symbol-macros macroexpand-all-environment))) >> (while p >> - (if (or (not (symbolp (car p))) (cl--expr-depends-p (nth 1 p) vars)) >> - (setq simple nil)) >> - (if (memq (car p) vars) >> - (error "Destination duplicated in psetf: %s" (car p))) >> + (when (or (not (symbolp (car p))) >> + (assq (car p) smacros) > > This looks like a safe way to make it work when the place is > a symbol macro. > >> + (and (symbolp (nth 1 p)) >> + (assq (nth 1 p) smacros)) >> + (cl--expr-depends-p (nth 1 p) vars)) > > But this doesn't look strong enough; if (nth 1 p) is (+ c c) where `c` > is a symbol macro the same problem will appear. So the test needs to be > pushed into `cl--expr-depends-p` (probably into `cl--safe-expr-p` where > it will fix other related problems elsewhere). (That was one year ago.) Michael, did you have a chance to look into this? It would be nice to get this bug fixed.
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.
Received: (at 56739) by debbugs.gnu.org; 6 Sep 2022 02:29:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 05 22:29:35 2022
Received: from localhost ([127.0.0.1]:49263 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oVOLH-0004TR-LC
for submit <at> debbugs.gnu.org; Mon, 05 Sep 2022 22:29:35 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52603)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1oVOLF-0004TF-RM
for 56739 <at> debbugs.gnu.org; Mon, 05 Sep 2022 22:29:34 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A8080807C3;
Mon, 5 Sep 2022 22:29:27 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 579F880070;
Mon, 5 Sep 2022 22:29:26 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1662431366;
bh=5BOMamr5+Jrxc7FrS6nciS9zS/eRY1u10GKfsWshzsg=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=n5dHqem7MsAsYZAGxhlZ+1lMU7cGbfCAWmbmmfVFP0z2XeE3PhJ7XJDFp+ecvGoNo
VqXoMXwVn/Io1YSHkjHIc4Jimabg7OHR2wOlrifsV53ft+5tQdDSZUzckcN7rkuR7k
DVtuF2lbhcAOhrks7e7kl7hYkpAHUF2s0dnzJV9WPx+vItuyhW3Q1iHMO9n4/yt4nO
lPFpgwM7ofc8btYkbI5oXzCURn8DBwAkdY6G0Icmvrl+SvobtQjL2NKjs3M2Yb4y0x
sNGBJtj9uSSbrfesaNhxPyA7IoZ9Mt6MIX1quPYHscHzfW0PxgI45nI8yiXRJxdInv
nLgvPkn+lncdw==
Received: from pastel (unknown [157.52.9.190])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 27B63120748;
Mon, 5 Sep 2022 22:29:26 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Wing Hei Chan <whmunkchan@HIDDEN>
Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize
symbol macros
In-Reply-To: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN>
(Wing Hei Chan's message of "Sun, 24 Jul 2022 20:12:10 +0800")
Message-ID: <jwvy1uxqm0h.fsf-monnier+emacs@HIDDEN>
References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN>
Date: Mon, 05 Sep 2022 22:29:24 -0400
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.068 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56739
Cc: 56739 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> The following form produces (2 2) due to the failure of detecting
> dependencies involving symbol macros.
>
> (cl-symbol-macrolet ((c a))
> (let ((a 1) (b 2))
> (cl-psetq a b
> b c)
> (list a b)))
BTW, another way to get similar problems is with `defvaralias`:
(defvaralias 'my-c 'my-a)
(defvar my-a 1)
(let ((b 2))
(cl-psetq my-a b
b my-c)
(list my-a b))
We should probably introduce a `(macroexp|cl)--simple-var-p` test to
catch the various cases where symbols aren't simple variables.
Another thing that might be worth digging into is how important is that
`cl-psetf` optimization for lexical variables (remember: this was
written back in the days of dynamic scoping and Mattias has made some
improvements to the compiler which may render this optimization
redundant inside the macro itself.
Stefan
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.
Received: (at 56739) by debbugs.gnu.org; 6 Sep 2022 02:22:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 05 22:22:39 2022
Received: from localhost ([127.0.0.1]:49242 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oVOEY-0004ID-TH
for submit <at> debbugs.gnu.org; Mon, 05 Sep 2022 22:22:39 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15877)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1oVOEW-0004I0-VC
for 56739 <at> debbugs.gnu.org; Mon, 05 Sep 2022 22:22:37 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 252BD100129;
Mon, 5 Sep 2022 22:22:31 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BFD331000B9;
Mon, 5 Sep 2022 22:22:29 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1662430949;
bh=1cyttE2jkm7muGt0gJn2v4Z5wFcJ3QfD+1ULFV8/Vtw=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=aFvjnAtaX3fcq3EGD6fZMh4CkrvWC4iTIG88oWOO5ppCWwAMYdZeS7wzLfMQe1u3h
gRgxyFo7vylheHtln2RPNOqu6T0BBMYYvgWEd3XIFxPkFwd4UVEP2OSIXJo2zTjWbv
08moGQote9o3Gy3Ert/tOmz/fuqZBkOWDpIAiw1dJrMp8JNyOUhxPXKOBYHXX59akI
WlUAxYKpAbuTv0F5NPiFdEFrqdh9Ef+bH3z3xc12cVSwLRIFae+X7S6P5vImEvrE8O
4nGNWNOyFSPTq5JifjY87i+RvpgY8juFksFe0xUKpiCMc3ZeRhVtKTX4Ae6GsQALug
uW8prNUFUnv8w==
Received: from pastel (unknown [157.52.9.190])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7DC23120909;
Mon, 5 Sep 2022 22:22:29 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize
symbol macros
In-Reply-To: <87y1w6xjmg.fsf@HIDDEN> (Michael Heerdegen's message of "Wed, 03
Aug 2022 02:20:55 +0200")
Message-ID: <jwv4jxls0qg.fsf-monnier+emacs@HIDDEN>
References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN>
<8735eeyz7e.fsf@HIDDEN> <87y1w6xjmg.fsf@HIDDEN>
Date: Mon, 05 Sep 2022 22:22:28 -0400
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.043 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56739
Cc: 56739 <at> debbugs.gnu.org, Wing Hei Chan <whmunkchan@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> - (let ((p args) (simple t) (vars nil))
> + (let ((p args) (simple t) (vars nil)
> + (smacros (alist-get :cl-symbol-macros macroexpand-all-environment)))
> (while p
> - (if (or (not (symbolp (car p))) (cl--expr-depends-p (nth 1 p) vars))
> - (setq simple nil))
> - (if (memq (car p) vars)
> - (error "Destination duplicated in psetf: %s" (car p)))
> + (when (or (not (symbolp (car p)))
> + (assq (car p) smacros)
This looks like a safe way to make it work when the place is
a symbol macro.
> + (and (symbolp (nth 1 p))
> + (assq (nth 1 p) smacros))
> + (cl--expr-depends-p (nth 1 p) vars))
But this doesn't look strong enough; if (nth 1 p) is (+ c c) where `c`
is a symbol macro the same problem will appear. So the test needs to be
pushed into `cl--expr-depends-p` (probably into `cl--safe-expr-p` where
it will fix other related problems elsewhere).
Stefan
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.Received: (at 56739) by debbugs.gnu.org; 6 Sep 2022 01:30:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 05 21:30:05 2022 Received: from localhost ([127.0.0.1]:49223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oVNPg-0002zP-V1 for submit <at> debbugs.gnu.org; Mon, 05 Sep 2022 21:30:05 -0400 Received: from mout.web.de ([217.72.192.78]:56069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1oVNPf-0002yS-Pk for 56739 <at> debbugs.gnu.org; Mon, 05 Sep 2022 21:30:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1662427790; bh=MzfpYeOLMeZDipAIlhqvuDqvs1ijC9//LEeDglord9A=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=cOEKbGIWjW6xzVjwc1BSLFu339yhzc+bbsSq3i/knrK7rv61xmAT0BLFuvKC7a4se x088WhsPnpW4BV1xUUMISePaSFB+FwxGlgnpgVu3OyJ1cQqlFillwCfR0/w/86nvLb Z4H4FRZncMKK6i6U/zuwrOGhgCU1BW2gKmh8sXDg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([92.208.190.67]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MkEhH-1pFgal0seX-00kTZI; Tue, 06 Sep 2022 03:29:50 +0200 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros In-Reply-To: <87zgfdzl9g.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Mon, 05 Sep 2022 21:14:35 +0200") References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN> <8735eeyz7e.fsf@HIDDEN> <87y1w6xjmg.fsf@HIDDEN> <87zgfdzl9g.fsf@HIDDEN> Date: Tue, 06 Sep 2022 03:29:48 +0200 Message-ID: <87pmg9guib.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:KOIC56UH9/F+J4508lBwTMLNVIFPSba5TlT5o9zz0rjH9S0zZyG zKR900xrnQLnD8cHl0e/8c2ZGotvA9OhcsVQcexw0vY/iwqrdFpE6HVX0Hp93KVej1u6HXw FRI8rrISn/u0O+DalOZhqlfZHOvCXGA2vnAP3hffjwSdJLK+ABlEBj4VfZEch/KqOS4kJCN VWOq80fmVtKg3iDvfTtGw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:2s4+AuAEhPg=:hFBlXhRfhLlbYt3AaVMm5k A0IGK6T0Tjv0950i2eFjec8VRb2YjO0/0RNGry+zFfX9/jJwQWfudEyCca7VmcIl+do/XFGlZ h7NO9J0FFdjuIZQrPAJSj/5snWKt61c+8lHMlTCQYs31k4XBmNTl1kZXaLQFal5RuqM3lnsYc axbTs2+3KOorDvJyD3Er9Ra36svn8OAE94P0IwtNVOPYgJlCbivcJsjptmzVC8FScoDPgnUSR SjF1nSY6Hr41SXt+a9OOrOkKLAehV5AVLgPgex1oH8ukUPynfrefLrCSaqasUV2PCPYz6ElJK B9yL2BM3/mu4Mic2LsPq8LYchR/vboie2+9YnSgV/zR97BFOs/kdOgWVkvmIORXVXnjap+gs8 vZABsGZae0LWjBtLllFEOG1PtUbKGd2fLBiNV8F3jpamLh2MJUfIvNfprkumpBIJMdFXcfbHR m6i8p9DhdZ0PXJNS1nUWSc42hn3RzIZhvtU4Aqh+KiHVUoPuV2y8MvDrL/NOFSgVqlld2FqvT Iw+j2cPTqQneJor6wYtdQObvDxfnxxegiKCHCnI4r949ANwZj7+8PA+wOsqdx2YVslHW+Va5u c3715Y6ZrciVYUIGlx4O/jm25WEMoeRjlAVTVhR6550nC9HN1dN46GzRbwbi6ep0QJqlRvKm9 Az9E3lCZul0E91Vs4GM9VglXWIF+ahntBcaNCEDs91SAhNS8mkXxl75PgbGUZfMFYSm5D2NtN jlQo6FRonpn1ZsJm1VQv/fTPALi/kaqE0zCWt5fztIJBISktpC2y1bye3+idxkPF1LWJX8V02 dZDP/6/tBOrsk4BVWq8W5fqP1J2V9oRYvHKg7s4vakIMWHavtUlPn2PestIuebQkyYqm1dlT7 xHEEo0nCExmX2AOn2NQ14hwZv0x3lRJYhbuQ1Vl4WS7StvU7Yz+ES6JkmGzGWzXJqoG1Ngpky bS3hxaF6UdLPw2OKW2/SIfpIvr4PKRyUK3caITfZoGNWJtSxJmj1OTHh5CXD8mteccGbY4D1i t84uh/l8QwpJdHf9vYJA6EGMZDtfOBXnMgZJ4Et7j18RBZ+zncoBwZfIgQjaTqe8twIGvTSk6 CSj9711ebyUj87rZqPxNPWSkn5mrLlKvpkWxPizqCVbyK/tDwJHkYpf4itPMo2cb4apTMSAM3 pcdZAR7XWMP/XwxeFvlyuLcrJK X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56739 Cc: 56739 <at> debbugs.gnu.org, Wing Hei Chan <whmunkchan@HIDDEN>, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Lars Ingebrigtsen <larsi@HIDDEN> writes: > This was a month ago, but as far as I can tell, this patch was never > pushed. I didn't want to push without at least one person saying "looks good". Michael.
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.Received: (at 56739) by debbugs.gnu.org; 5 Sep 2022 19:14:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 05 15:14:48 2022 Received: from localhost ([127.0.0.1]:48904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oVHYW-0001dx-Jj for submit <at> debbugs.gnu.org; Mon, 05 Sep 2022 15:14:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1oVHYU-0001dl-N5 for 56739 <at> debbugs.gnu.org; Mon, 05 Sep 2022 15:14:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lzFicOJAb2gZs0TfCGflOFX8YlrRLyPxqjVpimtmBl4=; b=sKMkttD7Enu9pBVbminhJCAy8y pBupyXIaJGYdWfQ1qmg74VqF4JXmGsgGuv5oRVWvNpR/oalsMm1Q+YaNN92Uxs85ic1+qifIb1Dwp 0tDzwxAPG98lgr3P4RJwW5nydRux/tQtX8urzsXAyN4VFyvEJncjtsi/olT/bTNPh4SU=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1oVHYL-0004Z5-Bj; Mon, 05 Sep 2022 21:14:39 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros In-Reply-To: <87y1w6xjmg.fsf@HIDDEN> (Michael Heerdegen's message of "Wed, 03 Aug 2022 02:20:55 +0200") References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN> <8735eeyz7e.fsf@HIDDEN> <87y1w6xjmg.fsf@HIDDEN> X-Now-Playing: The Rolling Stones's _Black and Blue_: "Crazy Mama" Date: Mon, 05 Sep 2022 21:14:35 +0200 Message-ID: <87zgfdzl9g.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > I think we can fix this (both cases mentioned) similarly as in cl-letf: > > From 29ea21a751ab6e71b2fb34c781131e31fc7b950d Mon Sep 17 00:00:00 2001 > From: Michael Heerdegen <michael_heerdegen@HIDDEN [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56739 Cc: 56739 <at> debbugs.gnu.org, Wing Hei Chan <whmunkchan@HIDDEN>, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > I think we can fix this (both cases mentioned) similarly as in cl-letf: > > From 29ea21a751ab6e71b2fb34c781131e31fc7b950d Mon Sep 17 00:00:00 2001 > From: Michael Heerdegen <michael_heerdegen@HIDDEN> > Date: Wed, 3 Aug 2022 02:06:16 +0200 > Subject: [PATCH] WIP: Fix symbol macros used in cl-psetf (Bug#56739) This was a month ago, but as far as I can tell, this patch was never pushed. Perhaps Stefan has some comments here; added to the CCs.
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.Stefan Kangas <stefan@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 56739) by debbugs.gnu.org; 3 Aug 2022 00:21:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 02 20:21:11 2022
Received: from localhost ([127.0.0.1]:45530 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oJ28N-00016G-Kq
for submit <at> debbugs.gnu.org; Tue, 02 Aug 2022 20:21:11 -0400
Received: from mout.web.de ([212.227.15.14]:44631)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <michael_heerdegen@HIDDEN>) id 1oJ28H-00015M-Md
for 56739 <at> debbugs.gnu.org; Tue, 02 Aug 2022 20:21:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1659486056;
bh=aezxof+s/wJbi8nzTBQjcU2EOJdvtqSmKxzlq+RsIzc=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
b=E6lNSTWkCbXabCjpreEuZpFv5dqajPrQktZ+6rC0SvGC/57W9gv2X2eXfrjTjnOHx
gZ3hiMa5Kj5nNw/WvJk8KEtmJDxMcZvBFPA4Ktc/raRvUs0ndLKIjycBsJmi8MwM9y
fS70z21a2v2BYebKO6sAlV8uP0m02CT7wbrdPRok=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006
[213.165.67.108]) with ESMTPSA (Nemesis) id 1MGQC9-1oDC2H0xYL-00GfSx; Wed, 03
Aug 2022 02:20:56 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Wing Hei Chan <whmunkchan@HIDDEN>
Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize
symbol macros
In-Reply-To: <8735eeyz7e.fsf@HIDDEN> (Michael Heerdegen's message of "Wed, 03
Aug 2022 01:59:01 +0200")
References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN>
<8735eeyz7e.fsf@HIDDEN>
Date: Wed, 03 Aug 2022 02:20:55 +0200
Message-ID: <87y1w6xjmg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:NMcqkymw3rA7QjOE3ny6oWJtmgA+iMwadkxh/pbeyl8rsCe4mxA
LBMTAKFlqbnFr64t22p6/stfXafuk1yMpXS+esI+QodeeuVJvGMRVLS74asWgFM8ZEhZ4ib
TAn4Zm8YkGT+RLtgj03F7pPw7qzXOq/Ivw0A9hMxX2v1kTdbmIKmvkMP8v5/TpNWiPq51Dn
9ty9VmXNVb5mb8UQdxXFg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:4jVbzibFpiE=:jCQH7qVtC8bHM+0vYIbNWJ
2Inhfe7boNca6MDsdHRgaGwOQPgk2Jq0FFMKl1MOdw8Iv6SRU/wxrwjXaHm3wpDbKtK7wtMUv
/aBcVguCbxNn/xeOlR3nGQR36lQCBVl8dmUmzpNMLw/zq5XwUJELlLiBuDFEu3EMptRLx7R3v
CK8hv/92Knxocyyl6KcSPHP2eiz4BO0NZb2IIY+a/QMDKAi942C2gOC6rZxk3rIKSm3wzcQVC
7ivQjRfkCpUh0suSGL2bprWCJpOQUm6lISNq1JnN/u9dCPiHukPP3U0gCEuzpHi537h7PVUO1
7rcBQy4Bhzy0Yxu7HIT5KSPqK7Bh6b0MeTos1MIX/Bpm6b0W2+fZy6IEeOdpQh4wv5THDTl4n
M9qgZlHvZjoSd2f9V/cTa6SabUIz9LI5vHIJSN7irKLdQfbP8Ip8KDEr5tKMSo90ZDPLY0+57
xwvGVphEz//KF8EfPuqkrWpikHmva8ndX5TY9/RGE3Ych/Ubxhkr1xFg5jzbsUEARIFjbvaIo
Z8mrMJml+sC6TBaqcdIXJGcaZOpL6pt4NmFkMwL6KTG9AXy230pfd6Y6yP/HhnsHVmjplwKWi
oeRTLI+/vch7AXToR6Mfyio08Tkc+DnJxKuz09a5GwAWrrctAcEf/KG3UJrsNZAyNavoSPcme
OBhuNfWyxPPvixfbfqL2CNX276APU0UosZVmET7GsZjpD2q45U3Ury4af/uY68187LguTL8Tl
x4ELHiKS2Z2bVlYwzhmPUG+AJFSH8qp0ZNO3ORkeUOk93B+g1MK6VpkB3Mt9/RPyreyhe9tE5
jwici+3h/fVgpRUI+2aau9NhATgb1f55MGnQXVc1vGUMVnVfx0AV90SKNnfxp9BHAw1qBmh/O
tTlvrTS8xeirOvQqWQTn5b5jsteCVPaQF38rV0MsXYkWDclZ2GeovmOzBT+T/qCp4La4JVPAZ
cbkSB9CGRFIxqlDcA8O7X4hc7SEydvHS3GSqGizN28aE+gAfljA/CGoHGvsUpqWzBfOBWsrWP
oh5r0ktvjK7+OTXUP0a/R6F0O1TvK4dxbXPL1nEx+5MYycgyeeBuCvrBPTdx7+9KZXddnT5OX
BnV3/AlK4Yv3HPTy7ZaetlDXZEFgqNTGEfcfR4+oZPFShFOFXUw4FF/Nw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 56739
Cc: 56739 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
Hello,
I think we can fix this (both cases mentioned) similarly as in cl-letf:
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
filename=0001-WIP-Fix-symbol-macros-used-in-cl-psetf-Bug-56739.patch
Content-Transfer-Encoding: quoted-printable
=46rom 29ea21a751ab6e71b2fb34c781131e31fc7b950d Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Date: Wed, 3 Aug 2022 02:06:16 +0200
Subject: [PATCH] WIP: Fix symbol macros used in cl-psetf (Bug#56739)
=2D--
lisp/emacs-lisp/cl-macs.el | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 78d19db479..f3051752ba 100644
=2D-- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -2653,12 +2653,17 @@ cl-psetf
\(fn PLACE VAL PLACE VAL ...)"
(declare (debug setf))
- (let ((p args) (simple t) (vars nil))
+ (let ((p args) (simple t) (vars nil)
+ (smacros (alist-get :cl-symbol-macros macroexpand-all-environment=
)))
(while p
- (if (or (not (symbolp (car p))) (cl--expr-depends-p (nth 1 p) vars)=
)
- (setq simple nil))
- (if (memq (car p) vars)
- (error "Destination duplicated in psetf: %s" (car p)))
+ (when (or (not (symbolp (car p)))
+ (assq (car p) smacros)
+ (and (symbolp (nth 1 p))
+ (assq (nth 1 p) smacros))
+ (cl--expr-depends-p (nth 1 p) vars))
+ (setq simple nil))
+ (when (memq (car p) vars)
+ (error "Destination duplicated in psetf: %s" (car p)))
(push (pop p) vars)
(or p (error "Odd number of arguments to cl-psetf"))
(pop p))
=2D-
2.30.2
--=-=-=
Content-Type: text/plain
But I'm not a fan of symbol macros any more: the concept sounds nice
first, but actually you only save one pair of parens when coding while
they introduce a special case that one always has too keep in mind for
macro expansions: any symbol might not just be a symbol.
I guess this is not the only place where they are not handled correctly.
Michael.
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.
Received: (at 56739) by debbugs.gnu.org; 2 Aug 2022 23:59:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 02 19:59:16 2022
Received: from localhost ([127.0.0.1]:45521 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oJ1nA-0000YK-9O
for submit <at> debbugs.gnu.org; Tue, 02 Aug 2022 19:59:16 -0400
Received: from mout.web.de ([212.227.17.12]:46819)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <michael_heerdegen@HIDDEN>) id 1oJ1n9-0000Y8-4Q
for 56739 <at> debbugs.gnu.org; Tue, 02 Aug 2022 19:59:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1659484744;
bh=YlROXOIDc7l1vihH9i+Qk6WTn3/hz7hTr+vUlIZhXVY=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
b=GOTyxdr0YrqtwFnErxd5pv2dEFtuuGHEd/0gfhVl+JaYPUd3tP3utGquAGCh5TDYB
75REzFEtHQM6CsGksM5hDhDVKHWeiC7l/y5NYMQtevirl2+PTVvEgof1z/xwi5KO69
zxyBXyNwAnES+eCksqtKeTVVDLI0oF2FUXTNExzw=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb105
[213.165.67.124]) with ESMTPSA (Nemesis) id 1MREzO-1o6z5Y1TrI-00NQRb; Wed, 03
Aug 2022 01:59:04 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Wing Hei Chan <whmunkchan@HIDDEN>
Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize
symbol macros
In-Reply-To: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN>
(Wing Hei Chan's message of "Sun, 24 Jul 2022 20:12:10 +0800")
References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN>
Date: Wed, 03 Aug 2022 01:59:01 +0200
Message-ID: <8735eeyz7e.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:SiTKVgkohEpva9SppQG7GtdtVj00RGqQNoCUJ+MwX+se5CF2C5O
2OC6pgnZ+9klEVW4l8pgvxaz9z+oeZnSQvEFSM+D7OZy4wz6H04dQIYZ+TMmA6mgjBTo/E5
2b1MI+CxG2jV1lYuwutaFMssqbFYK59n3RG3+NRhD2DHEezalgp8TVqIP9M5mK0jBsY15es
2hGz6GmsMDYtBI0vGrxog==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:uX7CMl+2UoY=:mOxudEprPkapxESWxqpSlf
IpQ2h8X4g1R+2wncCapTmTZwPWDYNBfrYVjLsD+Qz7pcH1Qt8+2IX5VKFU/R7L1zEVUoXPR02
yyjYjQxH/orrh1F6WnP0+68qLejMa1z8PU4btat0d6dCcTtGlbVoYcDqQZUln33NrRqMyr/rK
xB8NCqlviFjOYJfNFOeci1RNvDxfXtVH6hXbe6V8xTkjQpzNXtSSl8FpFaxLD/67R88Grd6f6
V+sntLF51QYUX716OxHzCL37LVCpJOFELR/6WpAM4HpydWtvjYxHXGNrEngVoPfgggFUdm38C
2sIxegXMnDLK+1fQTzMoTTl//EnvQLGqq9uAmD2PuxP6kQWKtsrbI0cbWzcLXDqHS3yytgVj3
C4uYNiwBR3DGA4IS0v8hD9TJh/ExRS55Ax5q1p8OJuwAO44dyYlZX29In9K9SL7S7N+sg7G/s
v5t2Vmrr7j3/iVwAGNb6RJaUVsMbdpko8y8vyTewDCH6LDc7EwplflAYhqPh4HSbm8oF+3VmG
lu6ERaKGhmGa1hVG/C4/+Qu68YSXBTtw6k/zqNeJ3oK8Bdthra4imy4AEOt5MBi6rh4Td7aL0
0VpyadivDG1h+qchIYX9FCxKM7s2duIyGXPQ6gu6uye/8K3XxdMow9pmryqVgl7kzKZuQnv5q
eApZuDjOIESjfRLZ0RzPLMNSH6Jqw8zuoIZHJqYjJdSl4+wZl3iI6Gi8Sq7CMPI4xaHL1msf4
W4YxQrI5Z9Ciyf5Ketk2szbIEOPiRafNZF8FQyqX7zDjB0RlHElkzfOcKEB63v+H0Dzhdmsup
sC1sz7rk4zVTEYQzlz1XWEnvkE+e72Z9d8he5malNf9r1kugbbvO4Y499LcRKYUUhHfp4BHen
+omt6ybjxHg3W8Tuiz0SVHdmdipziPI3sQn9045pcRGOX5at5CHE+ndDE4Cp2c6Ak8F/LT3jY
f7yrtHbw0PZOg24DACRI3ISUC6rQqA/KM+oz/DAQoSMR/yDQAxLr2e8oKYxr2Lnx86+mhAfCn
JCdIhxz1t8oN3gcE/g64knNjoxKsnt1y0zddcbEBtXbzukMoy1LrG0O6CpmHTAtiAsRvjHueZ
fklEztTELIuFdTtK+PNkkR37IyPwnqxf6+Cn0vom9eZvq9XZ+SDQFUrCQ==
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 56739
Cc: 56739 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Wing Hei Chan <whmunkchan@HIDDEN> writes:
> The following form produces (2 2) due to the failure of detecting
> dependencies involving symbol macros.
>
> (cl-symbol-macrolet ((c a))
> (let ((a 1) (b 2))
> (cl-psetq a b
> b c)
> (list a b)))
There is a second case that also fails: a symbol macro at a PLACE
position:
(cl-symbol-macrolet ((c a))
(let ((a 1))
(cl-psetf c 2
b a)
(list a b)))
==> (2 2) ;should be (2 1)
Michael.
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.Received: (at 56739) by debbugs.gnu.org; 2 Aug 2022 02:41:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 01 22:41:52 2022 Received: from localhost ([127.0.0.1]:41951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oIhqx-00086E-Po for submit <at> debbugs.gnu.org; Mon, 01 Aug 2022 22:41:52 -0400 Received: from mout.web.de ([212.227.17.12]:40607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1oIhqv-00085w-B8 for 56739 <at> debbugs.gnu.org; Mon, 01 Aug 2022 22:41:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1659408099; bh=NIFq+sxub0Dr7ojUUOtzlBnvnVsyOHPOvEXgVGCNeBo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=B304zySDiWXuUODW5njEgZ9nkU/TGygQE0wMACQaoHfMggoWR+Yjq9h9iF9N7ncRo +dKBvceLfbzPzxKcsS89mHAlIeuUHqv+SHFB4MCkUXkPvFXtrZEhm3wmWPn3/wdsnc PEeRvKxk4s0Con38qxSeGxRNC0ov7kqWp4kgX4ME= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MJWoU-1nyy2l0ihk-00K7dq; Tue, 02 Aug 2022 04:41:39 +0200 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Wing Hei Chan <whmunkchan@HIDDEN> Subject: Re: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros In-Reply-To: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN> (Wing Hei Chan's message of "Sun, 24 Jul 2022 20:12:10 +0800") References: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN> Date: Tue, 02 Aug 2022 04:41:38 +0200 Message-ID: <87zggntli5.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:HJhvizpdkYXm6bMWvqUhmiWh5zxWaYL5VYKngzT4nclLsgIKt/W EOLeF+H6Q147pLHHJcHHJTaSIiBrMb0+6fGjzjeqYInxeMDjROZbnN82iEetXM3xRRiuCyT /xFXAip7WcNWvvwSx5rGJ70FpTRnJwivaZUppIc9vPdtp9VtD9pDkfc3Vt62kRb8AfrAgMx nCws5MPFA93QCgyPDPWEg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:OVUACjW9MjA=:ICc1zWxh9CfAud733Ss+sw M+3xiaTsvj5O1UyuvNku5CBVCi+jcWC/UNQVZ30y94fU9bqH68+Re5dcW2KI2zPBLkiqTvfAL OMbUDWezqeX2vJX2XdV/vnXrzTaCH8gGGweKsJh0EeEM/NLB5CCCdeQbRzgKeD/+dpZz4DwzA sWTxO7K0XnKpjhtkf+Bimq0auhv5tTDwYUjwvY0kwbfWW8/mPsa/zOLJYpc5poWShF769Eo0D crDXfxFskIFVH9DDIDlwLn9UAdkob3VFGgx9KBmMzp6Pngehhh0RCOhYkLI78FserqiBpooOb +GzhfncqHWLZpGQfR3Ea0KMLrds32pyXax3M3pgojsTy0rG/xdA//1KpMuCVyboONJpnn0uph gQYlHL6oNg5xvJlJcRUDlDkGEnrz70VkkzOYyS7bgzXFqQe9dyZX7SjiWVtgvszhrjQyF+39A ZJxppGK3A1lvgFghK+BduuaWu1x14Lurxw89jZSz7R3b7DHKJDNDm+T0XmBHp0POdBWn+FZ6l x3g1rFBA3BATFODsV3MX1u1Czk2XGb/FwcyT5yUL417xVQjYLBsYFjydp++IpURDz7B3VpIOA 5OjyrzfABNKuSBtkOLqPWCY4MdKdZFNL2aPKt8efR7fjL27iw5n50AMZw2ppGlwUJBxvy8QQI 0wxEU5TM6BivDQXyhrsn/k8lFgOvu0yiTrZPDZPkXLsYN3SbbyP+nWCXTv//GwelK69D1q2vp 7eguETnUkq6WjN23Rwl+lPYb+d2BZX6Ug3ohrlhYgK7sIy3eL4qpIy6OpNND9J4pyrKr71Ei/ 0pS7sFKdTNnk2Kels1cLa8OPcxa5OGtsGU4mDXfDl4WDuQZX+IRaxTwZSu67gYLAM9Wd2UdU5 AVomKojhbM8pscmGUPcpHNRVRhW0LX4Wxt0BwEEAITihQXORbtZ4r9BMJiXF7ZVM6L2v4Xude +MpKpu5HUIKA/I+vFNsr4+EWigclaLpbJBE6QEnmT4CPmGA5tB6r/mnlB6dEvt54llQHnT9a/ K8NCeAmzOrFUzwV3+YpVOCtljrk++u96Icak8gnKk88Iy2uPLe9oDTozyLXa5zslKXCdIizRf LHmrThfAvnpTTxFHxaOhPo/EnWNjzUTP3qV1F95lYXSmVdvJx41bLLPkA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56739 Cc: 56739 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Wing Hei Chan <whmunkchan@HIDDEN> writes: > The following form produces (2 2) due to the failure of detecting > dependencies involving symbol macros. > > (cl-symbol-macrolet ((c a)) > (let ((a 1) (b 2)) > (cl-psetq a b > b c) > (list a b))) Dunno how a good fix would look like - but it is easy to follow why this error happens: `cl-psetf' analyses the expressions (each second argument) for whether they are "simple" (independent of the variables): (if (or (not (symbolp (car p))) (cl--expr-depends-p (nth 1 p) vars)) (setq simple nil)) but the symbol macro is not yet expanded when this is done, and the expression `c` passes the test - which is wrong. Maybe that test should just check for symbol macros in addition? Michael.
bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 24 Jul 2022 12:33:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 24 08:33:47 2022
Received: from localhost ([127.0.0.1]:47047 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oFanr-0003Vl-GS
for submit <at> debbugs.gnu.org; Sun, 24 Jul 2022 08:33:47 -0400
Received: from lists.gnu.org ([209.51.188.17]:39520)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <whmunkchan@HIDDEN>) id 1oFaYJ-00031k-Qv
for submit <at> debbugs.gnu.org; Sun, 24 Jul 2022 08:17:44 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55794)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <whmunkchan@HIDDEN>)
id 1oFaYJ-0003fs-Jq
for bug-gnu-emacs@HIDDEN; Sun, 24 Jul 2022 08:17:43 -0400
Received: from mail-os0jpn01olkn20824.outbound.protection.outlook.com
([2a01:111:f403:700c::824]:30486
helo=JPN01-OS0-obe.outbound.protection.outlook.com)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <whmunkchan@HIDDEN>)
id 1oFaYG-0007LX-Ez
for bug-gnu-emacs@HIDDEN; Sun, 24 Jul 2022 08:17:42 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Tt5Li4+QPSjIK4q8Pd/a1ESrd/RVownNJlBTR/LlRwYQUKZqoNYAnc98mvzmVDuNi9/3pva59J4UAu2Pls2hm0y1zSIAVPeqfEVCeAtkwRzjrrk/oQSs8CqztGJcgL07RbmwbsgKtY+p+PJYeYk7NQDged3eIQ20DaoNVBkUkb68lMQIjaSncOjVQBBhw+pw0Iz1JJx1ASglwBj9XIvKlx+tPOUonSmogVMZz7T11GjDY+apCTFG3slsdlRVGoDgvQubvL/rMXTi5w4EX6VFFcIoJ/uKroZJxQk361Rl/ESK5lwxQVJiBAFg2BWFd0GJNsMgZwWS5zAoA0asyaEAhA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=iFHWnTNRMW/jQOLFBl6S/+ILzO12Ty6iGfFwdBdRis4=;
b=clgqN+6RZ8zsas0XL4pPu4w9zVkscNKtUTOKZSNklcEA4ATbYvMjEfgQ3ldKyfs0lIOkTRPqXwVMBNr8RKexJBnGVP6WUTkwFE1BwTpBI6cY3W7P8lgZO6qKQQB2n/9PTX+NltL4ieWSyNWvpJdzUCUiE74e35fEzHbTF4BGlOUg2LhxX5Hww3YKtHrcl7LHIAdFm92H9c0isbbFXusPC544qx3ppviFggpcnQPINUBPhDxdDkY0x4Mpvyycss1c7phOaiKZ2grt2o+kHN6FiptN3IpGv2xbgGGtRI7jobyXVqxjVWWIJuFMe3jMAWqNJvUMy57TN+Yel9UH6dkruA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=iFHWnTNRMW/jQOLFBl6S/+ILzO12Ty6iGfFwdBdRis4=;
b=L+YL1nEl2x+rfHmmlQ2f/LgZ0qQiXzTVxqraNn7ZYS/usojySuVLUyeeFN8ifbet9csElFVAV8EUbfmnkgTKpCj4F2hSV62fz/Wojq0NTsRErkWRuK6x3/U2k8WS7pSp1AhQTt8BiEnw3Ecfpxv/VQLedP0xnZBiWVp0U3SoMMa9NFEacnI36scPJKc/m1lXDeRpBAaMbXSRaknsMzv1mwECcxXvTctuD64c2XXCb4Q2llHjWtClv5j5E1AjUtYIvApztiZrCHJ3fnu4i0Oc8lSuPH6GCoQ4pM+gdFEzchd353gUyUEG3BdLZ5nOba5uG7S8Rz+E4VMS8nIw2zxobw==
Received: from OSZP286MB1260.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:138::9)
by OS0P286MB0532.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:cd::14) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Sun, 24 Jul
2022 12:12:30 +0000
Received: from OSZP286MB1260.JPNP286.PROD.OUTLOOK.COM
([fe80::15ce:437f:f4e5:f9ed]) by OSZP286MB1260.JPNP286.PROD.OUTLOOK.COM
([fe80::15ce:437f:f4e5:f9ed%5]) with mapi id 15.20.5458.023; Sun, 24 Jul 2022
12:12:30 +0000
Message-ID: <OSZP286MB1260387EB0097C4D07840B54DA929@HIDDEN>
Date: Sun, 24 Jul 2022 20:12:10 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
Thunderbird/91.11.0
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros
Content-Language: en-US
From: Wing Hei Chan <whmunkchan@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-TMN: [IKSKLRaQfU2OqH9nFbesBsEzZdLJCogJ]
X-ClientProxiedBy: PS2PR01CA0062.apcprd01.prod.exchangelabs.com
(2603:1096:300:57::26) To OSZP286MB1260.JPNP286.PROD.OUTLOOK.COM
(2603:1096:604:138::9)
X-Microsoft-Original-Message-ID: <c886faad-c1a9-e6f1-2880-11a8e18dc40b@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e4d3e684-3cce-48e2-2236-08da6d6dc7f1
X-MS-TrafficTypeDiagnostic: OS0P286MB0532:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: D8C544prX4mmAtoVUnbel7Zjrt0cWWl/soKwJxBHJCXOph36phHrDNdJCyHR/1OxLnlhrGJ6jwEQswKcUHbaSfB/U0AG1/ljFUEQEDZEP+lJAES/p78cW5dwb70EiqSakeCgvAtFcm6I5Ku3tRhGHS0BbfzloMrDXpOTmCsFGSw1rby+9HiFt3Lfw2TBpqfJdDBlRpwoNvRPjuV64uKUIwRAuajlqEJekLutDugdoGKiXk189llthZLg1D94cJA23ccXKUhipmD4lXtGO11UGTOcMQMuAdELQcQHSrzsnTXASeaIcy0vczawNDmHaVHX+aOXSrvr+8FOeg5bEMVrAwMY4gcFouQ5sOqV1BqWM8dfdkc1ngyW72FARM2PaLeyOZM4vFNdkpkaEw4xCpfZ/HIO6T7rWGo0pgLwvfhAdLoXs0h7M3vEofAVVKMdgj2mfAedWfdInwFcQCVRWxYIC4za206pkpb/bcDW1DpSsZR5Kw5KJ6hRJFBZeeo4n0OX5oykUWbFfEwgvZgD5goUhIN5l5PxZx7vQLBXIiMC86OmcHlSoKPocDzX8oaKkJ/OMysd+eXoRHndtyohSIJ31f+6jE/Chu3ZlX/GwhhVW36igSLqAPd3njqHDB9w7nmhM04xTgjUibIJZlN29U2dmg==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHg0TXZUNkpaWXpZa1VySldIcjB1S25YR2g0NXNhdjFzQmpKeE9weHYvS2tv?=
=?utf-8?B?UE5wamZlRmUxa3NBZEpEZjBJYWxGLzNYWDhhRmxUcXdSelJPU0wrSEtIUVk2?=
=?utf-8?B?ckxlMHlTeGJFbzhXa2dxdEM4aStJN1NRRUNNc2JnT2FHODQrcm8yT01ud3Fl?=
=?utf-8?B?a0M3T3dzbHZicldhSlZsVzVpNzF6VTVhVjF0RmR6Zk5FM2dOajdKSTltWm9l?=
=?utf-8?B?SVNZMWxpMFZCaTNaZDc1WWwveDFmYWlYWmJnakdLVVhtU2U4YUFzZzRyOVg1?=
=?utf-8?B?V1VNckoyYmVXclJ2QzlxQXVKZ3FkSDhwYUw1YjJycjI4Y3lVZXg3WnpqaHBK?=
=?utf-8?B?STNEeEpFNVRmUnlxMEJudmczVHdYRzJQcHd4eUQ5aTBOQ3YvUkFJZm0xSWh2?=
=?utf-8?B?NEdTNEhnRnlYbFlUQUY2SnlleXlGRTEzVXVTakNYd2VRM0dmWEgyRERrRG5s?=
=?utf-8?B?NTQ1RUErbEthYXBxRXhzdzhJMk0xWFd5NmJ3YTc3VUZGQ3RtUTh5UzBDWnBI?=
=?utf-8?B?RkpWTSs1MkFRTERVRE16UzVwVWRpcjgxQ3libXFFNGp4TGJua1ZBMjZSTWN1?=
=?utf-8?B?T20zekV0VlRnQjI1eFpZV2xVNW1KT3Vmb05NaUVyVVFhY2UwOVNoQkdjL2F0?=
=?utf-8?B?NHd1Z3dMSXRrYnJlNmhpTFQ4dTFhdStma1Bkd2MwZHlUc2cwYVQrQlN3d25W?=
=?utf-8?B?dTBFcm9tY1Y2cVVqYzBFbnZSdXgzdGxiUnJvV1lwOUdxQmxWYkNJUlRVaEpj?=
=?utf-8?B?czZMdWxHYmM0QU1qdVR4blY1RHdHUUFBdDlkRzVFSmthbU11b0ZpYUZwTEFB?=
=?utf-8?B?bmZqZWpsV3ZsZFZ6NUdwcHc3MjdZMVhFUHhVT01xbHU2UjNmbU1zTitSVUNK?=
=?utf-8?B?cXpDQzU4bkFhWHNHUHVOaXNHc1BJRWlodjk4VDg2VXAyNWpxdERwK1YrYzRy?=
=?utf-8?B?QUM2aytCMVFUWDlMclR3TWNQbTlYdVQyYytvd0tCS0ZvQUhLd0hHR2plODdR?=
=?utf-8?B?K3ZCbHlSTzZwT3pDQUE4REtwVVpyRUpoeHpnZGdxSWhHcXdwdlE0YXdJWWFC?=
=?utf-8?B?V2IyZmY4MlRiZUFqaVEzdk45eFVCZWhWbzUrY3FnbFhXMStPZWRBRW0wR3RK?=
=?utf-8?B?VXVFVGx3QkRWVkxBQk40UThEYW9vVnJmN2MvRERzcmp5bWlVMnZUQzlVYkpt?=
=?utf-8?B?ejE5US9jbHVHZ0lKcTVDVVpaS28rYU41VStsMVFSV1JwdTNmV3hLSW5kWEg4?=
=?utf-8?B?TkdteFdaUTNXemNNbWFiTWRuV3RtVUxNUGdGR0V5SlZGZjJSOUJvNHJrUTFE?=
=?utf-8?B?VnA2WEVaTnBSL011N2V2TU4raHY0Y29IbStPQnpMeHl6cks5SER6YXlLNlg2?=
=?utf-8?B?YlhPeXNXUnVRNUVxN3k4d0RrQnFPMVV4V0lnTXIyQk4vVXRaSm9vOEZsNjd6?=
=?utf-8?B?RFIrRlFBaFgwWFdhRHhQQ1krMjg0V2RlbGM3SGdUdlNZMXZUazN0V0Q2d2s1?=
=?utf-8?B?dk5TME9WM3J0U3E3eTJXZlNUdkxaTm1ERTB6dzlWSGE3aitQaWhhUm1uVVlM?=
=?utf-8?B?bW9XZERhNkxvQ1hESWlLSEVITEg5WVR6SnNLZFVJamdCR1Y0WUw4OWNoelE3?=
=?utf-8?B?TVRwRFl0UWZKUUNJcyttbFJ2TWhPTDVRMENUdHpZeDFDVWNIVG5RNGdrV3Jz?=
=?utf-8?B?ZWNSWnZOUjl2MHlmT1dDOHdJQTU0d2hDaUswYnZmQTd6d2FNOWxHNmNRPT0=?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4d3e684-3cce-48e2-2236-08da6d6dc7f1
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB1260.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2022 12:12:30.2177 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS0P286MB0532
Received-SPF: pass client-ip=2a01:111:f403:700c::824;
envelope-from=whmunkchan@HIDDEN;
helo=JPN01-OS0-obe.outbound.protection.outlook.com
X-Spam_score_int: 2
X-Spam_score: 0.2
X-Spam_bar: /
X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_MUA_MOZILLA=2.309,
FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.8 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: The following form produces (2 2) due to the failure of
detecting
dependencies involving symbol macros. (cl-symbol-macrolet ((c a)) (let ((a
1) (b 2)) (cl-psetq a b b c) (list a b))) It should have behaved the same
as the following form without symbol macros, that is, producing (2 1).
Content analysis details: (1.8 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,
medium trust [209.51.188.17 listed in list.dnswl.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (whmunkchan[at]outlook.com)
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.6 FORGED_MUA_MOZILLA Forged mail pretending to be from Mozilla
1.5 SPOOFED_FREEMAIL No description available.
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sun, 24 Jul 2022 08:33:39 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)
The following form produces (2 2) due to the failure of detecting
dependencies involving symbol macros.
(cl-symbol-macrolet ((c a))
(let ((a 1) (b 2))
(cl-psetq a b
b c)
(list a b)))
It should have behaved the same as the following form without symbol
macros, that is, producing (2 1).
(let ((a 1) (b 2))
(cl-psetq a b
b a)
(list a b))
Wing Hei Chan <whmunkchan@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#56739; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.