GNU bug report logs - #56859
[PATCH] gnu: xdg-desktop-portal-wlr: Change elogind to basu for sd-bus.

Previous Next

To reply to this bug, email your comments to 56859 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: xdg-desktop-portal-wlr: Change elogind to basu for
 sd-bus.
Date: Sun, 31 Jul 2022 18:50:38 +0300

* gnu/packages/freedesktop.scm (xdg-desktop-portal-wlr):
[inputs]: Change elogind to basu.
[arguments]: Specify "-Dsd-bus-provider=basu" explicitly.
---
 gnu/packages/freedesktop.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index cde7156383..1a30091da0 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -2408,7 +2408,7 @@ (define-public xdg-desktop-portal-wlr
     (arguments
      `(#:configure-flags
        '("-Dsystemd=disabled"
-         "-Dsd-bus-provider=libelogind")
+         "-Dsd-bus-provider=basu")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'hardcode-binaries
@@ -2426,8 +2426,8 @@ (define-public xdg-desktop-portal-wlr
                   (string-append "execvp(\"" sh)))))))))
     (native-inputs
      (list cmake pkg-config))
-    (inputs (list elogind
-                  bash-minimal
+    (inputs (list bash-minimal
+                  basu
                   grim
                   iniparser
                   libinih
-- 
2.37.1

Message #8 received at 56859 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: muradm <mail <at> muradm.net>, 56859 <at> debbugs.gnu.org
Subject: Re: [bug#56859] [PATCH] gnu: xdg-desktop-portal-wlr: Change elogind
 to basu for sd-bus.
Date: Sun, 31 Jul 2022 19:38:10 +0200

[Message part 1 (text/plain, inline)]

On 31-07-2022 17:50, muradm wrote:
> * gnu/packages/freedesktop.scm (xdg-desktop-portal-wlr):
> [inputs]: Change elogind to basu.
> [arguments]: Specify "-Dsd-bus-provider=basu" explicitly.

What's the reason for the switch?

Greetings,
Maxime

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 56859 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Maxime Devos" <maximedevos <at> telenet.be>, "muradm" <mail <at> muradm.net>,
 <56859 <at> debbugs.gnu.org>
Subject: Re: [bug#56859] [PATCH] gnu: xdg-desktop-portal-wlr: Change elogind
 to basu for sd-bus.
Date: Sun, 31 Jul 2022 22:45:16 +0100

On Sun Jul 31, 2022 at 6:38 PM BST, Maxime Devos wrote:
> What's the reason for the switch?
Fewer dependencies (we include only the sd-bus library without the whole
of elogind), and it means eventually desktop users won't ever need elogind
to even exist in their store. (I think this is the reason. I'm not certain,
and there may be something more important, like some incompatibility with
seatd.)

    -- (

Message #14 received at 56859 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "(" <paren <at> disroot.org>, muradm <mail <at> muradm.net>, 56859 <at> debbugs.gnu.org
Subject: Re: [bug#56859] [PATCH] gnu: xdg-desktop-portal-wlr: Change elogind
 to basu for sd-bus.
Date: Mon, 1 Aug 2022 01:13:18 +0200

[Message part 1 (text/plain, inline)]

On 31-07-2022 23:45, ( wrote:
> On Sun Jul 31, 2022 at 6:38 PM BST, Maxime Devos wrote:
>> What's the reason for the switch?
> Fewer dependencies (we include only the sd-bus library without the whole
> of elogind), and it means eventually desktop users won't ever need elogind
> to even exist in their store. (I think this is the reason. I'm not certain,
> and there may be something more important, like some incompatibility with
> seatd.)
>
>      -- (

That's interesting but sounds very non-specific to 
xdg-desktop-portal-wlr; I think this would be better to propose on 
guix-devel@ to switch elogind->basu for _all_ dependents, not only 
xdg-desktop-portal-wlr -- the latter would increate the closure, not 
reduce it, because other installed packages would still use elogind.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #17 received at 56859 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "(" <paren <at> disroot.org>, muradm <mail <at> muradm.net>, 56859 <at> debbugs.gnu.org
Subject: Re: [bug#56859] [PATCH] gnu: xdg-desktop-portal-wlr: Change elogind
 to basu for sd-bus.
Date: Mon, 1 Aug 2022 01:32:44 +0200

[Message part 1 (text/plain, inline)]

On 01-08-2022 01:13, Maxime Devos wrote:
>
> On 31-07-2022 23:45, ( wrote:
>> On Sun Jul 31, 2022 at 6:38 PM BST, Maxime Devos wrote:
>>> What's the reason for the switch?
>> Fewer dependencies (we include only the sd-bus library without the whole
>> of elogind), and it means eventually desktop users won't ever need 
>> elogind
>> to even exist in their store. (I think this is the reason. I'm not 
>> certain,
>> and there may be something more important, like some incompatibility 
>> with
>> seatd.)
>>
>>      -- (
>
> That's interesting but sounds very non-specific to 
> xdg-desktop-portal-wlr; I think this would be better to propose on 
> guix-devel@ to switch elogind->basu for _all_ dependents, not only 
> xdg-desktop-portal-wlr -- the latter would increate the closure, not 
> reduce it, because other installed packages would still use elogind.

Additionally, the reason should have been mentioned in the commit message.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #20 received at 56859 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "\(" <paren <at> disroot.org>, 56859 <at> debbugs.gnu.org
Subject: Re: [bug#56859] [PATCH] gnu: xdg-desktop-portal-wlr: Change elogind
 to basu for sd-bus.
Date: Mon, 01 Aug 2022 07:55:31 +0300

[Message part 1 (text/plain, inline)]

Hi,

Regarding switching, I don't think it is very straight forward
to switch elogind with basu. Issue is that elogind "also" includes
sd-bus. Dependents may require either sd-bus and/or other parts
of elogind. Those who require sd-bus only to interface with bus
could be switched to basu gradually. Most likely this will be
suitable for "minimalist" applications.

I.e. basu is a drop-in replacement for those require sd-bus only,
but not whole elogind.

Thanks in advance,
muradm

Maxime Devos <maximedevos <at> telenet.be> writes:

> [[PGP Signed Part:Undecided]]
>
> On 01-08-2022 01:13, Maxime Devos wrote:
>>
>> On 31-07-2022 23:45, ( wrote:
>>> On Sun Jul 31, 2022 at 6:38 PM BST, Maxime Devos wrote:
>>>> What's the reason for the switch?
>>> Fewer dependencies (we include only the sd-bus library without 
>>> the whole
>>> of elogind), and it means eventually desktop users won't ever 
>>> need
>>> elogind
>>> to even exist in their store. (I think this is the reason. I'm 
>>> not
>>> certain,
>>> and there may be something more important, like some
>>> incompatibility with
>>> seatd.)
>>>
>>>      -- (
>>
>> That's interesting but sounds very non-specific to
>> xdg-desktop-portal-wlr; I think this would be better to propose 
>> on
>> guix-devel@ to switch elogind->basu for _all_ dependents, not 
>> only
>> xdg-desktop-portal-wlr -- the latter would increate the 
>> closure, not
>> reduce it, because other installed packages would still use 
>> elogind.
>
> Additionally, the reason should have been mentioned in the 
> commit message.
>
> Greetings,
> Maxime.
>
> [2. OpenPGP public key --- application/pgp-keys; 
> OpenPGP_0x49E3EE22191725EE.asc]...
>
> [[End of PGP Signed Part]]

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 56859 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: 56859 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: xdg-desktop-portal-wlr: Change elogind to basu for
 sd-bus.
Date: Mon,  1 Aug 2022 08:35:20 +0300

* gnu/packages/freedesktop.scm (xdg-desktop-portal-wlr):
[inputs]: Change elogind to basu.
[arguments]: Specify "-Dsd-bus-provider=basu" explicitly.

xdg-desktop-portal-wlr requires only sd-bus which is now
available via basu as standalone.
---
 gnu/packages/freedesktop.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index cde7156383..1a30091da0 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -2408,7 +2408,7 @@ (define-public xdg-desktop-portal-wlr
     (arguments
      `(#:configure-flags
        '("-Dsystemd=disabled"
-         "-Dsd-bus-provider=libelogind")
+         "-Dsd-bus-provider=basu")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'hardcode-binaries
@@ -2426,8 +2426,8 @@ (define-public xdg-desktop-portal-wlr
                   (string-append "execvp(\"" sh)))))))))
     (native-inputs
      (list cmake pkg-config))
-    (inputs (list elogind
-                  bash-minimal
+    (inputs (list bash-minimal
+                  basu
                   grim
                   iniparser
                   libinih
-- 
2.37.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.