GNU bug report logs - #56881
[PATCH] gnu: Add emacs-consult-yasnippet.

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Tue, 2 Aug 2022 11:41:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56881 in the body.
You can then email your comments to 56881 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#56881; Package guix-patches. (Tue, 02 Aug 2022 11:41:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Graves <ngraves <at> ngraves.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 02 Aug 2022 11:41:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH] gnu: Add emacs-consult-yasnippet.
Date: Tue,  2 Aug 2022 13:39:57 +0200
* gnu/packages/emacs-xyz.scm (emacs-consult-yasnippet): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 702378c206..b2634de8ee 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9154,6 +9154,32 @@ (define-public emacs-consult-eglot
 call.")
    (license license:gpl3+)))
 
+(define-public emacs-consult-yasnippet
+  (let ((commit "ae0450889484f23dc4ec37518852a2c61b89f184")
+        (revision "0"))
+    (package
+      (name "emacs-consult-yasnippet")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/mohkale/consult-yasnippet")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "13hmmsnmh32vafws61sckzzy354rq0nslqpyzhw97iwvn0fpsa35"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-consult emacs-yasnippet))
+      (home-page "https://github.com/mohkale/consult-yasnippet")
+      (synopsis "Consulting-read interface for yasnippet")
+      (description
+"This package implements allows you to expand yasnippet snippets through a\
+completing-read interface. It supports previewing the current snippet\
+expansion and overwriting the marked region with a new snippet completion.\
+")
+      (license license:gpl3+))))
+
 (define-public emacs-marginalia
   (package
     (name "emacs-marginalia")
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#56881; Package guix-patches. (Tue, 02 Aug 2022 11:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 56881 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Nicolas Graves" <ngraves <at> ngraves.fr>, <56881 <at> debbugs.gnu.org>
Subject: Re: [bug#56881] [PATCH] gnu: Add emacs-consult-yasnippet.
Date: Tue, 02 Aug 2022 12:48:09 +0100
On Tue Aug 2, 2022 at 12:39 PM BST, Nicolas Graves via Guix-patches via wrote:
> +      (description
> +"This package implements allows you to expand yasnippet snippets through a\
> +completing-read interface. It supports previewing the current snippet\
> +expansion and overwriting the marked region with a new snippet completion.\
> +")

I think this slightly amended version is better:

> +      (description
> +       "This package allows you to expand @code{emacs-yasnippet} snippets
> +through a completing-read interface. It supports previewing the current
> +snippet expansion and overwriting the marked region with a new snippet
> +completion.")

    -- (




Information forwarded to guix-patches <at> gnu.org:
bug#56881; Package guix-patches. (Tue, 02 Aug 2022 12:01:02 GMT) Full text and rfc822 format available.

Message #11 received at 56881 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 56881 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-consult-yasnippet.
Date: Tue, 02 Aug 2022 13:59:55 +0200
Indeed. Should I sent an updated patch ? 

Thanks! 

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#56881; Package guix-patches. (Tue, 02 Aug 2022 12:09:01 GMT) Full text and rfc822 format available.

Message #14 received at 56881 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Nicolas Graves" <ngraves <at> ngraves.fr>, <56881 <at> debbugs.gnu.org>
Subject: Re: [bug#56881] [PATCH] gnu: Add emacs-consult-yasnippet.
Date: Tue, 02 Aug 2022 13:07:51 +0100
On Tue Aug 2, 2022 at 12:59 PM BST, Nicolas Graves via Guix-patches via wrote:
> Indeed. Should I sent an updated patch ? 

Yeah.

ʃ # after applying my change
ʃ git add -p
ʃ git commit --amend
ʃ git send-email --to=56881 <at> debbugs.gnu.org -v2

    -- (




Information forwarded to guix-patches <at> gnu.org:
bug#56881; Package guix-patches. (Tue, 02 Aug 2022 12:56:01 GMT) Full text and rfc822 format available.

Message #17 received at 56881 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 56881 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH v2] gnu: Add emacs-consult-yasnippet.
Date: Tue,  2 Aug 2022 14:55:02 +0200
* gnu/packages/emacs-xyz.scm (emacs-consult-yasnippet): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 702378c206..408aaf57d2 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9154,6 +9154,32 @@ (define-public emacs-consult-eglot
 call.")
    (license license:gpl3+)))
 
+(define-public emacs-consult-yasnippet
+  (let ((commit "ae0450889484f23dc4ec37518852a2c61b89f184")
+        (revision "0"))
+    (package
+      (name "emacs-consult-yasnippet")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/mohkale/consult-yasnippet")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "13hmmsnmh32vafws61sckzzy354rq0nslqpyzhw97iwvn0fpsa35"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-consult emacs-yasnippet))
+      (home-page "https://github.com/mohkale/consult-yasnippet")
+      (synopsis "Consulting-read interface for yasnippet")
+      (description
+       "This package allows you to expand @code{emacs-yasnippet} snippets
+through a completing-read interface. It supports previewing the current
+snippet expansion and overwriting the marked region with a new snippet
+completion.")
+      (license license:gpl3+))))
+
 (define-public emacs-marginalia
   (package
     (name "emacs-marginalia")
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#56881; Package guix-patches. (Thu, 25 Aug 2022 10:31:02 GMT) Full text and rfc822 format available.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, 56881-done <at> debbugs.gnu.org
Subject: Re: [bug#56881] [PATCH v2] gnu: Add emacs-consult-yasnippet.
Date: Thu, 25 Aug 2022 12:30:36 +0200
Hello,

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-consult-yasnippet): New variable.

Applied with the changes below. Thank you.

> +(define-public emacs-consult-yasnippet
> +  (let ((commit "ae0450889484f23dc4ec37518852a2c61b89f184")
> +        (revision "0"))
> +    (package
> +      (name "emacs-consult-yasnippet")
> +      (version (git-version "0" revision commit))

Base version is 0.2 according to main file.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/mohkale/consult-yasnippet")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "13hmmsnmh32vafws61sckzzy354rq0nslqpyzhw97iwvn0fpsa35"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs (list emacs-consult emacs-yasnippet))
> +      (home-page "https://github.com/mohkale/consult-yasnippet")
> +      (synopsis "Consulting-read interface for yasnippet")
> +      (description
> +       "This package allows you to expand @code{emacs-yasnippet} snippets
> +through a completing-read interface. It supports previewing the
> current

I added two spaces between the two sentences, per Texinfo requirements.

Regards,
-- 
Nicolas Goaziou




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Thu, 25 Aug 2022 10:31:02 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Graves <ngraves <at> ngraves.fr>:
bug acknowledged by developer. (Thu, 25 Aug 2022 10:31:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 22 Sep 2022 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 213 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.