GNU bug report logs - #56884
[PATCH] Make x265 build on ppc64le

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Marcel van der Boom <marcel@HIDDEN>; Keywords: patch; dated Tue, 2 Aug 2022 12:11:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 56884 <at> debbugs.gnu.org:


Received: (at 56884) by debbugs.gnu.org; 10 Aug 2022 02:37:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 09 22:37:28 2022
Received: from localhost ([127.0.0.1]:45621 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oLbb5-0002TS-R1
	for submit <at> debbugs.gnu.org; Tue, 09 Aug 2022 22:37:28 -0400
Received: from mx.kolabnow.com ([212.103.80.155]:35762)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bauermann@HIDDEN>) id 1oLbb0-0002TB-Rg
 for 56884 <at> debbugs.gnu.org; Tue, 09 Aug 2022 22:37:26 -0400
Received: from localhost (unknown [127.0.0.1])
 by mx.kolabnow.com (Postfix) with ESMTP id 96C474293;
 Wed, 10 Aug 2022 04:37:16 +0200 (CEST)
Authentication-Results: ext-mx-out002.mykolab.com (amavisd-new);
 dkim=pass (4096-bit key) reason="pass (just generated, assumed good)"
 header.d=kolabnow.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h=
 content-transfer-encoding:content-type:content-type:mime-version
 :message-id:in-reply-to:date:date:subject:subject:from:from
 :references:received:received:received; s=dkim20160331; t=
 1660099036; x=1661913437; bh=fh05oEFzottzmGKPS+dGidZe0kZVAjgSCbA
 hOaoCMhI=; b=aEtOkdPQ1JC69ZF8raVPYc64vSNMocjNkRS/ArCtTQ6J8mc+rWC
 bMeMHdcG1HLSqSDH05NXVQYbqsuVhiwQxvCBNpQKq9wGQqG1v8Y8slBvLi1oft6S
 EbHK8XIWrqgkDUmZ7mLqI7s8U+GF1jps53YUv2ZXCW2f9tVoo1CbJw1TNbFHiO0I
 wtq3ob1Rjvbk1/xNbcJQtoivqY+pMPHtGbc4B9tqt7fmlPuEGQMA1TcyQGdySVRu
 v30Wj4dB/O5MstQjxjhAupjrbtYEzVjBMDdzhVZpkOOIzdM+M/BMUrqN7omPZedz
 nMN55eIaPWmfHVyPUf730KZThsWOmiaVqRntW3T25bYNQPv1+NhzpJgQxonJqgSo
 Veyl/mrkGJ4Zu6B6CHhy5c8DA46PW09/z3xjmFJeytDRP4LD6aOA/s4WHTi5D1Uu
 vi1MW+HgDMPD1i9h6uf2ionotgs7o6Jl+/dYY+YgrQw8ORT4w1fmPE7Plv0r0scy
 Qf+Y/yRTzP4vrlIk2YHWtihW6+4PzcqC/xIz7KwjcYrVINC3AMegK9qPuL9qREiP
 l0TGWJLti9Aj8d8oKJBbt45gvBCXVKn/iRm/4yW9difiu6FP+hl7E9w1kgL8U5Y7
 nEzvreCQgi5jC/K1MpzvdJvj3W3Ho2hXOLhCcWS4i9lS5cHZwnno5tE4=
X-Virus-Scanned: amavisd-new at mykolab.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5
 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mx.kolabnow.com ([127.0.0.1])
 by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 6WRR7EZkJCin; Wed, 10 Aug 2022 04:37:16 +0200 (CEST)
Received: from int-mx001.mykolab.com (unknown [10.9.13.1])
 by mx.kolabnow.com (Postfix) with ESMTPS id 811CA4291;
 Wed, 10 Aug 2022 04:37:15 +0200 (CEST)
Received: from ext-subm003.mykolab.com (unknown [10.9.6.3])
 by int-mx001.mykolab.com (Postfix) with ESMTPS id 3F304806;
 Wed, 10 Aug 2022 04:37:15 +0200 (CEST)
References: <f7be730ee74999da0f20b44c94c805681a194730.1659442047.git.marcel@HIDDEN>
 <87wnbhder7.fsf@HIDDEN>
From: Thiago Jung Bauermann <bauermann@HIDDEN>
To: Marcel van der Boom <marcel@HIDDEN>
Subject: Re: [bug#56884] [PATCH] Make x265 build on ppc64le
Date: Tue, 09 Aug 2022 23:16:35 -0300
In-reply-to: <87wnbhder7.fsf@HIDDEN>
Message-ID: <87r11oddt9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 56884
Cc: 56884 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Hello Marcel,

Marcel van der Boom <marcel@HIDDEN> writes:

> Anything else needed here?
>
> The patch seems consistent with other packagers I think.

Thank you for the patch! It looks good to me. I only have one
suggestion: IMHO it would be a good idea to have a short comment above
the =E2=80=9C(if (target-ppc64le?) =E2=80=A6)=E2=80=9D line explaining why =
it's needed, such as
=E2=80=9CEnabling AltiVec support causes compilation errors.=E2=80=9D or so=
mething
similar.

Ideally upstream should be notified about this problem so that they are
aware of it, but looking at the x265 website I can't find any bug
tracker.

> Others are also confused on what is needed for the altivec code
> between different POWER processors.

Sorry, I'm not sure what you mean.

PS: Just for the sake of documenting in the issue tracker why x265 isn't
building on ppc64le =E2=80=94 the build fails because of many errors such a=
s:

/tmp/guix-build-x265-3.5.drv-0/x265_3.5/source/common/ppc/pixel_altivec.cpp=
:4199:42: error: no matches converting function =E2=80=98sad16_altivec=E2=
=80=99 to type =E2=80=98x265_12bit::pixelcmp_t=E2=80=99 {aka =E2=80=98int (=
*)(const short unsigned int*, long int, const short unsigned int*, long int=
)=E2=80=99}
 4199 |         p.pu[LUMA_ ## W ## x ## H].sad =3D sad16_altivec<W, H>; \
      |                                          ^~~~~~~~~~~~~~~~~~~

--=20
Thanks
Thiago




Information forwarded to guix-patches@HIDDEN:
bug#56884; Package guix-patches. Full text available.

Message received at 56884 <at> debbugs.gnu.org:


Received: (at 56884) by debbugs.gnu.org; 9 Aug 2022 08:04:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 09 04:04:40 2022
Received: from localhost ([127.0.0.1]:42450 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oLKEB-0000Yv-Pu
	for submit <at> debbugs.gnu.org; Tue, 09 Aug 2022 04:04:39 -0400
Received: from read.hsdev.com ([209.250.245.235]:55564)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <marcel@HIDDEN>) id 1oLKE7-0000Yc-Mm
 for 56884 <at> debbugs.gnu.org; Tue, 09 Aug 2022 04:04:38 -0400
Received: from hsdev.com (hawking.hsdev.com [213.125.12.142])
 by read.hsdev.com (Postfix) with ESMTPA id 4F8EE20015
 for <56884 <at> debbugs.gnu.org>; Tue,  9 Aug 2022 10:04:28 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=van-der-boom.nl;
 s=202103; t=1660032268;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type;
 bh=yHhDhLRB5stUonADpJvemTLMvD0A67cQ9PhEM74ShN0=;
 b=zWNkEOijQndkITFMG++7uTnOLTMswCRTN3Zu4VSrvkA6upfcHC4kQ/vfNP2qP16zAS3pfc
 TvbAUSgI39b3AYHMtu5Pv2mwuR85qsv5bSeaKSWwiFHL0aCr5ycta0WG9Yg9aRwamM+N12
 fXlOsn1avTtMxYv6c66DUDMKGqE7RH8=
Received: from changeme.hsdev.com (localhost [127.0.0.1])
 by hsdev.com (Postfix) with ESMTP id 17EB236A2CFC
 for <56884 <at> debbugs.gnu.org>; Tue,  9 Aug 2022 10:04:28 +0200 (CEST)
User-agent: mu4e 1.8.6; emacs 29.0.50
From: Marcel van der Boom <marcel@HIDDEN>
To: 56884 <at> debbugs.gnu.org
Subject: [PATCH] Make x265 build on ppc64le
Date: Tue, 09 Aug 2022 10:02:34 +0200
Message-ID: <87wnbhder7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Spam-Score: 0.22
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 56884
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Anything else needed here?

The patch seems consistent with other packagers I think. Others 
are also confused on what is needed for the altivec code between 
different POWER processors.




Information forwarded to guix-patches@HIDDEN:
bug#56884; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 2 Aug 2022 12:10:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 02 08:10:30 2022
Received: from localhost ([127.0.0.1]:42728 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oIqjG-0008CD-9J
	for submit <at> debbugs.gnu.org; Tue, 02 Aug 2022 08:10:30 -0400
Received: from lists.gnu.org ([209.51.188.17]:59206)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mrb@HIDDEN>) id 1oIqjD-0008C3-VS
 for submit <at> debbugs.gnu.org; Tue, 02 Aug 2022 08:10:29 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:38476)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mrb@HIDDEN>) id 1oIqjD-0005uI-5f
 for guix-patches@HIDDEN; Tue, 02 Aug 2022 08:10:27 -0400
Received: from read.hsdev.com ([2001:19f0:5001:2902:5400:1ff:feeb:c9ab]:54058)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mrb@HIDDEN>) id 1oIqjA-0007GV-KQ
 for guix-patches@HIDDEN; Tue, 02 Aug 2022 08:10:26 -0400
Received: from hsdev.com (hawking.hsdev.com [213.125.12.142])
 by read.hsdev.com (Postfix) with ESMTPA id BFC2721611;
 Tue,  2 Aug 2022 14:10:21 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hsdev.com; s=201906;
 t=1659442221;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:
 content-transfer-encoding:content-transfer-encoding;
 bh=tYoA6DzC2MSk5w5nY30szX1op0GRcKPe+hR3DDU4IMg=;
 b=FRFONoqMBOoTUf/35+78DyGT30pCrSSwyUGgRM6D3mhYVyoRdZAh3UywQwyo6s/NncKxyM
 oGECcwl1wWIUcBhJOJ8yKrPql6T2ZOkrPDta6anoRytKCJflQrKZeSRjTxt2fiparcfMrG
 +yrP3xUfIQzIyz12J8v4ArrlTdUbwGU=
Received: by hsdev.com (Postfix, from userid 1000)
 id AD51D36A04E8; Tue,  2 Aug 2022 14:10:21 +0200 (CEST)
From: Marcel van der Boom <marcel@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] Make x265 build on ppc64le
Date: Tue,  2 Aug 2022 14:10:14 +0200
Message-Id: <f7be730ee74999da0f20b44c94c805681a194730.1659442047.git.marcel@HIDDEN>
X-Mailer: git-send-email 2.37.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -1.20
Received-SPF: pass client-ip=2001:19f0:5001:2902:5400:1ff:feeb:c9ab;
 envelope-from=mrb@HIDDEN; helo=read.hsdev.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Marcel van der Boom <marcel@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/video.scm: disable ALTIVEC for target-ppc64le
---
 gnu/packages/video.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 04049fd9c8..09f8b7fd23 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1252,6 +1252,9 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"
@@ -1272,6 +1275,9 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"

base-commit: a1f7d98a9c7380be5815fd13b519bbab145757c2
-- 
2.37.1





Acknowledgement sent to Marcel van der Boom <marcel@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#56884; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 10 Aug 2022 02:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.