GNU logs - #56994, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#56994] [PATCH] Add nmail
Resent-From: matf@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 05 Aug 2022 03:45:02 +0000
Resent-Message-ID: <handler.56994.B.165967108132685 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 56994 <at> debbugs.gnu.org
Cc: M <matf@HIDDEN>
From: matf@HIDDEN
Date: Fri,  5 Aug 2022 04:21:37 +0200
Message-Id: <24b34888cb54d3702eaeebf40267d910be9b54bb.1659666096.git.matf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=178.21.23.139; envelope-from=matf@HIDDEN;
 helo=knopi.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Thu, 04 Aug 2022 23:44:38 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

From: M <matf@HIDDEN>

---
 gnu/packages/mail.scm | 74 ++++++++++++++++++++++++++++++++-----------
 1 file changed, 55 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index ca4b3e819e..0bc6519dd2 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -49,6 +49,7 @@
 ;;; Copyright © 2022 Thiago Jung Bauermann <bauermann@HIDDEN>
 ;;; Copyright © 2022 Guillaume Le Vaillant <glv@HIDDEN>
 ;;; Copyright © 2022 muradm <mail@HIDDEN>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -66,8 +67,6 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages mail)
-  #:use-module (guix gexp)
-  #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages admin)
   #:use-module (gnu packages aspell)
@@ -94,6 +93,7 @@ (define-module (gnu packages mail)
   #:use-module (gnu packages emacs)
   #:use-module (gnu packages enchant)
   #:use-module (gnu packages file)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gawk)
@@ -101,15 +101,14 @@ (define-module (gnu packages mail)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages glib)
-  #:use-module (gnu packages golang)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages groff)
   #:use-module (gnu packages gsasl)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages guile-xyz)
-  #:use-module (gnu packages flex)
   #:use-module (gnu packages haskell-xyz)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages kerberos)
@@ -124,13 +123,14 @@ (define-module (gnu packages mail)
   #:use-module (gnu packages lsof)
   #:use-module (gnu packages lua)
   #:use-module (gnu packages m4)
+  #:use-module (gnu packages mail)
   #:use-module (gnu packages man)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages nettle)
   #:use-module (gnu packages networking)
   #:use-module (gnu packages ninja)
-  #:use-module (gnu packages openldap)
   #:use-module (gnu packages onc-rpc)
+  #:use-module (gnu packages openldap)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pdf)
   #:use-module (gnu packages perl)
@@ -145,14 +145,14 @@ (define-module (gnu packages mail)
   #:use-module (gnu packages python-web)
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages ragel)
-  #:use-module (gnu packages regex)
   #:use-module (gnu packages rdf)
   #:use-module (gnu packages readline)
+  #:use-module (gnu packages regex)
   #:use-module (gnu packages ruby)
-  #:use-module (gnu packages search)
-  #:use-module (gnu packages serialization)
   #:use-module (gnu packages samba)
   #:use-module (gnu packages screen)
+  #:use-module (gnu packages search)
+  #:use-module (gnu packages serialization)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages tcl)
@@ -164,28 +164,28 @@ (define-module (gnu packages mail)
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xdisorg)
-  #:use-module (gnu packages xorg)
   #:use-module (gnu packages xml)
-  #:use-module ((guix licenses) #:prefix license:)
-  #:use-module (guix packages)
-  #:use-module (guix deprecation)
-  #:use-module (guix download)
-  #:use-module (guix git-download)
-  #:use-module (guix svn-download)
-  #:use-module (guix utils)
+  #:use-module (gnu packages xorg)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system emacs)
   #:use-module (guix build-system glib-or-gtk)
-  #:use-module (guix build-system go)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system go)
   #:use-module (guix build-system guile)
-  #:use-module (guix build-system emacs)
   #:use-module (guix build-system meson)
   #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
-  #:use-module (srfi srfi-1)
+  #:use-module (guix deprecation)
+  #:use-module (guix download)
+  #:use-module (guix gexp)
+  #:use-module (guix git-download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix svn-download)
+  #:use-module (guix utils)
   #:use-module (ice-9 match))
+  #:use-module (srfi srfi-1))
 
 (define-public abook
   (package
@@ -441,6 +441,42 @@ (define-public guile2.2-mailutils
      (modify-inputs (package-inputs mailutils)
        (replace "guile" guile-2.2)))))
 
+(define-public nmail
+  (package
+    (name "nmail")
+    (version "3.74")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/d99kris/nmail/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "07lkl5syx3l37dhsl41nhmjknhxqgmvwc4il4gygsnr333qk75c9"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list #:phases #~(modify-phases %standard-phases
+                        (replace 'check
+                          (lambda*
+                              (#:key tests? #:allow-other-keys)
+                              (when tests? (invoke "ctest" "--output-on-failure")))))))
+    (inputs (list libetpan
+                  xapian
+                  sqlite
+                  cyrus-sasl
+                  ncurses
+                  openssl
+                  file
+                  (list util-linux "lib")))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/d99kris/nmail")
+    (synopsis "Terminal-based email client")
+    (description
+     "@command{nmail} is a terminal-based email client with a
+@code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
+    (license license:expat)))
+
 (define-public nullmailer
   (package
     (name "nullmailer")
-- 
2.34.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: matf@HIDDEN
Subject: bug#56994: Acknowledgement ([PATCH] Add nmail)
Message-ID: <handler.56994.B.165967108132685.ack <at> debbugs.gnu.org>
References: <24b34888cb54d3702eaeebf40267d910be9b54bb.1659666096.git.matf@HIDDEN>
X-Gnu-PR-Message: ack 56994
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 56994 <at> debbugs.gnu.org
Date: Fri, 05 Aug 2022 03:45:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 56994 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
56994: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56994
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#56994] Acknowledgement ([PATCH] Add nmail)
Resent-From: Mathieu <matf@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 05 Aug 2022 07:51:02 +0000
Resent-Message-ID: <handler.56994.B56994.165968580819221 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 56994 <at> debbugs.gnu.org
Date: Fri, 5 Aug 2022 09:49:59 +0200
From: Mathieu <matf@HIDDEN>
Message-ID: <b207e400-f103-48ec-be1b-d825bbf8b6d8@HIDDEN>
In-Reply-To: <handler.56994.B.165967108132685.ack <at> debbugs.gnu.org>
References: <handler.56994.B.165967108132685.ack <at> debbugs.gnu.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is my first attempt at packaging for Guix, I hope I didn't do any hu=
ge mistakes. And thanks IRC for the massive help I've received to slowly =
progress with Scheme.

I was unsure where to add the =60use-module=60 I needed for =60nmail.scm=60=
 when adding it into =60mail.scm=60, and in the end I think all modules w=
ere all already there, but to check that, I ordered them alphabetically i=
n =60mail.scm=60 and this revealed some duplicates, so the patch reflects=
 that too.

Message sent to guix-patches@HIDDEN:

Subject: [bug#56994] [PATCH] Add nmail
Resent-From: "(" <paren@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 05 Aug 2022 12:31:02 +0000
Resent-Message-ID: <handler.56994.B56994.1659702633654 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: <matf@HIDDEN>, <56994 <at> debbugs.gnu.org>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 05 Aug 2022 13:30:19 +0100
Message-Id: <CLY3H5RT7TGF.2D2ROQS8D6IIP@guix-aspire>
From: "(" <paren@HIDDEN>
References: <24b34888cb54d3702eaeebf40267d910be9b54bb.1659666096.git.matf@HIDDEN>
In-Reply-To: <24b34888cb54d3702eaeebf40267d910be9b54bb.1659666096.git.matf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Nice to see you got it working :) Some stylistic nits:

On Fri Aug 5, 2022 at 3:21 AM BST,  wrote:
> From: M <matf@HIDDEN>
>
> ---

You need to write a commit message following the project's conventions. In
this case, it'd be something like:

> gnu: packages: Add nmail.
>
> * gnu/packages/mail.scm: Reorder module imports. Remove
>   duplicate imports.
> (nmail): New variable.

Refer to <https://www.gnu.org/prep/standards/html_node/Change-Logs.html>.
(No, I don't like it much either :))

> +    (arguments
> +     (list #:phases #~(modify-phases %standard-phases
> +                        (replace 'check
> +                          (lambda*
> +                              (#:key tests? #:allow-other-keys)
> +                              (when tests? (invoke "ctest" "--output-on-=
failure")))))))

This part should be reformatted like this:

> (arguments
>  (list #:phases
>        #~(modify-phases %standard-phases
>            (replace 'check
>              (lambda* (#:key tests? #:allow-other-keys)
>                (when tests?
>                  (invoke "ctest" "--output-on-failure")))))))

> +    (inputs (list libetpan
> +                  xapian
> +                  sqlite
> +                  cyrus-sasl
> +                  ncurses
> +                  openssl
> +                  file
> +                  (list util-linux "lib")))

And this as:

> (inputs
>  (list cyrus-sasl
>        file
>        ncurses
>        openssl
>        sqlite
>        (list util-linux "lib")
>        xapian))

> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/d99kris/nmail")
> +    (synopsis "Terminal-based email client")
> +    (description
> +     "@command{nmail} is a terminal-based email client with a
> +@code{ncurses} user interface similar to @code{alpine} and @code{pine}."=
)
> +    (license license:expat)))
> +
>  (define-public nullmailer
>    (package
>      (name "nullmailer")
> --=20
> 2.34.0

Other than that, LGTM! :)

    -- (

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 6 Aug 2022 23:25:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 06 19:25:00 2022
Received: from localhost ([127.0.0.1]:35631 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oKTAB-0000p0-QM
	for submit <at> debbugs.gnu.org; Sat, 06 Aug 2022 19:24:59 -0400
Received: from knopi.disroot.org ([178.21.23.139]:45610)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <matf@HIDDEN>) id 1oKTA9-0000or-7O
 for control <at> debbugs.gnu.org; Sat, 06 Aug 2022 19:24:57 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id A5B3843A3B
 for <control <at> debbugs.gnu.org>; Sun,  7 Aug 2022 01:24:56 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id rOdX-rhnqW3V for <control <at> debbugs.gnu.org>;
 Sun,  7 Aug 2022 01:24:55 +0200 (CEST)
Date: Sun, 7 Aug 2022 01:24:55 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disr.it; s=mail;
 t=1659828295; bh=UneguwCK8Yw40/9jvfpSSWF2UJxsogJfsI8ywgPNN5s=;
 h=Date:From:To:Subject;
 b=Ihu/uIwlX365DGKQm1T4EnDwoOQOotRgMnkcTyW55i3fOmfgbNmhpm5pnibZrxPNk
 qcErKAMyVly13xaq4L3Szn7XvDFqOZ965blmKogCPnH2mip1Xyep3KLFLJu1mcGPgg
 KdO0t2fxtDHlRbpeGg3j5LT6b1EpNLfWN3cG8Ce0y9odL48K0JEjgzlF6EgVzkdYiw
 ZlmDWLMjnEFDWZkrghMDwbp2zMaDfVU0c3rNpXMkB8zF0WK/UZmGxT4lIiZ5d1BfMN
 uCD/8GEST9RwYP84RxlycK37d6wKaXfFrJpgR6YqmjQ7fEw1IixtrcrNfqCVH1mz5c
 VL9wb2sGy2PRQ==
From: Mathieu <matf@HIDDEN>
To: control <at> debbugs.gnu.org
Message-ID: <e1b4c5ad-ffb1-4aed-a26f-92ac831441f6@HIDDEN>
Subject: merge 56994 57201
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

merge 56994 57021

Last modified: Sat, 6 Aug 2022 23:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.