GNU bug report logs - #57017
[PATCH]: gnu: tdlib: Update to 1.8.4.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57017 in the body.
You can then email your comments to 57017 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH]: gnu: tdlib: Update to 1.8.4. 
Date: Sat, 06 Aug 2022 23:30:19 +0800

[Message part 1 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

[0001-gnu-tdlib-Use-G-expressions.patch (text/x-patch, inline)]

From 0037a0f2847fe39846c5a03139ef1be5b0a45155 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sat, 6 Aug 2022 23:10:56 +0800
Subject: [PATCH 1/2] gnu: tdlib: Use G-expressions.

* gnu/packages/messaging.scm (tdlib)[arguments]: Use G-expressions.
---
 gnu/packages/messaging.scm | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 2f61a8f783..aa15bf5b53 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2665,19 +2665,20 @@ (define-public tdlib
        (file-name (git-file-name name version))))
     (build-system cmake-build-system)
     (arguments
-     `(#:configure-flags
-       (list "-DCMAKE_BUILD_TYPE=Release"
-             "-DTD_ENABLE_LTO=OFF")     ; FIXME: Get LTO to work.
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'remove-failing-tests
-           (lambda _
-             (substitute* "test/CMakeLists.txt"
-               ;; The test cases are compiled into a distinct binary
-               ;; which uses mtproto.cpp to attempt to connect to
-               ;; a remote server. Removing this file from the sources
-               ;; list disables those specific test cases.
-               (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")))))))
+     (list
+      #:configure-flags
+      #~(list "-DCMAKE_BUILD_TYPE=Release"
+              "-DTD_ENABLE_LTO=OFF")      ; FIXME: Get LTO to work.
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'remove-failing-tests
+            (lambda _
+              (substitute* "test/CMakeLists.txt"
+                ;; The test cases are compiled into a distinct binary
+                ;; which uses mtproto.cpp to attempt to connect to
+                ;; a remote server. Removing this file from the sources
+                ;; list disables those specific test cases.
+                (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")))))))
     (native-inputs
      (list gperf openssl zlib php doxygen))
     (synopsis "Cross-platform library for building Telegram clients")
-- 
2.37.1

[0002-gnu-tdlib-Update-to-1.8.4.patch (text/x-patch, inline)]

From 45ff40bc27f6cacba976814841c90e8572118302 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sat, 6 Aug 2022 23:12:17 +0800
Subject: [PATCH 2/2] gnu: tdlib: Update to 1.8.4.

* gnu/packages/messaging.scm (tdlib): Update to 1.8.4.
<#:configure-flags>: Enable LTO. Move build type settings to #:build-type
arguments.
<#:build-type>: Use "Release build".
---
 gnu/packages/messaging.scm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index aa15bf5b53..89ba419f18 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2653,22 +2653,20 @@ (define-public telegram-purple
 (define-public tdlib
   (package
     (name "tdlib")
-    (version "1.8.0")
+    (version "1.8.4")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
              (url "https://github.com/tdlib/td")
-             (commit (string-append "v" version))))
+             (commit "7eabd8ca60de025e45e99d4e5edd39f4ebd9467e")))
        (sha256
-        (base32 "19psqpyh9a2kzfdhgqkirpif4x8pzy89phvi59dq155y30a3661q"))
+        (base32 "1chs0ibghjj275v9arsn3k68ppblpm7ysqk0za9kya5vdnldlld5"))
        (file-name (git-file-name name version))))
     (build-system cmake-build-system)
     (arguments
      (list
-      #:configure-flags
-      #~(list "-DCMAKE_BUILD_TYPE=Release"
-              "-DTD_ENABLE_LTO=OFF")      ; FIXME: Get LTO to work.
+      #:build-type "Release"
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'remove-failing-tests
-- 
2.37.1

[Message part 5 (text/plain, inline)]

-- 
Retrieve my PGP public key:

  gpg --recv-keys 481F5EEEBA425ADC13247C76A6E672D981B8E744

Zihao

Message #8 received at 57017 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 57017 <at> debbugs.gnu.org
Subject: Re: bug#57017: Acknowledgement ([PATCH]: gnu: tdlib: Update to
 1.8.4. )
Date: Sat, 13 Aug 2022 22:04:14 +0800

ping.
-- 
Retrieve my PGP public key:

  gpg --recv-keys 481F5EEEBA425ADC13247C76A6E672D981B8E744

Zihao

Message #13 received at 57017-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 57017-done <at> debbugs.gnu.org
Subject: Re: bug#57017: [PATCH]: gnu: tdlib: Update to 1.8.4. 
Date: Thu, 01 Sep 2022 00:57:50 +0200

Hi,

Zhu Zihao <all_but_last <at> 163.com> skribis:

>>From 0037a0f2847fe39846c5a03139ef1be5b0a45155 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last <at> 163.com>
> Date: Sat, 6 Aug 2022 23:10:56 +0800
> Subject: [PATCH 1/2] gnu: tdlib: Use G-expressions.
>
> * gnu/packages/messaging.scm (tdlib)[arguments]: Use G-expressions.

[...]

>>From 45ff40bc27f6cacba976814841c90e8572118302 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last <at> 163.com>
> Date: Sat, 6 Aug 2022 23:12:17 +0800
> Subject: [PATCH 2/2] gnu: tdlib: Update to 1.8.4.
>
> * gnu/packages/messaging.scm (tdlib): Update to 1.8.4.
> <#:configure-flags>: Enable LTO. Move build type settings to #:build-type
> arguments.
> <#:build-type>: Use "Release build".

Applied, thanks!

Ludo’.

Message #16 received at 57017 <at> debbugs.gnu.org (full text, mbox):

From: Giovanni Biscuolo <g <at> xelera.eu>
To: Zhu Zihao <all_but_last <at> 163.com>, 57017 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#57017] [PATCH]: gnu: tdlib: Update to 1.8.4.
Date: Fri, 09 Sep 2022 15:57:16 +0200

[Message part 1 (text/plain, inline)]

Hello,

sorry I was not able to spot this issue before this patch was committed

Zhu Zihao <all_but_last <at> 163.com> writes:

[...]

> From 45ff40bc27f6cacba976814841c90e8572118302 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last <at> 163.com>
> Date: Sat, 6 Aug 2022 23:12:17 +0800
> Subject: [PATCH 2/2] gnu: tdlib: Update to 1.8.4.
>
> * gnu/packages/messaging.scm (tdlib): Update to 1.8.4.
> <#:configure-flags>: Enable LTO. Move build type settings to #:build-type
> arguments.
> <#:build-type>: Use "Release build".
> ---
>  gnu/packages/messaging.scm | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index aa15bf5b53..89ba419f18 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -2653,22 +2653,20 @@ (define-public telegram-purple
>  (define-public tdlib
>    (package
>      (name "tdlib")
> -    (version "1.8.0")
> +    (version "1.8.4")
>      (source
>       (origin
>         (method git-fetch)
>         (uri (git-reference
>               (url "https://github.com/tdlib/td")
> -             (commit (string-append "v" version))))
> +             (commit "7eabd8ca60de025e45e99d4e5edd39f4ebd9467e")))

with the change above this patch is not using an official release of the
library but a specific commit from master, still not stable

the last stable release of tdlib is still 1.8.0 [1] and there is no
1.8.4 release yet

unfortunately people (like me) who upgraded tdlib are now having
problems with emacs-telega (see bug#57543)

please revert this patch ASAP

furthermore, it is likely that reverting this patch is not enough to
restore emacs-telega functionality since the tdlib upgrade triggered a
tdblib database upgrade that is non more compatible with the previous
tdlib version (see bug #57543) for details

[...]

Happy hacking!  Gio'

[1] https://github.com/tdlib/td/blob/master/CHANGELOG.md

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.