GNU bug report logs - #57024
[PATCH] gnu: Add emacs-pdb-capf.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57024 in the body.
You can then email your comments to 57024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add emacs-pdb-capf.
Date: Sat,  6 Aug 2022 19:00:58 -0500

* gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5e60d4fafd..b73383431f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -31947,6 +31947,32 @@ (define-public emacs-consult-lsp
 by leveraging @code{emacs-consult} APIs.")
     (license license:expat)))
 
+(define-public emacs-pdb-capf
+  (let ((commit "2f4099aa1330f87df4e9cd526de057ee9b71de6c")
+        (revision "0"))
+    (package
+      (name "emacs-pdb-capf")
+      (version (git-version "1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/muffinmad/emacs-pdb-capf")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0fdzhsz3784lf50mdabz9h2b6992cab2nnn4xv7rx2a8hsyyq1mq"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+        (list emacs-imgur-el))
+      (home-page "https://github.com/muffinmad/emacs-pdb-capf")
+      (synopsis "Completion-at-point function for pdb")
+      (description
+"@code{emacs-pdb-capf} provides a @code{completion-at-point} function
+for pdb allowing completion in a @code{*gud-pdb*} buffer.")
+      (license license:gpl3+))))
+
 (define-public emacs-bitbake-modes
   (package
    (name "emacs-bitbake-modes")
-- 
2.37.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: jgart <jgart <at> dismail.de>, 57024 <at> debbugs.gnu.org
Subject: Re: [bug#57024] [PATCH] gnu: Add emacs-pdb-capf.
Date: Thu, 25 Aug 2022 13:48:54 +0200

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.

Thank you.

> +      (propagated-inputs
> +        (list emacs-imgur-el))

You need to package this first.

Regards,
-- 
Nicolas Goaziou

Message #14 received at 57024 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 57024 <at> debbugs.gnu.org, jgart via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#57024] [PATCH] gnu: Add emacs-pdb-capf.
Date: Thu, 25 Aug 2022 08:36:51 -0500

On Thu, 25 Aug 2022 13:48:54 +0200 Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
> Hello,
> 
> jgart via Guix-patches via <guix-patches <at> gnu.org> writes:
> 
> > * gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.
> 
> Thank you.
> 
> > +      (propagated-inputs
> > +        (list emacs-imgur-el))

Oh, that's a mistake. emacs-pdb-capf doesn't need that package. Not sure how that happened. I'll send an updated patch.

Message #20 received at 57024 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 57024 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH v2] gnu: Add emacs-pdb-capf.
Date: Thu, 25 Aug 2022 08:48:03 -0500

* gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.

Hi Nicolas, 

Here is v2 with the spurious dependency removed. I also bumped the package.

Thanks for the review and for looking at this.

all best,

jgart
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f01af98c7c..325a366fc9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32003,6 +32003,30 @@ (define-public emacs-consult-lsp
 by leveraging @code{emacs-consult} APIs.")
     (license license:expat)))
 
+(define-public emacs-pdb-capf
+  (let ((commit "31602ccab53aa7dcf26a1af222c7da2bcc1390ed")
+        (revision "0"))
+    (package
+      (name "emacs-pdb-capf")
+      (version (git-version "1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/muffinmad/emacs-pdb-capf")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0x2pg03csf25vj8y2zb5sv493dk3n0s4xbkihii2mzhkx82vgpxg"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/muffinmad/emacs-pdb-capf")
+      (synopsis "Completion-at-point function for pdb")
+      (description
+"@code{emacs-pdb-capf} provides a @code{completion-at-point} function
+for pdb allowing completion in a @code{*gud-pdb*} buffer.")
+      (license license:gpl3+))))
+
 (define-public emacs-bitbake-modes
   (package
    (name "emacs-bitbake-modes")
-- 
2.37.2

Message #25 received at 57024-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart <jgart <at> dismail.de>
Cc: 57024-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add emacs-pdb-capf.
Date: Thu, 25 Aug 2022 19:00:58 +0200

Hello,

jgart <jgart <at> dismail.de> writes:

> * gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.