GNU bug report logs - #57056
[PATCH] Update python-lsp-server

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Mon, 8 Aug 2022 10:34:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57056 in the body.
You can then email your comments to 57056 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Mon, 08 Aug 2022 10:34:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Graves <ngraves <at> ngraves.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 08 Aug 2022 10:34:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update python-lsp-server
Date: Mon, 08 Aug 2022 12:33:36 +0200
Hi!

This patch series updates the python-lsp-server.
The package python-pluggy has been updated and the rebuild of
python-pytest works fine.

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Mon, 08 Aug 2022 10:37:01 GMT) Full text and rfc822 format available.

Message #8 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 1/3] gnu: Add python-whatthepatch.
Date: Mon,  8 Aug 2022 12:36:06 +0200
* gnu/packages/python-web.scm (python-whatthepatch): New variable.
---
 gnu/packages/python-web.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 7c5e5651c8..24ab022777 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -7666,3 +7666,20 @@ (define-public python-sendgrid
 SendGrid Web API v3.  Version 3+ of the library provides full support for all
 SendGrid Web API v3 endpoints, including the new v3 /mail/send.")
     (license license:expat)))
+
+(define-public python-whatthepatch
+  (package
+    (name "python-whatthepatch")
+    (version "1.0.2")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "whatthepatch" version))
+              (sha256
+               (base32
+                "17zspm5sxhvggkdhwq4s0fzf4mkc825xshn734g2j2iy2xcylh65"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/cscorley/whatthepatch")
+    (synopsis "Patch parsing and application")
+    (description
+     "This package provides a library to parse and apply patches.")
+    (license license:expat)))
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Mon, 08 Aug 2022 10:37:02 GMT) Full text and rfc822 format available.

Message #11 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 2/3] gnu: python-pluggy: Update to 1.0.0.
Date: Mon,  8 Aug 2022 12:36:07 +0200
* gnu/packages/python-xyz.scm (python-pluggy): Update to 1.0.0.
---
 gnu/packages/python-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b6ca32a757..9736930f15 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14447,17 +14447,17 @@ (define-public python-rsa
 (define-public python-pluggy
   (package
    (name "python-pluggy")
-   (version "0.13.1")
+   (version "1.0.0")
    (source
     (origin
      (method url-fetch)
      (uri (pypi-uri "pluggy" version))
      (sha256
       (base32
-       "1c35qyhvy27q9ih9n899f3h4sdnpgq027dbiilly2qb5cvgarchm"))))
+       "0n8iadlas2z1b4h0fc73b043c7iwfvx9rgvqm1azjmffmhxkf922"))))
    (build-system python-build-system)
-   (native-inputs
-    (list python-setuptools-scm))
+   (propagated-inputs (list python-importlib-metadata))
+   (native-inputs (list python-setuptools-scm))
    (synopsis "Plugin and hook calling mechanism for Python")
    (description "Pluggy is an extraction of the plugin manager as used by
 Pytest but stripped of Pytest specific details.")
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Mon, 08 Aug 2022 10:37:02 GMT) Full text and rfc822 format available.

Message #14 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 3/3] gnu: python-lsp-server: Update to 1.5.0.
Date: Mon,  8 Aug 2022 12:36:08 +0200
* gnu/packages/python-xyz.scm (python-lsp-server): Update to 1.5.0.
---
 gnu/packages/python-xyz.scm | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9736930f15..a6f07d9252 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -5258,49 +5258,38 @@ (define-public python-pydocstyle
 (define-public python-lsp-server
   (package
     (name "python-lsp-server")
-    (version "1.3.3")
+    (version "1.5.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "python-lsp-server" version))
        (sha256
         (base32
-         "0h6wxzmm6qjfwkkn3mnzn1fpmcp23fpbk74bi8p540q1nzccqj0v"))))
+         "039qi5x9sa1mjzinimxhiwzj8lxn5d5l33q6qhkjl0i5k70r9h75"))))
     (build-system python-build-system)
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-before 'check 'set-HOME
-           (lambda _ (setenv "HOME" "/tmp")))
-         (replace 'check
-           (lambda _
-             ;; Disable failing test.
-             (invoke "python" "-m" "pytest" "-k"
-                     "not test_pyqt_completion"))))))
     (propagated-inputs
      (list python-autopep8
            python-pydocstyle
            python-flake8
-           python-future
            python-jedi
            python-lsp-jsonrpc
            python-pluggy
            python-pycodestyle
            python-pyflakes
            python-rope
+           python-setuptools
            python-ujson
            python-yapf))
     (native-inputs
      (list python-coverage
            python-flaky
            python-matplotlib
-           python-mock
            python-numpy
            python-pandas
            python-pylint
            python-pytest
            python-pytest-cov
-           python-versioneer))
+           python-whatthepatch))
     (home-page "https://github.com/python-lsp/python-lsp-server")
     (synopsis "Python implementation of the Language Server Protocol")
     (description
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Fri, 12 Aug 2022 09:01:02 GMT) Full text and rfc822 format available.

Message #17 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 57056 <at> debbugs.gnu.org
Subject: Re: bug#57056: [PATCH] Update python-lsp-server
Date: Fri, 12 Aug 2022 11:00:27 +0200
Hello Nicolas,

> +   (propagated-inputs (list python-importlib-metadata))

This needs to be described in the commit message, this way:

[propagated-inputs]: Add python-importlib-metadata.

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Fri, 12 Aug 2022 09:04:02 GMT) Full text and rfc822 format available.

Message #20 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 57056 <at> debbugs.gnu.org
Subject: Re: bug#57056: [PATCH] Update python-lsp-server
Date: Fri, 12 Aug 2022 11:03:35 +0200
Hello,

> -       (modify-phases %standard-phases
> -         (add-before 'check 'set-HOME
> -           (lambda _ (setenv "HOME" "/tmp")))

You need to document it in the commit message, this way:

[arguments]{set-HOME}: Remove this phase because...
{check}: Do not replace it as test_pyqt_completion is not longer
failing.

or something similar.
>      (propagated-inputs
>       (list python-autopep8
>             python-pydocstyle
>             python-flake8
> -           python-future
>             python-jedi
>             python-lsp-jsonrpc
>             python-pluggy
>             python-pycodestyle
>             python-pyflakes
>             python-rope
> +           python-setuptools
>             python-ujson
>             python-yapf))
>      (native-inputs
>       (list python-coverage
>             python-flaky
>             python-matplotlib
> -           python-mock
>             python-numpy
>             python-pandas
>             python-pylint
>             python-pytest
>             python-pytest-cov
> -           python-versioneer))
> +           python-whatthepatch))

Ditto, with something like

[propagated-inputs]: Remove python-future and add python-setuptools.
[native-inputs]: Remove python-mock, python-versioneer and add
python-whatthepatch.

Could you please send a v2?

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Fri, 12 Aug 2022 11:01:02 GMT) Full text and rfc822 format available.

Message #23 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH v2 1/3] gnu: Add python-whatthepatch.
Date: Fri, 12 Aug 2022 13:00:02 +0200
* gnu/packages/python-web.scm (python-whatthepatch): New variable.
---
 gnu/packages/python-web.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 896e60aba2..0f00a23747 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -7761,3 +7761,20 @@ (define-public python-shopifyapi
 ruby Shopify API gem.  The library makes HTTP requests to Shopify in order to
 list, create, update, or delete resources (e.g. Order, Product, Collection).")
     (license license:expat)))
+
+(define-public python-whatthepatch
+  (package
+    (name "python-whatthepatch")
+    (version "1.0.2")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "whatthepatch" version))
+              (sha256
+               (base32
+                "17zspm5sxhvggkdhwq4s0fzf4mkc825xshn734g2j2iy2xcylh65"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/cscorley/whatthepatch")
+    (synopsis "Patch parsing and application")
+    (description
+     "This package provides a library to parse and apply patches.")
+    (license license:expat)))
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Fri, 12 Aug 2022 11:01:02 GMT) Full text and rfc822 format available.

Message #26 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH v2 2/3] gnu: python-pluggy: Update to 1.0.0.
Date: Fri, 12 Aug 2022 13:00:03 +0200
* gnu/packages/python-xyz.scm (python-pluggy): Update to 1.0.0.
  [propagated-inputs]: Add python-importlib-metadata.
---
 gnu/packages/python-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9422bf2866..01b78a4e19 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14509,17 +14509,17 @@ (define-public python-rsa
 (define-public python-pluggy
   (package
    (name "python-pluggy")
-   (version "0.13.1")
+   (version "1.0.0")
    (source
     (origin
      (method url-fetch)
      (uri (pypi-uri "pluggy" version))
      (sha256
       (base32
-       "1c35qyhvy27q9ih9n899f3h4sdnpgq027dbiilly2qb5cvgarchm"))))
+       "0n8iadlas2z1b4h0fc73b043c7iwfvx9rgvqm1azjmffmhxkf922"))))
    (build-system python-build-system)
-   (native-inputs
-    (list python-setuptools-scm))
+   (propagated-inputs (list python-importlib-metadata))
+   (native-inputs (list python-setuptools-scm))
    (synopsis "Plugin and hook calling mechanism for Python")
    (description "Pluggy is an extraction of the plugin manager as used by
 Pytest but stripped of Pytest specific details.")
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Fri, 12 Aug 2022 11:01:03 GMT) Full text and rfc822 format available.

Message #29 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH v2 3/3] gnu: python-lsp-server: Update to 1.5.0.
Date: Fri, 12 Aug 2022 13:00:04 +0200
* gnu/packages/python-xyz.scm (python-lsp-server): Update to 1.5.0.
   [arguments]{set-HOME}: Remove this phase because tests do not require it
   anymore.
   {check}: Do not replace it as test_pyqt_completion is not longer failing.
   [propagated-inputs]: Remove python-future and add python-setuptools.
   [native-inputs]: Remove python-mock, python-versioneer and add
   python-whatthepatch.
---
 gnu/packages/python-xyz.scm | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 01b78a4e19..ac2de03ff4 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -5273,49 +5273,38 @@ (define-public python-pydocstyle
 (define-public python-lsp-server
   (package
     (name "python-lsp-server")
-    (version "1.3.3")
+    (version "1.5.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "python-lsp-server" version))
        (sha256
         (base32
-         "0h6wxzmm6qjfwkkn3mnzn1fpmcp23fpbk74bi8p540q1nzccqj0v"))))
+         "039qi5x9sa1mjzinimxhiwzj8lxn5d5l33q6qhkjl0i5k70r9h75"))))
     (build-system python-build-system)
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-before 'check 'set-HOME
-           (lambda _ (setenv "HOME" "/tmp")))
-         (replace 'check
-           (lambda _
-             ;; Disable failing test.
-             (invoke "python" "-m" "pytest" "-k"
-                     "not test_pyqt_completion"))))))
     (propagated-inputs
      (list python-autopep8
            python-pydocstyle
            python-flake8
-           python-future
            python-jedi
            python-lsp-jsonrpc
            python-pluggy
            python-pycodestyle
            python-pyflakes
            python-rope
+           python-setuptools
            python-ujson
            python-yapf))
     (native-inputs
      (list python-coverage
            python-flaky
            python-matplotlib
-           python-mock
            python-numpy
            python-pandas
            python-pylint
            python-pytest
            python-pytest-cov
-           python-versioneer))
+           python-whatthepatch))
     (home-page "https://github.com/python-lsp/python-lsp-server")
     (synopsis "Python implementation of the Language Server Protocol")
     (description
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Sun, 14 Aug 2022 14:15:02 GMT) Full text and rfc822 format available.

Message #32 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 57056 <at> debbugs.gnu.org
Subject: Re: bug#57056: [PATCH] Update python-lsp-server
Date: Sun, 14 Aug 2022 16:14:33 +0200
Hey,

> * gnu/packages/python-xyz.scm (python-lsp-server): Update to 1.5.0.
>    [arguments]{set-HOME}: Remove this phase because tests do not require it
>    anymore.
>    {check}: Do not replace it as test_pyqt_completion is not longer failing.
>    [propagated-inputs]: Remove python-future and add python-setuptools.
>    [native-inputs]: Remove python-mock, python-versioneer and add
>    python-whatthepatch.

Thanks for the v2! I noticed this lint warning, something we should
worry about:

gnu/packages/python-xyz.scm:5274:2: python-lsp-server <at> 1.5.0: 'python-setuptools' should probably not be an input at all

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Sun, 14 Aug 2022 16:37:02 GMT) Full text and rfc822 format available.

Message #35 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH v3 1/3] gnu: Add python-whatthepatch.
Date: Sun, 14 Aug 2022 18:35:58 +0200
* gnu/packages/python-web.scm (python-whatthepatch): New variable.
---
 gnu/packages/python-web.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 896e60aba2..0f00a23747 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -7761,3 +7761,20 @@ (define-public python-shopifyapi
 ruby Shopify API gem.  The library makes HTTP requests to Shopify in order to
 list, create, update, or delete resources (e.g. Order, Product, Collection).")
     (license license:expat)))
+
+(define-public python-whatthepatch
+  (package
+    (name "python-whatthepatch")
+    (version "1.0.2")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "whatthepatch" version))
+              (sha256
+               (base32
+                "17zspm5sxhvggkdhwq4s0fzf4mkc825xshn734g2j2iy2xcylh65"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/cscorley/whatthepatch")
+    (synopsis "Patch parsing and application")
+    (description
+     "This package provides a library to parse and apply patches.")
+    (license license:expat)))
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Sun, 14 Aug 2022 16:37:03 GMT) Full text and rfc822 format available.

Message #38 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH v3 2/3] gnu: python-pluggy: Update to 1.0.0.
Date: Sun, 14 Aug 2022 18:35:59 +0200
* gnu/packages/python-xyz.scm (python-pluggy): Update to 1.0.0.
  [propagated-inputs]: Add python-importlib-metadata.
---
 gnu/packages/python-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 13ab2f2c8b..12a4aa168b 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14511,17 +14511,17 @@ (define-public python-rsa
 (define-public python-pluggy
   (package
    (name "python-pluggy")
-   (version "0.13.1")
+   (version "1.0.0")
    (source
     (origin
      (method url-fetch)
      (uri (pypi-uri "pluggy" version))
      (sha256
       (base32
-       "1c35qyhvy27q9ih9n899f3h4sdnpgq027dbiilly2qb5cvgarchm"))))
+       "0n8iadlas2z1b4h0fc73b043c7iwfvx9rgvqm1azjmffmhxkf922"))))
    (build-system python-build-system)
-   (native-inputs
-    (list python-setuptools-scm))
+   (propagated-inputs (list python-importlib-metadata))
+   (native-inputs (list python-setuptools-scm))
    (synopsis "Plugin and hook calling mechanism for Python")
    (description "Pluggy is an extraction of the plugin manager as used by
 Pytest but stripped of Pytest specific details.")
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Sun, 14 Aug 2022 16:37:03 GMT) Full text and rfc822 format available.

Message #41 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH v3 3/3] gnu: python-lsp-server: Update to 1.5.0.
Date: Sun, 14 Aug 2022 18:36:00 +0200
* gnu/packages/python-xyz.scm (python-lsp-server): Update to 1.5.0.
   [arguments]{set-HOME}: Remove this phase because tests do not require it
   anymore.
   {check}: Do not replace it as test_pyqt_completion is not longer failing.
   [propagated-inputs]: Remove python-future.
   [native-inputs]: Remove python-mock, python-versioneer and add
   python-whatthepatch.
---
 gnu/packages/python-xyz.scm | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 12a4aa168b..48bc1173af 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -5273,30 +5273,19 @@ (define-public python-pydocstyle
 (define-public python-lsp-server
   (package
     (name "python-lsp-server")
-    (version "1.3.3")
+    (version "1.5.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "python-lsp-server" version))
        (sha256
         (base32
-         "0h6wxzmm6qjfwkkn3mnzn1fpmcp23fpbk74bi8p540q1nzccqj0v"))))
+         "039qi5x9sa1mjzinimxhiwzj8lxn5d5l33q6qhkjl0i5k70r9h75"))))
     (build-system python-build-system)
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-before 'check 'set-HOME
-           (lambda _ (setenv "HOME" "/tmp")))
-         (replace 'check
-           (lambda _
-             ;; Disable failing test.
-             (invoke "python" "-m" "pytest" "-k"
-                     "not test_pyqt_completion"))))))
     (propagated-inputs
      (list python-autopep8
            python-pydocstyle
            python-flake8
-           python-future
            python-jedi
            python-lsp-jsonrpc
            python-pluggy
@@ -5309,13 +5298,12 @@ (define-public python-lsp-server
      (list python-coverage
            python-flaky
            python-matplotlib
-           python-mock
            python-numpy
            python-pandas
            python-pylint
            python-pytest
            python-pytest-cov
-           python-versioneer))
+           python-whatthepatch))
     (home-page "https://github.com/python-lsp/python-lsp-server")
     (synopsis "Python implementation of the Language Server Protocol")
     (description
-- 
2.37.1





Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Mon, 15 Aug 2022 07:48:01 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Graves <ngraves <at> ngraves.fr>:
bug acknowledged by developer. (Mon, 15 Aug 2022 07:48:01 GMT) Full text and rfc822 format available.

Message #46 received at 57056-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 57056-done <at> debbugs.gnu.org
Subject: Re: bug#57056: [PATCH] Update python-lsp-server
Date: Mon, 15 Aug 2022 09:47:13 +0200
Hey,

> * gnu/packages/python-xyz.scm (python-lsp-server): Update to 1.5.0.
>    [arguments]{set-HOME}: Remove this phase because tests do not require it
>    anymore.
>    {check}: Do not replace it as test_pyqt_completion is not longer failing.
>    [propagated-inputs]: Remove python-future.
>    [native-inputs]: Remove python-mock, python-versioneer and add
>    python-whatthepatch.

Added your copyright and pushed.

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Mon, 15 Aug 2022 08:34:01 GMT) Full text and rfc822 format available.

Message #49 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 57056 <at> debbugs.gnu.org
Subject: Re: bug#57056: [PATCH] Update python-lsp-server
Date: Mon, 15 Aug 2022 10:33:45 +0200
> * gnu/packages/python-xyz.scm (python-pluggy): Update to 1.0.0.
>   [propagated-inputs]: Add python-importlib-metadata.

Turns out this one was causing an infinite evaluation loop and I had to
revert it just before pushing.

Could it be because of the python-importlib-metadata inclusion?

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Mon, 15 Aug 2022 09:55:01 GMT) Full text and rfc822 format available.

Message #52 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Mathieu Othacehe <othacehe <at> gnu.org>, 57056 <at> debbugs.gnu.org
Subject: Re: bug#57056: [PATCH] Update python-lsp-server
Date: Mon, 15 Aug 2022 11:54:41 +0200
> Could it be because of the python-importlib-metadata inclusion?

I would rather bet on the presence of pluggy in pytest inputs, and the
presence of pytest in the build system, or something like that.

I can't look at that today, but I will investigate that.

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#57056; Package guix-patches. (Sun, 21 Aug 2022 10:15:01 GMT) Full text and rfc822 format available.

Message #55 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 57056 <at> debbugs.gnu.org
Cc: Mathieu Othacehe <othacehe <at> gnu.org>
Subject: How can I reproduce?
Date: Sun, 21 Aug 2022 12:13:55 +0200
Hi Mathieu,

Just a small question because I'm not able to reproduce the inifinite
evaluation loop.

I've tried the following:
- guix source git repository + checkout 07f807f12c and added my
python-pluggy commit
- guix shell -D guix then ./bootstrap and then ./configure --localstatedir=/var
(this step is not very clear for beginners in the 20.2 Running Guix
Before It Is Installed info node, I had to ask on libera chat to get it
to work)
- guix build (either python-pluggy, python-pytest, python-lsp-server) -K

But everything seems to build fine (possibly because of grafting
from my store however).

-- 
Best regards,
Nicolas Graves




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 18 Sep 2022 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 192 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.