GNU bug report logs - #57088
[PATCH] Add emacs-blight and emacs-lemon

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57088 in the body.
You can then email your comments to 57088 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Add emacs-blight and emacs-lemon
Date: Tue, 9 Aug 2022 18:57:04 +0000

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-blight.patch (application/octet-stream, attachment)]

[0002-gnu-Add-emacs-lemon.patch (application/octet-stream, attachment)]

Message #10 received at 57088-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
Cc: 57088-done <at> debbugs.gnu.org
Subject: Re: [bug#57088] [PATCH] Add emacs-blight and emacs-lemon
Date: Fri, 26 Aug 2022 10:29:08 +0200

Hello,

Baptiste Strazzulla <bstrazzull <at> hotmail.fr> writes:

> Subject: [PATCH 1/2] gnu: Add emacs-blight

Applied with the following changes. Thank you.

> +(define-public emacs-blight
> +  (let ((commit "6bf9c6192d")

Changed to a full hash.

> +        (revision "0"))
> +    (package
> +      (name "emacs-blight")
> +      (version (git-version "1.0.0" revision commit))

AFAICT, there is no mention of a version number whatsoever across the
code base. I set the base version to 0 instead.

> +      (description
> +       "@code{blight} allows you to control display brightness from Emacs.  It
> +features object-oriented code using EIEIO, a base class implementing a
> +reasonable API which focuses on the extremely basic \"set the back light to
> +this percentage\" functionality instead of advanced tightly-coupled frippery,
> +it includes a concrete implementation that uses SysFS to control brightness.
> +Other systems (D-Bus, macOS, Windows, xbacklight, XELB using XRandR) are
> +easily supportable, giving the same experience across environments.  It has a
> +500% snappier name than any other backlight tool for Emacs.")

I trimmed down the description a bit.

> +(define-public emacs-lemon
> +  (let ((commit "37a6e6d6ef")

Same as above.

> +      (native-inputs
> +       (list emacs-emms emacs-blight))

I re-ordered inputs alphabetically.

> +      (description
> +       "@code{lemon} is a tiny system monitor which displays system information
> +in the echo area when Emacs is has been idle for a few seconds.  This is a
> +fork of zk_phi’s Symon, which has been largely rewritten.  It fixes a number of
> +bugs and shortcomings and emphasizes customizability and code reuse, but also
> +drops support for non-Linux platforms.  It works nicely with EXWM.")

I removed the penultimate sentence, which is not useful in our case.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.