GNU bug report logs - #57173
[PATCH] gnu: yt-dlp: Update to 2022.08.08.

Previous Next

Package: guix-patches;

Reported by: raingloom <raingloom <at> riseup.net>

Date: Sat, 13 Aug 2022 13:54:01 UTC

Severity: normal

Tags: patch

Done: Vagrant Cascadian <vagrant <at> debian.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57173 in the body.
You can then email your comments to 57173 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#57173; Package guix-patches. (Sat, 13 Aug 2022 13:54:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to raingloom <raingloom <at> riseup.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 13 Aug 2022 13:54:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: raingloom <raingloom <at> riseup.net>
Subject: [PATCH] gnu: yt-dlp: Update to 2022.08.08.
Date: Sat, 13 Aug 2022 15:53:01 +0200
* gnu/packages/video.scm (yt-dlp): Update to 2022.08.08.
  [source]: remove snippet, switch to git-fetch
---
 gnu/packages/video.scm | 23 ++++++-----------------
 1 file changed, 6 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 6d0b5ccb58..94ef3f0468 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2486,26 +2486,15 @@ (define-public youtube-dl
 (define-public yt-dlp
   (package/inherit youtube-dl
     (name "yt-dlp")
-    (version "2022.07.18")
+    (version "2022.08.08")
     (source (origin
-              (method url-fetch)
-              (uri (string-append "https://github.com/yt-dlp/yt-dlp/"
-                                  "releases/download/"
-                                  version "/yt-dlp.tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/yt-dlp/yt-dlp/")
+                    (commit version)))
               (sha256
                (base32
-                "1wmzfqhysx1mqdba4ikvm6nbahasihi4xgqwqad20y3vs701slyj"))
-              (snippet
-               #~(begin
-                   ;; Delete the pre-generated files, except for the man page
-                   ;; which requires 'pandoc' to build.
-                   (for-each delete-file
-                             (list "yt-dlp"
-                                   ;;pandoc is needed to generate
-                                   ;;"yt-dlp.1"
-                                   "completions/bash/yt-dlp"
-                                   "completions/fish/yt-dlp.fish"
-                                   "completions/zsh/_yt-dlp"))))))
+                "07qz1zdndlpki0asw35zk5hdjcwpl3n1g54nxg4yb1iykbyv7rll"))))
     (arguments
      (substitute-keyword-arguments (package-arguments youtube-dl)
        ((#:tests? _) #t)
-- 
2.37.1





Information forwarded to guix-patches <at> gnu.org:
bug#57173; Package guix-patches. (Sat, 13 Aug 2022 14:36:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: raingloom <raingloom <at> riseup.net>
Cc: 57173-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#57173] [PATCH] gnu: yt-dlp: Update to 2022.08.08.
Date: Sat, 13 Aug 2022 16:19:46 +0200
[Message part 1 (text/plain, inline)]
Hi raingloom,

raingloom 写道:
> * gnu/packages/video.scm (yt-dlp): Update to 2022.08.08.

Thanks!

Since yt-dlp was already up to date, I've turned this into a 
‘fetch from git’ patch with the following additions:

>   [source]: remove snippet, switch to git-fetch

 ^^ extraneous indentation; s/remove/Remove/.

When using GIT-FETCH, always set the file-name to something 
meaningful:

 (file-name (git-file-name name version))

> -                   ;; Delete the pre-generated files, except 
> for the man page
> -                   ;; which requires 'pandoc' to build.

OK, but then we do need to build it ourselves, not remove it.

Done in c2481b1bea56f2885110d5af0a6cff36a3d95933.

The new package works fine, but differs slightly: 
extractor/lazy_extractors.py is no longer installed.  What's up 
with that?

Leaving open for now,

T G-R
[signature.asc (application/pgp-signature, inline)]

Reply sent to Tobias Geerinckx-Rice <me <at> tobias.gr>:
You have taken responsibility. (Sat, 13 Aug 2022 14:36:02 GMT) Full text and rfc822 format available.

Notification sent to raingloom <raingloom <at> riseup.net>:
bug acknowledged by developer. (Sat, 13 Aug 2022 14:36:03 GMT) Full text and rfc822 format available.

Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 13 Aug 2022 14:45:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#57173; Package guix-patches. (Sun, 14 Aug 2022 12:48:02 GMT) Full text and rfc822 format available.

Message #18 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Csepp <raingloom <at> riseup.net>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: raingloom <raingloom <at> riseup.net>, guix-patches <at> gnu.org
Subject: Re: [bug#57173] [PATCH] gnu: yt-dlp: Update to 2022.08.08.
Date: Sun, 14 Aug 2022 14:42:36 +0200
Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> [[PGP Signed Part:Undecided]]
> Hi raingloom,
>
> raingloom 写道:
>> * gnu/packages/video.scm (yt-dlp): Update to 2022.08.08.
>
> Thanks!
>
> Since yt-dlp was already up to date, I've turned this into a ‘fetch
> from git’ patch with the following additions:
>
>>   [source]: remove snippet, switch to git-fetch
>
>  ^^ extraneous indentation; s/remove/Remove/.

Dang, I'll get the hang of the changelog format sometime this decade. :)

> When using GIT-FETCH, always set the file-name to something
> meaningful:
>
>  (file-name (git-file-name name version))
>
>> -                   ;; Delete the pre-generated files, except for
>> the man page
>> -                   ;; which requires 'pandoc' to build.
>
> OK, but then we do need to build it ourselves, not remove it.
>
> Done in c2481b1bea56f2885110d5af0a6cff36a3d95933.

I lazily assumed it was being generated already, I guess the comment was
misleading and I should have verified it.

> The new package works fine, but differs slightly:
> extractor/lazy_extractors.py is no longer installed.  What's up with
> that?

Not sure what that is or where it's used.  I'll try to take a look soon-ish.

> Leaving open for now,
>
> T G-R
>
> [[End of PGP Signed Part]]





Information forwarded to guix-patches <at> gnu.org:
bug#57173; Package guix-patches. (Wed, 21 Sep 2022 09:21:01 GMT) Full text and rfc822 format available.

Message #21 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Tobias Geerinckx-Rice via Guix-patches via <guix-patches <at> gnu.org>
Cc: 57173 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 raingloom <raingloom <at> riseup.net>
Subject: Re: [bug#57173] [PATCH] gnu: yt-dlp: Update to 2022.08.08.
Date: Wed, 21 Sep 2022 11:20:06 +0200
[Message part 1 (text/plain, inline)]
On Sat, 13 Aug 2022 16:19:46 +0200
Tobias Geerinckx-Rice via Guix-patches via <guix-patches <at> gnu.org> wrote:

> Leaving open for now,

Hi raingloom, hi Tobias,

is there anything left here? Will you provide an updated patch with
some remainings, or can we close this here?

I'm just skimming through older patches and try to identify what needs
to be pushed vs can be closed.

Thanks,

Björn
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#57173; Package guix-patches. (Wed, 21 Sep 2022 09:21:02 GMT) Full text and rfc822 format available.

Reply sent to Vagrant Cascadian <vagrant <at> debian.org>:
You have taken responsibility. (Sat, 02 Sep 2023 03:59:01 GMT) Full text and rfc822 format available.

Notification sent to raingloom <raingloom <at> riseup.net>:
bug acknowledged by developer. (Sat, 02 Sep 2023 03:59:01 GMT) Full text and rfc822 format available.

Message #29 received at 57173-done <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Csepp <raingloom <at> riseup.net>, Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 57173-done <at> debbugs.gnu.org
Subject: Re: [bug#57173] [PATCH] gnu: yt-dlp: Update to 2022.08.08.
Date: Fri, 01 Sep 2023 20:58:26 -0700
[Message part 1 (text/plain, inline)]
On 2022-08-14, Csepp wrote:
> Tobias Geerinckx-Rice <me <at> tobias.gr> writes:
>> raingloom 写道:
>>> * gnu/packages/video.scm (yt-dlp): Update to 2022.08.08.
...
>> When using GIT-FETCH, always set the file-name to something
>> meaningful:
>>
>>  (file-name (git-file-name name version))
>>
>>> -                   ;; Delete the pre-generated files, except for
>>> the man page
>>> -                   ;; which requires 'pandoc' to build.
>>
>> OK, but then we do need to build it ourselves, not remove it.
>>
>> Done in c2481b1bea56f2885110d5af0a6cff36a3d95933.
>
> I lazily assumed it was being generated already, I guess the comment was
> misleading and I should have verified it.
>
>> The new package works fine, but differs slightly:
>> extractor/lazy_extractors.py is no longer installed.  What's up with
>> that?
>
> Not sure what that is or where it's used.  I'll try to take a look soon-ish.
>
>> Leaving open for now,

If there are other outstanding issues, might be best to open a new bug
for them at this point?

yt-dlp has been updated several times since, the latest being:

88d107b2b9bf72a628065a1475ecce7b49852c35 gnu: yt-dlp: Update to 2023.07.06.

Marking as done.

live well,
  vagrant
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 30 Sep 2023 11:24:26 GMT) Full text and rfc822 format available.

This bug report was last modified 180 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.