GNU bug report logs - #57253
[PATCH] gnu: Add keychain.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57253 in the body.
You can then email your comments to 57253 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: guix-patches <at> gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 1/2] gnu: greybird-gtk-theme: Build with librsvg-for-system.
Date: Wed, 17 Aug 2022 01:46:01 +0200

* gnu/packages/gnome-xyz.scm (greybird-gtk-theme)[inputs]:
  Replace librsvg with librsvg-for-system.
---
 gnu/packages/gnome-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index c37ae27cc5..beab5429bf 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Charles Jackson <charles.b.jackson <at> protonmail.com>
 ;;; Copyright © 2022 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2022 Sughosha <sughosha <at> proton.me>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1137,7 +1138,7 @@ (define-public greybird-gtk-theme
     (native-inputs
      (list gtk+
            `(,glib "bin") ; for "glib-compile-resources"
-           librsvg
+           (librsvg-for-system)
            pkg-config
            ruby-sass
            sassc))

base-commit: 8aab1f7c73c3a6e204b1257e687120c009c88604
-- 
2.37.1

Message #8 received at 57253 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 57253 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 2/2] gnu: Add keychain.
Date: Wed, 17 Aug 2022 02:03:32 +0200

* gnu/packages/crypto.scm (keychain): New variable.
---
 gnu/packages/crypto.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 9dcffd8dd4..3553415ad5 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2021, 2022 Brendan Tildesley <mail <at> brendan.scot>
 ;;; Copyright © 2022 Allan Adair <allan <at> adair.no>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -46,6 +47,7 @@ (define-module (gnu packages crypto)
   #:use-module (gnu packages aidc)
   #:use-module (gnu packages attr)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -1699,3 +1701,42 @@ (define-public libxcrypt
 descrypt.")
     (home-page "https://github.com/besser82/libxcrypt")
     (license license:lgpl2.1)))
+
+(define-public keychain
+  (package
+    (name "keychain")
+    (version "2.8.5")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/funtoo/keychain")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1bkjlg0a2bbdjhwp37ci1rwikvrl4s3xlbf2jq2z4azc96dr83mj"))))
+    (build-system gnu-build-system)
+    (native-inputs (list bash))
+    (arguments
+     `(#:tests? #f
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure)
+                  (replace 'install
+                    (lambda _
+                      (install-file "keychain"
+                                    (string-append %output "/bin/"))
+                      (install-file "keychain.1"
+                                    (string-append %output "/share/man/man1"))
+                      #t)))))
+    (synopsis
+     "SSH or GPG agent frontend that can share a single agent on the same
+system")
+    (description
+     "Keychain is usually run from shell profiles like ~/.bash_profile, but
+it is also possible to use it with non-interactive shells.  It works
+with various operating systems (including GNU/Linux and HURD) and
+shells (like bourne-compatible, csh-compatible and fish shells).  By
+default Keychain will only start ssh-agent, but it can also be
+configured to start gpg-agent.")
+    (home-page "https://www.funtoo.org/Keychain")
+    (license license:gpl2)))
-- 
2.37.1

Message #11 received at 57253 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 57253 <at> debbugs.gnu.org
Subject: Re: bug#57253: [PATCH 1/2] gnu: greybird-gtk-theme: Build with
 librsvg-for-system.
Date: Wed, 17 Aug 2022 13:38:40 +0800

Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> writes:

> * gnu/packages/gnome-xyz.scm (greybird-gtk-theme)[inputs]:
>   Replace librsvg with librsvg-for-system.

Pushed this patch, thank you!

Message #16 received at 57253 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 57253 <at> debbugs.gnu.org, iyzsong <at> envs.net
Subject: Re: [bug#57253] [PATCH 2/2] gnu: Add keychain.
Date: Wed, 21 Sep 2022 18:14:13 +0200

[Message part 1 (text/plain, inline)]

Hi Denis,
Hi iyzsong,

On Wed, 17 Aug 2022 02:03:32 +0200
Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> wrote:

> * gnu/packages/crypto.scm (keychain): New variable.
> ---
>  gnu/packages/crypto.scm | 41
> +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41
> insertions(+)
> 
[..]
> +
> +(define-public keychain

In commit 3220edac2a5ac816328bd65489513ae8d33fbe23, you pushed the
first patch, but you missed this here, and the patchset is still open.

I cannot find any discussions about this.

Did you just miss pushing "keychain" patch, or was there a specific
reason why you hold it back?

Thanks,

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #19 received at 57253 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 57253 <at> debbugs.gnu.org, iyzsong <at> envs.net
Subject: Re: [bug#57253] [PATCH 2/2] gnu: Add keychain.
Date: Wed, 21 Sep 2022 23:52:54 +0200

[Message part 1 (text/plain, inline)]

On Wed, 21 Sep 2022 18:14:13 +0200
Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> wrote:

> Hi Denis,
> Hi iyzsong,
Hi,

> In commit 3220edac2a5ac816328bd65489513ae8d33fbe23, you pushed the
> first patch, but you missed this here, and the patchset is still open.
> 
> I cannot find any discussions about this.
> 
> Did you just miss pushing "keychain" patch, or was there a specific
> reason why you hold it back?
I think that someone needs to review it and to push it if it's OK.

The reason might be related to the fact that I sent two unrelated
patches in the same serie (I'm unsure how best to send unrelated
patches).

Denis.

[Message part 2 (application/pgp-signature, inline)]

Message #24 received at 57253-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: iyzsong <at> envs.net, 57253-done <at> debbugs.gnu.org
Subject: Re: [bug#57253] [PATCH 2/2] gnu: Add keychain.
Date: Thu, 22 Sep 2022 10:00:57 +0200

[Message part 1 (text/plain, inline)]

On Wed, 21 Sep 2022 23:52:54 +0200
Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> wrote:

> The reason might be related to the fact that I sent two unrelated
> patches in the same serie (I'm unsure how best to send unrelated
> patches).


OK. I reviewed it and pushed under

da3bbcc9916b08324e7b85f5b9c528b4696c39d4

with some slight changes:

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 3553415ad5..074fa5bf31 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -47,7 +47,6 @@ (define-module (gnu packages crypto)
   #:use-module (gnu packages aidc)
   #:use-module (gnu packages attr)
   #:use-module (gnu packages autotools)
-  #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -1716,9 +1715,9 @@ (define-public keychain
                (base32
                 "1bkjlg0a2bbdjhwp37ci1rwikvrl4s3xlbf2jq2z4azc96dr83mj"))))
     (build-system gnu-build-system)
-    (native-inputs (list bash))
+    (propagated-inputs (list procps))
     (arguments
-     `(#:tests? #f
+     `(#:tests? #f ; No test suite
        #:phases (modify-phases %standard-phases
                   (delete 'configure)
                   (replace 'install

* There is no need to use/import bash
* ps is required to find the agent, so I propagated procps
* Tests disabled because there are none. Commented about that fact.

Thanks,

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.