GNU bug report logs - #57291
New package: fftgen

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57291 in the body.
You can then email your comments to 57291 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: guix-patches <at> gnu.org
Subject: New package: fftgen
Date: Fri, 19 Aug 2022 01:18:41 +0200

Hi!

I've stumbled upon this beautiful little piece of software that let's
you generate FFT designs in Verilog.  Since it's free software I thought
I'd ready it up for my favorite distribution!

Thanks for merging!

gabriel


From 189ae40cb6104ac703f0171e32fe88208f9fcc25 Mon Sep 17 00:00:00 2001
From: Gabriel Wicki <gabriel <at> erlikon.ch>
Date: Fri, 19 Aug 2022 01:14:06 +0200
Subject: [PATCH] gnu: Add fftgen.

* gnu/packages/fpga.scm (fftgen): New variable.
---
 gnu/packages/fpga.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
index 06d4a10e7e..e1ae577c65 100644
--- a/gnu/packages/fpga.scm
+++ b/gnu/packages/fpga.scm
@@ -552,3 +552,34 @@ (define-public verilator
 performs the design simulation.  Verilator also supports linking its generated
 libraries, optionally encrypted, into other simulators.")
     (license license:lgpl3)))
+
+(define-public fftgen
+  (let ((commit "1d75a992efd0528edea128a903aafdabe133cb08")
+        (revision "0"))
+    (package
+      (name "fftgen")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/ZipCPU/dblclockfft")
+                      (commit commit)))
+                (file-name (git-file-name name
+                                          (string-take commit 8)))
+                (sha256
+                 (base32
+                  "0qq874yalzpjdwnxhc5df8a0ifywv29wcncb09945x56xplvkcmd"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f
+         #:phases (modify-phases %standard-phases
+                    (delete 'configure)
+                    (replace 'install
+                      (lambda* (#:key outputs #:allow-other-keys)
+                        (let ((bin (string-append (assoc-ref outputs "out")
+                                                  "/bin")))
+                          (install-file "sw/fftgen" bin) #t))))))
+      (synopsis "Generic Pipelined FFT Core Generator")
+      (description "fftgen produces FFT hardware designs in Verilog.")
+      (home-page "https://zipcpu.com/")
+      (license license:lgpl3))))
-- 
2.36.1

Message #10 received at 57291-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Gabriel Wicki <gabriel <at> erlikon.ch>
Cc: 57291-done <at> debbugs.gnu.org
Subject: Re: bug#57291: New package: fftgen
Date: Fri, 02 Sep 2022 17:29:49 +0200

[Message part 1 (text/plain, inline)]

Hi,

Gabriel Wicki <gabriel <at> erlikon.ch> skribis:

>>From 189ae40cb6104ac703f0171e32fe88208f9fcc25 Mon Sep 17 00:00:00 2001
> From: Gabriel Wicki <gabriel <at> erlikon.ch>
> Date: Fri, 19 Aug 2022 01:14:06 +0200
> Subject: [PATCH] gnu: Add fftgen.
>
> * gnu/packages/fpga.scm (fftgen): New variable.

Applied with the minor changes below, thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
index e1ae577c65..58b81bf83a 100644
--- a/gnu/packages/fpga.scm
+++ b/gnu/packages/fpga.scm
@@ -554,7 +554,7 @@ (define-public verilator
     (license license:lgpl3)))
 
 (define-public fftgen
-  (let ((commit "1d75a992efd0528edea128a903aafdabe133cb08")
+  (let ((commit "1d75a992efd0528edea128a903aafdabe133cb08") ;no releases
         (revision "0"))
     (package
       (name "fftgen")
@@ -564,22 +564,23 @@ (define-public fftgen
                 (uri (git-reference
                       (url "https://github.com/ZipCPU/dblclockfft")
                       (commit commit)))
-                (file-name (git-file-name name
-                                          (string-take commit 8)))
+                (file-name (git-file-name name version))
                 (sha256
                  (base32
                   "0qq874yalzpjdwnxhc5df8a0ifywv29wcncb09945x56xplvkcmd"))))
       (build-system gnu-build-system)
       (arguments
-       `(#:tests? #f
+       `(#:tests? #f                              ;no tests
+         #:make-flags '("CFLAGS=-g -O2")          ;default flags lack -O2
          #:phases (modify-phases %standard-phases
                     (delete 'configure)
                     (replace 'install
                       (lambda* (#:key outputs #:allow-other-keys)
                         (let ((bin (string-append (assoc-ref outputs "out")
                                                   "/bin")))
-                          (install-file "sw/fftgen" bin) #t))))))
-      (synopsis "Generic Pipelined FFT Core Generator")
-      (description "fftgen produces FFT hardware designs in Verilog.")
+                          (install-file "sw/fftgen" bin)))))))
+      (synopsis "Generic pipelined FFT core generator")
+      (description "fftgen produces @acronym{FFT, fast-Fourier transforms}
+hardware designs in Verilog.")
       (home-page "https://zipcpu.com/")
-      (license license:lgpl3))))
+      (license license:lgpl3+))))

Message #13 received at 57291 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Gabriel Wicki <gabriel <at> erlikon.ch>, 57291 <at> debbugs.gnu.org
Subject: Re: [bug#57291] New package: fftgen
Date: Fri, 2 Sep 2022 20:57:59 +0200

[Message part 1 (text/plain, inline)]

On 19-08-2022 01:18, Gabriel Wicki wrote:
> +                (file-name (git-file-name name
> +                                          (string-take commit 8)))

You don't have to string-take, the standard pattern is (git-file-name 
name version), as in (guix)Version Numbers.

> +       `(#:tests? #f
Why are tests disabled?  There is a bench-test target, maybe you need 
#:test-target "bench-test"? I hope that means "test bench" and not 
"benchmark" though.

On the license: some parts are GPL3+ (see: 
https://github.com/ZipCPU/dblclockfft/blob/master/sw/legal.h), that 
sounds important to add to the license field to me (license 
(license:lgpl3+ license:gpl3+)).

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #16 received at 57291 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 57291 <at> debbugs.gnu.org, ludo <at> gnu.org, gabriel <at> erlikon.ch
Subject: Re: bug#57291: New package: fftgen
Date: Fri, 2 Sep 2022 21:00:43 +0200

[Message part 1 (text/plain, inline)]

On 02-09-2022 17:29, Ludovic Courtès wrote:
> +         #:make-flags '("CFLAGS=-g -O2")          ;default flags lack -O2

I think (string-append "CXX=" #$(cxx-for-target)) is needed to, for 
cross-compilation.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.