GNU bug report logs - #57314
[PATCH] guix system: Use standard cross and native build options.

Previous Next

Package: guix-patches;

Reported by: Thiago Jung Bauermann <bauermann <at> kolabnow.com>

Date: Sun, 21 Aug 2022 06:12:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57314 in the body.
You can then email your comments to 57314 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#57314; Package guix-patches. (Sun, 21 Aug 2022 06:12:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Thiago Jung Bauermann <bauermann <at> kolabnow.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 21 Aug 2022 06:12:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: guix-patches <at> gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH] guix system: Use standard cross and native build options.
Date: Sun, 21 Aug 2022 03:11:24 -0300
This change prevents guix system from erroring out with an ugly backtrace
when it's passed an invalid value to the “--system” or “--target”
option. It also adds the “--list-systems” and “--list-targets” options.

The manual section about guix system doesn't mention the “--target” option,
so add it there.

* guix/scripts/system (show-help): Call show-cross-build-options-help and
show-native-build-options-help.
(%options): Remove own implementation of “system” and “target” options and
use the ones in %standard-cross-build-options and
%standard-native-build-options.
* doc/guix.texi (Invoking guix system): Document “--target” option.
---
 doc/guix.texi           |  5 +++++
 guix/scripts/system.scm | 16 +++++++---------
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 023b48ae3507..e8f05ffdeb51 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -37533,6 +37533,11 @@ Installation Image}).
 Attempt to build for @var{system} instead of the host system type.
 This works as per @command{guix build} (@pxref{Invoking guix build}).
 
+@item --target=@var{triplet}
+Cross-build for @var{triplet}, which must be a valid GNU triplet, such
+as @code{"aarch64-linux-gnu"} (@pxref{Specifying target triplets, GNU
+configuration triplets,, autoconf, Autoconf}).
+
 @item --derivation
 @itemx -d
 Return the derivation file name of the given operating system without
diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
index be6e83994100..443e9d3282fc 100644
--- a/guix/scripts/system.scm
+++ b/guix/scripts/system.scm
@@ -1046,6 +1046,10 @@ (define (show-help)
                          for 'describe' and 'list-generations', list installed
                          packages matching REGEXP"))
   (newline)
+  (show-cross-build-options-help)
+  (newline)
+  (show-native-build-options-help)
+  (newline)
   (display (G_ "
   -h, --help             display this help and exit"))
   (display (G_ "
@@ -1136,14 +1140,6 @@ (define %options
                    (let ((level (string->number* arg)))
                      (alist-cons 'verbosity level
                                  (alist-delete 'verbosity result)))))
-         (option '(#\s "system") #t #f
-                 (lambda (opt name arg result)
-                   (alist-cons 'system arg
-                               (alist-delete 'system result eq?))))
-         (option '("target") #t #f
-                 (lambda (opt name arg result)
-                   (alist-cons 'target arg
-                               (alist-delete 'target result eq?))))
          (option '(#\r "root") #t #f
                  (lambda (opt name arg result)
                    (alist-cons 'gc-root arg result)))
@@ -1153,7 +1149,9 @@ (define %options
          (option '(#\I "list-installed") #f #t
                  (lambda (opt name arg result)
                    (alist-cons 'list-installed (or arg "") result)))
-         %standard-build-options))
+         (append %standard-build-options
+                 %standard-cross-build-options
+                 %standard-native-build-options)))
 
 (define %default-options
   ;; Alist of default option values.




Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Tue, 30 Aug 2022 06:57:01 GMT) Full text and rfc822 format available.

Notification sent to Thiago Jung Bauermann <bauermann <at> kolabnow.com>:
bug acknowledged by developer. (Tue, 30 Aug 2022 06:57:01 GMT) Full text and rfc822 format available.

Message #10 received at 57314-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Cc: 57314-done <at> debbugs.gnu.org
Subject: Re: bug#57314: [PATCH] guix system: Use standard cross and native
 build options.
Date: Tue, 30 Aug 2022 08:56:40 +0200
Hello Thiago,

> This change prevents guix system from erroring out with an ugly backtrace
> when it's passed an invalid value to the “--system” or “--target”
> option. It also adds the “--list-systems” and “--list-targets” options.
>
> The manual section about guix system doesn't mention the “--target” option,
> so add it there.

Looks nice, pushed!

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#57314; Package guix-patches. (Wed, 31 Aug 2022 05:17:02 GMT) Full text and rfc822 format available.

Message #13 received at 57314-done <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 57314-done <at> debbugs.gnu.org
Subject: Re: bug#57314: [PATCH] guix system: Use standard cross and native
 build options.
Date: Wed, 31 Aug 2022 02:16:03 -0300
Hello Mathieu,

Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Hello Thiago,
>
>> This change prevents guix system from erroring out with an ugly backtrace
>> when it's passed an invalid value to the “--system” or “--target”
>> option. It also adds the “--list-systems” and “--list-targets” options.
>>
>> The manual section about guix system doesn't mention the “--target” option,
>> so add it there.
>
> Looks nice, pushed!

Thank you!

-- 
Thiago




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 28 Sep 2022 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 182 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.