GNU bug report logs - #57365
[PATCH] gnu: guile-smc: Update to 0.5.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57365 in the body.
You can then email your comments to 57365 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: guile-smc: Update to 0.5.0
Date: Tue, 23 Aug 2022 21:45:32 +0300

[Message part 1 (text/plain, inline)]

Hello,

this patch updates Guile-SMC[1] to 0.5.0.

[0001-gnu-guile-smc-Update-to-0.5.0.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

- Artyom

References:
1. https://github.com/artyom-poptsov/guile-smc

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 57365 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 57365 <at> debbugs.gnu.org
Subject: Re: bug#57365: [PATCH] gnu: guile-smc: Update to 0.5.0
Date: Fri, 26 Aug 2022 15:34:36 +0200

Hey Artyom,

> -              (string-append
> -               "(add-handler! %logger\n"
> -               "              (make <rotating-log>\n"
> -               "                    #:file-name \"smc.log\"))\n")))
> -             #t))
> +               (("\\(add-handler! %logger %syslog\\)")
> +                (string-append
> +                 "(add-handler! %logger\n"
> +                 "              (make <port-log/us>\n"
> +                 "                    #:port (open-file \"/tmp/smc.log\" \"a+\")))\n")))))

What is this patch about? Can't it be upstreamed?

> +     (list autoconf automake pkg-config texinfo help2man))

You need to describe it in the commit message:

[native-inputs]: Add help2man.

> +     (list bash-minimal
> +           guile-3.0
> +           guile-lib
> +           inetutils))

Ditto:

[inputs]: Use the new inputs style.

Can you send an updated patch?

Thanks,

Mathieu

Message #11 received at 57365 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 57365 <at> debbugs.gnu.org
Subject: Re: bug#57365: [PATCH] gnu: guile-smc: Update to 0.5.0
Date: Sat, 27 Aug 2022 06:15:59 +0300

[Message part 1 (text/plain, inline)]

Hello Mathieu,

Thanks for my patch review!

> What is this patch about? Can't it be upstreamed?

As you can see from the package description of Guile-SMC 0.3.0 there was
already a problem with logging; I just tried to fix that patch for the
current release.

Guile-SMC tries to log to the syslog by default but it seems that this
option is not working in Guix, so we need another way to log the
messages.  Or it may be that I just overlooked something.

I wasn't able to use "<rotating-log>" anymore as Guile-SMC now uses
custom microsecond-resolution logging backend (which is required for the
FSM profiler to work properly.)  The problem is that this backend does
not work well with "<rotating-log>".  With the new snipped Guile-SMC
uses its "<port-log/us>" class to log the messages to
"/tmp/smc.log.<number>" file.

I wish we had more advanced logging functionality in GNU Guile core
modules but that a discussion for another thread I think.

For now I agree that this snipped looks a bit hacky but that is the
solution a I came up with trying to fix things fast.

If you have any ideas on how to improve the snippet (or the logging in
Guile-SMC for that matter), I'm all ears.

Meanwhile I try to do something with Guile-SMC logging myself.

> You need to describe it in the commit message:
>
> [native-inputs]: Add help2man.

> Ditto:
>
> [inputs]: Use the new inputs style.

Done.

Here's the updated patch.

[0001-gnu-guile-smc-Update-to-0.5.0.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 57365 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Mathieu Othacehe <othacehe <at> gnu.org>,
 "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 57365 <at> debbugs.gnu.org
Subject: Re: [bug#57365] [PATCH] gnu: guile-smc: Update to 0.5.0
Date: Sat, 27 Aug 2022 09:54:47 +0200

[Message part 1 (text/plain, inline)]

On 26-08-2022 15:34, Mathieu Othacehe wrote:
> +               (("\\(add-handler! %logger %syslog\\)")
> +                (string-append
> +                 "(add-handler! %logger\n"
> +                 "              (make <port-log/us>\n"
> +                 "                    #:port (open-file \"/tmp/smc.log\" \"a+\")))\n")))))

When is this /tmp/smc.log used? When compiling guile-smc or when running 
guile-smc?

If the latter, an attacker on a multi-user system could use it to make 
you append to files the attacker ordinarily doesn't have access to -- 
consider guile-smc being in a process as root and the attacker creating 
/tmp/smc.log as a symlink to /etc/passwd first, depending on what was 
logged, there is now an additional entry in there or its corrupted, 
preventing booting.

> Guile-SMC tries to log to the syslog by default but it seems that this
> option is not working in Guix, so we need another way to log the
> messages.  Or it may be that I just overlooked something.
I do think it works, at least there are plenty of mentions of 'syslog' 
in the Guix repository. However, possibly the build container forbids 
access (unverified), maybe for running tests you need a different logger.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #17 received at 57365 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 57365 <at> debbugs.gnu.org
Subject: Re: bug#57365: [PATCH] gnu: guile-smc: Update to 0.5.0
Date: Fri, 02 Sep 2022 09:20:13 +0300

[Message part 1 (text/plain, inline)]

Hello,

I released Guile-SMC 0.5.2:
  https://lists.gnu.org/archive/html/guile-user/2022-09/msg00002.html

And Guile-INI 0.5.1:
  https://lists.gnu.org/archive/html/guile-user/2022-09/msg00003.html

So I updated both Guile-SMC and Guile-INI package definitions
accordingly.

Not sure if I should create a new thread in the mailing list for this.

For now please find updated patches attached below.

[0001-gnu-guile-smc-Update-to-0.5.2.patch (text/x-diff, attachment)]

[0002-gnu-guile-ini-Update-to-0.5.1.patch (text/x-diff, attachment)]

[Message part 4 (text/plain, inline)]

Thanks,

- Artyom
  
-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 57365-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 57365-done <at> debbugs.gnu.org
Subject: Re: bug#57365: [PATCH] gnu: guile-smc: Update to 0.5.0
Date: Fri, 02 Sep 2022 09:38:15 +0200

Hey Artyom,

> Not sure if I should create a new thread in the mailing list for this.
>
> For now please find updated patches attached below.

It's great that you found a way to deal with logging. Guile-SMC looks
fun, can't wait to test it :).

Pushed both patches.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.