GNU bug report logs - #57400
29.0.50; Support sending patches from VC directly

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Antoine Kalmbach <ane@HIDDEN>; dated Thu, 25 Aug 2022 08:49:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 27 Aug 2022 09:21:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 27 05:21:00 2022
Received: from localhost ([127.0.0.1]:55185 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRrzw-0005OJ-A8
	for submit <at> debbugs.gnu.org; Sat, 27 Aug 2022 05:21:00 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45588)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oRrzu-0005O5-H0
 for 57400 <at> debbugs.gnu.org; Sat, 27 Aug 2022 05:20:59 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59206)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRrzp-0000SL-3h; Sat, 27 Aug 2022 05:20:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=bfmgng26w30d7WAiCf4+Unka1PpTacOm+0104xvwCFI=; b=CRCsTjTjx2Kh
 PGfvEdq4Lu7RirXYnMmtTZkBG6npgj5qC0pgnT/8MAQeoxI9rzHUYaEJuUkfaNTPRprx9/P01wKTk
 DFeGD9r/ozNhqLgc0guxZRHdTirg4z0ac/KZs8H8j1NZ38EHvSb1UXTmO1TolOGEMzp64+m9e9HVF
 QPk1cacav/trYyGmQhEFvMZHrpGwOHFfHrMHmgJWY8Yd1IqzsBzVoWYmMxpKAPajvHXHspAmReaRt
 mOJ4yfUJAcLKze1DjXByy/ow4GQzN2Zfy6Zk4gy0lz+LQNdO84AlPphH1r885gLgVFCG/wTdrtvgQ
 /OFs+/KCXt/xSXpcgU9U1g==;
Received: from [87.69.77.57] (port=2782 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRrzo-0002Np-HK; Sat, 27 Aug 2022 05:20:52 -0400
Date: Sat, 27 Aug 2022 12:21:08 +0300
Message-Id: <83zgfqyrcr.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <87v8qecd0v.fsf@HIDDEN> (message from Philip Kaludercic on
 Sat, 27 Aug 2022 08:21:36 +0000)
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
 <87tu5zky6k.fsf@HIDDEN> <83lerb197w.fsf@HIDDEN>
 <87y1vbjfpp.fsf@HIDDEN> <83h71z13xc.fsf@HIDDEN>
 <87v8qecd0v.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org, ane@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Philip Kaludercic <philipk@HIDDEN>
> Cc: ane@HIDDEN,  57400 <at> debbugs.gnu.org
> Date: Sat, 27 Aug 2022 08:21:36 +0000
> 
> But there are plenty of projects that will only accept patches
> formatted and sent by "git send-email".  If you send them an attachment
> with a patch, they might complain and ask you to send it back again
> using "git send-email".
> 
> Once again, I don't think we disagree on anything substantial here.  You
> have already said that it is fine to implement support for both, and
> everything beyond that should not matter for the proposal.

So why are we still arguing?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 27 Aug 2022 08:21:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 27 04:21:47 2022
Received: from localhost ([127.0.0.1]:55114 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRr4d-0003tW-62
	for submit <at> debbugs.gnu.org; Sat, 27 Aug 2022 04:21:47 -0400
Received: from mout01.posteo.de ([185.67.36.65]:45001)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1oRr4b-0003tC-8B
 for 57400 <at> debbugs.gnu.org; Sat, 27 Aug 2022 04:21:45 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 8FCDB240026
 for <57400 <at> debbugs.gnu.org>; Sat, 27 Aug 2022 10:21:39 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1661588499; bh=X0pIJ1jvqVDNvEICBGFS+z1IPgEiq6yRRJmNQyzNWW8=;
 h=From:To:Cc:Subject:Autocrypt:Date:From;
 b=PeUF7VIoHMK3mcCMtHLN3DE8g7+/N4G8u7Bj1cw+NPiXVU8dmlcZzAduwy56AMs5Z
 1/4PmOZ7628Xc/lmP6h/Foo9b+El5AE3ry75SJF2XAF55qffwQp9mR3Vo0E/XRlIFs
 yc1HV7LwcBBPCjh7nePnlI/LbnqtDjr9789U4InY/YDxhgNgO2mPsSFsVqgipcOFz8
 ZKMWoFB5HDGgMF6s+upvY7fbYp8fpflzVP+c49MGxv2PBqfrg4oSLRfGVZZUDIqOtQ
 29feAY0DOL/7YRlZN9ds+UCkXHQttZJIIFkU96zK0Y2nDXtN+pK8kNTQGIzOjabJbC
 6rNQTCcDjw/ow==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4MF8my3Q3sz6trK;
 Sat, 27 Aug 2022 10:21:37 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <83h71z13xc.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 26 Aug
 2022 17:21:19 +0300")
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
 <87tu5zky6k.fsf@HIDDEN> <83lerb197w.fsf@HIDDEN>
 <87y1vbjfpp.fsf@HIDDEN> <83h71z13xc.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; prefer-encrypt=nopreference; keydata=
 mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ
 CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh
 io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF
 AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo
 Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS
 g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB
Date: Sat, 27 Aug 2022 08:21:36 +0000
Message-ID: <87v8qecd0v.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org, ane@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii <eliz@HIDDEN> writes:

>
>> From: Philip Kaludercic <philipk@HIDDEN>
>> Cc: ane@HIDDEN,  57400 <at> debbugs.gnu.org
>> Date: Fri, 26 Aug 2022 13:29:22 +0000
>> 
>> >> Only if the MUA can recognise the patch and pipe it into a git am
>> >> process.
>> >
>> > What do you mean by "MUA can recognize" here? which Emacs MUA
>> > recognizes Git-formatted patches and applies them?
>> 
>> The MUA recognizes the patch as a an attachment.  E.g. in Gnus the patch
>> is highlighted and "|" is bound to a command that pipes the contents of
>> the attachment through a command.
>> 
>> > What I do is invoke "M-|" and send the region to "git am".  That
>> > requires myself to recognize the patches, not the MUA I use.
>> 
>> I hadn't considered that, but again, if we are thinking about preparing
>> messages that are sent out to other developers using other MUAs, then I
>> don't know if this kind of functionality is available.
>
> I fail to see how other MUAs used by other developers are relevant
> here.  We are talking about sending patches, not receiving them.
> Sending them as attachments is a known, and frequently required or
> preferred, technique.  How the patches are handled on the receiving
> end is a separate problem, but it already has its solution, because
> people send patches as attachments all over the place.

But there are plenty of projects that will only accept patches
formatted and sent by "git send-email".  If you send them an attachment
with a patch, they might complain and ask you to send it back again
using "git send-email".

Once again, I don't think we disagree on anything substantial here.  You
have already said that it is fine to implement support for both, and
everything beyond that should not matter for the proposal.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 14:21:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 10:21:16 2022
Received: from localhost ([127.0.0.1]:54219 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRaCx-00052e-KY
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 10:21:15 -0400
Received: from eggs.gnu.org ([209.51.188.92]:58244)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oRaCv-00052P-6K
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 10:21:13 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:36196)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRaCp-0005W5-GZ; Fri, 26 Aug 2022 10:21:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=8+GkyZOSosE94pQSq0RvUlS8q03RX3uTXXNTPmRQJpE=; b=NtThQO80RVHC
 FyDO56Qvw/d6jQ+gKWSRkFBhRBOz3zqP521kmhXEErkkRX+QRu9OilnOFxqzL20xWkRimVSR3sndO
 ZJqegBP0VPZsR7SS+1VsNn5cKEVDxzL5Q4bQuRKRkGUmTXzolNJu6Uo0gANsFagPt62zdLsiUJvwJ
 f71pXd1Nmy/SHfiMSpnkVCFJjKi7xQTtbz7hyzSJGVA56gtpC1oAHB3PLB+BxxRhaS6bz7t1jrAMZ
 O6/P/Jg+SQNYc2INmWdvUrEAUIvjeTCSpvocJm/VV+tX0LMXuPS7UQKSQul5A5PMhX+9cmX9Xgc2s
 CQll4o1x8W5Dakx0/qInKw==;
Received: from [87.69.77.57] (port=4713 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRaCo-0002RM-St; Fri, 26 Aug 2022 10:21:07 -0400
Date: Fri, 26 Aug 2022 17:21:19 +0300
Message-Id: <83h71z13xc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <87y1vbjfpp.fsf@HIDDEN> (message from Philip Kaludercic on
 Fri, 26 Aug 2022 13:29:22 +0000)
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
 <87tu5zky6k.fsf@HIDDEN> <83lerb197w.fsf@HIDDEN>
 <87y1vbjfpp.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org, ane@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Philip Kaludercic <philipk@HIDDEN>
> Cc: ane@HIDDEN,  57400 <at> debbugs.gnu.org
> Date: Fri, 26 Aug 2022 13:29:22 +0000
> 
> >> Only if the MUA can recognise the patch and pipe it into a git am
> >> process.
> >
> > What do you mean by "MUA can recognize" here? which Emacs MUA
> > recognizes Git-formatted patches and applies them?
> 
> The MUA recognizes the patch as a an attachment.  E.g. in Gnus the patch
> is highlighted and "|" is bound to a command that pipes the contents of
> the attachment through a command.
> 
> > What I do is invoke "M-|" and send the region to "git am".  That
> > requires myself to recognize the patches, not the MUA I use.
> 
> I hadn't considered that, but again, if we are thinking about preparing
> messages that are sent out to other developers using other MUAs, then I
> don't know if this kind of functionality is available.

I fail to see how other MUAs used by other developers are relevant
here.  We are talking about sending patches, not receiving them.
Sending them as attachments is a known, and frequently required or
preferred, technique.  How the patches are handled on the receiving
end is a separate problem, but it already has its solution, because
people send patches as attachments all over the place.

> >> But if we are trying to re-create the behaviour of "git
> >> send-email" (as I think is necessary if we want the feature to be of use
> >> outside of Emacs circles, such as sending a patch to the Linux Kernel
> >> Mailing List), then we need to consider people using clients like Mutt
> >> or Aerc (https://aerc-mail.org/) that just pipe the entire message
> >> through "git am".
> >
> > Do you intend to provide a VC front-end to applying the patch-set, as
> > part of this job?  Because if not, what happens on the receiving end
> > is out of the scope of the feature we are discussing.
> 
> No, this is just about sending patches, but if the patches sent out are
> of no use to the developers receiving them, then the feature is not as
> useful as it could be.

They cannot be "of no use", because these practices are already in
use, regardless of whether Emacs does or doesn't support them.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 13:29:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 09:29:41 2022
Received: from localhost ([127.0.0.1]:52726 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRZP3-0003FF-7A
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 09:29:41 -0400
Received: from mout01.posteo.de ([185.67.36.65]:39965)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1oRZP0-0003F1-Pm
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 09:29:39 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id E9E9F240027
 for <57400 <at> debbugs.gnu.org>; Fri, 26 Aug 2022 15:29:30 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1661520572; bh=/KExMXW469SfSsKOCSvgCt7yeNANQktNhFk3ZGF/jEQ=;
 h=From:To:Cc:Subject:Autocrypt:Date:From;
 b=IRb8y/RCRw/+AKBehFvxmqSBh8yRzAINbDKj7bhxAamjl62QHW1iSdf3TGqLutpRl
 tTOCCXaCDutw/IerIlzRCUsJvbzLQK8OfHhEMWfMYos0fYvZoAmvYu6lh/zRbFzxy7
 1x+lwjc8xWmjGw7Cg+H6yCRenpYKzjYBgM0tf3pYUrsRS/S/I4I9v6f+hAnR8LVrgQ
 1dls/noQvu5KLV5RViP0CgHcaLiO/ejwotGeNU96Sc1rmo+C+YEHsxS0mvxYIHzWGE
 4p9YydXX+jD773jBicyylMUq3JEF7nncQzEepyViA/N8vwWRQmyq2hqvIUHkhjTRjh
 o40RDYU9kNftA==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4MDgfd4W8Zz9rxK;
 Fri, 26 Aug 2022 15:29:27 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <83lerb197w.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 26 Aug
 2022 15:26:59 +0300")
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
 <87tu5zky6k.fsf@HIDDEN> <83lerb197w.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; prefer-encrypt=nopreference; keydata=
 mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ
 CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh
 io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF
 AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo
 Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS
 g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB
Date: Fri, 26 Aug 2022 13:29:22 +0000
Message-ID: <87y1vbjfpp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org, ane@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii <eliz@HIDDEN> writes:

>
>> From: Philip Kaludercic <philipk@HIDDEN>
>> Cc: ane@HIDDEN,  57400 <at> debbugs.gnu.org
>> Date: Fri, 26 Aug 2022 12:05:07 +0000
>> 
>> >> > Also, I'm not sure why we'd need to send each patch file separately.
>> >> > Why not add them one by one as attachments to the same email message?
>> >> 
>> >> This wouldn't work if we are sending patches to a mailing list that
>> >> assumes patches are sent out by git send-email, and that the messages
>> >> can be filtered through git am.
>> >
>> > "git am" handles attachments without any problems, I do it all the
>> > time.
>> 
>> Only if the MUA can recognise the patch and pipe it into a git am
>> process.
>
> What do you mean by "MUA can recognize" here? which Emacs MUA
> recognizes Git-formatted patches and applies them?

The MUA recognizes the patch as a an attachment.  E.g. in Gnus the patch
is highlighted and "|" is bound to a command that pipes the contents of
the attachment through a command.

> What I do is invoke "M-|" and send the region to "git am".  That
> requires myself to recognize the patches, not the MUA I use.

I hadn't considered that, but again, if we are thinking about preparing
messages that are sent out to other developers using other MUAs, then I
don't know if this kind of functionality is available.

>> But if we are trying to re-create the behaviour of "git
>> send-email" (as I think is necessary if we want the feature to be of use
>> outside of Emacs circles, such as sending a patch to the Linux Kernel
>> Mailing List), then we need to consider people using clients like Mutt
>> or Aerc (https://aerc-mail.org/) that just pipe the entire message
>> through "git am".
>
> Do you intend to provide a VC front-end to applying the patch-set, as
> part of this job?  Because if not, what happens on the receiving end
> is out of the scope of the feature we are discussing.

No, this is just about sending patches, but if the patches sent out are
of no use to the developers receiving them, then the feature is not as
useful as it could be.

>> > But I don't object to having optional behaviors here.  My point is
>> > that we should allow sending all the patches together, as that is the
>> > preferred/usual practice in Emacs development.
>> 
>> Of course, the idea that was proposed on emacs-devel was to have this
>> behaviour be controlled by a (file-local) variable that could be set on
>> a per-project basis.
>
> We should have a user option that doesn't require project.el
> (project.el can override it, of course).  There should be no
> requirement to use project.el to send patches from VC.

There should be no need for project.el, this could just be set in dir
.dir-locals.el file in emacs.git.

But I don't think there is an actual issue here, the plan has been all
along to provide both kinds of patches (git am-style, attached) to be
sent out.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 13:17:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 09:17:07 2022
Received: from localhost ([127.0.0.1]:52670 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRZCq-0002uJ-KT
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 09:17:07 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43196)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oRZCl-0002tj-HY
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 09:17:03 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:60084)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRZCg-0003FZ-8U; Fri, 26 Aug 2022 09:16:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=6hMsKX2V3qmNAJWOZyuSAjBsm/lzrjPQZ/+zH90fLh4=; b=QDjl9SoLZ4FD
 AtLPRjFMq0vFaN4fgxYkO1RiLUmfEf6wHEQbdd/asaIyOcWsIMQoMRW/NEZJcVRA2VoI0J3dRjeoK
 1OOPDaroaIsD6Warw+Oeu+uMbZmQgDgwRMHdzdP85MSv2teJJZCPVQCOg4tlwsyGVinlh/aNwFuqt
 HIrx20RjNpWV0W+XEkCGwWsTxu/2X4y8IBpPw7BEQOkQpDmwZgDOQQU3Gkki6uixKpT9es7n5pWUh
 Sk6+l1wIgQ8lRe/BEvRFm2L4v8/TiA0nd4IRZjXZVirgQwxcZAIj6lY2E69kpeKe6TqhF2coj3R1h
 A+BUDWkbGpdQRlL0fyJkGw==;
Received: from [87.69.77.57] (port=4774 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRZCf-0004el-O8; Fri, 26 Aug 2022 09:16:54 -0400
Date: Fri, 26 Aug 2022 16:17:07 +0300
Message-Id: <83ilmf16wc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Antoine Kalmbach <ane@HIDDEN>
In-Reply-To: <lya67rrvz1.fsf@HIDDEN> (message from Antoine Kalmbach on Fri, 26
 Aug 2022 16:10:58 +0300)
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
 <87tu5zky6k.fsf@HIDDEN> <83lerb197w.fsf@HIDDEN> <lya67rrvz1.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: philipk@HIDDEN, 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Antoine Kalmbach <ane@HIDDEN>
> Cc: 57400 <at> debbugs.gnu.org
> Date: Fri, 26 Aug 2022 16:10:58 +0300
> 
> > What I do is invoke "M-|" and send the region to "git am".  That
> > requires myself to recognize the patches, not the MUA I use.
> 
> If the patch is attached, you open the patch, mark it, and then M-| git
> am, right?

Yes (modulo "cd .." to the right directory).

> The standard Git approach is to just pipe the whole message,
> expecting the patch to be in the email directly.

The patch attachments can all be shown inline, since they are text,
and then you can pipe the entire message, yes.

> Or even with attachments, can you actually mark the whole email buffer
> and pipe that? 

I think I once did that, and it worked.  Not sure.

But if you intend to provide/improve what happens on the receiving end
as well, then Emacs could filter the irrelevant parts from what it
sends down the "git am" pipe.

> > Do you intend to provide a VC front-end to applying the patch-set, as
> > part of this job?  Because if not, what happens on the receiving end
> > is out of the scope of the feature we are discussing.
> 
> Having a complementary `vc-apply-patch` wouldn't be a bad idea, but
> I think we should do the sending part first. 

Fine by me.

> > We should have a user option that doesn't require project.el
> > (project.el can override it, of course).  There should be no
> > requirement to use project.el to send patches from VC.
> 
> I think Philip means directory-local variables, not project.el.

Once we have an option, it can be included in directory-local
variables, right?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 13:11:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 09:11:08 2022
Received: from localhost ([127.0.0.1]:52664 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRZ75-0002kk-Qa
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 09:11:08 -0400
Received: from meesny.iki.fi ([195.140.195.201]:35572)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ane@HIDDEN>) id 1oRZ70-0002kH-35
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 09:11:06 -0400
Received: from qfinm256.local (unknown [66.159.213.92])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested) (Authenticated sender: ane)
 by meesny.iki.fi (Postfix) with ESMTPSA id 4E8BE200BF;
 Fri, 26 Aug 2022 16:10:59 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny;
 t=1661519460;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=OblYlGQm2sjzpdxUde/M1vQxHVUlqdFYPi5Xq0Kx5e4=;
 b=hY0UcjH0UBCh32mpQmJCZ4GFaaMEzjVwu5Z5/Q0zBfqBz+UhWzp6vLf6B2/FzK4ACJ296d
 EupWg8S13WyNJJKnp6WGA+3AtNvk1iHIJZ94xE8QUGk9H3x60GOF/ESqzB7EKbyPnADftR
 AHaqDhjHe0ffhL8063pvsQZFR7Gap1w=
From: Antoine Kalmbach <ane@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <83lerb197w.fsf@HIDDEN>
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
 <87tu5zky6k.fsf@HIDDEN> <83lerb197w.fsf@HIDDEN>
Date: Fri, 26 Aug 2022 16:10:58 +0300
Message-ID: <lya67rrvz1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi;
 s=meesny; t=1661519460;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=OblYlGQm2sjzpdxUde/M1vQxHVUlqdFYPi5Xq0Kx5e4=;
 b=jTcdTRay/HRCeJHLGc2lXpNAp/xRwp3odkyQXRnGcliEIs1IbsGjLIFrZ+jv0hn79LKCUM
 L4VGYX10O7fX2pSDgWz5xAPYbiRLV8sifuCccMYv2tALh4lzHtwqJzbL8x5uroonGXZ9CB
 h7zbw1dhs8siG127PbbiqLfOgEAmJ0U=
ARC-Authentication-Results: i=1; ORIGINATING;
 auth=pass smtp.auth=ane smtp.mailfrom=ane@HIDDEN
ARC-Seal: i=1; s=meesny; d=iki.fi; t=1661519460; a=rsa-sha256; cv=none;
 b=yeiWVAlWMkkDpsTK5IHpmqbyFx6VNqb5modI4nJMtF7ksjOVSRoBx849XSnNSCbvQXM1+L
 hK/lEtAVEtJyZJBbAHzhXqMrPunioQpVxa2+Yl4CkpgcSkHQ6Ch8zgBVaFvqOhhDoH45pz
 2NFjzIL3SQvBZEWiGFnDOTTKsBg+5FI=
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Only if the MUA can recognise the patch and pipe it into a git am
>> process.
>
> What do you mean by "MUA can recognize" here? which Emacs MUA
> recognizes Git-formatted patches and applies them?

I don't think any does.  Insofar as Mutt and Aerc are concerned, all they
provide is functionality for syntax highlighting the diff and then a
command for piping the message.  Emacs can do, and does, both of
those. (At least Gnus highlights patch blocks.)

> What I do is invoke "M-|" and send the region to "git am".  That
> requires myself to recognize the patches, not the MUA I use.

If the patch is attached, you open the patch, mark it, and then M-| git
am, right? The standard Git approach is to just pipe the whole message,
expecting the patch to be in the email directly.

Or even with attachments, can you actually mark the whole email buffer
and pipe that? 

> Do you intend to provide a VC front-end to applying the patch-set, as
> part of this job?  Because if not, what happens on the receiving end
> is out of the scope of the feature we are discussing.
>

Having a complementary `vc-apply-patch` wouldn't be a bad idea, but
I think we should do the sending part first. 

>
> We should have a user option that doesn't require project.el
> (project.el can override it, of course).  There should be no
> requirement to use project.el to send patches from VC.

I think Philip means directory-local variables, not project.el.

-- 
Antoine Kalmbach




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 12:28:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 08:28:31 2022
Received: from localhost ([127.0.0.1]:52583 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRYRr-0003Si-Gv
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 08:28:31 -0400
Received: from eggs.gnu.org ([209.51.188.92]:51146)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oRYRq-0003SU-Jz
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 08:28:30 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:43308)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRYRk-0001qk-Jh; Fri, 26 Aug 2022 08:28:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=+4C2I85h2nxFR/yQ0V8X8mczO6C4+/KDeTDxJNhevUU=; b=MxiYE3zmgNXz
 CN4zbcXHqEE3UA24ZUzkzr0b14zS4E9N4cjTwmgZPKOvfsIR7UHqKAGR28kC3YGZvH8hmnCBz7Mjz
 PcKj3SoLX5TvMgxGaqXust1bl6lFuwvw/Qcl15JRPBr8T5+h/Im2W+QxGKZLVymgzXyda0eONag/Y
 cOwbIRFE8r/Jep7L3C3D1KB2E8DGA8babOlXKRP5otNDJaliPYZGEgl2iFyFxgfZHkAOWXHSTkkqj
 VS88iH9ozshG0fvA7Xg6hKZwK1m/VG+AtXdd+rPM50TeEIT6iwlTNYG0tlAkJ7XlJo5j0Mo4iCliS
 fmgQOrmhLC6YU+XzJs5WSA==;
Received: from [87.69.77.57] (port=4551 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRYRj-0002cM-4g; Fri, 26 Aug 2022 08:28:23 -0400
Date: Fri, 26 Aug 2022 15:28:36 +0300
Message-Id: <83k06v1957.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Antoine Kalmbach <ane@HIDDEN>
In-Reply-To: <lyedx3ryvy.fsf@HIDDEN> (message from Antoine Kalmbach on Fri, 26
 Aug 2022 15:08:01 +0300)
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN> <lyedx3ryvy.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: philipk@HIDDEN, 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Antoine Kalmbach <ane@HIDDEN>
> Cc: 57400 <at> debbugs.gnu.org
> Date: Fri, 26 Aug 2022 15:08:01 +0300
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >> > Also, I'm not sure why we'd need to send each patch file separately.
> >> > Why not add them one by one as attachments to the same email message?
> >> 
> >> This wouldn't work if we are sending patches to a mailing list that
> >> assumes patches are sent out by git send-email, and that the messages
> >> can be filtered through git am.
> >
> > "git am" handles attachments without any problems, I do it all the
> > time.
> 
> But you have to save the attached .patch files and then run git am on
> those.

No, I just use M-| from Emacs.

> > But I don't object to having optional behaviors here.  My point is
> > that we should allow sending all the patches together, as that is the
> > preferred/usual practice in Emacs development.
> 
> Yes, but users would have to apply the customization to get the Emacs
> way of working, I think.  

You are now arguing about the default value of that option?  Let's
delay that until the feature is done and the option is available,
okay?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 12:27:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 08:27:05 2022
Received: from localhost ([127.0.0.1]:52578 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRYQS-0003QN-Rp
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 08:27:05 -0400
Received: from eggs.gnu.org ([209.51.188.92]:52826)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oRYQJ-0003Ph-7U
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 08:27:03 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:48598)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRYQC-0001Su-2J; Fri, 26 Aug 2022 08:26:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=j75ebuoETUl5EB6MMwv1Ny3z9GHtem4fflJ+w5LTwag=; b=CXAJ2wUOD2LS
 x6MKWN9IEjJplh4NdXNLTU8mHOfv0rRyth7cYL0W3ylrpDF7urqQtHFbyUkfpxjWVrZRh0sAJIoBj
 CJKG0Anf/MnU1tbcAB9/iV1fWeaA864v0I7GwjvrQyHf1rpdR4hihgk5yhwAB9j+CbPE8DBoGpp+E
 aBS9Iq3Ri9W8eK8s6EJeKNPd1ZyziOwnXMmsrydb6KvT/RBFY+vboffKVTEdu/kCgxCHZ/ci0AID1
 jUM0LvlLX2dFuVU0AxMJ8OowU6NYJXSfpO15Inn1F2D+P6tptohOjlpJC6X2oWSmuujEL05dWhN4W
 /zKMjnNJc0N4CznpFmy4xQ==;
Received: from [87.69.77.57] (port=4450 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRYQA-0008Dg-NI; Fri, 26 Aug 2022 08:26:47 -0400
Date: Fri, 26 Aug 2022 15:26:59 +0300
Message-Id: <83lerb197w.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <87tu5zky6k.fsf@HIDDEN> (message from Philip Kaludercic on
 Fri, 26 Aug 2022 12:05:07 +0000)
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
 <87tu5zky6k.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org, ane@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Philip Kaludercic <philipk@HIDDEN>
> Cc: ane@HIDDEN,  57400 <at> debbugs.gnu.org
> Date: Fri, 26 Aug 2022 12:05:07 +0000
> 
> >> > Also, I'm not sure why we'd need to send each patch file separately.
> >> > Why not add them one by one as attachments to the same email message?
> >> 
> >> This wouldn't work if we are sending patches to a mailing list that
> >> assumes patches are sent out by git send-email, and that the messages
> >> can be filtered through git am.
> >
> > "git am" handles attachments without any problems, I do it all the
> > time.
> 
> Only if the MUA can recognise the patch and pipe it into a git am
> process.

What do you mean by "MUA can recognize" here? which Emacs MUA
recognizes Git-formatted patches and applies them?

What I do is invoke "M-|" and send the region to "git am".  That
requires myself to recognize the patches, not the MUA I use.

> But if we are trying to re-create the behaviour of "git
> send-email" (as I think is necessary if we want the feature to be of use
> outside of Emacs circles, such as sending a patch to the Linux Kernel
> Mailing List), then we need to consider people using clients like Mutt
> or Aerc (https://aerc-mail.org/) that just pipe the entire message
> through "git am".

Do you intend to provide a VC front-end to applying the patch-set, as
part of this job?  Because if not, what happens on the receiving end
is out of the scope of the feature we are discussing.

> > But I don't object to having optional behaviors here.  My point is
> > that we should allow sending all the patches together, as that is the
> > preferred/usual practice in Emacs development.
> 
> Of course, the idea that was proposed on emacs-devel was to have this
> behaviour be controlled by a (file-local) variable that could be set on
> a per-project basis.

We should have a user option that doesn't require project.el
(project.el can override it, of course).  There should be no
requirement to use project.el to send patches from VC.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 12:08:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 08:08:06 2022
Received: from localhost ([127.0.0.1]:52552 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRY86-0000kw-F5
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 08:08:06 -0400
Received: from lahtoruutu.iki.fi ([185.185.170.37]:35098)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ane@HIDDEN>) id 1oRY84-0000km-MV
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 08:08:05 -0400
Received: from qfinm256.local (unknown [66.159.213.92])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested) (Authenticated sender: ane)
 by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 0965D1B001A3;
 Fri, 26 Aug 2022 15:08:01 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; 
 t=1661515682;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=h9T/CxzmtzzZ5hdxv6vOKSpom383IT4/xPma8fzAwcA=;
 b=LEgXK4FTMxq50Wrmp/qVZtQemT2d6PRI4C9pAxZSt2WumyAurNV6UTD+mD5PzOjjkHjh3y
 5tFyoR/BOd/MA6UwHnLlBlj6Yezw5tJ0g4E1uOS9XG3ikXjK8bc0yceamTbUY9aF88gNaF
 am7RIW0VHj+nbeoKhIX727ieEbVAhFRjthE8gSBQ9mgGWBJutG5N2phvDk6Vaj+iPAWrep
 nV5fAlG7AxuWEgSwhvS7A8u0dKs4Z/e6WKNDWi0IflKtHMcURWFFEB+Rc5qyZkU41sXfl7
 aTQGru/p9ClXJWBs8M7b4iGaY78PJFELA9bVKUtIwJmZUCSi6Q/t2m3LFVfQhg==
From: Antoine Kalmbach <ane@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <83mtbr1b6l.fsf@HIDDEN>
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
Date: Fri, 26 Aug 2022 15:08:01 +0300
Message-ID: <lyedx3ryvy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1661515682; a=rsa-sha256; cv=none;
 b=hPQJ9rSANsWiWoxhsFSYepuVMw6e7Q+NwwwSGekS9EZdarmJCoXesg5aNk9H3OWE10y/Zi
 JDdLJ7GE30C1H4RXQSK1vuAu2EqGnVRwg/JQRguTvOLfV6jViG9luLb6AY8+YI/KiKqoBF
 8b68bvmAtTcxOKL5x7yH+ODgEO0IJTAMlIqVBvu+H6VvL9CavAzwmfArjpzIJxjyim3BBp
 SyBlcFwkCiHNS26+IzUJkcpcWT+7EAwRw7A3Q1ZUTMcGibwQikxZN1fYHLkb7MD0o3MSPE
 dhsuFio/Wk1vQQRbEAYksy5pdGjoW6x6aezjRaHkgtyVqCYeULEO2iejZi2UMQ==
ARC-Authentication-Results: i=1; ORIGINATING;
 auth=pass smtp.auth=ane smtp.mailfrom=ane@HIDDEN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi;
 s=lahtoruutu; t=1661515682;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=h9T/CxzmtzzZ5hdxv6vOKSpom383IT4/xPma8fzAwcA=;
 b=wcd7/vHNKbEiTNo83IVf7XIQD7gG+918G1ACSYTJ8y64ubnyJ+cfdYyS8vNFO/+KvKeLKD
 l86r5LTebZueimX6AjRMx4wL+HExoDqIRu7r5VU2Tn7cM5SoQDLTJ8G/9LoubyWr9B8cEO
 F3y6hFoHAlz/p47GRlf1VbTpFLEULLfgu3RULXMiw1y9iiUZU6EtjbXdlocXeqGpPJv4RP
 ngtlk50qIHmzv0nmr9qijBj0DZuT/CGljtLzQjjv/PR65wneNUOnmIbsq6OO9uO7p0SHSX
 0YZ3FSfcR7EHOffaSCAPRVHnSHi/DauuhM+AJDjlpvl2LH5ls8pUSiC6PWmDIA==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> > Also, I'm not sure why we'd need to send each patch file separately.
>> > Why not add them one by one as attachments to the same email message?
>> 
>> This wouldn't work if we are sending patches to a mailing list that
>> assumes patches are sent out by git send-email, and that the messages
>> can be filtered through git am.
>
> "git am" handles attachments without any problems, I do it all the
> time.
>

But you have to save the attached .patch files and then run git am on
those.  Typically, without attachments, you'd run `git am` on the
message (mbox) directly.  Each mail is a patch in that sense, and a
separate cover letter is sent first when there's some introductory words
that need to be said.

> But I don't object to having optional behaviors here.  My point is
> that we should allow sending all the patches together, as that is the
> preferred/usual practice in Emacs development.

Yes, but users would have to apply the customization to get the Emacs
way of working, I think.  

-- 
Antoine Kalmbach




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 12:05:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 08:05:18 2022
Received: from localhost ([127.0.0.1]:52547 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRY5N-0000gV-PJ
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 08:05:18 -0400
Received: from mout02.posteo.de ([185.67.36.66]:41999)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1oRY5M-0000gF-1w
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 08:05:16 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 07E37240106
 for <57400 <at> debbugs.gnu.org>; Fri, 26 Aug 2022 14:05:09 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1661515510; bh=N38R6UoP3m4mn/EtwaAZtYa5KDCKQoHK375FWtK/H7I=;
 h=From:To:Cc:Subject:Autocrypt:Date:From;
 b=hYRtH2Q6Bw46TkyqehQy3Jae4G0YsbClteSTSMLeLwYrjS1L4beVkTWzSb04RBEmo
 Rrinx3uGXR+xMK/rBxfLQSafKjuhJGwZh0OCn7nHwH8ytJuG0sCf9cIwi1St9IRaWg
 Bw9zegWIKj5rLkwm2TV6JmUEuh8I41Sv9Z8NSOOZZtNi9h49IJnt9c5uamP8S7fwcN
 nrLF6Pub8AWkU5xFc/7z5sOoZCA6+5Si6TdxuvVf0UK3HdK/tGBURfN2zred+FnBBR
 RuiO21vcJLXx6pqbtT2LqF00ziu4r0j+KxiTThBurgtqd4i8kO0B6C091KJSyV6hqM
 HWjUcCDu03EHw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4MDdnK17k6z6tm6;
 Fri, 26 Aug 2022 14:05:08 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <83mtbr1b6l.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 26 Aug
 2022 14:44:34 +0300")
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
 <87fshjmeje.fsf@HIDDEN> <83mtbr1b6l.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; prefer-encrypt=nopreference; keydata=
 mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ
 CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh
 io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF
 AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo
 Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS
 g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB
Date: Fri, 26 Aug 2022 12:05:07 +0000
Message-ID: <87tu5zky6k.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org, ane@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii <eliz@HIDDEN> writes:

>
>> From: Philip Kaludercic <philipk@HIDDEN>
>> Cc: Antoine Kalmbach <ane@HIDDEN>,  57400 <at> debbugs.gnu.org
>> Date: Fri, 26 Aug 2022 11:26:29 +0000
>> 
>> Eli Zaretskii <eliz@HIDDEN> writes:
>> 
>> >>   5. Loop each file in `message-mode`. `C-c C-c` sends and goes to the
>> >>      next patch, `C-c C-k` cancels the whole thing.
>> >
>> > Please don't hard-code message-mode.  Please honor the user setting of
>> > mail-user-agent instead.
>> 
>> Is there a generic way to handle any mail-user-agent?
>
> For some value of "generic way to handle", yes.  For example,
> compose-mail does that.
>
>> E.g. if you want to add attachments, is there any better way that
>> just doing a case distinction on known user agent implementations?
>
> Not sure about attachments, but we could either add another property
> to mail-user-agent, like we do with composefunc property, or dispatch
> on the agent itself.

That sounds like a good approach.

>> > Also, I'm not sure why we'd need to send each patch file separately.
>> > Why not add them one by one as attachments to the same email message?
>> 
>> This wouldn't work if we are sending patches to a mailing list that
>> assumes patches are sent out by git send-email, and that the messages
>> can be filtered through git am.
>
> "git am" handles attachments without any problems, I do it all the
> time.

Only if the MUA can recognise the patch and pipe it into a git am
process.  But if we are trying to re-create the behaviour of "git
send-email" (as I think is necessary if we want the feature to be of use
outside of Emacs circles, such as sending a patch to the Linux Kernel
Mailing List), then we need to consider people using clients like Mutt
or Aerc (https://aerc-mail.org/) that just pipe the entire message
through "git am".

> But I don't object to having optional behaviors here.  My point is
> that we should allow sending all the patches together, as that is the
> preferred/usual practice in Emacs development.

Of course, the idea that was proposed on emacs-devel was to have this
behaviour be controlled by a (file-local) variable that could be set on
a per-project basis.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 11:44:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 07:44:30 2022
Received: from localhost ([127.0.0.1]:52499 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRXlF-0004B2-Nq
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 07:44:30 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43962)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oRXlD-0004Am-9W
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 07:44:28 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:49216)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRXl8-0002QV-1E; Fri, 26 Aug 2022 07:44:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=sj7xkH0y82D11HQZ/KtR2tkM3NSPrUpKQbGSRI1pJIA=; b=j0BUiRCUx7Iu
 gkouCsNXlKeI+vCQIvvnvq32sWNMi55h9ouFkr2zioQ2lkFFbYgNAnE6p/GsDb/cmUuwzez990+Zl
 1lwdq9lelu/nAQ7oaFzoZJ0jZEPl7QDUlPGQiSqsPfw7SUOpuCsHc1z6yaqSPJ2RABReeXsH75D/J
 eg/rH53UYK3B3PGaVO2VEGG8LK3sc4UM0s7KuL6j0lVSUNrz9CWgFEqIMXwhGAydLNz0anQA98ava
 UccPVAI0mtMJz8sNPGtmEpEwO8wdUceCeV5LXq0d2JE2aiVRmwFjK3Jp1y1AukYB+e+fNsgDOfgHm
 sT2jaUIElPsJUa0Dv91+lg==;
Received: from [87.69.77.57] (port=1622 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRXl7-0007Jx-7t; Fri, 26 Aug 2022 07:44:21 -0400
Date: Fri, 26 Aug 2022 14:44:34 +0300
Message-Id: <83mtbr1b6l.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <87fshjmeje.fsf@HIDDEN> (message from Philip Kaludercic on
 Fri, 26 Aug 2022 11:26:29 +0000)
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN> <87fshjmeje.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org, ane@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Philip Kaludercic <philipk@HIDDEN>
> Cc: Antoine Kalmbach <ane@HIDDEN>,  57400 <at> debbugs.gnu.org
> Date: Fri, 26 Aug 2022 11:26:29 +0000
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >>   5. Loop each file in `message-mode`. `C-c C-c` sends and goes to the
> >>      next patch, `C-c C-k` cancels the whole thing.
> >
> > Please don't hard-code message-mode.  Please honor the user setting of
> > mail-user-agent instead.
> 
> Is there a generic way to handle any mail-user-agent?

For some value of "generic way to handle", yes.  For example,
compose-mail does that.

> E.g. if you want to add attachments, is there any better way that
> just doing a case distinction on known user agent implementations?

Not sure about attachments, but we could either add another property
to mail-user-agent, like we do with composefunc property, or dispatch
on the agent itself.

> > Also, I'm not sure why we'd need to send each patch file separately.
> > Why not add them one by one as attachments to the same email message?
> 
> This wouldn't work if we are sending patches to a mailing list that
> assumes patches are sent out by git send-email, and that the messages
> can be filtered through git am.

"git am" handles attachments without any problems, I do it all the
time.

But I don't object to having optional behaviors here.  My point is
that we should allow sending all the patches together, as that is the
preferred/usual practice in Emacs development.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 11:26:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 07:26:43 2022
Received: from localhost ([127.0.0.1]:52461 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRXU2-0001Xf-QD
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 07:26:43 -0400
Received: from mout02.posteo.de ([185.67.36.66]:52139)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1oRXU1-0001XR-2D
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 07:26:41 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id F234E240101
 for <57400 <at> debbugs.gnu.org>; Fri, 26 Aug 2022 13:26:33 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1661513195; bh=IGboPacd35yaV+GCg9Nojg7ej1Xd12KRqsZoXKhglVY=;
 h=From:To:Cc:Subject:Autocrypt:Date:From;
 b=Q0U+ZmydCPYa3/T9ouERO5MCsxQ9tebbDXZfMckckGapuL2gtOzFmAdT6MEjxR2pr
 eTknE/WfPnPorDc7jRZa8+sN5gz/ib0MyCYGP4VJuJhKmi2ds6k1ygsAnb/D9hgKqb
 M+MbjTU81UWCd+QyI7ZV5yG83rSYxuDio68AH7K98zQDZfo08kdMBZfDTCyUwXeOO5
 RhMzgxuSSrIHhVTAFgtL6oLMTnLBZQwRWpSInnmariN0xRPMRjyPlwibhZSTIoquo/
 bow6eeU+7XMZVGBkTbjYw6JDMwofK6YB5w/OE7YiEemH2D2Z4U6kK1UvkAjRT7jy9b
 JUpl/fPGvEmjg==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4MDcwm2rRhz6tpm;
 Fri, 26 Aug 2022 13:26:29 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <83sflj1dbo.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 26 Aug
 2022 13:58:19 +0300")
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
 <lyo7w7s2ow.fsf@HIDDEN> <83sflj1dbo.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; prefer-encrypt=nopreference; keydata=
 mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ
 CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh
 io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF
 AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo
 Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS
 g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB
Date: Fri, 26 Aug 2022 11:26:29 +0000
Message-ID: <87fshjmeje.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org, Antoine Kalmbach <ane@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii <eliz@HIDDEN> writes:

>>   5. Loop each file in `message-mode`. `C-c C-c` sends and goes to the
>>      next patch, `C-c C-k` cancels the whole thing.
>
> Please don't hard-code message-mode.  Please honor the user setting of
> mail-user-agent instead.

Is there a generic way to handle any mail-user-agent?  E.g. if you want
to add attachments, is there any better way that just doing a case
distinction on known user agent implementations?

> Also, I'm not sure why we'd need to send each patch file separately.
> Why not add them one by one as attachments to the same email message?

This wouldn't work if we are sending patches to a mailing list that
assumes patches are sent out by git send-email, and that the messages
can be filtered through git am.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 10:58:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 06:58:14 2022
Received: from localhost ([127.0.0.1]:52281 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRX2T-0004mb-V3
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 06:58:14 -0400
Received: from eggs.gnu.org ([209.51.188.92]:37522)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1oRX2S-0004mP-QA
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 06:58:13 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:60066)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRX2N-0001TH-Io; Fri, 26 Aug 2022 06:58:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=KBdki2H9GBUyw9oen195ROfzG/LXzLS9l3mFIColy5c=; b=IRjY5RwRU36j
 s/9mz8Azpfmcm0xdOQR5sgD90GhleW7pRJninuuj/yg4SzzaordOuQ5i3rkUG4A/0ThrPmIiEcx7R
 Wha0zKQvqlNTR1FeZQkAndnGn1SZc6cb6Ht/l88Ln0ibRtKk70s6g2ract0i2QhJ0kS24LiWBe/j6
 1nmPzZHtKbHkVRqlva8rIfGK3hpw+LiPVuc21qTQzcraQ1aAoiG9+O+q5Sf26hTOfelWrlhtLT8u2
 RVWaKUHEvWGJJoImapcLCm0BPFJON0QmTBT86opn8gzURP6oCRfnczAtHoWX0TJssrXoyR/VmOif2
 YckpUMBpSzkF1MJqKlfdzQ==;
Received: from [87.69.77.57] (port=2689 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1oRX2M-0002bo-R7; Fri, 26 Aug 2022 06:58:07 -0400
Date: Fri, 26 Aug 2022 13:58:19 +0300
Message-Id: <83sflj1dbo.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Antoine Kalmbach <ane@HIDDEN>
In-Reply-To: <lyo7w7s2ow.fsf@HIDDEN> (message from Antoine Kalmbach on Fri, 26
 Aug 2022 13:45:51 +0300)
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN> <lyo7w7s2ow.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: philipk@HIDDEN, 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 57400 <at> debbugs.gnu.org
> From: Antoine Kalmbach <ane@HIDDEN>
> Date: Fri, 26 Aug 2022 13:45:51 +0300
> 
>   1. `M-x vc-prepare-patch`
>   2. Dispatch to `vc-git-prepare-patch`
>   3. Git wants a revision range, so interactively prompt for that
>      (e.g. `HEAD^`, `abcd1234..ghjk5678`, or `-1`)

Please allow the user to specify the range of commits in a log-like
display, e.g. by having mark and point around them.  It makes no sense
to force users to type revisions in the Git syntax, and come up with
the SHA1 codes on top of that.  VC is supposed to be a convenient UI,
not just a dumb front-end to the VCS.

>   4. `call-process` to `git format-patch $REV`, and so forth, get the
>      list of files.

By "list of files" do you mean the list of patch files?

>   5. Loop each file in `message-mode`. `C-c C-c` sends and goes to the
>      next patch, `C-c C-k` cancels the whole thing.

Please don't hard-code message-mode.  Please honor the user setting of
mail-user-agent instead.

Also, I'm not sure why we'd need to send each patch file separately.
Why not add them one by one as attachments to the same email message?

> Most likely, depending on the backend, we should not require any
> parameters besides the "set of changes".

If you allow to specify that via the region, all your problems are
solved, and the only one that remains is how to express that in the
backend-specific syntax.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 10:45:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 06:45:56 2022
Received: from localhost ([127.0.0.1]:52221 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRWqa-0004O2-Bx
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 06:45:56 -0400
Received: from lahtoruutu.iki.fi ([185.185.170.37]:42282)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ane@HIDDEN>) id 1oRWqY-0004Nq-39
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 06:45:54 -0400
Received: from qfinm256.local (unknown [66.159.213.92])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested) (Authenticated sender: ane)
 by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 165FD1B0018B;
 Fri, 26 Aug 2022 13:45:52 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; 
 t=1661510752;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=0CNUFwa3Vl5LTtcr+Gnsrni6EOXlu2uah3WmjawPdwQ=;
 b=Vb5l2YfH8J+VVzAAdTIuQ0Hf75OplaEWahwz8LVDB8wb4dTKUcCV3xAG71ei1BbEx0AjAO
 MlRB8Qu45jzGGLdyY3Lg48PyC++LK/Hdi7cJk26AiPkDYGL6KNZeb+XA2/brHWogJ+RMx/
 y7nUxXSPcpnR6pBDxBgMa8nVbtNVTV1EpT9FTdhLxs9XUNfsdlyZxBMfM8vbBds5jRp7nt
 eWFUuja030f+XpuFgJrbls+DsRi4cH7onzzcDW3tWRyNmJIWpkan0VCSpq2QIvkSrkGMIi
 h2rRU9PXca4ZSc0NtxKeQSBC7h33gxQdJxuL8u6n1S3RaAg2FfpJDHhwhWV+9A==
From: Antoine Kalmbach <ane@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <87sfljmgwz.fsf@HIDDEN>
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN> <87sfljmgwz.fsf@HIDDEN>
Date: Fri, 26 Aug 2022 13:45:51 +0300
Message-ID: <lyo7w7s2ow.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1661510752; a=rsa-sha256; cv=none;
 b=HCFdDyy5wD+5gR2COtlbBtmX/uCetq5ieHXPR+Fp+Ol5L1nl0xkuN9ZCeRga4xEa7FiI37
 Foorz9kVKJzBWFQXXAVoIz8Bv4yaAtuzDm2zJDhoJduNOaTW+kKAN+nsPJgE/XAh9pi8Ng
 XPYSVf5E5Sfy7pbEBWMXnB5AZZXT5WEkG0dc8TNRjp70OdmoLY2VXgp+xjzCF0sfBmJzdM
 It8K/PE4cgTLUJveptNFkRZveIwfjekzZu0iHdDIHv4/6GCbW8RLW6uR87Rh5VhYJOOkYU
 N5am/cU47nxVs8odcpgL6RFZiiTTSNuT/CQIsoo53g06VRuBcQ21AATjkKJCpQ==
ARC-Authentication-Results: i=1; ORIGINATING;
 auth=pass smtp.auth=ane smtp.mailfrom=ane@HIDDEN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi;
 s=lahtoruutu; t=1661510752;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=0CNUFwa3Vl5LTtcr+Gnsrni6EOXlu2uah3WmjawPdwQ=;
 b=CXKJkGV7IzzwQ25q6jBybIEvjzkZEpO59MfsPeyMvtgXvLf747DHaf0e61w0LGIo+mpogg
 AoejgdJqdnCKbW4YatpdsnY7Dh6zeNvwCJbvp0Eim2NSxuZQE56nQqiMENxDl1esnAlmB1
 K1J7atEFppudy0ZAGTT74CWWSZOFNvZmp5fmx3gQ57r+aDi4ds1YnFpCHMXmr6N0gfxilm
 681jP0FDbb9+5mmw8HmY+QqF9KHFKPjwvj6EInf7WCXZMXmGco6+x4Fj6JAuBsX/HPhxNd
 7Oobglv06fr7QmHHII3rrLKoDU5jYPPVDlVzLAQuF2XP+X9pZs9HG5rvMuRqRw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Philip Kaludercic <philipk@HIDDEN> writes:

> Yes, and I began implementing a different approach (as mentioned on the
> emacs-devel thread), which I have since abandoned.  If you haven't
> written anything yet, and don't insist on it, I could propose to start
> sketching out your suggestions.

Sure!  I was thinking we could start from a very basic command, call it
`vc-prepare-patch` as per your suggestion. Since VC uses generics, we
can dispatch to backend-specific implementations, something like this,
with Git:

  1. `M-x vc-prepare-patch`
  2. Dispatch to `vc-git-prepare-patch`
  3. Git wants a revision range, so interactively prompt for that
     (e.g. `HEAD^`, `abcd1234..ghjk5678`, or `-1`)
  4. `call-process` to `git format-patch $REV`, and so forth, get the
     list of files.
  5. Loop each file in `message-mode`. `C-c C-c` sends and goes to the
     next patch, `C-c C-k` cancels the whole thing.

Once the file opens in message-mode, most likely we need to strip the
magic From <sha> <date> header from the beginning of the mail. Then we ensure
don't do any nasty whitespace removal or wrapping.

Most likely, depending on the backend, we should not require any
parameters besides the "set of changes". For instance, in Git you can
configure `git-format-patch` in the git configuration for several
attributes, like --to=, --annotate, --prefix, etc.

I don't remember how Mercurial works with this. Probably similar. It
should generate mbox entries as well, I think. 

-- 
Antoine Kalmbach




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 10:35:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 06:35:22 2022
Received: from localhost ([127.0.0.1]:52141 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRWgL-0001sO-OH
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 06:35:22 -0400
Received: from mout01.posteo.de ([185.67.36.65]:37145)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1oRWgJ-0001s7-HV
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 06:35:20 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 38F66240028
 for <57400 <at> debbugs.gnu.org>; Fri, 26 Aug 2022 12:35:12 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1661510113; bh=61DnrQfRh2XQMdrORkvQ3W2W5QhcJWx3koTRti7rhes=;
 h=From:To:Cc:Subject:Autocrypt:Date:From;
 b=RFemCNlTn6ghmzWDxvejkoDU6bqcxVzdRMa2LC6cQ1E+mep3ybQMqGkWqTKDx5tr/
 esF7vzzjc1GjGBvgjAx5bQ+Qn3jf3UI9lKvP34ukGqvbJhKNqd0BlDQ3bviNy5VMN7
 Qmv5gxY2/DdsAOImFzaphqdBeuTLZKrHBMgEt4U1zjqL9g2x8A5H6nlBRdSMnLr7cc
 bsazSzfp+iuX17y3Yk/hHUDm/STvtEuKDHI4YKmAOXEwjEkfzYjEtaauTyLuoB3ol6
 SE32qcrykdlxPDVmQ+GVUJOihIr/jQ6aMByPNJ92QD1yAQqWKu8B6yITsJrA7BNvqo
 +l9EQ/qXn4MhA==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4MDbnX2srYz6tmB;
 Fri, 26 Aug 2022 12:35:09 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Antoine Kalmbach <ane@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <lyr113s43w.fsf@HIDDEN> (Antoine Kalmbach's message of "Fri, 26
 Aug 2022 13:15:15 +0300")
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
 <lyr113s43w.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; prefer-encrypt=nopreference; keydata=
 mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ
 CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh
 io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF
 AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo
 Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS
 g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB
Date: Fri, 26 Aug 2022 10:35:08 +0000
Message-ID: <87sfljmgwz.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Antoine Kalmbach <ane@HIDDEN> writes:

>
> Philip Kaludercic <philipk@HIDDEN> writes:
>
>> Have you started implementing anything yet?
>
> No, not yet.  Hadn't you also thought about implementing this, if I
> recall correctly?

Yes, and I began implementing a different approach (as mentioned on the
emacs-devel thread), which I have since abandoned.  If you haven't
written anything yet, and don't insist on it, I could propose to start
sketching out your suggestions.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 10:15:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 06:15:22 2022
Received: from localhost ([127.0.0.1]:52059 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRWMz-0001BJ-Vk
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 06:15:22 -0400
Received: from lahtoruutu.iki.fi ([185.185.170.37]:57416)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ane@HIDDEN>) id 1oRWMy-0001BB-9x
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 06:15:21 -0400
Received: from qfinm256.local (unknown [66.159.213.92])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested) (Authenticated sender: ane)
 by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 386121B0018B;
 Fri, 26 Aug 2022 13:15:17 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; 
 t=1661508917;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=sZeyhxYj1/i9UDAr5S0bgDWXyBRIvrIn+oqKSj5pzAM=;
 b=WBQ8N67m4mKpuvBV6A6rgHMf7YIdiJAiW6szxcjWgystOwnwtrGzPz3hfmKQ6bjdF54axr
 IavPcdMWaDk2DRO0wA2SvS9KhbHSQ1nn1IETN7f4+BXhxLyYeQKBMT9MwnQwBEDl3UKiGB
 6OX7kLypoHl9Eo4h0hF0KtpQVuVcMMGhrE4PJ8uBtzG4Sp5dUaL4W2Ci5szrL0Njmfc8QQ
 uZmHQspRN6Sx7Hporufy7zR51YJP1HyVahh3vg13+MzSIBKwzqHUYQvG0QfMrlwFAHrawD
 GbFuci8Nv4b9mCVi/pWBih1xuxp5LvIxCOZwG1RN130brAUVxLFywXwat9x9UA==
From: Antoine Kalmbach <ane@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <87h71zo3p8.fsf@HIDDEN>
References: <84v8qgn1z9.fsf@HIDDEN> <87h71zo3p8.fsf@HIDDEN>
Date: Fri, 26 Aug 2022 13:15:15 +0300
Message-ID: <lyr113s43w.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1661508917; a=rsa-sha256; cv=none;
 b=S04cXdIWYPrnp1TQeE7t4Gx0Bsj+0F/NHKa5t5uFkxlN1L/lqaKHp6SZ01KgZI6UloVePG
 bV/O4ZGKrF2E5Hvmf8pCjh2HhdhCz+5RcCca3P1DY5jdgm40um6cr0+JddtXrs1Tkn1e+f
 /HQr7ArJDgTeSmWS1JZHFSp7Uo41tOr+e4oCpsNELrJyQRDRHor/Gg08x3WjmKI6Wgsuy/
 /PFG7jXsEG8yeUrt3vF29Xb+wENiIqJbyOS1I8Ckm15gaRF0V+nZQEOa/pNfu2fueufkTW
 dUJnjPPCVzukIcXgVz/To4gJPW6BUNHpzyD7P3QdwwIK1jyqC0eCG5GmEIXoDg==
ARC-Authentication-Results: i=1; ORIGINATING;
 auth=pass smtp.auth=ane smtp.mailfrom=ane@HIDDEN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi;
 s=lahtoruutu; t=1661508917;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=sZeyhxYj1/i9UDAr5S0bgDWXyBRIvrIn+oqKSj5pzAM=;
 b=HdhFV7Y9W2hCcth+1thdcP4Z/elkuc+dt7kL2s3YH47Ee7qbXQE4wLsf1D2NTsNLr0urGO
 X1d8R0ov69v/XdLGmYvnrHmpE0f3xedDNUpCghxR9E6/LNhkS3SkSMSG2C+3p8Q6/NMhAZ
 otGrq3dd9NoOXoVx0Ygsfr5mH5a2X8eN/3uDQ3joz93er3BS2oWlZlJNpr1YGv6ddh53Ge
 8b4bCbJYQsUeD2JpNGSwQpHZZeOXYbPRdFHM8EKwaJnChpgtBgEeoPB4Kq87q+i+KkOkL2
 ZuB8I9NGmQOA4JwV+fIh+TEY+CBWh9aBx2N2WkXwAIcQJGeFsNEz9sNmfsHQKg==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Philip Kaludercic <philipk@HIDDEN> writes:

> Have you started implementing anything yet?

No, not yet.  Hadn't you also thought about implementing this, if I
recall correctly?

-- 
Antoine Kalmbach




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at 57400 <at> debbugs.gnu.org:


Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 07:37:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 26 03:37:56 2022
Received: from localhost ([127.0.0.1]:51933 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oRTue-0005aN-86
	for submit <at> debbugs.gnu.org; Fri, 26 Aug 2022 03:37:56 -0400
Received: from mout01.posteo.de ([185.67.36.65]:46355)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1oRTub-0005a6-9p
 for 57400 <at> debbugs.gnu.org; Fri, 26 Aug 2022 03:37:54 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id D97DE24002A
 for <57400 <at> debbugs.gnu.org>; Fri, 26 Aug 2022 09:37:45 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1661499466; bh=axoi0aRvNzZ4vHi2XNkIHcfSy/3KVJGgibuYxYxWcJ8=;
 h=From:To:Cc:Subject:Autocrypt:Date:From;
 b=aFKo2B9V5O0yZr5D25Qc24F0VPu+Ad1c0KFglcnjdcVfZk4dKfatGFWeTJ3eIIGLR
 maeDw97w4/zYmkmX2z4F8a1QMy/GyXuEkJwNm5uXrwvOfIz32kAsugW8e12TzYkI+A
 /ZkyRVtOW7BSVTgOE91oUSaGYfAidoyR6TA02aJUNo8gA6OZSCeGJ8ZjPFVAD2mCA6
 zuL8Dnz7DiX/7gCzmZ8qNFhiQqMf3m9qZ34u7wBmQpD/7KwZVharOKHdA9zug47Yu4
 ThhidCgxW4RJI4K4vlQZscK3oSrzpnCYNFH9D3b43ugvOWANOhO/eZ/nOhBks+mxK6
 M0CTEYojXrVVQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4MDWrn1J3Pz6tq1;
 Fri, 26 Aug 2022 09:37:44 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Antoine Kalmbach <ane@HIDDEN>
Subject: Re: bug#57400: 29.0.50; Support sending patches from VC directly
In-Reply-To: <84v8qgn1z9.fsf@HIDDEN> (Antoine Kalmbach's message of "Thu, 25
 Aug 2022 11:47:54 +0300")
References: <84v8qgn1z9.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; prefer-encrypt=nopreference; keydata=
 mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ
 CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh
 io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF
 AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo
 Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS
 g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB
Date: Fri, 26 Aug 2022 07:37:39 +0000
Message-ID: <87h71zo3p8.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57400
Cc: 57400 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Antoine Kalmbach <ane@HIDDEN> writes:

>
>
> See the discussion here
>
> https://mail.gnu.org/archive/html/emacs-devel/2022-08/msg01059.html
>
> The idea would be to support sending patches using Emacs mail user agent
> capabilities directly from VC projects. This would depend on the chosen
> VC backend and whether it has support for email-based workflows in the
> first place.
>
> The reference implementation would be for Git. A command such as
> `vc-prepare-patch`, which would prompt for a Git revision range and then
> generate a set of .patch files. These then would be opened in the mail
> user agent configured in Emacs for sending.

Have you started implementing anything yet?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 25 Aug 2022 08:48:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 25 04:48:06 2022
Received: from localhost ([127.0.0.1]:48848 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oR8Wz-0002K8-7s
	for submit <at> debbugs.gnu.org; Thu, 25 Aug 2022 04:48:06 -0400
Received: from lists.gnu.org ([209.51.188.17]:42372)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ane@HIDDEN>) id 1oR8Ww-0002Jk-TJ
 for submit <at> debbugs.gnu.org; Thu, 25 Aug 2022 04:48:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:41894)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ane@HIDDEN>) id 1oR8Ww-0006E6-Bv
 for bug-gnu-emacs@HIDDEN; Thu, 25 Aug 2022 04:48:02 -0400
Received: from lahtoruutu.iki.fi ([185.185.170.37]:33554)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ane@HIDDEN>) id 1oR8Ws-0001uh-Uh
 for bug-gnu-emacs@HIDDEN; Thu, 25 Aug 2022 04:48:01 -0400
Received: from thanatos (91-157-197-22.elisa-laajakaista.fi [91.157.197.22])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested) (Authenticated sender: ane)
 by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 565221B00027
 for <bug-gnu-emacs@HIDDEN>; Thu, 25 Aug 2022 11:47:55 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; 
 t=1661417275;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type;
 bh=G6m+ludGHLRgPmh0kbc8+oYvl0G2IIVpboBYRF8zyDg=;
 b=aT0QywCNCTd3SIj/v+2S4NNZDdH8Ya272KztMoiBVFpL3+gP/wI/XCkOgM2GUNVsFfC450
 9YJu0nT/BHGXsJfO2tvuhvcosK5Kxztf7ZVujvksBzLncwAgbANG41QizCcqEmxcD8uSI+
 z1lKreI6+kN3Tt/AWC4JVsQ/vXiMTym2jGyP+SjqTXepbddWjAa9ZcqEAItsT/OGzqkWQN
 bHkjoljZAtSx5umZiJF83KiqkoBPTeIvXb1zNGSfmVdWFYO8T2BH+hwABkjD3VE32jsq99
 eAqWEqJyPiGirN+YnyKJqp8mS19nXviz98HDHem8cKiX+o0+PVHQiKsvTdd5WQ==
From: Antoine Kalmbach <ane@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; Support sending patches from VC directly
Date: Thu, 25 Aug 2022 11:47:54 +0300
Message-ID: <84v8qgn1z9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1661417275; a=rsa-sha256; cv=none;
 b=BBssmeDSQvTZ6qQ9b/3mfECFvbvP1K5so1rZuH+dI9y2b96IeWpa38K8HtsqrsK2qzcVNk
 xXijJrHBMrjysFiZh2dfuQ3DenlHCxtkTn5AmzgvfqseVzNSnOmKcczhd7m9eCw45KZul+
 kJ0OulCns4foXIAiJ6TQsITGsqJFuN2ZDSjz/JKdqw07qYoV5vsO+AwN2KmV8Q3CeRigHZ
 yW0Q7HcPudoPfCJNLxbtqaMXHlvfBGkq+aiYEGC4MAx5+zu22ddsIrGT1lgssBdKq7JeqC
 l9aB6cA7AcOXPqAgbkVur6q5aNzhHYJixSOOX2XSOG3/V8yPOzMaNzzzB0EY4w==
ARC-Authentication-Results: i=1; ORIGINATING;
 auth=pass smtp.auth=ane smtp.mailfrom=ane@HIDDEN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi;
 s=lahtoruutu; t=1661417275;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type;
 bh=G6m+ludGHLRgPmh0kbc8+oYvl0G2IIVpboBYRF8zyDg=;
 b=c2tOC9CHp7O9AlRFgv3rHAcrCJ5M3ibUFe2ElRvt+oKzFIm5j0zCBfBLarv374I91ttosA
 qZNmjOzJ497bZr/f53u0sVJaPcDZTRz2OzcwRZ5lTGWQJ3RO57EIrpblovlq1TmdxIte/r
 Hn+07+OsiMbCThxdFjkX774VBjqLG2sU/ZYl0wCLSwBlgnMBjdtr58tyh4q68YoEjT0Po5
 HVo79BENgo4GEM+ZH2Ir8R9MQ92GPpNBNIb56wU5+OKbXAQ0ahxneOkD0bsTs/sFpUpg6s
 kwXwuLFol9gGDbo+O+IBXaCG0QmozJRq4Oj8gr7KuZqZoJ0q1l5Kwv8IRgqMjA==
Received-SPF: pass client-ip=185.185.170.37; envelope-from=ane@HIDDEN;
 helo=lahtoruutu.iki.fi
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)


See the discussion here

https://mail.gnu.org/archive/html/emacs-devel/2022-08/msg01059.html

The idea would be to support sending patches using Emacs mail user agent
capabilities directly from VC projects. This would depend on the chosen
VC backend and whether it has support for email-based workflows in the
first place.

The reference implementation would be for Git. A command such as
`vc-prepare-patch`, which would prompt for a Git revision range and then
generate a set of .patch files. These then would be opened in the mail
user agent configured in Emacs for sending.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.17.6) of 2022-08-23 built on thanatos
Repository revision: 67a15ce1564ce35ece24a19f00e03a36e0575746
Repository branch: master
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --with-x-toolkit=motif --with-json --with-native-compilation
 --with-pgtk --with-imagemagick --with-mailutils'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS XIM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8

Major mode: notmuch-hello

Minor modes in effect:
  eros-mode: t
  electric-pair-mode: t
  global-corfu-mode: t
  corfu-mode: t
  marginalia-mode: t
  vertico-mode: t
  recentf-mode: t
  savehist-mode: t
  display-time-mode: t
  global-hl-line-mode: t
  global-auto-revert-mode: t
  winner-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tab-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  column-number-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/ane/.emacs.d/elpa/transient-20220806.2224/transient hides /usr/local/share/emacs/29.0.50/lisp/transient

Features:
(shadow emacsbug rfc2104 secrets dbus xml network-stream nsm mailalias
textsec uni-scripts idna-mapping ucs-normalize uni-confusable
textsec-check eudc-capf eudc cus-edit cus-start cus-load eudc-vars sort
company-oddmuse company-keywords company-etags etags fileloop generator
company-gtags company-dabbrev-code company-dabbrev company-files
company-clang company-capf company-cmake company-semantic
company-template company-bbdb company notmuch notmuch-tree notmuch-jump
notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua
notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address
notmuch-company notmuch-parser format-spec notmuch-wash coolj goto-addr
icalendar diary-lib diary-loaddefs cal-menu calendar cal-loaddefs
notmuch-tag crm notmuch-lib notmuch-compat mm-view mml-smime smime
gnutls dig mule-util mail-extr flyspell ispell smex ido eros checkdoc
lisp-mnt noutline outline rainbow-mode color rainbow-delimiters paredit
eldoc-box eglot array xref flymake-proc flymake thingatpt compile comint
ansi-color project imenu jsonrpc ert pp ewoc debug backtrace advice
find-func vc-hg vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs
vc-rcs log-view pcvs-util vc vc-dispatcher bug-reference elec-pair corfu
marginalia vertico recentf tree-widget wid-edit cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
hydra lv smtpmail message sendmail yank-media puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util
text-property-search time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev
mail-utils gmm-utils mailheader diminish modus-operandi-theme
modus-themes use-package-diminish edmacro kmacro use-package-bind-key
bind-key easy-mmode use-package-ensure use-package-core savehist comp
comp-cstr warnings icons rx cl-extra pcase finder-inf
ace-window-autoloads avy-autoloads clj-refactor-autoloads
cider-autoloads clojure-mode-extra-font-locking-autoloads
clojure-mode-autoloads company-autoloads consult-autoloads
corfu-doc-autoloads corfu-autoloads debbugs-autoloads diff-hl-autoloads
diminish-autoloads edit-indirect-autoloads eglot-autoloads
eldoc-box-autoloads eros-autoloads exec-path-from-shell-autoloads
expand-region-autoloads flycheck-autoloads geiser-guile-autoloads
geiser-impl help-fns radix-tree help-mode geiser-custom geiser-base
geiser-autoloads gif-screencast-autoloads go-mode-autoloads
google-c-style-autoloads graphviz-dot-mode-autoloads hl-todo-autoloads
hydra-autoloads inflections-autoloads keycast-autoloads
kind-icon-autoloads lv-autoloads magit-autoloads git-commit-autoloads
magit-section-autoloads marginalia-autoloads markdown-mode-autoloads
meson-mode-autoloads modus-themes-autoloads multiple-cursors-autoloads
neotree-autoloads ninja-mode-autoloads notmuch-autoloads
paredit-autoloads parseedn-autoloads parseclj-autoloads
pinentry-autoloads pkg-info-autoloads epl-autoloads
plantuml-mode-autoloads dash-autoloads queue-autoloads
rainbow-delimiters-autoloads rainbow-mode-autoloads rust-mode-autoloads
scss-mode-autoloads sesman-autoloads sly-asdf-autoloads popup-autoloads
sly-macrostep-autoloads macrostep-autoloads
sly-repl-ansi-color-autoloads sly-autoloads smex-autoloads
spinner-autoloads ssh-config-mode-autoloads svg-lib-autoloads
transient-autoloads tree-sitter-langs-autoloads tree-sitter-autoloads
tsc-autoloads typescript-mode-autoloads use-package-autoloads
bind-key-autoloads vertico-autoloads web-mode-autoloads wgrep-autoloads
with-editor-autoloads info compat-autoloads yaml-mode-autoloads
yasnippet-snippets-autoloads yasnippet-autoloads zig-mode-autoloads
package browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie generate-lisp-file url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv
url-vars time hl-line autorevert filenotify cl-loaddefs cl-lib winner
ring rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win
term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
gtk pgtk multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 815238 428939)
 (symbols 48 32388 106)
 (strings 32 177583 63256)
 (string-bytes 1 5448488)
 (vectors 16 78687)
 (vector-slots 8 1356913 2880582)
 (floats 8 317 2125)
 (intervals 56 1817 7744)
 (buffers 1000 18))

-- 
Antoine Kalmbach




Acknowledgement sent to Antoine Kalmbach <ane@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#57400; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 27 Aug 2022 09:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.