GNU bug report logs - #57482
[PATCH] gnu: Add emacs-org-fc.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57482 in the body.
You can then email your comments to 57482 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: Add emacs-org-fc.
Date: Tue, 30 Aug 2022 14:32:13 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

* gnu/packages/emacs-xyz.scm (emacs-org-fc): New variable.
---
 gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 90ee485f1e..90d817527b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -166,6 +166,7 @@ (define-module (gnu packages emacs-xyz)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages games)
+  #:use-module (gnu packages gawk)
   #:use-module (gnu packages golang)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
@@ -32410,3 +32411,46 @@ (define-public emacs-vertico-posframe
 a Vertico extension which provides a way to pop up a frame at point to show
 a vertical completion UI.")
     (license license:gpl3+)))
+
+(define-public emacs-org-fc
+  (let ((commit "f64b5336485a42be91cfe77850c02a41575f5984")
+        (revision "0"))
+    (package
+      (name "emacs-org-fc")
+      (version (git-version "0.1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://git.sr.ht/~l3kn/org-fc")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1d0a3vr09zkplclypcgpfbfd6r0h0i3g3zsqb4pcz6x239d59gd5"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-hydra))
+      (inputs (list findutils gawk))
+      (arguments
+       (list
+        #:include #~(list "\\.el$" "\\.awk$" "\\.org$")
+        #:exclude #~(list "^tests/")
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'qualify-paths
+              (lambda* (#:key inputs #:allow-other-keys)
+                (let ((find (search-input-file inputs "/bin/find"))
+                      (gawk (search-input-file inputs "/bin/gawk"))
+                      (xargs (search-input-file inputs "/bin/xargs")))
+                  (substitute* "org-fc-awk.el"
+                    (("\"find ") (string-append "\"" find " "))
+                    (("\"gawk ") (string-append "\"" gawk " "))
+                    (("\"xargs ") (string-append "\"" xargs " ")))))))))
+      (home-page "https://www.leonrische.me/fc/index.html")
+      (synopsis "Spaced Repetition System for Emacs org-mode")
+      (description
+       "Org-fc is a spaced-repetition system for Emacs' org-mode.
+It allows you to mark headlines in a file as flashcards, turning pieces of
+knowledge you want to learn into a question-answer test.  These cards are
+reviewed at regular interval.  After each review, the next review interval is
+calculated based on how well you remembered the contents of the card.")
+      (license license:gpl3+))))
-- 
2.37.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: iyzsong--- via Guix-patches via <guix-patches <at> gnu.org>
Cc: 宋文武 <iyzsong <at> member.fsf.org>,
 57482-done <at> debbugs.gnu.org, iyzsong <at> envs.net
Subject: Re: [bug#57482] [PATCH] gnu: Add emacs-org-fc.
Date: Sat, 03 Sep 2022 10:12:55 +0200

Hello,

iyzsong--- via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-fc): New variable.

I applied your patch with the changes below. Thank you.

> +      (arguments
> +       (list
> +        #:include #~(list "\\.el$" "\\.awk$" "\\.org$")

I used  #~(cons* ... %default-include) instead.

> +        #:exclude #~(list "^tests/")

Likewise, I used #~(cons ... %default-exclude)

> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (add-after 'unpack 'qualify-paths
> +              (lambda* (#:key inputs #:allow-other-keys)
> +                (let ((find (search-input-file inputs "/bin/find"))
> +                      (gawk (search-input-file inputs "/bin/gawk"))
> +                      (xargs (search-input-file inputs "/bin/xargs")))
> +                  (substitute* "org-fc-awk.el"
> +                    (("\"find ") (string-append "\"" find " "))
> +                    (("\"gawk ") (string-append "\"" gawk " "))
> +                    (("\"xargs ") (string-append "\"" xargs " ")))))))))


I also activated check phase.

> +      (home-page "https://www.leonrische.me/fc/index.html")
> +      (synopsis "Spaced Repetition System for Emacs org-mode")

I removed over-capitalization. Also (nitpick), I replaced org-mode with
Org mode.

> +      (description
> +       "Org-fc is a spaced-repetition system for Emacs' org-mode.

Ditto.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.