GNU bug report logs - #57495
[PATCH] gnu: Add steam-devices-udev-rules.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57495 in the body.
You can then email your comments to 57495 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: Add steam-devices-udev-rules.
Date: Tue, 30 Aug 2022 15:01:21 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/games.scm (steam-devices-udev-rules): New variable.
---
 gnu/packages/games.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index fe66343a4c..f8c6b86cf7 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -12591,3 +12591,26 @@ (define-public freerct
 Should they go unwise, a theme park plunge into chaos with vandalizing guests
 and unsafe rides.  Which path will you take?")
     (license license:gpl2)))
+
+(define-public steam-devices-udev-rules
+  (package
+    (name "steam-devices-udev-rules")
+    (version "1.0.0.61")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ValveSoftware/steam-devices")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1m4zcrz83p41lz7wxzqc62fsx00rfrai996psfjv7vjvjlyqj0mx"))))
+    (build-system copy-build-system)
+    (arguments
+     '(#:install-plan '(("./" "lib/udev/rules.d"
+                         #:include-regexp ("rules$")))))
+    (home-page "https://github.com/ValveSoftware/steam-devices")
+    (synopsis "udev rules for game controllers and virtual reality devices")
+    (description
+     "Provides a set of udev rules for game controllers and virtual reality devices.")
+    (license license:expat)))
-- 
2.37.2

Message #8 received at 57495 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Morgan.J.Smith <at> outlook.com
Cc: 57495 <at> debbugs.gnu.org
Subject: Re: bug#57495: [PATCH] gnu: Add steam-devices-udev-rules.
Date: Wed, 31 Aug 2022 00:27:55 +0000

Hello,

Thanks for submitting this here! I've been grabbing these files directly
in my system configuration to use the udev rules and never got around to
making a proper package.

Overall LGTM (but did not try out this package), with one minor comment:

On Tue, Aug 30, 2022 at 03:01 PM, Morgan wrote:

> * gnu/packages/games.scm (steam-devices-udev-rules): New variable.
> ---
>  gnu/packages/games.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index fe66343a4c..f8c6b86cf7 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -12591,3 +12591,26 @@ (define-public freerct
>  Should they go unwise, a theme park plunge into chaos with vandalizing guests
>  and unsafe rides.  Which path will you take?")
>      (license license:gpl2)))
> +
> +(define-public steam-devices-udev-rules
> +  (package
> +    (name "steam-devices-udev-rules")
> +    (version "1.0.0.61")

This tag is from 3 years ago now. While this is the latest tag/release,
there have been commits more recently than that. Considering these will
mostly be for adding/tweaking hardware rule, personally I would like
this to reflect the most recent commit to be the most useful. This is
from a year ago now, so it seems the timeline for a release is probably
"Valve time" (aka I'm not holding my breath).

What do you think?

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ValveSoftware/steam-devices")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1m4zcrz83p41lz7wxzqc62fsx00rfrai996psfjv7vjvjlyqj0mx"))))
> +    (build-system copy-build-system)
> +    (arguments
> +     '(#:install-plan '(("./" "lib/udev/rules.d"
> +                         #:include-regexp ("rules$")))))
> +    (home-page "https://github.com/ValveSoftware/steam-devices")
> +    (synopsis "udev rules for game controllers and virtual reality devices")
> +    (description
> +     "Provides a set of udev rules for game controllers and virtual reality devices.")
> +    (license license:expat)))

Thanks!
John

Message #11 received at 57495 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Morgan.J.Smith <at> outlook.com, 57495 <at> debbugs.gnu.org
Subject: Re: [bug#57495] [PATCH] gnu: Add steam-devices-udev-rules.
Date: Wed, 31 Aug 2022 17:55:41 +0200

[Message part 1 (text/plain, inline)]

On 30-08-2022 21:01, Morgan.J.Smith <at> outlook.com wrote:
> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
>
> * gnu/packages/games.scm (steam-devices-udev-rules): New variable.
> ---
>   gnu/packages/games.scm | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index fe66343a4c..f8c6b86cf7 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -12591,3 +12591,26 @@ (define-public freerct
>   Should they go unwise, a theme park plunge into chaos with vandalizing guests
>   and unsafe rides.  Which path will you take?")
>       (license license:gpl2)))
> +
> +(define-public steam-devices-udev-rules
> +  (package
> +    (name "steam-devices-udev-rules")
> +    (version "1.0.0.61")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ValveSoftware/steam-devices")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1m4zcrz83p41lz7wxzqc62fsx00rfrai996psfjv7vjvjlyqj0mx"))))

I have taken a look at the rules, and noticed:

https://github.com/ValveSoftware/steam-devices/blob/d87ef558408c5e7a1a793d738db4c9dc2cb5f8fa/60-steam-input.rules#L55

KERNEL=="input*", ATTRS{name}=="Lic Pro Controller", 
RUN{program}+="/bin/sh -c 'udevadm test-builtin uaccess 
/sys/%p/../../hidraw/hidraw*'"

/bin/sh and udevadm will need to patched (with substitute*) to guarantee 
that sh and udevadm will be found.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #14 received at 57495 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 57495 <at> debbugs.gnu.org
Cc: john.kehayias <at> protonmail.com, Morgan Smith <Morgan.J.Smith <at> outlook.com>,
 maximedevos <at> telenet.be
Subject: [PATCH v2] gnu: Add steam-devices-udev-rules.
Date: Wed, 31 Aug 2022 12:44:22 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/games.scm (steam-devices-udev-rules): New variable.
---

I've incorporated both of your suggestions into the following patch


 gnu/packages/games.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index fe66343a4c..98e5389903 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -12591,3 +12591,38 @@ (define-public freerct
 Should they go unwise, a theme park plunge into chaos with vandalizing guests
 and unsafe rides.  Which path will you take?")
     (license license:gpl2)))
+
+(define-public steam-devices-udev-rules
+  ;; Last release from 2019-04-10
+  (let ((commit "d87ef558408c5e7a1a793d738db4c9dc2cb5f8fa")
+        (revision "0"))
+    (package
+      (name "steam-devices-udev-rules")
+      (version (git-version "1.0.0.61" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/ValveSoftware/steam-devices")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1yqigraz9f19018ma5n2pbx7naadh9960lia3z8ayg7vz1fjdl54"))))
+      (build-system copy-build-system)
+      (arguments
+       '(#:install-plan '(("./" "lib/udev/rules.d"
+                           #:include-regexp ("rules$")))
+         #:phases (modify-phases %standard-phases
+                    (add-after 'unpack 'patch-paths
+                      (lambda* (#:key inputs #:allow-other-keys)
+                        (substitute* "60-steam-input.rules"
+                          (("/bin/sh")
+                           (search-input-file inputs "/bin/sh"))
+                          (("udevadm")
+                           (search-input-file inputs "/bin/udevadm"))))))))
+      (inputs (list eudev))
+      (home-page "https://github.com/ValveSoftware/steam-devices")
+      (synopsis "udev rules for game controllers and virtual reality devices")
+      (description
+       "Provides a set of udev rules for game controllers and virtual reality devices.")
+      (license license:expat))))
-- 
2.37.2

Message #17 received at 57495 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Morgan.J.Smith <at> outlook.com
Cc: maximedevos <at> telenet.be, 57495 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add steam-devices-udev-rules.
Date: Fri, 09 Sep 2022 20:15:11 +0000

On Wed, Aug 31, 2022 at 12:44 PM, Morgan.J.Smith <at> outlook.com wrote:

> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
>
> * gnu/packages/games.scm (steam-devices-udev-rules): New variable.
> ---
>
> I've incorporated both of your suggestions into the following patch
>
>
[snip]

LGTM

I checked that it builds and the output looks correct (correct location, took a peek at the udev rules)

Message #22 received at 57495-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: Morgan.J.Smith <at> outlook.com, maximedevos <at> telenet.be,
 57495-done <at> debbugs.gnu.org
Subject: Re: bug#57495: [PATCH] gnu: Add steam-devices-udev-rules.
Date: Sun, 11 Sep 2022 16:38:57 +0200

Applied, thanks to all reviewers :)

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.