GNU bug report logs - #57512
29.0.50; outline-minor-mode-map outline-minor-mode-cycle-map are eq

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57512 in the body.
You can then email your comments to 57512 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: miha <at> kamnitnik.top
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; outline-minor-mode-map outline-minor-mode-cycle-map are eq
Date: Wed, 31 Aug 2022 23:07:30 +0200

[Message part 1 (text/plain, inline)]

(progn
  (require 'outline)
  (eq outline-minor-mode-map outline-minor-mode-cycle-map))

-> t

In GNU Emacs 29.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.17.6) of 2022-08-30 built on iii
Repository revision: e1e60e51bf324aaa2137075827c4d08a331a7bef
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Arch Linux

Configured using:
 'configure -C --prefix=/usr
 'CFLAGS=-O0 -g3''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11
XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
faces cus-face macroexp files window text-properties overlay sha1 md5
base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 38013 5938)
 (symbols 48 5087 0)
 (strings 32 13142 1955)
 (string-bytes 1 375319)
 (vectors 16 9267)
 (vector-slots 8 146341 10494)
 (floats 8 21 17)
 (intervals 56 215 0)
 (buffers 1000 11))

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 57512 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: miha <at> kamnitnik.top
Cc: 57512 <at> debbugs.gnu.org
Subject: Re: bug#57512: 29.0.50;
 outline-minor-mode-map outline-minor-mode-cycle-map are eq
Date: Thu, 01 Sep 2022 08:07:41 +0300

> Date: Wed, 31 Aug 2022 23:07:30 +0200
> From: miha--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> (progn
>   (require 'outline)
>   (eq outline-minor-mode-map outline-minor-mode-cycle-map))
> 
> -> t

Why is that a problem?  You only loaded the code, you didn't enable
any of the modes in outline.el.

Message #11 received at 57512 <at> debbugs.gnu.org (full text, mbox):

From: <miha <at> kamnitnik.top>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57512 <at> debbugs.gnu.org
Subject: Re: bug#57512: 29.0.50; outline-minor-mode-map
 outline-minor-mode-cycle-map are eq
Date: Thu, 01 Sep 2022 08:49:02 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Wed, 31 Aug 2022 23:07:30 +0200
>> From: miha--- via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> (progn
>>   (require 'outline)
>>   (eq outline-minor-mode-map outline-minor-mode-cycle-map))
>> 
>> -> t
>
> Why is that a problem?  You only loaded the code, you didn't enable
> any of the modes in outline.el.

Indeed this isn't such a big problem, just a bit confusing, as the
variables have slightly different doc-strings.

Perhaps we should make the equivalence more explicit by declaring
'outline-minor-mode-cycle-map' as a possibly obsolete variable alias to
'outline-minor-mode-map'.

Message #14 received at 57512 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: miha <at> kamnitnik.top
Cc: 57512 <at> debbugs.gnu.org
Subject: Re: bug#57512: 29.0.50; outline-minor-mode-map
 outline-minor-mode-cycle-map are eq
Date: Thu, 01 Sep 2022 10:27:25 +0300

> (progn
>   (require 'outline)
>   (eq outline-minor-mode-map outline-minor-mode-cycle-map))
>
> -> t

It seems you found a bug in easy-mmode-define-keymap.

  (define-minor-mode outline-minor-mode
    :keymap (easy-mmode-define-keymap
             `(([menu-bar] . ,outline-minor-mode-menu-bar-map)
               (,outline-minor-mode-prefix . ,outline-mode-prefix-map))
             :inherit outline-minor-mode-cycle-map)

This supposed to create a new keymap with these additional keybindings.
But it also destructively modifies outline-minor-mode-cycle-map
from which it should only inherit without changing it.

Message #17 received at 57512 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: miha <at> kamnitnik.top, 57512 <at> debbugs.gnu.org
Subject: Re: bug#57512: 29.0.50; outline-minor-mode-map
 outline-minor-mode-cycle-map are eq
Date: Thu, 01 Sep 2022 10:21:32 +0200

Juri Linkov <juri <at> linkov.net> writes:

> It seems you found a bug in easy-mmode-define-keymap.

(Which should probably be obsoleted now that `define-keymap' exists.)

Message #20 received at 57512 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: miha <at> kamnitnik.top
Cc: 57512 <at> debbugs.gnu.org
Subject: Re: bug#57512: 29.0.50; outline-minor-mode-map
 outline-minor-mode-cycle-map are eq
Date: Thu, 01 Sep 2022 12:24:29 +0200

miha <at> kamnitnik.top writes:

> (progn
>   (require 'outline)
>   (eq outline-minor-mode-map outline-minor-mode-cycle-map))

This is now fixed in Emacs 29.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.