GNU logs - #57551, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#57551: 29.0.50; hide-show in python-mode selects the current block imperfectly
Resent-From: Dima Kogan <dima@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 02 Sep 2022 21:26:01 +0000
Resent-Message-ID: <handler.57551.B.166215395727059 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 57551 <at> debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, kobarity <kobarity@HIDDEN>
Feedback-ID: i3e8042a0:Fastmail
From: Dima Kogan <dima@HIDDEN>
Date: Fri, 02 Sep 2022 14:25:39 -0700
Message-ID: <87zgfhtqng.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=64.147.123.24; envelope-from=dima@HIDDEN;
 helo=wout1-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

Hi. I've been using the recently-committed hide-show functionality from:

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56635

It's working well, but I just found a problem. Python lacks explicit
block-end characters that a language like C has. This creates some
ambiguity about what is intended, and I think emacs makes the wrong
choice in at least one spot. Let's say we have a tst.py:

def f():
    if 1:
        11
    elif 2:
        22
    elif 3:
        33
    elif 4:
        44
    else:
        5

If I want to collapse the "elif 2:" block, I move the point to somewhere
inside that block, and (hs-hide-block). Placing the point at the end of
the "elif 2:" line puts us unambiguously inside that block, so this does
the job.

But what if the point is at the start of the "elif 2:" line? Currently
emacs considers this to be INSIDE this block also, so (hs-hide-block)
there also hides the "elif 2" block, but should it? Would it not make
more sense if the START of the "elif 2:" line was considered in the "def
f():" block, but outside all the "if" blocks? Then (hs-hide-block) at
the start of that line would collapse the whole "def f():" block.
Currently the only point where this can be done is at the end of the
"def f():" line.

This also raises a question about what should happen if we
(hs-hide-block) with the point on the "i" in any of the "elif" lines.
Probably this should be outside the "elif" blocks too? Maybe?

Thanks!

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Dima Kogan <dima@HIDDEN>
Subject: bug#57551: Acknowledgement (29.0.50; hide-show in python-mode
 selects the current block imperfectly)
Message-ID: <handler.57551.B.166215395727059.ack <at> debbugs.gnu.org>
References: <87zgfhtqng.fsf@HIDDEN>
X-Gnu-PR-Message: ack 57551
X-Gnu-PR-Package: emacs
Reply-To: 57551 <at> debbugs.gnu.org
Date: Fri, 02 Sep 2022 21:26:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 57551 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
57551: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57551
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#57551: 29.0.50; hide-show in python-mode selects the current block imperfectly
Resent-From: kobarity <kobarity@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 04 Sep 2022 15:16:02 +0000
Resent-Message-ID: <handler.57551.B57551.166230455114502 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Dima Kogan <dima@HIDDEN>
Cc: 57551 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi@HIDDEN>
Date: Mon, 05 Sep 2022 00:15:40 +0900
Message-ID: <eke7zgff41cz.wl-kobarity@HIDDEN>
From: kobarity <kobarity@HIDDEN>
In-Reply-To: <87zgfhtqng.fsf@HIDDEN>
References: <87zgfhtqng.fsf@HIDDEN>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/29.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Dima Kogan wrote:
> But what if the point is at the start of the "elif 2:" line? Currently
> emacs considers this to be INSIDE this block also, so (hs-hide-block)
> there also hides the "elif 2" block, but should it? Would it not make
> more sense if the START of the "elif 2:" line was considered in the "def
> f():" block, but outside all the "if" blocks? Then (hs-hide-block) at
> the start of that line would collapse the whole "def f():" block.
> Currently the only point where this can be done is at the end of the
> "def f():" line.

Hi.  I think current hideshow behavior is in line with block
navigation in Python mode.  For example, if the point is at the start
of the "elif 2:" line, M-x python-nav-beginning-of-block moves the
point to "e" of "elif 2:".  This implies that Emacs Python mode
considers spaces before "elif 2:" to belong to the "elif 2:" block.
So I think this is not a matter of hideshow, but of how the block
should be recognized.

The current implementation seems to assume that the block boundary is
always at the end of the line, as shown in the following figure.

_______________
|def f():      |
|_____________ |
||    if 1:   ||
||________11__||
||    elif 2: ||
||________22__||
|______________|

On the other hand, Dima seems to expect the block boundary to be as
shown in the following figure.

_______________
|def f():      |
|    _________ |
| ___|if 1:  _||
||_______ 11|_ |
| ___|elif 2:_||
||_______ 22|  |
|______________|

Although both models may have pros and cons, the current
implementation seems more natural to me.  In particular, it would be
more natural for "elif" or "else" block to be adjacent to "if" block
with nothing else in between.

Regards,

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#57551: 29.0.50; hide-show in python-mode selects the current block imperfectly
Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= <andreas.roehler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 04 Sep 2022 17:03:01 +0000
Resent-Message-ID: <handler.57551.B.166231092625154 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 57551 <at> debbugs.gnu.org
Message-ID: <19c5c343-0a74-a8b3-055e-681d40a43b71@HIDDEN>
Date: Sun, 4 Sep 2022 19:01:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Content-Language: en-US
References: <87zgfhtqng.fsf@HIDDEN>
 <eke7zgff41cz.wl-kobarity@HIDDEN>
From: Andreas =?UTF-8?Q?R=C3=B6hler?= <andreas.roehler@HIDDEN>
In-Reply-To: <eke7zgff41cz.wl-kobarity@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: none client-ip=212.227.17.24;
 envelope-from=andreas.roehler@HIDDEN; helo=mout.kundenserver.de
X-Spam_score_int: -28
X-Spam_score: -2.9
X-Spam_bar: --
X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.978,
 SPF_HELO_NONE=0.001, SPF_NONE=0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Am 04.09.22 um 17:15 schrieb kobarity:
> Dima Kogan wrote:
>> But what if the point is at the start of the "elif 2:" line? Currently
>> emacs considers this to be INSIDE this block also, so (hs-hide-block)
>> there also hides the "elif 2" block, but should it? Would it not make
>> more sense if the START of the "elif 2:" line was considered in the "def
>> f():" block, but outside all the "if" blocks? Then (hs-hide-block) at
>> the start of that line would collapse the whole "def f():" block.
>> Currently the only point where this can be done is at the end of the
>> "def f():" line.
> Hi.  I think current hideshow behavior is in line with block
> navigation in Python mode.  For example, if the point is at the start
> of the "elif 2:" line, M-x python-nav-beginning-of-block moves the
> point to "e" of "elif 2:".  This implies that Emacs Python mode
> considers spaces before "elif 2:" to belong to the "elif 2:" block.
> So I think this is not a matter of hideshow, but of how the block
> should be recognized.
>
> The current implementation seems to assume that the block boundary is
> always at the end of the line, as shown in the following figure.
>
> _______________
> |def f():      |
> |_____________ |
> ||    if 1:   ||
> ||________11__||
> ||    elif 2: ||
> ||________22__||
> |______________|
>
> On the other hand, Dima seems to expect the block boundary to be as
> shown in the following figure.
>
> _______________
> |def f():      |
> |    _________ |
> | ___|if 1:  _||
> ||_______ 11|_ |
> | ___|elif 2:_||
> ||_______ 22|  |
> |______________|
>
> Although both models may have pros and cons, the current
> implementation seems more natural to me.  In particular, it would be
> more natural for "elif" or "else" block to be adjacent to "if" block
> with nothing else in between.
>
> Regards,
>
>
> Hi,

IMO the if-block starts at column 4, with "if". It ends at any column 
lower than 4 below that number 22.

Assume everything between with no regard of column as part of that block.

Best,

Andreas

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#57551: 29.0.50; hide-show in python-mode selects the current block imperfectly
Resent-From: Dima Kogan <dima@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 05 Sep 2022 07:49:01 +0000
Resent-Message-ID: <handler.57551.B57551.16623641018205 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 57551
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: kobarity <kobarity@HIDDEN>
Cc: 57551 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi@HIDDEN>
Received: via spool by 57551-submit <at> debbugs.gnu.org id=B57551.16623641018205
          (code B ref 57551); Mon, 05 Sep 2022 07:49:01 +0000
Received: (at 57551) by debbugs.gnu.org; 5 Sep 2022 07:48:21 +0000
Received: from localhost ([127.0.0.1]:46339 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oV6qD-00028H-7p
	for submit <at> debbugs.gnu.org; Mon, 05 Sep 2022 03:48:21 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:54455)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dima@HIDDEN>) id 1oV6qB-00027s-4Q
 for 57551 <at> debbugs.gnu.org; Mon, 05 Sep 2022 03:48:19 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id A9B2B5C006E;
 Mon,  5 Sep 2022 03:48:13 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Mon, 05 Sep 2022 03:48:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm3; t=1662364093; x=1662450493; bh=U7
 ljqoSrs8cGceatXAxggZEwfCDkUp2O/juNark6F0g=; b=qXFEWU1K2ZOayYU+RF
 hqKbfu213346JArjbhNq5n+hWuZqFVTvVLRMQl49ITqnPZEc4tNr8+237b3znAfn
 NTjCwLM2foYYrT29D26Fx/DFb4haa0ehBq2exZyzEfqbikdntBmqKWl80bfh1pOx
 Yqu83RT+3c6EyOQQLC1Fuh7Ndoy7+t/7dnap4iuLcarWtTqF5fepFLtCZe3J18k8
 a1LwDSxyuOTFd6mcV3N5SJgy2T7ZQgc9uWuth3CIndhBm2M6oIFAU2VzXmZb1jQV
 U6USRwmpUcZhBe+3tr429mvDZ1t81vPGqWnV63NF+16xLN6V4yOns/H/bUWh9Cn8
 roBQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1662364093; x=1662450493; bh=U7ljqoSrs8cGceatXAxggZEwfCDk
 Up2O/juNark6F0g=; b=fT4Cn96g2ox3B7h/ZzGgV7p2OXhGr7kHZXtxJfLfZHEM
 QNOLnCKeV9VNC/uazt/7xKisxtJc42lrcZA6pN4JYeVbWpPmF2lYLHmvq5yXmPvz
 U3hqUR7jZsKYfbv4TesHUZnltTJuGxn58o+y/7sp1do8MRrYORuwLbLaFfv4Itd6
 8H5Lm9TlYhAqJda7kRXu862iEPt1rVPsTHA2mGyj+AiCHLMuxrFQyErtGP0ApX7H
 eo4Vz1puYIBPn0EqncrS3azi9EDZkH3//2+aan+Z1x6ZqdGmx2FPwZmpwwxluXuW
 sFrrrHU/VNrC4iQUI4tDC1jnc1l1GyQBwE3jyLAN/g==
X-ME-Sender: <xms:vakVYzxbETj6FETsMyToo2EZTLKkvOV3Cwob0AQXrCbLIHLt6jzC7Q>
 <xme:vakVY7TcoeLDectDJOYSHyG58nlvOaRqCSty0P-l2mU83xs3fAg94L-RwSdkDcZXj
 at2n8iM0TIr3tY2>
X-ME-Received: <xmr:vakVY9UIhXD2b2KDgSkYi1rnOGeXfByqmVDgUvkT8R-zYpxVsXJAHvO0>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelhedguddvgecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpeffihhm
 rgcumfhoghgrnhcuoeguihhmrgesshgvtghrvghtshgruhgtvgdrnhgvtheqnecuggftrf
 grthhtvghrnhepgfeifeehgedvkeekvdevvdelvdegleevtedvueejvdejveduveeuleev
 leevudetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh
 epughimhgrsehsvggtrhgvthhsrghutggvrdhnvght
X-ME-Proxy: <xmx:vakVY9iM043xeOLgUl2j9XSrAa-NQKQsghUv3wTkAMGx0gW92nnP-w>
 <xmx:vakVY1DMANdKF3NrXjjNvhc9IR8IOieBo-_jIzOifxRA9ECgS7jwxw>
 <xmx:vakVY2J6jX2Kls7OnFmJUjZxT8sU6iBcfeTMFQEnB_umV3JNTVibPw>
 <xmx:vakVYy5bTkvGChQj0nVsPTTVJ_7Q6dlGyxx5vBbKjTG4m1Jjml0xng>
Feedback-ID: i3e8042a0:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 5 Sep 2022 03:48:13 -0400 (EDT)
References: <87zgfhtqng.fsf@HIDDEN>
 <eke7zgff41cz.wl-kobarity@HIDDEN>
User-agent: mu4e 1.8.7; emacs 29.0.50
From: Dima Kogan <dima@HIDDEN>
Date: Mon, 05 Sep 2022 00:44:22 -0700
In-reply-to: <eke7zgff41cz.wl-kobarity@HIDDEN>
Message-ID: <87tu5ms1mu.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi. Thanks for the analysis. I guess this isn't the right forum for this
discussion, but I'll put it here anyway. The reason I think the "if" and
"else" text and the preceding whitespace should be considered to lie
outside their block is that this is how cc-mode works. Consider the
C code equivalent to the Python code in the bug report:

void f(void)
{
    if(1)
    {
        11;
    }
    else if(2)
    {
        22;
    }
    else if(3)
    {
        33;
    }
    else if(4)
    {
        44;
    }
    else
    {
        5;
    }

    return 0;
}

Here (hs-hide-block) hides the if/else blocks ONLY if the point is
inside the {}. Otherwise, the whole f() is hidden.

Last modified: Mon, 5 Sep 2022 08:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.