GNU bug report logs - #57573
disarchive: Test "[prop] Writing is reversible" fails

Previous Next

Package: guix;

Reported by: Maxime Devos <maxime.devos <at> student.kuleuven.be>

Date: Sun, 4 Sep 2022 08:12:02 UTC

Severity: normal

To reply to this bug, email your comments to 57573 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to samplet <at> ngyro.com, bug-guix <at> gnu.org:
bug#57573; Package guix. (Sun, 04 Sep 2022 08:12:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Maxime Devos <maxime.devos <at> student.kuleuven.be>:
New bug report received and forwarded. Copy sent to samplet <at> ngyro.com, bug-guix <at> gnu.org. (Sun, 04 Sep 2022 08:12:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maxime.devos <at> student.kuleuven.be>
To: bug-guix <bug-guix <at> gnu.org>
Subject: disarchive: Test "[prop] Writing is reversible" fails
Date: Sun, 4 Sep 2022 10:11:08 +0200
X-Debbugs-CC: Timothy Sample <samplet <at> ngyro.com>

Hi,

disarchive fails to build (on core-updates, more precisely as part of 
the antiox jobset on ci.guix.gnu.org).

The failing test is:

> test-name: [prop] Writing is reversible
> location: tests/kinds/octal.scm:128
> source:
> + (test-assert
> +   "[prop] Writing is reversible"
> +   (quickcheck
> +     (property
> +       ((octal $octal))
> +       (test-when
> +         (valid-octal? octal)
> +         (begin
> +           (equal?
> +             octal
> +             (decode-octal (encode-octal octal))))))))
> Falsifiable after 25 tests.
> Seed: 318171092
> octal = #<<unstructured-octal> value: 0 source: #<<zero-string> value: 
> "0" trailer: "?">>
> actual-value: #f
> result: FAIL
(This appears to be a different test failure than in 
<https://issues.guix.gnu.org/48114>)

TBI ...

Greetings,
Maxime.





Information forwarded to bug-guix <at> gnu.org:
bug#57573; Package guix. (Sun, 04 Sep 2022 08:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 57573 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maxime.devos <at> student.kuleuven.be>
To: 57573 <at> debbugs.gnu.org
Cc: timothy sample <samplet <at> ngyro.com>
Subject: Re: bug#57573: disarchive: Test "[prop] Writing is reversible" fails
Date: Sun, 4 Sep 2022 10:24:15 +0200
Here's a reproducer:

(define o (make-unstructured-octal 0 (make-zero-string "0" #\䤄)))
(test-equal "Writing is reversible (#57573)"
        o (decode-octal (encode-octal octal)))





Information forwarded to bug-guix <at> gnu.org:
bug#57573; Package guix. (Sun, 04 Sep 2022 09:07:02 GMT) Full text and rfc822 format available.

Message #11 received at 57573 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maxime.devos <at> student.kuleuven.be>
To: 57573 <at> debbugs.gnu.org
Cc: timothy sample <samplet <at> ngyro.com>
Subject: Re: bug#57573: disarchive: Test "[prop] Writing is reversible" fails
Date: Sun, 4 Sep 2022 11:05:59 +0200
On 04-09-2022 10:24, Maxime Devos wrote:
> Here's a reproducer:
>
> (define o (make-unstructured-octal 0 (make-zero-string "0" #\䤄)))
> (test-equal "Writing is reversible (#57573)"
>         o (decode-octal (encode-octal octal)))
>
That was bogus (octal is undefined), try

>
> (define o (make-unstructured-octal 0 (make-zero-string "0" "䤄")))
> (unless (valid-octal? o) (error "oops"))
> (test-equal "Writing is reversible (#57573)"
>         o (decode-octal (encode-octal o)))
instead. Error message:
> test-name: Writing is reversible (#57573)
> location: tests/kinds/octal.scm:130
> source:
> + (test-equal
> +   "Writing is reversible (#57573)"
> +   o
> +   (decode-octal (encode-octal o)))
> expected-value: #<<unstructured-octal> value: 0 source: 
> #<<zero-string> value: "0" trailer: "䤄">>
> actual-value: #<<padded-octal> value: 0 width: 1 padding: #\0 trailer: 
> "䤄">
> result: FAIL
Greetings,
Maxime.





Information forwarded to bug-guix <at> gnu.org:
bug#57573; Package guix. (Thu, 08 Sep 2022 18:22:02 GMT) Full text and rfc822 format available.

Message #14 received at 57573 <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Maxime Devos <maxime.devos <at> student.kuleuven.be>
Cc: 57573 <at> debbugs.gnu.org
Subject: Re: bug#57573: disarchive: Test "[prop] Writing is reversible" fails
Date: Thu, 08 Sep 2022 12:21:31 -0600
Hi Maxime,

Maxime Devos <maxime.devos <at> student.kuleuven.be> writes:

> (define o (make-unstructured-octal 0 (make-zero-string "0" "䤄")))
> (unless (valid-octal? o) (error "oops"))
> (test-equal "Writing is reversible (#57573)"
>         o (decode-octal (encode-octal o)))

Right.  That unstructured octal should be invalid.  By the definition in
the code, it has too much “structure”.  It’s a test issue, the actual
code is fine.  I’ll patch the tests and make a point release in the
coming days.

Thanks for the heads up and the analysis, and sorry for the
inconvenience!


-- Tim

P.S. I’m excited about antioxidant – good work and happy hacking!




This bug report was last modified 1 year and 202 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.