GNU bug report logs - #57608
Upstreaming KDE Plasma and rest of packages

Previous Next

Package: guix-patches;

Reported by: phodina <phodina <at> protonmail.com>

Date: Tue, 6 Sep 2022 07:16:01 UTC

Severity: normal

Done: 宋文武 <iyzsong <at> envs.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57608 in the body.
You can then email your comments to 57608 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Tue, 06 Sep 2022 07:16:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to phodina <phodina <at> protonmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 06 Sep 2022 07:16:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxime Devos <maximedevos <at> telenet.be>, Brendan Tildesley <mail <at> brendan.scot>,
 Leo Famulari <leo <at> famulari.name>,
 "marekpasnikowski <at> protonmail.com" <marekpasnikowski <at> protonmail.com>,
 "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: Upstreaming KDE Plasma and rest of packages
Date: Tue, 06 Sep 2022 07:14:39 +0000
[Message part 1 (text/plain, inline)]
Hi Marius,

thanks for upstreaming the patches into staging. [1]

I've rebased the patches on your changes.

Unfortunately beside that I haven't had the time to go through them.

I just removed the kpurpose as it was pointed out by Brendan that the package is already there under the name purpose.

The patches are again tracked in the branch patch/upstream-kde [2]. Expect rebases as my next plan is to go through licenses and later tests + builds.

Also I added all of you in the CC since you were part of the patchset thread.

[1] https://issues.guix.gnu.org/50862
[2] https://github.com/phodina/guix/tree/patch/upstream-kde

----
Petr
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Mon, 19 Sep 2022 17:52:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxime Devos <maximedevos <at> telenet.be>, Brendan Tildesley <mail <at> brendan.scot>,
 Leo Famulari <leo <at> famulari.name>,
 "marekpasnikowski <at> protonmail.com" <marekpasnikowski <at> protonmail.com>,
 "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: Re: Upstreaming KDE Plasma and rest of packages
Date: Mon, 19 Sep 2022 17:50:24 +0000
[Message part 1 (text/plain, inline)]
Hi,

I've went over all the packages and prepared a new patch set.

----
Petr
------- Original Message -------
On Tuesday, September 6th, 2022 at 9:14 AM, phodina <phodina <at> protonmail.com> wrote:

> Hi Marius,
>
> thanks for upstreaming the patches into staging. [1]
>
> I've rebased the patches on your changes.
>
> Unfortunately beside that I haven't had the time to go through them.
>
> I just removed the kpurpose as it was pointed out by Brendan that the package is already there under the name purpose.
>
> The patches are again tracked in the branch patch/upstream-kde [2]. Expect rebases as my next plan is to go through licenses and later tests + builds.
>
> Also I added all of you in the CC since you were part of the patchset thread.
>
> [1] https://issues.guix.gnu.org/50862
> [2] https://github.com/phodina/guix/tree/patch/upstream-kde
>
> ----
> Petr
[Message part 2 (text/html, inline)]
[0001-gnu-Add-fwupd-service.patch (text/x-patch, attachment)]
[0010-gnu-libksysguard-Update-to-5.25.4.patch (text/x-patch, attachment)]
[0017-gnu-Add-kgamma.patch (text/x-patch, attachment)]
[0009-gnu-Remove-kqtquickcharts.patch (text/x-patch, attachment)]
[0015-gnu-Add-kio-fuse.patch (text/x-patch, attachment)]
[0054-gnu-Add-plasma-systemmonitor.patch (text/x-patch, attachment)]
[0034-gnu-Add-plasmatube.patch (text/x-patch, attachment)]
[0014-gnu-Add-kio-extras.patch (text/x-patch, attachment)]
[0032-gnu-Add-maliit-keyboard.patch (text/x-patch, attachment)]
[0013-gnu-Add-ksysguard.patch (text/x-patch, attachment)]
[0080-gnu-Add-plasma-mobile-sounds.patch (text/x-patch, attachment)]
[0002-gnu-ktouch-Remove-kqtquickcharts-form-inputs.patch (text/x-patch, attachment)]
[0047-gnu-packagekit-Remove-input-labels-and-use-gexp.patch (text/x-patch, attachment)]
[0066-gnu-Add-system-settings.patch (text/x-patch, attachment)]
[0008-gnu-akregator-Remove-kqtquickcharts-form-inputs.patch (text/x-patch, attachment)]
[0006-gnu-akregator-Use-G-Expression.-Fixes-build.patch (text/x-patch, attachment)]
[0012-gnu-Add-kwayland-integration.patch (text/x-patch, attachment)]
[0007-gnu-akregator-Fix-incorrect-package-source-hash-from.patch (text/x-patch, attachment)]
[0052-gnu-Add-kwallet-pam.patch (text/x-patch, attachment)]
[0033-gnu-Add-kitinerary.patch (text/x-patch, attachment)]
[0004-gnu-kio-Enable-2-tests.patch (text/x-patch, attachment)]
[0070-gnu-Add-khotkeys.patch (text/x-patch, attachment)]
[0011-gnu-libkscreen-Update-to-5.25.4.patch (text/x-patch, attachment)]
[0001-gnu-Add-kquickcharts.patch (text/x-patch, attachment)]
[0065-gnu-Add-plasma-workspace.patch (text/x-patch, attachment)]
[0016-gnu-Add-kpkpass.patch (text/x-patch, attachment)]
[0019-gnu-Add-kwrited.patch (text/x-patch, attachment)]
[0038-gnu-Add-plasma-vault.patch (text/x-patch, attachment)]
[0072-gnu-Add-plasma-browser-integration.patch (text/x-patch, attachment)]
[0073-gnu-Add-plasma-desktop.patch (text/x-patch, attachment)]
[0003-gnu-kwayland-Run-all-tests.patch (text/x-patch, attachment)]
[0081-gnu-Add-plasma-phonebook.patch (text/x-patch, attachment)]
[0018-gnu-Add-kscreen.patch (text/x-patch, attachment)]
[0005-gnu-kcontacts-Run-all-but-2-tests.patch (text/x-patch, attachment)]
[0050-gnu-Add-discover.patch (text/x-patch, attachment)]
[0020-gnu-Add-kmenuedit.patch (text/x-patch, attachment)]
[0041-gnu-Add-plasma-integration.patch (text/x-patch, attachment)]
[0024-gnu-Add-libaccounts-glib.patch (text/x-patch, attachment)]
[0049-gnu-Add-packagekit-qt5.patch (text/x-patch, attachment)]
[0035-gnu-Add-latte-dock.patch (text/x-patch, attachment)]
[0076-gnu-Add-plasma-nano.patch (text/x-patch, attachment)]
[0077-gnu-Add-plasma-phone-components.patch (text/x-patch, attachment)]
[0022-gnu-Add-kactivitymanagerd.patch (text/x-patch, attachment)]
[0046-gnu-Add-drkonqi.patch (text/x-patch, attachment)]
[0068-gnu-Add-kde-cli-tools.patch (text/x-patch, attachment)]
[0067-gnu-Add-kinfocenter.patch (text/x-patch, attachment)]
[0043-gnu-Add-plasma-disks.patch (text/x-patch, attachment)]
[0039-gnu-Add-plasma-pass.patch (text/x-patch, attachment)]
[0062-gnu-Add-kwin-effects-yet-another-magic-lamp.patch (text/x-patch, attachment)]
[0042-gnu-Add-plasma-pa.patch (text/x-patch, attachment)]
[0028-gnu-Add-libaccounts-qt.patch (text/x-patch, attachment)]
[0040-gnu-Add-plasma-nm.patch (text/x-patch, attachment)]
[0063-gnu-Add-plasma-workspace-wallpapers.patch (text/x-patch, attachment)]
[0056-gnu-Add-xdg-desktop-portal-kde.patch (text/x-patch, attachment)]
[0074-gnu-Add-plasma-meta-package.patch (text/x-patch, attachment)]
[0027-gnu-Add-kpublictransport.patch (text/x-patch, attachment)]
[0059-gnu-Add-calindori.patch (text/x-patch, attachment)]
[0045-gnu-Add-plasma-active-window-control.patch (text/x-patch, attachment)]
[0031-gnu-Add-maliit-framework.patch (text/x-patch, attachment)]
[0079-gnu-Add-plasma-mobile-settings.patch (text/x-patch, attachment)]
[0051-gnu-Add-ksystemstats.patch (text/x-patch, attachment)]
[0021-gnu-Add-kirigami-addons.patch (text/x-patch, attachment)]
[0069-gnu-Add-kdeplasma-addons.patch (text/x-patch, attachment)]
[0060-gnu-Add-bluedevil.patch (text/x-patch, attachment)]
[0071-gnu-Add-powerdevil.patch (text/x-patch, attachment)]
[0053-gnu-Add-milou.patch (text/x-patch, attachment)]
[0058-gnu-breeze-gtk-Update-to-5.25.4.patch (text/x-patch, attachment)]
[0025-gnu-Add-signond.patch (text/x-patch, attachment)]
[0037-gnu-Add-wacomtablet.patch (text/x-patch, attachment)]
[0036-gnu-Add-oxygen-sounds.patch (text/x-patch, attachment)]
[0030-gnu-Add-kaccounts-integration.patch (text/x-patch, attachment)]
[0023-gnu-Add-knetworkmanager.patch (text/x-patch, attachment)]
[0075-gnu-Add-plasma-desktop-service-type.patch (text/x-patch, attachment)]
[0055-gnu-Add-polkit-kde-agent.patch (text/x-patch, attachment)]
[0078-gnu-Add-plasma-mobile.patch (text/x-patch, attachment)]
[0044-gnu-Add-plasma-firewall.patch (text/x-patch, attachment)]
[0057-gnu-breeze-Update-to-5.25.4.patch (text/x-patch, attachment)]
[0026-gnu-Add-signon-plugin-oauth2.patch (text/x-patch, attachment)]
[0064-gnu-Add-appmenu-gtk-module.patch (text/x-patch, attachment)]
[0029-gnu-Add-libsignon-glib.patch (text/x-patch, attachment)]
[0048-gnu-packagekit-Update-to-1.2.5.patch (text/x-patch, attachment)]
[0061-gnu-Add-kwin.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Sat, 24 Sep 2022 13:14:01 GMT) Full text and rfc822 format available.

Message #11 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxime Devos <maximedevos <at> telenet.be>, Brendan Tildesley <mail <at> brendan.scot>,
 Leo Famulari <leo <at> famulari.name>,
 "marekpasnikowski <at> protonmail.com" <marekpasnikowski <at> protonmail.com>,
 "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 57608 <at> debbugs.gnu.org
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Sat, 24 Sep 2022 15:12:55 +0200
Hi!

An impressive patch series.  :-)

phodina <phodina <at> protonmail.com> skribis:

> From ce8fab8c61ade5c317445a5df26189e51061c1ec Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Wed, 7 Sep 2022 07:48:41 +0200
> Subject: [PATCH] gnu: Add fwupd service.
>
> * gnu/services/firmware.scm (fwupd): New variable.

Simply:

  * gnu/services/firmware.scm: New file.
  * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

… and actually add it to gnu/local.mk.

> +++ b/gnu/services/firmware.scm
> @@ -0,0 +1,70 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright ?? 2022 Petr Hodina <phodina <at> protonmail.com>

Typo.

> +(define-record-type* <fwupd-configuration> fwupd-configuration
> +                     make-fwupd-configuration fwupd-configuration?
> +                     (fwupd fwupd-configuration-fwupd
> +                            (default fwupd)))

Please indent in the same way as done elsewhere.

We’ll also need an entry in the manual for this one, maybe under
“Desktop Services”?

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Sat, 24 Sep 2022 13:16:02 GMT) Full text and rfc822 format available.

Message #14 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxime Devos <maximedevos <at> telenet.be>, Brendan Tildesley <mail <at> brendan.scot>,
 Leo Famulari <leo <at> famulari.name>,
 "marekpasnikowski <at> protonmail.com" <marekpasnikowski <at> protonmail.com>,
 "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 57608 <at> debbugs.gnu.org
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Sat, 24 Sep 2022 15:15:09 +0200
Hi,

phodina <phodina <at> protonmail.com> skribis:

> +    (home-page "https://invent.kde.org/plasma/plasma-pass")
> +    (synopsis "Plasma applet for the Pass password manager")
> +    (description "Provides Plasma applet for the Pass password manager.")

You’d save time by making sure details such as synopsis/description are
all right (info "(guix) Synopses and Descriptions").

Now I realize there’s a long list of people Cc’d so I’ll let’em check
the remaining patches and commit them if they deem it appropriate.
:-)

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Sun, 02 Oct 2022 17:15:02 GMT) Full text and rfc822 format available.

Message #17 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: Marek Paśnikowski <marekpasnikowski <at> protonmail.com>
To: 57608 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>, Brendan Tildesley <mail <at> brendan.scot>,
 Leo Famulari <leo <at> famulari.name>, "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>,
 phodina <phodina <at> protonmail.com>
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Sun, 02 Oct 2022 17:14:06 +0000
Good morning / evening.

Today my small Thinkpad finally finished building the new release of Plasma. In the system configuration, I declared `(service plasma-desktop-service-type)`, as my desire is just to see the KDE desktop. My testing methodology is to edit my Guix configuration on a testing branch and sequentially perform `guix pull`, `guix home reconfigure` and `guix system reconfigure`.

In order to perform this test I set `https://github.com/phodina/guix.git` as the Git remote and pulled the `patch/plasma` branch. I made no customizations to the repository.

The commit used is `d9ca04ca425915a7b991f3bcfa72b5b0e6f48e45`.

This time, I encountered several different issues during the rebuilds:
    1. (irrelevant to KDE) build of gnome-keyring fails on the `check` phase, so I had to comment `(service gnome-desktop-service-type)` out of my system configuration;
    2. `kaccounts-integration` appears to be defined in two files;
    3. the overall state of the Plasma Desktop regressed from a broken, but visible panel ( https://github.com/phodina/guix/issues/6 ) to no panel - at least the initial animation completes and the cursor moves;
    4. `(define-public plasma (package (version "5.25.4")))` in `kde-plasma.scm` sticks out from the rest of packages on version "5.25.5".

Below is a collection of log snippets relating to the aforementioned issues.
    1. ```$ zcat /var/log/guix/drvs/hp/ahf0x32fr2wsvp34wdnfl2dyf9m5bc-gnome-keyring-42.1.drv.gz
PASS: test-gnome2-private-key 1 /gnome2-store/private-key/load
PASS: test-gnome2-private-key 2 /gnome2-store/private-key/save
SKIP: test-import Bail out! Gck-FATAL-WARNING: couldn't close session properly: The module has not been initialized

(test-import:23825): Gck-WARNING **: 16:24:33.365: couldn't close session properly: The module has not been initialized
ERROR: test-import process failed: -5
PASS: test-initialize 1 /pkcs11/rpc-layer/initialize/normal
PASS: test-initialize 2 /pkcs11/rpc-layer/initialize/control
```
    2. ```WARNING: (gnu packages kde-plasma): `kaccounts-integration' imported from both (gnu packages kde) and (gnu packages kde-pim)```;
    3. ```$ sudo herd restart xorg-server -> $ sudo tail -f /var/log/messages -> Start user session in GDM

Oct 2 18:51:58 localhost elogind[282]: New session c11 of user marek.
Oct 2 18:52:10 localhost gnome-session-binary[22756]: WARNING: Lost name on bus: org.gnome.SessionManager
Oct 2 18:52:10 localhost gdm-x-session: GLib: Source ID 2 was not found when attempting to remove it
Oct 2 18:52:10 localhost gdm-session-worker: GLib-GObject: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
Oct 2 18:52:10 localhost elogind[282]: Removed session c10.
Oct 2 18:52:10 localhost pulseaudio[22793]: [pulseaudio] core-util.c: Failed to create secure directory (/run/user/975/pulse): No such file or directory
Oct 2 18:52:10 localhost gdm: Gdm: Child process -22742 was already dead.
Oct 2 18:52:47 localhost ntpd[281]: Soliciting pool server 94.23.94.78
Oct 2 18:52:49 localhost shepherd[1]: [dbus-daemon] Geoclue-Message: 18:52:49.433: Service not used for 60 seconds. Shutting down..
```




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Tue, 04 Oct 2022 06:53:02 GMT) Full text and rfc822 format available.

Message #20 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Marek Paśnikowski <marekpasnikowski <at> protonmail.com>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>, Brendan Tildesley <mail <at> brendan.scot>,
 Leo Famulari <leo <at> famulari.name>, "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 57608 <at> debbugs.gnu.org
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Tue, 04 Oct 2022 06:52:02 +0000
Hi Marek and Ludo',


> Good morning / evening.
> 
> Today my small Thinkpad finally finished building the new release of Plasma. In the system configuration, I declared `(service plasma-desktop-service-type)`, as my desire is just to see the KDE desktop. My testing methodology is to edit my Guix configuration on a testing branch and sequentially perform `guix pull`, `guix home reconfigure` and `guix system reconfigure`.
> 

Thanks for testing the build Marek!

Well building KDE takes definitely long time. Even more building the development version.
 
> In order to perform this test I set `https://github.com/phodina/guix.git` as the Git remote and pulled the `patch/plasma` branch. I made no customizations to the repository.
> 
> The commit used is `d9ca04ca425915a7b991f3bcfa72b5b0e6f48e45`.
> 
> This time, I encountered several different issues during the rebuilds:
> 1. (irrelevant to KDE) build of gnome-keyring fails on the `check` phase, so I had to comment `(service gnome-desktop-service-type)` out of my system configuration;

Haven't seen this one but there were some other gnome things (and others like gstreamer) that failed. Therefore I also disabled the `gnome-desktop-service-type`.

> 2. `kaccounts-integration` appears to be defined in two files;

Thanks in the new version (patchset - I've rebased the branch, you'll have to "downgrade" guix on the next pull) it's already removed and the locations for package definitions are revised.

> 3. the overall state of the Plasma Desktop regressed from a broken, but visible panel ( https://github.com/phodina/guix/issues/6 ) to no panel - at least the initial animation completes and the cursor moves;

The issue is caused by Guix "bug" in package `extra-cmake-modules`.

The problem is that the function `ecm_find_qmlmodule` looks for Qt6 modules - well attempts by launching `Qt6::qmlplugindump`.

I've tried to specify the TARGET and QT_MAJOR to Qt::5 and also removing the Qt6 branch in `extra-cmake-modules/modules/ECMFindQmlModule.cmake.in`.

Here's the excerpt of the build of `kwin`:
```
-- Could NOT find hwdata (missing: hwdata_FOUND hwdata_PNPIDS_FILE)
-- Found QtQuick-QMLModule: TRUE (found version "")
-- qmlplugindump failed for QtQuick.Controls.
-- Could NOT find QtQuick.Controls-QMLModule (missing: QtQuick.Controls-QMLModule_FOUND)
-- Found QtQuick.Layouts-QMLModule: TRUE (found version "")
-- Found QtQuick.Window-QMLModule: TRUE (found version "")
-- Found QtMultimedia-QMLModule: TRUE (found version "")
-- Found org.kde.kquickcontrolsaddons-QMLModule: TRUE (found version "")
-- qmlplugindump failed for org.kde.plasma.core.
-- Could NOT find org.kde.plasma.core-QMLModule (missing: org.kde.plasma.core-QMLModule_FOUND)
```

And when we check for qmlplugindump we get this:

```
/tmp/guix-build-kwin-5.25.5.drv-2/kwin-5.25.5$ grep -r qmlplugindump
Findorg.kde.plasma.components-QMLModule.cmake:    find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
Findorg.kde.plasma.components-QMLModule.cmake:    get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
Findorg.kde.plasma.components-QMLModule.cmake:    message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
Findorg.kde.plasma.components-QMLModule.cmake:    message(STATUS "qmlplugindump failed for org.kde.plasma.components.")
Findorg.kde.plasma.core-QMLModule.cmake:    find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
Findorg.kde.plasma.core-QMLModule.cmake:    get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
Findorg.kde.plasma.core-QMLModule.cmake:    message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
Findorg.kde.plasma.core-QMLModule.cmake:    message(STATUS "qmlplugindump failed for org.kde.plasma.core.")
Findorg.kde.kquickcontrolsaddons-QMLModule.cmake:    find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
Findorg.kde.kquickcontrolsaddons-QMLModule.cmake:    get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
Findorg.kde.kquickcontrolsaddons-QMLModule.cmake:    message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
Findorg.kde.kquickcontrolsaddons-QMLModule.cmake:    message(STATUS "qmlplugindump failed for org.kde.kquickcontrolsaddons.")
FindQtMultimedia-QMLModule.cmake:    find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
FindQtMultimedia-QMLModule.cmake:    get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
FindQtMultimedia-QMLModule.cmake:    message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
FindQtMultimedia-QMLModule.cmake:    message(STATUS "qmlplugindump failed for QtMultimedia.")
FindQtQuick.Window-QMLModule.cmake:    find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
FindQtQuick.Window-QMLModule.cmake:    get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
FindQtQuick.Window-QMLModule.cmake:    message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
FindQtQuick.Window-QMLModule.cmake:    message(STATUS "qmlplugindump failed for QtQuick.Window.")
FindQtQuick.Layouts-QMLModule.cmake:    find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
FindQtQuick.Layouts-QMLModule.cmake:    get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
FindQtQuick.Layouts-QMLModule.cmake:    message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
FindQtQuick.Layouts-QMLModule.cmake:    message(STATUS "qmlplugindump failed for QtQuick.Layouts.")
FindQtQuick.Controls-QMLModule.cmake:    find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
FindQtQuick.Controls-QMLModule.cmake:    get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
FindQtQuick.Controls-QMLModule.cmake:    message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
FindQtQuick.Controls-QMLModule.cmake:    message(STATUS "qmlplugindump failed for QtQuick.Controls.")
FindQtQuick-QMLModule.cmake:    find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
FindQtQuick-QMLModule.cmake:    get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
FindQtQuick-QMLModule.cmake:    message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
FindQtQuick-QMLModule.cmake:    message(STATUS "qmlplugindump failed for QtQuick.")
```

However, the `extra-cmake-modules` depends only on `qtbase-5` and just for tests. The incriminated program is part of different package:

``` 
find /gnu/store -iname qmlplugindump
/gnu/store/7dpp0vpli7f4j4idaj5iwcpra8hl3xfb-qtdeclarative-5.15.2/bin/qmlplugindump
```

So the solution is probably to add `qtdeclarative-5` to list of inputs. However the same problem might happen with Qt6 and maybe more extra modules.

Stay tuned for this one as I have to rebuild majority of the packages :-D

There is also bug about this in earlier verions of `extra-cmake-modules` but the code is deprecated if I apply the patch [1] and it does not solve the problem that Guix stores all in the `/gnu/store/`.

To add to my curiosity Nix does not appear to have this problem [2] but they use some `setup-hook.sh` [2] - needs more studying.
 
> 4. `(define-public plasma (package (version "5.25.4")))` in `kde-plasma.scm` sticks out from the rest of packages on version "5.25.5".

Thanks. It's also updated as well as the rest of the packages to the newest packages.


Regarding the fwdup-service - Ludo'. That patch was sent by mistake as I wanted to see the firmware version in KDE environment. But I'd rather leave it for separate patch as it applies to Gnome and cli tools as well.

I've also enabled more tests and rewritten Qt and other packages to use gexps. 

So the amount of patches is now about close to 160. But on the other hand it also now packages apps like Kalendar.


[1] https://gitweb.gentoo.org/repo/gentoo.git/diff/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.40.0-qmlplugindump-path.patch?id=13dec085bcd84e7c7c67ae53cd5152c08bc9213e
[2] https://github.com/NixOS/nixpkgs/blob/nixos-22.05/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/default.nix

----
Petr




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Tue, 04 Oct 2022 11:08:02 GMT) Full text and rfc822 format available.

Message #23 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: Marek Paśnikowski <marekpasnikowski <at> protonmail.com>
To: 57608 <at> debbugs.gnu.org, phodina <phodina <at> protonmail.com>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>, Brendan Tildesley <mail <at> brendan.scot>,
 Leo Famulari <leo <at> famulari.name>, "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Tue, 04 Oct 2022 11:07:12 +0000
The current branch (at commit
5b1a2c2b5eb2029a2330ee3a2bbd7b648f4cea5c ) can not be pulled
by guix. Should I bisect this?

Here is the build log:

```
marek <at> aisaka $ guix pull --allow-downgrades --disable-authentication
Updating channel 'guix' from Git repository at 'file:///home/marek/src/aisaka'...
guix pull: warning: moving channel 'guix' from f64c80a53843006aa96bbdb3d5286f67c7dc8d8f to unrelated commit 5b1a2c2b5eb2029a2330ee3a2bbd7b648f4cea5c
guix pull: warning: channel authentication disabled
Updating channel 'jeko' from Git repository at 'https://framagit.org/Jeko/guix-jeko-channel.git'...
guix pull: warning: channel authentication disabled
Building from these channels:
  jeko      https://framagit.org/Jeko/guix-jeko-channel.git     3c4fd0d
  guix      file:///home/marek/src/aisaka       5b1a2c2
Computing Guix derivation for 'x86_64-linux'... /
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 100.0%
The following derivation will be built:
  /gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv

building package cache...
/builder for `/gnu/store/bhnd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv' failed to produce output path `/gnu/store/rwd3d86r0b938mha6cxiyhi9y9nrv80f-guix-package-cache'
build of /gnu/store/bhnd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv failed
View build log at '/var/log/guix/drvs/bh/nd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv.gz'.
cannot build derivation `/gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv': 1 dependencies couldn't be built
guix pull: error: build of `/gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv' failed

marek <at> aisaka $ zcat /var/log/guix/drvs/bh/nd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv.gz 
(repl-version 0 1 1)
Generating package cache for '/gnu/store/9jk80ks6jz193b03mn92lvclr61w6dvf-profile'...

Backtrace:
In guix/memoization.scm:
    101:0 19 (_ #<hash-table 7fffe21a8500 1756/3517> #<package akon?> ?)
In guix/packages.scm:
  1249:12 18 (_)
In srfi/srfi-1.scm:
   460:18 17 (fold #<procedure 7fffe36c0700 at guix/packages.scm:12?> ?)
In guix/packages.scm:
  1253:42 16 (_ _ ("x86_64-linux"))
In guix/memoization.scm:
    101:0 15 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kio@?> ?)
In guix/packages.scm:
  1249:12 14 (_)
In srfi/srfi-1.scm:
   460:18 13 (fold #<procedure 7fffe36f3d20 at guix/packages.scm:12?> ?)
In guix/packages.scm:
  1253:42 12 (_ _ ("x86_64-linux"))
In guix/memoization.scm:
    101:0 11 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kdbu?> ?)
In guix/packages.scm:
  1249:12 10 (_)
In srfi/srfi-1.scm:
   460:18  9 (fold #<procedure 7fffe36f36e0 at guix/packages.scm:12?> ?)
In guix/packages.scm:
  1253:42  8 (_ _ ("x86_64-linux"))
In guix/memoization.scm:
    101:0  7 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kini?> ?)
In guix/packages.scm:
  1257:37  6 (_)
  1517:16  5 (package->bag _ _ _ #:graft? _)
  1622:43  4 (thunk)
In gnu/packages/kde-frameworks.scm:
  2655:44  3 (arguments #<package kinit <at> 5.98.0 guix/packages.scm:144?>)
In ice-9/boot-9.scm:
  1685:16  2 (raise-exception _ #:continuable? _)
  1780:13  1 (_ #<&compound-exception components: (#<&undefined-vari?>)
In unknown file:
           0 (backtrace #<undefined>)

(exception unbound-variable (value #f) (value "Unbound variable: ~S") (value (this-package-inputs)) (value #f))
```




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Tue, 04 Oct 2022 14:03:02 GMT) Full text and rfc822 format available.

Message #26 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: marekpasnikowski <at> protonmail.com, 57608 <at> debbugs.gnu.org
Cc: maxim.cournoyer <at> gmail.com, ludo <at> gnu.org, maximedevos <at> telenet.be,
 mail <at> brendan.scot, leo <at> famulari.name, marius <at> gnu.org,
 h.goebel <at> crazy-compilers.com
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Tue, 04 Oct 2022 14:01:48 +0000
[Message part 1 (text/plain, inline)]
I suggest to wait till tomorrow as I plan to make some additional changes and push them.

Now the branch is out of sync with my local machine where I rebuilt the patches due to change to `extra-cmake-modules`.

I'd like to test the code as I saw the issues about missing components were resolved in `kwin`.

Also I'd like to attach the patchset v2 here.

However it still might not result in fully working Plasma.

----
Petr

-------- Original Message --------
On Oct 4, 2022, 1:07 PM, Marek Paśnikowski wrote:

> The current branch (at commit
> 5b1a2c2b5eb2029a2330ee3a2bbd7b648f4cea5c ) can not be pulled
> by guix. Should I bisect this?
>
> Here is the build log:
>
> ```
> marek <at> aisaka $ guix pull --allow-downgrades --disable-authentication
> Updating channel 'guix' from Git repository at 'file:///home/marek/src/aisaka'...
> guix pull: warning: moving channel 'guix' from f64c80a53843006aa96bbdb3d5286f67c7dc8d8f to unrelated commit 5b1a2c2b5eb2029a2330ee3a2bbd7b648f4cea5c
> guix pull: warning: channel authentication disabled
> Updating channel 'jeko' from Git repository at 'https://framagit.org/Jeko/guix-jeko-channel.git'...
> guix pull: warning: channel authentication disabled
> Building from these channels:
> jeko https://framagit.org/Jeko/guix-jeko-channel.git 3c4fd0d
> guix file:///home/marek/src/aisaka 5b1a2c2
> Computing Guix derivation for 'x86_64-linux'... /
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 100.0%
> The following derivation will be built:
> /gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv
>
> building package cache...
> /builder for `/gnu/store/bhnd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv' failed to produce output path `/gnu/store/rwd3d86r0b938mha6cxiyhi9y9nrv80f-guix-package-cache'
> build of /gnu/store/bhnd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv failed
> View build log at '/var/log/guix/drvs/bh/nd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv.gz'.
> cannot build derivation `/gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv': 1 dependencies couldn't be built
> guix pull: error: build of `/gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv' failed
>
> marek <at> aisaka $ zcat /var/log/guix/drvs/bh/nd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv.gz
> (repl-version 0 1 1)
> Generating package cache for '/gnu/store/9jk80ks6jz193b03mn92lvclr61w6dvf-profile'...
>
> Backtrace:
> In guix/memoization.scm:
> 101:0 19 (_ #<hash-table 7fffe21a8500 1756/3517> #<package akon?> ?)
> In guix/packages.scm:
> 1249:12 18 (_)
> In srfi/srfi-1.scm:
> 460:18 17 (fold #<procedure 7fffe36c0700 at guix/packages.scm:12?> ?)
> In guix/packages.scm:
> 1253:42 16 (_ _ ("x86_64-linux"))
> In guix/memoization.scm:
> 101:0 15 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kio@?> ?)
> In guix/packages.scm:
> 1249:12 14 (_)
> In srfi/srfi-1.scm:
> 460:18 13 (fold #<procedure 7fffe36f3d20 at guix/packages.scm:12?> ?)
> In guix/packages.scm:
> 1253:42 12 (_ _ ("x86_64-linux"))
> In guix/memoization.scm:
> 101:0 11 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kdbu?> ?)
> In guix/packages.scm:
> 1249:12 10 (_)
> In srfi/srfi-1.scm:
> 460:18 9 (fold #<procedure 7fffe36f36e0 at guix/packages.scm:12?> ?)
> In guix/packages.scm:
> 1253:42 8 (_ _ ("x86_64-linux"))
> In guix/memoization.scm:
> 101:0 7 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kini?> ?)
> In guix/packages.scm:
> 1257:37 6 (_)
> 1517:16 5 (package->bag _ _ _ #:graft? _)
> 1622:43 4 (thunk)
> In gnu/packages/kde-frameworks.scm:
> 2655:44 3 (arguments #<package kinit <at> 5.98.0 guix/packages.scm:144?>)
> In ice-9/boot-9.scm:
> 1685:16 2 (raise-exception _ #:continuable? _)
> 1780:13 1 (_ #<&compound-exception components: (#<&undefined-vari?>)
> In unknown file:
> 0 (backtrace #<undefined>)
>
> (exception unbound-variable (value #f) (value "Unbound variable: ~S") (value (this-package-inputs)) (value #f))
> ```
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Thu, 06 Oct 2022 12:10:02 GMT) Full text and rfc822 format available.

Message #29 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: marekpasnikowski <at> protonmail.com, 57608 <at> debbugs.gnu.org
Cc: maxim.cournoyer <at> gmail.com, ludo <at> gnu.org, maximedevos <at> telenet.be,
 mail <at> brendan.scot, leo <at> famulari.name, marius <at> gnu.org,
 h.goebel <at> crazy-compilers.com
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Thu, 06 Oct 2022 12:09:24 +0000
[Message part 1 (text/plain, inline)]
So here are the patches. There are in tar as there is 171 of them :-)

- The last patch is for building a desktop if you want to test it and don't want to wait for the gnome desktop to be built.

- Package kwin-effects-yet-another-magic-lamp​ unfortunately broke due to update of kwin​ to 5.25.5.

- The other package is kapidox​ . There I tried to remove the phase `sanity-check` but there is still missing gv​ module

- Package discover​ runs but can't connect to whatever online so you don't get SW listed to install

- Some good news - kalendar​, itinerary​, kongress​ and other apps seem to work fine

- The deal breaker is that Plasma DE does not work ... yet. X11 displays black screen and wayland does not even start. I have dedicated machine where I intend to have a look into the issue by strace, going through logs etc.

- I also tried to update krita to 5.1.1 and ran out of space in tmpfs - it ate about 30 GB and failed ~90% of the build on clean machine with 32 GB of RAM. Is there a way to run build in different location - on the SSD/NVME/HDD?

I'll keep the branch plasma on github stable [1].

Any comments, reviews, testers and tips are welcome :-)

[1] https://github.com/phodina/guix/commit/a4d236529c260d27998ee48cd969fa52bfd3d62e
----
Petr

------- Original Message -------
On Tuesday, October 4th, 2022 at 4:01 PM, phodina <phodina <at> protonmail.com> wrote:

> I suggest to wait till tomorrow as I plan to make some additional changes and push them.
>
> Now the branch is out of sync with my local machine where I rebuilt the patches due to change to `extra-cmake-modules`.
>
> I'd like to test the code as I saw the issues about missing components were resolved in `kwin`.
>
> Also I'd like to attach the patchset v2 here.
>
> However it still might not result in fully working Plasma.
>
> ----
> Petr
>
> -------- Original Message --------
> On Oct 4, 2022, 1:07 PM, Marek Paśnikowski < marekpasnikowski <at> protonmail.com> wrote:
>
>> The current branch (at commit
>> 5b1a2c2b5eb2029a2330ee3a2bbd7b648f4cea5c ) can not be pulled
>> by guix. Should I bisect this?
>>
>> Here is the build log:
>>
>> ```
>> marek <at> aisaka $ guix pull --allow-downgrades --disable-authentication
>> Updating channel 'guix' from Git repository at 'file:///home/marek/src/aisaka'...
>> guix pull: warning: moving channel 'guix' from f64c80a53843006aa96bbdb3d5286f67c7dc8d8f to unrelated commit 5b1a2c2b5eb2029a2330ee3a2bbd7b648f4cea5c
>> guix pull: warning: channel authentication disabled
>> Updating channel 'jeko' from Git repository at 'https://framagit.org/Jeko/guix-jeko-channel.git'...
>> guix pull: warning: channel authentication disabled
>> Building from these channels:
>> jeko https://framagit.org/Jeko/guix-jeko-channel.git 3c4fd0d
>> guix file:///home/marek/src/aisaka 5b1a2c2
>> Computing Guix derivation for 'x86_64-linux'... /
>> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
>> substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 100.0%
>> The following derivation will be built:
>> /gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv
>>
>> building package cache...
>> /builder for `/gnu/store/bhnd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv' failed to produce output path `/gnu/store/rwd3d86r0b938mha6cxiyhi9y9nrv80f-guix-package-cache'
>> build of /gnu/store/bhnd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv failed
>> View build log at '/var/log/guix/drvs/bh/nd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv.gz'.
>> cannot build derivation `/gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv': 1 dependencies couldn't be built
>> guix pull: error: build of `/gnu/store/4f3n9qvm66g1znil24iqnx70jk9x7ysb-profile.drv' failed
>>
>> marek <at> aisaka $ zcat /var/log/guix/drvs/bh/nd46s8ki5iml29ndq6y93fxhllgjmd-guix-package-cache.drv.gz
>> (repl-version 0 1 1)
>> Generating package cache for '/gnu/store/9jk80ks6jz193b03mn92lvclr61w6dvf-profile'...
>>
>> Backtrace:
>> In guix/memoization.scm:
>> 101:0 19 (_ #<hash-table 7fffe21a8500 1756/3517> #<package akon?> ?)
>> In guix/packages.scm:
>> 1249:12 18 (_)
>> In srfi/srfi-1.scm:
>> 460:18 17 (fold #<procedure 7fffe36c0700 at guix/packages.scm:12?> ?)
>> In guix/packages.scm:
>> 1253:42 16 (_ _ ("x86_64-linux"))
>> In guix/memoization.scm:
>> 101:0 15 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kio@?> ?)
>> In guix/packages.scm:
>> 1249:12 14 (_)
>> In srfi/srfi-1.scm:
>> 460:18 13 (fold #<procedure 7fffe36f3d20 at guix/packages.scm:12?> ?)
>> In guix/packages.scm:
>> 1253:42 12 (_ _ ("x86_64-linux"))
>> In guix/memoization.scm:
>> 101:0 11 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kdbu?> ?)
>> In guix/packages.scm:
>> 1249:12 10 (_)
>> In srfi/srfi-1.scm:
>> 460:18 9 (fold #<procedure 7fffe36f36e0 at guix/packages.scm:12?> ?)
>> In guix/packages.scm:
>> 1253:42 8 (_ _ ("x86_64-linux"))
>> In guix/memoization.scm:
>> 101:0 7 (_ #<hash-table 7fffe21a8500 1756/3517> #<package kini?> ?)
>> In guix/packages.scm:
>> 1257:37 6 (_)
>> 1517:16 5 (package->bag _ _ _ #:graft? _)
>> 1622:43 4 (thunk)
>> In gnu/packages/kde-frameworks.scm:
>> 2655:44 3 (arguments #<package kinit <at> 5.98.0 guix/packages.scm:144?>)
>> In ice-9/boot-9.scm:
>> 1685:16 2 (raise-exception _ #:continuable? _)
>> 1780:13 1 (_ #<&compound-exception components: (#<&undefined-vari?>)
>> In unknown file:
>> 0 (backtrace #<undefined>)
>>
>> (exception unbound-variable (value #f) (value "Unbound variable: ~S") (value (this-package-inputs)) (value #f))
>> ```
[Message part 2 (text/html, inline)]
[kde-plasma-guix.tar.gz (application/gzip, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Thu, 06 Oct 2022 18:37:02 GMT) Full text and rfc822 format available.

Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <kiasoc5 <at> disroot.org>
To: phodina via Guix-patches via <guix-patches <at> gnu.org>
Cc: maxim.cournoyer <at> gmail.com, ludo <at> gnu.org, maximedevos <at> telenet.be,
 mail <at> brendan.scot, leo <at> famulari.name, marekpasnikowski <at> protonmail.com,
 marius <at> gnu.org, h.goebel <at> crazy-compilers.com, 57608 <at> debbugs.gnu.org,
 phodina <phodina <at> protonmail.com>
Subject: Re: [bug#57608] Upstreaming KDE Plasma and rest of packages
Date: Thu, 6 Oct 2022 18:29:58 +0000
On Thu, Oct 06 2022, 12:09:24 PM +0000
phodina via Guix-patches via <guix-patches <at> gnu.org> wrote:

> - The deal breaker is that Plasma DE does not work ... yet. X11
> displays black screen and wayland does not even start. I have
> dedicated machine where I intend to have a look into the issue by
> strace, going through logs etc.

Maybe https://issues.guix.gnu.org/57742 is a factor for blocking the
wayland session?

-- 




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Thu, 06 Oct 2022 18:37:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Fri, 07 Oct 2022 12:59:02 GMT) Full text and rfc822 format available.

Message #38 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: kiasoc5 <kiasoc5 <at> disroot.org>
Cc: maxim.cournoyer <at> gmail.com, ludo <at> gnu.org, maximedevos <at> telenet.be,
 mail <at> brendan.scot, leo <at> famulari.name, marekpasnikowski <at> protonmail.com,
 marius <at> gnu.org, h.goebel <at> crazy-compilers.com, 57608 <at> debbugs.gnu.org,
 phodina via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#57608] Upstreaming KDE Plasma and rest of packages
Date: Fri, 07 Oct 2022 12:57:44 +0000
> On Thu, Oct 06 2022, 12:09:24 PM +0000
> phodina via Guix-patches via guix-patches <at> gnu.org wrote:
> 
> > - The deal breaker is that Plasma DE does not work ... yet. X11
> > displays black screen and wayland does not even start. I have
> > dedicated machine where I intend to have a look into the issue by
> > strace, going through logs etc.
> 
> 
> Maybe https://issues.guix.gnu.org/57742 is a factor for blocking the
> wayland session?
> 
> --

Thanks for the tip.

Also there is issue with the KCM modules that they were not found. So I had to patch package `extra-cmake-modules` and add more runtime Qt dependencies.

----
Petr




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Fri, 07 Oct 2022 12:59:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Fri, 07 Oct 2022 14:10:01 GMT) Full text and rfc822 format available.

Message #44 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: phodina <phodina <at> protonmail.com>
Cc: ludo <at> gnu.org, maximedevos <at> telenet.be, mail <at> brendan.scot, leo <at> famulari.name,
 kiasoc5 <kiasoc5 <at> disroot.org>, marekpasnikowski <at> protonmail.com, marius <at> gnu.org,
 h.goebel <at> crazy-compilers.com, 57608 <at> debbugs.gnu.org,
 phodina via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#57608] Upstreaming KDE Plasma and rest of packages
Date: Fri, 07 Oct 2022 10:09:45 -0400
Hi,

phodina <phodina <at> protonmail.com> writes:

>> On Thu, Oct 06 2022, 12:09:24 PM +0000
>> phodina via Guix-patches via guix-patches <at> gnu.org wrote:
>> 
>> > - The deal breaker is that Plasma DE does not work ... yet. X11
>> > displays black screen and wayland does not even start. I have
>> > dedicated machine where I intend to have a look into the issue by
>> > strace, going through logs etc.
>> 
>> 
>> Maybe https://issues.guix.gnu.org/57742 is a factor for blocking the
>> wayland session?
>> 
>> --
>
> Thanks for the tip.
>
> Also there is issue with the KCM modules that they were not found. So
> I had to patch package `extra-cmake-modules` and add more runtime Qt
> dependencies.

I think a basic, easy change we could do is restoring QT_PLUGIN_PATH for
Qt6 *only*.  This would fix things like wayland support, by having
qtwayland available in the user profile, while providing some incentive
to upgrade Qt5 packages to Qt6 :-).

Still, requiring the user to manually install qtwayland in their user
profile sounds suboptimal.  Perhaps qt-build-system should simply
propagate it?

--8<---------------cut here---------------start------------->8---
$ guix size qtbase
[...]
total: 1419.4 MiB

$ guix size qtwayland
[...]
total: 1575.9 MiB
--8<---------------cut here---------------end--------------->8---

So, a ~10% increase in size would mean qt applications just works, on
either xorg or wayland sessions, right?

And if we do it this way, we do not need to change any of the current
QT_PLUGIN_PATH wrapping.  Unless there are other Qt plugins that really
make more sense to be used as plugins, rather than hard dependencies?

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Fri, 07 Oct 2022 14:11:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Mon, 10 Oct 2022 13:04:01 GMT) Full text and rfc822 format available.

Message #50 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marek Paśnikowski <marekpasnikowski <at> protonmail.com>
To: phodina <phodina <at> protonmail.com>, 57608 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, ludo <at> gnu.org,
 maximedevos <at> telenet.be, mail <at> brendan.scot, leo <at> famulari.name,
 kiasoc5 <kiasoc5 <at> disroot.org>, marius <at> gnu.org, h.goebel <at> crazy-compilers.com,
 phodina via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#57608] Upstreaming KDE Plasma and rest of packages
Date: Mon, 10 Oct 2022 13:03:25 +0000
It's me again, with a build report of this version of patches.
This time it is very short, because there is no visible change in
state of (plasma-desktop-service-type).

The whole set of changes got built, with one irregularity.
Like previously, gnome-keyring failed in its 'check' phase.
I decided to bisect that after completing the Plasma Desktop on its
own.
I commented out both the Plasma and Gnome declarations
and bisected,
and declared installation of "gnome-keyring" package.
It kept building fine up to the git HEAD.
That was weird, so I tried bisecting the whole
(gnome-desktop-service-type).
This also built fine.
At this point, adding the (plasma-desktop-service-type) was
also fine, and now I have everything built just fine.

The commit used is "a4d236529c260d27998ee48cd969fa52bfd3d62e".

The branch used is "patch/plasma".

I have no idea why the previously failing test suddenly passed.
Should I report this weird behavior as an another issue?




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Mon, 10 Oct 2022 13:04:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Sat, 29 Oct 2022 12:01:02 GMT) Full text and rfc822 format available.

Message #56 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: phodina <phodina <at> protonmail.com>, Guix Patches <guix-patches <at> gnu.org>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxime Devos <maximedevos <at> telenet.be>, Leo Famulari <leo <at> famulari.name>,
 "marekpasnikowski <at> protonmail.com" <marekpasnikowski <at> protonmail.com>,
 "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: Re: Upstreaming KDE Plasma and rest of packages
Date: Sat, 29 Oct 2022 11:59:46 +0000
Another issue is that Dolphin does not create/display thumbnails and 
reports:

kf.service.services: KServiceTypeTrader: serviceType "ThumbCreator" not 
found

I packaged kdegraphics-thumbnailers. But adding that didn't make a 
difference.
Have you had a go at this phodina?




(define-public kdegraphics-thumbnailers
  (package
    (name "kdegraphics-thumbnailers")
    (version "22.08.2")
    (source
     (origin
       (method url-fetch)
       (uri (string-append "mirror://kde/stable/release-service/" version
                           "/src/" name "-" version ".tar.xz"))

       (sha256
        (base32 "1ppgc5yh23fgfkwzjirrkv5w7y23xlpf3ijgaw8wgm7kbm61i5y0"))))
    (build-system cmake-build-system)
    (native-inputs
     (list extra-cmake-modules))
    (inputs
     (list karchive
           kdegraphics-mobipocket
           ki18n
           kio
           libkexiv2
           qtbase-5))
    (home-page "")
    (synopsis "")
    (description "")
    (license #f)))




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Sat, 29 Oct 2022 20:34:01 GMT) Full text and rfc822 format available.

Message #59 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marek Paśnikowski <marekpasnikowski <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>,
 "mail <at> brendan.scot" <mail <at> brendan.scot>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxime Devos <maximedevos <at> telenet.be>, Leo Famulari <leo <at> famulari.name>,
 "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>,
 phodina <phodina <at> protonmail.com>
Subject: Re: Upstreaming KDE Plasma and rest of packages
Date: Sat, 29 Oct 2022 20:32:49 +0000
------- Original Message -------
sobota, 29 października 2022 13:59, Brendan Tildesley <mail <at> brendan.scot> napisał(a):

> Another issue is that Dolphin does not create/display thumbnails 

Is that Dolphin opened in GNOME desktop or in Plasma desktop?
I am asking because Plasma Desktop fails to produce anything more
than a black screen in the current state of the patches.

I would also like to take this opportunity to share a couple of
links related to the process of Plasma Desktop installation, which
I found this week.

[Qt/KDE applications segfault on start due to stale qmlcache][1]
[KDE Community page on kdesrc-build build-system][2]
[Script to streamline setting up and maintaining KDE software][3]

I wish I could experiment with the KDESRC system, but I am still
struggling with packaging a simple GNOME extension, so I am not
ready for this.

[1]: https://github.com/NixOS/nixpkgs/issues/177720
[2]: https://community.kde.org/Get_Involved/development#Building_software_with_kdesrc-build
[3]: https://invent.kde.org/sdk/kdesrc-build




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Sat, 29 Oct 2022 23:50:01 GMT) Full text and rfc822 format available.

Message #62 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: Marek Paśnikowski <marekpasnikowski <at> protonmail.com>,
 Guix Patches <guix-patches <at> gnu.org>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxime Devos <maximedevos <at> telenet.be>, Leo Famulari <leo <at> famulari.name>,
 "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>,
 phodina <phodina <at> protonmail.com>
Subject: Re: Upstreaming KDE Plasma and rest of packages
Date: Sat, 29 Oct 2022 23:49:25 +0000

On 29/10/22 20:32, Marek Paśnikowski wrote:
> ------- Original Message -------
> sobota, 29 października 2022 13:59, Brendan Tildesley <mail <at> brendan.scot> napisał(a):
>
>> Another issue is that Dolphin does not create/display thumbnails
> Is that Dolphin opened in GNOME desktop or in Plasma desktop?
> I am asking because Plasma Desktop fails to produce anything more
> than a black screen in the current state of the patches.
I'm in XFCE, just testing with guix shell dolphin -- dolphin
> I would also like to take this opportunity to share a couple of
> links related to the process of Plasma Desktop installation, which
> I found this week.
>
> [Qt/KDE applications segfault on start due to stale qmlcache][1]
> [KDE Community page on kdesrc-build build-system][2]
> [Script to streamline setting up and maintaining KDE software][3]
>
> I wish I could experiment with the KDESRC system, but I am still
> struggling with packaging a simple GNOME extension, so I am not
> ready for this.
>
> [1]: https://github.com/NixOS/nixpkgs/issues/177720
> [2]: https://community.kde.org/Get_Involved/development#Building_software_with_kdesrc-build
> [3]: https://invent.kde.org/sdk/kdesrc-build





Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Mon, 31 Oct 2022 07:44:02 GMT) Full text and rfc822 format available.

Message #65 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: "57608 <at> debbugs.gnu.org" <57608 <at> debbugs.gnu.org>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxime Devos <maximedevos <at> telenet.be>, "mail <at> brendan.scot" <mail <at> brendan.scot>,
 Leo Famulari <leo <at> famulari.name>,
 Marek Paśnikowski <marekpasnikowski <at> protonmail.com>,
 "marius <at> gnu.org" <marius <at> gnu.org>,
 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: Re: Upstreaming KDE Plasma and rest of packages
Date: Mon, 31 Oct 2022 07:42:47 +0000
[Message part 1 (text/plain, inline)]
Hi,

> 
> > Another issue is that Dolphin does not create/display thumbnails
> 
> 
> Is that Dolphin opened in GNOME desktop or in Plasma desktop?
> I am asking because Plasma Desktop fails to produce anything more
> than a black screen in the current state of the patches.

Well since Plasma is not yet running it's probably Dolphin in Gnome or other DE. Not sure why thumbnails are missing, but let's note issues about all the KDE programs.
 
> 
> I would also like to take this opportunity to share a couple of
> links related to the process of Plasma Desktop installation, which
> I found this week.
> 
> [Qt/KDE applications segfault on start due to stale qmlcache][1]
> [KDE Community page on kdesrc-build build-system][2]
> [Script to streamline setting up and maintaining KDE software][3]
> 
> I wish I could experiment with the KDESRC system, but I am still
> struggling with packaging a simple GNOME extension, so I am not
> ready for this.
> 
> [1]: https://github.com/NixOS/nixpkgs/issues/177720
> [2]: https://community.kde.org/Get_Involved/development#Building_software_with_kdesrc-build
> [3]: https://invent.kde.org/sdk/kdesrc-build

Thanks for the links. The issue is probably not in the KDESRC itself but in the Qt Framework.

I've been looking into Nix and they have additional patches. I managed to apply some of them.

But then the most needed  could not get to work (marked with ! in the commit).

Would somebody know how to port them into Guix?
It's mostly about CMake and QML. Which is what fails during the `kwin` and `plasma-workspace` build. Therefore they built but are broken when run.

----
Petr
[0002-gnu-qtbase-5-Apply-patch-qtbase-assert.patch.patch (text/x-patch, attachment)]
[0004-gnu-qtbase-5-Apply-qtbase-tbd-frameworks.patch.patch (text/x-patch, attachment)]
[0001-gnu-plasma-workspace-Add-xorg-server-for-tests-in-na.patch (text/x-patch, attachment)]
[0008-gnu-qtbase-5-Apply-qtbase-fix-header_module.patch.patch (text/x-patch, attachment)]
[0005-gnu-qtbase-5-Apply-qtbase-qtpluginpath.patch.patch (text/x-patch, attachment)]
[0006-gnu-qtdeclarative-5-Apply-qtdeclarative.patch.patch (text/x-patch, attachment)]
[0003-gnu-qtbase-5-Apply-qtbase-xcursor.patch.patch (text/x-patch, attachment)]
[0007-gnu-qtbase-5-Apply-qtbase-cmake.patch.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Mon, 21 Nov 2022 21:12:01 GMT) Full text and rfc822 format available.

Message #68 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: phodina <phodina <at> protonmail.com>, marekpasnikowski <at> protonmail.com,
 57608 <at> debbugs.gnu.org
Cc: maxim.cournoyer <at> gmail.com, ludo <at> gnu.org, maximedevos <at> telenet.be,
 mail <at> brendan.scot, leo <at> famulari.name, h.goebel <at> crazy-compilers.com
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Mon, 21 Nov 2022 22:11:34 +0100
[Message part 1 (text/plain, inline)]
phodina <phodina <at> protonmail.com> skriver:

> So here are the patches. There are in tar as there is 171 of them :-)
>
> - The last patch is for building a desktop if you want to test it and don't want to wait for the gnome desktop to be built.
>
> - Package kwin-effects-yet-another-magic-lamp​ unfortunately broke due to update of kwin​ to 5.25.5.
>
> - The other package is kapidox​ . There I tried to remove the phase `sanity-check` but there is still missing gv​ module
>
> - Package discover​ runs but can't connect to whatever online so you don't get SW listed to install
>
> - Some good news - kalendar​, itinerary​, kongress​ and other apps seem to work fine
>
> - The deal breaker is that Plasma DE does not work ... yet. X11 displays black screen and wayland does not even start. I have dedicated machine where I intend to have a look into the issue by strace, going through logs etc.
>
> - I also tried to update krita to 5.1.1 and ran out of space in tmpfs - it ate about 30 GB and failed ~90% of the build on clean machine with 32 GB of RAM. Is there a way to run build in different location - on the SSD/NVME/HDD?
>
> I'll keep the branch plasma on github stable [1].

Awesome work Petr.  :-)

I went through the branch and applied most of the patches.  With a few
changes:

* shortened multi-line URLs
* added (file-name ...) for git sources
* removed knetworkmanager -- AFAICT it is identical to networkmanager-qt
* switched to git-fetch for packages that were downloading tarballs from
  the KDE GitLab.  This is because such autogenerated tarballs are not
  stable: they may get regenerated with a different hash.
* dropped the !! commits
* Minor tweaks to synopses and descriptions
* A few commits had a random edit to a different package: I reverted
  those edits.  An example:
  https://github.com/phodina/guix/commit/5eaa9c49a78eed419db7847668a55c079bad5b71
* Removed use of direct variable references, i.e. #$qtbase.  Always use
  (search-input-file ...), (search-input-directory ...) or as a last
  resort #$(this-package-input "foo").
* Skipped commits that would trigger a lot of rebuilds, e.g. gpgme.
* Skipped cosmetic commits such as using G-expressions in Qt packages;
  mainly because of rebuilds, but also because they were not indented
  properly.  Some also introduced direct #$variable references.
* Dropped the plasma-desktop-service since it was not working for me.

For later reference, when adding patches, please add a sentence or two
at the top of the patch describing what it does.  I did not edit the
patches (except for a long file name), because I did not know what it
was for.  Presumably you did; future you will thank you!

Pushed to 'master' as fe3be8d5e0..82804298ad !
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Tue, 22 Nov 2022 10:21:01 GMT) Full text and rfc822 format available.

Message #71 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Marius Bakke <marius <at> gnu.org>
Cc: maxim.cournoyer <at> gmail.com, ludo <at> gnu.org, maximedevos <at> telenet.be,
 mail <at> brendan.scot, leo <at> famulari.name, marekpasnikowski <at> protonmail.com,
 h.goebel <at> crazy-compilers.com, 57608 <at> debbugs.gnu.org
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Tue, 22 Nov 2022 10:20:36 +0000
Hi Marius,

Thanks for the review and push to master!

> Awesome work Petr. :-)
> 
> I went through the branch and applied most of the patches. With a few
> changes:
> 
> * shortened multi-line URLs

Sorry I used the formatter ('guix style') and it set the URLs as such).

> * added (file-name ...) for git sources
> * removed knetworkmanager -- AFAICT it is identical to networkmanager-qt
> * switched to git-fetch for packages that were downloading tarballs from
> the KDE GitLab. This is because such autogenerated tarballs are not
> stable: they may get regenerated with a different hash.

Is this issue somewhere described? I've lately used more tarballs to git download on other packages. Is the issue connected with any Gitlab/Forge or just the KDE and the release scripts?

> * dropped the !! commits
> * Minor tweaks to synopses and descriptions

My apologies as I noticed there were few packages with wrong license or missing description.

> * A few commits had a random edit to a different package: I reverted
> those edits. An example:
> https://github.com/phodina/guix/commit/5eaa9c49a78eed419db7847668a55c079bad5b71

Caused due to rebasing and working on a large patchset. I'll split it next time and sent it by smaller parts.

> * Removed use of direct variable references, i.e. #$qtbase. Always use
> (search-input-file ...), (search-input-directory ...) or as a last
> resort #$(this-package-input "foo").

Thanks for the hint. I'll fix all the packages where I use this syntax!
 
> * Skipped commits that would trigger a lot of rebuilds, e.g. gpgme.

I'll submit it in new ticket.

> * Skipped cosmetic commits such as using G-expressions in Qt packages;
> mainly because of rebuilds, but also because they were not indented
> properly. Some also introduced direct #$variable references.

I'll fix the issues and submit it as a new ticket.

> * Dropped the plasma-desktop-service since it was not working for me.

Should we keep this ticket open to package also the plasma-desktop-service?
I'll try it now and see what causes the Plasma not to work.

> For later reference, when adding patches, please add a sentence or two
> at the top of the patch describing what it does. I did not edit the
> patches (except for a long file name), because I did not know what it
> was for. Presumably you did; future you will thank you!
> 
> Pushed to 'master' as fe3be8d5e0..82804298ad !

Sorry I didn't intend to add so many changes and it's been a challenge that taught me some new lessons.

I'll definitely add more description for the reviewers and keep it smaller so I doesn't take long time to review.

----
Petr




Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Tue, 22 Nov 2022 10:57:01 GMT) Full text and rfc822 format available.

Message #74 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: maxim.cournoyer <at> gmail.com, ludo <at> gnu.org, maximedevos <at> telenet.be,
 mail <at> brendan.scot, leo <at> famulari.name, marekpasnikowski <at> protonmail.com,
 h.goebel <at> crazy-compilers.com, 57608 <at> debbugs.gnu.org
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Tue, 22 Nov 2022 11:56:38 +0100
[Message part 1 (text/plain, inline)]
phodina <phodina <at> protonmail.com> skriver:

> Hi Marius,
>
> Thanks for the review and push to master!
>
>> Awesome work Petr. :-)
>> 
>> I went through the branch and applied most of the patches. With a few
>> changes:
>> 
>> * shortened multi-line URLs
>
> Sorry I used the formatter ('guix style') and it set the URLs as such).

Right.  It still has a few quirks that needs to be inched out...

>> * added (file-name ...) for git sources
>> * removed knetworkmanager -- AFAICT it is identical to networkmanager-qt
>> * switched to git-fetch for packages that were downloading tarballs from
>> the KDE GitLab. This is because such autogenerated tarballs are not
>> stable: they may get regenerated with a different hash.
>
> Is this issue somewhere described? I've lately used more tarballs to git download on other packages. Is the issue connected with any Gitlab/Forge or just the KDE and the release scripts?

We have this problem with all the forges.  There have been many-a bug
report about it, and the linter also warns about it (apparently for
GitHub only, that could be improved).

>> * dropped the !! commits
>> * Minor tweaks to synopses and descriptions
>
> My apologies as I noticed there were few packages with wrong license or missing description.

Oh, I did not license audit these packages as I assumed all the KDE
stuffs were using the same license.  Can you submit patches to update
the licenses?

>> * A few commits had a random edit to a different package: I reverted
>> those edits. An example:
>> https://github.com/phodina/guix/commit/5eaa9c49a78eed419db7847668a55c079bad5b71
>
> Caused due to rebasing and working on a large patchset. I'll split it next time and sent it by smaller parts.

No worries; this is what reviews are for.  :-)

>> * Removed use of direct variable references, i.e. #$qtbase. Always use
>> (search-input-file ...), (search-input-directory ...) or as a last
>> resort #$(this-package-input "foo").
>
> Thanks for the hint. I'll fix all the packages where I use this syntax!
>  
>> * Skipped commits that would trigger a lot of rebuilds, e.g. gpgme.
>
> I'll submit it in new ticket.

Note: I added a new version of gpgme and used it for the packages that
require it.  We already have the newest version on 'core-updates'.

>> * Skipped cosmetic commits such as using G-expressions in Qt packages;
>> mainly because of rebuilds, but also because they were not indented
>> properly. Some also introduced direct #$variable references.
>
> I'll fix the issues and submit it as a new ticket.

Great.

>> * Dropped the plasma-desktop-service since it was not working for me.
>
> Should we keep this ticket open to package also the plasma-desktop-service?
> I'll try it now and see what causes the Plasma not to work.

Let's keep this ticket open until we get past the finish line.  :-)

>> For later reference, when adding patches, please add a sentence or two
>> at the top of the patch describing what it does. I did not edit the
>> patches (except for a long file name), because I did not know what it
>> was for. Presumably you did; future you will thank you!
>> 
>> Pushed to 'master' as fe3be8d5e0..82804298ad !
>
> Sorry I didn't intend to add so many changes and it's been a challenge that taught me some new lessons.

It's easy to get lost in a huge patchset.  You did great!

> I'll definitely add more description for the reviewers and keep it smaller so I doesn't take long time to review.

Bite-sized PRs are more likely to get through, but I'm not sure we had a
lot of choice here given the scope of the project.

Ultimately someone just needs to muster enough courage to push it
forward.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Tue, 27 Dec 2022 21:17:01 GMT) Full text and rfc822 format available.

Message #77 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Marius Bakke <marius <at> gnu.org>
Cc: maxim.cournoyer <at> gmail.com, ludo <at> gnu.org, mail <at> brendan.scot,
 leo <at> famulari.name, marekpasnikowski <at> protonmail.com,
 h.goebel <at> crazy-compilers.com, 57608 <at> debbugs.gnu.org
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Tue, 27 Dec 2022 21:15:55 +0000
[Message part 1 (text/plain, inline)]
Hi Marius,





Sent with Proton Mail secure email.

------- Original Message -------
On Tuesday, November 22nd, 2022 at 11:56 AM, Marius Bakke <marius <at> gnu.org> wrote:


> > Is this issue somewhere described? I've lately used more tarballs to git download on other packages.
> > Is the issue connected with any Gitlab/Forge or just the KDE and the release scripts?
> 
> 
> We have this problem with all the forges. There have been many-a bug
> report about it, and the linter also warns about it (apparently for
> GitHub only, that could be improved).

Thanks for the explanation. I'll keep that in mind.
> 
> > > * dropped the !! commits
> > > * Minor tweaks to synopses and descriptions
> > 
> > My apologies as I noticed there were few packages with wrong license or missing description.
> 
> 
> Oh, I did not license audit these packages as I assumed all the KDE
> stuffs were using the same license. Can you submit patches to update
> the licenses?

I've tried to follow the licenses as submitted by the individual packages. I'm currently in process
of double checking.


I found out that the kinfocenter and systemsettings were not behaving correctly - no widgets were
rendered due to missing QML modules. The attached patch solves this.

I have some additional patches for kwin and plasma-workspace but they are not yet enough to launch
KDE desktop.

Also one "small" problem. As I switched to sway to test apps running under Wayland I noticed a pretty
important issue. None of the programs launched were running under Wayland - they ran in XWayland.

Is this known issue?

Do we need to modify the qt-build-system or cmake-build-system? Or shall we add wrap phase for each
package to add the correct path for qtwayland package in env variable QT_QPA_PLATFORM_PLUGIN_PATH?

```
$ echo $XDG_SESSION_TYPE
wayland
$ konsole
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
```

----
Petr
[0001-gnu-system-settings-Add-phase-wrap-executable-and-ad.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#57608; Package guix-patches. (Wed, 28 Dec 2022 00:49:01 GMT) Full text and rfc822 format available.

Message #80 received at 57608 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: phodina <phodina <at> protonmail.com>
Cc: ludo <at> gnu.org, mail <at> brendan.scot, leo <at> famulari.name,
 marekpasnikowski <at> protonmail.com, Marius Bakke <marius <at> gnu.org>,
 h.goebel <at> crazy-compilers.com, 57608 <at> debbugs.gnu.org
Subject: Re: bug#57608: Upstreaming KDE Plasma and rest of packages
Date: Tue, 27 Dec 2022 19:48:09 -0500
Hi Petr,

phodina <phodina <at> protonmail.com> writes:

[...]

> Also one "small" problem. As I switched to sway to test apps running under Wayland I noticed a pretty
> important issue. None of the programs launched were running under Wayland - they ran in XWayland.
>
> Is this known issue?

It's known as #57742.  If you add qtwayland to the inputs of the
packages making use of it, it'll get captured in the wrapper and it'll
work.

-- 
Thanks,
Maxim




Reply sent to 宋文武 <iyzsong <at> envs.net>:
You have taken responsibility. (Sat, 02 Sep 2023 04:24:02 GMT) Full text and rfc822 format available.

Notification sent to phodina <phodina <at> protonmail.com>:
bug acknowledged by developer. (Sat, 02 Sep 2023 04:24:02 GMT) Full text and rfc822 format available.

Message #85 received at 57608-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: phodina <phodina <at> protonmail.com>
Cc: 57608-done <at> debbugs.gnu.org
Subject: Re: [bug#57608] Upstreaming KDE Plasma and rest of packages
Date: Sat, 02 Sep 2023 12:23:25 +0800
phodina <phodina <at> protonmail.com> writes:

> [...]
>
> The patches are again tracked in the branch patch/upstream-kde [2]. Expect rebases as my next plan is to go
> through licenses and later tests + builds.

Hello, we have a working KDE plasma in master now, closing.

If there are still some changes needed, please rebase and open new
issues, thanks!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 30 Sep 2023 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 207 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.