GNU bug report logs - #57630
[PATCH] emms.el: Maintain original player list order when selecting a player

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57630 in the body.
You can then email your comments to 57630 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] emms.el: Maintain original player list order when selecting
 a player
Date: Tue, 06 Sep 2022 14:54:15 -0400

[Message part 1 (text/plain, inline)]

Hello!

I'm not sure where to send emms patches so I guess I'll send them here.

I struggled for quite a while to figure out why emms was using the
second player in my config instead of the first.  This fixes that issue.

Thanks,

Morgan

[0001-emms.el-Maintain-original-player-list-order-when-sel.patch (text/x-patch, attachment)]

Message #8 received at 57630 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: 57630 <at> debbugs.gnu.org, Yoni Rabkin <yoni <at> rabkins.net>
Subject: Re: bug#57630: [PATCH] emms.el: Maintain original player list order
 when selecting a player
Date: Tue, 06 Sep 2022 22:42:55 +0200

Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:

> I'm not sure where to send emms patches so I guess I'll send them here.
>
> I struggled for quite a while to figure out why emms was using the
> second player in my config instead of the first.  This fixes that issue.

The maintainer of emms is Yoni Rabkin; now added to the CCs.

Message #11 received at 57630 <at> debbugs.gnu.org (full text, mbox):

From: Yoni Rabkin <yoni <at> rabkins.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 57630 <at> debbugs.gnu.org
Subject: Re: bug#57630: [PATCH] emms.el: Maintain original player list order
 when selecting a player
Date: Tue, 06 Sep 2022 17:43:38 -0400

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:
>
>> I'm not sure where to send emms patches so I guess I'll send them here.
>>
>> I struggled for quite a while to figure out why emms was using the
>> second player in my config instead of the first.  This fixes that issue.
>
> The maintainer of emms is Yoni Rabkin; now added to the CCs.

Addressed in the Savannah git repo and will appear in the next
release. This issue can be closed.

The way to select a player is via the preferences system in
emms.el. However, I see no reason not to flip the order in which the
players are collected if that is of use to someone.

I went ahead and made that change, but using a different method.


-- 
   "Cut your own wood and it will warm you twice"

Message #14 received at 57630 <at> debbugs.gnu.org (full text, mbox):

From: Yoni Rabkin <yoni <at> rabkins.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 57630 <at> debbugs.gnu.org
Subject: Re: bug#57630: [PATCH] emms.el: Maintain original player list order
 when selecting a player
Date: Tue, 06 Sep 2022 17:45:43 -0400

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:
>
>> I'm not sure where to send emms patches so I guess I'll send them here.

Please send further correspondence to the emms mailing list at:
emms-help <at> gnu.org

-- 
   "Cut your own wood and it will warm you twice"

Message #17 received at 57630 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Yoni Rabkin <yoni <at> rabkins.net>
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 57630 <at> debbugs.gnu.org
Subject: Re: bug#57630: [PATCH] emms.el: Maintain original player list order
 when selecting a player
Date: Wed, 07 Sep 2022 00:03:04 +0200

Yoni Rabkin <yoni <at> rabkins.net> writes:

> Addressed in the Savannah git repo and will appear in the next
> release. This issue can be closed.

Thanks; closing this issue, then.

Message #22 received at 57630-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yoni Rabkin <yoni <at> rabkins.net>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 57630-done <at> debbugs.gnu.org
Subject: Re: bug#57630: [PATCH] emms.el: Maintain original player list order
 when selecting a player
Date: Tue, 6 Sep 2022 18:08:24 -0400

Yoni Rabkin <yoni <at> rabkins.net> writes:

> This issue can be closed.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.