GNU logs - #57635, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#57635: 29.0.50; Look into using generator.el's CPS machinery to replace 'eshell-do-eval'
Resent-From: Jim Porter <jporterbugs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 07 Sep 2022 03:59:02 +0000
Resent-Message-ID: <handler.57635.B.16625230864273 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 57635 <at> debbugs.gnu.org
From: Jim Porter <jporterbugs@HIDDEN>
Message-ID: <1766577e-022f-87ae-873e-875d84078891@HIDDEN>
Date: Tue, 6 Sep 2022 20:58:00 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::435;
 envelope-from=jporterbugs@HIDDEN; helo=mail-pf1-x435.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

In order to make long-running Eshell commands behave more-nicely, Eshell 
uses iterative evaluation of many commands so that it can return control 
back to the rest of Emacs. This has a lot of similarity to how 
generator.el works.

This would hopefully help prevent obscure bugs in Eshell, such as 
bug#54190. In that bug, Stefan mentions[1]:

> Looks like a bug somewhere in the `eshell-do-eval` machinery, yes.
> Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS
> converter of `generator.el`), I think reverting this change (and adding
> a comment pointing to this bug) sounds like a great plan.

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54190#17

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Jim Porter <jporterbugs@HIDDEN>
Subject: bug#57635: Acknowledgement (29.0.50; Look into using
 generator.el's CPS machinery to replace 'eshell-do-eval')
Message-ID: <handler.57635.B.16625230864273.ack <at> debbugs.gnu.org>
References: <1766577e-022f-87ae-873e-875d84078891@HIDDEN>
X-Gnu-PR-Message: ack 57635
X-Gnu-PR-Package: emacs
Reply-To: 57635 <at> debbugs.gnu.org
Date: Wed, 07 Sep 2022 03:59:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 57635 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
57635: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57635
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#57635: 29.0.50; Look into using generator.el's CPS machinery to replace 'eshell-do-eval'
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 07 Sep 2022 12:46:03 +0000
Resent-Message-ID: <handler.57635.B57635.16625547629436 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Jim Porter <jporterbugs@HIDDEN>
Cc: 57635 <at> debbugs.gnu.org
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <1766577e-022f-87ae-873e-875d84078891@HIDDEN> (Jim Porter's
 message of "Tue, 6 Sep 2022 20:58:00 -0700")
Message-ID: <jwv8rmvnym0.fsf-monnier+emacs@HIDDEN>
References: <1766577e-022f-87ae-873e-875d84078891@HIDDEN>
Date: Wed, 07 Sep 2022 08:45:52 -0400
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> In order to make long-running Eshell commands behave more-nicely, Eshell
> uses iterative evaluation of many commands so that it can return control
> back to the rest of Emacs. This has a lot of similarity to how
> generator.el works.

Indeed, the idea would be to replace the commands that launch processes
with "yields" to an external loop (that just launches the next process
and then calls the generator again).


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#57635: 29.0.50; Look into using generator.el's CPS machinery to replace 'eshell-do-eval'
Resent-From: Jim Porter <jporterbugs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 12 Sep 2022 01:02:01 +0000
Resent-Message-ID: <handler.57635.B57635.166294447722014 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Stefan Monnier <monnier@HIDDEN>
Cc: 57635 <at> debbugs.gnu.org
References: <1766577e-022f-87ae-873e-875d84078891@HIDDEN>
 <jwv8rmvnym0.fsf-monnier+emacs@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
Message-ID: <302b247c-2269-78ca-07e2-ad6c6f93fe1d@HIDDEN>
Date: Sun, 11 Sep 2022 18:01:04 -0700
MIME-Version: 1.0
In-Reply-To: <jwv8rmvnym0.fsf-monnier+emacs@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 9/7/2022 5:45 AM, Stefan Monnier via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Indeed, the idea would be to replace the commands that launch processes
> with "yields" to an external loop (that just launches the next process
> and then calls the generator again).

That part should be fairly straightforward; there's already 
'eshell-eval-command' and friends ('eshell-resume-command', 
'eshell-resume-eval', and 'eshell-do-eval'), which work pretty much like 
this already. Looking through this, I see a few main differences between 
how Eshell does things and how generator.el does things:

----------------------------------------

1) Eshell uses (throw 'eshell-defer) to yield

This is probably easy to fix, since it's only used in a couple places, 
and it looks like it's purely an implementation detail.

2) Eshell doesn't have anything like 'iter-defun'

Eshell just evaluates a Lisp form directly (you can see this by tracing 
'eshell-eval-command' and then running some external process in Eshell). 
I'm not sure how hard it would be to get generator.el to be ok with this.

3) Eshell allows replacing a form by throwing 'eshell-replace-command'

This is the trickiest part (to me, anyway). It's typically used by 
Eshell built-in commands when they want to give up and run an external 
process, though it can be used for a bunch of other things. I'm not sure 
what the best way to handle this via generator.el would be. Is there any 
straightforward way to do this?

----------------------------------------

If anyone has ideas, I'm all ears. This is pretty far down into the 
weeds of Lisp metaprogramming, so I'm just making some educated guesses 
here. I think doing this would be a big improvement for Eshell though, 
since I've already bumped up against a few cases that really look like 
they're just bugs in 'eshell-do-eval'. Moving to generator.el would 
hopefully fix those and make Eshell easier to maintain/improve.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 13 Oct 2022 13:47:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 13 09:47:46 2022
Received: from localhost ([127.0.0.1]:60026 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oiyYs-0005Dv-8Q
	for submit <at> debbugs.gnu.org; Thu, 13 Oct 2022 09:47:46 -0400
Received: from mail-oi1-f170.google.com ([209.85.167.170]:43632)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1oiyYn-0005CJ-0t
 for control <at> debbugs.gnu.org; Thu, 13 Oct 2022 09:47:41 -0400
Received: by mail-oi1-f170.google.com with SMTP id g10so1753033oif.10
 for <control <at> debbugs.gnu.org>; Thu, 13 Oct 2022 06:47:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=fRhbfIVOt0g1Gwwgy9iAqGuChB6k/GfjgrP8kyOXKVk=;
 b=hMCwfyW7xvRS03z5AWv0bA2qKozBlY7zfiRbe2ywpuwy/yNdg3xMVKZhBtW9obS0AK
 yWwBBITDsrGV75L2itbqWX3O5fgQoVM1eB0iF94GW4YfakUVMta+VfzjkPtic/Z2TjDu
 MVhitM3bkiAE5Zlt/5ClIkHhq9DaYkyJavHtEyj5oK9QxjEfBbdfAcQG+n32DQYifohu
 b7rxG3dyJKsk2p//6yDytX0lOIuKfQ9OUWJSFKDdRQo76R0+ygbA7X530wJSl0Gpk8YM
 Oo//euTKnXPnMkFZC7r1KWeKxtKr5JJbtFsW5VMbok/u7qjFg+aXehnpJ428OlemeuU3
 sd4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=fRhbfIVOt0g1Gwwgy9iAqGuChB6k/GfjgrP8kyOXKVk=;
 b=gGXiU/aAVq2Bt6teIvKUptMaoKOsUE6JyiFUaiytqWXabu5Oj5doOoJGF+VHeuIFYk
 0Gy/CAlEX3KWCgGHx3h75rQ9L441xhnc2ckT9nyQttzbiCfGFGY4z8L00+mjqTrOiO+u
 k0hPY7XPdNJJ54sFgH4CK9kmVZn/D/lcztJcdTHM5W9ACu+R5bT7l+cHnsl0uVpKcEcQ
 CU13M/mEDkRMjH56O4uqIjXzZ0l6j7GIf2Vfuh+Wkk/R28HcJJHvd7Nunow6kLFdSpfA
 LaPnbBIpGtXxVNMBjNdEMn69UR9b3iL1CRBjhPhikfEjTV70XLh/sUPwOsptn2STsmEN
 4H2Q==
X-Gm-Message-State: ACrzQf0oLH5GzsRxu2XmL9MlBAoAi2ALswQKIxaUCtKh1Sd7iUmNJxtD
 sGFwvrfTthBxqZ4uIimHHCmWTwgVfm/496VKhN81hULM
X-Google-Smtp-Source: AMsMyM6tla+KCY34G9edq4cM6sVPpdIfbC89Gxn4jmJP4/GxhQl0gl//5m7zoOE3QZYgE7pap4MxkbNVCZlgWPhi9iM=
X-Received: by 2002:a05:6808:1186:b0:353:b77a:a481 with SMTP id
 j6-20020a056808118600b00353b77aa481mr4735021oil.199.1665668854458; Thu, 13
 Oct 2022 06:47:34 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 13 Oct 2022 15:47:34 +0200
From: Stefan Kangas <stefankangas@HIDDEN>
X-Hashcash: 1:20:221013:control <at> debbugs.gnu.org::FBoK1Eo9tAHmgAM8:2VRW
MIME-Version: 1.0
Date: Thu, 13 Oct 2022 15:47:34 +0200
Message-ID: <CADwFkmmPbTOrSe1Z4aY_d6rH_L-AqjCY8g9uD4SCVe8y2khjvw@HIDDEN>
Subject: control message for bug #57635
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 57635 wishlist
quit

Last modified: Thu, 13 Oct 2022 14:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.